From nobody Fri Oct 2 08:25:34 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C5EC2DF13E for ; Mon, 3 Aug 2026 13:44:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785764642; cv=none; b=RC62TYbWFZnCM7jWqg+BRrn9QPayfkGhwhqsHU3kiZL+fWWL1ZnlNRVas5Qdl7K6gwRuY+3AzGDHSLUbP2e4TMl/PG7wSffRntjFAJHmZjQ/1jARkfWCPbe31zkG4rBz1gU/Bui3mIZuVSKWojH0DrawvunFRu5fWgzOQBy2v38= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785764642; c=relaxed/simple; bh=a4fUsm0sri2CJp9Xa6+EfCy3v837PLIvJct/CxDUWxw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dH7eECKfKGFsp9GU2NPtF/iq4eFA3u9HTtUK06X19SBfEiGCgGpd/HTZECdZIonhZEr0AKpcUxF+te+dUJnNNRBCb1dEHVlL5EXYpzKeyZgHYmMbJTkdYdNnu57+TqxlRzqsDqWSFxjQ9TS0nC9VWzlOlVFjS+QFNT8BEhlp3Sc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G4iXkmBJ; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G4iXkmBJ" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47de0093c42so2358467f8f.3 for ; Mon, 03 Aug 2026 06:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785764639; x=1786369439; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5Ovn4XB3GgCDHVcufiauy/1mVBNPpRS6FI6cibDiq4A=; b=G4iXkmBJ/ugmNIVrZJsuk7Cv04P75n2u36vrGAfeyBM/86kqAHOe5eohdjOrjpBkLo rSSIBZ/0DfgR1ItnU6yUuD/YJUigBzVgbqXNyhTOJH0NndtjkQpbnAQv3/MNjLiDiybZ YYy+fwSohYmZEZxXJ+MjDGC/LSli5lrmH0tliTFMXj0NyBJe0NYutl0s1ViniV2jh2al XJbOpiiOE+V0a+OXRaa/nfhbmzvie1loeH9g4brzwHundjBwBI8NdYGlyLZ4cxpq+eEp MPFouC/ZZk6gu3kxOxipcq1RPKbr7xatlTqXHEht+bJydBvG6eFpi3k7q8Pi+VppG0/+ FeVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785764639; x=1786369439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5Ovn4XB3GgCDHVcufiauy/1mVBNPpRS6FI6cibDiq4A=; b=TBA6X2Iq6C1T5/Y5IzdvUP6JU+KH/uxXBiFJif30YTujZzrT0Q5K1LfzO3VLy8nY/w aZKnUg9vT/eg50CQd+GAl6s1vvq7bK4gqv52lkAZn9nMbHkwciwHQHLUZ1+vdAEhMmV4 hEqvki5ohO5o7CZ/n8O6O36YLs3bH96KwaaFdtR7+B3Nxrqx0Xc3fEH1F1p/oe9O+8F5 Jg0EDta3t3gcj36LoYnL4HyHM6+hwvhM508x2JdX61RGh37Mwbzh0sXz1mQ//j3occsg YCMRL16Ix7yqaHiYzQ3HiJYqo53ECI9SJCTzQJVHWkoMOsanGh6nZZd2ldY9aBPTYZDz 40OA== X-Forwarded-Encrypted: i=1; AHgh+Roo4Yxej8Kc1+0RC3Ik7LE7lKBpTp+X1v3KTTsKYTfEL5ET1Q1wYg8QCJSYOq/e3HbgWcTqjYNWElS9nRg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywa0lCeeVlJ2vjAp6ESeEJ+Mts9Y2rVRE/YXoijr9+a8leoy6Eu 4n660yFgCzxtcvr3VSZQZKn8+f8YpdBAS6DKWRBy+IYqhuH/ec5DhWwX X-Gm-Gg: AR+sD128hmmGUfGdi00ablQyUA1zmlW2zED7aOiRashWbtRiF9GhDgY8IkfHSX6qDLG Ms9Hr+qqfBYcpTEHcVgZqrNCPLU5njcpkNoxOF+5LrpotXZtsa7fMpzcdpJcvgqmYHIyyqSFivE UyLORh4oGuTgAQMU2eSE1al3sRW+c7oBgiltDXbPIDRv1FunDlMoLskyMAmKo+YADnMwvNyZFvb kgvtvQwQrl/CKX1TdWEh+GfBGPT0ZNr3U571vAlDXcpj8nMaPvMh9tvMc+2AUZKaLH/etN0yvWH yX0M1VxHVfRtUcrms2D4YddQvIQIiocUXFxQk6FhIkg4Gx3IJHq2h0yip7G8QjFiQ6CdYB9tQP9 sLvnjlLkQskgFBGgesrx2tO/+fuZMkwuWrIWto7nFh4q0RCCb/6EmjLiQ13aFnOmZjbo8eSAWP0 mF2n8KAjvWhm/gr47xJb0nGPoDuRqUfFoz46vazSMtxnSpcvT5L2JTudLxp69y8yJA6989V9p2x TcpJt0w4Q== X-Received: by 2002:a05:6000:3102:b0:47f:5a97:2a63 with SMTP id ffacd0b85a97d-47fd729fce9mr28593445f8f.9.1785764638595; Mon, 03 Aug 2026 06:43:58 -0700 (PDT) Received: from fedora ([154.182.126.98]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd4068fb7sm34328908f8f.0.2026.08.03.06.43.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 06:43:58 -0700 (PDT) From: Abdelnasser Hussein To: jic23@kernel.org Cc: nuno.sa@analog.com, Michael.Hennerich@analog.com, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Abdelnasser Hussein , Dan Carpenter Subject: [PATCH v3 1/2] staging: greybus: audio_codec: fix sscanf return value check Date: Mon, 3 Aug 2026 16:43:43 +0300 Message-ID: <20260803134346.6733-2-abdelnasserhussein11@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260803134346.6733-1-abdelnasserhussein11@gmail.com> References: <20260803134346.6733-1-abdelnasserhussein11@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Smatch static checker warns: drivers/staging/greybus/audio_codec.c:335 gbaudio_module_update() warn: sscanf doesn't return error codes The sscanf() function returns the number of successfully matched input items, not a negative error code. Compare the return value directly with the expected number of conversions (3) instead of storing it in 'ret' and returning it as an error code, which leads to returning a positive value on failure. Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/YoOLnDkHgVltyXK7@kili/ Signed-off-by: Abdelnasser Hussein --- Changes in v3: - Split from the previous v2 patch into a separate patch. - Updated tags to properly credit Dan Carpenter for the smatch warning. drivers/staging/greybus/audio_codec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybu= s/audio_codec.c index 720aa752e17e..295222ec0f1a 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -311,8 +311,7 @@ int gbaudio_module_update(struct gbaudio_codec_info *co= dec, } =20 /* parse dai_id from AIF widget's stream_name */ - ret =3D sscanf(w->sname, "%s %d %s", intf_name, &dai_id, dir); - if (ret < 3) { + if (sscanf(w->sname, "%s %d %s", intf_name, &dai_id, dir) !=3D 3) { dev_err(codec->dev, "Error while parsing dai_id for %s\n", w->name); return -EINVAL; } --=20 2.54.0 From nobody Fri Oct 2 08:25:34 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1250240F726 for ; Mon, 3 Aug 2026 13:44:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785764650; cv=none; b=Ahd+mK6d5f6vu7A2pslutFRgD3up0nlMWXlMs0aXESbifQNpvefisM4SFmD0e8Nos9EWJ2PUjuJm2l3otkCHT1fLGLfQ7+0plzmuexe3Bldko/0o3XbB0woHVSm+IKDzF5OF5kbqNUcGpW+pQ4WGSV0Uh384nEquAdSgc7NSjI4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785764650; c=relaxed/simple; bh=YM8dfmlqxShxjvZGqRGiSNpTyF4I8DQHGxMXfAniN4Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I/HkW6tAi/ZfupNB4b8TLnSxzzsa0a2I5ZldOQiro7cuVaANgTmtQIuVF0Mqx3MhxEKadonqtCGCE+NTH1dbE/qqU4Ti88yqDz1HYn9trr4Yy7+9Vp0Rx7nUxJIs9TV+aNaBlMh/Kr6eXssW4mTs0frYonLDdwn3IWR7HwgCGAU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k63liqe2; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k63liqe2" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-47f84023916so3414052f8f.3 for ; Mon, 03 Aug 2026 06:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785764645; x=1786369445; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kDNUtFHnwjFHImwGnadLZYX2nGq1XShrI3jQKtCkmMY=; b=k63liqe26Fl8IPI3al0/6RKdWIV3N+CUBv5PvQQ1u8xlHB5hFfnW02YYzaQS6yX0v1 F7sQbslg0bM7DPqAaVedo3cKXtAf+trRfJz7xOfvb3ww731k77R794XbLoZedyaZ5vzt Lfi3tfM2PyZ6BzrClhYe4FbfhMa17pZWoFy7Vz4ENpi+PNUsnTvq1ah8cazYICd61zQD oN4q5dAeLH7pCdtvILvqY4t0oTMuFWIev2Dt9QmDnso1mwKyw9EmEO/I0ODsmlmovHtC pn5mPm0YK2s0+b2kquLA2EDhGesfgghh4+bzvkMqUi/UgLP33Jvtvuz3e2grp2eeFtIe Xj4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785764645; x=1786369445; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kDNUtFHnwjFHImwGnadLZYX2nGq1XShrI3jQKtCkmMY=; b=Sgyx4jF1V0tjVF3J8YMu0ZfwDeRKffIyCaYqMlocCJkmn6ahDjc+RmNgMIF5OtVuSl ERtMGBzSPzymBqUGagdXKGYfgiwJaAUSudI8u3ANkOM/SPraUZCCvRURrTU3RJ1TyrWn 5RKlPuE7o9Oy1PMBsQL7CWwQNPLEubuoI2b7PGBF7ZCIiO9owJLuE1v5sCufc30NsxFO K/omv4hwgGerjYhFz+UCbS4ZryKuDu7KkhwvV+qVEsXjo94y+Y1b+lPPb8PfwDzdN1a8 jKfvuIb9uxrF96MSiNXoj96YwUeNgtlnQMS2N3ZKGcqdz0ED5VU/2WmEV6qVJu0y7SUQ /3Pg== X-Forwarded-Encrypted: i=1; AHgh+Rplh9vIxulk9ibHdYwJFnwv7ZflC7TI6HUYuEYi6hJOxo1wKcVT0gkBB72pk8f/iDRzgSrOWK9WZqdQrjM=@vger.kernel.org X-Gm-Message-State: AOJu0YzbFrOsQzByJatDA8dZvjVMfsvb790rvcfJ2mopRWERlUps8K96 Vgvti9VqzrDMM9D+aykBq+yoFC4NQG6kQyA42UYDWt7966axtoIFHXbq9jQDAg== X-Gm-Gg: AR+sD11afJe+q397XAsaP8KwLTZ271SXqqo03bdVKv3nFSX4mQD+gtrt7du/FSXFIi+ dK1jB1inWJGcuDx8eYy825g25XFzuGgewpQ6kc1vKaU0VicEBq2ebmzhNzSOfCErfTGD8oeAJEz rB19EBtTag8YLCUB+TB57DolU1YgFMcJ5YfBGUCbUb2DZh+0Sm4QujqGygCfMFSTEnItx4mm4wq OJOKK81jbmLifb4fvqUr3tHJLlrosIKXW3H34/75UCh7rBGnAeqtP2pRIlYMiNNG+gdYVrW1nV9 vrWJfu2+zQ9DHvgV3Y1HK8QrLGD9FLg4kH8Jd2PsX+yFzBvv07dZJrVpbWNgbgKSH0N8j47K8Yp XBDjE/j5jHPP9gdJ8FIdfiF1kxhuAyRLWzqIjVHpJoTOAzgeVzdEx5djepy967ETX5Chwqvr8dZ hUHKAaa94BSAnvOoXF0QZeXPETUDjLeHodaCR+H6ihamJRuLysyhKJiJ/tvh4n9IS5rm/bWEj16 ZKBUXNIDg== X-Received: by 2002:a05:6000:2087:b0:47d:ea8a:d211 with SMTP id ffacd0b85a97d-47fd9f93ed8mr23273896f8f.29.1785764645563; Mon, 03 Aug 2026 06:44:05 -0700 (PDT) Received: from fedora ([154.182.126.98]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd4068fb7sm34328908f8f.0.2026.08.03.06.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 06:44:05 -0700 (PDT) From: Abdelnasser Hussein To: jic23@kernel.org Cc: nuno.sa@analog.com, Michael.Hennerich@analog.com, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Abdelnasser Hussein Subject: [PATCH v3 1/2] staging: iio: ad7816: serialize ad7816_spi_read() with a mutex Date: Mon, 3 Aug 2026 16:43:44 +0300 Message-ID: <20260803134346.6733-3-abdelnasserhussein11@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260803134346.6733-1-abdelnasserhussein11@gmail.com> References: <20260803134346.6733-1-abdelnasserhussein11@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ad7816_spi_read() path performs a sequence of SPI transfers and GPIO state changes that must not be interleaved with another read operation. Without serialization, concurrent callers can interfere with each other, leading to inconsistent device state and incorrect data being returned. Add a mutex to struct ad7816_chip_info and hold it across the entire read sequence to ensure exclusive access to the device. Signed-off-by: Abdelnasser Hussein --- drivers/staging/iio/adc/ad7816.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index 0e32a2295990..b5a0c2871e00 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -50,6 +50,7 @@ struct ad7816_chip_info { u8 oti_data[AD7816_CS_MAX + 1]; u8 channel_id; /* 0 always be temperature */ u8 mode; + struct mutex lock; /* protect device state during SPI transfers */ }; =20 enum ad7816_type { @@ -67,11 +68,14 @@ static int ad7816_spi_read(struct ad7816_chip_info *chi= p, u16 *data) int ret; __be16 buf; =20 + mutex_lock(&chip->lock); + gpiod_set_value(chip->rdwr_pin, 1); gpiod_set_value(chip->rdwr_pin, 0); ret =3D spi_write(spi_dev, &chip->channel_id, sizeof(chip->channel_id)); if (ret < 0) { dev_err(&spi_dev->dev, "SPI channel setting error\n"); + mutex_unlock(&chip->lock); return ret; } gpiod_set_value(chip->rdwr_pin, 1); @@ -94,11 +98,13 @@ static int ad7816_spi_read(struct ad7816_chip_info *chi= p, u16 *data) ret =3D spi_read(spi_dev, &buf, sizeof(*data)); if (ret < 0) { dev_err(&spi_dev->dev, "SPI data read error\n"); + mutex_unlock(&chip->lock); + return ret; } =20 *data =3D be16_to_cpu(buf); - + mutex_unlock(&chip->lock); return ret; } =20 @@ -359,7 +365,7 @@ static int ad7816_probe(struct spi_device *spi_dev) if (!indio_dev) return -ENOMEM; chip =3D iio_priv(indio_dev); - + mutex_init(&chip->lock); chip->spi_dev =3D spi_dev; for (i =3D 0; i <=3D AD7816_CS_MAX; i++) chip->oti_data[i] =3D 203; --=20 2.54.0 From nobody Fri Oct 2 08:25:34 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11CCF40F751 for ; Mon, 3 Aug 2026 13:44:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785764654; cv=none; b=No5SUMhJGJ4LbdZk6tEssV+zv1vmXxRel9Tqwn4w+l0KTXSuOsv7pEtb52gwiVuSlIuYK5Vtgzdw08xKRRZglXY6mbabLmU/efvsBnX28jpvWGhVkcAgImvfhg0f43+UmzBClvm4oc875ml4bRWGQhojFZb8jb4+/624DKtR8mo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785764654; c=relaxed/simple; bh=lhQg0++53cN6YWLsvuYUtWRHnABUxZRuUet4RxtPuNY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gPN6tIZLev/zAwVH7jAL2P+3CfRRXgZzWKV5AC0YpZzrXHudD7EBOrPhydgSq41dflQZRVAVX2doM7cCwOLy8Td1c7koUxU0EFiMONoKXj5lCeNiUzLLJtiiiRdMhBJMBBTdHHCr41CZBQepWS+PQssQgPhC2Y1k7pYuFhNgqUo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R7N4Ncjk; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R7N4Ncjk" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4954a9e8490so15520125e9.1 for ; Mon, 03 Aug 2026 06:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785764651; x=1786369451; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=opTcDvpoHFRHn9n+WZGobddkXtZDg7nJ4XpbwWq3BKs=; b=R7N4Ncjk7l42lOULN9LZzVTtMer4ESR+yo+rBJHGQakMHxDJT9RNth3+VZBilPT5sB LubDAM2o998ccbANNXaiiOcODa0LsVGiQFORJ9xTAqt3vWUjV0c7DtQfDzp/IAKEmZd3 XAQz2JPnILvaSfkRtAgr+Fh+GjwSKZMu+VNzK5iM1d3zFyZjOxLdWc1sCs8NwfhguVFJ xbFZWnMaUhnFm3WDObv51l2G5OErByjLpdhJlRMTFg5DlF7MsNMh1KOFs1dzNPamInC1 M1jNxwEhQY2K+dWedFQlTNYKGyx7P2YLbzs66UbmxBBDYydzSv+M/s2sHoNvTR015eff RQ0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785764651; x=1786369451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=opTcDvpoHFRHn9n+WZGobddkXtZDg7nJ4XpbwWq3BKs=; b=VX6hgQN3tuzGOX/PVMzM/GZ9kNW2q+5l5hVeJ8+Bh7gExjthBXzjfIxvW3SK2JNdw8 1EZr5ajxcnXKjjX6cHQOGrRgMP2vQRJB6jelG5NizIqIAkcWUhoShhgGQNROY0rh1O+Y vGOHlDQzv8akCZv/3XYuprXkMUvjI1Z36I5klkDIy27uLMzykI6eL8MLo5QmNOAVtlQg TimOZMJBfNTBJwJAjPcASIS9jwb0suyiEx1Zm3GZmyLdiCO1+UHoziJwnlZBTSwPKzDR MLxa/wgR/njErQtESJfT2mzYc73nTFQKjUHZa7azVBngq0XJ/CoHyCSLmAx1z0WS7/3f t7iA== X-Forwarded-Encrypted: i=1; AHgh+RqK+ANwHVCtJGxB464E/t3BcZljxtMqIZS4k1BWNV0p2oypQZB6PMB4z/enA4yNK/lgnSvoUaAZSNqKr68=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0P4Te1sMCXetMttpvD4Frung1QLvvYdbQYLQGCHP5EneZj708 fOxneT08WfKy3JeI5axPBkKoy8aG0BuTasH4hQoPmVLGp+tK/4cK1uAK X-Gm-Gg: AR+sD12+59YinHI48OZKy688C+A3XFh4Y04VRT8J6HSr1vg7JJg95eo7BVS6zL9NBy5 bbC4Ii0ytz/onKCdq4taOr1byPi8KzPuH2aj1wUvid/lIeQEKv4/Kjafw4dt3IPHwbml4oiYTtY OwP8aO+zx8n4utm42tvrvJBf5AJlfM8CnizMSbnlX46MPR2/PYe/VeuDLmrTPjJFYQdL5PHgH/X hX0FzcnV7bZF7khAMQ9sMqdP2kT2k5va1toiHyPxAEG+6e68WLyy06Pm8PpmfbhI3uHi2mnpvGt 0guMEmlK9Lr9BrW38UEg8phZaIK8xE2j8eRaYytJxyJ8sRx2vpEE9+9IuVumQb9uq69LMbHc8Af BE37ta+AkwGggWR1LGEPF43jiLXLyDsH9ZY6frVT2DUzy3RI9xX4FuNbj9dO5cWYo9zcuzNB9PF InulPhHaEDla9OSzhtpbo85Si2v3UNNbUB7lLZa/NpfMgHpe8bipdS3FAKARbFMl0WWT8i6XEc5 z2PC4QsiQ== X-Received: by 2002:a05:6000:1846:b0:47f:6e8b:699c with SMTP id ffacd0b85a97d-47fd729208fmr23158328f8f.14.1785764651304; Mon, 03 Aug 2026 06:44:11 -0700 (PDT) Received: from fedora ([154.182.126.98]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd4068fb7sm34328908f8f.0.2026.08.03.06.44.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 06:44:10 -0700 (PDT) From: Abdelnasser Hussein To: jic23@kernel.org Cc: nuno.sa@analog.com, Michael.Hennerich@analog.com, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Abdelnasser Hussein , kernel test robot Subject: [PATCH v3 2/2] staging: greybus: audio_codec: remove redundant else-if check Date: Mon, 3 Aug 2026 16:43:45 +0300 Message-ID: <20260803134346.6733-4-abdelnasserhussein11@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260803134346.6733-1-abdelnasserhussein11@gmail.com> References: <20260803134346.6733-1-abdelnasserhussein11@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In gbaudio_module_update(), the widget id is validated earlier in the function to ensure it is either snd_soc_dapm_aif_in or snd_soc_dapm_aif_out. Remove the redundant else-if check for snd_soc_dapm_aif_out. The remaining branch can only handle snd_soc_dapm_aif_out, which avoids a compiler warning about a potentially uninitialized variable. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202606140347.gGVWDnbi-lkp@int= el.com/ Signed-off-by: Abdelnasser Hussein --- Changes in v3: - Split from the previous v2 patch to address the uninitialized variable warning separately. drivers/staging/greybus/audio_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybu= s/audio_codec.c index 295222ec0f1a..6daa4e706792 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -322,7 +322,7 @@ int gbaudio_module_update(struct gbaudio_codec_info *co= dec, ret =3D gbaudio_module_enable_tx(codec, module, dai_id); else ret =3D gbaudio_module_disable_tx(module, dai_id); - } else if (w->id =3D=3D snd_soc_dapm_aif_out) { + } else { if (enable) ret =3D gbaudio_module_enable_rx(codec, module, dai_id); else --=20 2.54.0 From nobody Fri Oct 2 08:25:34 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0C1C3E5A20 for ; Mon, 3 Aug 2026 13:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785764667; cv=none; b=M1Moa5isO0Zw8Ej0wxqAkn9HrgxtWp6vH7BYsRoyN8bpQhy+nMX77NodQDGGd6MIzguShV7n+Gsl6UewvQB6lImR9kbb4pwBkqze1YNqcsZrdfaqjTdj2o7NnLShHXzf7NoHarbzNvh5mqdsFPP23UvO3mNJWGCYx7wwzIrrh1w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785764667; c=relaxed/simple; bh=KbuAVltrdpgoTAsog3bNgHW9HPKgi7jzMUcqoyvahh8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FAirMntNeXH9bL5jMyPz4Vh8s4pbQuWrKNDTVpvRMPwuadKesOyaBpEVDuhj9/3by14SKhKi4NIp9PPFy607IR/OnYC/iTWa97z+Jaf4SvEV+MdrZXG0Ervw1CkkSEAnctoA2abA/gXDSmFGvtWIkkIK5UGTSa5FwaQVRBuh4OQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B2TvBU9N; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B2TvBU9N" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-490cf322ed0so11586165e9.1 for ; Mon, 03 Aug 2026 06:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785764664; x=1786369464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0KbS3mbw078LtlagODYtZipKV9fmkHUKkmrW3T3OnxI=; b=B2TvBU9N5dqvJ+vEFjS9UOQeMrzU0vmvTsM7u/WVrW1gkDakdfuFHmHxE7aWF+OMXl kLeCcrDPrfnnUbb1knjd6d4u77DN7mpQTWjC11aniV48YngO/mh/AdlnlpZPn3+oj+VR FeZdtKOW06POiAQDIzeGHNbQ5lcasEUK2aJGEiDt61va+SSIN+ZSNPLpNejpEb0pQKQ1 i9OQjZ+arAMrqwyh1gBEtMyDK54w/jwBZrfhwdugrV68n9ylWYq9YqulOkdhQ9NhZ8qI kDCLQIScSdgU4JSBndK/iL2rQijf3hCWrPYSrdGH8YTi75x8A9+jFtEEPQ0iC7LqicGx v2AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785764664; x=1786369464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0KbS3mbw078LtlagODYtZipKV9fmkHUKkmrW3T3OnxI=; b=qkOuwkQZuRZ89r6i2tK9/1N7y0V/AFxfIEMPNjLRrzPlctg2p5ujRtKnkYZFmGY4va wIQ0oMGmpNVjTCr55VF5H8By6SOzmob5URlFKoCHpn9A8vqmBJRfWE9TFpWwqztmJNgl wD/IwtJkvYUoVa887GZR6zyMwjwsIL6zYZtODzWh2zZqXiUIoI1MwoMErjYIaZYw26o4 5yhTlOaM+P0nMKZBGTgXSRF1Rbzz0Vz37H4yKIChcuj+H8O5Eb2mUqlx+p2Ed+JNdwCt qJZu0cDez3D3KLDAuXnRzc9k6yy/2TppGlrYxJ3tOvxDUVgbp3zQrEam0JQR5H9DE5tZ emQw== X-Forwarded-Encrypted: i=1; AHgh+RpDZlhdkyHy3LxXVMZdkAO7DvVXgk5yauXHUu+hFTdPONhsIrkt0/hCAIGb7Q1FXy7K6mA25Sogy3KRpLo=@vger.kernel.org X-Gm-Message-State: AOJu0Ywxg9JET8d5ebNilga3NIOzkY89j3HMm2hprz/i6/VE9dyI+TEC neAnOhDo+MEFmC+MSOUwfy7e6lDPCPZy5Gzwf1g6VJluTXA8s5OAKq4w X-Gm-Gg: AR+sD13zrPgenZu+dyLiye6UKxe5t/hby+la77+9W7qR5UsI0THTUXxYOQWPbOcHybE Sd+v8EhwrAzvWHg7yIAy0DUhvKPI0nSVJ1D/VhZEAjzu0zG/RrCarn5LOdWsFkpbI3bH8BcCwcj 6hMY+4pb0w+5T6Oz+Y76t35wZSSB4dCRS8vsMPd3CKfcsodyjvxmxndkE9SYNo4iZaVfIlykVhi 4/76Vbb5WQSQKPfFRBfQ3nBy3kgGD2cQ0AamW+SsUNi86HNjEqb4VhrVVjGdH2Ksp9E+gS5IuC5 48aeZrcwP2f+kTzN2ESzxtTzlH0/yfqBP9NAUMlNuZQxCIHwvxhkxBsJqDUYbwqQbItjS9/s87N 6esnJGRzPUYgAjtVD3Vf1vj4RIchFnqNGmwMbHk5TYjg6YNjIweTAb5kOqee8Xl0py5jf8XTgCb uM0os8p3cR4lay0DZN7/zi+ppifw0It9780XHnME2CuxZRDl79AUZ8qQ2hzf5CTPO0y1X66rOwd LC8tYTPxQ== X-Received: by 2002:a05:600c:3550:b0:495:607e:5ee7 with SMTP id 5b1f17b1804b1-4980c679513mr223092645e9.17.1785764663678; Mon, 03 Aug 2026 06:44:23 -0700 (PDT) Received: from fedora ([154.182.126.98]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd4068fb7sm34328908f8f.0.2026.08.03.06.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 06:44:23 -0700 (PDT) From: Abdelnasser Hussein To: jic23@kernel.org Cc: nuno.sa@analog.com, Michael.Hennerich@analog.com, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Abdelnasser Hussein Subject: [PATCH v3 2/2] staging: iio: ad7816: avoid DMA from stack in spi_read Date: Mon, 3 Aug 2026 16:43:46 +0300 Message-ID: <20260803134346.6733-5-abdelnasserhussein11@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260803134346.6733-1-abdelnasserhussein11@gmail.com> References: <20260803134346.6733-1-abdelnasserhussein11@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The SPI transfer buffer is allocated on the stack, which is unsafe when the SPI core performs DMA transfers. With VMAP_STACK enabled, this can lead to DMA mapping failures because the stack is not guaranteed to be DMA-accessible. Move the buffer into struct ad7816_chip_info to provide storage with an appropriate lifetime for DMA, align it with __aligned(IIO_DMA_MINALIGN), and update the spi_read() sizeof() argument to reference the relocated buffer. Fixes: 7924425db04a ("staging: iio: adc: new driver for AD7816 devices") Signed-off-by: Abdelnasser Hussein --- drivers/staging/iio/adc/ad7816.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index b5a0c2871e00..c58a6bf77020 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -51,6 +51,7 @@ struct ad7816_chip_info { u8 channel_id; /* 0 always be temperature */ u8 mode; struct mutex lock; /* protect device state during SPI transfers */ + __be16 rx_buf __aligned(IIO_DMA_MINALIGN); }; =20 enum ad7816_type { @@ -66,7 +67,6 @@ static int ad7816_spi_read(struct ad7816_chip_info *chip,= u16 *data) { struct spi_device *spi_dev =3D chip->spi_dev; int ret; - __be16 buf; =20 mutex_lock(&chip->lock); =20 @@ -95,7 +95,7 @@ static int ad7816_spi_read(struct ad7816_chip_info *chip,= u16 *data) =20 gpiod_set_value(chip->rdwr_pin, 0); gpiod_set_value(chip->rdwr_pin, 1); - ret =3D spi_read(spi_dev, &buf, sizeof(*data)); + ret =3D spi_read(spi_dev, &chip->rx_buf, sizeof(chip->rx_buf)); if (ret < 0) { dev_err(&spi_dev->dev, "SPI data read error\n"); mutex_unlock(&chip->lock); @@ -103,7 +103,7 @@ static int ad7816_spi_read(struct ad7816_chip_info *chi= p, u16 *data) return ret; } =20 - *data =3D be16_to_cpu(buf); + *data =3D be16_to_cpu(chip->rx_buf); mutex_unlock(&chip->lock); return ret; } --=20 2.54.0