From nobody Fri Oct 2 07:47:37 2026 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 708F23C6600 for ; Mon, 3 Aug 2026 18:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785783471; cv=none; b=uyCZcPWmTa+Tb+foL8TjbK6hCSWPqXjSy2rgRZavjY+FIkas/3SOtI8H5rNlDAb53H2XFqzjsv0pUtliUnK+yOmuzpW7e3HB0tuL2PjuZGaSCwlPQQBWZEidoOJBWSf9j5n6wXYUlHuxb6DckIDyTToTsvo0TlXA/lV6oCQY3l4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785783471; c=relaxed/simple; bh=EAnLkUzD/jak0hj55ek8FaJpcs1PSsPCAlouMNxHBzM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=YysuvYxozYDe5FmWiwQdOUca5R4EkTaDSNmSJw/EocWT7EZ32gyQGdeQNT43/90jMBI1oCuSu8Hg/gJuTFM5rMZOODj8Zj13nCoIhuiavVdFC2RWWNpIKxfgSZ3ZgN0xGSabkyIyo6KzkVTBei0GVjh/oXiU9GIfs3s1opk4LbU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marliere.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=marliere.net header.i=@marliere.net header.b=iT0mmCuX; arc=none smtp.client-ip=209.85.210.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marliere.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marliere.net header.i=@marliere.net header.b="iT0mmCuX" Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-7eb5bdb50fcso2452749a34.1 for ; Mon, 03 Aug 2026 11:57:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785783468; x=1786388268; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lcHoPJWnPgEgMutYYZSf0CmDCVCUMwS4dztIBV+3zoI=; b=I4L8i/4BtHX13KUhToIMwn5psBjgtuydQzLM+3Hi+3UBeEOG5OlKGY0cpoDFnXqo+b Sdbi70iFbqw3ouH3SRRlIgBFcKGQA/MQ1MKtdiGCflxL5gWITUQ5BY74m47kWF4XcGVk seFSopQHvJkqPtnMGFEdIInyISSg2KQp7+Xk3D0ma5txyaieYc8I58S5n0AvC1VP4X+t HBap981H50Tg6l/lU5SVEl9oFgBzusuIuNGpsrhHNVLLG2LOhL8OzEBEhMuRo0pwxs0F iOW/cJ7FUyjStkupu1/mj2bX1TPwFtVVqlteWR3c6i2vSENJORKSsJo0PbjUBcax2C29 CbKA== X-Gm-Message-State: AOJu0YysMrTPiTO6j1GpVrRcoB70fYpJ020TWr8kq2SMPO5bDmEv/464 W9LYItjP0jRqxtxyRRCsFNcBCAnXBfbscF4mOQhWuz7sSg3PK6UKWr51 X-Gm-Gg: AR+sD13y+WdylWfoVFEqoWaHNrDRG/nscTTkpk28SJW/CokQtvgRd0sat7H6buPHE4T U3cTtTB1RBk8qlX26+J6aAj4ZGteXjnvJ4T3uNhVB8/fAYEe17hC4KVkQzw14MBeRdzX+86Qx6k mtp5hEtx0DF7XgxAtlsFT1vElKoKk3nMS6s7YDMI9OXhjmyoTMGPHlduI24OF+s3hPQ8dL2WM8Q eYUhgwDPo4RLM4FJonjRAJFAmvutGiv+KefzsU7uTHa02s1Gl5U52BIP0OLIntD+PW6/PQrgPsC UDGLOh748OPk/uHbXKuv0mukcHyAmbXtomcFmHEmJHyi21RSQtFvZKfdqrGmFGXIcI/l3xKqQPZ ANtqzvxx2PedW3XO9jH1EdY3sfskwpKrRBWOwz02dP8ucvNmeFLT/1wup7Nw8YJdoN5YPpmkpa1 0/P/mvq31t2WsSd62LGw53rvYaV0C4I7ZQeUAV4pg0l45r6wIjPzoIAnMdueCYagoqOETm5Ew0n 2pZhNfWdplfsMEc0EQNHWXGWCBcUFUysP5bGnAJRSXq2X6gyo/9dA9Xa+gyoDMfdQ== X-Received: by 2002:a05:6830:700c:b0:7df:5fc:3fd5 with SMTP id 46e09a7af769-7f196b97f19mr19782181a34.1.1785783468210; Mon, 03 Aug 2026 11:57:48 -0700 (PDT) Received: from mail.marliere.net (137.65.66.34.bc.googleusercontent.com. [34.66.65.137]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f18f0da951sm7885452a34.24.2026.08.03.11.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 11:57:47 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7274160CD1; Mon, 3 Aug 2026 18:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marliere.net; s=dkim; t=1785783465; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding; bh=lcHoPJWnPgEgMutYYZSf0CmDCVCUMwS4dztIBV+3zoI=; b=iT0mmCuXCnmL8iTlj47goISnaeeghCP8cxhqJnfAmdE2z/81u6/B/W4GIS9qaJvYZexYV0 XkE4UDmFyG4FMtiAIJCGQtfE3pVjhuLUrFEexs2vZIkGGGrUZBQoRrRkPk1pPRxadY1+C8 UxLmEcK0AUdPxiP8byNydgI8u6QWtn7qPB/MOA8jIrewb1Tm/xLz0AUIsUUXedTfZxZnMO Tb8EXT/2Qn88VPWOXmKh9PIrb3Tcs5EYncztyLRG6DdBRdXuBk9S5TjE/aqhAsk05UiZpr nzwixPqTLsZiA22GHvZEdjNaRBjl47mieFibuuIWWQK0jd0lC9CHz8s1TyfbEQ== From: =?utf-8?q?Ricardo_B=2E_Marli=C3=A8re_=28SUSE=29?= Date: Mon, 03 Aug 2026 15:57:32 -0300 Subject: [PATCH 7.1.y] selftests/bpf: Add tests for sleepable tracepoint programs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260803-selftests-bpf-sleepable-v1-1-dc4cb88374e9@marliere.net> X-B4-Tracking: v=1; b=H4sIAJvkcGoC/yWMWw7CIBREt9Lcb2kAk/rYivED6GAxBAkXjabp3 gX9PCczZyVGCWA6DysVvAKHR2qgdgO5xaQbRJgbk5Z6kke5F4zoK7iysNkLjkA2NkIA1uv5NGk tFbV3LvDh/Stf6DCq8UPXv+anvcPVXu1DaxjCFpPc0hXXnqNt+wKn6H/JmwAAAA== X-Change-ID: 20260803-selftests-bpf-sleepable-eebf2d962201 To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Kumar Kartikeya Dwivedi , Song Liu , Yonghong Song , Jiri Olsa , Shuah Khan Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Mykyta Yatsenko , =?utf-8?q?Ricardo_B=2E_Marli=C3=A8re_=28SUSE=29?= X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openssh-sha256; t=1785783453; l=10993; i=ricardo@marliere.net; h=from:subject:message-id; bh=nYxKjXWof+q7Tycv1IRGu/Vn8ITWdIxa0qhQDccaG+w=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgguRCc5X8/UX9M40lkMnr//aFGOhce x5ezt8MFNUFlqYAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QPvYdeSRW8R5oNioGDKpEYp67s5aOfQ3kh85ecMqEKbN9smSR/O+KIzIda/xGvSYkM9C3OGT1de wUD1YcI/Esgc= X-Developer-Key: i=ricardo@marliere.net; a=openssh; fpr=SHA256:pzhe0fJpYLz+3cZ33FFPhIfaUElk9CXPFFXmalIH+1g X-Last-TLS-Session-Version: TLSv1.3 From: Mykyta Yatsenko From: Mykyta Yatsenko [ Upstream commit 8a20655749c625dcc4debdfdeeaa0cf8bb85c203 ] Cover all three sleepable tracepoint types (tp_btf.s, raw_tp.s, tp.s) and sys_exit (via bpf_task_pt_regs) with functional tests using bpf_copy_from_user() on getcwd. Verify alias and bare SEC variants, bpf_prog_test_run_raw_tp() with BPF_F_TEST_RUN_ON_CPU rejection, attach-time rejection on non-faultable tracepoints, and load-time rejection for sleepable tp_btf on non-faultable tracepoints. Signed-off-by: Mykyta Yatsenko Acked-by: Kumar Kartikeya Dwivedi Link: https://lore.kernel.org/bpf/20260422-sleepable_tracepoints-v13-6-9900= 5dff21ef@meta.com Signed-off-by: Kumar Kartikeya Dwivedi --- Signed-off-by: Ricardo B. Marli=C3=A8re (SUSE) --- .../bpf/prog_tests/sleepable_tracepoints.c | 142 +++++++++++++++++= ++++ .../bpf/progs/test_sleepable_tracepoints.c | 112 ++++++++++++++++ .../bpf/progs/test_sleepable_tracepoints_fail.c | 18 +++ tools/testing/selftests/bpf/verifier/sleepable.c | 17 ++- 4 files changed, 287 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/sleepable_tracepoints.c= b/tools/testing/selftests/bpf/prog_tests/sleepable_tracepoints.c new file mode 100644 index 000000000000..19500b785ee3 --- /dev/null +++ b/tools/testing/selftests/bpf/prog_tests/sleepable_tracepoints.c @@ -0,0 +1,142 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2025 Meta Platforms, Inc. and affiliates. */ + +#include +#include +#include "test_sleepable_tracepoints.skel.h" +#include "test_sleepable_tracepoints_fail.skel.h" + +static void run_test(struct test_sleepable_tracepoints *skel) +{ + char buf[PATH_MAX] =3D "/"; + + skel->bss->target_pid =3D getpid(); + skel->bss->prog_triggered =3D 0; + skel->bss->err =3D 0; + skel->bss->copied_byte =3D 0; + + syscall(__NR_getcwd, buf, sizeof(buf)); + + ASSERT_EQ(skel->bss->prog_triggered, 1, "prog_triggered"); + ASSERT_EQ(skel->bss->err, 0, "err"); + ASSERT_EQ(skel->bss->copied_byte, '/', "copied_byte"); +} + +static void run_auto_attach_test(struct bpf_program *prog, + struct test_sleepable_tracepoints *skel) +{ + struct bpf_link *link; + + link =3D bpf_program__attach(prog); + if (!ASSERT_OK_PTR(link, "prog_attach")) + return; + + run_test(skel); + bpf_link__destroy(link); +} + +static void test_attach_only(struct bpf_program *prog) +{ + struct bpf_link *link; + + link =3D bpf_program__attach(prog); + if (ASSERT_OK_PTR(link, "attach")) + bpf_link__destroy(link); +} + +static void test_attach_reject(struct bpf_program *prog) +{ + struct bpf_link *link; + + link =3D bpf_program__attach(prog); + if (!ASSERT_ERR_PTR(link, "attach_should_fail")) + bpf_link__destroy(link); +} + +static void test_raw_tp_bare(struct test_sleepable_tracepoints *skel) +{ + struct bpf_link *link; + + link =3D bpf_program__attach_raw_tracepoint(skel->progs.handle_raw_tp_bar= e, + "sys_enter"); + if (ASSERT_OK_PTR(link, "attach")) + bpf_link__destroy(link); +} + +static void test_tp_bare(struct test_sleepable_tracepoints *skel) +{ + struct bpf_link *link; + + link =3D bpf_program__attach_tracepoint(skel->progs.handle_tp_bare, + "syscalls", "sys_enter_getcwd"); + if (ASSERT_OK_PTR(link, "attach")) + bpf_link__destroy(link); +} + +static void test_test_run(struct test_sleepable_tracepoints *skel) +{ + __u64 args[2] =3D {0x1234ULL, 0x5678ULL}; + LIBBPF_OPTS(bpf_test_run_opts, topts, + .ctx_in =3D args, + .ctx_size_in =3D sizeof(args), + ); + int fd, err; + + fd =3D bpf_program__fd(skel->progs.handle_test_run); + err =3D bpf_prog_test_run_opts(fd, &topts); + ASSERT_OK(err, "test_run"); + ASSERT_EQ(topts.retval, args[0] + args[1], "test_run_retval"); +} + +static void test_test_run_on_cpu_reject(struct test_sleepable_tracepoints = *skel) +{ + __u64 args[2] =3D {}; + LIBBPF_OPTS(bpf_test_run_opts, topts, + .ctx_in =3D args, + .ctx_size_in =3D sizeof(args), + .flags =3D BPF_F_TEST_RUN_ON_CPU, + ); + int fd, err; + + fd =3D bpf_program__fd(skel->progs.handle_test_run); + err =3D bpf_prog_test_run_opts(fd, &topts); + ASSERT_ERR(err, "test_run_on_cpu_reject"); +} + +void test_sleepable_tracepoints(void) +{ + struct test_sleepable_tracepoints *skel; + + skel =3D test_sleepable_tracepoints__open_and_load(); + if (!ASSERT_OK_PTR(skel, "open_and_load")) + return; + + if (test__start_subtest("tp_btf")) + run_auto_attach_test(skel->progs.handle_sys_enter_tp_btf, skel); + if (test__start_subtest("raw_tp")) + run_auto_attach_test(skel->progs.handle_sys_enter_raw_tp, skel); + if (test__start_subtest("tracepoint")) + run_auto_attach_test(skel->progs.handle_sys_enter_tp, skel); + if (test__start_subtest("sys_exit")) + run_auto_attach_test(skel->progs.handle_sys_exit_tp, skel); + if (test__start_subtest("tracepoint_alias")) + test_attach_only(skel->progs.handle_sys_enter_tp_alias); + if (test__start_subtest("raw_tracepoint_alias")) + test_attach_only(skel->progs.handle_sys_enter_raw_tp_alias); + if (test__start_subtest("raw_tp_bare")) + test_raw_tp_bare(skel); + if (test__start_subtest("tp_bare")) + test_tp_bare(skel); + if (test__start_subtest("test_run")) + test_test_run(skel); + if (test__start_subtest("test_run_on_cpu_reject")) + test_test_run_on_cpu_reject(skel); + if (test__start_subtest("raw_tp_non_faultable")) + test_attach_reject(skel->progs.handle_raw_tp_non_faultable); + if (test__start_subtest("tp_non_syscall")) + test_attach_reject(skel->progs.handle_tp_non_syscall); + if (test__start_subtest("tp_btf_non_faultable_reject")) + RUN_TESTS(test_sleepable_tracepoints_fail); + + test_sleepable_tracepoints__destroy(skel); +} diff --git a/tools/testing/selftests/bpf/progs/test_sleepable_tracepoints.c= b/tools/testing/selftests/bpf/progs/test_sleepable_tracepoints.c new file mode 100644 index 000000000000..254f7fd895d9 --- /dev/null +++ b/tools/testing/selftests/bpf/progs/test_sleepable_tracepoints.c @@ -0,0 +1,112 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2025 Meta Platforms, Inc. and affiliates. */ + +#include +#include +#include +#include +#include + +char _license[] SEC("license") =3D "GPL"; + +int target_pid; +int prog_triggered; +long err; +char copied_byte; + +static int copy_getcwd_arg(char *ubuf) +{ + err =3D bpf_copy_from_user(&copied_byte, sizeof(copied_byte), ubuf); + if (err) + return err; + + prog_triggered =3D 1; + return 0; +} + +SEC("tp_btf.s/sys_enter") +int BPF_PROG(handle_sys_enter_tp_btf, struct pt_regs *regs, long id) +{ + if ((bpf_get_current_pid_tgid() >> 32) !=3D target_pid || + id !=3D __NR_getcwd) + return 0; + + return copy_getcwd_arg((void *)PT_REGS_PARM1_SYSCALL(regs)); +} + +SEC("raw_tp.s/sys_enter") +int BPF_PROG(handle_sys_enter_raw_tp, struct pt_regs *regs, long id) +{ + if ((bpf_get_current_pid_tgid() >> 32) !=3D target_pid || + id !=3D __NR_getcwd) + return 0; + + return copy_getcwd_arg((void *)PT_REGS_PARM1_CORE_SYSCALL(regs)); +} + +SEC("tp.s/syscalls/sys_enter_getcwd") +int handle_sys_enter_tp(struct syscall_trace_enter *args) +{ + if ((bpf_get_current_pid_tgid() >> 32) !=3D target_pid) + return 0; + + return copy_getcwd_arg((void *)args->args[0]); +} + +SEC("tp.s/syscalls/sys_exit_getcwd") +int handle_sys_exit_tp(struct syscall_trace_exit *args) +{ + struct pt_regs *regs; + + if ((bpf_get_current_pid_tgid() >> 32) !=3D target_pid) + return 0; + + regs =3D (struct pt_regs *)bpf_task_pt_regs(bpf_get_current_task_btf()); + return copy_getcwd_arg((void *)PT_REGS_PARM1_CORE_SYSCALL(regs)); +} + +SEC("raw_tp.s") +int BPF_PROG(handle_raw_tp_bare, struct pt_regs *regs, long id) +{ + return 0; +} + +SEC("tp.s") +int handle_tp_bare(void *ctx) +{ + return 0; +} + +SEC("tracepoint.s/syscalls/sys_enter_getcwd") +int handle_sys_enter_tp_alias(struct syscall_trace_enter *args) +{ + return 0; +} + +SEC("raw_tracepoint.s/sys_enter") +int BPF_PROG(handle_sys_enter_raw_tp_alias, struct pt_regs *regs, long id) +{ + return 0; +} + +SEC("raw_tp.s/sys_enter") +int BPF_PROG(handle_test_run, struct pt_regs *regs, long id) +{ + if ((__u64)regs =3D=3D 0x1234ULL && (__u64)id =3D=3D 0x5678ULL) + return (__u64)regs + (__u64)id; + + return 0; +} + +SEC("raw_tp.s/sched_switch") +int BPF_PROG(handle_raw_tp_non_faultable, bool preempt, + struct task_struct *prev, struct task_struct *next) +{ + return 0; +} + +SEC("tp.s/sched/sched_switch") +int handle_tp_non_syscall(void *ctx) +{ + return 0; +} diff --git a/tools/testing/selftests/bpf/progs/test_sleepable_tracepoints_f= ail.c b/tools/testing/selftests/bpf/progs/test_sleepable_tracepoints_fail.c new file mode 100644 index 000000000000..1a0748a9520b --- /dev/null +++ b/tools/testing/selftests/bpf/progs/test_sleepable_tracepoints_fail.c @@ -0,0 +1,18 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2025 Meta Platforms, Inc. and affiliates. */ + +#include +#include +#include +#include "bpf_misc.h" + +char _license[] SEC("license") =3D "GPL"; + +/* Sleepable program on a non-faultable tracepoint should fail to load */ +SEC("tp_btf.s/sched_switch") +__failure __msg("Sleepable program cannot attach to non-faultable tracepoi= nt") +int BPF_PROG(handle_sched_switch, bool preempt, + struct task_struct *prev, struct task_struct *next) +{ + return 0; +} diff --git a/tools/testing/selftests/bpf/verifier/sleepable.c b/tools/testi= ng/selftests/bpf/verifier/sleepable.c index c2b7f5ebf168..6dabc5522945 100644 --- a/tools/testing/selftests/bpf/verifier/sleepable.c +++ b/tools/testing/selftests/bpf/verifier/sleepable.c @@ -76,7 +76,20 @@ .runs =3D -1, }, { - "sleepable raw tracepoint reject", + "sleepable raw tracepoint accept", + .insns =3D { + BPF_MOV64_IMM(BPF_REG_0, 0), + BPF_EXIT_INSN(), + }, + .prog_type =3D BPF_PROG_TYPE_TRACING, + .expected_attach_type =3D BPF_TRACE_RAW_TP, + .kfunc =3D "sys_enter", + .result =3D ACCEPT, + .flags =3D BPF_F_SLEEPABLE, + .runs =3D -1, +}, +{ + "sleepable raw tracepoint reject non-faultable", .insns =3D { BPF_MOV64_IMM(BPF_REG_0, 0), BPF_EXIT_INSN(), @@ -85,7 +98,7 @@ .expected_attach_type =3D BPF_TRACE_RAW_TP, .kfunc =3D "sched_switch", .result =3D REJECT, - .errstr =3D "Only fentry/fexit/fsession/fmod_ret, lsm, iter, uprobe, and = struct_ops programs can be sleepable", + .errstr =3D "Sleepable program cannot attach to non-faultable tracepoint", .flags =3D BPF_F_SLEEPABLE, .runs =3D -1, }, --- base-commit: c7d419828268d5f3e52b74506d074955ad8c01d1 change-id: 20260803-selftests-bpf-sleepable-eebf2d962201 Best regards, -- =20 Ricardo B. Marli=C3=A8re (SUSE)