From nobody Fri Oct 2 08:31:20 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B371E33A715; Mon, 3 Aug 2026 15:04:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785769443; cv=none; b=ZRoycrHJAkugP36aOotmqrHidPmTB2DqsghseEY0SwxIWbhVhw8g2ipSRlymAioIl1OZi2Z4PMxm6l2IGso5j6ggmtdzjpoWQmT/2cs1qVm/R2gsSdmplkGK63MK3xzJeMNQMwp2Yny8gkktpxqA8XrXpiAAlZxh7oX9bux9zzw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785769443; c=relaxed/simple; bh=I9kKXk45Fx/bC1i8ICXNMpf3fIxhgN36l0pxu7VEFCg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GI15q/ElbuHguR0uJBKNJg8jSQarXh6ju3h5FqryEG5J/+s6GXs7ld6BXfUweToYsrp4aPuB9TpjimcHOlwWGe4BjiYgVhAk2nw1yJtsX+Ala0MaBXYFWsZm4kbxnfOTftsM2M0VRdvLVGEl1qREKYCknRisnf2CcnRtNlCvdLk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WJJKTeFb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WJJKTeFb" Received: by smtp.kernel.org (Postfix) with ESMTPS id 3F3DDC2BCF6; Mon, 3 Aug 2026 15:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1785769443; bh=I9kKXk45Fx/bC1i8ICXNMpf3fIxhgN36l0pxu7VEFCg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=WJJKTeFbjhnqwWG/X46/QAS5mQf8EktsbriUyTndFRjzTppL6XxDGzhM8W23qvV7S swL5werVEHf40Nl9g+cyqUNX1vYvomucGx1u9JPxgnLcube3UH6Jkxco61/6qhGr1s pc9EmP/XrHZkaoxdoRvr8stuq0unOV7EU0qbeLweSqTicC5Z9iECHB2OyljZs3XiaP n0yri8Rdq5PtuS0Ki+V7JC9JqYCiaUwLenHmkwzzrVpseNRBY8ywTZw7tG9QQhkLDL LW9NRo4EadBX3kfTDznTsZsyy+292fIj7A0pQuO7EpkX24pxB4CE7TwVGU+uw9EKaL bAdl8442Dwb4w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15821C55184; Mon, 3 Aug 2026 15:04:03 +0000 (UTC) From: Pawel Zalewski via B4 Relay Date: Mon, 03 Aug 2026 16:03:50 +0100 Subject: [PATCH 1/2] ata: use named initializers for acpi_device_id Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260803-ata-acpi-v1-1-f606afaacad1@thegoodpenguin.co.uk> References: <20260803-ata-acpi-v1-0-f606afaacad1@thegoodpenguin.co.uk> In-Reply-To: <20260803-ata-acpi-v1-0-f606afaacad1@thegoodpenguin.co.uk> To: Hans de Goede , Damien Le Moal , Niklas Cassel Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, "Pawel Zalewski (The Capable Hub)" X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785769441; l=2352; i=pzalewski@thegoodpenguin.co.uk; s=20260803; h=from:subject:message-id; bh=WMyRqpKRasvtDzYDnFf0+c4OYkQwjZjb+uf6e+s2Npo=; b=PbTHyx1WSZfMEhOhxM9hmNcXZFILmH388MaASnrWgAbeuHMoifugHG966KQFhmtyx3di43las Owk2gLaALFrC4gvY+NrEhNq/wh1SqD/c8X2pr7LWnikpN0sfOa6oJuP X-Developer-Key: i=pzalewski@thegoodpenguin.co.uk; a=ed25519; pk=W3zk1cb/wRnj6pNGbl3/2Zf3GmPA6IBpNHpDPyJ05k8= X-Endpoint-Received: by B4 Relay for pzalewski@thegoodpenguin.co.uk/20260803 with auth_id=913 X-Original-From: "Pawel Zalewski (The Capable Hub)" Reply-To: pzalewski@thegoodpenguin.co.uk From: "Pawel Zalewski (The Capable Hub)" Use a named initializer for the acpi_device_id fields which makes the code more readable and consistent with how lists are initialized in the rest of the kernel code base. While we are at it - unify the list terminator to have a single space between the brackets and no trailing comma. Signed-off-by: Pawel Zalewski (The Capable Hub) --- drivers/ata/ahci_platform.c | 4 ++-- drivers/ata/ahci_qoriq.c | 2 +- drivers/ata/ahci_xgene.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c index c18054333f7c..d97f0ad3b4cd 100644 --- a/drivers/ata/ahci_platform.c +++ b/drivers/ata/ahci_platform.c @@ -88,9 +88,9 @@ static const struct of_device_id ahci_of_match[] =3D { MODULE_DEVICE_TABLE(of, ahci_of_match); =20 static const struct acpi_device_id ahci_acpi_match[] =3D { - { "APMC0D33", (unsigned long)&ahci_port_info_nolpm }, + { .id =3D "APMC0D33", .driver_data =3D (unsigned long)&ahci_port_info_nol= pm }, { ACPI_DEVICE_CLASS(PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff) }, - {}, + { } }; MODULE_DEVICE_TABLE(acpi, ahci_acpi_match); =20 diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c index 0dec1a17e5b1..96492159fa7c 100644 --- a/drivers/ata/ahci_qoriq.c +++ b/drivers/ata/ahci_qoriq.c @@ -80,7 +80,7 @@ static const struct of_device_id ahci_qoriq_of_match[] = =3D { MODULE_DEVICE_TABLE(of, ahci_qoriq_of_match); =20 static const struct acpi_device_id ahci_qoriq_acpi_match[] =3D { - {"NXP0004", .driver_data =3D (kernel_ulong_t)AHCI_LX2160A}, + { .id =3D "NXP0004", .driver_data =3D (kernel_ulong_t)AHCI_LX2160A }, { } }; MODULE_DEVICE_TABLE(acpi, ahci_qoriq_acpi_match); diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c index 98c99b5a8242..2ebfe86e429b 100644 --- a/drivers/ata/ahci_xgene.c +++ b/drivers/ata/ahci_xgene.c @@ -710,9 +710,9 @@ static const struct scsi_host_template ahci_platform_sh= t =3D { =20 #ifdef CONFIG_ACPI static const struct acpi_device_id xgene_ahci_acpi_match[] =3D { - { "APMC0D0D", XGENE_AHCI_V1}, - { "APMC0D32", XGENE_AHCI_V2}, - {}, + { .id =3D "APMC0D0D", .driver_data =3D XGENE_AHCI_V1 }, + { .id =3D "APMC0D32", .driver_data =3D XGENE_AHCI_V2 }, + { } }; MODULE_DEVICE_TABLE(acpi, xgene_ahci_acpi_match); #endif --=20 2.54.0 From nobody Fri Oct 2 08:31:20 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B31AE2931FA; Mon, 3 Aug 2026 15:04:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785769443; cv=none; b=Q2sN2btSwU3S0UtwJM/WueYLj53lbPbBoQbj2CLhaeA3sdQnIuOgVLJkrBIkIFl/2rDyWISjifBNuIGS7CiXuhPDCTjqeQRKYdgNuDb0Fnbwd38+hIblA1ZxrONo302SI2vDRi+KscDg8OaCsJyoQsYjuAr5kSwyvOQ4W0ZKQpg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785769443; c=relaxed/simple; bh=iq+SM7rJUXSs4k5NukSDtbdt4eahBkIns2wi7WY9PjU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=alBPFIWbJsXw6/uXSxHGGaX6CsmI63c0+UsJC/yCm119jdK1rLQQYjIHWBRAltG0gvT/Lpc0P+7G/mLs+79KGrH/KnIlL2z/NiivUvhbsMTBHRjjLGQyExbYvIRP7tf/NEbatxw55nywDNrkvNTrCfRp8wHi8UL4oxsKQNVzKJw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eHO4BAUg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eHO4BAUg" Received: by smtp.kernel.org (Postfix) with ESMTPS id 4F1D7C2BCFD; Mon, 3 Aug 2026 15:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1785769443; bh=iq+SM7rJUXSs4k5NukSDtbdt4eahBkIns2wi7WY9PjU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=eHO4BAUgmSZLypj8CKJSG8yVvAXU4o6kbphvlGhwvKLVz9YMddoE+Rg1aeDG7NI9c XJEWoncTmif0rDRs79xoTMiIJr+Sjrq6Q8s26JFiAVCcpYmoVhPzoBTXvOb98XS6yc oD5vXTMv62TWgzXPUIR08v9d10Pi5JlsgkIHxaKoDWK8FU9BMiymO1V1XhsQ87OZSs bi4IcdvH3tGyI1Mt0305V9vVsoeVSvHDzj0v9OlnbmwtJY5/MLevBmxwGKsI279J6K wsob9NDhM6DmOqxOOP6AjgtdqEMEpZkf0+64Ja3KLJwSh2XOwREPM7GRCUYKIDOl1r FsOujT45jlM0w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27019C5518F; Mon, 3 Aug 2026 15:04:03 +0000 (UTC) From: Pawel Zalewski via B4 Relay Date: Mon, 03 Aug 2026 16:03:51 +0100 Subject: [PATCH 2/2] ata: ahci_seattle: drop unused acpi_device_id::driver_data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260803-ata-acpi-v1-2-f606afaacad1@thegoodpenguin.co.uk> References: <20260803-ata-acpi-v1-0-f606afaacad1@thegoodpenguin.co.uk> In-Reply-To: <20260803-ata-acpi-v1-0-f606afaacad1@thegoodpenguin.co.uk> To: Hans de Goede , Damien Le Moal , Niklas Cassel Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, "Pawel Zalewski (The Capable Hub)" X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785769441; l=991; i=pzalewski@thegoodpenguin.co.uk; s=20260803; h=from:subject:message-id; bh=NTXTlwoJq1lj+SCnk1cP3pBirwDRzp26Eqhz/VVpz7g=; b=hHVIY0FHG/LCgvw64RMEFNmMBpCnkPqpMqMd6efOPU7QrZ1NAtnXzGy3uFJjdGguQ9l7vQCEH fPUT++WnuooByct+CmewiYse55NReJ8kyyscIC9owlzfOrgnPhB8n0z X-Developer-Key: i=pzalewski@thegoodpenguin.co.uk; a=ed25519; pk=W3zk1cb/wRnj6pNGbl3/2Zf3GmPA6IBpNHpDPyJ05k8= X-Endpoint-Received: by B4 Relay for pzalewski@thegoodpenguin.co.uk/20260803 with auth_id=913 X-Original-From: "Pawel Zalewski (The Capable Hub)" Reply-To: pzalewski@thegoodpenguin.co.uk From: "Pawel Zalewski (The Capable Hub)" This module sets the acpi_device_id::driver_data to 0 but the id is not actually used within the module, we can just drop it from the list. While we are at it - used a named initializer for the acpi_device_id::id field to increase readability and modify the list terminator to have a single space in between the brackets. Signed-off-by: Pawel Zalewski (The Capable Hub) --- drivers/ata/ahci_seattle.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/ahci_seattle.c b/drivers/ata/ahci_seattle.c index 3f16c1678402..9758fa0260ac 100644 --- a/drivers/ata/ahci_seattle.c +++ b/drivers/ata/ahci_seattle.c @@ -178,8 +178,8 @@ static SIMPLE_DEV_PM_OPS(ahci_pm_ops, ahci_platform_sus= pend, ahci_platform_resume); =20 static const struct acpi_device_id ahci_acpi_match[] =3D { - { "AMDI0600", 0 }, - {} + { .id =3D "AMDI0600" }, + { } }; MODULE_DEVICE_TABLE(acpi, ahci_acpi_match); =20 --=20 2.54.0