From nobody Fri Oct 2 08:28:23 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3F222DEA7B; Mon, 3 Aug 2026 14:11:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785766280; cv=none; b=l4NLBX0ASpHCnpc/u2GVZpwu2+Qwq7wiQkQDd+0pzjDI32uC56kXpKVOtPethfywNXYdURSIbwAcaa+YMK8QD4RFmL87aJkYDfceqy3q6Y6UnFJmpi0LhgMyNbZxpW1F3hwQ6qagYJ36E+aPShh7rSBri1NMXTGR+K2H9Vqq3BM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785766280; c=relaxed/simple; bh=flpHljxSDlM6FiFUOGalQHThagM8liAXe0uLMZuHEJg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LVdYp+0DGAU9CT0RGhy9OK/6PJjhrhxVV6Jxy8XXFQnmFJgyeute3DUR7TlzYhIh0rR7b+/8OOsgfWcMKa3vDqvWhMqIvB8KBNKHA3zh5NoWDA4AUnw/A/g0gLpWupx3iXLkB2jWal8p9tqb7s31r9sG2k2KCWLmwu1uKZvGX9c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XYffHzt4; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XYffHzt4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C234E1F000E9; Mon, 3 Aug 2026 14:11:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785766279; bh=2ftHmK8g7nafyB0jkOSG6fQpcxsvFWE4K+g+CwBWgOU=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=XYffHzt4GGGT7fayKgw6SnzgXaxEk719NJ3Y767fqYNMvMxDZ+fHqfvmndSwU8yb3 Av7EYufZ5itqfaICvS+y8a/Ff6t9qIZXXKXH93sAtv3ZQ152AiNkIPu27VSZWeL+MG CYip289SRkojM+yUvleOgLXFx/hXdeGGS8kTfS0Q= From: Greg Kroah-Hartman Date: Mon, 03 Aug 2026 16:10:54 +0200 Subject: [PATCH v2 1/2] tty: vcc: zero-initialize control packet in vcc_send_ctl() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260803-aisle-tty-vcc-v2-1-a50bc9b15193@linuxfoundation.org> References: <20260803-aisle-tty-vcc-v2-0-a50bc9b15193@linuxfoundation.org> In-Reply-To: <20260803-aisle-tty-vcc-v2-0-a50bc9b15193@linuxfoundation.org> To: sparclinux@vger.kernel.org Cc: "David S. Miller" , Joshua Rogers , Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Greg Kroah-Hartman , stable X-Mailer: b4 0.16-dev-401aa X-Developer-Signature: v=1; a=openpgp-sha256; l=851; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=bq8fgDTT1FUjR57jXPgAKYoZ5dEnL8YK8TP0HoDJE/U=; b=owGbwMvMwCRo6H6F97bub03G02pJDFkFC0vc2vVOTzzqaMWTqvvtqm5dsHvyPTu5Wq2D39pFq 5jq+9Z2xLIwCDIxyIopsnzZxnN0f8UhRS9D29Mwc1iZQIYwcHEKwET+SjDMz12Ro5g29ejyn8GM 02+71dz1WSDRwzA/fnKsuNdBG8HV5i9YSiULhPb/3jkVAA== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 From: Joshua Rogers The stack-allocated struct vio_vcc pkt was partially initialized, leaving the tag.stype_env field uninitialized before being sent via ldc_write(), potentially leaking kernel stack data to the LDC peer. Assisted-by: AISLE:Snapshot Cc: stable Signed-off-by: Joshua Rogers Signed-off-by: Greg Kroah-Hartman Reviewed-by: Jiri Slaby --- drivers/tty/vcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c index 27a55465bf5e..3947bd2b75ac 100644 --- a/drivers/tty/vcc.c +++ b/drivers/tty/vcc.c @@ -492,7 +492,7 @@ static ssize_t domain_show(struct device *dev, =20 static int vcc_send_ctl(struct vcc_port *port, int ctl) { - struct vio_vcc pkt; + struct vio_vcc pkt =3D {}; int rv; =20 pkt.tag.type =3D VIO_TYPE_CTRL; --=20 2.55.0 From nobody Fri Oct 2 08:28:23 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4922240F759; Mon, 3 Aug 2026 14:11:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785766283; cv=none; b=WlFSnHr4Dv7tJI+yZt/+qcVxarHOPN6c907RcjG1+gXP73aZ+174Se/eGiGDMEv8D5hv6veUrow+dWlC3+eCrMJ1H40vLbfaXrGjxz701v1CN2eT9ptA12uhRWHc3hpRm723B0WL+N8/eu84suT4cIAQUgQUf91T1ZEQW68E900= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785766283; c=relaxed/simple; bh=qod1kldoxOL4+StIyobWsZtCVUU/S3T7yDLmBcNpBOk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AywnUhsjYqFazj506dV2OTW/4STgRclIcUmEdKN6kZ+l8xdnQFEhhv1bWliIhSXUbaOPXp4Q9SN/kYcHOvsNKaeQ7AIH6izvbO4Tml7VVS3f9ahBrhz4/2HFX9HU8bV4lMvUiunGj6RjnMe/9ltBM+Tc7KobNya3ULCucwYlaSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=njgpQfib; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="njgpQfib" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C5301F00A3A; Mon, 3 Aug 2026 14:11:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785766282; bh=0JEtF4uhZ/xwqVHWOd87FJU1a4CIL2n7CzuY18k0BfM=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=njgpQfib+6SOvkKJY8eouYVz7qRt0TES8tlpXi8SRtxZusbLr+WPzwlNQ+6wN4+sj Y4bFvR1dYC5mdxD6UpMIUAWV0h1yg7dNoR2xdNWr6dB6zgRF9q8uL0Z9CgOLeIqMOq olr6SnvaG6QhfWdq9LrYY9lqBVBwhqNAZe3ZYI7U= From: Greg Kroah-Hartman Date: Mon, 03 Aug 2026 16:10:55 +0200 Subject: [PATCH v2 2/2] tty: vcc: hold port lock when clearing tty pointer in vcc_cleanup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260803-aisle-tty-vcc-v2-2-a50bc9b15193@linuxfoundation.org> References: <20260803-aisle-tty-vcc-v2-0-a50bc9b15193@linuxfoundation.org> In-Reply-To: <20260803-aisle-tty-vcc-v2-0-a50bc9b15193@linuxfoundation.org> To: sparclinux@vger.kernel.org Cc: "David S. Miller" , Joshua Rogers , Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Greg Kroah-Hartman , stable X-Mailer: b4 0.16-dev-401aa X-Developer-Signature: v=1; a=openpgp-sha256; l=988; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=QJHFkLZlhHMGzuovuFDTu96rwVxMxfuLPI79nitom9w=; b=owGbwMvMwCRo6H6F97bub03G02pJDFkFC0sOJwTf2rRvy2oZ0aXPGRj36q2v5IjZnnulUaR24 a9fJ6XvdMSyMAgyMciKKbJ82cZzdH/FIUUvQ9vTMHNYmUCGMHBxCsBE9NcyLNi3iYkv73ZhqPqC rApno4ns828KuzAsWCQXI1E698T5AAXd5YmeuhsOya6ZDwA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 From: Joshua Rogers vcc_cleanup() sets port->tty to NULL without holding port->lock, racing with vcc_event() LDC callbacks that read port->tty under port->lock and then use tty->port. This can cause a use-after-free when the callback dereferences tty->port after cleanup has already destroyed and freed it. Assisted-by: AISLE:Snapshot Cc: stable Signed-off-by: Joshua Rogers Signed-off-by: Greg Kroah-Hartman Reviewed-by: Jiri Slaby --- drivers/tty/vcc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c index 3947bd2b75ac..9adb533f7034 100644 --- a/drivers/tty/vcc.c +++ b/drivers/tty/vcc.c @@ -986,7 +986,8 @@ static void vcc_cleanup(struct tty_struct *tty) =20 port =3D vcc_get(tty->index, true); if (port) { - port->tty =3D NULL; + scoped_guard(spinlock_irqsave, &port->lock) + port->tty =3D NULL; =20 if (port->removed) { vcc_table_remove(tty->index); --=20 2.55.0