From nobody Fri Oct 2 10:09:09 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CF85218592 for ; Sun, 2 Aug 2026 13:29:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785677347; cv=none; b=ErOjU++0VXTm4dRWJG2vs/OyOHpXdZDZXReaYvkDKiaN5p2AseCEgEkaD/nA+aAI2NQ76sIJu/l1TofBz7Rt/3RPeMsuhOdgIcLwjj9HSpqJKdTgETvSukUH9PO33Ro7TWL21cGK7QrCWmQjNbbfUgwfDHn8JlL5+eIa1idWw1w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785677347; c=relaxed/simple; bh=7j6cDbR8ZhsKS84pGfZMbp4cajWaCjf/n++4Ujh/WNg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oTF5M/bT3AL6PmbhIRXcG7k9jr6RytybAw2c1ORgCBrro3V4p6RxAE0dm5KTB7XnlZe4ejHxmvrUFSgYw2rCXMmpDQMZmtfIdY5mDbbEaVIA5N09BOawR+pGBjC0b76elKsrBUENddl4FMu3hCISJGFzIDcRimj2BbEzefq2nzc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YupWv5wo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DP8ZiKV2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YupWv5wo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DP8ZiKV2" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 672B6fHE1809984 for ; Sun, 2 Aug 2026 13:29:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OWuFxDG3GB3vQLllt9wjhHrS9M6M8QRdIWcCeT7gxnM=; b=YupWv5wotjJbAvYj vJcMuyqz75lU0mKfVB8CUTBtyKB8EYy2b8Izpd40IAaDVftCdHbIfpCptPx9W6nN sKIuZPBPzGb3CBVSQjet13P7+dYVUGRMPSVTjigKxCPEMQyjTh7zJ5e9R/ICGeoR K8mSAJZC5rf1XxRMC4bAPsA0siduEGt+s4NaI45w2RXEpKZ1tNeG7973QSBy/423 8CBUTv6TChjYKTI+OsImEG7QyPgbFcghXVQ2rlNCqcAdy5qvaYD1zSyv8G2G9v/V hgxrSCxNhh4kobKjCEce42ZTy+oZ/XhE1CqOneVvk3dWvOPD+eqMhkU3HDl6NAiV 2ycF/w== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fs8q52x2d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 02 Aug 2026 13:29:05 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-ca860baea9fso6393474a12.2 for ; Sun, 02 Aug 2026 06:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785677344; x=1786282144; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OWuFxDG3GB3vQLllt9wjhHrS9M6M8QRdIWcCeT7gxnM=; b=DP8ZiKV2VU+NT7+JDK2KYGIzIGqHdtEwKsdup3TNLDy7GwelBApEjURrUXPAkSUtpM +Uk4V/sB/6meAzZRnMoYOpfzHNk5OvCfTjqCD+VNBcCYgmb1Otc7n9eg8q+rPqd448FE y8Y23QXwlcx9N9wM3cGtE12+WUGYFTQ7F4VV90r8f7RsW0PiUktplQsQglVvs7YRPIL1 eOJ6DpfKMEX7vF+2AJtj0nWmTQR3f7ftN+lHR8YqgNNyVC25xr5Z2RVC2n9JpQNt8f5Y 2ab6s6Wy+99QGPNLcnZrSOLvVDrw5UEW0JsvVJZ9qfDwlsoWlEZ2pgTHUw204GSPWsyK EIqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785677344; x=1786282144; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OWuFxDG3GB3vQLllt9wjhHrS9M6M8QRdIWcCeT7gxnM=; b=QcMl0DxnI48G5fVzBd0QuLRtEdI/ZELbBlOw82rbcWMHeGDC8B9Dg/69XF7ipi88Sd Ef0k077XKkmfdXFs7IVKF2nlSEizu0h/HzcJfMq12qmHdjGBef8CpyktQy6klOO4H6BR 4o5g/CTwbDxFk+xqiBCFG7uisYAt1saQRufrv1eIp8GWFyer200HfUeyTF12e4cH8TgC 6HeCFdRxN1HhRIpGhT4TfxLv4Ko1zEmr57orh4E4CvT+2/MfQr4x0JyJpK9gqZdEjb6r zduibKU1cMozpehug57XCp90pzdEpfQwSzvaEujGOZRir4vA3RjdQVZsxQ3/+A7G04VF SJAw== X-Forwarded-Encrypted: i=1; AHgh+RoefdhdU2349AcmNKobBULXl5IUvq3Mgt39RGgo6aVhtXD03AyVokVLxClsXcXaUaYFQ6RHeFgqvlZajlc=@vger.kernel.org X-Gm-Message-State: AOJu0YwBWNtLPNwI5TMjXopfkdp3+otBdDSB3fAhMShx3Inc1+I1Qxte ki2+WgzQR0yo/wl9T3GfEYky9KJXyUa5KoJeC5cqwY94YTc72HudsdALbS4NsGVS2Q2PsWgfewn jQiMkidWAvue8DwWazRv4NwI3j3zbIPi8xxU+DZg0UTYOqFhGdxLnXp/0y8G3cbRyZDc= X-Gm-Gg: AR+sD10XC0rp3drEKgN3ke0T4BsBt7FRD8zrV1laBeKLiWwc58SwzFi92CKnSyR6+IE ZZRdqhSs/cEc0JSn1x97lAM1abVPG9qeqsSa3uzCwStcdVI7Yv44dKjNZhCW3Qo4OaJ5w4b5w3K ywYQVY/3CVkezf5LmrIXTZqIJENrban8frxg+1kPlgmXCjAPKygSYrAPeG4ykpxgtEA+WAlXdPo Y+Zv6QtBWQLN5Rv3jtaXZNSlcvvbAXk+FcpPhzT/7uYckW1UuZmrTeDiqpdWJXX12lFBicveuLA S0Vgp7NcqSut8aKNJFtmXk/o2pW3AaC7qLbRACwlAN/YWRixklxMqwB3PMdEHR09ygKhTRtbbdf PKM+9TYVLllC6wVCG9nPwFMxTrMO4 X-Received: by 2002:a05:6a21:1645:b0:3c0:b4f8:bbfb with SMTP id adf61e73a8af0-3c92a5e15cfmr6219875637.22.1785677344024; Sun, 02 Aug 2026 06:29:04 -0700 (PDT) X-Received: by 2002:a05:6a21:1645:b0:3c0:b4f8:bbfb with SMTP id adf61e73a8af0-3c92a5e15cfmr6219853637.22.1785677343555; Sun, 02 Aug 2026 06:29:03 -0700 (PDT) Received: from hu-mkshah-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153db2f911sm30582951eec.0.2026.08.02.06.29.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 06:29:03 -0700 (PDT) From: Maulik Shah Date: Sun, 02 Aug 2026 18:58:53 +0530 Subject: [PATCH 1/3] soc: qcom: rpmh-internal: fix kernel-doc issues in rpmh-internal.h Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-b4b4-rpmh-kdoc-v1-1-0f5026293d9a@oss.qualcomm.com> References: <20260802-b4b4-rpmh-kdoc-v1-0-0f5026293d9a@oss.qualcomm.com> In-Reply-To: <20260802-b4b4-rpmh-kdoc-v1-0-0f5026293d9a@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Maulik Shah X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785677338; l=2743; i=maulik.shah@oss.qualcomm.com; s=20240109; h=from:subject:message-id; bh=7j6cDbR8ZhsKS84pGfZMbp4cajWaCjf/n++4Ujh/WNg=; b=oHR5HWEUpN7YTDM6E8WgMV5IijG/Ebgr88iMrwiURxu+cVso4uG86r5NiqtZNoLQldG8iCgo+ DYo18Dq2CO4A+lw88g00V2h8+mEQbWAbuIVqCnwToUy23iOQyijP7p6 X-Developer-Key: i=maulik.shah@oss.qualcomm.com; a=ed25519; pk=bd9h5FIIliUddIk8p3BlQWBlzKEQ/YW5V+fe759hTWQ= X-Proofpoint-Spam-Info: AW1haW4tMjYwODAyMDExOCBTYWx0ZWRfXyyZTgpzQR/tb mEBhDfC2jDGEDFTR7WyZi5vWWMWeDiWgFP1xUGTSkKlUNUtAdGecU1JHmMbDwCIgaWVkz/G+dda Ti5nM0FEaoQhzuMUMJHJSkanNVP212o= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAyMDExOCBTYWx0ZWRfX6uUNZMDan1eF VOGw7mg0DvbyoarQ1/hGNkMwUe/mLlWTQ6rLLH7kHoXvV7LP0n2WUVX93vsxYWvOAgKgfLjrHBm 7X+bXIp5H2w0RF/SqnAOFpBCPIiVvnANIeTiJSpb5ZqG5LOf/Z0TUteD6L5mGC9/+6iM1MWvUjl hPIQNAronbI1Ec1x9jpvgDLArJ0ct93vWV+z3+B53nnnwnxqby7N1SYdj52UnGoiTgKzhU9aBrU qLipQFMdih4Hq5aPByWMhm/R5vDufP7KQbFN0uTjhkJA1gboulFosuv5KEoNXVXw1AYSVL7br5W +pB4E5Er7D469f3YC4D2pd4A8hdZaf9CScRR6wY0LyenZZseLPWpBtsgPqbuC5Wh2oOzGvmAMfl KV9GqrTldgwmiyprHFjgHKy9qch10brsej563lu3NBcCjty6rPEA/jc2pryJW3nW25Pr0078Jl/ TewpipqgXpvjfzAZFpA== X-Proofpoint-GUID: 0Jsz0_9uGV4HeuqMW3ioWWmxZ6S8a7E- X-Authority-Analysis: v=2.4 cv=IYC3n2qa c=1 sm=1 tr=0 ts=6a6f4621 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=h0T-4XPPwEjqpx5X2ycA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-ORIG-GUID: 0Jsz0_9uGV4HeuqMW3ioWWmxZ6S8a7E- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_04,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 priorityscore=1501 spamscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608020118 kernel-doc emits two warnings for rpmh-internal.h: Warning: drivers/soc/qcom/rpmh-internal.h:136 struct member 'ver' not des= cribed in 'rsc_drv' Warning: drivers/soc/qcom/rpmh-internal.h:136 struct member 'regs' not de= scribed in 'rsc_drv' Fix them by adding @ver and @regs entries to the struct rsc_drv documentation. While at it, add a missing kernel-doc block for struct rsc_ver, and update the remaining struct kernel-doc comments (struct tcs_group, struct rpmh_request, struct rpmh_ctrlr, struct rsc_drv) to use the 'struct name -' format documented in Documentation/doc-guide/kernel-doc.rst. No functional impact. Assisted-by: Claude:claude-sonnet-5 Signed-off-by: Maulik Shah Reviewed-by: Konrad Dybcio --- drivers/soc/qcom/rpmh-internal.h | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/soc/qcom/rpmh-internal.h b/drivers/soc/qcom/rpmh-inter= nal.h index e3cf1beff803..39441a25af9b 100644 --- a/drivers/soc/qcom/rpmh-internal.h +++ b/drivers/soc/qcom/rpmh-internal.h @@ -20,7 +20,7 @@ struct rsc_drv; =20 /** - * struct tcs_group: group of Trigger Command Sets (TCS) to send state req= uests + * struct tcs_group - group of Trigger Command Sets (TCS) to send state re= quests * to the controller * * @drv: The controller. @@ -53,7 +53,7 @@ struct tcs_group { }; =20 /** - * struct rpmh_request: the message to be sent to rpmh-rsc + * struct rpmh_request - the message to be sent to rpmh-rsc * * @msg: the request * @cmd: the payload that will be part of the @msg @@ -70,7 +70,7 @@ struct rpmh_request { }; =20 /** - * struct rpmh_ctrlr: our representation of the controller + * struct rpmh_ctrlr - our representation of the controller * * @cache: the list of cached requests * @cache_lock: synchronize access to the cache data @@ -84,13 +84,19 @@ struct rpmh_ctrlr { struct list_head batch_cache; }; =20 +/** + * struct rsc_ver - Hardware version of the RSC controller. + * + * @major: Major version number. + * @minor: Minor version number. + */ struct rsc_ver { u32 major; u32 minor; }; =20 /** - * struct rsc_drv: the Direct Resource Voter (DRV) of the + * struct rsc_drv - the Direct Resource Voter (DRV) of the * Resource State Coordinator controller (RSC) * * @name: Controller identifier. @@ -116,6 +122,8 @@ struct rsc_ver { * slot * @client: Handle to the DRV's client. * @dev: RSC device. + * @ver: HW version of the RSC controller. + * @regs: Pointer to the register offset table for this vers= ion. */ struct rsc_drv { const char *name; --=20 2.43.0 From nobody Fri Oct 2 10:09:09 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 334D53B42D9 for ; Sun, 2 Aug 2026 13:29:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785677349; cv=none; b=aiWq71QqipDh8MQI23atJorSN3p9yr9BF5Gjhg6turUCkiUJuG3BAcwOtY5f7QZzBNHfmCnCffT7uaouGv3oAskKMuVDH8pMHrcOwXwBHLi4pNfTj3fXGrf8w/lw0EFZecvdP6Learh5y4mimzZ2MnRXMrOCOS+KLNHXdra5Hd0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785677349; c=relaxed/simple; bh=+CYnCwojlSBcKoiP35Bjbd59g2f9lZL6rBYcAz4xraY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q4WM14MVD5ICXudCgvGn49sRSF6PcFXuOuQX3A0dnTCyNWdsrWE+B4IhAy9XinObLXvH8F9z8G4ddoFF7zvam9Kmtw02XF9w32iuBKm2QOwVm3D1wHXYa9fs3zmNyhYkz00JyxofB212Q0Xjh05z0dwQTEz50+LOrgIl90mSCqk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LLIqpcdw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QK74ioAR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LLIqpcdw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QK74ioAR" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 672B6lkX2009996 for ; Sun, 2 Aug 2026 13:29:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3pbo5cYJ9CVWp9LjGEV/wAfvm2Rp5OTXI1X+QDSrEUw=; b=LLIqpcdwUVlrvjQ5 ydRMsy6TzgG3LnZEmlP/PQV+m8cLgfByv25DshuHcB2fjQW3RzQsp3iFxUyNXhCt c1sKqWbcn7ojOZ7Uy32gzlrAGa769JA+SkLn/H8pEfdIJ8ZFm1xjcYpvA4A5rk48 KhRwVbSXYjisP46OxeDxCeTyQ8sCNhmYJxRc67GGxGan+eYPCJTUegFjnGtfBg0k SbQpXDtqiw802tzgOQTfz7s746htgX1wyE1jprFShZghEjHJiXybTc5yeKkgrWX7 od60ow8A6KUR+JbFFzomYhTIIlpKAU90np1lDKkyhqowQ2F2Nz19DHWVhSsP0Bbt lNyS7A== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fs8qptvh3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 02 Aug 2026 13:29:07 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38e8e864ef0so4149770a91.0 for ; Sun, 02 Aug 2026 06:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785677347; x=1786282147; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3pbo5cYJ9CVWp9LjGEV/wAfvm2Rp5OTXI1X+QDSrEUw=; b=QK74ioAR/JgkKhB0TwkERzx1TIQXxRPUfgCwRNBeD/I6C/3dN85zJdiT+dEx9fcJIi 1SfooBzg+O7myzPLeBd819JoksLi8wSP1lWH6haLMeQC6d42e7VPNt8DHhs/IqCFQIuJ +2b1R5xTZ4bLqt9ojIgzeXF+kVNKMFTexWeQ3rTnG+j8u9c0ZchQidtB6TVIpIkw5a8B i+ez0xI+RAft7Y42ng6e6wwjqP9jmUcm1k54DiO3gNFcQEkJ4+pSTL90y+wXz14wsCXd XJvMypygMhFQ5FAgQUWBNz7vlwF2YpucXGPlP7Cfxxqa7O5aJuIYCHB0ilg93zH7qx22 Z7LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785677347; x=1786282147; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3pbo5cYJ9CVWp9LjGEV/wAfvm2Rp5OTXI1X+QDSrEUw=; b=KIsBYmFV6EvAWcgvGB/Y8ly0sbID4lUpz+HFh8OXQkZ0zTvHm8mLVbyhtkJUFBhVhM PmMZeVSBfzuaFi4QDoKmz965zXJlx8HEQ86TMM+hY4a96nxDYFkBaSX26KyG1YpwIwhs 6HDXvlNOJBuLLSNJDwE1W8elGw0b3Yk2mnSJ7GD0823NQUgkCHKfYu3l++8yen8B5L8h DfCTSI0TebkEhD1HDcLZrUjAD9Tkhasw6kXzbpJu+Iaz+nN6L9LmkOWjn3rGUsOfa/hG 4AAl7PfgnAD6HaBVQEeff8jowOAUe8qQ5uzRwKApmWXaywCtgpuJgzb8O74h9K/yGuWB K2sg== X-Forwarded-Encrypted: i=1; AHgh+RrAOyhMj9EFI/HHTCi8sJnjZkQWnb6VA6m1KdTCh/LA7kA6N4pWMohA3paeqRjZVmFFUIEsw7ua9WhEbxs=@vger.kernel.org X-Gm-Message-State: AOJu0YyCeOYnnZGINk4NDhCfUs+bZgCUJaEgkvVbz6RlUcC8gFUyrn+q JCVVTV832qb9ysbv+890okcC+OsTtCDUlQ5FFblN/+qgX/EgjLslWShrB/e5OdLpvj7KnfVAkgo 3eBZgl9rxSCHGUvb1e0AbgzWMB/8PmH6fAFpQRaVszJwHne2FqJD8ZPyWoCdjzwkcJAc= X-Gm-Gg: AR+sD11NRSLQ7TcUOHiectm0m+IH5UXwBfwTKPiGm5gDMzDXQPzD9D0HtgigAUXu/8R fzU6MhgW+2QePnHXfvO6qlnuvHS4DU6qfoMhpO5mGnzslYwWeN5HWgTLcQw3J4iEMZcZ0fQHwz6 HUCpn/C00JFHVZi+UiF9e16zx7IpkUuYGUINRv2d/kheuTrRAzS08QxBhavke/1rjUdjELGemyG b86tF+iCgb3jTBQrssDic+YSTc8gIJcMDXo7SovRJYbeA0xCcoQQAHPcNUdsiHAB/DerThAJ1JM T+aiJ2j683cN7Q1UuHEnf+V+DIvkzAAL8eUiuhBO2gstP5doCLMK3lN0pkJlaz4/NnpqjfTbtZp XoCMno0LpJ29iJA+TPjXvgbjv5gJY X-Received: by 2002:a05:6a21:3511:b0:3c8:f98f:475b with SMTP id adf61e73a8af0-3c92a74a14cmr7481484637.19.1785677346507; Sun, 02 Aug 2026 06:29:06 -0700 (PDT) X-Received: by 2002:a05:6a21:3511:b0:3c8:f98f:475b with SMTP id adf61e73a8af0-3c92a74a14cmr7481464637.19.1785677346049; Sun, 02 Aug 2026 06:29:06 -0700 (PDT) Received: from hu-mkshah-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153db2f911sm30582951eec.0.2026.08.02.06.29.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 06:29:05 -0700 (PDT) From: Maulik Shah Date: Sun, 02 Aug 2026 18:58:54 +0530 Subject: [PATCH 2/3] soc: qcom: rpmh: fix kernel-doc issues in rpmh.c Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-b4b4-rpmh-kdoc-v1-2-0f5026293d9a@oss.qualcomm.com> References: <20260802-b4b4-rpmh-kdoc-v1-0-0f5026293d9a@oss.qualcomm.com> In-Reply-To: <20260802-b4b4-rpmh-kdoc-v1-0-0f5026293d9a@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Maulik Shah X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785677338; l=6489; i=maulik.shah@oss.qualcomm.com; s=20240109; h=from:subject:message-id; bh=+CYnCwojlSBcKoiP35Bjbd59g2f9lZL6rBYcAz4xraY=; b=09cHSX2v4klLzQ9P7iJNawmlGMi789WCQF7Dn6H8+LL6kumsaAE7LIF+JP0dSyaJ6xtNV6xZ4 c7v1zAyITLdD16C3BOz0rWJ+UDPYZGu9acqqN4BepXmrZxoTYfe+u8+ X-Developer-Key: i=maulik.shah@oss.qualcomm.com; a=ed25519; pk=bd9h5FIIliUddIk8p3BlQWBlzKEQ/YW5V+fe759hTWQ= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAyMDExOCBTYWx0ZWRfX5Iu5bwHWK6Db 22vT3lFy5KJt0zmvK6hDNeL1+RWFwlcz0915WeYifS5GxgdU4mL0fwSOjfEzd743ae2/5lXEBEo tb3IaAx334azFV9DJTLuyY83+j9cp7yMowiwrDJSIcDKZ/Td4jJEHWrC2Tbubyaz4gWolV7exyF ErDLhh6kheFgBkatKxtTSeu/dAfzJ5CmbBKZHZhUicVhxBoP/SZ0LevK2jEsPzPMS5XqYGrE8Bl ZrhzGyV3Yjw6JRCNvz9QvHIc+QgFfDWY1n+IbkPK/0B6EYO6HiXxuUzgX6b7zMWl803EkLTbxac GP9LRr45CuF1E5PZgIphuz+SgLodvmWg2PLWD4oxMjL6/77BF5rcfAlaT5AOFfR7TlNFnUze/IV bErDuSqkh1L2YlUqgUvQZfQRv6dP01URBVb025Jar4ZWEotrdKrnBjQ/24CbwjLKSw/idv8nalC HLZ4rhDb+EBIJX7Uc5Q== X-Proofpoint-GUID: xBk0wYbfP0znt--HpDclvokmp1I_BwtR X-Authority-Analysis: v=2.4 cv=MpViLWae c=1 sm=1 tr=0 ts=6a6f4623 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=_NtIa0pIVb_aOCDbWhEA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: xBk0wYbfP0znt--HpDclvokmp1I_BwtR X-Proofpoint-Spam-Info: AW1haW4tMjYwODAyMDExOCBTYWx0ZWRfX0P1k6k3Q8+ie IrHxEUJTuQmVwdkvUsdZmPE26WZ3n/HrupaK9QukcE4qjJLsilYWdNpYHV5aXjrdE77XjF7OaUt eHOcExcPR04PfoqqYw8Q+KpMKmkflKM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_04,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 phishscore=0 malwarescore=0 spamscore=0 adultscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608020118 Six documentation issues in rpmh.c: - struct batch_cache_req has a typo in its title: 'batch catch' should be 'batch cache'. Fix it. - __rpmh_write(), rpmh_write_async(), rpmh_write(), rpmh_write_batch() and rpmh_invalidate() use 'name: title' format instead of the 'name() - title' format documented in Documentation/doc-guide/kernel-doc.rst. Fix all of them. - rpmh_tx_done() has no kernel-doc comment. Add one describing its purpose as the RSC driver callback for active-only transfer completion. - __rpmh_write(), rpmh_write_async(), rpmh_write() and rpmh_write_batch() are missing Return: tags. Add them. - struct cache_req uses 'struct name:' format instead of the 'struct name -' format documented in Documentation/doc-guide/kernel-doc.rst. Fix it. - rpmh_write_batch() has an inaccurate description: it says requests are sent 'without caching' and that SLEEP/WAKE_ONLY requests are sent as fire-and-forget. In reality, SLEEP/WAKE_ONLY requests are cached in batch_cache and returned immediately; they are only sent to the controller later by rpmh_flush(). Fix the description. No functional impact. Assisted-by: Claude:claude-sonnet-5 Signed-off-by: Maulik Shah Reviewed-by: Konrad Dybcio --- drivers/soc/qcom/rpmh.c | 40 ++++++++++++++++++++++++++++------------ 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/drivers/soc/qcom/rpmh.c b/drivers/soc/qcom/rpmh.c index ca37da3dc2b1..f725b1135388 100644 --- a/drivers/soc/qcom/rpmh.c +++ b/drivers/soc/qcom/rpmh.c @@ -41,7 +41,7 @@ #define ctrlr_to_drv(ctrlr) container_of(ctrlr, struct rsc_drv, client) =20 /** - * struct cache_req: the request object for caching + * struct cache_req - the request object for caching * * @addr: the address of the resource * @sleep_val: the sleep vote @@ -56,7 +56,7 @@ struct cache_req { }; =20 /** - * struct batch_cache_req - An entry in our batch catch + * struct batch_cache_req - An entry in our batch cache * * @list: linked list obj * @count: number of messages @@ -76,6 +76,14 @@ static struct rpmh_ctrlr *get_rpmh_ctrlr(const struct de= vice *dev) return &drv->client; } =20 +/** + * rpmh_tx_done() - Signal the completion of a RPMH transfer. + * @msg: The request that was previously sent. + * + * Called by the RSC driver when an active-only transfer is complete. + * Signals any blocking waiter and frees the message if it was dynamically + * allocated. + */ void rpmh_tx_done(const struct tcs_request *msg) { struct rpmh_request *rpm_msg =3D container_of(msg, struct rpmh_request, @@ -157,7 +165,7 @@ static struct cache_req *cache_rpm_request(struct rpmh_= ctrlr *ctrlr, } =20 /** - * __rpmh_write: Cache and send the RPMH request + * __rpmh_write() - Cache and send the RPMH request. * * @dev: The device making the request * @state: Active/Sleep request type @@ -166,6 +174,8 @@ static struct cache_req *cache_rpm_request(struct rpmh_= ctrlr *ctrlr, * Cache the RPMH request and send if the state is ACTIVE_ONLY. * SLEEP/WAKE_ONLY requests are not sent to the controller at * this time. Use rpmh_flush() to send them to the controller. + * + * Return: 0 on success, negative error code on failure. */ static int __rpmh_write(const struct device *dev, enum rpmh_state state, struct rpmh_request *rpm_msg) @@ -209,7 +219,7 @@ static int __fill_rpmh_msg(struct rpmh_request *req, en= um rpmh_state state, } =20 /** - * rpmh_write_async: Write a set of RPMH commands + * rpmh_write_async() - Write a set of RPMH commands. * * @dev: The device making the request * @state: Active/sleep set @@ -218,6 +228,8 @@ static int __fill_rpmh_msg(struct rpmh_request *req, en= um rpmh_state state, * * Write a set of RPMH commands, the order of commands is maintained * and will be sent as a single shot. + * + * Return: 0 on success, negative error code on failure. */ int rpmh_write_async(const struct device *dev, enum rpmh_state state, const struct tcs_cmd *cmd, u32 n) @@ -241,7 +253,7 @@ int rpmh_write_async(const struct device *dev, enum rpm= h_state state, EXPORT_SYMBOL_GPL(rpmh_write_async); =20 /** - * rpmh_write: Write a set of RPMH commands and block until response + * rpmh_write() - Write a set of RPMH commands and block until response * * @dev: The device making the request * @state: Active/sleep set @@ -249,6 +261,8 @@ EXPORT_SYMBOL_GPL(rpmh_write_async); * @n: The number of elements in @cmd * * May sleep. Do not call from atomic contexts. + * + * Return: 0 on success, negative error code on failure. */ int rpmh_write(const struct device *dev, enum rpmh_state state, const struct tcs_cmd *cmd, u32 n) @@ -303,7 +317,7 @@ static int flush_batch(struct rpmh_ctrlr *ctrlr) } =20 /** - * rpmh_write_batch: Write multiple sets of RPMH commands and wait for the + * rpmh_write_batch() - Write multiple sets of RPMH commands and wait for = the * batch to finish. * * @dev: the device making the request @@ -311,13 +325,15 @@ static int flush_batch(struct rpmh_ctrlr *ctrlr) * @cmd: The payload data * @n: The array of count of elements in each batch, 0 terminated. * - * Write a request to the RSC controller without caching. If the request - * state is ACTIVE, then the requests are treated as completion request - * and sent to the controller immediately. The function waits until all the - * commands are complete. If the request was to SLEEP or WAKE_ONLY, then t= he - * request is sent as fire-n-forget and no ack is expected. + * If the request state is ACTIVE_ONLY, the requests are sent to the + * controller immediately and the function waits until all commands are + * complete. If the state is SLEEP or WAKE_ONLY, the requests are cached + * and the function returns immediately; they are sent to the controller + * later by rpmh_flush(). * * May sleep. Do not call from atomic contexts for ACTIVE_ONLY requests. + * + * Return: 0 on success, negative error code on failure. */ int rpmh_write_batch(const struct device *dev, enum rpmh_state state, const struct tcs_cmd *cmd, u32 *n) @@ -480,7 +496,7 @@ int rpmh_flush(struct rpmh_ctrlr *ctrlr) } =20 /** - * rpmh_invalidate: Invalidate sleep and wake sets in batch_cache + * rpmh_invalidate() - Invalidate sleep and wake sets in batch_cache * * @dev: The device making the request * --=20 2.43.0 From nobody Fri Oct 2 10:09:09 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29EEF3B71AE for ; Sun, 2 Aug 2026 13:29:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785677352; cv=none; b=QYVd2xOOtH+NPG5K8GbQ/L1MJkcf1LC2VCv1L8fuwR62dIS88OYAOd8B8P5d4EoPWH2C62TckGkPeBuONFFZI4WXW3LR4omjb39q1wdr28zu9ct76vuh1Ud3N1sH5MNpqqvMoXc821wvCuRcNimgkTvkPtOAHauxyb8BumDkQnA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785677352; c=relaxed/simple; bh=Y59BOttM1xa174SDMiJoFUqpqlNHb3j6S8caVXTgWjw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eAybe7r0gGtqfFOMYDv1MXLNUOh4+iPpLkJj1luMgQ3OqJKusP44oOn5nM0KehWkPDxXhxJZyIbgHmHh29V6ievbY1AynM514Qvj7T1A5z57ds45KLH65ogjcwRVhLewfrJj2j79W+WxdNWN1fXYFNioecQCjbzkzPh+mcAVBwY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GIH1CAg2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fj7e3EUt; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GIH1CAg2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fj7e3EUt" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 672B6fHF1809984 for ; Sun, 2 Aug 2026 13:29:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WuR176VLUamMDkT1wfGrpjDH+JtVK/6ppywmLriE0eo=; b=GIH1CAg2c6YJFAL0 IgRORIFj08qVHGnwasy/bl9d302+Kx4kx7icuzrp/lVtRRWdx2IyyhRZBeEBcjJX ZVfcNoCObDNfNsDQy/Q0FHo5I3qH1KABHfkqYHEHUXdwEhkosY60TN6pnEgyaNMw NVOGzktx/XF/X0wLFbmXx0d37dHaxG23M5eSj4t34loJ2SlhVDvn4cOpg6LAfvSn +D+XqWfbJ0HOEpqGIdFqQeD0Kx9wnP+cqFa+b0g+aCIsqe5nwvWvBovZs94TdedV kDh2g6WfNOsLmX/j5yt/pFugkJd0NGxPexOlosgZPzaVgqqsFeFQRRwodFY7zuPL 0Hc9yQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fs8q52x2h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 02 Aug 2026 13:29:09 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2cc6dd43737so55030385ad.2 for ; Sun, 02 Aug 2026 06:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785677349; x=1786282149; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WuR176VLUamMDkT1wfGrpjDH+JtVK/6ppywmLriE0eo=; b=fj7e3EUtkKdmFAfW9X5MAsHCVG1fDlIgzOD2zHobUHZEMdRejX3Up1mAtjVttGcKRX elNMHgCtSL0kG0k8ulI9KRXVdJrGeBrXT2LeFqJ/cEhMeMb8OAO7pinHFvc2ZsRKMFY9 k4M5I5v+Os5gsYTj1pQocId/AmZ8FhWJsczrynUBVHairIsZ5ejFF2CZojhX/3VkFUJs No4sRP8RnOxf4hRJ9XvwjU+zBqSXaoyO+XvpInQadRwYQlwKQsqylag5n4sFUL5nKP+4 DBf0tZvapchVTtYPLTBecgwxmBGegwcviGP02s9AkmD+XMg/6H6o3KYXCKnQNz+EJbJY mQZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785677349; x=1786282149; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WuR176VLUamMDkT1wfGrpjDH+JtVK/6ppywmLriE0eo=; b=fmQFf5kb2pAsxfLINDatPkSA/jWMC1zh0W00t6BC0tlEJb9xivAwxzgE7dFL6TrVEA k5c8QJ733z8z4/Hs/rqR5Jd3IYm3VZWNMk4/PULWaBlyhpk0NKdVUT7Lg7wi+EnswN5Z GK0NEXKNd9jQYe/qOQz3hQ5bUnZQi4KgpaytIYZcOz3wosiObYZ/tX1L0BvaoKWcjkgP 5yF3PO2MXdL+TGq8+NMkl7ZFrfKcFLylih1MyQMnHrb8L3wQTpBEOQIyZP7AVuBlOrkI Oc8B7JwIpve6jJ7SpihVZ9xl9cMMJxTEzyEt9KFsU52OT0BgCCiPLt+U8OJ0Lwfdjo1n aO9g== X-Forwarded-Encrypted: i=1; AHgh+RpVqkHFtksTnDZ31IEq3R0qvxVkKEOznsjzfKskTAXFXbaQAbd7e5LbZbQHPjp55S7QCapa8+qumyMXbWQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzi3p6TbxNWvOcAOPfubvqMeqegMMQmO7MgT/1b/2s+GnoI1xmh 5lkVM5aCmCyU3xVTGuNUzPQgodY5QHKZ4NDUgke2oYiiDDAv7X5kXpL66PKnkQu4GuTh5yF7UNp WoEb7rfPxI/XHTNXOvIFWYG9oLNYF1ZToQd7Oyx14/P96ssS+MFmwhZXZg/GfnURoy20ZxYFWZZ U= X-Gm-Gg: AR+sD12NAYQwpKHThVwRbQOcZUmsCx3ynoWb81fjdoL0F6USmmOwIrAP4nR5KdQJPar 6FnUX6tbEx2Uakqd3CNsQpm7cTa3Th/dGJ00aHB6hugzZ2hgyBKuqzysq1H99HF+/N7xTiPO8AJ csmnc2kOkcrDC6VJ1NlN5gATxKeGNTw6vMSreXZTwGzTNt9QzbNNELbDXFwlzu0uUydfZwAytu/ 2nP1cckQ7tBsssB3SUlUGNZ52f6F74VYVRHimb2srA3y7qnqpo7+crzBsz+wW7hT6ilCBs6SS2N jAIuUQmWl78Iu4stoC/M0TKPnECJnHciTYYBso7hsrYahQFkmGceGpJXDrsTpsY3L+9obMq3ZDx 2x1rUrN0dYqeo2hSl3rBu6G9hPqA7 X-Received: by 2002:a17:903:3810:b0:2cf:b23a:3e6e with SMTP id d9443c01a7336-2d0524740cfmr67910985ad.40.1785677348998; Sun, 02 Aug 2026 06:29:08 -0700 (PDT) X-Received: by 2002:a17:903:3810:b0:2cf:b23a:3e6e with SMTP id d9443c01a7336-2d0524740cfmr67910775ad.40.1785677348549; Sun, 02 Aug 2026 06:29:08 -0700 (PDT) Received: from hu-mkshah-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153db2f911sm30582951eec.0.2026.08.02.06.29.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 06:29:08 -0700 (PDT) From: Maulik Shah Date: Sun, 02 Aug 2026 18:58:55 +0530 Subject: [PATCH 3/3] soc: qcom: rpmh-rsc: fix kernel-doc issues in rpmh-rsc.c Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-b4b4-rpmh-kdoc-v1-3-0f5026293d9a@oss.qualcomm.com> References: <20260802-b4b4-rpmh-kdoc-v1-0-0f5026293d9a@oss.qualcomm.com> In-Reply-To: <20260802-b4b4-rpmh-kdoc-v1-0-0f5026293d9a@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Maulik Shah X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785677338; l=1765; i=maulik.shah@oss.qualcomm.com; s=20240109; h=from:subject:message-id; bh=Y59BOttM1xa174SDMiJoFUqpqlNHb3j6S8caVXTgWjw=; b=v6PNu/9qo2t+RnDf3UOioLg5lTJl9FnxkTcJZsuShN/gDyeXGCzAKkFS0wItJVoXKi2hjTglY n5NIbEOrF7jBv8qaJEzipW0WGfVkS7dVmV+5tXHRSZTfk/97CusFiUX X-Developer-Key: i=maulik.shah@oss.qualcomm.com; a=ed25519; pk=bd9h5FIIliUddIk8p3BlQWBlzKEQ/YW5V+fe759hTWQ= X-Proofpoint-Spam-Info: AW1haW4tMjYwODAyMDExOCBTYWx0ZWRfXxWuY3O04iSAF HWLbfd1n3OOUaa7iXxBpHoJzyix/gyFVqYLd7KQ5mBkXuevquTz4vsByPhl627x9ScSxor4F9Y9 hCvnXeVGJzxz97qQ6ESH51X7TA6l5Z0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAyMDExOCBTYWx0ZWRfX4CIM1rUxNTlf QaIYXI0I/K0eKj2EgC6iOr/KP1uXRNaSnj0kiFkTosnjVpFv7P5W/2Ktc7Mo/dXMK9Itvs2uu8A CCak6JRGsS7QFzHqXFXhFrzZUPKCSBQGAVao0bbJZc6Hr73AqKyULgC2HTUz4L4+k7s7kq624aK 940w0QAW0UnC5tsR4X46FhD7qbdSDdz9srDCrlUI8STLM7wPC+vJh2h+4OBsOCRNuLVrnVKm9Ud gxnMosEreIEdvHw9a2maf6gfHMpYxHPz1eriSDaRfH0kukGPvC8PrNG+fuOMIJUgUfr+nDSWwRd okq+W19lgEsVmbUXtV7t6JS8INjnYyQgXUQv7yjKKHbrpat+Jl2DUYz56yKcEW7ax+1VNAU4CL9 RVdxArQNWelxfi2XXptgxsZFfPBxsFYBDYeyabUFReMDq3IJc+2hBbeK1nEdRKWQF99jtMEDk3c uYjvU2ZtZTgVhCfngjA== X-Proofpoint-GUID: hJghMTdGb3Ea2jF23KGnssBgWeWITHBL X-Authority-Analysis: v=2.4 cv=IYC3n2qa c=1 sm=1 tr=0 ts=6a6f4625 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=x3vLSCj6OUTY9ROcoe8A:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: hJghMTdGb3Ea2jF23KGnssBgWeWITHBL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_04,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 priorityscore=1501 spamscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608020118 Two documentation issues in rpmh-rsc.c: - rpmh_rsc_pd_callback() has a copy-paste title 'Check if any of the AMCs are busy' which describes rpmh_rsc_ctrlr_is_busy() not this function. Fix the title to accurately describe what this callback does: flush sleep/wake TCS data on PM domain power-off. - rpmh_rsc_cpu_pm_callback() has the same copy-paste title 'Check if any of the AMCs are busy'. Fix the title to accurately describe what this callback does: flush sleep/wake TCS data when all CPUs enter power down. No functional impact. Assisted-by: Claude:claude-sonnet-5 Signed-off-by: Maulik Shah Reviewed-by: Konrad Dybcio --- drivers/soc/qcom/rpmh-rsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c index 66928ca40b9a..f5251519ec85 100644 --- a/drivers/soc/qcom/rpmh-rsc.c +++ b/drivers/soc/qcom/rpmh-rsc.c @@ -833,7 +833,7 @@ void rpmh_rsc_write_next_wakeup(struct rsc_drv *drv) } =20 /** - * rpmh_rsc_cpu_pm_callback() - Check if any of the AMCs are busy. + * rpmh_rsc_cpu_pm_callback() - CPU PM notifier to flush sleep/wake TCS da= ta. * @nfb: Pointer to the notifier block in struct rsc_drv. * @action: CPU_PM_ENTER, CPU_PM_ENTER_FAILED, or CPU_PM_EXIT. * @v: Unused @@ -914,7 +914,7 @@ static int rpmh_rsc_cpu_pm_callback(struct notifier_blo= ck *nfb, } =20 /** - * rpmh_rsc_pd_callback() - Check if any of the AMCs are busy. + * rpmh_rsc_pd_callback() - PM domain callback to flush sleep/wake TCS dat= a. * @nfb: Pointer to the genpd notifier block in struct rsc_drv. * @action: GENPD_NOTIFY_PRE_OFF, GENPD_NOTIFY_OFF, GENPD_NOTIFY_PRE_ON or= GENPD_NOTIFY_ON. * @v: Unused --=20 2.43.0