From nobody Fri Oct 2 10:08:42 2026 Received: from bkemail.birger-koblitz.de (bkemail.birger-koblitz.de [23.88.97.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AE083B9DA2; Sun, 2 Aug 2026 16:32:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.97.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688356; cv=none; b=Gq8Yabe+W5SCQOIPLPn4g93NDH6B0+yqqdO99I8VoqqgHfgsHMy+0kqDaRhMe3VY9z9DCFnTBZ//HaD9aYr6GSsonLeHN96PYLvOV/4Wi9oGuJDmVxFWYYtUo7AgXZg+QlJrdNuqSALNmYMbpC+PI/hwlGuwiGoDmPwC5wiCbN4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688356; c=relaxed/simple; bh=Xt+4mBtUkIrJ36ZCTKcJkucyLloqg9n7ap1XhHTfnJk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uVjvDt/aAb38DEtiKHnux+RN18Sl+23mKcckcrebFSshcvnuurdR4yse0RbfCfkxBthSEWOJ5xONDXk3eyI2HSJXHVWmt466pK7+sB5TK9iEsWtmsJIeCWY0MA0OCy6vrxhL/Nos6aygPihwwxCwPbrVOmyllk2WHAq0eIZ72Gg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de; spf=pass smtp.mailfrom=birger-koblitz.de; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=kgO2DNt9; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=Fw+ehoN0; arc=none smtp.client-ip=23.88.97.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="kgO2DNt9"; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="Fw+ehoN0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688353; bh=Xt+4mBtUkIrJ36ZCTKcJkucyLloqg9n7ap1XhHTfnJk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=kgO2DNt9oJrPduZm8+Iq4ut2Yj2FswcF9kx2DPkeuM/1dz8LplT5J/FyOpFxfRyR4 ZldK9/fZFAnBi9j7NPJAJlkYbVrCdQ/+cs9UYUkQ+UNdSbzjmQsQVwA43S4X2SXs6V h6n5k7s5eSTj51ngWVkHbSDo91jYpBLN85pFkgVGEgG8roqaaf0iuUrbY8ogWf3Rql hSlF44FZPGUS+TicCvolsN0JW1kyjdcWpZ/dO7C+j09046WrdWLWw/3L7WwGdybdve CXFcsn3BwJ5wsphzoNBU5Fk2ggaHQpQzAtaEwliAhhkllY/zjC5wPfr2Iupi46CxmT hArreUzVlRDQQ== Received: by bkemail.birger-koblitz.de (Postfix, from userid 109) id 1C70B49658; Sun, 2 Aug 2026 16:32:33 +0000 (UTC) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688351; bh=Xt+4mBtUkIrJ36ZCTKcJkucyLloqg9n7ap1XhHTfnJk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Fw+ehoN0jrFRn/ZtY5NZ8nxFCCAUEmRrRCZkpaaSHMAc0c6lKxdjSvdwtOvrXTauf 27ZbtG5AIg3Zy9XoaXXY4YBNGGB3L5bEK77lA4O2hNO4cYyI8FbsfBHW9FXIU94r5v O2qWTg0Lvj7ATv4vdiFfxJcJBFzOqhOimg3tu+UvmcVhXsmftVZ2wK3w0DuF3UfCzT Y08+qAcUfaxvNv7cdHXdC3b5do67PLF9WNeH4mguIMCZeQMpjOoALehPX73fPj7Ja8 NUwfbko/upw3+8m3Ef2xfg1osZ7UPk2G80VKc8Yywp/CThOQ9mfa72dDdsKiRUUUBk YTnailLmf4oHw== Received: from ThinkPadAMD.lan (90-227-251-202-no2480.tbcn.telia.com [90.227.251.202]) by bkemail.birger-koblitz.de (Postfix) with ESMTPSA id 630CB49643; Sun, 2 Aug 2026 16:32:31 +0000 (UTC) From: Birger Koblitz Date: Sun, 02 Aug 2026 18:31:59 +0200 Subject: [PATCH net-next v5 01/13] ax88179_178a: Fix endianness of pause watermark register Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-ax88179a-v5-1-dcb9fea4acd4@birger-koblitz.de> References: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> In-Reply-To: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Andrew Lunn , Heiner Kallweit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Birger Koblitz , Jianhui Xu X-Mailer: b4 0.14.2 The 16-bit pause watermark register is little endian as described in the ASIX 4.1.0 out-of-tree driver. Correct the register byte sequence but also swap the configuration values used in the code in order to keep the current behaviour. The endianness is relevant for 16-bit writes to the register. Signed-off-by: Birger Koblitz Reviewed-by: Andrew Lunn Tested-by: Jianhui Xu --- drivers/net/usb/ax88179_178a.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 98f899ea2e9462f1ba99281a875385241745458b..945c071dfd1d2f0816c779e1a40= 1ac158adc8d99 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -32,8 +32,8 @@ #define AX_ACCESS_EEPROM 0x04 #define AX_ACCESS_EFUS 0x05 #define AX_RELOAD_EEPROM_EFUSE 0x06 -#define AX_PAUSE_WATERLVL_HIGH 0x54 -#define AX_PAUSE_WATERLVL_LOW 0x55 +#define AX_PAUSE_WATERLVL_LOW 0x54 +#define AX_PAUSE_WATERLVL_HIGH 0x55 =20 #define PHYSICAL_LINK_STATUS 0x02 #define AX_USB_SS 0x04 @@ -1617,11 +1617,10 @@ static int ax88179_reset(struct usbnet *dev) dev->rx_urb_size =3D 1024 * 20; =20 *tmp =3D 0x34; - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_LOW, 1, 1, tmp); + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_HIGH, 1, 1, tmp); =20 *tmp =3D 0x52; - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_HIGH, - 1, 1, tmp); + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_LOW, 1, 1, tmp); =20 /* Enable checksum offload */ *tmp =3D AX_RXCOE_IP | AX_RXCOE_TCP | AX_RXCOE_UDP | --=20 2.47.3 From nobody Fri Oct 2 10:08:42 2026 Received: from bkemail.birger-koblitz.de (bkemail.birger-koblitz.de [23.88.97.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF3993C2BA2; Sun, 2 Aug 2026 16:32:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.97.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688369; cv=none; b=YHJ9LnoYz2ESLLVzDitYET4ynz9G9SaOBX5sy0wgnq72ns2YsGUqrhXXd9gJF4V17Xg/nECy26VLffDpOoBnrTFGAjYzj+/YDC7lQYngdDeID8SUE3czLooBqGJo+K4n00EhRtRRpEnrwZwsyJCuvrFNLG9A04f/orWUHUsatcU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688369; c=relaxed/simple; bh=Eks2Ad1M0C1NOfXtuLA6GDYamvbAmjbtcWB1L3/MivM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kNVbcZWGipSAnucPyGwbCHvjfb9JqmjGKD6doeC1YgP4GwFUR/TRlr0oAsnflcLr0j8uGyQVuaB+TE4XP0x+V9+yuNLVQXXNzXYpjhwmEBGlStVOL9Wrx9DqkJgMACDwFwP0KZvAcWd94sQVTm5gZoFkglGJF/nwErqUyFu4+/Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de; spf=pass smtp.mailfrom=birger-koblitz.de; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=pWpCahM2; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=MGtcfMY+; arc=none smtp.client-ip=23.88.97.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="pWpCahM2"; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="MGtcfMY+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688357; bh=Eks2Ad1M0C1NOfXtuLA6GDYamvbAmjbtcWB1L3/MivM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=pWpCahM220pKVdLxZ3pWfM7g/D7UPt7mXLRWqpK/lnGFSWtKWPBNX76Iwi9Op5LQd UnDvOExsICDyta9Ewp7u0+ZnRX40zfdDJNk/6B5RusJNuBPS7hbqmExPGUx0jedFcP F1b0xm7xA/ki6G27X0F2XITgOgwiX1XnxV2+DKPRVBG7otx6E2KU5Ivys+nOsQjyBw 6Hqd1WmNlBac3eOmZqph0h7xhrHrNgxCd2mmyN7/oVoqR8UHjKjS+Qhx5gTetHUxEE YEt0jEPf3o1go1lges6bP99E5TyXxUi5xd99t1B5PlcHlmLbj3HorDa/HdO7b3TfJG hFAFPTuTH+S4g== Received: by bkemail.birger-koblitz.de (Postfix, from userid 109) id D1EA34965C; Sun, 2 Aug 2026 16:32:37 +0000 (UTC) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688352; bh=Eks2Ad1M0C1NOfXtuLA6GDYamvbAmjbtcWB1L3/MivM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=MGtcfMY+1UJP9BntKKZxMMpHpBB9BLvPLkYBAgon1ZpBkcZ16TpW034YIpZIGO79M UqxuMyAYKl7kdA9+t2vmcfRcMxY897ygy6eX3fJHED7VkV4+XszeXAjeo+3Zqpgv9c FLHYBt2PpH/+WiQrh8bJinhhiT/XA2F3zSuWXUDdDNwI8mcGTl5vsnsCzNkI5hmsLB IEJpivmYDTldu96h++LV4PfsOzo01O37B3ByFfNp04KKBhmBGkwq/f39hfIumLFmqb nal7H3XGTjIq4R1fr0K5piu2vsDEVAQJOF2P3bsN7Nz0xY8IXkV3vsqeVBBLth7Pjy yQA7mHAgBTrog== Received: from ThinkPadAMD.lan (90-227-251-202-no2480.tbcn.telia.com [90.227.251.202]) by bkemail.birger-koblitz.de (Postfix) with ESMTPSA id ED6EF49649; Sun, 2 Aug 2026 16:32:31 +0000 (UTC) From: Birger Koblitz Date: Sun, 02 Aug 2026 18:32:00 +0200 Subject: [PATCH net-next v5 02/13] ax88179_178a: Split driver into library and device specific code Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-ax88179a-v5-2-dcb9fea4acd4@birger-koblitz.de> References: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> In-Reply-To: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Andrew Lunn , Heiner Kallweit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Birger Koblitz , Jianhui Xu X-Mailer: b4 0.14.2 Split the ax88179_178a module code into code common to the AX88179/178a/179a and 279 family of controllers and device specific code for the currently supported devices based on the AX88179 and AX88178a. Rename the module to ax88179 to reflect the broader scope of controllers supported by the module. Signed-off-by: Birger Koblitz Tested-by: Jianhui Xu --- drivers/net/usb/Makefile | 3 +- drivers/net/usb/ax88179_178a.c | 611 +------------------------------------= ---- drivers/net/usb/ax88179_lib.c | 453 ++++++++++++++++++++++++++++++ drivers/net/usb/ax88179_lib.h | 194 +++++++++++++ 4 files changed, 650 insertions(+), 611 deletions(-) diff --git a/drivers/net/usb/Makefile b/drivers/net/usb/Makefile index 4964f7b326fbcedffc1e5a1bf004aea95560db8c..ddd76fa71e2ee670888df1c9715= 632e5c04a8149 100644 --- a/drivers/net/usb/Makefile +++ b/drivers/net/usb/Makefile @@ -12,7 +12,8 @@ obj-$(CONFIG_USB_HSO) +=3D hso.o obj-$(CONFIG_USB_LAN78XX) +=3D lan78xx.o obj-$(CONFIG_USB_NET_AX8817X) +=3D asix.o asix-y :=3D asix_devices.o asix_common.o ax88172a.o -obj-$(CONFIG_USB_NET_AX88179_178A) +=3D ax88179_178a.o +obj-$(CONFIG_USB_NET_AX88179_178A) +=3D ax88179.o +ax88179-y :=3D ax88179_178a.o ax88179_lib.o obj-$(CONFIG_USB_NET_CDCETHER) +=3D cdc_ether.o obj-$(CONFIG_USB_NET_CDC_EEM) +=3D cdc_eem.o obj-$(CONFIG_USB_NET_DM9601) +=3D dm9601.o diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 945c071dfd1d2f0816c779e1a401ac158adc8d99..66464a321dbcfe4370dad97d7ef= d5165983de6e4 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -8,179 +8,12 @@ #include #include #include -#include -#include -#include #include #include - -#define AX88179_PHY_ID 0x03 -#define AX_EEPROM_LEN 0x100 -#define AX88179_EEPROM_MAGIC 0x17900b95 -#define AX_MCAST_FLTSIZE 8 -#define AX_MAX_MCAST 64 -#define AX_INT_PPLS_LINK ((u32)BIT(16)) -#define AX_RXHDR_L4_TYPE_MASK 0x1c -#define AX_RXHDR_L4_TYPE_UDP 4 -#define AX_RXHDR_L4_TYPE_TCP 16 -#define AX_RXHDR_L3CSUM_ERR 2 -#define AX_RXHDR_L4CSUM_ERR 1 -#define AX_RXHDR_CRC_ERR ((u32)BIT(29)) -#define AX_RXHDR_DROP_ERR ((u32)BIT(31)) -#define AX_ACCESS_MAC 0x01 -#define AX_ACCESS_PHY 0x02 -#define AX_ACCESS_EEPROM 0x04 -#define AX_ACCESS_EFUS 0x05 -#define AX_RELOAD_EEPROM_EFUSE 0x06 -#define AX_PAUSE_WATERLVL_LOW 0x54 -#define AX_PAUSE_WATERLVL_HIGH 0x55 - -#define PHYSICAL_LINK_STATUS 0x02 - #define AX_USB_SS 0x04 - #define AX_USB_HS 0x02 - -#define GENERAL_STATUS 0x03 -/* Check AX88179 version. UA1:Bit2 =3D 0, UA2:Bit2 =3D 1 */ - #define AX_SECLD 0x04 - -#define AX_SROM_ADDR 0x07 -#define AX_SROM_CMD 0x0a - #define EEP_RD 0x04 - #define EEP_BUSY 0x10 - -#define AX_SROM_DATA_LOW 0x08 -#define AX_SROM_DATA_HIGH 0x09 - -#define AX_RX_CTL 0x0b - #define AX_RX_CTL_DROPCRCERR 0x0100 - #define AX_RX_CTL_IPE 0x0200 - #define AX_RX_CTL_START 0x0080 - #define AX_RX_CTL_AP 0x0020 - #define AX_RX_CTL_AM 0x0010 - #define AX_RX_CTL_AB 0x0008 - #define AX_RX_CTL_AMALL 0x0002 - #define AX_RX_CTL_PRO 0x0001 - #define AX_RX_CTL_STOP 0x0000 - -#define AX_NODE_ID 0x10 -#define AX_MULFLTARY 0x16 - -#define AX_MEDIUM_STATUS_MODE 0x22 - #define AX_MEDIUM_GIGAMODE 0x01 - #define AX_MEDIUM_FULL_DUPLEX 0x02 - #define AX_MEDIUM_EN_125MHZ 0x08 - #define AX_MEDIUM_RXFLOW_CTRLEN 0x10 - #define AX_MEDIUM_TXFLOW_CTRLEN 0x20 - #define AX_MEDIUM_RECEIVE_EN 0x100 - #define AX_MEDIUM_PS 0x200 - #define AX_MEDIUM_JUMBO_EN 0x8040 - -#define AX_MONITOR_MOD 0x24 - #define AX_MONITOR_MODE_RWLC 0x02 - #define AX_MONITOR_MODE_RWMP 0x04 - #define AX_MONITOR_MODE_PMEPOL 0x20 - #define AX_MONITOR_MODE_PMETYPE 0x40 - -#define AX_GPIO_CTRL 0x25 - #define AX_GPIO_CTRL_GPIO3EN 0x80 - #define AX_GPIO_CTRL_GPIO2EN 0x40 - #define AX_GPIO_CTRL_GPIO1EN 0x20 - -#define AX_PHYPWR_RSTCTL 0x26 - #define AX_PHYPWR_RSTCTL_BZ 0x0010 - #define AX_PHYPWR_RSTCTL_IPRL 0x0020 - #define AX_PHYPWR_RSTCTL_AT 0x1000 - -#define AX_RX_BULKIN_QCTRL 0x2e -#define AX_CLK_SELECT 0x33 - #define AX_CLK_SELECT_BCS 0x01 - #define AX_CLK_SELECT_ACS 0x02 - #define AX_CLK_SELECT_ULR 0x08 - -#define AX_RXCOE_CTL 0x34 - #define AX_RXCOE_IP 0x01 - #define AX_RXCOE_TCP 0x02 - #define AX_RXCOE_UDP 0x04 - #define AX_RXCOE_TCPV6 0x20 - #define AX_RXCOE_UDPV6 0x40 - -#define AX_TXCOE_CTL 0x35 - #define AX_TXCOE_IP 0x01 - #define AX_TXCOE_TCP 0x02 - #define AX_TXCOE_UDP 0x04 - #define AX_TXCOE_TCPV6 0x20 - #define AX_TXCOE_UDPV6 0x40 - -#define AX_LEDCTRL 0x73 - -#define GMII_PHY_PHYSR 0x11 - #define GMII_PHY_PHYSR_SMASK 0xc000 - #define GMII_PHY_PHYSR_GIGA 0x8000 - #define GMII_PHY_PHYSR_100 0x4000 - #define GMII_PHY_PHYSR_FULL 0x2000 - #define GMII_PHY_PHYSR_LINK 0x400 - -#define GMII_LED_ACT 0x1a - #define GMII_LED_ACTIVE_MASK 0xff8f - #define GMII_LED0_ACTIVE BIT(4) - #define GMII_LED1_ACTIVE BIT(5) - #define GMII_LED2_ACTIVE BIT(6) - -#define GMII_LED_LINK 0x1c - #define GMII_LED_LINK_MASK 0xf888 - #define GMII_LED0_LINK_10 BIT(0) - #define GMII_LED0_LINK_100 BIT(1) - #define GMII_LED0_LINK_1000 BIT(2) - #define GMII_LED1_LINK_10 BIT(4) - #define GMII_LED1_LINK_100 BIT(5) - #define GMII_LED1_LINK_1000 BIT(6) - #define GMII_LED2_LINK_10 BIT(8) - #define GMII_LED2_LINK_100 BIT(9) - #define GMII_LED2_LINK_1000 BIT(10) - #define LED0_ACTIVE BIT(0) - #define LED0_LINK_10 BIT(1) - #define LED0_LINK_100 BIT(2) - #define LED0_LINK_1000 BIT(3) - #define LED0_FD BIT(4) - #define LED0_USB3_MASK 0x001f - #define LED1_ACTIVE BIT(5) - #define LED1_LINK_10 BIT(6) - #define LED1_LINK_100 BIT(7) - #define LED1_LINK_1000 BIT(8) - #define LED1_FD BIT(9) - #define LED1_USB3_MASK 0x03e0 - #define LED2_ACTIVE BIT(10) - #define LED2_LINK_1000 BIT(13) - #define LED2_LINK_100 BIT(12) - #define LED2_LINK_10 BIT(11) - #define LED2_FD BIT(14) - #define LED_VALID BIT(15) - #define LED2_USB3_MASK 0x7c00 - -#define GMII_PHYPAGE 0x1e -#define GMII_PHY_PAGE_SELECT 0x1f - #define GMII_PHY_PGSEL_EXT 0x0007 - #define GMII_PHY_PGSEL_PAGE0 0x0000 - #define GMII_PHY_PGSEL_PAGE3 0x0003 - #define GMII_PHY_PGSEL_PAGE5 0x0005 +#include "ax88179_lib.h" =20 static int ax88179_reset(struct usbnet *dev); =20 -struct ax88179_data { - u8 eee_enabled; - u8 eee_active; - u16 rxctl; - u8 in_pm; - u32 wol_supported; - u32 wolopts; - u8 disconnecting; -}; - -struct ax88179_int_data { - __le32 intdata1; - __le32 intdata2; -}; - static const struct { unsigned char ctrl, timer_l, timer_h, size, ifg; } AX88179_BULKIN_SIZE[] =3D { @@ -190,165 +23,6 @@ static const struct { {7, 0xcc, 0x4c, 0x18, 8}, }; =20 -static void ax88179_set_pm_mode(struct usbnet *dev, bool pm_mode) -{ - struct ax88179_data *ax179_data =3D dev->driver_priv; - - ax179_data->in_pm =3D pm_mode; -} - -static int ax88179_in_pm(struct usbnet *dev) -{ - struct ax88179_data *ax179_data =3D dev->driver_priv; - - return ax179_data->in_pm; -} - -static int __ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 i= ndex, - u16 size, void *data) -{ - int ret; - int (*fn)(struct usbnet *, u8, u8, u16, u16, void *, u16); - struct ax88179_data *ax179_data =3D dev->driver_priv; - - BUG_ON(!dev); - - if (!ax88179_in_pm(dev)) - fn =3D usbnet_read_cmd; - else - fn =3D usbnet_read_cmd_nopm; - - ret =3D fn(dev, cmd, USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE, - value, index, data, size); - - if (unlikely((ret < 0) && !(ret =3D=3D -ENODEV && ax179_data->disconnecti= ng))) - netdev_warn(dev->net, "Failed to read reg index 0x%04x: %d\n", - index, ret); - - return ret; -} - -static int __ax88179_write_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 = index, - u16 size, const void *data) -{ - int ret; - int (*fn)(struct usbnet *, u8, u8, u16, u16, const void *, u16); - struct ax88179_data *ax179_data =3D dev->driver_priv; - - BUG_ON(!dev); - - if (!ax88179_in_pm(dev)) - fn =3D usbnet_write_cmd; - else - fn =3D usbnet_write_cmd_nopm; - - ret =3D fn(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE, - value, index, data, size); - - if (unlikely((ret < 0) && !(ret =3D=3D -ENODEV && ax179_data->disconnecti= ng))) - netdev_warn(dev->net, "Failed to write reg index 0x%04x: %d\n", - index, ret); - - return ret; -} - -static void ax88179_write_cmd_async(struct usbnet *dev, u8 cmd, u16 value, - u16 index, u16 size, void *data) -{ - u16 buf; - - if (2 =3D=3D size) { - buf =3D *((u16 *)data); - cpu_to_le16s(&buf); - usbnet_write_cmd_async(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR | - USB_RECIP_DEVICE, value, index, &buf, - size); - } else { - usbnet_write_cmd_async(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR | - USB_RECIP_DEVICE, value, index, data, - size); - } -} - -static int ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 ind= ex, - u16 size, void *data) -{ - int ret; - - if (2 =3D=3D size) { - u16 buf =3D 0; - ret =3D __ax88179_read_cmd(dev, cmd, value, index, size, &buf); - le16_to_cpus(&buf); - *((u16 *)data) =3D buf; - } else if (4 =3D=3D size) { - u32 buf =3D 0; - ret =3D __ax88179_read_cmd(dev, cmd, value, index, size, &buf); - le32_to_cpus(&buf); - *((u32 *)data) =3D buf; - } else { - ret =3D __ax88179_read_cmd(dev, cmd, value, index, size, data); - } - - return ret; -} - -static int ax88179_write_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 in= dex, - u16 size, const void *data) -{ - int ret; - - if (2 =3D=3D size) { - u16 buf; - buf =3D *((u16 *)data); - cpu_to_le16s(&buf); - ret =3D __ax88179_write_cmd(dev, cmd, value, index, - size, &buf); - } else { - ret =3D __ax88179_write_cmd(dev, cmd, value, index, - size, data); - } - - return ret; -} - -static void ax88179_status(struct usbnet *dev, struct urb *urb) -{ - struct ax88179_int_data *event; - u32 link; - - if (urb->actual_length < 8) - return; - - event =3D urb->transfer_buffer; - le32_to_cpus((void *)&event->intdata1); - - link =3D (((__force u32)event->intdata1) & AX_INT_PPLS_LINK) >> 16; - - if (netif_carrier_ok(dev->net) !=3D link) { - usbnet_link_change(dev, link, 1); - if (!link) - netdev_info(dev->net, "ax88179 - Link status is: 0\n"); - } -} - -static int ax88179_mdio_read(struct net_device *netdev, int phy_id, int lo= c) -{ - struct usbnet *dev =3D netdev_priv(netdev); - u16 res; - - ax88179_read_cmd(dev, AX_ACCESS_PHY, phy_id, (__u16)loc, 2, &res); - return res; -} - -static void ax88179_mdio_write(struct net_device *netdev, int phy_id, int = loc, - int val) -{ - struct usbnet *dev =3D netdev_priv(netdev); - u16 res =3D (u16) val; - - ax88179_write_cmd(dev, AX_ACCESS_PHY, phy_id, (__u16)loc, 2, &res); -} - static inline int ax88179_phy_mmd_indirect(struct usbnet *dev, u16 prtad, u16 devad) { @@ -510,146 +184,11 @@ static void ax88179_disconnect(struct usb_interface = *intf) usbnet_disconnect(intf); } =20 -static void -ax88179_get_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo) -{ - struct usbnet *dev =3D netdev_priv(net); - struct ax88179_data *priv =3D dev->driver_priv; - - wolinfo->supported =3D priv->wol_supported; - wolinfo->wolopts =3D priv->wolopts; -} - -static int -ax88179_set_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo) -{ - struct usbnet *dev =3D netdev_priv(net); - struct ax88179_data *priv =3D dev->driver_priv; - - if (wolinfo->wolopts & ~(priv->wol_supported)) - return -EINVAL; - - priv->wolopts =3D wolinfo->wolopts; - - return 0; -} - static int ax88179_get_eeprom_len(struct net_device *net) { return AX_EEPROM_LEN; } =20 -static int -ax88179_get_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom, - u8 *data) -{ - struct usbnet *dev =3D netdev_priv(net); - u16 *eeprom_buff; - int first_word, last_word; - int i, ret; - - if (eeprom->len =3D=3D 0) - return -EINVAL; - - eeprom->magic =3D AX88179_EEPROM_MAGIC; - - first_word =3D eeprom->offset >> 1; - last_word =3D (eeprom->offset + eeprom->len - 1) >> 1; - eeprom_buff =3D kmalloc_array(last_word - first_word + 1, sizeof(u16), - GFP_KERNEL); - if (!eeprom_buff) - return -ENOMEM; - - /* ax88179/178A returns 2 bytes from eeprom on read */ - for (i =3D first_word; i <=3D last_word; i++) { - ret =3D __ax88179_read_cmd(dev, AX_ACCESS_EEPROM, i, 1, 2, - &eeprom_buff[i - first_word]); - if (ret < 0) { - kfree(eeprom_buff); - return -EIO; - } - } - - memcpy(data, (u8 *)eeprom_buff + (eeprom->offset & 1), eeprom->len); - kfree(eeprom_buff); - return 0; -} - -static int -ax88179_set_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom, - u8 *data) -{ - struct usbnet *dev =3D netdev_priv(net); - u16 *eeprom_buff; - int first_word; - int last_word; - int ret; - int i; - - netdev_dbg(net, "write EEPROM len %d, offset %d, magic 0x%x\n", - eeprom->len, eeprom->offset, eeprom->magic); - - if (eeprom->len =3D=3D 0) - return -EINVAL; - - if (eeprom->magic !=3D AX88179_EEPROM_MAGIC) - return -EINVAL; - - first_word =3D eeprom->offset >> 1; - last_word =3D (eeprom->offset + eeprom->len - 1) >> 1; - - eeprom_buff =3D kmalloc_array(last_word - first_word + 1, sizeof(u16), - GFP_KERNEL); - if (!eeprom_buff) - return -ENOMEM; - - /* align data to 16 bit boundaries, read the missing data from - the EEPROM */ - if (eeprom->offset & 1) { - ret =3D ax88179_read_cmd(dev, AX_ACCESS_EEPROM, first_word, 1, 2, - &eeprom_buff[0]); - if (ret < 0) { - netdev_err(net, "Failed to read EEPROM at offset 0x%02x.\n", first_word= ); - goto free; - } - } - - if ((eeprom->offset + eeprom->len) & 1) { - ret =3D ax88179_read_cmd(dev, AX_ACCESS_EEPROM, last_word, 1, 2, - &eeprom_buff[last_word - first_word]); - if (ret < 0) { - netdev_err(net, "Failed to read EEPROM at offset 0x%02x.\n", last_word); - goto free; - } - } - - memcpy((u8 *)eeprom_buff + (eeprom->offset & 1), data, eeprom->len); - - for (i =3D first_word; i <=3D last_word; i++) { - netdev_dbg(net, "write to EEPROM at offset 0x%02x, data 0x%04x\n", - i, eeprom_buff[i - first_word]); - ret =3D ax88179_write_cmd(dev, AX_ACCESS_EEPROM, i, 1, 2, - &eeprom_buff[i - first_word]); - if (ret < 0) { - netdev_err(net, "Failed to write EEPROM at offset 0x%02x.\n", i); - goto free; - } - msleep(20); - } - - /* reload EEPROM data */ - ret =3D ax88179_write_cmd(dev, AX_RELOAD_EEPROM_EFUSE, 0x0000, 0, 0, NULL= ); - if (ret < 0) { - netdev_err(net, "Failed to reload EEPROM data\n"); - goto free; - } - - ret =3D 0; -free: - kfree(eeprom_buff); - return ret; -} - static int ax88179_get_link_ksettings(struct net_device *net, struct ethtool_link_ksettings *cmd) { @@ -864,125 +403,6 @@ static const struct ethtool_ops ax88179_ethtool_ops = =3D { .get_ts_info =3D ethtool_op_get_ts_info, }; =20 -static void ax88179_set_multicast(struct net_device *net) -{ - struct usbnet *dev =3D netdev_priv(net); - struct ax88179_data *data =3D dev->driver_priv; - u8 *m_filter =3D ((u8 *)dev->data); - - data->rxctl =3D (AX_RX_CTL_START | AX_RX_CTL_AB | AX_RX_CTL_IPE); - - if (net->flags & IFF_PROMISC) { - data->rxctl |=3D AX_RX_CTL_PRO; - } else if (net->flags & IFF_ALLMULTI || - netdev_mc_count(net) > AX_MAX_MCAST) { - data->rxctl |=3D AX_RX_CTL_AMALL; - } else if (netdev_mc_empty(net)) { - /* just broadcast and directed */ - } else { - /* We use dev->data for our 8 byte filter buffer - * to avoid allocating memory that is tricky to free later - */ - u32 crc_bits; - struct netdev_hw_addr *ha; - - memset(m_filter, 0, AX_MCAST_FLTSIZE); - - netdev_for_each_mc_addr(ha, net) { - crc_bits =3D ether_crc(ETH_ALEN, ha->addr) >> 26; - *(m_filter + (crc_bits >> 3)) |=3D (1 << (crc_bits & 7)); - } - - ax88179_write_cmd_async(dev, AX_ACCESS_MAC, AX_MULFLTARY, - AX_MCAST_FLTSIZE, AX_MCAST_FLTSIZE, - m_filter); - - data->rxctl |=3D AX_RX_CTL_AM; - } - - ax88179_write_cmd_async(dev, AX_ACCESS_MAC, AX_RX_CTL, - 2, 2, &data->rxctl); -} - -static int -ax88179_set_features(struct net_device *net, netdev_features_t features) -{ - u8 tmp; - struct usbnet *dev =3D netdev_priv(net); - netdev_features_t changed =3D net->features ^ features; - - if (changed & NETIF_F_IP_CSUM) { - ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp); - tmp ^=3D AX_TXCOE_TCP | AX_TXCOE_UDP; - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp); - } - - if (changed & NETIF_F_IPV6_CSUM) { - ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp); - tmp ^=3D AX_TXCOE_TCPV6 | AX_TXCOE_UDPV6; - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp); - } - - if (changed & NETIF_F_RXCSUM) { - ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 1, &tmp); - tmp ^=3D AX_RXCOE_IP | AX_RXCOE_TCP | AX_RXCOE_UDP | - AX_RXCOE_TCPV6 | AX_RXCOE_UDPV6; - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 1, &tmp); - } - - return 0; -} - -static int ax88179_change_mtu(struct net_device *net, int new_mtu) -{ - struct usbnet *dev =3D netdev_priv(net); - u16 tmp16; - - WRITE_ONCE(net->mtu, new_mtu); - dev->hard_mtu =3D net->mtu + net->hard_header_len; - - if (net->mtu > 1500) { - ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, - 2, 2, &tmp16); - tmp16 |=3D AX_MEDIUM_JUMBO_EN; - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, - 2, 2, &tmp16); - } else { - ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, - 2, 2, &tmp16); - tmp16 &=3D ~AX_MEDIUM_JUMBO_EN; - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, - 2, 2, &tmp16); - } - - /* max qlen depend on hard_mtu and rx_urb_size */ - usbnet_update_max_qlen(dev); - - return 0; -} - -static int ax88179_set_mac_addr(struct net_device *net, void *p) -{ - struct usbnet *dev =3D netdev_priv(net); - struct sockaddr *addr =3D p; - int ret; - - if (netif_running(net)) - return -EBUSY; - if (!is_valid_ether_addr(addr->sa_data)) - return -EADDRNOTAVAIL; - - eth_hw_addr_set(net, addr->sa_data); - - /* Set the MAC address */ - ret =3D ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, - ETH_ALEN, net->dev_addr); - if (ret < 0) - return ret; - - return 0; -} - static const struct net_device_ops ax88179_netdev_ops =3D { .ndo_open =3D usbnet_open, .ndo_stop =3D usbnet_stop, @@ -1249,35 +669,6 @@ static int ax88179_led_setting(struct usbnet *dev) return 0; } =20 -static void ax88179_get_mac_addr(struct usbnet *dev) -{ - u8 mac[ETH_ALEN]; - - memset(mac, 0, sizeof(mac)); - - /* Maybe the boot loader passed the MAC address via device tree */ - if (!eth_platform_get_mac_address(&dev->udev->dev, mac)) { - netif_dbg(dev, ifup, dev->net, - "MAC address read from device tree"); - } else { - ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, - ETH_ALEN, mac); - netif_dbg(dev, ifup, dev->net, - "MAC address read from ASIX chip"); - } - - if (is_valid_ether_addr(mac)) { - eth_hw_addr_set(dev->net, mac); - if (!is_local_ether_addr(mac)) - dev->net->addr_assign_type =3D NET_ADDR_PERM; - } else { - netdev_info(dev->net, "invalid MAC address, using random\n"); - } - - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN, - dev->net->dev_addr); -} - static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf) { struct ax88179_data *ax179_data; diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c new file mode 100644 index 0000000000000000000000000000000000000000..7b5c17a01df2deac2cc0210bc88= 193be1abfbe23 --- /dev/null +++ b/drivers/net/usb/ax88179_lib.c @@ -0,0 +1,453 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * ASIX AX88179/178A USB 3.0/2.0 to Gigabit Ethernet Devices + * + * Copyright (C) 2011-2013 ASIX + */ + +#include +#include "ax88179_lib.h" + +void ax88179_set_pm_mode(struct usbnet *dev, bool pm_mode) +{ + struct ax88179_data *ax179_data =3D dev->driver_priv; + + ax179_data->in_pm =3D pm_mode; +} + +static int ax88179_in_pm(struct usbnet *dev) +{ + struct ax88179_data *ax179_data =3D dev->driver_priv; + + return ax179_data->in_pm; +} + +int __ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, + u16 size, void *data) +{ + int ret; + int (*fn)(struct usbnet *dev, u8 cmd, u8 rtype, u16 val, u16 i, void *d, = u16 size); + struct ax88179_data *ax179_data =3D dev->driver_priv; + + if (!dev) { + netdev_err(dev->net, "No net device.\n"); + return -ENODEV; + } + + if (!ax88179_in_pm(dev)) + fn =3D usbnet_read_cmd; + else + fn =3D usbnet_read_cmd_nopm; + + ret =3D fn(dev, cmd, USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE, + value, index, data, size); + + if (unlikely(ret < 0 && !(ret =3D=3D -ENODEV && ax179_data->disconnecting= ))) + netdev_warn(dev->net, "Failed to read reg index 0x%04x: %d\n", + index, ret); + + return ret; +} + +static int __ax88179_write_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 = index, + u16 size, const void *data) +{ + int ret; + int (*fn)(struct usbnet *dev, u8 cmd, u8 rtype, u16 val, u16 i, const voi= d *d, u16 size); + struct ax88179_data *ax179_data =3D dev->driver_priv; + + if (!dev) { + netdev_err(dev->net, "No net device.\n"); + return -ENODEV; + } + + if (!ax88179_in_pm(dev)) + fn =3D usbnet_write_cmd; + else + fn =3D usbnet_write_cmd_nopm; + + ret =3D fn(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE, + value, index, data, size); + + if (unlikely(ret < 0 && !(ret =3D=3D -ENODEV && ax179_data->disconnecting= ))) + netdev_warn(dev->net, "Failed to write reg index 0x%04x: %d\n", + index, ret); + + return ret; +} + +void ax88179_write_cmd_async(struct usbnet *dev, u8 cmd, u16 value, u16 in= dex, u16 size, + void *data) +{ + u16 buf; + + if (size =3D=3D 2) { + buf =3D *((u16 *)data); + cpu_to_le16s(&buf); + usbnet_write_cmd_async(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR | + USB_RECIP_DEVICE, value, index, &buf, + size); + } else { + usbnet_write_cmd_async(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR | + USB_RECIP_DEVICE, value, index, data, + size); + } +} + +int ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, u16= size, void *data) +{ + int ret; + + if (size =3D=3D 2) { + u16 buf =3D 0; + + ret =3D __ax88179_read_cmd(dev, cmd, value, index, size, &buf); + le16_to_cpus(&buf); + *((u16 *)data) =3D buf; + } else if (size =3D=3D 2) { + u32 buf =3D 0; + + ret =3D __ax88179_read_cmd(dev, cmd, value, index, size, &buf); + le32_to_cpus(&buf); + *((u32 *)data) =3D buf; + } else { + ret =3D __ax88179_read_cmd(dev, cmd, value, index, size, data); + } + + return ret; +} + +int ax88179_write_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, u1= 6 size, + const void *data) +{ + int ret; + + if (size =3D=3D 2) { + u16 buf; + + buf =3D *((u16 *)data); + cpu_to_le16s(&buf); + ret =3D __ax88179_write_cmd(dev, cmd, value, index, + size, &buf); + } else { + ret =3D __ax88179_write_cmd(dev, cmd, value, index, + size, data); + } + + return ret; +} + +void ax88179_status(struct usbnet *dev, struct urb *urb) +{ + struct ax88179_int_data *event; + u32 link; + + if (urb->actual_length < 8) + return; + + event =3D urb->transfer_buffer; + le32_to_cpus((void *)&event->intdata1); + + link =3D (((__force u32)event->intdata1) & AX_INT_PPLS_LINK) >> 16; + + if (netif_carrier_ok(dev->net) !=3D link) { + usbnet_link_change(dev, link, 1); + if (!link) + netdev_info(dev->net, "ax88179 - Link status is: 0\n"); + } +} + +int ax88179_mdio_read(struct net_device *netdev, int phy_id, int loc) +{ + struct usbnet *dev =3D netdev_priv(netdev); + u16 res; + + ax88179_read_cmd(dev, AX_ACCESS_PHY, phy_id, (__u16)loc, 2, &res); + return res; +} + +void ax88179_mdio_write(struct net_device *netdev, int phy_id, int loc, in= t val) +{ + struct usbnet *dev =3D netdev_priv(netdev); + u16 res =3D (u16)val; + + ax88179_write_cmd(dev, AX_ACCESS_PHY, phy_id, (__u16)loc, 2, &res); +} + +void ax88179_get_wol(struct net_device *net, struct ethtool_wolinfo *wolin= fo) +{ + struct usbnet *dev =3D netdev_priv(net); + struct ax88179_data *priv =3D dev->driver_priv; + + wolinfo->supported =3D priv->wol_supported; + wolinfo->wolopts =3D priv->wolopts; +} + +int ax88179_set_wol(struct net_device *net, struct ethtool_wolinfo *wolinf= o) +{ + struct usbnet *dev =3D netdev_priv(net); + struct ax88179_data *priv =3D dev->driver_priv; + + if (wolinfo->wolopts & ~(priv->wol_supported)) + return -EINVAL; + + priv->wolopts =3D wolinfo->wolopts; + + return 0; +} + +int ax88179_get_eeprom(struct net_device *net, struct ethtool_eeprom *eepr= om, u8 *data) +{ + struct usbnet *dev =3D netdev_priv(net); + u16 *eeprom_buff; + int first_word, last_word; + int i, ret; + + if (eeprom->len =3D=3D 0) + return -EINVAL; + + eeprom->magic =3D AX88179_EEPROM_MAGIC; + + first_word =3D eeprom->offset >> 1; + last_word =3D (eeprom->offset + eeprom->len - 1) >> 1; + eeprom_buff =3D kmalloc_array(last_word - first_word + 1, sizeof(u16), + GFP_KERNEL); + if (!eeprom_buff) + return -ENOMEM; + + /* ax88179/178A returns 2 bytes from eeprom on read */ + for (i =3D first_word; i <=3D last_word; i++) { + ret =3D __ax88179_read_cmd(dev, AX_ACCESS_EEPROM, i, 1, 2, + &eeprom_buff[i - first_word]); + if (ret < 0) { + kfree(eeprom_buff); + return -EIO; + } + } + + memcpy(data, (u8 *)eeprom_buff + (eeprom->offset & 1), eeprom->len); + kfree(eeprom_buff); + return 0; +} + +int ax88179_set_eeprom(struct net_device *net, struct ethtool_eeprom *eepr= om, u8 *data) +{ + struct usbnet *dev =3D netdev_priv(net); + u16 *eeprom_buff; + int first_word; + int last_word; + int ret; + int i; + + netdev_dbg(net, "write EEPROM len %d, offset %d, magic 0x%x\n", + eeprom->len, eeprom->offset, eeprom->magic); + + if (eeprom->len =3D=3D 0) + return -EINVAL; + + if (eeprom->magic !=3D AX88179_EEPROM_MAGIC) + return -EINVAL; + + first_word =3D eeprom->offset >> 1; + last_word =3D (eeprom->offset + eeprom->len - 1) >> 1; + + eeprom_buff =3D kmalloc_array(last_word - first_word + 1, sizeof(u16), + GFP_KERNEL); + if (!eeprom_buff) + return -ENOMEM; + + /* align data to 16 bit boundaries, read the missing data from + * the EEPROM + */ + if (eeprom->offset & 1) { + ret =3D ax88179_read_cmd(dev, AX_ACCESS_EEPROM, first_word, 1, 2, + &eeprom_buff[0]); + if (ret < 0) { + netdev_err(net, "Failed to read EEPROM at offset 0x%02x.\n", first_word= ); + goto free; + } + } + + if ((eeprom->offset + eeprom->len) & 1) { + ret =3D ax88179_read_cmd(dev, AX_ACCESS_EEPROM, last_word, 1, 2, + &eeprom_buff[last_word - first_word]); + if (ret < 0) { + netdev_err(net, "Failed to read EEPROM at offset 0x%02x.\n", last_word); + goto free; + } + } + + memcpy((u8 *)eeprom_buff + (eeprom->offset & 1), data, eeprom->len); + + for (i =3D first_word; i <=3D last_word; i++) { + netdev_dbg(net, "write to EEPROM at offset 0x%02x, data 0x%04x\n", + i, eeprom_buff[i - first_word]); + ret =3D ax88179_write_cmd(dev, AX_ACCESS_EEPROM, i, 1, 2, + &eeprom_buff[i - first_word]); + if (ret < 0) { + netdev_err(net, "Failed to write EEPROM at offset 0x%02x.\n", i); + goto free; + } + msleep(20); + } + + /* reload EEPROM data */ + ret =3D ax88179_write_cmd(dev, AX_RELOAD_EEPROM_EFUSE, 0x0000, 0, 0, NULL= ); + if (ret < 0) { + netdev_err(net, "Failed to reload EEPROM data\n"); + goto free; + } + + ret =3D 0; +free: + kfree(eeprom_buff); + return ret; +} + +void ax88179_set_multicast(struct net_device *net) +{ + struct usbnet *dev =3D netdev_priv(net); + struct ax88179_data *data =3D dev->driver_priv; + u8 *m_filter =3D ((u8 *)dev->data); + + data->rxctl =3D (AX_RX_CTL_START | AX_RX_CTL_AB | AX_RX_CTL_IPE); + + if (net->flags & IFF_PROMISC) { + data->rxctl |=3D AX_RX_CTL_PRO; + } else if (net->flags & IFF_ALLMULTI || + netdev_mc_count(net) > AX_MAX_MCAST) { + data->rxctl |=3D AX_RX_CTL_AMALL; + } else if (netdev_mc_empty(net)) { + /* just broadcast and directed */ + } else { + /* We use dev->data for our 8 byte filter buffer + * to avoid allocating memory that is tricky to free later + */ + u32 crc_bits; + struct netdev_hw_addr *ha; + + memset(m_filter, 0, AX_MCAST_FLTSIZE); + + netdev_for_each_mc_addr(ha, net) { + crc_bits =3D ether_crc(ETH_ALEN, ha->addr) >> 26; + *(m_filter + (crc_bits >> 3)) |=3D (1 << (crc_bits & 7)); + } + + ax88179_write_cmd_async(dev, AX_ACCESS_MAC, AX_MULFLTARY, + AX_MCAST_FLTSIZE, AX_MCAST_FLTSIZE, + m_filter); + + data->rxctl |=3D AX_RX_CTL_AM; + } + + ax88179_write_cmd_async(dev, AX_ACCESS_MAC, AX_RX_CTL, + 2, 2, &data->rxctl); +} + +int ax88179_set_features(struct net_device *net, netdev_features_t feature= s) +{ + u8 tmp; + struct usbnet *dev =3D netdev_priv(net); + netdev_features_t changed =3D net->features ^ features; + + if (changed & NETIF_F_IP_CSUM) { + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp); + tmp ^=3D AX_TXCOE_TCP | AX_TXCOE_UDP; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp); + } + + if (changed & NETIF_F_IPV6_CSUM) { + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp); + tmp ^=3D AX_TXCOE_TCPV6 | AX_TXCOE_UDPV6; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp); + } + + if (changed & NETIF_F_RXCSUM) { + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 1, &tmp); + tmp ^=3D AX_RXCOE_IP | AX_RXCOE_TCP | AX_RXCOE_UDP | + AX_RXCOE_TCPV6 | AX_RXCOE_UDPV6; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 1, &tmp); + } + + return 0; +} + +void ax88179_get_mac_addr(struct usbnet *dev) +{ + u8 mac[ETH_ALEN]; + + memset(mac, 0, sizeof(mac)); + + /* Maybe the boot loader passed the MAC address via device tree */ + if (!eth_platform_get_mac_address(&dev->udev->dev, mac)) { + netif_dbg(dev, ifup, dev->net, + "MAC address read from device tree"); + } else { + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, + ETH_ALEN, mac); + netif_dbg(dev, ifup, dev->net, + "MAC address read from ASIX chip"); + } + + if (is_valid_ether_addr(mac)) { + eth_hw_addr_set(dev->net, mac); + if (!is_local_ether_addr(mac)) + dev->net->addr_assign_type =3D NET_ADDR_PERM; + } else { + netdev_info(dev->net, "invalid MAC address, using random\n"); + } + + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN, + dev->net->dev_addr); +} + +int ax88179_change_mtu(struct net_device *net, int new_mtu) +{ + struct usbnet *dev =3D netdev_priv(net); + u16 tmp16; + + WRITE_ONCE(net->mtu, new_mtu); + dev->hard_mtu =3D net->mtu + net->hard_header_len; + + if (net->mtu > 1500) { + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, + 2, 2, &tmp16); + tmp16 |=3D AX_MEDIUM_JUMBO_EN; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, + 2, 2, &tmp16); + } else { + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, + 2, 2, &tmp16); + tmp16 &=3D ~AX_MEDIUM_JUMBO_EN; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, + 2, 2, &tmp16); + } + + /* max qlen depend on hard_mtu and rx_urb_size */ + usbnet_update_max_qlen(dev); + + return 0; +} + +int ax88179_set_mac_addr(struct net_device *net, void *p) +{ + struct usbnet *dev =3D netdev_priv(net); + struct sockaddr *addr =3D p; + int ret; + + if (netif_running(net)) + return -EBUSY; + if (!is_valid_ether_addr(addr->sa_data)) + return -EADDRNOTAVAIL; + + eth_hw_addr_set(net, addr->sa_data); + + /* Set the MAC address */ + ret =3D ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, + ETH_ALEN, net->dev_addr); + if (ret < 0) + return ret; + + return 0; +} + diff --git a/drivers/net/usb/ax88179_lib.h b/drivers/net/usb/ax88179_lib.h new file mode 100644 index 0000000000000000000000000000000000000000..b2ee1356727cf4b3fa05f0b0d5f= d863ac3f9a87d --- /dev/null +++ b/drivers/net/usb/ax88179_lib.h @@ -0,0 +1,194 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include +#include +#include + +#ifndef __LINUX_USBNET_AX88179_H +#define __LINUX_USBNET_AX88179_H + +#define AX88179_PHY_ID 0x03 +#define AX_EEPROM_LEN 0x100 +#define AX88179_EEPROM_MAGIC 0x17900b95 +#define AX_MCAST_FLTSIZE 8 +#define AX_MAX_MCAST 64 +#define AX_INT_PPLS_LINK ((u32)BIT(16)) +#define AX_RXHDR_L4_TYPE_MASK 0x1c +#define AX_RXHDR_L4_TYPE_UDP 4 +#define AX_RXHDR_L4_TYPE_TCP 16 +#define AX_RXHDR_L3CSUM_ERR 2 +#define AX_RXHDR_L4CSUM_ERR 1 +#define AX_RXHDR_CRC_ERR ((u32)BIT(29)) +#define AX_RXHDR_DROP_ERR ((u32)BIT(31)) +#define AX_ACCESS_MAC 0x01 +#define AX_ACCESS_PHY 0x02 +#define AX_ACCESS_EEPROM 0x04 +#define AX_ACCESS_EFUS 0x05 +#define AX_RELOAD_EEPROM_EFUSE 0x06 +#define AX_PAUSE_WATERLVL_LOW 0x54 +#define AX_PAUSE_WATERLVL_HIGH 0x55 + +#define PHYSICAL_LINK_STATUS 0x02 + #define AX_USB_SS 0x04 + #define AX_USB_HS 0x02 + +#define GENERAL_STATUS 0x03 +/* Check AX88179 version. UA1:Bit2 =3D 0, UA2:Bit2 =3D 1 */ + #define AX_SECLD 0x04 + +#define AX_SROM_ADDR 0x07 +#define AX_SROM_CMD 0x0a + #define EEP_RD 0x04 + #define EEP_BUSY 0x10 + +#define AX_SROM_DATA_LOW 0x08 +#define AX_SROM_DATA_HIGH 0x09 + +#define AX_RX_CTL 0x0b + #define AX_RX_CTL_DROPCRCERR 0x0100 + #define AX_RX_CTL_IPE 0x0200 + #define AX_RX_CTL_START 0x0080 + #define AX_RX_CTL_AP 0x0020 + #define AX_RX_CTL_AM 0x0010 + #define AX_RX_CTL_AB 0x0008 + #define AX_RX_CTL_AMALL 0x0002 + #define AX_RX_CTL_PRO 0x0001 + #define AX_RX_CTL_STOP 0x0000 + +#define AX_NODE_ID 0x10 +#define AX_MULFLTARY 0x16 + +#define AX_MEDIUM_STATUS_MODE 0x22 + #define AX_MEDIUM_GIGAMODE 0x01 + #define AX_MEDIUM_FULL_DUPLEX 0x02 + #define AX_MEDIUM_EN_125MHZ 0x08 + #define AX_MEDIUM_RXFLOW_CTRLEN 0x10 + #define AX_MEDIUM_TXFLOW_CTRLEN 0x20 + #define AX_MEDIUM_RECEIVE_EN 0x100 + #define AX_MEDIUM_PS 0x200 + #define AX_MEDIUM_JUMBO_EN 0x8040 + +#define AX_MONITOR_MOD 0x24 + #define AX_MONITOR_MODE_RWLC 0x02 + #define AX_MONITOR_MODE_RWMP 0x04 + #define AX_MONITOR_MODE_PMEPOL 0x20 + #define AX_MONITOR_MODE_PMETYPE 0x40 + +#define AX_GPIO_CTRL 0x25 + #define AX_GPIO_CTRL_GPIO3EN 0x80 + #define AX_GPIO_CTRL_GPIO2EN 0x40 + #define AX_GPIO_CTRL_GPIO1EN 0x20 + +#define AX_PHYPWR_RSTCTL 0x26 + #define AX_PHYPWR_RSTCTL_BZ 0x0010 + #define AX_PHYPWR_RSTCTL_IPRL 0x0020 + #define AX_PHYPWR_RSTCTL_AT 0x1000 + +#define AX_RX_BULKIN_QCTRL 0x2e +#define AX_CLK_SELECT 0x33 + #define AX_CLK_SELECT_BCS 0x01 + #define AX_CLK_SELECT_ACS 0x02 + #define AX_CLK_SELECT_ULR 0x08 + +#define AX_RXCOE_CTL 0x34 + #define AX_RXCOE_IP 0x01 + #define AX_RXCOE_TCP 0x02 + #define AX_RXCOE_UDP 0x04 + #define AX_RXCOE_TCPV6 0x20 + #define AX_RXCOE_UDPV6 0x40 + +#define AX_TXCOE_CTL 0x35 + #define AX_TXCOE_IP 0x01 + #define AX_TXCOE_TCP 0x02 + #define AX_TXCOE_UDP 0x04 + #define AX_TXCOE_TCPV6 0x20 + #define AX_TXCOE_UDPV6 0x40 + +#define AX_LEDCTRL 0x73 + +#define GMII_PHY_PHYSR 0x11 + #define GMII_PHY_PHYSR_SMASK 0xc000 + #define GMII_PHY_PHYSR_GIGA 0x8000 + #define GMII_PHY_PHYSR_100 0x4000 + #define GMII_PHY_PHYSR_FULL 0x2000 + #define GMII_PHY_PHYSR_LINK 0x400 + +#define GMII_LED_ACT 0x1a + #define GMII_LED_ACTIVE_MASK 0xff8f + #define GMII_LED0_ACTIVE BIT(4) + #define GMII_LED1_ACTIVE BIT(5) + #define GMII_LED2_ACTIVE BIT(6) + +#define GMII_LED_LINK 0x1c + #define GMII_LED_LINK_MASK 0xf888 + #define GMII_LED0_LINK_10 BIT(0) + #define GMII_LED0_LINK_100 BIT(1) + #define GMII_LED0_LINK_1000 BIT(2) + #define GMII_LED1_LINK_10 BIT(4) + #define GMII_LED1_LINK_100 BIT(5) + #define GMII_LED1_LINK_1000 BIT(6) + #define GMII_LED2_LINK_10 BIT(8) + #define GMII_LED2_LINK_100 BIT(9) + #define GMII_LED2_LINK_1000 BIT(10) + #define LED0_ACTIVE BIT(0) + #define LED0_LINK_10 BIT(1) + #define LED0_LINK_100 BIT(2) + #define LED0_LINK_1000 BIT(3) + #define LED0_FD BIT(4) + #define LED0_USB3_MASK 0x001f + #define LED1_ACTIVE BIT(5) + #define LED1_LINK_10 BIT(6) + #define LED1_LINK_100 BIT(7) + #define LED1_LINK_1000 BIT(8) + #define LED1_FD BIT(9) + #define LED1_USB3_MASK 0x03e0 + #define LED2_ACTIVE BIT(10) + #define LED2_LINK_1000 BIT(13) + #define LED2_LINK_100 BIT(12) + #define LED2_LINK_10 BIT(11) + #define LED2_FD BIT(14) + #define LED_VALID BIT(15) + #define LED2_USB3_MASK 0x7c00 + +#define GMII_PHYPAGE 0x1e +#define GMII_PHY_PAGE_SELECT 0x1f + #define GMII_PHY_PGSEL_EXT 0x0007 + #define GMII_PHY_PGSEL_PAGE0 0x0000 + #define GMII_PHY_PGSEL_PAGE3 0x0003 + #define GMII_PHY_PGSEL_PAGE5 0x0005 + +struct ax88179_data { + u8 eee_enabled; + u8 eee_active; + u16 rxctl; + u8 in_pm; + u32 wol_supported; + u32 wolopts; + u8 disconnecting; +}; + +struct ax88179_int_data { + __le32 intdata1; + __le32 intdata2; +}; + +void ax88179_set_pm_mode(struct usbnet *dev, bool pm_mode); +int __ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, u= 16 size, void *data); +int ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, u16= size, void *data); +int ax88179_write_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, u1= 6 size, + const void *data); +void ax88179_write_cmd_async(struct usbnet *dev, u8 cmd, u16 value, u16 in= dex, + u16 size, void *data); +int ax88179_mdio_read(struct net_device *netdev, int phy_id, int loc); +void ax88179_mdio_write(struct net_device *netdev, int phy_id, int loc, in= t val); +void ax88179_status(struct usbnet *dev, struct urb *urb); +void ax88179_get_wol(struct net_device *net, struct ethtool_wolinfo *wolin= fo); +int ax88179_set_wol(struct net_device *net, struct ethtool_wolinfo *wolinf= o); +int ax88179_get_eeprom(struct net_device *net, struct ethtool_eeprom *eepr= om, u8 *data); +int ax88179_set_eeprom(struct net_device *net, struct ethtool_eeprom *eepr= om, u8 *data); +void ax88179_set_multicast(struct net_device *net); +int ax88179_set_features(struct net_device *net, netdev_features_t feature= s); +void ax88179_get_mac_addr(struct usbnet *dev); +int ax88179_change_mtu(struct net_device *net, int new_mtu); +int ax88179_set_mac_addr(struct net_device *net, void *p); +#endif /*__LINUX_USBNET_AX88179_H */ --=20 2.47.3 From nobody Fri Oct 2 10:08:42 2026 Received: from bkemail.birger-koblitz.de (bkemail.birger-koblitz.de [23.88.97.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AB4D3C1996; Sun, 2 Aug 2026 16:32:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.97.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688365; cv=none; b=fg4V1JWLFchAMw05D6YHrYL1vKzGRWtgyE6Nd2pdngSPnL6fj/9gOtaSkKOIv6wxy8n1Kd6rLHQz/qgQ9L2nEanX54dsNg+ppOfCdy6Ncl19BIoR3sCE9GX6bNN9VHFcQy2FV2EMHSuDQqoaz6dSsbAwuzs82HDlCG6LoL5uaJA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688365; c=relaxed/simple; bh=itokd5pFa1OVLpnstzL/mOuxLye8/+3saVZKgfJxPEM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cXth9s+dNmlUCIm9EtkXwY7gaSoVOPhZ4wsTFezNoYzoJfQ9igHF6Bh4FLrGAlrr8Ywb3zuImY1NpkQC3NnBFsAGGpSRX1ZKPUDPXPHxFS3IRF7rG/ZZ6oz4aLL6h9vBJvTPUQJ6EHZMDynFNWHfCtjpGmLydorhumD7DAdpcPg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de; spf=pass smtp.mailfrom=birger-koblitz.de; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=jvQ0Q03T; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=vVBqyRqJ; arc=none smtp.client-ip=23.88.97.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="jvQ0Q03T"; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="vVBqyRqJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688357; bh=itokd5pFa1OVLpnstzL/mOuxLye8/+3saVZKgfJxPEM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=jvQ0Q03Tak0xaTFGr4cuT3jDSsL6NAi9bhx2Ipa0iBuedhwAVHToJjNFMzLoQHL70 4zEiqbMzT2W/a9aFdUFzC7N86aFXxm40qgXWZQEZzKxtZNCdjtcYqCtEbX3IK9obgn nRCl1nsecWpiC4XOmtjn8KvmIGN9TSZk+IFw+eq054JalXaPIKXBb01Stl0qrrbcWD HU2B6WWmuBh0hyGPAKgip7SUrgHrWA+8aaQodkcOfe67bel9/YoakwHJTWUeAPqNqZ lXmTPjMxu4v+MzyUdSHDPd1zgaADdmN8y5PENsoSpIKJKAaYISjUysjarTM3WkoO1z ijBfZ+llIjJTA== Received: by bkemail.birger-koblitz.de (Postfix, from userid 109) id 7F9AA49650; Sun, 2 Aug 2026 16:32:37 +0000 (UTC) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688353; bh=itokd5pFa1OVLpnstzL/mOuxLye8/+3saVZKgfJxPEM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=vVBqyRqJqPQUoD+H/nbyC9p2AHG6lSjXgC9dC9zzbp1M5w8X+C3qYxA8fDImK/fCO FlvlTVq+EFOQalEH916KSnFanfGsn5cKMjNIC7HjMgQMH0Pg2+puXIe2zsSOFl9qHv qs8uVhReOdQe3R74EU64Rtgmg5ZIJ4Y94boucnz356uqeFNBHEQvEAqt3hvdB4Aq+N 0a7qAXsV0OeSUcrvnzvkM+YrpENaKn8VzqqI6z/qaYsrH78uTiJU8CZ2rYH3mvlrSQ 8mhebGhDk6C4fQjc2Odee2GgpU9Ffv8810iDOIMRp4Ck3vyiNH90riK8gvYcrbaphu 0l9oMbY1JubBA== Received: from ThinkPadAMD.lan (90-227-251-202-no2480.tbcn.telia.com [90.227.251.202]) by bkemail.birger-koblitz.de (Postfix) with ESMTPSA id 8F4BA4964E; Sun, 2 Aug 2026 16:32:32 +0000 (UTC) From: Birger Koblitz Date: Sun, 02 Aug 2026 18:32:01 +0200 Subject: [PATCH net-next v5 03/13] ax88179_178a: Add netdev2data() convenience function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-ax88179a-v5-3-dcb9fea4acd4@birger-koblitz.de> References: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> In-Reply-To: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Andrew Lunn , Heiner Kallweit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Birger Koblitz , Jianhui Xu X-Mailer: b4 0.14.2 Add a convenience function for the ethtool ops that use phylink and need to retrieve the ax88179_data structure from net_device. Signed-off-by: Birger Koblitz Reviewed-by: Andrew Lunn Tested-by: Jianhui Xu --- drivers/net/usb/ax88179_lib.c | 7 +++++++ drivers/net/usb/ax88179_lib.h | 1 + 2 files changed, 8 insertions(+) diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c index 7b5c17a01df2deac2cc0210bc88193be1abfbe23..34350ba3b96b94bc82072a57880= 2a91ebffd7a6a 100644 --- a/drivers/net/usb/ax88179_lib.c +++ b/drivers/net/usb/ax88179_lib.c @@ -137,6 +137,13 @@ int ax88179_write_cmd(struct usbnet *dev, u8 cmd, u16 = value, u16 index, u16 size return ret; } =20 +struct ax88179_data *netdev2data(struct net_device *net) +{ + struct usbnet *dev =3D netdev_priv(net); + + return dev->driver_priv; +} + void ax88179_status(struct usbnet *dev, struct urb *urb) { struct ax88179_int_data *event; diff --git a/drivers/net/usb/ax88179_lib.h b/drivers/net/usb/ax88179_lib.h index b2ee1356727cf4b3fa05f0b0d5fd863ac3f9a87d..9ff2a94a6fb2de4ee85f25e913a= e2fe263bcea7c 100644 --- a/drivers/net/usb/ax88179_lib.h +++ b/drivers/net/usb/ax88179_lib.h @@ -181,6 +181,7 @@ void ax88179_write_cmd_async(struct usbnet *dev, u8 cmd= , u16 value, u16 index, u16 size, void *data); int ax88179_mdio_read(struct net_device *netdev, int phy_id, int loc); void ax88179_mdio_write(struct net_device *netdev, int phy_id, int loc, in= t val); +struct ax88179_data *netdev2data(struct net_device *net); void ax88179_status(struct usbnet *dev, struct urb *urb); void ax88179_get_wol(struct net_device *net, struct ethtool_wolinfo *wolin= fo); int ax88179_set_wol(struct net_device *net, struct ethtool_wolinfo *wolinf= o); --=20 2.47.3 From nobody Fri Oct 2 10:08:42 2026 Received: from bkemail.birger-koblitz.de (bkemail.birger-koblitz.de [23.88.97.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A5302D061D; Sun, 2 Aug 2026 16:32:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.97.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688369; cv=none; b=E0CKeRJfSRVfYCzxjKZMP7igWTvs36Swyp0JvT4LI90i85yQekbo/ZvbrurNtmm8Ppo9RmKHxfHMpwsLFpVD+Oz1w59Hh5qcFmjnjScyQov/rk9Za4Z+RWY+8zwAS15CsRTHYmssgPXzYzW784wry2c5UTiHLFrG9AKnat0lI7U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688369; c=relaxed/simple; bh=F1fETYmsx41Ku4npGmbDIPxa25ih9h3p3+HTHiBfJE8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dSzt7oeY16P9akakQRQ5HyY/56cQjFY4eTJ5OMdpVd/89o1aWnqHx4Lo8zBq2CGsuFHFmCWMxfbPBsYPET2WwfxuLn50YtJDTyDP6xIqnroIdFdpidlb67/aR25tnXXDVtQsHd2tdHxuAZd4kD4JxPGAPanilCYs2lGG2OLunoc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de; spf=pass smtp.mailfrom=birger-koblitz.de; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=ImRoneUx; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=KaxYBVmo; arc=none smtp.client-ip=23.88.97.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="ImRoneUx"; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="KaxYBVmo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688361; bh=F1fETYmsx41Ku4npGmbDIPxa25ih9h3p3+HTHiBfJE8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ImRoneUxDYG06TlWuE/guRjgGr0Y0ajZRWMWPW2LLoRk4vHTXg9ZzCOdj4Lfj7sji ILNOPBW+wI1vO73wk3mYiLz6Yr3NNIf9Zk0gXfW0tWxEAikx1kzCzCtMLfLd6G9FRv n63g/BPNoxbX6AhMWTD7erv61il+5pP2ZHEXdyNTGxPWYxPbD5FahWjmmpfz+GXyBU BUe80ukKKbREewXYPg1sZ6Z6Ov/vORMDdjB6o1+ySVlWod5AL0klqz9SJSs8BkN8gD hpoLe6A33959stIHjWOf09HD/FaJrVcIngIBP2JGcXbp/ukyovaZFVRTYSXIDsrCib 70QyDXitn74/A== Received: by bkemail.birger-koblitz.de (Postfix, from userid 109) id D844149660; Sun, 2 Aug 2026 16:32:41 +0000 (UTC) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688353; bh=F1fETYmsx41Ku4npGmbDIPxa25ih9h3p3+HTHiBfJE8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=KaxYBVmo4KDSliBeWaheedwjwM3/cQbaUZusfUyEMuZRLoFmhxXtWK9w6rxcTS/Vx vZ9f3zQ7K+eOGBhDHO4yJAGM4dxV7AVs4Ek0rOZNNv8nuPx3FF4MUfIxPz3F3+zB+u TnaXOhvjNLg41lS/+QTD87S8VK43QKvIs1Mv6VVXEcS/tFVftyOckxrFdIxZW9CLX6 Wkrx3KpscFUe/kgxzDWCsiS8wp2yF19kFlKh8OagVOHUsx+z5yn9zqX91T/m7CDYu5 Jem//iIzkPtMNH5GaJ1wkDoX3Oo9WHZvx8obSDAaN9M7SuDL8Zbya2eKRLD/tOkyHK ryRwl+B+GLxKg== Received: from ThinkPadAMD.lan (90-227-251-202-no2480.tbcn.telia.com [90.227.251.202]) by bkemail.birger-koblitz.de (Postfix) with ESMTPSA id 265CA4964D; Sun, 2 Aug 2026 16:32:33 +0000 (UTC) From: Birger Koblitz Date: Sun, 02 Aug 2026 18:32:02 +0200 Subject: [PATCH net-next v5 04/13] ax88179_178a: Add HW support for AX179A-based chips Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-ax88179a-v5-4-dcb9fea4acd4@birger-koblitz.de> References: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> In-Reply-To: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Andrew Lunn , Heiner Kallweit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Birger Koblitz , Jianhui Xu X-Mailer: b4 0.14.2 This adds bindings and HW support for AX179A-based USB-Ethernet controllers. The AX179A-family of chips consists of the AX88279 (2.5GBit PHY) AX88179A/B (1GBit PHY, B variant has wider temperature range) AX772D/E (100Mbit PHY) The controllers all have the same vendor and device ID (0x0b95, 0x1790) and are distinguished by their BCD device versions, which are 2.00 AX88179A/B 3.00 AX88772D/E 4.00 AX88279 For all chips, the driver calls the same ax88179a_bind() function and the chips are then distinguished by the chip version and BCD device ID. The AX179A-based chips all provide both a CDC-NCM compatible USB interface, and a proprietary vendor interface. By default, the proprietary vendor interface is not active and Linux will load the CDC-NCM driver to support the devices. If the ax88179_178a module is configured by the OS to have precedence over CDC-NCM, then this driver will switch the device to use the vendor interface, and the device will be controlled by the ax88179_178a driver when the device is probed again after an automatic reset by the device. Signed-off-by: Birger Koblitz Tested-by: Jianhui Xu --- drivers/net/usb/Kconfig | 2 +- drivers/net/usb/Makefile | 2 +- drivers/net/usb/ax88179_178a.c | 12 + drivers/net/usb/ax88179_lib.h | 159 ++++++ drivers/net/usb/ax88179a_devices.c | 963 +++++++++++++++++++++++++++++++++= ++++ 5 files changed, 1136 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig index 52a5c0922c79fc52906d4d4040ec2b3411ff0984..115990b0d9537aea2776544c976= 8b034f32aa7a4 100644 --- a/drivers/net/usb/Kconfig +++ b/drivers/net/usb/Kconfig @@ -199,7 +199,7 @@ config USB_NET_AX88179_178A tristate "ASIX AX88179/178A USB 3.0/2.0 to Gigabit Ethernet" depends on USB_USBNET select CRC32 - select PHYLIB + select PHYLINK default y help This option adds support for ASIX AX88179 based USB 3.0/2.0 diff --git a/drivers/net/usb/Makefile b/drivers/net/usb/Makefile index ddd76fa71e2ee670888df1c9715632e5c04a8149..2ecead0181eaf8d66fb6f5dbd6f= 2905b22b6eb57 100644 --- a/drivers/net/usb/Makefile +++ b/drivers/net/usb/Makefile @@ -13,7 +13,7 @@ obj-$(CONFIG_USB_LAN78XX) +=3D lan78xx.o obj-$(CONFIG_USB_NET_AX8817X) +=3D asix.o asix-y :=3D asix_devices.o asix_common.o ax88172a.o obj-$(CONFIG_USB_NET_AX88179_178A) +=3D ax88179.o -ax88179-y :=3D ax88179_178a.o ax88179_lib.o +ax88179-y :=3D ax88179_178a.o ax88179a_devices.o ax88179_lib.o obj-$(CONFIG_USB_NET_CDCETHER) +=3D cdc_ether.o obj-$(CONFIG_USB_NET_CDC_EEM) +=3D cdc_eem.o obj-$(CONFIG_USB_NET_DM9601) +=3D dm9601.o diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 66464a321dbcfe4370dad97d7efd5165983de6e4..6bd9704046009d7aad5ee6ddddc= 18faab5b030dc 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -1268,6 +1268,18 @@ static const struct driver_info at_umc2000sp_info = =3D { =20 static const struct usb_device_id products[] =3D { { + /* ASIX AX88179A USB 3.2 1000Mbit Ethernet */ + USB_DEVICE_VER(0x0b95, 0x1790, 0, 0x0200), + .driver_info =3D (unsigned long)&ax88179a_info, +}, { + /* ASIX AX88772D USB 2.0 100Mbit Ethernet */ + USB_DEVICE_VER(0x0b95, 0x1790, 0x0300, 0x0300), + .driver_info =3D (unsigned long)&ax88772d_info, +}, { + /* ASIX AX88279 USB 3.2 2500Mbit Ethernet */ + USB_DEVICE_VER(0x0b95, 0x1790, 0, 0x0400), + .driver_info =3D (unsigned long)&ax88279_info, +}, { /* ASIX AX88179 10/100/1000 */ USB_DEVICE_AND_INTERFACE_INFO(0x0b95, 0x1790, 0xff, 0xff, 0), .driver_info =3D (unsigned long)&ax88179_info, diff --git a/drivers/net/usb/ax88179_lib.h b/drivers/net/usb/ax88179_lib.h index 9ff2a94a6fb2de4ee85f25e913ae2fe263bcea7c..2e4d35c74ee8b32cd2916924b85= d5427860bb08c 100644 --- a/drivers/net/usb/ax88179_lib.h +++ b/drivers/net/usb/ax88179_lib.h @@ -2,6 +2,7 @@ =20 #include #include +#include #include =20 #ifndef __LINUX_USBNET_AX88179_H @@ -25,17 +26,34 @@ #define AX_ACCESS_EEPROM 0x04 #define AX_ACCESS_EFUS 0x05 #define AX_RELOAD_EEPROM_EFUSE 0x06 +#define AX88179A_WAKEUP_SETTING 0x07 +#define AX_FW_MODE 0x08 +#define AX_GPHY_CTL 0x0F +#define AX88179A_FLASH_READ 0x21 +#define AX88179A_FLASH_WEN 0x22 +#define AX88179A_FLASH_WDIS 0x23 +#define AX88179A_FLASH_WRITE 0x24 +#define AX88179A_PHY_CLAUSE45 0x27 +#define AX88179A_FLASH_ERASE_SECTION 0x28 +#define AX88179A_ACCESS_BL 0x2A +#define AX88179A_PHY_POWER 0x31 +#define AX88179A_AUTODETACH 0xC0 + #define AX_PAUSE_WATERLVL_LOW 0x54 #define AX_PAUSE_WATERLVL_HIGH 0x55 =20 +#define AX_FW_MODE_179A 0x01 #define PHYSICAL_LINK_STATUS 0x02 #define AX_USB_SS 0x04 #define AX_USB_HS 0x02 + #define AX_USB_FS 0x01 =20 #define GENERAL_STATUS 0x03 /* Check AX88179 version. UA1:Bit2 =3D 0, UA2:Bit2 =3D 1 */ #define AX_SECLD 0x04 =20 +#define AX_CHIP_STATUS 0x05 + #define AX_SROM_ADDR 0x07 #define AX_SROM_CMD 0x0a #define EEP_RD 0x04 @@ -55,6 +73,15 @@ #define AX_RX_CTL_PRO 0x0001 #define AX_RX_CTL_STOP 0x0000 =20 +#define AX88179A_ETH_TX_GAP 0x0D + +#define AX88179A_BFM_DATA 0x0E + #define AX_TX_QUEUE_CFG 0x02 + #define AX_TX_QUEUE_SET 0x08 + #define AX_TX_Q1_AHB_FC_EN 0x10 + #define AX_TX_Q2_AHB_FC_EN 0x20 + #define AX_XGMII_EN 0x80 + #define AX_NODE_ID 0x10 #define AX_MULFLTARY 0x16 =20 @@ -84,7 +111,20 @@ #define AX_PHYPWR_RSTCTL_IPRL 0x0020 #define AX_PHYPWR_RSTCTL_AT 0x1000 =20 +#define AX88179A_VLAN_ID_ADDRESS 0x2A + +#define AX88179A_VLAN_ID_CONTROL 0x2B + #define AX_VLAN_CONTROL_WE 0x0001 + #define AX_VLAN_CONTROL_RD 0x0002 + #define AX_VLAN_CONTROL_VSO 0x0010 + #define AX_VLAN_CONTROL_VFE 0x0020 + +#define AX88179A_VLAN_ID_DATA0 0x2C +#define AX88179A_VLAN_ID_DATA1 0x2D + #define AX_RX_BULKIN_QCTRL 0x2e +#define AX_GPHY_EEE_CTRL 0x01 + #define AX_CLK_SELECT 0x33 #define AX_CLK_SELECT_BCS 0x01 #define AX_CLK_SELECT_ACS 0x02 @@ -104,7 +144,51 @@ #define AX_TXCOE_TCPV6 0x20 #define AX_TXCOE_UDPV6 0x40 =20 +#define AX88179A_MAC_BM_INT_MASK 0x41 +#define AX88179A_MAC_BM_RX_DMA_CTL 0x43 +#define AX88179A_MAC_BM_TX_DMA_CTL 0x46 + +#define AX88179A_MAC_RX_STATUS_CDC 0x6D + #define AX_LSOFC_WCNT_7_ACCESS 0x03 + #define AX_GMII_CRC_APPEND 0x10 + #define AX_LEDCTRL 0x73 +#define AX88179A_MAC_ARC_CTRL 0x9E +#define AX88179A_MAC_SWP_CTRL 0xB1 + +#define AX88179A_MAC_TX_PAUSE 0xB2 + +#define AX88179A_MAC_CDC_DELAY_TX 0xB5 + +#define AX88179A_MAC_PATH 0xB7 + #define AX_MAC_RX_PATH_READY 0x01 + #define AX_MAC_TX_PATH_READY 0x02 + +#define AX88179A_NEW_PAUSE_CTRL 0xB8 + #define AX_NEW_PAUSE_EN 0x01 + +#define AX88179A_MAC_BULK_OUT_CTRL 0xB9 + #define AX_MAC_EFF_EN 0x02 + +#define AX88179A_MAC_RX_DATA_CDC_CNT 0xC0 + #define AX_MAC_LSO_ERR_EN 0x04 + #define AX_MAC_MIQFFCTRL_FORMAT 0x10 + #define AX_MAC_MIQFFCTRL_DROP_CRC 0x20 + +#define AX88179A_AUTODETACH_DELAY (5UL << 8) +#define AX88179A_AUTODETACH_EN 1 + +#define AX88179A_MAC_LSO_ENHANCE_CTRL 0xC3 + #define AX_LSO_ENHANCE_EN 0x01 + +#define AX88179A_MAC_TX_HDR_CKSUM 0xCC +#define AX88179A_EP5_EHR 0xF9 + +#define AX_PHY_POWER 0x02 + +#define EPHY_LOW_POWER_EN 0x01 +#define S5_WOL_EN 0x04 +#define S5_WOL_LOW_POWER 0x20 =20 #define GMII_PHY_PHYSR 0x11 #define GMII_PHY_PHYSR_SMASK 0xc000 @@ -157,6 +241,56 @@ #define GMII_PHY_PGSEL_PAGE3 0x0003 #define GMII_PHY_PGSEL_PAGE5 0x0005 =20 +/* TX Descriptor */ +#define AX179A_TX_DESC_LEN_MASK 0x1FFFFF +#define AX179A_TX_DESC_DROP_PADD BIT(28) +#define AX179A_TX_DESC_VLAN BIT(29) +#define AX179A_TX_DESC_MSS_MASK 0x7FFF +#define AX179A_TX_DESC_MSS_SHIFT 0x20 +#define AX179A_TX_DESC_VLAN_MASK 0xFFFF +#define AX179A_TX_DESC_VLAN_SHIFT 0x30 + +/* RX Packet Descriptor */ +#define AX179A_RX_PD_L4_ERR BIT(0) +#define AX179A_RX_PD_L3_ERR BIT(1) +#define AX179A_RX_PD_L4_TYPE_MASK 0x1C +#define AX179A_RX_PD_L4_UDP 0x04 +#define AX179A_RX_PD_L4_TCP 0x10 +#define AX179A_RX_PD_L3_TYPE_MASK 0x60 +#define AX179A_RX_PD_L3_IP 0x20 +#define AX179A_RX_PD_L3_IP6 0x40 + +#define AX179A_RX_PD_VLAN BIT(10) +#define AX179A_RX_PD_RX_OK BIT(11) +#define AX179A_RX_PD_DROP BIT(31) +#define AX179A_RX_PD_LEN_MASK 0x7FFF0000 +#define AX179A_RX_PD_LEN_SHIFT 0x10 +#define AX179A_RX_PD_VLAN_SHIFT 0x20 + +/* RX Descriptor header */ +#define AX179A_RX_DH_PKT_CNT_MASK 0x1FFF +#define AX179A_RX_DH_DESC_OFFSET_MASK 0xFFFFE000 +#define AX179A_RX_DH_DESC_OFFSET_SHIFT 0x0D + +#define AX179A_RX_HW_PAD 0x02 + +#define AX_ADVERTISE_2500 0x1000 + +enum ax_ether_link_speed { + ETHER_LINK_NONE =3D 0, + ETHER_LINK_10 =3D 1, + ETHER_LINK_100 =3D 2, + ETHER_LINK_1000 =3D 3, + ETHER_LINK_2500 =3D 4, +}; + +enum ax_chip_version { + AX_VERSION_INVALID =3D 0x0, + AX_VERSION_AX88179 =3D 0x4, + AX_VERSION_AX88179A =3D 0x6, /* Also AX88772D */ + AX_VERSION_AX88279 =3D 0x7, +}; + struct ax88179_data { u8 eee_enabled; u8 eee_active; @@ -165,6 +299,22 @@ struct ax88179_data { u32 wol_supported; u32 wolopts; u8 disconnecting; + u8 chip_version; + u8 fw_version[4]; + u8 is_ax88772d; + u8 ip_align; + u8 link; + u8 speed; + u8 full_duplex; + u8 rx_checksum; + u8 eeprom_read_cmd; + u8 eeprom_write_cmd; + u8 eeprom_wen; + u16 eeprom_block; + struct mii_bus *mdio; + struct phy_device *phydev; + struct phylink *phylink; + struct phylink_config phylink_config; }; =20 struct ax88179_int_data { @@ -172,6 +322,10 @@ struct ax88179_int_data { __le32 intdata2; }; =20 +struct ax_bulkin_settings { + unsigned char ctrl, timer_l, timer_h, size, ifg; +}; + void ax88179_set_pm_mode(struct usbnet *dev, bool pm_mode); int __ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, u= 16 size, void *data); int ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, u16= size, void *data); @@ -192,4 +346,9 @@ int ax88179_set_features(struct net_device *net, netdev= _features_t features); void ax88179_get_mac_addr(struct usbnet *dev); int ax88179_change_mtu(struct net_device *net, int new_mtu); int ax88179_set_mac_addr(struct net_device *net, void *p); + +extern const struct driver_info ax88179a_info; +extern const struct driver_info ax88772d_info; +extern const struct driver_info ax88279_info; + #endif /*__LINUX_USBNET_AX88179_H */ diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_= devices.c new file mode 100644 index 0000000000000000000000000000000000000000..cef2a0131c1e6d60b28c2aab1e0= 20e6b7468bc3c --- /dev/null +++ b/drivers/net/usb/ax88179a_devices.c @@ -0,0 +1,963 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include "ax88179_lib.h" + +#define AX88279_EEPROM_LEN 0x4000 +#define AX88179A_EEPROM_LEN (32 * 20) + +static const struct ax_bulkin_settings AX88179A_BULKIN_SIZE[] =3D { + {5, 0x7B, 0x00, 0x17, 0x0F}, /* 1G, SS */ + {5, 0xC0, 0x02, 0x06, 0x0F}, /* 1G, HS */ + {7, 0xF0, 0x00, 0x0C, 0x0F}, /* 100M, Full, SS */ + {6, 0x00, 0x00, 0x06, 0x0F}, /* 100M, Half, SS */ + {5, 0xC0, 0x04, 0x06, 0x0F}, /* 100M, Full, HS */ + {7, 0xC0, 0x04, 0x06, 0x0F}, /* 100M, Half, HS */ + {7, 0x00, 0x00, 0x03, 0x3F}, /* FS */ +}; + +static const struct ax_bulkin_settings AX88772D_BULKIN_SIZE[] =3D { + {0, 0x00, 0x00, 0x00, 0x00}, /* 1G, SS (unused) */ + {0, 0x00, 0x00, 0x00, 0x00}, /* 1G, HS (unused) */ + {0, 0x00, 0x00, 0x00, 0x00}, /* 100M, Full, SS (unused) */ + {0, 0x00, 0x00, 0x00, 0x00}, /* 100M, Half, SS (unused) */ + {5, 0xC0, 0x04, 0x06, 0x0F}, /* 100M, Full, HS */ + {7, 0xC0, 0x04, 0x06, 0x0F}, /* 100M, Half, HS */ + {7, 0x00, 0x00, 0x03, 0x3F}, /* FS */ +}; + +static const struct ax_bulkin_settings AX88279_BULKIN_SIZE[] =3D { + {5, 0x10, 0x01, 0x11, 0x0F}, /* 2.5G */ + {7, 0xB3, 0x01, 0x11, 0x0F}, /* 1G, SS */ + {7, 0xC0, 0x02, 0x06, 0x0F}, /* 1G, HS */ + {7, 0x80, 0x01, 0x03, 0x0F}, /* 100M, Full, SS */ + {7, 0x80, 0x01, 0x03, 0x0F}, /* 100M, Half, SS */ + {7, 0x80, 0x01, 0x03, 0x0F}, /* 100M, Full, HS */ + {7, 0x80, 0x01, 0x03, 0x0F}, /* 100M, Half, HS */ + {7, 0x00, 0x00, 0x03, 0x3F}, /* FS */ +}; + +static int ax88179_mdiobus_read(struct mii_bus *bus, int phy_id, int regnu= m) +{ + struct usbnet *dev =3D bus->priv; + struct ax88179_data *priv; + u16 res; + + priv =3D dev->driver_priv; + /* When reading PHYSID, return unused PHY-IDs from the ASIX vendor range = */ + if (phy_id =3D=3D AX88179_PHY_ID && regnum =3D=3D MII_PHYSID1) + return 0x003b; + if (phy_id =3D=3D AX88179_PHY_ID && regnum =3D=3D MII_PHYSID2) { + if (priv->chip_version =3D=3D AX_VERSION_AX88179A && priv->is_ax88772d) + return 0x772d; + else if (priv->chip_version =3D=3D AX_VERSION_AX88179A) + return 0x179a; + else if (priv->chip_version =3D=3D AX_VERSION_AX88279) + return 0x2790; + } + + ax88179_read_cmd(dev, AX_ACCESS_PHY, phy_id, (__u16)regnum, 2, &res); + return res; +} + +static int ax88179_mdiobus_write(struct mii_bus *bus, int phy_id, int regn= um, u16 val) +{ + struct usbnet *dev =3D bus->priv; + + return ax88179_write_cmd(dev, AX_ACCESS_PHY, phy_id, (__u16)regnum, 2, &v= al); +} + +static int ax179a_read_mmd(struct usbnet *dev, u16 dev_addr, u16 reg) +{ + u16 res; + int ret; + + ret =3D ax88179_read_cmd(dev, AX88179A_PHY_CLAUSE45, dev_addr, reg, 2, &r= es); + if (ret < 0) + return ret; + return res; +} + +static int ax179a_write_mmd(struct usbnet *dev, u16 dev_addr, u16 reg, u16= data) +{ + return ax88179_write_cmd(dev, AX88179A_PHY_CLAUSE45, dev_addr, reg, 2, &d= ata); +} + +static int ax88179_mdiobus_read_c45(struct mii_bus *bus, int addr, int dev= num, int regnum) +{ + struct usbnet *dev =3D bus->priv; + + if (addr !=3D AX88179_PHY_ID) + return -EINVAL; + + return ax179a_read_mmd(dev, devnum, regnum); +} + +static int ax88179_mdiobus_write_c45(struct mii_bus *bus, int addr, int de= vnum, + int regnum, u16 val) +{ + struct usbnet *dev =3D bus->priv; + + if (addr !=3D AX88179_PHY_ID) + return -EINVAL; + + return ax179a_write_mmd(dev, devnum, regnum, val); +} + +static int ax88179a_auto_detach(struct usbnet *dev) +{ + u16 tmp16; + + tmp16 =3D AX88179A_AUTODETACH_DELAY; + ax88179_write_cmd(dev, AX88179A_AUTODETACH, tmp16, 0, 0, NULL); + return 0; +} + +static void ax88179a_bulkin_config(struct usbnet *dev, u8 link_sts) +{ + struct ax88179_data *ax179_data =3D dev->driver_priv; + const struct ax_bulkin_settings *bulkin_data; + int index =3D 0; + + switch (ax179_data->speed) { + case ETHER_LINK_2500: /* AX88279 only */ + index =3D 0; + break; + + case ETHER_LINK_1000: /* AX88279 & AX88178A */ + if (ax179_data->chip_version =3D=3D AX_VERSION_AX88279) { + if (link_sts & AX_USB_SS) + index =3D 1; + else if (link_sts & AX_USB_HS) + index =3D 2; + } else { + if (link_sts & AX_USB_SS) + index =3D 0; + else if (link_sts & AX_USB_HS) + index =3D 1; + } + break; + + case ETHER_LINK_100: + if (ax179_data->chip_version =3D=3D AX_VERSION_AX88279) { + if (link_sts & AX_USB_SS) + index =3D 3; + else if (link_sts & AX_USB_HS) + index =3D 5; + if (!ax179_data->full_duplex) + index++; + } else { + /* AX88279A & AX88277D */ + if (link_sts & AX_USB_SS) + index =3D 2; + else if (link_sts & AX_USB_HS) + index =3D 4; + if (!ax179_data->full_duplex) + index++; + } + break; + + case ETHER_LINK_10: + if (ax179_data->chip_version =3D=3D AX_VERSION_AX88279) + index =3D 7; + else + index =3D 6; + break; + + default: /* No link */ + index =3D 0; + } + + if (ax179_data->chip_version =3D=3D AX_VERSION_AX88279 && (link_sts & AX_= USB_FS)) + index =3D 7; + + if (ax179_data->chip_version =3D=3D AX_VERSION_AX88279) { + bulkin_data =3D AX88279_BULKIN_SIZE; + } else { + if (ax179_data->is_ax88772d) + bulkin_data =3D AX88772D_BULKIN_SIZE; + else + bulkin_data =3D AX88179A_BULKIN_SIZE; + } + + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RX_BULKIN_QCTRL, 5, 5, &bulkin_d= ata[index]); +} + +static void ax88179a_get_pauseparam(struct net_device *net, struct ethtool= _pauseparam *pause) +{ + struct ax88179_data *data =3D netdev2data(net); + + phylink_ethtool_get_pauseparam(data->phylink, pause); +} + +static int ax88179a_set_pauseparam(struct net_device *net, struct ethtool_= pauseparam *pause) +{ + struct ax88179_data *data =3D netdev2data(net); + + return phylink_ethtool_set_pauseparam(data->phylink, pause); +} + +static int ax88179a_get_eeprom_len(struct net_device *net) +{ + struct ax88179_data *ax179_data =3D netdev2data(net); + + if (ax179_data->chip_version >=3D AX_VERSION_AX88279) + return AX88279_EEPROM_LEN; + else + return AX88179A_EEPROM_LEN; +} + +static const struct ethtool_ops ax88179a_ethtool_ops =3D { + .get_link =3D ethtool_op_get_link, + .get_msglevel =3D usbnet_get_msglevel, + .set_msglevel =3D usbnet_set_msglevel, + .get_wol =3D ax88179_get_wol, + .set_wol =3D ax88179_set_wol, + .get_eeprom_len =3D ax88179a_get_eeprom_len, + .get_eeprom =3D ax88179_get_eeprom, + .set_eeprom =3D ax88179_set_eeprom, + .nway_reset =3D usbnet_nway_reset, + .get_link_ksettings =3D phy_ethtool_get_link_ksettings, + .set_link_ksettings =3D phy_ethtool_set_link_ksettings, + .get_pauseparam =3D ax88179a_get_pauseparam, + .set_pauseparam =3D ax88179a_set_pauseparam, + .get_ts_info =3D ethtool_op_get_ts_info, +}; + +static void ax88179a_mdio_unregister(struct ax88179_data *data) +{ + mdiobus_unregister(data->mdio); + mdiobus_free(data->mdio); +} + +static int ax88179a_init_phy(struct usbnet *dev) +{ + struct ax88179_data *data =3D dev->driver_priv; + int ret; + + data->phydev =3D mdiobus_get_phy(data->mdio, AX88179_PHY_ID); + if (!data->phydev) { + netdev_err(dev->net, "Could not find PHY\n"); + return -ENODEV; + } + + ret =3D phylink_connect_phy(data->phylink, data->phydev); + if (ret) { + netdev_err(dev->net, "Could not connect PHY\n"); + return ret; + } + + phy_suspend(data->phydev); + data->phydev->mac_managed_pm =3D true; + + phy_attached_info(data->phydev); + + return 0; +} + +static void ax88179a_mac_config(struct phylink_config *config, unsigned in= t mode, + const struct phylink_link_state *state) +{ + /* Nothing to do */ +} + +static void ax88179a_mac_link_down(struct phylink_config *config, + unsigned int mode, phy_interface_t interface) +{ + /* Nothing to do */ +} + +static void ax88179a_mac_link_up(struct phylink_config *config, + struct phy_device *phy, + unsigned int phy_mode, phy_interface_t interface, + int speed, int duplex, + bool tx_pause, bool rx_pause) +{ + struct usbnet *dev =3D netdev_priv(to_net_dev(config->dev)); + struct ax88179_data *ax179_data =3D dev->driver_priv; + u8 tmp8, link_sts, reg8[3]; + u16 tmp16, mode; + + /* Stop RX/TX for link configuration */ + tmp16 =3D AX_RX_CTL_STOP; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, 2, &tmp16); + tmp8 =3D 0; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_PATH, 1, 1, &tmp8); + + tmp8 =3D 0xa5; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_CDC_DELAY_TX, 1, 1, &t= mp8); + + tmp16 =3D 0x0410; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_LOW, 2, 2, &tmp16= ); + + tmp8 =3D 0; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_ETH_TX_GAP, 1, 1, &tmp8); + + tmp8 =3D 0x07; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_EP5_EHR, 1, 1, &tmp8); + + tmp8 =3D 0x28 | AX_NEW_PAUSE_EN; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_NEW_PAUSE_CTRL, 1, 1, &tmp= 8); + + mode =3D AX_MEDIUM_RECEIVE_EN; + if (tx_pause) + mode |=3D AX_MEDIUM_TXFLOW_CTRLEN; + if (rx_pause) + mode |=3D AX_MEDIUM_RXFLOW_CTRLEN; + + switch (speed) { + case SPEED_2500: + reg8[0] =3D 0x00; + reg8[1] =3D 0xF8; + reg8[2] =3D 0x07; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_TX_PAUSE, 3, 3, reg8); + + reg8[0] =3D 0x78; + reg8[1] =3D (AX_LSOFC_WCNT_7_ACCESS << 5); + reg8[2] =3D 0; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_STATUS_CDC, 3, 3, = reg8); + + reg8[0] =3D 0x40; + reg8[1] =3D AX_MAC_MIQFFCTRL_FORMAT | AX_MAC_MIQFFCTRL_DROP_CRC | AX_MAC= _LSO_ERR_EN; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_DATA_CDC_CNT, 2, 2= , reg8); + + tmp8 =3D AX_XGMII_EN; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_BFM_DATA, 1, 1, &tmp8); + + tmp8 =3D 0x1C | AX_LSO_ENHANCE_EN; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_LSO_ENHANCE_CTRL, 1, = 1, &tmp8); + + mode |=3D AX_MEDIUM_GIGAMODE | AX_MEDIUM_FULL_DUPLEX; + + break; + + case SPEED_1000: + mode |=3D AX_MEDIUM_GIGAMODE; + fallthrough; + + case SPEED_100: + reg8[0] =3D 0x78; + reg8[1] =3D (AX_LSOFC_WCNT_7_ACCESS << 5) | AX_GMII_CRC_APPEND; + reg8[2] =3D 0; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_STATUS_CDC, 3, 3, = reg8); + + tmp8 =3D 0x40; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_DATA_CDC_CNT, 1, 1= , &tmp8); + break; + + case SPEED_10: + reg8[0] =3D 0xFA; + reg8[1] =3D (AX_LSOFC_WCNT_7_ACCESS << 5) | AX_GMII_CRC_APPEND; + reg8[2] =3D 0xFF; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_STATUS_CDC, 3, 3, = reg8); + + tmp8 =3D 0xFA; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_DATA_CDC_CNT, 1, 1= , &tmp8); + + speed =3D 10; + break; + } + + ax88179_read_cmd(dev, AX_ACCESS_MAC, PHYSICAL_LINK_STATUS, 1, 1, &link_st= s); + ax88179a_bulkin_config(dev, link_sts); + + if (ax179_data->chip_version < AX_VERSION_AX88279) { + tmp8 =3D 0; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_BFM_DATA, 1, 1, &tmp8); + } + + if (duplex) + mode |=3D AX_MEDIUM_FULL_DUPLEX; + + if (dev->net->mtu > 1500) + mode |=3D AX_MEDIUM_JUMBO_EN; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, &mode); + + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, 2, &ax179_data->rxctl= ); + + tmp8 =3D AX_MAC_RX_PATH_READY | AX_MAC_TX_PATH_READY; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_PATH, 1, 1, &tmp8); +} + +static void ax88179a_mac_disable_tx_lpi(struct phylink_config *config) +{ + struct usbnet *dev =3D netdev_priv(to_net_dev(config->dev)); + + ax88179_write_cmd(dev, AX_GPHY_CTL, AX_GPHY_EEE_CTRL, false, 0, NULL); +} + +static int ax88179a_mac_enable_tx_lpi(struct phylink_config *config, u32 t= imer, bool tx_clk_stop) +{ + struct usbnet *dev =3D netdev_priv(to_net_dev(config->dev)); + + /* AX88179A does not provide LPI timer registers */ + return ax88179_write_cmd(dev, AX_GPHY_CTL, AX_GPHY_EEE_CTRL, true, 0, NUL= L); +} + +static const struct phylink_mac_ops ax88179a_phylink_mac_ops =3D { + .mac_config =3D ax88179a_mac_config, + .mac_link_down =3D ax88179a_mac_link_down, + .mac_link_up =3D ax88179a_mac_link_up, +}; + +static int ax88179a_phylink_setup(struct usbnet *dev) +{ + struct ax88179_data *data =3D dev->driver_priv; + phy_interface_t phy_if_mode; + struct phylink *phylink; + + data->phylink_config.dev =3D &dev->net->dev; + data->phylink_config.type =3D PHYLINK_NETDEV; + data->phylink_config.mac_capabilities =3D MAC_SYM_PAUSE | MAC_ASYM_PAUSE = | MAC_100; + if (data->is_ax88772d) + data->phylink_config.mac_capabilities |=3D MAC_10; + else if (data->chip_version < AX_VERSION_AX88279) + data->phylink_config.mac_capabilities |=3D MAC_10 | MAC_1000; + else + data->phylink_config.mac_capabilities |=3D MAC_1000 | MAC_2500FD; + + __set_bit(PHY_INTERFACE_MODE_INTERNAL, + data->phylink_config.supported_interfaces); + phy_if_mode =3D PHY_INTERFACE_MODE_INTERNAL; + + phylink =3D phylink_create(&data->phylink_config, dev->net->dev.fwnode, + phy_if_mode, &ax88179a_phylink_mac_ops); + if (IS_ERR(phylink)) + return PTR_ERR(phylink); + + data->phylink =3D phylink; + return 0; +} + +static int ax88179a_init_mdio(struct usbnet *dev) +{ + struct ax88179_data *data =3D dev->driver_priv; + int ret; + + data->mdio =3D mdiobus_alloc(); + if (!data->mdio) + return -ENOMEM; + + data->mdio->priv =3D dev; + data->mdio->read =3D ax88179_mdiobus_read; + data->mdio->write =3D ax88179_mdiobus_write; + data->mdio->read_c45 =3D ax88179_mdiobus_read_c45; + data->mdio->write_c45 =3D ax88179_mdiobus_write_c45; + data->mdio->name =3D "AX88179A MDIO Bus"; + data->mdio->phy_mask =3D ~(1 << AX88179_PHY_ID); + /* mii bus name is usb-- */ + snprintf(data->mdio->id, MII_BUS_ID_SIZE, "usb-%03d:%03d", + dev->udev->bus->busnum, dev->udev->devnum); + + ret =3D mdiobus_register(data->mdio); + if (ret) { + netdev_err(dev->net, "Could not register MDIO bus (err %d)\n", ret); + mdiobus_free(data->mdio); + data->mdio =3D NULL; + } + + return ret; +} + +static const struct net_device_ops ax88179a_netdev_ops =3D { + .ndo_open =3D usbnet_open, + .ndo_stop =3D usbnet_stop, + .ndo_start_xmit =3D usbnet_start_xmit, + .ndo_tx_timeout =3D usbnet_tx_timeout, + .ndo_get_stats64 =3D dev_get_tstats64, + .ndo_change_mtu =3D ax88179_change_mtu, + .ndo_set_mac_address =3D ax88179_set_mac_addr, + .ndo_validate_addr =3D eth_validate_addr, + .ndo_eth_ioctl =3D usbnet_mii_ioctl, +}; + +static int ax88179a_bind(struct usbnet *dev, struct usb_interface *intf) +{ + struct usb_device *udev =3D interface_to_usbdev(intf); + struct ax88179_data *ax179_data; + int ret; + u8 reg8; + + /* Check if vendor configuration */ + if (udev->actconfig->desc.bConfigurationValue !=3D 1) { + netdev_info(dev->net, "Switching to vendor mode\n"); + usb_driver_set_configuration(udev, 1); + return -ENODEV; + } + + ret =3D usbnet_get_endpoints(dev, intf); + if (ret < 0) + return ret; + + ax179_data =3D kzalloc_obj(*ax179_data); + if (!ax179_data) + return -ENOMEM; + + dev->driver_priv =3D ax179_data; + + ret =3D ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_CHIP_STATUS, + 1, 1, &ax179_data->chip_version); + if (ret < 0) + goto err_nodev; + + ax179_data->chip_version =3D (ax179_data->chip_version & 0xf0) >> 4; + ax179_data->is_ax88772d =3D 0; + if (ax179_data->chip_version =3D=3D AX_VERSION_AX88179A) { + if (udev->descriptor.bcdDevice =3D=3D 0x300) + ax179_data->is_ax88772d =3D 1; + } + + for (int i =3D 0; i < 3; i++) { + ret =3D ax88179_read_cmd(dev, AX88179A_ACCESS_BL, (0xFD + i), + 1, 1, &ax179_data->fw_version[i]); + if (ret < 0) + ax179_data->fw_version[i] =3D 0xff; + } + netdev_info(dev->net, "AX88179A/279/772D Chip Version: %x, FW: %d.%d.%d.%= d\n", + ax179_data->chip_version, + ax179_data->fw_version[0], ax179_data->fw_version[1], + ax179_data->fw_version[2], ax179_data->fw_version[3]); + + /* The AX88279 requires both the AX_RX_CTL_IPE and AX_RX_CTL_DROPCRCERR + * bits set in AX_RX_CTL for creating correct RX-URBs. AX_RX_CTL_DROPCRCE= RR + * is anyway set for all chips, make sure AX_RX_CTL_IPE is set via ip_ali= gn. + * Also configure eeprom access parameters. + */ + if (ax179_data->chip_version =3D=3D AX_VERSION_AX88279) { + ax179_data->ip_align =3D 1; + ax179_data->eeprom_read_cmd =3D AX88179A_FLASH_READ; + ax179_data->eeprom_write_cmd =3D AX88179A_FLASH_WRITE; + ax179_data->eeprom_block =3D 256; + ax179_data->eeprom_wen =3D 1; + } else { + ax179_data->ip_align =3D 0; + ax179_data->eeprom_read_cmd =3D AX_ACCESS_EFUS; + ax179_data->eeprom_write_cmd =3D AX_ACCESS_EFUS; + ax179_data->eeprom_block =3D 20; + ax179_data->eeprom_wen =3D 0; + } + + dev->net->netdev_ops =3D &ax88179a_netdev_ops; + dev->net->ethtool_ops =3D &ax88179a_ethtool_ops; + dev->net->needed_headroom =3D 8; + dev->net->needed_tailroom =3D 8; + dev->net->min_mtu =3D ETH_MIN_MTU; + dev->hard_mtu =3D 9 * 1024; + dev->net->max_mtu =3D dev->hard_mtu - dev->net->hard_header_len; + + if (!ax179_data->is_ax88772d) + dev->mii.supports_gmii =3D 1; + + dev->net->features |=3D NETIF_F_SG | NETIF_F_IP_CSUM | + NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM | NETIF_F_TSO | + NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_HW_VLAN_CTAG_RX | + NETIF_F_HW_VLAN_CTAG_FILTER; + + dev->net->hw_features |=3D dev->net->features; + + dev->net->vlan_features =3D NETIF_F_SG | NETIF_F_IP_CSUM | + NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM | NETIF_F_TSO; + + netif_set_tso_max_size(dev->net, 16384); + + /* Enable Transmission of Link Speed byte in interrupt URB */ + ax88179_write_cmd(dev, AX_FW_MODE, AX_FW_MODE_179A, 0, 0, NULL); + ax88179_write_cmd(dev, AX_RELOAD_EEPROM_EFUSE, 0, 0, 0, NULL); + + /* Read MAC address from DTB or ASIX chip */ + ax88179_get_mac_addr(dev); + memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN); + + /* Power PHY for probing */ + reg8 =3D AX_PHY_POWER; + ax88179_write_cmd(dev, AX88179A_PHY_POWER, 0, 0, 1, ®8); + msleep(250); + + ret =3D ax88179a_init_mdio(dev); + if (ret) + goto err_nodev; + + ret =3D ax88179a_phylink_setup(dev); + if (ret) + goto phylink_err; + + ret =3D ax88179a_init_phy(dev); + if (ret) + goto initphy_err; + + return 0; + +initphy_err: + phylink_destroy(ax179_data->phylink); +phylink_err: + ax88179a_mdio_unregister(ax179_data); +err_nodev: + kfree(ax179_data); + ax179_data =3D NULL; + + return ret; +} + +static void ax88179a_unbind(struct usbnet *dev, struct usb_interface *intf) +{ + struct ax88179_data *ax179_data =3D dev->driver_priv; + u16 tmp16; + u8 tmp8; + + /* Configure RX control register =3D> stop operation */ + tmp16 =3D AX_RX_CTL_STOP; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, 2, &tmp16); + + rtnl_lock(); + phylink_disconnect_phy(ax179_data->phylink); + rtnl_unlock(); + phylink_destroy(ax179_data->phylink); + ax88179a_mdio_unregister(ax179_data); + + tmp8 =3D 0; + ax88179_write_cmd(dev, AX88179A_PHY_POWER, 0, 0, 1, &tmp8); + + kfree(ax179_data); +} + +static void ax88179a_rx_checksum(struct sk_buff *skb, u64 pkt_desc) +{ + u32 pkt_type; + + skb->ip_summed =3D CHECKSUM_NONE; + /* checksum error bit is set */ + if (pkt_desc & AX179A_RX_PD_L4_ERR || pkt_desc & AX179A_RX_PD_L3_ERR) + return; + + pkt_type =3D pkt_desc & AX179A_RX_PD_L4_TYPE_MASK; + /* It must be a TCP or UDP packet with a valid checksum */ + if (pkt_type =3D=3D AX179A_RX_PD_L4_TCP || pkt_type =3D=3D AX179A_RX_PD_L= 4_UDP) + skb->ip_summed =3D CHECKSUM_UNNECESSARY; +} + +static int ax88179a_rx_fixup(struct usbnet *dev, struct sk_buff *skb) +{ + struct ax88179_data *ax179_data =3D dev->driver_priv; + struct sk_buff *ax_skb; + u32 hdr_off, pkt_end; + u64 *pkt_desc_ptr; + u16 vlan_tag; + u16 pkt_cnt; + u64 rx_hdr; + + /* SKB contents for AX179A-based chips: + * + * ... + * + * + * ... + * + * + * + * where: + * contains pkt_len data bytes and padding: + * 2 bytes of IP alignment (optional, depends on AX_RX_CTL_IPE flag) + * packet data received + * optional padding to 8-bytes boundary + * contains 8 bytes: + * pkt_len and fields AX_RXHDR_* + * contains 8 bytes: + * pkt_cnt and hdr_off (offset of ) + * + * pkt_cnt is number of entries in the per-packet metadata array. + */ + + if (!skb || skb->len < sizeof(rx_hdr)) + goto err; + + /* RX Descriptor Header */ + skb_trim(skb, skb->len - sizeof(rx_hdr)); + rx_hdr =3D le64_to_cpup((u64 *)skb_tail_pointer(skb)); + + /* Check these packets */ + hdr_off =3D (rx_hdr & AX179A_RX_DH_DESC_OFFSET_MASK) >> AX179A_RX_DH_DESC= _OFFSET_SHIFT; + pkt_cnt =3D rx_hdr & AX179A_RX_DH_PKT_CNT_MASK; + + /* Consistency check header position */ + if (hdr_off !=3D skb->len - (pkt_cnt * sizeof(rx_hdr))) + goto err; + + /* Make sure that the bounds of the metadata array are inside the SKB + * (and in front of the counter at the end). + */ + if (pkt_cnt * 8 + hdr_off > skb->len) + goto err; + + /* Packets must not overlap the metadata array */ + skb_trim(skb, hdr_off); + + if (!pkt_cnt) + goto err; + + /* Get the first RX packet descriptor */ + pkt_desc_ptr =3D (u64 *)(skb->data + hdr_off); + + pkt_end =3D 0; + while (pkt_cnt--) { + u64 pkt_desc =3D le64_to_cpup(pkt_desc_ptr); + u32 pkt_len_plus_padd; + u32 pkt_len; + + pkt_len =3D (u32)((pkt_desc & AX179A_RX_PD_LEN_MASK) >> AX179A_RX_PD_LEN= _SHIFT) + - (ax179_data->ip_align ? 2 : 0); + pkt_len_plus_padd =3D ((pkt_len + 7 + (ax179_data->ip_align ? 2 : 0)) & = 0x7FFF8); + + pkt_end +=3D pkt_len_plus_padd; + if (pkt_end > hdr_off || (pkt_cnt =3D=3D 0 && pkt_end !=3D hdr_off)) + goto err; + + if (pkt_desc & AX179A_RX_PD_DROP || !(pkt_desc & AX179A_RX_PD_RX_OK) || + pkt_len > (dev->hard_mtu + AX179A_RX_HW_PAD)) { + skb_pull(skb, pkt_len_plus_padd); + + /* Next RX Packet Descriptor */ + pkt_desc_ptr++; + continue; + } + + ax_skb =3D netdev_alloc_skb_ip_align(dev->net, pkt_len); + if (!ax_skb) + goto err; + + skb_put(ax_skb, pkt_len); + memcpy(ax_skb->data, skb->data + (ax179_data->ip_align ? AX179A_RX_HW_PA= D : 0), + pkt_len); + + if (ax179_data->rx_checksum) + ax88179a_rx_checksum(ax_skb, pkt_desc); + + if (pkt_desc & AX179A_RX_PD_VLAN) { + vlan_tag =3D pkt_desc >> AX179A_RX_PD_VLAN_SHIFT; + __vlan_hwaccel_put_tag(ax_skb, htons(ETH_P_8021Q), + vlan_tag & VLAN_VID_MASK); + } + + usbnet_skb_return(dev, ax_skb); + skb_pull(skb, pkt_len_plus_padd); + + /* Next RX Packet Header */ + pkt_desc_ptr++; + } + + return 1; + +err: + return 0; +} + +static struct sk_buff *ax88179a_tx_fixup(struct usbnet *dev, struct sk_buf= f *skb, gfp_t flags) +{ + u64 tx_desc =3D skb->len & AX179A_TX_DESC_LEN_MASK; + int frame_size =3D dev->maxpacket; + struct sk_buff *ax_skb; + u64 *tx_desc_ptr; + int padding_size; + int headroom; + int tailroom; + u16 tci =3D 0; + + /* TSO MSS */ + tx_desc |=3D ((u64)(skb_shinfo(skb)->gso_size & AX179A_TX_DESC_MSS_MASK))= << + AX179A_TX_DESC_MSS_SHIFT; + + headroom =3D (skb->len + sizeof(tx_desc)) % 8; + padding_size =3D headroom ? 8 - headroom : 0; + + if (((skb->len + sizeof(tx_desc) + padding_size) % frame_size) =3D=3D 0) { + padding_size +=3D 8; + tx_desc |=3D AX179A_TX_DESC_DROP_PADD; + } + + if ((dev->net->features & NETIF_F_HW_VLAN_CTAG_TX) && (vlan_get_tag(skb, = &tci) >=3D 0)) { + tx_desc |=3D AX179A_TX_DESC_VLAN; + tx_desc |=3D ((u64)tci & AX179A_TX_DESC_VLAN_MASK) << AX179A_TX_DESC_VLA= N_SHIFT; + } + + if (!dev->can_dma_sg && (dev->net->features & NETIF_F_SG) && skb_lineariz= e(skb)) + return NULL; + + headroom =3D skb_headroom(skb); + tailroom =3D skb_tailroom(skb); + + if (!(headroom >=3D sizeof(tx_desc) && tailroom >=3D padding_size)) { + ax_skb =3D skb_copy_expand(skb, sizeof(tx_desc), padding_size, flags); + dev_kfree_skb_any(skb); + skb =3D ax_skb; + if (!skb) + return NULL; + } + if (padding_size !=3D 0) + skb_put_zero(skb, padding_size); + /* Copy TX header */ + tx_desc_ptr =3D skb_push(skb, sizeof(tx_desc)); + *tx_desc_ptr =3D cpu_to_le64(tx_desc); + + usbnet_set_skb_tx_stats(skb, 1, 0); + + return skb; +} + +static int ax88179a_reset(struct usbnet *dev) +{ + struct ax88179_data *ax179_data =3D dev->driver_priv; + u16 *tmp16; + u8 buf[5]; + u8 *tmp; + + tmp16 =3D (u16 *)buf; + tmp =3D (u8 *)buf; + + /* Power up ethernet PHY */ + *tmp =3D AX_PHY_POWER; + ax88179_write_cmd(dev, AX88179A_PHY_POWER, 0, 0, 1, tmp); + msleep(250); + + /* Ethernet PHY Auto Detach*/ + ax88179a_auto_detach(dev); + + *tmp =3D AX_MAC_EFF_EN; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_BULK_OUT_CTRL, 1, 1, t= mp); + + *tmp16 =3D 0; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, 2, tmp16); + + *tmp =3D 0x04; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_LOW, 1, 1, tmp); + *tmp =3D 0x10; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_HIGH, 1, 1, tmp); + + *tmp =3D 0; + if (dev->net->features & NETIF_F_HW_VLAN_CTAG_FILTER) + *tmp |=3D AX_VLAN_CONTROL_VFE; + if (dev->net->features & NETIF_F_HW_VLAN_CTAG_RX) + *tmp |=3D AX_VLAN_CONTROL_VSO; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, tmp= ); + + *tmp =3D 0xff; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_BM_INT_MASK, 1, 1, tmp= ); + + *tmp =3D 0; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_BM_RX_DMA_CTL, 1, 1, t= mp); + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_BM_TX_DMA_CTL, 1, 1, t= mp); + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_ARC_CTRL, 1, 1, tmp); + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_SWP_CTRL, 1, 1, tmp); + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_TX_HDR_CKSUM, 1, 1, tm= p); + + /* Read MAC address from DTB or asix chip */ + ax88179_get_mac_addr(dev); + memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN); + + /* The Bulk-Register configuration for the AX88179A is done in + * ax88179a_mac_link_up(), once the link is up for a given link and USB-s= peed. + */ + if (ax179_data->is_ax88772d) + dev->rx_urb_size =3D 1024 * 24; + else + dev->rx_urb_size =3D 1024 * 48; + + /* Enable checksum offload */ + *tmp =3D AX_RXCOE_IP | AX_RXCOE_TCP | AX_RXCOE_UDP | + AX_RXCOE_TCPV6 | AX_RXCOE_UDPV6; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 1, tmp); + ax179_data->rx_checksum =3D 1; + + *tmp =3D AX_TXCOE_IP | AX_TXCOE_TCP | AX_TXCOE_UDP | + AX_TXCOE_TCPV6 | AX_TXCOE_UDPV6; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, tmp); + + /* Configure RX control register =3D> start operation */ + ax179_data->rxctl =3D AX_RX_CTL_DROPCRCERR | AX_RX_CTL_START | + AX_RX_CTL_AP | AX_RX_CTL_AMALL | AX_RX_CTL_AB; + if (ax179_data->ip_align) + ax179_data->rxctl |=3D AX_RX_CTL_IPE; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, 2, &ax179_data->rxctl= ); + + if (ax179_data->chip_version < AX_VERSION_AX88179A) + *tmp =3D AX_MONITOR_MODE_PMETYPE | AX_MONITOR_MODE_PMEPOL | AX_MONITOR_M= ODE_RWMP; + else + *tmp =3D AX_MONITOR_MODE_RWMP; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MONITOR_MOD, 1, 1, tmp); + + /* Configure default medium type =3D> giga */ + *tmp16 =3D AX_MEDIUM_RECEIVE_EN | AX_MEDIUM_TXFLOW_CTRLEN | + AX_MEDIUM_RXFLOW_CTRLEN | AX_MEDIUM_FULL_DUPLEX; + if (!ax179_data->is_ax88772d) + *tmp16 |=3D AX_MEDIUM_GIGAMODE; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, tmp16); + + /* Check if WoL is supported */ + ax179_data->wol_supported =3D 0; + if (ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MONITOR_MOD, + 1, 1, &tmp) > 0) + ax179_data->wol_supported =3D WAKE_MAGIC | WAKE_PHY; + + phylink_start(ax179_data->phylink); + + usbnet_link_change(dev, 0, 0); + + return 0; +} + +static int ax88179a_stop(struct usbnet *dev) +{ + struct ax88179_data *ax179_data =3D dev->driver_priv; + u16 reg16; + u8 reg8; + + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, ®16); + reg16 &=3D ~AX_MEDIUM_RECEIVE_EN; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, ®16= ); + + reg16 =3D 0; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, 2, ®16); + + reg8 =3D 0; + ax88179_read_cmd(dev, AX88179A_PHY_POWER, 0, 0, 1, ®8); + + phylink_stop(ax179_data->phylink); + + return 0; +} + +const struct driver_info ax88179a_info =3D { + .description =3D "ASIX AX88179A USB 3.2 Gigabit Ethernet", + .bind =3D ax88179a_bind, + .unbind =3D ax88179a_unbind, + .status =3D ax88179_status, + .reset =3D ax88179a_reset, + .stop =3D ax88179a_stop, + .flags =3D FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET | FLAG_AVOID_= UNLINK_URBS, + .rx_fixup =3D ax88179a_rx_fixup, + .tx_fixup =3D ax88179a_tx_fixup, +}; + +const struct driver_info ax88772d_info =3D { + .description =3D "ASIX AX88772D/E USB 2.0 Fast Ethernet", + .bind =3D ax88179a_bind, + .unbind =3D ax88179a_unbind, + .status =3D ax88179_status, + .reset =3D ax88179a_reset, + .stop =3D ax88179a_stop, + .flags =3D FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET | FLAG_AVOID_= UNLINK_URBS, + .rx_fixup =3D ax88179a_rx_fixup, + .tx_fixup =3D ax88179a_tx_fixup, +}; + +const struct driver_info ax88279_info =3D { + .description =3D "ASIX AX88279 USB 3.2 2.5Gigabit Ethernet", + .bind =3D ax88179a_bind, + .unbind =3D ax88179a_unbind, + .status =3D ax88179_status, + .reset =3D ax88179a_reset, + .stop =3D ax88179a_stop, + .flags =3D FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET | FLAG_AVOID_= UNLINK_URBS, + .rx_fixup =3D ax88179a_rx_fixup, + .tx_fixup =3D ax88179a_tx_fixup, +}; --=20 2.47.3 From nobody Fri Oct 2 10:08:42 2026 Received: from bkemail.birger-koblitz.de (bkemail.birger-koblitz.de [23.88.97.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 937672931E4; Sun, 2 Aug 2026 16:32:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.97.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688367; cv=none; b=mCv8oc005nGwGcbpm68OKZkO140xrk4/vtwwjiHesiL0PKrCo3aHCa7TZgV97eR6hJycS31/sFLCCnrjQJni9vXqTuGxr+++QN0F0avaS03cvU8xcucxd0MobEQIWVrzXSwmaGBRHTnoDffd0ZOsmkii7LNr+Qumj1tow7XRxzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688367; c=relaxed/simple; bh=M6kH3QCSEEIgF299jkmBFu99MO+R3RPd+0sy4J70++k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GzpdugfnVa7R5XhgKHMSe9L7vn9fmgi0tEb7v/FiEhYDll2t6Clxx2tsPpiNtSkFABnJnt+/P/4QWbArPBTssRZNyv1ZRIGz6vgD2FeDri8wYNjs52CgvqDfo0POaVEBM5Fc45BA1+wdO4BmcHlDoWgkb/fsrPtfZytitnOjqgw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de; spf=pass smtp.mailfrom=birger-koblitz.de; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=ONciwd9F; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=kUeTzlBN; arc=none smtp.client-ip=23.88.97.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="ONciwd9F"; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="kUeTzlBN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688362; bh=M6kH3QCSEEIgF299jkmBFu99MO+R3RPd+0sy4J70++k=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ONciwd9FPHxF8Q2Iv6r6x1Cdz2bb4YghCHnACKIITYiI6gvEWP9ztmPMoeRHWjgLx /RYjLU4982NhC+09k3tCS0XRnDcHycIQ02/o5OGoIdQbDevW7uMNwip2/xUjuFBlHJ yedABwb9o/o8l8CDCDVaP4feJVDV9tXZkbsLqnw7e3dXKupLL65fnQVgChRmVDCSrK zQ6N/3uQcvrYrxbbt+57I3qinvpaCXHgwPUWJkQCf8rJNaerVzEBG0G+PQWJ3itgWr hPkMv5N5B5jcOWppn3Zup8j+L8ns0BNjJHj7jRobR6TfpB/f2JATTPBsZIxK3zgcAd 6bHSLXsJ4a/8A== Received: by bkemail.birger-koblitz.de (Postfix, from userid 109) id 0174249652; Sun, 2 Aug 2026 16:32:42 +0000 (UTC) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688354; bh=M6kH3QCSEEIgF299jkmBFu99MO+R3RPd+0sy4J70++k=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=kUeTzlBNMo5OHc6KoT4UA7Jy/Wv/pdgM+v0Oj9doxWP+KqogrSHxlmPsu+nF/H0Mt PxNUTZN9CUFYTth7+Wu4E/PaY+ug5uImcEW/l1wesG6qcIA8qdOxH0mZnIWAEycek+ YRy/+mS9vcI1TQB8Xp4EmxSfwFTHcnRf3rWvK52U6kFz5egRvD03isY4oKeCa4ghP8 sHRPrzFfWIMAPQoNYINHZ5qt7rga6b3ySsDqw5irauLMog1BbBhPoPis9J6PrQifxa TNMQpzzbHyPs/enzYzR4jUdJOBfqhVAQc3+aQojmrVAdNQXS398rT4zcXftvaLVAy9 cZt63JpnfRnpw== Received: from ThinkPadAMD.lan (90-227-251-202-no2480.tbcn.telia.com [90.227.251.202]) by bkemail.birger-koblitz.de (Postfix) with ESMTPSA id B80E24949C; Sun, 2 Aug 2026 16:32:33 +0000 (UTC) From: Birger Koblitz Date: Sun, 02 Aug 2026 18:32:03 +0200 Subject: [PATCH net-next v5 05/13] ax88179_178a: Add EEE configuration support for AX88179A MACs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-ax88179a-v5-5-dcb9fea4acd4@birger-koblitz.de> References: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> In-Reply-To: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Andrew Lunn , Heiner Kallweit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Birger Koblitz , Jianhui Xu X-Mailer: b4 0.14.2 The AX88179A uses a simple HW configuration for EEE via a single EEE configuration register without LPI timer support Add support for this EEE enable/disable register and replace the EEE. Signed-off-by: Birger Koblitz Reviewed-by: Andrew Lunn Tested-by: Jianhui Xu --- drivers/net/usb/ax88179a_devices.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_= devices.c index cef2a0131c1e6d60b28c2aab1e020e6b7468bc3c..22c7d1a4501dc052ebb16e06dff= 86e70c00c8381 100644 --- a/drivers/net/usb/ax88179a_devices.c +++ b/drivers/net/usb/ax88179a_devices.c @@ -400,6 +400,8 @@ static const struct phylink_mac_ops ax88179a_phylink_ma= c_ops =3D { .mac_config =3D ax88179a_mac_config, .mac_link_down =3D ax88179a_mac_link_down, .mac_link_up =3D ax88179a_mac_link_up, + .mac_disable_tx_lpi =3D ax88179a_mac_disable_tx_lpi, + .mac_enable_tx_lpi =3D ax88179a_mac_enable_tx_lpi, }; =20 static int ax88179a_phylink_setup(struct usbnet *dev) --=20 2.47.3 From nobody Fri Oct 2 10:08:42 2026 Received: from bkemail.birger-koblitz.de (bkemail.birger-koblitz.de [23.88.97.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 541EE3B7B70; Sun, 2 Aug 2026 16:32:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.97.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688367; cv=none; b=ED+hbIJSsly02qwK9l7bPs3zViFL5BGYW6ZOYu8m+geIf7smM22tKZqJc31KxS7K7Fe8jkafhOouHezykT03Mc6Xgf93phmICPyvnmepoezsUstj0X77rysbPYuNSp5BTYVtkBagByc8AzwY27e2iFl7AR6tF71ceaPJ+3sHhM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688367; c=relaxed/simple; bh=1lJvFkHqBAbikIFSPVhUOr7FYSC+jKTFRQ//f0Az/DU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sdhlOelJwMUheHffS/JMsRo715CIgAyhzUo5p2h8Fz1zIW4LAbz0+UFBd6uOfzxANGK3nIaY+hKM1LFtCfq2qQHySLGnXGH+7hJKHyup6qGLThct5/gvG9Q2s1MQbe3wjmN43lPWQQHcweVDiIbULVcMIusWooTvy7GlXsBCgKE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de; spf=pass smtp.mailfrom=birger-koblitz.de; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=AjfyQy73; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=MtwKdvAt; arc=none smtp.client-ip=23.88.97.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="AjfyQy73"; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="MtwKdvAt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688362; bh=1lJvFkHqBAbikIFSPVhUOr7FYSC+jKTFRQ//f0Az/DU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=AjfyQy73KrRMDUG/DJVcgkJNSUantkbWlQ4u8xkpC7I5cnYoxONjaQLbSogXz33GU AI8YsRs9RBucfWoS+Zfoxkt9SBxmApJe5FTsNjtDSFjnc7f9+TzHZ8goGGn7g66Dpa QXJy33yTRfdEFAfR8B4kIZV7mF3saLIfOPX4e4BTpMu6jmN+ADp2b6qH5BWXKPiEc+ 8ParRm7x79HtQ7VUDKyXXDJTmJFcm0cVnAhKY4ahAR4n1+l4OQP6bOubwyF6BD2aNf e/D6CR3GAz/wYLc6WwYwtlC4HruOAzcaK2nUVnP7/eBzvy5xSgPfueNsEMfZhBiV/G 3y81QsAEda5bw== Received: by bkemail.birger-koblitz.de (Postfix, from userid 109) id 9A0C44964D; Sun, 2 Aug 2026 16:32:42 +0000 (UTC) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688354; bh=1lJvFkHqBAbikIFSPVhUOr7FYSC+jKTFRQ//f0Az/DU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=MtwKdvAtI9mWwlm8mOCvZSaOcXlpGrSnRriwObCMdFLt8qTMTdSHEn7pcIB9qa8I3 byRWlV7nr3GWNm7f8e3HGyu5Ah+Z+mPeX24uPxux2PaH7eqTBm+80m43HbuOgvNIFM vA0q2/eoYJmcrC/PAUlQz8llIH25YkTU8bEJRfIuQlvLK5cvathHMceU2xJjm44vvi TaRyYxMVdXDIuBQSwfzkZe8sYM+2sQ2bs+mRX1sFZqNnIGzGoYHhs6FqtB4hJrnTJr BtF0iRpCLuGJ/gNawelFdnMvu2fh6umKzdbHx1irYOY3ccMyGajiWwxPvXKO8WfGd5 lr2ZR9WizwkBQ== Received: from ThinkPadAMD.lan (90-227-251-202-no2480.tbcn.telia.com [90.227.251.202]) by bkemail.birger-koblitz.de (Postfix) with ESMTPSA id 4C6E649643; Sun, 2 Aug 2026 16:32:34 +0000 (UTC) From: Birger Koblitz Date: Sun, 02 Aug 2026 18:32:04 +0200 Subject: [PATCH net-next v5 06/13] ax88179_178a: Add EEE configuration support for AX88179A PHYs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-ax88179a-v5-6-dcb9fea4acd4@birger-koblitz.de> References: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> In-Reply-To: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Andrew Lunn , Heiner Kallweit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Birger Koblitz , Jianhui Xu X-Mailer: b4 0.14.2 Configure phylink to work with the PHYs in the AX88197A controllers and provide ethtool get/set eee operations calling into phylink. Signed-off-by: Birger Koblitz Reviewed-by: Andrew Lunn Tested-by: Jianhui Xu --- drivers/net/usb/ax88179a_devices.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_= devices.c index 22c7d1a4501dc052ebb16e06dff86e70c00c8381..be07effc20c3df0bad294f591b7= 150b78b0b5020 100644 --- a/drivers/net/usb/ax88179a_devices.c +++ b/drivers/net/usb/ax88179a_devices.c @@ -209,6 +209,20 @@ static int ax88179a_get_eeprom_len(struct net_device *= net) return AX88179A_EEPROM_LEN; } =20 +static int ax88179a_get_eee(struct net_device *net, struct ethtool_keee *e= data) +{ + struct ax88179_data *ax179_data =3D netdev2data(net); + + return phylink_ethtool_get_eee(ax179_data->phylink, edata); +} + +static int ax88179a_set_eee(struct net_device *net, struct ethtool_keee *e= data) +{ + struct ax88179_data *ax179_data =3D netdev2data(net); + + return phylink_ethtool_set_eee(ax179_data->phylink, edata); +} + static const struct ethtool_ops ax88179a_ethtool_ops =3D { .get_link =3D ethtool_op_get_link, .get_msglevel =3D usbnet_get_msglevel, @@ -218,6 +232,8 @@ static const struct ethtool_ops ax88179a_ethtool_ops = =3D { .get_eeprom_len =3D ax88179a_get_eeprom_len, .get_eeprom =3D ax88179_get_eeprom, .set_eeprom =3D ax88179_set_eeprom, + .get_eee =3D ax88179a_get_eee, + .set_eee =3D ax88179a_set_eee, .nway_reset =3D usbnet_nway_reset, .get_link_ksettings =3D phy_ethtool_get_link_ksettings, .set_link_ksettings =3D phy_ethtool_set_link_ksettings, @@ -420,10 +436,18 @@ static int ax88179a_phylink_setup(struct usbnet *dev) else data->phylink_config.mac_capabilities |=3D MAC_1000 | MAC_2500FD; =20 + if (!data->is_ax88772d) { + data->phylink_config.lpi_capabilities =3D MAC_100FD | MAC_1000FD; + data->phylink_config.eee_enabled_default =3D true; + } __set_bit(PHY_INTERFACE_MODE_INTERNAL, data->phylink_config.supported_interfaces); phy_if_mode =3D PHY_INTERFACE_MODE_INTERNAL; =20 + memcpy(data->phylink_config.lpi_interfaces, + data->phylink_config.supported_interfaces, + sizeof(data->phylink_config.lpi_interfaces)); + phylink =3D phylink_create(&data->phylink_config, dev->net->dev.fwnode, phy_if_mode, &ax88179a_phylink_mac_ops); if (IS_ERR(phylink)) --=20 2.47.3 From nobody Fri Oct 2 10:08:42 2026 Received: from bkemail.birger-koblitz.de (bkemail.birger-koblitz.de [23.88.97.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 585643BBFC9; Sun, 2 Aug 2026 16:32:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.97.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688367; cv=none; b=YndHEx4MXwVlWLPkZ0Oh0QxvmHxfhcA+dcvygR8ZxjWbDoAfpd6td4LLUpmj6mbow3G6GFm1Rxy2kh4FGolYOqOSF7AMXT4g15TZs2fgbXPHdAaF6LpDh7I2G372t1gQqa47KGwbmLmwiqHjJVI9MTgkUEPI1mmCuwXe+Hn8N8s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688367; c=relaxed/simple; bh=iMBg19JSHRh1Ay47H58z14LCpuFncHmvXc2BwnB9/f8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IjfV+TKwjkO3nHSNxytWNWkwGnmsPzXWZhMSCBFMYuvkQ3shzHnciZK0q4Yf/6wvWt6NcSHgteZwc0TZZrD8eMRtVWaGoM3ujybu9vInhsU0voH40jvcxpB1ir2RXLUdSFBoK8rMW07dTnW8jaIa6ZVVpuplhXJb4LDaS7HSUYg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de; spf=pass smtp.mailfrom=birger-koblitz.de; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=ukPjAGFb; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=Cxwq5yYF; arc=none smtp.client-ip=23.88.97.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="ukPjAGFb"; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="Cxwq5yYF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688363; bh=iMBg19JSHRh1Ay47H58z14LCpuFncHmvXc2BwnB9/f8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ukPjAGFbSRS0zV0DdEAqQsO7TJ/CTU0uBNpUDUOpZVDwZVm+QSgaVvF0hJ9+ZQCJo bs5mSvBtUMDtmEXK5cdC+7/DiZX5fHCW4lUtlZBeKaIOzFrpQGZSVFXATf1XoNAcb1 fBKep0S/o0vW7yLiBuVuD5IiGB/RAm1Ywx0XVcatMk9zUItfWmtpSEYHjh3D3tRj0w bZhTP5fXGyetDF6zHgH/GGxVjFkuipNfF+hyxASKQRQYajarbuxWahWC94UwfCPgtS dlU7WUqOj4bFJTFeaYYFEp66Tj/d+qBlcOATxl4HLmvjsM8CQnJE9V+d0uQ8QIfgKR nnEBK+igWnIag== Received: by bkemail.birger-koblitz.de (Postfix, from userid 109) id 9A6F849665; Sun, 2 Aug 2026 16:32:43 +0000 (UTC) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688355; bh=iMBg19JSHRh1Ay47H58z14LCpuFncHmvXc2BwnB9/f8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Cxwq5yYFNc177byuUlUJl2N3cH6A3GHXNmIlSyxAkiuTt6pAEb1f+w7phu9L/1VXe awiyuuW4NB5Zsc3qSxfmanMw5QyAjtnQf2aW6QecrMMdEN1XQG7hePfby6ULID+Ay2 B/JhwnTCJxjWVZQ0ksPCW5iB6Lg+HMvfhsKZV+buu33BbLLTxCVS+yW/bPUXzY7EWD uMrnifGBoCNNsw3HNFp6tRpP5t8sJev0gTTR2a4Ecsh/83Tv96W/h+14Bz8uRN+fIn P/9GGKj8gnXxi/RUw85UT7CxMCpFaFAJyzjFQasA51n1p3LAZPF++frU6Lk2AKCgoF Wi7N2ua6cf4VA== Received: from ThinkPadAMD.lan (90-227-251-202-no2480.tbcn.telia.com [90.227.251.202]) by bkemail.birger-koblitz.de (Postfix) with ESMTPSA id D804D4964B; Sun, 2 Aug 2026 16:32:34 +0000 (UTC) From: Birger Koblitz Date: Sun, 02 Aug 2026 18:32:05 +0200 Subject: [PATCH net-next v5 07/13] ax88179_178a: Add VLAN offload support for AX88179A Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-ax88179a-v5-7-dcb9fea4acd4@birger-koblitz.de> References: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> In-Reply-To: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Andrew Lunn , Heiner Kallweit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Birger Koblitz , Jianhui Xu X-Mailer: b4 0.14.2 The AX88179A-based chips support VLAN offload. Add configuration support in netdev_ops. Features supported are: NETIF_F_HW_VLAN_CTAG_TX, NETIF_F_HW_VLAN_CTAG_RX and NETIF_F_HW_VLAN_CTAG_FILTER. Signed-off-by: Birger Koblitz Reviewed-by: Andrew Lunn Tested-by: Jianhui Xu --- drivers/net/usb/ax88179_lib.c | 2 + drivers/net/usb/ax88179a_devices.c | 102 +++++++++++++++++++++++++++++++++= ++++ 2 files changed, 104 insertions(+) diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c index 34350ba3b96b94bc82072a578802a91ebffd7a6a..9d6df9d5c61c841965e9f7fa4b1= 075561b7f9c50 100644 --- a/drivers/net/usb/ax88179_lib.c +++ b/drivers/net/usb/ax88179_lib.c @@ -355,6 +355,7 @@ int ax88179_set_features(struct net_device *net, netdev= _features_t features) { u8 tmp; struct usbnet *dev =3D netdev_priv(net); + struct ax88179_data *data =3D dev->driver_priv; netdev_features_t changed =3D net->features ^ features; =20 if (changed & NETIF_F_IP_CSUM) { @@ -374,6 +375,7 @@ int ax88179_set_features(struct net_device *net, netdev= _features_t features) tmp ^=3D AX_RXCOE_IP | AX_RXCOE_TCP | AX_RXCOE_UDP | AX_RXCOE_TCPV6 | AX_RXCOE_UDPV6; ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 1, &tmp); + data->rx_checksum =3D !!(features & NETIF_F_RXCSUM); } =20 return 0; diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_= devices.c index be07effc20c3df0bad294f591b7150b78b0b5020..213eb974b7da576bb6546532ce4= 5716055da1de0 100644 --- a/drivers/net/usb/ax88179a_devices.c +++ b/drivers/net/usb/ax88179a_devices.c @@ -242,6 +242,62 @@ static const struct ethtool_ops ax88179a_ethtool_ops = =3D { .get_ts_info =3D ethtool_op_get_ts_info, }; =20 +static int ax88179a_vlan_rx_kill_vid(struct net_device *net, __be16 proto,= u16 vid) +{ + struct usbnet *dev =3D netdev_priv(net); + u8 vlan_ctrl; + u16 reg16; + u8 reg8; + + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, ®= 8); + vlan_ctrl =3D reg8; + + /* Address */ + reg8 =3D (vid / 16); + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_ADDRESS, 1, 1, &re= g8); + + /* Data */ + reg8 =3D vlan_ctrl | AX_VLAN_CONTROL_RD; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, &re= g8); + + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_DATA0, 2, 2, ®16= ); + reg16 &=3D ~(1 << (vid % 16)); + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_DATA0, 2, 2, ®1= 6); + + reg8 =3D vlan_ctrl | AX_VLAN_CONTROL_WE; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, &re= g8); + + return 0; +} + +static int ax88179a_vlan_rx_add_vid(struct net_device *net, __be16 proto, = u16 vid) +{ + struct usbnet *dev =3D netdev_priv(net); + u8 vlan_ctrl; + u16 reg16; + u8 reg8; + + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, ®= 8); + vlan_ctrl =3D reg8; + + /* Address */ + reg8 =3D (vid / 16); + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_ADDRESS, 1, 1, &re= g8); + + /* Data */ + reg8 =3D vlan_ctrl | AX_VLAN_CONTROL_RD; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, &re= g8); + + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_DATA0, 2, 2, ®16= ); + reg16 |=3D (1 << (vid % 16)); + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_DATA0, 2, 2, ®1= 6); + + reg8 =3D vlan_ctrl | AX_VLAN_CONTROL_WE; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, &re= g8); + + return 0; +} + static void ax88179a_mdio_unregister(struct ax88179_data *data) { mdiobus_unregister(data->mdio); @@ -487,6 +543,49 @@ static int ax88179a_init_mdio(struct usbnet *dev) return ret; } =20 +static int ax88179a_set_features(struct net_device *net, netdev_features_t= features) +{ + struct usbnet *dev =3D netdev_priv(net); + netdev_features_t changed; + int ret; + u8 tmp; + + changed =3D net->features ^ features; + + ret =3D ax88179_set_features(net, features); + if (ret) + return ret; + + if (changed & NETIF_F_HW_VLAN_CTAG_FILTER) { + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, &tm= p); + tmp ^=3D AX_VLAN_CONTROL_VFE; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, &t= mp); + if (features & NETIF_F_HW_VLAN_CTAG_FILTER) { + for (int i =3D 0; i < 256; i++) { + u16 tmp16 =3D 0; + /* Address */ + tmp =3D i; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_ADDRESS, + 1, 1, &tmp); + /* Data */ + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_DATA0, + 2, 2, &tmp16); + tmp =3D AX_VLAN_CONTROL_WE; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, + 1, 1, &tmp); + } + } + } + + if (changed & NETIF_F_HW_VLAN_CTAG_RX) { + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, &tm= p); + tmp ^=3D AX_VLAN_CONTROL_VSO; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, &t= mp); + } + + return 0; +} + static const struct net_device_ops ax88179a_netdev_ops =3D { .ndo_open =3D usbnet_open, .ndo_stop =3D usbnet_stop, @@ -497,6 +596,9 @@ static const struct net_device_ops ax88179a_netdev_ops = =3D { .ndo_set_mac_address =3D ax88179_set_mac_addr, .ndo_validate_addr =3D eth_validate_addr, .ndo_eth_ioctl =3D usbnet_mii_ioctl, + .ndo_set_features =3D ax88179a_set_features, + .ndo_vlan_rx_add_vid =3D ax88179a_vlan_rx_add_vid, + .ndo_vlan_rx_kill_vid =3D ax88179a_vlan_rx_kill_vid, }; =20 static int ax88179a_bind(struct usbnet *dev, struct usb_interface *intf) --=20 2.47.3 From nobody Fri Oct 2 10:08:42 2026 Received: from bkemail.birger-koblitz.de (bkemail.birger-koblitz.de [23.88.97.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A35513BE646; Sun, 2 Aug 2026 16:32:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.97.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688368; cv=none; b=artcA0oP3NDgZesoXg3lJik2gAGUXktOnW7VtHi5jORiOBdIN7c1rC2zoc+u+d3Z/rAzJB1X8ii5rUlVHs2Wj8Y18SxoQjswSfAcKohaSIsXO5thNkkucbz1jbPk/cjXdUzeJA/Sy3u4yyt769RtZr6nazaIJl6uKw0GTEtaMiU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688368; c=relaxed/simple; bh=xoHH9cUOLWL2L7ppRswu4lHeGWC0NZSts6QDXgqPs/M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CBZBA/CQPrdKk5aORAKcajN5MKO2mUDpGOr5K9r8xzoxLmpN4GrrIu9FH7SI/qXtgA5q6CL/jrYnV8oEs5UH/Jz11gclGCS5srN2eUQvoghYz6h54rSDE4prTYDuRLYvKIFyhH5Ghc4Bh5/h8mBZ90NG7lIVLWOJK/t4Bj8aLV0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de; spf=pass smtp.mailfrom=birger-koblitz.de; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=W8POj3pf; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=th8UZkVb; arc=none smtp.client-ip=23.88.97.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="W8POj3pf"; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="th8UZkVb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688364; bh=xoHH9cUOLWL2L7ppRswu4lHeGWC0NZSts6QDXgqPs/M=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=W8POj3pfNZ9SNIVs7fz0BaTri09CcOjxkZBxdKZDnl31/1xojxX6xfaAjKZp0nej6 rhUrAEqhS67ErkfL7kOONYLffS+NMK8/c3HBRtAqXwn+fJI45wGLELDedm8WUWKfWN BDUt/u4kcUl1kz9Jkracjk1irUELJ3dVmA+pJq86KLj5ZREyqqbkhgrY3wLnUpA+1D hYyJuu7QFTSIAB1Ke/MJEvM9WQy9y9VFd/vdK7AW5nMSplQMDYaBNenM3UjWY30xCF hVBD4FtaiHZOCBOw/akGwQZrW8xocKKLaBL4Y2H2fogGp+Gtm9vlFbaHVHqiZSeM5L TeaTDiVKRh7Rw== Received: by bkemail.birger-koblitz.de (Postfix, from userid 109) id 20EBE4965E; Sun, 2 Aug 2026 16:32:44 +0000 (UTC) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688355; bh=xoHH9cUOLWL2L7ppRswu4lHeGWC0NZSts6QDXgqPs/M=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=th8UZkVb4eEa1m2g8+CFHDbAYgXAZxHXRdr+2HO9AHTEMURiFaFgziECtSlUfpiNR 0QR7Y3smGeIksjfTQpjj+G9sTVbFecgquH4e3EonoLSf1+cGihPezjp/3zunuRUqI+ ZejRfPb1iNLYsdge4BMWnzAuYXW14CGOIGQRuNN/HtVIuHTJg8+W6IXw4NohPAemT2 kdHVNYaGQBFSjSIA6Xc544U7wRMjzU7qBZQPoOYEDyOiQJr2tG+ZOKlzUFVIe++WJq 5Wlh22KpLJjUf+Lf5gfA8vsvjO/RLiEtOacVwFG7oCXO1Cf3RE8w3g2tiBicM9Isew A6UhTgB6tjyHg== Received: from ThinkPadAMD.lan (90-227-251-202-no2480.tbcn.telia.com [90.227.251.202]) by bkemail.birger-koblitz.de (Postfix) with ESMTPSA id 71E464964C; Sun, 2 Aug 2026 16:32:35 +0000 (UTC) From: Birger Koblitz Date: Sun, 02 Aug 2026 18:32:06 +0200 Subject: [PATCH net-next v5 08/13] ax88179_178a: Add AX179A/AX279 multicast configuration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-ax88179a-v5-8-dcb9fea4acd4@birger-koblitz.de> References: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> In-Reply-To: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Andrew Lunn , Heiner Kallweit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Birger Koblitz , Jianhui Xu X-Mailer: b4 0.14.2 Add support for conditionally setting the ip_alignement flag AX_RX_CTL_IPE in AX_RX_CTL and make sure that AX_RX_CTL_DROPCRCERR is also set to be consistent with the initial configuration in ax88179_reset() Signed-off-by: Birger Koblitz Reviewed-by: Andrew Lunn Tested-by: Jianhui Xu --- drivers/net/usb/ax88179_lib.c | 8 ++++++-- drivers/net/usb/ax88179a_devices.c | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c index 9d6df9d5c61c841965e9f7fa4b1075561b7f9c50..7a8c12027b9fcf7141694952528= 861e986d065ad 100644 --- a/drivers/net/usb/ax88179_lib.c +++ b/drivers/net/usb/ax88179_lib.c @@ -314,10 +314,14 @@ int ax88179_set_eeprom(struct net_device *net, struct= ethtool_eeprom *eeprom, u8 void ax88179_set_multicast(struct net_device *net) { struct usbnet *dev =3D netdev_priv(net); - struct ax88179_data *data =3D dev->driver_priv; u8 *m_filter =3D ((u8 *)dev->data); + struct ax88179_data *data; + + data =3D dev->driver_priv; =20 - data->rxctl =3D (AX_RX_CTL_START | AX_RX_CTL_AB | AX_RX_CTL_IPE); + data->rxctl =3D (AX_RX_CTL_START | AX_RX_CTL_AB | AX_RX_CTL_DROPCRCERR); + if (data->ip_align) + data->rxctl |=3D AX_RX_CTL_IPE; =20 if (net->flags & IFF_PROMISC) { data->rxctl |=3D AX_RX_CTL_PRO; diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_= devices.c index 213eb974b7da576bb6546532ce45716055da1de0..70d0780ae5bcd9339dc456fffac= dea86a4bf39a9 100644 --- a/drivers/net/usb/ax88179a_devices.c +++ b/drivers/net/usb/ax88179a_devices.c @@ -596,6 +596,7 @@ static const struct net_device_ops ax88179a_netdev_ops = =3D { .ndo_set_mac_address =3D ax88179_set_mac_addr, .ndo_validate_addr =3D eth_validate_addr, .ndo_eth_ioctl =3D usbnet_mii_ioctl, + .ndo_set_rx_mode =3D ax88179_set_multicast, .ndo_set_features =3D ax88179a_set_features, .ndo_vlan_rx_add_vid =3D ax88179a_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid =3D ax88179a_vlan_rx_kill_vid, --=20 2.47.3 From nobody Fri Oct 2 10:08:42 2026 Received: from bkemail.birger-koblitz.de (bkemail.birger-koblitz.de [23.88.97.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 907DC3C5826; Sun, 2 Aug 2026 16:32:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.97.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688370; cv=none; b=ZEtmM2b/xwm8zPzMr9l4KD7a1yZyhMW4FmrD73Pm0BkpsZyepVw3nLOAETs9d7B0TG6GULRso6ACoJab9PqwHHfC0pMj0vtk0mz0TcSvSyxPGJ2kKcOu3WidVPbhI22D7VafR9Ms54/sgcz5yPXQZnKf81paHoBaDAxrzD77RAI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688370; c=relaxed/simple; bh=IXiptK1pRjG8znEjgRZfXus3k/jYM4cOSQOJ0BRDk8Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LXc2dRPgVeuetzj7/cMgtobfu91VJgExA/xFbgzCK9MDCI1Lp1FksTygSXbacJOCf2Xgme3hBObj3r8KMl0JjYIWGCHBJK+WAPZfiRAN8AsXxn16978aGfQTIyEsjUk8ZkjBfL4JSsX5//k/jFPuKyVHqZwDTKJ1f0C24X+EfWc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de; spf=pass smtp.mailfrom=birger-koblitz.de; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=l7ForUvb; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=AQv87DDR; arc=none smtp.client-ip=23.88.97.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="l7ForUvb"; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="AQv87DDR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688365; bh=IXiptK1pRjG8znEjgRZfXus3k/jYM4cOSQOJ0BRDk8Q=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=l7ForUvbluhSJklPnS5jk1Px6jr9zU9Kx9ov0p2vzcDvVkLSSLRPcCP/aRf6TApmS cXDAsg2qYbfUbAcZ4IHiVieg4VqxpY0jOYJYMZ3Ar575e+kHxX4BSTh2+nGquSdZpq oNxLsiCIpaB88Y4uZ5XjFrT/nFUiMgIJjd6PbE4xwTAifOwwZAqIl+gLrkmQoWPgjH snf2SXCri1I/n3lsFGOXrHhEvnLHi7eXRXOqQ+B2HdF1T3ewWzoU5cBHIPr/iTQ/8P 9UsaZLoUZ0aacrRPhm30P3v5zaCVbwIi6TtRM34TPJFuWq/fJ0oTzFPE2bE0XJjVFI i/HIEJPaIPc2w== Received: by bkemail.birger-koblitz.de (Postfix, from userid 109) id DCA0449650; Sun, 2 Aug 2026 16:32:45 +0000 (UTC) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688356; bh=IXiptK1pRjG8znEjgRZfXus3k/jYM4cOSQOJ0BRDk8Q=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=AQv87DDRPvHUm4iVCwSLKBoM4/cXXVR3d5F/EjbhK0Dlldm/Qg9I6UKjp+gn43mVl jI8d5Hui4WliOUcPnLZGTYJEyLocVzmCDSXG/5/HZbwfp8zNMjKKId3rQ0RSK3QhQR ORnawkb2UdPbfAWRjuwRdaGABE+HHYSkndJep+xWNKf3kkr2athPBmEGu+AuleORyL d+peHrzXbFVnnfriLuFa00mcvsKY3xfb8BJ6B3jDR0LWgtg4aem0KtR6aWo9I3CgxJ selYlNk+AmNIiv6BTgZAmA/L9uXepgB4QGMNbo5muUrBT/z3PocskPiNW39HpQpxfJ CpxpwB71Rrz4g== Received: from ThinkPadAMD.lan (90-227-251-202-no2480.tbcn.telia.com [90.227.251.202]) by bkemail.birger-koblitz.de (Postfix) with ESMTPSA id 074524964F; Sun, 2 Aug 2026 16:32:35 +0000 (UTC) From: Birger Koblitz Date: Sun, 02 Aug 2026 18:32:07 +0200 Subject: [PATCH net-next v5 09/13] ax88179_178a: Add Suspend/resume support for AX88179A/772D/279 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-ax88179a-v5-9-dcb9fea4acd4@birger-koblitz.de> References: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> In-Reply-To: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Andrew Lunn , Heiner Kallweit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Birger Koblitz , Jianhui Xu X-Mailer: b4 0.14.2 The suspend and resume functions are called via the usb_driver structure, for which the driver has only a single instance. Add wrapper functions for the different implementations for the AX88179 and AX179A architecutres in ax88179_lib which calls the 2 implementations in ax88179_178a and ax88179a_devices, respectively. Signed-off-by: Birger Koblitz Tested-by: Jianhui Xu --- drivers/net/usb/ax88179_178a.c | 9 ++-- drivers/net/usb/ax88179_lib.c | 19 ++++++++ drivers/net/usb/ax88179_lib.h | 4 ++ drivers/net/usb/ax88179a_devices.c | 95 ++++++++++++++++++++++++++++++++++= +++- 4 files changed, 123 insertions(+), 4 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 6bd9704046009d7aad5ee6ddddc18faab5b030dc..8c22c2517cc08249c4e89625f14= 2a76d4edc7d6a 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -684,6 +684,9 @@ static int ax88179_bind(struct usbnet *dev, struct usb_= interface *intf) =20 dev->driver_priv =3D ax179_data; =20 + ax179_data->resume =3D ax88179_resume; + ax179_data->suspend =3D ax88179_suspend; + dev->net->netdev_ops =3D &ax88179_netdev_ops; dev->net->ethtool_ops =3D &ax88179_ethtool_ops; dev->net->needed_headroom =3D 8; @@ -1340,9 +1343,9 @@ static struct usb_driver ax88179_178a_driver =3D { .name =3D "ax88179_178a", .id_table =3D products, .probe =3D usbnet_probe, - .suspend =3D ax88179_suspend, - .resume =3D ax88179_resume, - .reset_resume =3D ax88179_resume, + .suspend =3D ax88179_suspend_wrapper, + .resume =3D ax88179_resume_wrapper, + .reset_resume =3D ax88179_resume_wrapper, .disconnect =3D ax88179_disconnect, .supports_autosuspend =3D 1, .disable_hub_initiated_lpm =3D 1, diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c index 7a8c12027b9fcf7141694952528861e986d065ad..8aa5489d4bbc46faa1545cdfb85= f65d8035c0c3c 100644 --- a/drivers/net/usb/ax88179_lib.c +++ b/drivers/net/usb/ax88179_lib.c @@ -464,3 +464,22 @@ int ax88179_set_mac_addr(struct net_device *net, void = *p) return 0; } =20 +int ax88179_suspend_wrapper(struct usb_interface *intf, pm_message_t messa= ge) +{ + struct usbnet *dev =3D usb_get_intfdata(intf); + struct ax88179_data *priv; + + priv =3D dev->driver_priv; + + return priv->suspend(intf, message); +} + +int ax88179_resume_wrapper(struct usb_interface *intf) +{ + struct usbnet *dev =3D usb_get_intfdata(intf); + struct ax88179_data *priv; + + priv =3D dev->driver_priv; + return priv->resume(intf); +} + diff --git a/drivers/net/usb/ax88179_lib.h b/drivers/net/usb/ax88179_lib.h index 2e4d35c74ee8b32cd2916924b85d5427860bb08c..16a6dcbd6e66e37d3da0e57d280= 0c29d8a95a34a 100644 --- a/drivers/net/usb/ax88179_lib.h +++ b/drivers/net/usb/ax88179_lib.h @@ -315,6 +315,8 @@ struct ax88179_data { struct phy_device *phydev; struct phylink *phylink; struct phylink_config phylink_config; + int (*resume)(struct usb_interface *intf); + int (*suspend)(struct usb_interface *intf, pm_message_t message); }; =20 struct ax88179_int_data { @@ -346,6 +348,8 @@ int ax88179_set_features(struct net_device *net, netdev= _features_t features); void ax88179_get_mac_addr(struct usbnet *dev); int ax88179_change_mtu(struct net_device *net, int new_mtu); int ax88179_set_mac_addr(struct net_device *net, void *p); +int ax88179_suspend_wrapper(struct usb_interface *intf, pm_message_t messa= ge); +int ax88179_resume_wrapper(struct usb_interface *intf); =20 extern const struct driver_info ax88179a_info; extern const struct driver_info ax88772d_info; diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_= devices.c index 70d0780ae5bcd9339dc456fffacdea86a4bf39a9..4a3c2e77b1baba7e0c5bd542517= 9dfd1180b9b09 100644 --- a/drivers/net/usb/ax88179a_devices.c +++ b/drivers/net/usb/ax88179a_devices.c @@ -5,6 +5,8 @@ #include #include "ax88179_lib.h" =20 +static int ax88179a_reset(struct usbnet *dev); + #define AX88279_EEPROM_LEN 0x4000 #define AX88179A_EEPROM_LEN (32 * 20) =20 @@ -106,6 +108,53 @@ static int ax88179_mdiobus_write_c45(struct mii_bus *b= us, int addr, int devnum, return ax179a_write_mmd(dev, devnum, regnum, val); } =20 +static int ax88179a_suspend(struct usb_interface *intf, pm_message_t messa= ge) +{ + struct usbnet *dev =3D usb_get_intfdata(intf); + struct ax88179_data *priv; + u16 tmp16; + u8 tmp8; + + priv =3D dev->driver_priv; + ax88179_set_pm_mode(dev, true); + + if (netif_running(dev->net)) { + rtnl_lock(); + phylink_suspend(priv->phylink, !!priv->wolopts); + rtnl_unlock(); + } + + /* Enable WoL */ + if (priv->wolopts) { + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MONITOR_MOD, 1, 1, &tmp8); + if (priv->wolopts & WAKE_PHY) + tmp8 |=3D AX_MONITOR_MODE_RWLC; + if (priv->wolopts & WAKE_MAGIC) + tmp8 |=3D AX_MONITOR_MODE_RWMP; + + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MONITOR_MOD, 1, 1, &tmp8); + + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, &tmp16= ); + tmp16 |=3D AX_MEDIUM_RECEIVE_EN; + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, &tmp1= 6); + + if (priv->chip_version =3D=3D AX_VERSION_AX88279) + ax88179_write_cmd(dev, AX88179A_WAKEUP_SETTING, 8, + EPHY_LOW_POWER_EN | S5_WOL_EN + | S5_WOL_LOW_POWER | 0x8000, 0, NULL); + else + ax88179_write_cmd(dev, AX88179A_WAKEUP_SETTING, 0, + EPHY_LOW_POWER_EN, 0, NULL); + + } else if (priv->chip_version =3D=3D AX_VERSION_AX88279) { + ax88179_write_cmd(dev, AX88179A_WAKEUP_SETTING, 8, 0x8000, 0, NULL); + } + + usbnet_suspend(intf, message); + ax88179_set_pm_mode(dev, false); + return 0; +} + static int ax88179a_auto_detach(struct usbnet *dev) { u16 tmp16; @@ -115,6 +164,43 @@ static int ax88179a_auto_detach(struct usbnet *dev) return 0; } =20 +static int ax88179a_resume(struct usb_interface *intf) +{ + struct usbnet *dev =3D usb_get_intfdata(intf); + struct ax88179_data *ax179_data; + u8 reg8; + + ax179_data =3D dev->driver_priv; + ax88179_set_pm_mode(dev, true); + + ax88179_read_cmd(dev, AX88179A_PHY_POWER, 0, 0, 1, ®8); + if (!(reg8 & AX_PHY_POWER)) { + reg8 =3D AX_PHY_POWER; + ax88179_write_cmd(dev, AX88179A_PHY_POWER, 0, 0, 1, ®8); + msleep(250); + } + ax88179_write_cmd(dev, AX_FW_MODE, AX_FW_MODE_179A, 0, 0, NULL); + + /* Now, that AX_FW_MODE_179A is enabled, the PHY needs a power-cycle. + * PHY-power is re-enabled in ax88179_reset() + */ + reg8 =3D 0; + ax88179_write_cmd(dev, AX88179A_PHY_POWER, 0, 0, 1, ®8); + msleep(250); + + if (netif_running(dev->net)) { + rtnl_lock(); + phylink_resume(ax179_data->phylink); + rtnl_unlock(); + } + + ax88179a_reset(dev); + + ax88179_set_pm_mode(dev, false); + + return usbnet_resume(intf); +} + static void ax88179a_bulkin_config(struct usbnet *dev, u8 link_sts) { struct ax88179_data *ax179_data =3D dev->driver_priv; @@ -668,6 +754,9 @@ static int ax88179a_bind(struct usbnet *dev, struct usb= _interface *intf) ax179_data->eeprom_wen =3D 0; } =20 + ax179_data->resume =3D ax88179a_resume; + ax179_data->suspend =3D ax88179a_suspend; + dev->net->netdev_ops =3D &ax88179a_netdev_ops; dev->net->ethtool_ops =3D &ax88179a_ethtool_ops; dev->net->needed_headroom =3D 8; @@ -1027,7 +1116,11 @@ static int ax88179a_reset(struct usbnet *dev) 1, 1, &tmp) > 0) ax179_data->wol_supported =3D WAKE_MAGIC | WAKE_PHY; =20 - phylink_start(ax179_data->phylink); + /* ax88179a_reset() may also be called from resume context, phylink + * is already started, then. + */ + if (!ax179_data->in_pm) + phylink_start(ax179_data->phylink); =20 usbnet_link_change(dev, 0, 0); =20 --=20 2.47.3 From nobody Fri Oct 2 10:08:42 2026 Received: from bkemail.birger-koblitz.de (bkemail.birger-koblitz.de [23.88.97.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13D7D3C819C; Sun, 2 Aug 2026 16:32:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.97.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688371; cv=none; b=NgBH0xfyYtQAZbgQUUh4RRtIKV80CdgnZalJnYG7BzlOBRgA/HT804DuJaK1sG2nNxLoe7rQcqW6xLn3elq5euEybG6r809+aVWw62kGPDk3cb7t7bGNAwYyOzLd07WnooJuEhz2o7qc7h7vs1U856Y/R+ALnM7icn5RpREtAFI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688371; c=relaxed/simple; bh=8icT4J/o3lofd7IFk7tygDgW00qwK7iZKkAxg2q4LnA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NXDsblBN0lY2jZCbE8aOn9XBMPiXl+UD6suRxcpdNqS0vkvCIRMmGn8VwfQb1qE0DCInKwf3LCT+np3r1XQZN//Pr5qBjZvBBIH7Vn7fVzFuv9DVx5xHGaiWTWCpT7NTMuWM7/6lGLzOeuK/Dpcx3Ph/h9PJ/FZ5aO0cUDEWUvU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de; spf=pass smtp.mailfrom=birger-koblitz.de; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=iJJnrdPm; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=UQ5fcCfP; arc=none smtp.client-ip=23.88.97.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="iJJnrdPm"; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="UQ5fcCfP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688366; bh=8icT4J/o3lofd7IFk7tygDgW00qwK7iZKkAxg2q4LnA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=iJJnrdPmOO2gAulUwyipeXEadRdYZ1okAv7KW/fGuHc6HznMg5FNJN9Au5+Bsvzd7 vh4wWERm7iqKK85oJH4XrezARjOGPNOMyJwf014h+p1WaeJKdOZPQ4bzMqnxKwjPoq NEreddvLbvjR7k27v+oElCKVX7pwDkIvSToBukjxAUOLkLmCXWXYcFnYOlMVZmr0An 0G53eIetkPtOsFrV+JRwLm2n0b7LrEZVIJBtwkfKYqMQBn2kik2T5wg0DQw1vIPjhJ DvLenNvRUcEv2gman+CXbW8j5bxgTtav6Vb6ZT9Ap6Q+9sUEUpt8imnSuVNQ1kQgtk 8Q/8oiCLYMN2w== Received: by bkemail.birger-koblitz.de (Postfix, from userid 109) id 55FBE49658; Sun, 2 Aug 2026 16:32:46 +0000 (UTC) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688357; bh=8icT4J/o3lofd7IFk7tygDgW00qwK7iZKkAxg2q4LnA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=UQ5fcCfP2JJYwfAP9/QYNZWcP5r/zmFHYdIIHhx9RmfxW16CSNcVjtpRZ0RN4QsFs 78gUS0jnOI3ikhdpRj/U6DqySKFKXfNJ2qHavIwSD3/519AUNr5JJOUgG4/A+blK3X htqvGXRYQTU943ffycqaHLkznLHYqtlgeeNs4XJYAPsdfOx82M2x8aB3CmRql8fEib 1Xu0s/J1msmiXeM/TY+h0uQd5ws7PINFY6U3qXlAF2+4C0pY+EwR4/jx7YAewxrmAU noGYeGiJxvaA/63CMcWMjs2ZDyCEynIMIBdhuON/JsQujPgPhI3ecr9v4vo/HNkp3k ETfw6oT5Mplzw== Received: from ThinkPadAMD.lan (90-227-251-202-no2480.tbcn.telia.com [90.227.251.202]) by bkemail.birger-koblitz.de (Postfix) with ESMTPSA id 8F62449654; Sun, 2 Aug 2026 16:32:36 +0000 (UTC) From: Birger Koblitz Date: Sun, 02 Aug 2026 18:32:08 +0200 Subject: [PATCH net-next v5 10/13] ax88179_178a: Add ethtool get_drvinfo Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-ax88179a-v5-10-dcb9fea4acd4@birger-koblitz.de> References: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> In-Reply-To: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Andrew Lunn , Heiner Kallweit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Birger Koblitz , Jianhui Xu X-Mailer: b4 0.14.2 Add ax88179a_get_drvinfo() as implementation of get_drvinfo, in order to provide information about the device firmware. Signed-off-by: Birger Koblitz Reviewed-by: Andrew Lunn Tested-by: Jianhui Xu --- drivers/net/usb/ax88179a_devices.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_= devices.c index 4a3c2e77b1baba7e0c5bd5425179dfd1180b9b09..37a55ff5464c6569ac729013787= 63ca419dd306a 100644 --- a/drivers/net/usb/ax88179a_devices.c +++ b/drivers/net/usb/ax88179a_devices.c @@ -201,6 +201,20 @@ static int ax88179a_resume(struct usb_interface *intf) return usbnet_resume(intf); } =20 +static void ax88179a_get_drvinfo(struct net_device *net, struct ethtool_dr= vinfo *info) +{ + struct ax88179_data *priv =3D netdev2data(net); + + /* Inherit standard device info */ + usbnet_get_drvinfo(net, info); + if (priv->chip_version < AX_VERSION_AX88179A) + return; + + snprintf(info->fw_version, sizeof(info->fw_version), "%d.%d.%d.%d", + priv->fw_version[0], priv->fw_version[1], + priv->fw_version[2], priv->fw_version[3]); +} + static void ax88179a_bulkin_config(struct usbnet *dev, u8 link_sts) { struct ax88179_data *ax179_data =3D dev->driver_priv; @@ -310,6 +324,7 @@ static int ax88179a_set_eee(struct net_device *net, str= uct ethtool_keee *edata) } =20 static const struct ethtool_ops ax88179a_ethtool_ops =3D { + .get_drvinfo =3D ax88179a_get_drvinfo, .get_link =3D ethtool_op_get_link, .get_msglevel =3D usbnet_get_msglevel, .set_msglevel =3D usbnet_set_msglevel, --=20 2.47.3 From nobody Fri Oct 2 10:08:42 2026 Received: from bkemail.birger-koblitz.de (bkemail.birger-koblitz.de [23.88.97.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C7483CB547; Sun, 2 Aug 2026 16:32:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.97.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688371; cv=none; b=pBGXaH5IOKHZbHL1DrE3AMxpWvnp6K+aj6e+WkDEb4Km184+cEJXbW3xSa9DpKS/IfWluIONg23VH5LJfUB3upnqsUk4WN+HRTMukFaLfcnT8bKdZ+uHmdLssOhvqCyBvmhOKtNYYmIrA9+oAkfEZbuWQgCmJWc9gkAP0sCU7JQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688371; c=relaxed/simple; bh=yJI1i9OovlKPX702eR4VoV2OZS2wvoRbasdSeeN/BU4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IXTu8KFGB4zWZbJLNUz9kkanclKsv9AoNfJ+nuPtOylA3bzlZCH3NM7SG9s+u5+gM3PXwqHGMNTt2Igdgrx6wvZRSFf7SYmqDpBfHRlT37NjleQvEuvBoe64hAgjObk3MqleLMSi1LubPVpFrBE3LnggxRiO7D6hdx4j9yr8ZKs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de; spf=pass smtp.mailfrom=birger-koblitz.de; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=M6vjA+OR; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=aQkgWn46; arc=none smtp.client-ip=23.88.97.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="M6vjA+OR"; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="aQkgWn46" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688366; bh=yJI1i9OovlKPX702eR4VoV2OZS2wvoRbasdSeeN/BU4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=M6vjA+ORTvM4gGJJ4r14dZRDJz9cBqeWAVLEr6wHgq7QTJRwGTOjTAlNgIOeVx22g Y3Xanm6CaOYkVU7ak12yeDuMSEGyn+w69nFzSTFD68P7aL+13PSvoQ3+4M+tdKILZe 59QWV9XeLVaQabYy+P1+RENp/MRcT3PXWqQVjBX3/Je7Swp/OIGMRdFnsSVgfRWvUz 9WhDELex8Bs8bXA7e4DraEMT45jNK+ZALEoXsqVAvZbJwVGwYUjyS9Ux5y9m49+Dfn mSOauXISVF7lSrSlQMOetmfy7sECedhb4axm/p+xwAJa8DmCtRQxVMuNstOYyMUN0Z PrdvRaxeao9+g== Received: by bkemail.birger-koblitz.de (Postfix, from userid 109) id 76FB54965D; Sun, 2 Aug 2026 16:32:46 +0000 (UTC) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688357; bh=yJI1i9OovlKPX702eR4VoV2OZS2wvoRbasdSeeN/BU4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=aQkgWn46xqLUyL+QjOFvDYzafirmX0NyTII6JuymYtK+UdQzxIhWkZUU/QjA+mU6M xMnq7ty/vayRp1ewgsrXmyOn4byXd9o2Xd3/pvdDxkSNo7OQeItqnBKfj4KDpBAjqm VLupyQKE6SIwqXefItAPowRH8ejLnNedxLLG5BCBabXafLA0oH4WOQ+yUH7WRD03PU /IAA6B0/M+ozzejFHji+dL9X80jayyzgrhuno19aO9QCPpiJZPH1IdXmyP9k/gA6e7 +QJ8fZKRP2uRFMlVeLqSAtsvzJHodncfBVuwKjVPmoVmiw1sHj0JEOhgagf9GtP8/k ApqgRN+5rJ/jQ== Received: from ThinkPadAMD.lan (90-227-251-202-no2480.tbcn.telia.com [90.227.251.202]) by bkemail.birger-koblitz.de (Postfix) with ESMTPSA id 23F0B49651; Sun, 2 Aug 2026 16:32:37 +0000 (UTC) From: Birger Koblitz Date: Sun, 02 Aug 2026 18:32:09 +0200 Subject: [PATCH net-next v5 11/13] ax88179_178a: Update driver name and information Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-ax88179a-v5-11-dcb9fea4acd4@birger-koblitz.de> References: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> In-Reply-To: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Andrew Lunn , Heiner Kallweit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Birger Koblitz , Jianhui Xu X-Mailer: b4 0.14.2 Add additionally supported devices to Kconfig description, add further requirements such as PHYLINK. Update driver name in usb_driver and update MODULE_DESCRIPTION to include the additionally supported chips. Signed-off-by: Birger Koblitz Reviewed-by: Andrew Lunn Tested-by: Jianhui Xu --- drivers/net/usb/Kconfig | 10 +++++++--- drivers/net/usb/Makefile | 2 +- drivers/net/usb/ax88179_178a.c | 8 ++++---- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig index 115990b0d9537aea2776544c9768b034f32aa7a4..4158455a2da76cd43a9a9d9d0e8= c66028d57b095 100644 --- a/drivers/net/usb/Kconfig +++ b/drivers/net/usb/Kconfig @@ -195,11 +195,12 @@ config USB_NET_AX8817X This driver creates an interface named "ethX", where X depends on what other networking devices you have in use. =20 -config USB_NET_AX88179_178A - tristate "ASIX AX88179/178A USB 3.0/2.0 to Gigabit Ethernet" +config USB_NET_AX88179 + tristate "ASIX AX88179/179A/178A USB 3.0/2.0 to Gigabit Ethernet" depends on USB_USBNET - select CRC32 select PHYLINK + select AX88796B_PHY + select CRC32 default y help This option adds support for ASIX AX88179 based USB 3.0/2.0 @@ -207,6 +208,9 @@ config USB_NET_AX88179_178A =20 This driver should work with at least the following devices: * ASIX AX88179 + * ASIX AX88179A/B + * ASIX AX88279 + * ASIX AX88772D/E * ASIX AX88178A * Sitcomm LN-032 =20 diff --git a/drivers/net/usb/Makefile b/drivers/net/usb/Makefile index 2ecead0181eaf8d66fb6f5dbd6f2905b22b6eb57..4026f19ecb826a6465de38f1d9b= b0e4c0af80421 100644 --- a/drivers/net/usb/Makefile +++ b/drivers/net/usb/Makefile @@ -12,7 +12,7 @@ obj-$(CONFIG_USB_HSO) +=3D hso.o obj-$(CONFIG_USB_LAN78XX) +=3D lan78xx.o obj-$(CONFIG_USB_NET_AX8817X) +=3D asix.o asix-y :=3D asix_devices.o asix_common.o ax88172a.o -obj-$(CONFIG_USB_NET_AX88179_178A) +=3D ax88179.o +obj-$(CONFIG_USB_NET_AX88179) +=3D ax88179.o ax88179-y :=3D ax88179_178a.o ax88179a_devices.o ax88179_lib.o obj-$(CONFIG_USB_NET_CDCETHER) +=3D cdc_ether.o obj-$(CONFIG_USB_NET_CDC_EEM) +=3D cdc_eem.o diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 8c22c2517cc08249c4e89625f142a76d4edc7d6a..6d6ee39b342e9b4e008bb2c1ee2= 76dc27279a2f7 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -1339,8 +1339,8 @@ static const struct usb_device_id products[] =3D { }; MODULE_DEVICE_TABLE(usb, products); =20 -static struct usb_driver ax88179_178a_driver =3D { - .name =3D "ax88179_178a", +static struct usb_driver ax88179_driver =3D { + .name =3D "ax88179", .id_table =3D products, .probe =3D usbnet_probe, .suspend =3D ax88179_suspend_wrapper, @@ -1351,7 +1351,7 @@ static struct usb_driver ax88179_178a_driver =3D { .disable_hub_initiated_lpm =3D 1, }; =20 -module_usb_driver(ax88179_178a_driver); +module_usb_driver(ax88179_driver); =20 -MODULE_DESCRIPTION("ASIX AX88179/178A based USB 3.0/2.0 Gigabit Ethernet D= evices"); +MODULE_DESCRIPTION("ASIX AX88179/179A/178A based USB 3.0/2.0 Gigabit Ether= net Devices"); MODULE_LICENSE("GPL"); --=20 2.47.3 From nobody Fri Oct 2 10:08:42 2026 Received: from bkemail.birger-koblitz.de (bkemail.birger-koblitz.de [23.88.97.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 186943C3F52; Sun, 2 Aug 2026 16:32:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.97.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688371; cv=none; b=npFEos1qfWLJV5Kf7y7ni3nwRM7SV5v/Ni1P/dlThC1SEViigrDOEKmVPdDl+iSFthHgOfVflDuzD8Vr4hBWNSNkDXGIRk50BeyoKgY4QfIeiiYeriBO4dXxhPQLZc8cQR6UytzLHPvj2NRR9BI6To0GmsIzGE6X5gUxUoFyWrA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688371; c=relaxed/simple; bh=jShhd6P/W3mf0dYLRwM2NXXvZDo9conzYgts+79W70E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qNN/X3Qv4vz3uQiLltaATVrrXLfuHdpiSkqzv2w7OlLeAknthoi7DLik/fa4vli7WBUh4jZaiMaWJMfODLk6HL/yVtnAokKOhuGWTVEdb6EpL6/zTyW4FzZZZP1olGehzjBsK5Va6N0Z2NSg5JZpZx3vdVhh72Zw2huOMRC2pEI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de; spf=pass smtp.mailfrom=birger-koblitz.de; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=1PPiqZQ+; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=TsGD2429; arc=none smtp.client-ip=23.88.97.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="1PPiqZQ+"; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="TsGD2429" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688367; bh=jShhd6P/W3mf0dYLRwM2NXXvZDo9conzYgts+79W70E=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=1PPiqZQ+wyO+/Dk2jtghBj/O42FvhD8Y/pINwSLqe4ZTKJJTGOeAWc1G/yoYl6ZJf uu2RPEIuVwHH4gebXALh7n6wFHXTTYyFeXScnFF6PpE9G1VadjIYifi6P9LKAVtupq QDgjwZoe+OIzq0t4T/z3LuuTFJ0OXDl2GXjf8O9XAIucgTPy3TB/1R+yhV/96AKu3g W2UpVriI7Iblvve8VUCsaz6HWkF6bR2iZsx/PEQvAwruYfHy0HKCHostYejunpBg9h I2cT0+Fg2wCV9lmP7ZAsgPpvPgjMzf5RWrHpkGi/Q2N3tlulvNt8eBMHMd550krcX8 oKYtM3r7WjE6Q== Received: by bkemail.birger-koblitz.de (Postfix, from userid 109) id 33D4649657; Sun, 2 Aug 2026 16:32:47 +0000 (UTC) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688358; bh=jShhd6P/W3mf0dYLRwM2NXXvZDo9conzYgts+79W70E=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=TsGD24292kzZRItsnwdXfX9QrAskkkc/5kgkZuXcYpWCaH95dN33wJs6XttnMDJ4D Q6RLqHnUF9xDdQCPPKTyF/oUGvBTPsbnxhDMuB1S6SO56UnJu+ln0yXY7AxiLVV9B0 XpGGP96LK386bbeNUzHiBm/okMCVhXQArlK3lvBSTZyHGmiMjcPxGBDppC1k31CIXL oogiXNujg5QkueUItaurrMfarX3/qX9IGNIFNbRxJ3t4zNEH9kWtLJ1XqTu+LL3YS7 MGU6zbkFL2BjH1a9/S3fm4AWpPB+iNTgnFTV+gNRCz60wTM2sj8YyVo5Tejn8xHIVJ QUUglVMb9v7Dw== Received: from ThinkPadAMD.lan (90-227-251-202-no2480.tbcn.telia.com [90.227.251.202]) by bkemail.birger-koblitz.de (Postfix) with ESMTPSA id AE7FD4964E; Sun, 2 Aug 2026 16:32:37 +0000 (UTC) From: Birger Koblitz Date: Sun, 02 Aug 2026 18:32:10 +0200 Subject: [PATCH net-next v5 12/13] ax88179_178a: Add support for AX88179A/772D/279 EEPROM access Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-ax88179a-v5-12-dcb9fea4acd4@birger-koblitz.de> References: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> In-Reply-To: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Andrew Lunn , Heiner Kallweit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Birger Koblitz , Jianhui Xu X-Mailer: b4 0.14.2 The AX88179A/772D devices have 32 efuses with 20 bytes each, which can be randomly programmed. The AX88279 has 16K FLASH. Provide ethtool read capability for these devices. However, no write access is provided. Signed-off-by: Birger Koblitz Reviewed-by: Andrew Lunn Tested-by: Jianhui Xu --- drivers/net/usb/ax88179_178a.c | 19 +++++++++++++++ drivers/net/usb/ax88179_lib.c | 54 ++++++++++++++++++++++++++++++++------= ---- 2 files changed, 61 insertions(+), 12 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 6d6ee39b342e9b4e008bb2c1ee276dc27279a2f7..be72ed955b6b8b1700d5f3624c5= 9d7dea1b3d1dd 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -687,6 +687,19 @@ static int ax88179_bind(struct usbnet *dev, struct usb= _interface *intf) ax179_data->resume =3D ax88179_resume; ax179_data->suspend =3D ax88179_suspend; =20 + ret =3D ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_CHIP_STATUS, + 1, 1, &ax179_data->chip_version); + if (ret < 0) + goto err_nodev; + + ax179_data->chip_version =3D (ax179_data->chip_version & 0xf0) >> 4; + ax179_data->is_ax88772d =3D 0; + ax179_data->ip_align =3D 1; + ax179_data->eeprom_read_cmd =3D AX_ACCESS_EEPROM; + ax179_data->eeprom_write_cmd =3D AX_ACCESS_EEPROM; + ax179_data->eeprom_block =3D 2; + ax179_data->eeprom_wen =3D 0; + dev->net->netdev_ops =3D &ax88179_netdev_ops; dev->net->ethtool_ops =3D &ax88179_ethtool_ops; dev->net->needed_headroom =3D 8; @@ -711,6 +724,12 @@ static int ax88179_bind(struct usbnet *dev, struct usb= _interface *intf) ax88179_reset(dev); =20 return 0; + +err_nodev: + kfree(ax179_data); + ax179_data =3D NULL; + + return ret; } =20 static void ax88179_unbind(struct usbnet *dev, struct usb_interface *intf) diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c index 8aa5489d4bbc46faa1545cdfb85f65d8035c0c3c..22209640734c884a0c83d76ad72= e4364dd29c653 100644 --- a/drivers/net/usb/ax88179_lib.c +++ b/drivers/net/usb/ax88179_lib.c @@ -203,36 +203,61 @@ int ax88179_set_wol(struct net_device *net, struct et= htool_wolinfo *wolinfo) return 0; } =20 +static void +ax88179_eeprom_access_params(struct ax88179_data *ax179_data, int i, u16 *= value, u16 *idx) +{ + /* AX88179 has a word-addressable EEPROM + * AX88179A uses EFUSES with 20 bytes length + * AX88279 has an EEPROM addressable in 256 byte blocks + */ + if (ax179_data->chip_version < AX_VERSION_AX88179A) { + *value =3D i; + *idx =3D 1; + } else if (ax179_data->chip_version >=3D AX_VERSION_AX88279) { + *value =3D (i * ax179_data->eeprom_block) >> 16; + *idx =3D (i * ax179_data->eeprom_block) & 0xffff; + } else { + *value =3D i << 4; + *idx =3D 0; + } +} + int ax88179_get_eeprom(struct net_device *net, struct ethtool_eeprom *eepr= om, u8 *data) { struct usbnet *dev =3D netdev_priv(net); - u16 *eeprom_buff; - int first_word, last_word; - int i, ret; + struct ax88179_data *ax179_data; + int first, last, i, ret; + u8 *eeprom_buff; + + ax179_data =3D dev->driver_priv; =20 if (eeprom->len =3D=3D 0) return -EINVAL; =20 eeprom->magic =3D AX88179_EEPROM_MAGIC; =20 - first_word =3D eeprom->offset >> 1; - last_word =3D (eeprom->offset + eeprom->len - 1) >> 1; - eeprom_buff =3D kmalloc_array(last_word - first_word + 1, sizeof(u16), - GFP_KERNEL); + first =3D eeprom->offset / ax179_data->eeprom_block; + last =3D (eeprom->offset + eeprom->len - 1) / ax179_data->eeprom_block; + + eeprom_buff =3D kzalloc((last - first + 1) * ax179_data->eeprom_block, GF= P_KERNEL); if (!eeprom_buff) return -ENOMEM; =20 - /* ax88179/178A returns 2 bytes from eeprom on read */ - for (i =3D first_word; i <=3D last_word; i++) { - ret =3D __ax88179_read_cmd(dev, AX_ACCESS_EEPROM, i, 1, 2, - &eeprom_buff[i - first_word]); + for (i =3D first; i <=3D last; i++) { + u16 value, idx; + + ax88179_eeprom_access_params(ax179_data, i, &value, &idx); + ret =3D __ax88179_read_cmd(dev, ax179_data->eeprom_read_cmd, + value, idx, ax179_data->eeprom_block, + eeprom_buff + (i - first) * ax179_data->eeprom_block); + if (ret < 0) { kfree(eeprom_buff); return -EIO; } } =20 - memcpy(data, (u8 *)eeprom_buff + (eeprom->offset & 1), eeprom->len); + memcpy(data, eeprom_buff + eeprom->offset % ax179_data->eeprom_block, eep= rom->len); kfree(eeprom_buff); return 0; } @@ -240,12 +265,17 @@ int ax88179_get_eeprom(struct net_device *net, struct= ethtool_eeprom *eeprom, u8 int ax88179_set_eeprom(struct net_device *net, struct ethtool_eeprom *eepr= om, u8 *data) { struct usbnet *dev =3D netdev_priv(net); + struct ax88179_data *ax179_data; u16 *eeprom_buff; int first_word; int last_word; int ret; int i; =20 + ax179_data =3D dev->driver_priv; + if (ax179_data->chip_version >=3D AX_VERSION_AX88179A) + return -EOPNOTSUPP; + netdev_dbg(net, "write EEPROM len %d, offset %d, magic 0x%x\n", eeprom->len, eeprom->offset, eeprom->magic); =20 --=20 2.47.3 From nobody Fri Oct 2 10:08:42 2026 Received: from bkemail.birger-koblitz.de (bkemail.birger-koblitz.de [23.88.97.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D61333CC9F6; Sun, 2 Aug 2026 16:32:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.97.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688372; cv=none; b=U+Spsioh9rDBiCEVs7vJUsgggdXVrHe9vdHed+SQ09E8koiGEsm9YuPRzoyH4oO0IMT6WEHL4u+L9au2edmOmde32MsGXPW9WCYnDBtjqwK2V87fdYxxucEJ+lwNYu1Q0IesqaU0fcU5kXQyV1FjXZs6gxOUylhS4/hZcnhM1yg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785688372; c=relaxed/simple; bh=Tkj/io/sw62VVraxYJvI/E6x7ZRyxrP06AReHxBB32o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SO8Y5rVeyoHc2gmB27VONpoYwcqO5qXORFBmxRezLGtWLq/2H3Xmprk1sQ/1zgUf0SZ+so7BCPgDBxo0FCH4mGkL/owz/R4W6xQRN5Qs8KZmUFMfgpgyGasbCPwfVO/v/nBmLoND84dLN2R0nR4rUn6fT44lTxKLONhNYwbo+fw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de; spf=pass smtp.mailfrom=birger-koblitz.de; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=VWZbwbQv; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=WcVprQGY; arc=none smtp.client-ip=23.88.97.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="VWZbwbQv"; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="WcVprQGY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688368; bh=Tkj/io/sw62VVraxYJvI/E6x7ZRyxrP06AReHxBB32o=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=VWZbwbQvWUUtqNVi7sqYE/7SngQpNJoHQ5l4CcYNqvNtbaB05yHyleqTacZQ3Nvla 09aKQW5qeUpGGHXiqypBa7k59C1AOS4cNuKWpFLO1yYBhVJzqLVF8fMVdT/3HOzQBW ajtGW1+dq4+bCFj33mjmOnSrUM+Xp4b86mPqqSH0gU0NOQf1A9WhXD42SGBHDj58ky H2X/NNn1cqX8I0nMxDxin8Yys27oghviC3yN50IC8QIqZSVt9SD1CwSc7M98yAH6Ep oJXu3rJzwnMYqvLA5J2DExbLfeJYt3ZqZDpi2SwjiZjrkq2DGssLBSsA4pkFGNZBnl 8yaHzATYyN0aA== Received: by bkemail.birger-koblitz.de (Postfix, from userid 109) id 4A5AD49652; Sun, 2 Aug 2026 16:32:48 +0000 (UTC) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1785688358; bh=Tkj/io/sw62VVraxYJvI/E6x7ZRyxrP06AReHxBB32o=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=WcVprQGYMJgZMufCQ7WEcgzUIJhmkN55omPk8mTCrcjxVMYl43+6X0BSSIKXZtVcH stlkpl9PynXZc/Z0RkPiRRTbiAizqSqHgqowF3yycwfuXTOHCqlvryNxISMPCgitwP SaNwCZWL9TVewnmyl3XV/hLsyIgEfhGlfl99Ldxdi0ZcmgKQURuskOTn0WTcguN5fO VYvd3M1IxfxLJiGHPFksufWSXRwystIBqegTdRWL8oQKlLpFHJXTPBjhmZ3gir2wpp BS1xFN06lNitMYSK54ihhH1ecNjQfoFGAe2iiTf03FJaQEm39yuSlGrCA+J9L0QV/8 zEKAS4VMkLYxQ== Received: from ThinkPadAMD.lan (90-227-251-202-no2480.tbcn.telia.com [90.227.251.202]) by bkemail.birger-koblitz.de (Postfix) with ESMTPSA id 4332849649; Sun, 2 Aug 2026 16:32:38 +0000 (UTC) From: Birger Koblitz Date: Sun, 02 Aug 2026 18:32:11 +0200 Subject: [PATCH net-next v5 13/13] ax88796b: Add support for AX88772D, AX88179A and AX88279 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260802-ax88179a-v5-13-dcb9fea4acd4@birger-koblitz.de> References: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> In-Reply-To: <20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Andrew Lunn , Heiner Kallweit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Birger Koblitz , Jianhui Xu X-Mailer: b4 0.14.2 The AX88772D, AX88179A and AX88279 are 100MBit, 1GBit and respectively 2.5 GBit PHYs that are found in ASIX USB-Ethernet controllers of the same name. Signed-off-by: Birger Koblitz Tested-by: Jianhui Xu --- drivers/net/phy/ax88796b.c | 188 +++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 188 insertions(+) diff --git a/drivers/net/phy/ax88796b.c b/drivers/net/phy/ax88796b.c index f20ddf64914993f7097070d1f56c1103ec1e40e8..04788f3e247cbf86a291f373f89= 5beec496d85cf 100644 --- a/drivers/net/phy/ax88796b.c +++ b/drivers/net/phy/ax88796b.c @@ -13,6 +13,19 @@ #define PHY_ID_ASIX_AX88772A 0x003b1861 #define PHY_ID_ASIX_AX88772C 0x003b1881 #define PHY_ID_ASIX_AX88796B 0x003b1841 +#define PHY_ID_ASIX_AX88772D 0x003b772d +#define PHY_ID_ASIX_AX88179A 0x003b179a +#define PHY_ID_ASIX_AX88279 0x003b2790 + +#define AX_ADVERTISE_2500 0x1000 + +/* MII Vendor registers */ +#define AX_CTRL_STATUS 0x1d +#define AX_CTRL_STATUS_SPEED_MASK 0x0c +#define AX_CTRL_STATUS_SPEED_10 0x0 +#define AX_CTRL_STATUS_SPEED_100 0x4 +#define AX_CTRL_STATUS_SPEED_1000 0x8 +#define AX_CTRL_STATUS_SPEED_2500 0xc =20 MODULE_DESCRIPTION("Asix PHY driver"); MODULE_AUTHOR("Michael Schmitz "); @@ -83,6 +96,131 @@ static int asix_ax88772a_read_status(struct phy_device = *phydev) return 0; } =20 +static int asix_ax88279_read_status(struct phy_device *phydev) +{ + int ret, val; + + ret =3D genphy_update_link(phydev); + if (ret) + return ret; + + phydev->master_slave_get =3D MASTER_SLAVE_CFG_UNSUPPORTED; + phydev->master_slave_state =3D MASTER_SLAVE_STATE_UNSUPPORTED; + phydev->speed =3D SPEED_UNKNOWN; + phydev->duplex =3D DUPLEX_UNKNOWN; + phydev->pause =3D 0; + phydev->asym_pause =3D 0; + phydev->rate_matching =3D RATE_MATCH_PAUSE; + + if (!phydev->link) + return 0; + + ret =3D genphy_read_master_slave(phydev); + if (ret < 0) + return ret; + + ret =3D genphy_read_lpa(phydev); + if (ret < 0) + return ret; + + val =3D phy_read(phydev, MII_ADVERTISE); + if (val < 0) + return val; + + /* Read actual speed from vendor register */ + val =3D phy_read(phydev, AX_CTRL_STATUS); + switch (val & AX_CTRL_STATUS_SPEED_MASK) { + case AX_CTRL_STATUS_SPEED_2500: + phydev->speed =3D SPEED_2500; + break; + case AX_CTRL_STATUS_SPEED_1000: + phydev->speed =3D SPEED_1000; + break; + case AX_CTRL_STATUS_SPEED_100: + phydev->speed =3D SPEED_100; + break; + case AX_CTRL_STATUS_SPEED_10: + phydev->speed =3D SPEED_10; + } + + /* MDIO_AN_10GBT_STAT_LP2_5G is broken, but we can deduce that + * the link-partner advertised 2500M if remotely AN succceded + * for link speed > 1000M and we locally have a link speed of + * 2500M + */ + val =3D phy_read_mmd(phydev, MDIO_MMD_AN, MDIO_AN_10GBT_STAT); + if (val >=3D 0 && val & MDIO_AN_10GBT_STAT_REMOK) { + linkmode_mod_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, + phydev->lp_advertising, + phydev->speed =3D=3D SPEED_2500); + } + /* Only supports full duplex */ + phydev->duplex =3D DUPLEX_FULL; + + return 0; +} + +static int asix_ax88279_config_aneg(struct phy_device *phydev) +{ + bool adv_2500; + int ret; + + if (phydev->autoneg =3D=3D AUTONEG_DISABLE) { + phydev_warn(phydev, "Disabling autoneg is not supported\n"); + return -EINVAL; + } + + ret =3D genphy_config_aneg(phydev); + + if (ret < 0) + return ret; + + adv_2500 =3D linkmode_test_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, phyd= ev->advertising); + ret =3D phy_modify(phydev, MII_ADVERTISE, AX_ADVERTISE_2500, + adv_2500 ? AX_ADVERTISE_2500 : 0); + + return ret; +} + +static int asix_ax88279_get_features(struct phy_device *phydev) +{ + int ret; + + /* MDIO_DEVS1/2 empty, so set mmds_present bits to allow reading abilitie= s */ + phydev->c45_ids.mmds_present |=3D MDIO_DEVS_PMAPMD | MDIO_DEVS_AN; + + linkmode_set_bit_array(phy_basic_ports_array, ARRAY_SIZE(phy_basic_ports_= array), + phydev->supported); + + ret =3D genphy_c45_pma_read_abilities(phydev); + if (ret < 0) + return ret; + + /* AX88279 does not support reported 100baseT-half duplex mode */ + linkmode_clear_bit(ETHTOOL_LINK_MODE_100baseT_Half_BIT, phydev->supported= ); + + return 0; +} + +/* AX88179A-based PHYs cannot access MMD registers via MII_MMD_CTRL/MII_MM= D_DATA + * Make sure to use c45 access instead. + */ +static int asix_read_mmd(struct phy_device *phydev, int devnum, u16 reg) +{ + struct mii_bus *bus =3D phydev->mdio.bus; + int addr =3D phydev->mdio.addr; + + return __mdiobus_c45_read(bus, addr, devnum, reg); +} + +static int asix_write_mmd(struct phy_device *phydev, int devnum, u16 reg, = u16 val) +{ + struct mii_bus *bus =3D phydev->mdio.bus; + int addr =3D phydev->mdio.addr; + + return __mdiobus_c45_write(bus, addr, devnum, reg, val); +} + static void asix_ax88772a_link_change_notify(struct phy_device *phydev) { /* Reset PHY, otherwise MII_LPA will provide outdated information. @@ -94,6 +232,25 @@ static void asix_ax88772a_link_change_notify(struct phy= _device *phydev) } } =20 +static int asix_ax88772D_get_features(struct phy_device *phydev) +{ + int ret; + __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) =3D {}; + + /* MDIO_DEVS1/2 empty, so set mmds_present bits to allow reading abilitie= s */ + phydev->c45_ids.mmds_present |=3D MDIO_DEVS_PMAPMD | MDIO_DEVS_AN; + + ret =3D genphy_read_abilities(phydev); + if (ret < 0) + return ret; + + /* AX88772D does not support reported 1000baseT mode */ + linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, mask); + linkmode_andnot(phydev->supported, phydev->supported, mask); + + return 0; +} + static struct phy_driver asix_driver[] =3D { { PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88772A), @@ -111,6 +268,34 @@ static struct phy_driver asix_driver[] =3D { .suspend =3D genphy_suspend, .resume =3D genphy_resume, .soft_reset =3D asix_soft_reset, +}, { + PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88772D), + .name =3D "Asix Electronics AX88772D", + .flags =3D PHY_IS_INTERNAL, + .get_features =3D asix_ax88772D_get_features, + .read_mmd =3D asix_read_mmd, + .write_mmd =3D asix_write_mmd, + .suspend =3D genphy_suspend, + .resume =3D genphy_resume, +}, { + PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88179A), + .name =3D "Asix Electronics AX88179A", + .flags =3D PHY_IS_INTERNAL, + .suspend =3D genphy_suspend, + .resume =3D genphy_resume, + .read_mmd =3D asix_read_mmd, + .write_mmd =3D asix_write_mmd, +}, { + PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88279), + .name =3D "Asix Electronics AX88279", + .flags =3D PHY_IS_INTERNAL, + .get_features =3D asix_ax88279_get_features, + .read_status =3D asix_ax88279_read_status, + .config_aneg =3D asix_ax88279_config_aneg, + .read_mmd =3D asix_read_mmd, + .write_mmd =3D asix_write_mmd, + .suspend =3D genphy_suspend, + .resume =3D genphy_resume, }, { PHY_ID_MATCH_MODEL(PHY_ID_ASIX_AX88796B), .name =3D "Asix Electronics AX88796B", @@ -124,6 +309,9 @@ static const struct mdio_device_id __maybe_unused asix_= tbl[] =3D { { PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88772A) }, { PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88772C) }, { PHY_ID_MATCH_MODEL(PHY_ID_ASIX_AX88796B) }, + { PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88772D) }, + { PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88179A) }, + { PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88279) }, { } }; =20 --=20 2.47.3