From nobody Fri Oct 2 11:43:49 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 193AA2E1F06 for ; Sat, 1 Aug 2026 11:49:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785584962; cv=none; b=BPccMVJcPOpjQG6aDVybGC7Ekb1mtUlxq/Gsd4Nrr8y5URYbEFIMUUwLH7xGnq5Rt4NRTqpFC5WlTt3XPvM2VPfTv2ghkUkaRijtOOBXQvZbUB7pnNgPxwp6/lhKxtyhzjctJVH16h+iFdW69vwFliBD05b8rp3TL8kOnzlU2jY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785584962; c=relaxed/simple; bh=4yyAcVknUicAHnNFBh0eMnF/hJea/MMAc1JgVYj7fY8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=utqnjleCagDIAWOAAH1n/we6NbLOVDv4RuG+MCdzP2BEYa7n2zW7Rmk7oW+dTDTaUALRe+eGdPdeAOZGi3K8dibGGNqoIRf9cvxJup/n8Y5MFdn75t6MbtbgeMXY3qdVAeFVtZtMysg8lgecOr/bFZRQ529DfUDLbK8hPVsatdE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=TRhifgad; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="TRhifgad" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ce98cb8165so19739355ad.1 for ; Sat, 01 Aug 2026 04:49:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1785584960; x=1786189760; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Y/htim8H+8x9oNbHl26vDUAIesN+LBlNBvkdejEDGrc=; b=TRhifgadxAPmJ8/U0T62YS0UNymQDKERmTM6pNtHE//EmZ1tJ14HN23Q66I1ZIRlZg q+RD1DyKETOEEsNm9nQrRhCW36JXB9Egl65uJo1e0FzzXl5gAE3aLjgduWk/itkNe4py xFa9ac3gz9JilSRxQ3vmk8+s689CWVwiL/dN2e2CZCuitH19daimUhsqItQIsMObjQvc Sq8+4UteJ7R8Q261nRkBX8f/Kf2SWpH0ryxLrPrVMcUYxtvnlX76xAyqBUwAVwvBFqa6 BcUOR6zZmgGSwDE88gse0jPwfzD/ih/nzG/sYDIIn9MKN0oCZviiSCRR6EtU0MGCgXGh 8/jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785584960; x=1786189760; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Y/htim8H+8x9oNbHl26vDUAIesN+LBlNBvkdejEDGrc=; b=aXvxyPBeg0mRMSRF3C3D7fKhGknUKdkxU6XNrXcF0shbBtB+Yy63Tfv5wJX+OE1P6g XDJylL3NUfLkBYECNvyTYVHMl5xGWjzhNrOEzxO7LXt0GnGu15UVZYKW0gZLRRjGk7Hd koBBlKJgq8KM6BdAfAg7mGTg4Q+1Jt3yrrP2ZFrK79gkCc6SKmco3iZL1N3NufIbCE4j bQayHAzfEhgQvwH907maFH1V7RQjnxdqCkHrebuNXsZ/qSg5YaUSwxP2BU1utvdSHb7F RJGs/vc3JTR7VSSE9S8mIDtuQkvXFrIGn39Ogf013jjexHvt5t9+nXsudVfdHXxUvPqJ yDSA== X-Forwarded-Encrypted: i=1; AHgh+RrDWP4ZejL2cVhRyQ3fhH4krP62hYl6rxLDNa4otH4f/zxEPyiTSOP7Lq68nRB7n/mmS5C5dEcfZ4RK/Ho=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5PnMlV0MYWdLCbRS5wtPjPpNoLPCPWUgAJfwJrTXW6fRBiRo1 r81Quhvi//MPLrvXJPH2fowk4sWTkgdYtpBSGJInJ3zakOh+qjLezm/FPHPR9UrDopJziJpvPhW oB8pqdzPrJw== X-Gm-Gg: AR+sD10wjx7D5nKccyoUR8pGV7LoYmLcQ+Bzhq0DZzwFZd+JkoEOnu/hSp+qQpWQaIt ak2MpKl77p1cICM1d2VAKzFqTi3JuVpgBC2fkVvhgf/4wXSscZEpzBb50WB5YWnO2YJL36axyRl LxZ6wx9gxfw3aqxMStrReiBlZ1Kdzq/YII4k1DCyQ8DMoNvoCM2ZWJMT54nvMmOVvxZbmBYcjjV aRx4vGULnotBt8vpezqQMQHMg7fV4ySHAWp3JnmTGZsi+JNbfU0PRPbBo6bMdRgL8JStmH5KQcX YPmObReMkb0tabwXb5XU6NBNGgkvaOQ7voOF8QHMlmai6OIXDIihydvexS0zeMjkQRWX5te8SUz IqJROxyaEvJqRNi3VWDXrsxcst3OtQSyvo3LDvblwKuxMug5u64MZQXN5wDLNLYP+deJfZLHD6g D9mVspbnPFfGmChYBmadrnoDx89A6rdBQSQEwHH32Os5NGKar7y1KG+Kt4fkL0cX1AY4cuYyF+D CxSz05EumzoKHHKJ61Emo6bNB71rRRaBkz+DH8g7ziBBpeIokwYhoi4ESDt3dgDF032T9+aOM4Z RShCl4b33lYDj2U= X-Received: by 2002:a17:903:350f:b0:2cf:461a:3863 with SMTP id d9443c01a7336-2d047e6fe24mr51267725ad.22.1785584960370; Sat, 01 Aug 2026 04:49:20 -0700 (PDT) Received: from Metius.iitm.ac.in ([103.158.43.43]) by smtp.googlemail.com with ESMTPSA id 5a478bee46e88-3153e06f8dbsm16967624eec.22.2026.08.01.04.49.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 04:49:19 -0700 (PDT) From: Abdun Nihaal To: jjohnson@kernel.org Cc: Abdun Nihaal , nathan@kernel.org, ndesaulniers@google.com, morbo@google.com, justinstitt@google.com, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, baochen.qiang@oss.qualcomm.com, stable@vger.kernel.org Subject: [PATCH v2] wifi: ath11k: Fix possible memory leak in ath11k_dp_srng_setup() Date: Sat, 1 Aug 2026 17:19:09 +0530 Message-ID: <20260801114911.91483-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In ath11k_dp_srng_setup(), the memory allocated for ring->vaddr_unaligned is not freed in the error paths that follow. Fix that by calling ath11k_dp_srng_cleanup() in those error paths. Compile tested only. Issue found using a prototype static analysis tool built on the LLVM compiler infrastructure. Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-sonnet-4-6 Reviewed-by: Baochen Qiang Signed-off-by: Abdun Nihaal Reviewed-by: Rameshkumar Sundaram --- v1->v2: - Moved the information about compile testing, and how the issue was detected to the commit message, as suggested by Baochen Qiang. - Add the release function in the switch default case as well, as pointed out by Jeff Johnson. Also add Assisted-by tag. v1 link: https://patchwork.kernel.org/project/linux-wireless/patch/20260727= 105532.118164-1-nihaal@cse.iitm.ac.in/ drivers/net/wireless/ath/ath11k/dp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath11k/dp.c b/drivers/net/wireless/at= h/ath11k/dp.c index f389b97acbdd..be65d73b904b 100644 --- a/drivers/net/wireless/ath/ath11k/dp.c +++ b/drivers/net/wireless/ath/ath11k/dp.c @@ -313,6 +313,7 @@ int ath11k_dp_srng_setup(struct ath11k_base *ab, struct= dp_srng *ring, case HAL_RXDMA_DIR_BUF: break; default: + ath11k_dp_srng_cleanup(ab, ring); ath11k_warn(ab, "Not a valid ring type in dp :%d\n", type); return -EINVAL; } @@ -324,6 +325,7 @@ int ath11k_dp_srng_setup(struct ath11k_base *ab, struct= dp_srng *ring, =20 ret =3D ath11k_hal_srng_setup(ab, type, ring_num, mac_id, ¶ms); if (ret < 0) { + ath11k_dp_srng_cleanup(ab, ring); ath11k_warn(ab, "failed to setup srng: %d ring_id %d\n", ret, ring_num); return ret; --=20 2.43.0