From nobody Fri Oct 2 12:19:54 2026 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21E44255E43 for ; Sat, 1 Aug 2026 09:10:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785575433; cv=none; b=MnrAa2gg5Em6aP8yKe5GId6ZupuRTUm74kDq2fX5R8W9G/aKw3zNSRJNrvYb1DX4Ww9v0z8HlBnAZk4iOLH3U7+ngeM577yG9CyfVeYgHxcMO4b+3hPYyhQVe1Ah49jCodtJb2ibzDqtYY4yKlTOL0J5nHeBoK/iIXxSHG40Hkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785575433; c=relaxed/simple; bh=5C7wceqaQFO2f4qXEFx21ohpcplYEZ+eV+kQkbGuCaY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lPxajYp9dCUXO2uLDQpHnExORLjTLQN7eBmay6mNmybu+2Nbzjf46dUJKDlvZKhAnKxCblnpZ8OpnUXdRSUW9SrEBRj0+EN1vBHEzm3pXFSvybHnKeUlC3ZgJR2/Vf8/et+Jz1BRfAMmjDOCZKOCalkz7N49S9d/vzKaJ8ENLBM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C1N6Znfe; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C1N6Znfe" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c96c92c0980so1037636a12.3 for ; Sat, 01 Aug 2026 02:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785575430; x=1786180230; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+19O7nuCCtomwWmgwH/WqZ+QVpHVmBP+p+odMSd16YE=; b=C1N6ZnfetAIrX5h3uPn7KmNzP2Gq0EPz8Y3Mv1unnNC1XywqmkyNiL2uUi+V68X4qQ deZ1+mqD4B3EdJKEGNKDDIakuJxsJxQ9e8sHbhObsrv2jj7e1WI+amrHDPi14IBWBDX3 S/3dP4qSBiM6ag7T60BCHtIePHw21ar0ssbM21n0es4d8JYTfeafLegkSEgDrbJaVo6q e4JsKrpvwBLrI7KlI58CzGBUUYiOsHuTWxxtK8MuNiiPOY2p3uOrORq7LNLE7e9R2yct pXueVk2+AkrBkxAzSJUpbY0adLr7t42uXbHCD/jFo4KnqiDjsdk85csL6Shagqet6Kr8 vjPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785575430; x=1786180230; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+19O7nuCCtomwWmgwH/WqZ+QVpHVmBP+p+odMSd16YE=; b=nmAml6DwYkIDoyhZMA8BGHmYw+/GATIcSzzZWUIioE6D+EmhRrFl9RF62zCBjZANCx AQoIKM4zRrOLsbVScvp+8VXXeXdgTtkAC4ZiTflv82jN2h6xCii6r2aWcNo60Z5tJYir Rte66PsqTpz+jnAJWD6Emm7SYgA9yOiETF4x6i62apTNK520vEhzstj2y2/hfj8oIqSj HEFakVNjPfYFTlcMWApTXwF9Mlwv+uz0zsnLfLu3KOQpaN70orW7ZGPYxHXlGuGfm/HO 2fq9EvqItSxAZNcBFe+Df58hfYX+96yvmlx3TDgVevx426ZXhZ05W8/ZMczdBq/4F2Mp rIDQ== X-Forwarded-Encrypted: i=1; AHgh+Rrl9gqajiOVQjuDwqkxRS7KmKkHGP3+oKThFzDXGqLrV6eHi4M+kFXDbEeKkF1TLtUdK1TyfVftIgaAiLY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0aLNEC23FEa1JyOPuMGrQUe8/ee/sWKdQD3AgWYb4jp3HWnzH bp0s/Lu3mXe1JLxc47kJGDONzkp75AcLwHLMhMvJN4UNYR/h66Mef0KN X-Gm-Gg: AR+sD10ugmZFW+cbi5E+vA0N0FsZqWh2mrinT8jHh2fHaJaJUKWm+kIxiVzThZoGlqt njKf8XNxqAczmT+0IQQ9OHbT7XVKYEETDVCwLu7WtEHY2oA+Sq3mr+KnX5W61J0d/aVL3b422JK 3GnqoTc7eXMt2p2E1GlGAn2Jd0CiDLiavv5tOzwG9bcpTSDtgv8N2nF5syeVYhr1R6BdatnAyp5 QxMCyokoAZAHhxAIegiSG9QGXF+9JHgh2ekqdurtpfdBZaA3p6wsAd+X8xsEKkxRKWxZ0EJjueO LDnvFv+LpVWJF8ikXTXx8UBzg12QbegB1lG2Ym4Qtt4E6YoSgxhutq1U3Z5rKHc+iTEHcr0bdD2 0+3T9SjYtB5k1E+NTUzsOkXJZ174orOCdP91y4DgzE7aEXyIlirfOgKuY4RwexTbPsG0p8t6o/V cbKCFM73TJwLeklztAlJpIqmWbzEBgKACW0i8qw8dGyY4cTmR7vGRtOFZZbg== X-Received: by 2002:a05:6a21:d88:b0:3c3:6544:5eb2 with SMTP id adf61e73a8af0-3c92aa5d51emr3029824637.55.1785575430377; Sat, 01 Aug 2026 02:10:30 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:36ae:7de2:5cca:938]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm15432431eec.7.2026.08.01.02.10.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 02:10:29 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron , Andy Shevchenko Cc: Joshua Crofts , Broadcom internal kernel list , David Lechner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Mohammad Shahid Subject: [PATCH v4 1/3] iio: adc: bcm_iproc_adc: Remove redundant probe error messages Date: Sat, 1 Aug 2026 14:39:51 +0530 Message-ID: <20260801090953.61603-2-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260801090953.61603-1-mdshahid03@gmail.com> References: <20260801090953.61603-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid devm_request_threaded_irq() already logs an error when the request fails, making the explicit dev_err() redundant. Similarly, iproc_adc_enable() already reports failures, making the additional dev_err() in the probe path redundant. Remove both duplicate messages. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index cf4738b16e62..7c2e2770cd61 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -551,10 +551,8 @@ static int iproc_adc_probe(struct platform_device *pde= v) iproc_adc_interrupt_handler, iproc_adc_interrupt_thread, IRQF_SHARED, "iproc-adc", indio_dev); - if (ret) { - dev_err(&pdev->dev, "request_irq error %d\n", ret); + if (ret) return ret; - } =20 ret =3D clk_prepare_enable(adc_priv->adc_clk); if (ret) { @@ -564,10 +562,8 @@ static int iproc_adc_probe(struct platform_device *pde= v) } =20 ret =3D iproc_adc_enable(indio_dev); - if (ret) { - dev_err(&pdev->dev, "failed to enable adc %d\n", ret); + if (ret) goto err_adc_enable; - } =20 indio_dev->name =3D "iproc-static-adc"; indio_dev->info =3D &iproc_adc_iio_info; --=20 2.43.0 From nobody Fri Oct 2 12:19:54 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B451361979 for ; Sat, 1 Aug 2026 09:10:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785575441; cv=none; b=OLCivs3OPrVN+2e0LkI6ZnZvov4Fo/YTC0rTxILX9KZnZRTV56jo4snKU49RHY+x9ULodND/8dHufpYLI4322olHRo7iw9FGCFxq+qEXlnqWHn2wjVO3I2s4v9KtAT+8Fe+XtTH0mFl15OK1X7mWRlY/AdMRjvCYDGNYG+X7CPI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785575441; c=relaxed/simple; bh=mBvzCrJqfjVnlWATRpHn3lgMmeSiDO2rsv8lorvrc+M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G9xNlyMc9QMIo8904pmoAGmVUO5cMP1h4ERgQ6bsTHsd1qCBgt2OSEv8CQIlYuhxe9/Tlt25fFeiAV/19JsX1NJFpIjTF3u/N394F10hEeDkyqvxsuWqQRf7Pb6Co49jAcUPDynPzdBHIU24f9VKjH0Xm4HIoNg5NQzL2QdzVAk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P0IlD/dK; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P0IlD/dK" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-ca80d708489so1084949a12.1 for ; Sat, 01 Aug 2026 02:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785575439; x=1786180239; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4sMBazdEJYTe6pzd45qpWokzuIgSbldBJhe0jeEanG8=; b=P0IlD/dKxh2lhAKurckYAbamScw/wmAZLullJmvdvcb7MNwnjHkPKjzWtib1i/O1gI zZzp6egVFVuthBai63Yw86suRyd2oD//0LxZR1UHc9VBgvF5KAHgYVHw5mFjx7mt3RcU 81XfOQkI03iSjCk4acXSEwIUlqjOQr/HsSllC55HWKZEWb6Wkmmi+C9HXPckcjsIyJQz T6zvqAxXhMwHLOaXBjcYB7MLYi1DugrkP6s3YGAHZfzP/rdnr0OLERfweC20F905nitT VB72sphDEKluD9zpyqYjvzNhHvmOqWFsfqfeaUBlRELH1XnWbmk9s8RAP0O1P6lxSQOg /O+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785575439; x=1786180239; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4sMBazdEJYTe6pzd45qpWokzuIgSbldBJhe0jeEanG8=; b=Lo6mDoX1CQtsGah2SS/Tgeg5NI5R8Nx3OsuDhnq2P6V5F1f/KJj3W2ghDsQmGhsi2V VCI2XulAAyDC+fln3bE4hdhrJpuYgLmU1AcHpfgRI16nuTgXB7B7PLJzVAlrxhbflTsR D0wBFzhXD0CwSRubkkNdWAfx53/a09LmlTjqMXDO/wc7LYYT+oK3T6CpHXti2+5YEgo4 heaJ4ezZAS3WYMyhlDMhyhe6Iyc4eealrQLaTuJ0gTBXPxhudCuEo6oGkQ8XaaDyT6KC UaeQdWqzAqbWSUB0qLubK+hVnvgK4WfY3aMnOwvxHj0trvKiQ3icCZMpkjV66D295URn 5A/w== X-Forwarded-Encrypted: i=1; AHgh+RoZNFsC402LlehoMYUsAPFYZc9LdfMmhWOoIoImRZODEg5ry02T2OE9hBKn0L/+dciPN4BtxoOZsopxKzo=@vger.kernel.org X-Gm-Message-State: AOJu0Ywz2NSccpCz0HVFyREweVVP+Lgx0sy+msQKIIAT2wOuKjL21QCe vCVoJRMhjEMW0WeR5w6KjTbn97TiWiEoyUOjb7rmH3Osdy665n32YSNh X-Gm-Gg: AR+sD13YC2C7s5SyvgASoRkFroVaXcGFubBmrDWlaU05SzmXzXlThExVkjjdKnijZOm 2vghUeMFJnWnA7VXW6P759LrcqUHDuKwzn+NT8LwQ+oBqggpsWWz14OeDwV//HyVuNwhfRG6Cnu RGqm2ae3E3pVBvLiFB+8r2L9XgvRCulY8iFCy2uKuvH1dtrkx+Rk1kadU2IV/fdAnm8XukRAYG9 Y+RvIDRaIXhjg6ckRb2xhJc1P9FFtJD8dsyzqQ6JmexMbPP7DYEgXIdkp2NWSlzeZJmf/bNj6s6 5ypvaIGuTFkIQNIaFYLR1XFwUgfg/72bW6DWfph9bXhZY2dpel0eQ9li1Levuwf99WUZy/cDIr1 Y8CJbTAgdgXizxqq0EprVqmiY4KQza6RfAE9PAixvhVbrVGKhDT52betgSAQ1fUWCbfRc83+3iD H4As4EjZJxKdXg57twdjb6zc9H6Ipj9xVpHnFtS/JyVcck26HU9rckagJS/w== X-Received: by 2002:a05:6a21:e598:b0:3c6:6f25:594 with SMTP id adf61e73a8af0-3c91aa0a4f5mr5101134637.38.1785575439377; Sat, 01 Aug 2026 02:10:39 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:36ae:7de2:5cca:938]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm15432431eec.7.2026.08.01.02.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 02:10:38 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron , Andy Shevchenko Cc: Joshua Crofts , Broadcom internal kernel list , David Lechner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Mohammad Shahid Subject: [PATCH v4 2/3] iio: adc: bcm_iproc_adc: Introduce local device pointer Date: Sat, 1 Aug 2026 14:39:52 +0530 Message-ID: <20260801090953.61603-3-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260801090953.61603-1-mdshahid03@gmail.com> References: <20260801090953.61603-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Introduce a local 'struct device *dev' variable in iproc_adc_probe() and use it instead of repeatedly referencing '&pdev->dev'. This simplifies the code and makes subsequent error handling changes less verbose. No functional change intended. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index 7c2e2770cd61..4acd9c3f089b 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -506,9 +506,10 @@ static int iproc_adc_probe(struct platform_device *pde= v) { struct iproc_adc_priv *adc_priv; struct iio_dev *indio_dev =3D NULL; + struct device *dev =3D &pdev->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&pdev->dev, + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*adc_priv)); if (!indio_dev) return -ENOMEM; @@ -523,14 +524,14 @@ static int iproc_adc_probe(struct platform_device *pd= ev) adc_priv->regmap =3D syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "adc-syscon"); if (IS_ERR(adc_priv->regmap)) { - dev_err(&pdev->dev, "failed to get handle for tsc syscon\n"); + dev_err(dev, "failed to get handle for tsc syscon\n"); ret =3D PTR_ERR(adc_priv->regmap); return ret; } =20 - adc_priv->adc_clk =3D devm_clk_get(&pdev->dev, "tsc_clk"); + adc_priv->adc_clk =3D devm_clk_get(dev, "tsc_clk"); if (IS_ERR(adc_priv->adc_clk)) { - dev_err(&pdev->dev, + dev_err(dev, "failed getting clock tsc_clk\n"); ret =3D PTR_ERR(adc_priv->adc_clk); return ret; @@ -543,11 +544,11 @@ static int iproc_adc_probe(struct platform_device *pd= ev) ret =3D regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2, IPROC_ADC_AUXIN_SCAN_ENA); if (ret) { - dev_err(&pdev->dev, "failed to write IPROC_REGCTL2 %d\n", ret); + dev_err(dev, "failed to write IPROC_REGCTL2 %d\n", ret); return ret; } =20 - ret =3D devm_request_threaded_irq(&pdev->dev, adc_priv->irqno, + ret =3D devm_request_threaded_irq(dev, adc_priv->irqno, iproc_adc_interrupt_handler, iproc_adc_interrupt_thread, IRQF_SHARED, "iproc-adc", indio_dev); @@ -556,7 +557,7 @@ static int iproc_adc_probe(struct platform_device *pdev) =20 ret =3D clk_prepare_enable(adc_priv->adc_clk); if (ret) { - dev_err(&pdev->dev, + dev_err(dev, "clk_prepare_enable failed %d\n", ret); return ret; } @@ -573,7 +574,7 @@ static int iproc_adc_probe(struct platform_device *pdev) =20 ret =3D iio_device_register(indio_dev); if (ret) { - dev_err(&pdev->dev, "iio_device_register failed:err %d\n", ret); + dev_err(dev, "iio_device_register failed:err %d\n", ret); goto err_clk; } =20 --=20 2.43.0 From nobody Fri Oct 2 12:19:54 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68500255E43 for ; Sat, 1 Aug 2026 09:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785575450; cv=none; b=h/u1P+o+5KSlbHkOsmjPgVWmeVYanuXlL6holRcxOuaPYqjpIk5pw1T2Q3fsAgXIecx1qw2o9E62fo1wlOyMX15LTrK2YVnb7mS+LPKvFN2kytCRxu8vmZ0olB8sT6UU5tuNN342QiC9WEALLTpjbu0ZIAVgDe6zNDZ+Cwig4Ac= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785575450; c=relaxed/simple; bh=OvQKuoneFsh/WxICPt1MaBIMs0/iiqu65A4ormy8KeQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i4y/Erk/Ou3LgnUumwkvY/Uyuf0BIUZ7WYnJjSydR1pSr6Km8v0zICMPx1S5S2rh0NffEVvENf9zn/ZZWqJflVqgT1oYuPzx7lVtMK3Xet9gDdoYBJmORzijWdXY+57jkWLR0lmlcsyQp9U+LYtFMTeMz9H+KV0z/FNEwEuhEEc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WdDgUjKk; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WdDgUjKk" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-84862b0d5f8so1625692b3a.3 for ; Sat, 01 Aug 2026 02:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785575449; x=1786180249; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PgxBTc/eAxhpXNXIIpPZ/eJLF5hZIUUNMPVKiLuD+Wo=; b=WdDgUjKkyv4zqYfB0A8uO4zTfw9lz3K6v2WFTHUscNEFZkRnYjRCVP6WVQYywIXmgl +Fyi1ZNDWGI6fI4AT2LHW8RtxvAniT1EbfBdoTv2rGvGW8GX1R22iZp7FcpYGoa/jG2A 7iwcnDWCURh1gnhEFj/dzu3z2GjEE50moPTmljZJ8eV2L9aEnqwmGSbBdMPAneVx1iwB g2xTjWTy4IS6B/PvUQ8qUi9SY6YYFXHUtXe0J62EHksQxR7UEyPFUzUFydL/Y9h+0EHk m2wDzxjAmEHpFnTgROch0+LHocX7FIiWwq/qsT5Xx26L22uE4ya4qR42jGPUelTbFLAE C0fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785575449; x=1786180249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=PgxBTc/eAxhpXNXIIpPZ/eJLF5hZIUUNMPVKiLuD+Wo=; b=soGLp4N4LlGdIGLNaXqGnWzMGMSV0FNl118jxbIZYahTNtO5iHF90ZdcqvfUNKmgT2 YPjBormNXumsrujaWrcvjprs1taef3uXo26GU6T05nHuG7i1lLyfj1Xx27Y1yo4Um7IE pIfJr1Yj1hcB6T6YLW9m+pgXxzLZEQ/5fkAkCZvamNOfaOqXNyr8zb9Kp1d5uSZAlKea rwf6ABM/7XNcgSby0vXW6UWVJctJm+dNlGfIFH8MFvMedQoT3LOZ0hbxzXtR6nlMaYNZ Ux5kVOPEQREO+iIbRZHb4wvcT/hSCxZcbUR4TG9WdrQlWGdRGkSY7eImlTg3BX6AVthW 3eMg== X-Forwarded-Encrypted: i=1; AHgh+Rp8+yS1T5k7G1SpfNOH8fVyyjQ9rVzbo4xtw/Li7vL1E1Mdm67yeU2698mLO+Y6JX/5jJ9Qm7Dj17HaAeU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2PmyLP8Ue+wqYm8G5c1JPgsd4TPQLIwFK1NOgBDqfZmFRxd0Z IPEaSgExCEtfbbqCOvvXWnbQyVqOR4IdTrKOOzaWs1cWlZX8PSQery8A X-Gm-Gg: AR+sD10DerZmCTveD0XDmMYA37o/cp0ne7GUGYbYQ8lL8YwD6btQ/0+m+yjOvZbmRLd EDRxmV5aRrx29rdZD0FniMRRrkK/xNE+Xh06vhKx0tANY+qWBVAbETEIYNOMvaznivQ1y4BPMAx rGSzx58PiCWN2bXg72fuK8vDcZ1tdCR5654fSg56UOa8z25vnhyYEbS3vQokYHyKjdNJ8M53q8m MU4XlUsjIkr/eNW6T/iFnEKrrHA/6wMxA+qYezM01Pn9U2Kq0KLrpEp00cjpuEIT7FYJFLRq3Wi nCcZSDHY+dqjq1rQpeBfndcX1Kqs9tDMYtD4KAxy5LmkUR0CQHaUus5QJqaPY/BLUrP0SLzmLcz AY+8WbvmSD7f6a/6phX7HB0KVxAOpNFjtwVVfZoNcpEsGwq0LhL6x4xlf/p//M2SLJg1btcKEHj BIvwGxslKw1SaBDGhxxsK1F4y86ZHr3jqzklJNMiH4xqAVTJbw7bIAXPHQhg== X-Received: by 2002:a05:6a21:2212:b0:3bf:9b61:f7ae with SMTP id adf61e73a8af0-3c92a75b245mr2888824637.14.1785575448667; Sat, 01 Aug 2026 02:10:48 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:36ae:7de2:5cca:938]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm15432431eec.7.2026.08.01.02.10.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 02:10:48 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron , Andy Shevchenko Cc: Joshua Crofts , Broadcom internal kernel list , David Lechner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Mohammad Shahid Subject: [PATCH v4 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() Date: Sat, 1 Aug 2026 14:39:53 +0530 Message-ID: <20260801090953.61603-4-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260801090953.61603-1-mdshahid03@gmail.com> References: <20260801090953.61603-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid This simplifies the probe error handling by replacing open-coded dev_err() and return sequences while preserving the existing messages. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 39 +++++++++++++++------------------ 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index 4acd9c3f089b..5fcd528eb88a 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -523,19 +523,16 @@ static int iproc_adc_probe(struct platform_device *pd= ev) =20 adc_priv->regmap =3D syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "adc-syscon"); - if (IS_ERR(adc_priv->regmap)) { - dev_err(dev, "failed to get handle for tsc syscon\n"); - ret =3D PTR_ERR(adc_priv->regmap); - return ret; - } + if (IS_ERR(adc_priv->regmap)) + return dev_err_probe(dev, + PTR_ERR(adc_priv->regmap), + "failed to get handle for tsc syscon\n"); =20 adc_priv->adc_clk =3D devm_clk_get(dev, "tsc_clk"); - if (IS_ERR(adc_priv->adc_clk)) { - dev_err(dev, - "failed getting clock tsc_clk\n"); - ret =3D PTR_ERR(adc_priv->adc_clk); - return ret; - } + if (IS_ERR(adc_priv->adc_clk)) + return dev_err_probe(dev, + PTR_ERR(adc_priv->adc_clk), + "failed getting clock tsc_clk\n"); =20 adc_priv->irqno =3D platform_get_irq(pdev, 0); if (adc_priv->irqno < 0) @@ -543,10 +540,10 @@ static int iproc_adc_probe(struct platform_device *pd= ev) =20 ret =3D regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2, IPROC_ADC_AUXIN_SCAN_ENA); - if (ret) { - dev_err(dev, "failed to write IPROC_REGCTL2 %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, + ret, + "failed to write IPROC_REGCTL2\n"); =20 ret =3D devm_request_threaded_irq(dev, adc_priv->irqno, iproc_adc_interrupt_handler, @@ -556,11 +553,10 @@ static int iproc_adc_probe(struct platform_device *pd= ev) return ret; =20 ret =3D clk_prepare_enable(adc_priv->adc_clk); - if (ret) { - dev_err(dev, - "clk_prepare_enable failed %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, + ret, + "failed to enable clock\n"); =20 ret =3D iproc_adc_enable(indio_dev); if (ret) @@ -574,7 +570,8 @@ static int iproc_adc_probe(struct platform_device *pdev) =20 ret =3D iio_device_register(indio_dev); if (ret) { - dev_err(dev, "iio_device_register failed:err %d\n", ret); + dev_err_probe(dev, ret, + "failed to register IIO device\n"); goto err_clk; } =20 --=20 2.43.0