From nobody Fri Oct 2 11:43:35 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1AB7352C51 for ; Sat, 1 Aug 2026 05:55:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785563739; cv=none; b=GDSasabrmHeQSVNcJK9Bv2LAkrbbRtBXRN9c4Y3SZI6N/YIFvstnf180eP7bg4EPyAF2m41rzduT0HsTk0+bOW2Ak2czrR04S96BmO5MFPmg2KTdmUNcp1HRpDengG3zx0Evia8XGbZWCmsqEvu6iDn1jgZjRNPEnZLnWoyjo+8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785563739; c=relaxed/simple; bh=ZHdedNPcudEcVol+83qSYMha4eWY9xZ3jg45Y9HOidY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CBGY9z/fexErcItCBItH2vqBPE/Okqc/3DyP0kMbaxxSHQNrS495fsgTvHCwrlRThtJ5D5km5h0+D5dlQCYnuSRLa4USyo68S2xliLJHBUhavfH6Ds5hxKamg1mLTGIK3zxscrQldrN3ZiN9vWhNNkdGrJvd5v9Nf1336EmJscA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=bq0Lksk1; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="bq0Lksk1" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-cbb7926836eso1049317a12.3 for ; Fri, 31 Jul 2026 22:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1785563735; x=1786168535; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=d0YoODerQIzEOVN20KJQiVnY06JcnNCgCt2bly7t1Fo=; b=bq0Lksk1Lv0zrJjlb4BgOI/7ySE/jGJyriPfZutvDqXQiBzkprJuBByFyJFedLq79I AJID9AJf9FOn118dIH6qYNIWqX0xtMS8U7EK2rgHMOOWXk2Mu+Q7RqtitrqGriBSDucL cD2XhI+dLpOehAGKLI8z7yU+ygf1KT0Kpa5xrAzhMmGXwuj8XoElt7yWVp1tUE/KILhZ ottEQqyo7UD5yZQYKl24m4zeQRlGR6PF+BN20/3+knvO44+jbrVs9Jt2qfHaZn5gGdFq nwfwcQoqimYZ5XkTQu2dTZXzw7opAAEjeCv3na8bkuEvdwXXqmSu9D4JExD2pZ2cYJNh L+IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785563735; x=1786168535; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=d0YoODerQIzEOVN20KJQiVnY06JcnNCgCt2bly7t1Fo=; b=GXuHOk007z+bSZy+BMkhhnNCspHvTJJ4dKgAWswZqP8zpVTuzImdM+yGoGXziUd80F zEeol63TTYSD00XNxWgzt2iOqrERIbUHFUq+3HjAy3UARPGflmW2pHCoruU1x0YFxOPs ry6b2uS/8xhiTIpVeL/BMi7QMUeg6vzbeZhXSVenJQ0Sgeq3TnhvWz2pdM/K2piHlQ/O aPEBGXMqKjmz+1pJ3+c4AjnbuScxbmQM+RzDBBknc8/PqAXSKBhFC6nsyhfp+yITfdYp tFTgOi9WII2g3M5fIhstLBBw/Qi3of/K5pTd7ls1qwjCjJKcxF3rwcMKY5p82VoZCisN 5IAQ== X-Forwarded-Encrypted: i=1; AHgh+RqlKyEBIaHu6EeghK6J7gX53pPf1/d6Usqjldxx+f20SxWY7A57O1LrWTPshsQO1Grm64fH+hHMVXPQBWQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwKLtMHGD9rEjliJBri5BGTAOR6c3QlA+Ru70B1gOfXDEzsn38Q AQvulk26aD0M8yzn6vquh1Mp5DBaCnTUmEAnRUnf69MOCkzIpS3mlS3ZrRwiSSAUdWI= X-Gm-Gg: AR+sD11DAkFeynVK7PuUQxKBvk/TJEFEkqXVc6h1NKjKUa/T4V4uu0BJFv4lov60vS1 mAcVp6GZ77DCUc4JoUntD9cysazF2dkuEyjSVa3g3FZyz0C4ldr9+DPkOE5TOoxQlVaMYk1CZAM vq7Q0BXiWeAvIUE4ain6l/8S/+AsZAUHS+xbQk5Mv86e76jLSBmq2RCJCodcNy4NFMnbfCaggzt yjJ7BMcCfvkj45SFdYOvexeh+OCaixheiVECewytrDX4khlgEY2Hcgwcj03HKRXa6al1EROnM6T M7kBLlyHm/bt5Z8SJsY5QCSGVG6ioBpyK3m4BNLzIBCae+vAuchNILZbHbajwz+N7blTJZzhQeq 7e2HYcZMcQh6OMyzcMh+l+3S7cZ9y9ZGhGDIUtSnR3q6JYXWR1qeUhtB1FtfYyUQLAlqUJBXWuP IIG8l3K+Pl6huKKSqb5QJ4G9jeVq2CTgLpguMrUndox6CwLbnTYUQ/SWvR/rg5lgtHONJ5QXIGg 8NVNErHwL6RSDn0wA0IIu/SMT2jp3v0IJ8EW1/mx8+6Q4gkU0byDDaCl/jK/xxIChN8Y2LfqAGY VrcFsg2CRHxX7m4= X-Received: by 2002:a05:6a21:9995:b0:3c3:b4e8:5565 with SMTP id adf61e73a8af0-3c92a8f301emr2512911637.61.1785563735027; Fri, 31 Jul 2026 22:55:35 -0700 (PDT) Received: from Metius.iitm.ac.in ([103.158.43.43]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-13fab050d8csm16502537c88.0.2026.07.31.22.55.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 22:55:34 -0700 (PDT) From: Abdun Nihaal To: Steen.Hegelund@microchip.com Cc: Abdun Nihaal , daniel.machon@microchip.com, UNGLinuxDriver@microchip.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, nathan@kernel.org, ndesaulniers@google.com, morbo@google.com, justinstitt@google.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, joe@dama.to, horatiu.vultur@microchip.com, stable@vger.kernel.org Subject: [PATCH v3 net] net: microchip: vcap api: Fix possible memory leak in vcap_decode_rule() Date: Sat, 1 Aug 2026 11:25:05 +0530 Message-ID: <20260801055507.47534-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated for struct vcap_rule_internal, keyfields and actionfields inside vcap_dup_rule() are not freed in some of the error paths in vcap_decode_rule(). Fix that by calling vcap_free_rule(). Compile tested only. Issue found using a prototype static analysis tool built on top of the LLVM compiler infrastructure. Fixes: 610c32b2ce66 ("net: microchip: vcap: Add vcap_get_rule") Cc: stable@vger.kernel.org Reviewed-by: Joe Damato Signed-off-by: Abdun Nihaal --- v2->v3: - Rename the error label to "err_free_rule" to denote the first action being undone, as suggested by Jakub Kicinski - Move the information about compile tested only, and how the issue was found to the commit message, as suggested by Jakub Kicinski. v1->v2: - Convert the error labels from "err" to "out_err" to avoid confusion with the err variable, as suggested by Joe Damato. Link to v1: https://patchwork.kernel.org/project/netdevbpf/patch/2026072712= 5757.134611-1-nihaal@cse.iitm.ac.in/ Link to v2: https://patchwork.kernel.org/project/netdevbpf/patch/2026072811= 4253.196398-1-nihaal@cse.iitm.ac.in/ drivers/net/ethernet/microchip/vcap/vcap_api.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api.c b/drivers/net/e= thernet/microchip/vcap/vcap_api.c index ff86cde11a32..788c0728d763 100644 --- a/drivers/net/ethernet/microchip/vcap/vcap_api.c +++ b/drivers/net/ethernet/microchip/vcap/vcap_api.c @@ -2427,18 +2427,21 @@ struct vcap_rule *vcap_decode_rule(struct vcap_rule= _internal *elem) =20 err =3D vcap_read_rule(ri); if (err) - return ERR_PTR(err); + goto err_free_rule; =20 err =3D vcap_decode_keyset(ri); if (err) - return ERR_PTR(err); + goto err_free_rule; =20 err =3D vcap_decode_actionset(ri); if (err) - return ERR_PTR(err); + goto err_free_rule; =20 out: return &ri->data; +err_free_rule: + vcap_free_rule(&ri->data); + return ERR_PTR(err); } =20 struct vcap_rule *vcap_get_rule(struct vcap_control *vctrl, u32 id) --=20 2.43.0