From nobody Fri Oct 2 12:25:02 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF65E470129 for ; Fri, 31 Jul 2026 18:24:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785522265; cv=none; b=rd9ZD0ztlW4ZqmBLRzzzP7dAYrVQvxwyMKPNoKv4FDwKHKIe7y89Ec0DFfn5F2Q40LXxowsz9iSBjsobJ6QbhB79LcV9KzDUyiSSdLukzB9pBlVe2+VuS0Coe/1KJQPuu2tTlEXFRPQYLfOZhjYIML1wTeprIJIIIU49rme9Q0I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785522265; c=relaxed/simple; bh=EPY5u/ZBN4AuBkuSxbn9+BI/xZDkdQvnzEg57jzxv4o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ABxdLnx753Dp5VwAbGitdRmpgfKeAn5krTQ+0vQ4kEtAgIfKPg/jIVe/5FlB0rpJI+IHUneCPlMJBmLfHiKGQSMLhvavUMN7z5tWzHMKFBqCXHbJgUmMO7vkBl7VcyHWABWRz8tugefuzhsfW3E4r8uHKzhcOW4U7Uvw2gHv/fk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NuOZe2UA; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NuOZe2UA" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38e041ea211so1406977a91.0 for ; Fri, 31 Jul 2026 11:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785522262; x=1786127062; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vDzVbcLKcPv6oSc5KVtpGnThTEkbSjdGeapuLqqH1HI=; b=NuOZe2UA13S9Q+6Ajsz+JrUAGC3fkWl4fhU6/8o4T16b6klag0dXBb7kYQgvE96lxR +mWXR76z2iCu9lKpBK4Q1RviCfto8R/ho7BU8D0rmaHOwxiExNcnSC6E6YiAV1vckAO5 t1EpekzmiUBRkDVCyYF9hjY3YFW3iXdJhM2rk7dfITkzJBhv+WxBsLvbgjqjFaWe5Qvy 9oWNd+AwL6AJp+63G+N3erM9enynFKIzUfQzntoSFkLOXks9syb1fCJHMr2Q/F2wHmZE oqTEQoo8tkmFgeiuW5pjoPspN6qbHLRjzD91Mj1blfU2FgD+ofzdeBM94QxgidZJsjMD FxQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785522262; x=1786127062; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vDzVbcLKcPv6oSc5KVtpGnThTEkbSjdGeapuLqqH1HI=; b=Dl2av47Zi/6ps6YzygpNppNXJb0DnZgx42Yk0d2KiJ5393aofpQh0fvliuq6JfSKcc HBtH1jX0MO9ivG8zjpei1b5dps7CifKnDntX7jk6SdNcDj05iufk8+1CR7Im0M15q7ou J2lV30qGmkho8shvhrp38T+E5LXmkJS0ouZN9HQWNTV/LdZpDyWXHIfOH9qe/izHudLw /3eVoPuzJ+9yAb34MECtOhBN2Q12bMGPApDEo5EPqSC06Dl+c6YoWQu48hotyw9iFZA3 PGMrT0CiVTh1DiVrrszsuUs8r1dGP5ARCU/v0z8jz2mjqdw2F0kUwmuhzkARvI7kogeM pA2Q== X-Forwarded-Encrypted: i=1; AHgh+Rrxmu4HjcdszvZueYS8L+DcygLbYAF/rokr4nytSbyGpgaXZJQ9yz4ik6R1o3UQr6UEwWMEM0ZbsbZ7pAg=@vger.kernel.org X-Gm-Message-State: AOJu0YwKA6jy3kfV6pyn0rw/2WwpOv8JGEYYnOThasp1JbejQoJrvuua BS4KsZJuCKadNxO+1ZELNFZGEtn+RBnuhGEsGYkJWPiwXcza37+xzLP3 X-Gm-Gg: AR+sD12Zna21M9m2DbPH5YbOM1L1hx+sAKVRYKttj6Dz7WKn7tLAZlPpSwaBcYT7f9i +Atrog1cNGZbKhZrqAASaH9GzUBTGLBziAX41wdnPh48bkPfhQpOs5sGfnTJxOVcR5qxP7k9lVE DUcNtpeN8ZTc4i4d1eSYNYzbtNBE6oCxDZtxon+1UUzLn1FtrPX6hRKdtYU0ck5R9DmrLuiV3mY wyY2B1Hev70Mx4VaVYHjpnrWadaBzWU2t2gRsfBzTQLsdcOHgDKZlp6Ny/wCBlPvwwDiATej1Hu RQjyuOBPfI2jpU47rrQJuAvi1znn0rqi/s/Uydmz+KiUdUvIOBtL8qjtrCHg3SARjMIbE6yz7Wp n9NfCVp5gcr0dTWthPy2sLFPVgg3LOvCsSuoyENpXtzQs9/X0CkFioz4BW3xiASnnaFurtKuHsv IKoItwMq2XY9whvE1sBtInVRa5RrMoLM2UBfcDccO8OspeqW7FlR+9UF2kM1s= X-Received: by 2002:a05:6300:6684:b0:3c3:c080:71ca with SMTP id adf61e73a8af0-3c92a26b14bmr795433637.0.1785522261990; Fri, 31 Jul 2026 11:24:21 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:d69c:7f00:28b4:311c]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c1casm8400785eec.10.2026.07.31.11.24.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 11:24:21 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron , Andy Shevchenko Cc: Joshua Crofts , Broadcom internal kernel list , David Lechner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Mohammad Shahid Subject: [PATCH v3 1/3] iio: adc: bcm_iproc_adc: Remove redundant error message after devm_request_threaded_irq() Date: Fri, 31 Jul 2026 23:53:45 +0530 Message-ID: <20260731182347.42888-2-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731182347.42888-1-mdshahid03@gmail.com> References: <20260731182347.42888-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid devm_request_threaded_irq() already logs an error when the request fails, making the explicit dev_err() redundant. Remove the duplicate message and simply return the error. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index cf4738b16e62..1b0dd654402f 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -551,10 +551,8 @@ static int iproc_adc_probe(struct platform_device *pde= v) iproc_adc_interrupt_handler, iproc_adc_interrupt_thread, IRQF_SHARED, "iproc-adc", indio_dev); - if (ret) { - dev_err(&pdev->dev, "request_irq error %d\n", ret); + if (ret) return ret; - } =20 ret =3D clk_prepare_enable(adc_priv->adc_clk); if (ret) { --=20 2.43.0 From nobody Fri Oct 2 12:25:02 2026 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1B7247042F for ; Fri, 31 Jul 2026 18:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785522275; cv=none; b=Eiie+XX2U5FxE0fWKmc6+Pzexv28N/Fd0qaAA+P1NPqZQDUuD/eua3hRBzzb4wXKKzyRN2DhrHc5MN9bl1oBtvj8kQKyckEaeoDpJWUTploUg+CJe0bo1KMfxBd4NDI8fm+9lW9NWTC2nqvFLsctEPsWapDjTKk1+N2s7ECjY/0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785522275; c=relaxed/simple; bh=j4VKKE2lbj9EIehEK9wJEP89gyl1CvgBqtl5SfvS28s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OfqZntPiDnGb66coBXbw0k2Rk7GntCZ9bddxGriUoGV41A1qGHWPnafkI7Dj07TsAy55YqOIhcf0W8JcXLd9thL2j3A52ePJEf4OvzM+uopUpIyXQD5NoAPPSMu+ER9UBtOxseb2eXeVhe4TCJaRLc7/570zOlnZvZzToelI+eg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fqOAVfux; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fqOAVfux" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-cb5b8572b70so1119510a12.2 for ; Fri, 31 Jul 2026 11:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785522272; x=1786127072; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gsS73bmDoxyOch7pFT+GXYXN7OXiaTwdO6oVVnU6ol0=; b=fqOAVfuxd0YXprlVo/1PwgPvj+ReaQ6VTQq+JkPfdW2JqjA5F50PTwsDtmEimu/KyM eLWsHh5YZDIZtsjDSM9FDWUyOOE+M35t174XHrq5Kr5D4GbvNgwuqmleau7zboDojkNR uP9si+NWBdq4UJjh/VMX2yDAHtwjLdkFZFhq0ZAZ5kmHSZbjxIMozECd3Q8xgyY95KXE DhLHCWfNZNDAVfoytuEeTDehrP59C/NwCxLDHjfAOO7U1FWMZFNMD2DAJsb3y/cZ51WL wkUMUrFz6G3Rr2DzUJ/pNtmVE6DK4HwLJaqG6NB6SH2Cr/yT9/wByIuph2qTRwsiW4eJ H2Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785522272; x=1786127072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=gsS73bmDoxyOch7pFT+GXYXN7OXiaTwdO6oVVnU6ol0=; b=hjDFdrXk7omKnf4fWkyTun6wET/RUl4aDzew01sokQoA65qD+uOtN1K+SLLI8xhc+l tvKPWObaA4UU+RNKLqAbCPXekpX4OdGnC3idMzz3rV9m+F1th7kAoNWN4LNsk+fSsvYx GTCJfzyRBCJRN9Dxgm7YcbxyxyCL/aNI+Emptk0oPJ0iEU1JA92OLrpGsQmX2ICHLycT HWoNAkyZEx8p+NMfWw/6qUKrfSdFBIIqKPGyPGWsRfoGcoRhcwTaBsaKWETRLoIQnzz6 LBNQruPsNHwnHKbEwlPoptoJVnG9Sr4b7z6QI3aG/yHiFh779ofMceVcoWqBrzthtTHH EZIA== X-Forwarded-Encrypted: i=1; AHgh+RrBxO8XU5/awKbmGJGpUc5MunyYCnM0XYSxzyCDs6sQA/VtT4aee+maFnQwCtZ3qNHvY7f9UGpsIn0Qvio=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9uKVIRyInUC+4sFgbR38Ke3/1gfB/kXrQmrTHc8BqafnhQcfY /SbtX1VukgfmpngHBU88YC3mTKpqbqdHud9UlqR6LO0Gd1wT1TiMBIqa X-Gm-Gg: AR+sD11eYZYbTyGda51vGdlYtxvddQEygwYO/1YQbuz/sJbEjnNAdyOJAL8wfx3usdf iab+Me1DARUkl7anD9ZadOgBl/4CF6ODPMGSnddylcw5NAhv7kJF9kXKS9C+oOPSH123I46wamb GVRbsQtUx0VGWtIDzGh/2qURhSvBUBW/6KR3DaQliuDSrgX1yQIIBbBofg5aw35JiaIWMIBeuPJ anQ3uwa0oqBQJ47sKW290vqeMgbCCJfmWlj50Pe6bGWQzYCoPy3odvmov+bJ37niJwDPQgaQHj0 NZSpSkmGWIiK0I8EPb1/d0uiqDQtFZrgb+5BWuGR7bg+ORmGbN1m3nJ1Kz9Or1QKs6W3haj2md5 OlzSTP3IMkQ0YaAuonqKSW9eQiTk0yXMjqYOsyzsN7a73uPzv4UTgu8cGOYROzJjIMoTxf7fysE oIAwJ+BZqOqQ6kalZzgZ3BDUHwGugz0KUymZV2XqRBYF9vnKHXjIWeSvGPI4Lq X-Received: by 2002:a05:6a21:6f13:b0:3c4:2a97:fd2 with SMTP id adf61e73a8af0-3c92a8757b4mr806736637.67.1785522272021; Fri, 31 Jul 2026 11:24:32 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:d69c:7f00:28b4:311c]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c1casm8400785eec.10.2026.07.31.11.24.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 11:24:31 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron , Andy Shevchenko Cc: Joshua Crofts , Broadcom internal kernel list , David Lechner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Mohammad Shahid Subject: [PATCH v3 2/3] iio: adc: bcm_iproc_adc: Introduce local device pointer Date: Fri, 31 Jul 2026 23:53:46 +0530 Message-ID: <20260731182347.42888-3-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731182347.42888-1-mdshahid03@gmail.com> References: <20260731182347.42888-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Introduce a local 'struct device *dev' variable in iproc_adc_probe() and use it instead of repeatedly referencing '&pdev->dev'. This simplifies the code and makes subsequent error handling changes less verbose. No functional change intended. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index 1b0dd654402f..29ea35972a23 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -506,9 +506,10 @@ static int iproc_adc_probe(struct platform_device *pde= v) { struct iproc_adc_priv *adc_priv; struct iio_dev *indio_dev =3D NULL; + struct device *dev =3D &pdev->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&pdev->dev, + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*adc_priv)); if (!indio_dev) return -ENOMEM; @@ -523,14 +524,14 @@ static int iproc_adc_probe(struct platform_device *pd= ev) adc_priv->regmap =3D syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "adc-syscon"); if (IS_ERR(adc_priv->regmap)) { - dev_err(&pdev->dev, "failed to get handle for tsc syscon\n"); + dev_err(dev, "failed to get handle for tsc syscon\n"); ret =3D PTR_ERR(adc_priv->regmap); return ret; } =20 - adc_priv->adc_clk =3D devm_clk_get(&pdev->dev, "tsc_clk"); + adc_priv->adc_clk =3D devm_clk_get(dev, "tsc_clk"); if (IS_ERR(adc_priv->adc_clk)) { - dev_err(&pdev->dev, + dev_err(dev, "failed getting clock tsc_clk\n"); ret =3D PTR_ERR(adc_priv->adc_clk); return ret; @@ -543,11 +544,11 @@ static int iproc_adc_probe(struct platform_device *pd= ev) ret =3D regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2, IPROC_ADC_AUXIN_SCAN_ENA); if (ret) { - dev_err(&pdev->dev, "failed to write IPROC_REGCTL2 %d\n", ret); + dev_err(dev, "failed to write IPROC_REGCTL2 %d\n", ret); return ret; } =20 - ret =3D devm_request_threaded_irq(&pdev->dev, adc_priv->irqno, + ret =3D devm_request_threaded_irq(dev, adc_priv->irqno, iproc_adc_interrupt_handler, iproc_adc_interrupt_thread, IRQF_SHARED, "iproc-adc", indio_dev); @@ -556,14 +557,14 @@ static int iproc_adc_probe(struct platform_device *pd= ev) =20 ret =3D clk_prepare_enable(adc_priv->adc_clk); if (ret) { - dev_err(&pdev->dev, + dev_err(dev, "clk_prepare_enable failed %d\n", ret); return ret; } =20 ret =3D iproc_adc_enable(indio_dev); if (ret) { - dev_err(&pdev->dev, "failed to enable adc %d\n", ret); + dev_err(dev, "failed to enable adc %d\n", ret); goto err_adc_enable; } =20 @@ -575,7 +576,7 @@ static int iproc_adc_probe(struct platform_device *pdev) =20 ret =3D iio_device_register(indio_dev); if (ret) { - dev_err(&pdev->dev, "iio_device_register failed:err %d\n", ret); + dev_err(dev, "iio_device_register failed:err %d\n", ret); goto err_clk; } =20 --=20 2.43.0 From nobody Fri Oct 2 12:25:02 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00DBC455192 for ; Fri, 31 Jul 2026 18:24:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785522287; cv=none; b=J2C0XcVRkqpewVKTdlkc+mhPbyguFWuN6bJgiKQ37/IhF2Bgxrn6AHNRb/TQWPtqdAH1xQ/Sn8KzuCnDPkfpB/bvQL1PkEv5XWQ0mNO/kc3fFLRI1ZsqM9NghoVEJ7COXkavT90fWfTFpFUjjzvasvSqRMaRZjtLghYZ5CUWIOA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785522287; c=relaxed/simple; bh=VD2QHojgachEtitvCMQ22pgLNRLQvtYqV1cce6F2O+o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Vk6VUSHI0iUlb3FVKGzWryzFeGMm2upodI07wzdk9Ac5Z1sgO5as74VSVthPUZ6CzPh10i0SVcDyKr9AXvsk4H64M9m67DvOcefbCJ8KuY9C2Bosxap9hKCOgqBTRsa7y0NLeUqkeJDhHe+Pg4ZS7z0L/XoL77UkTfIREtewXa0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lko9YkiT; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lko9YkiT" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38e3617ba36so1462335a91.3 for ; Fri, 31 Jul 2026 11:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785522282; x=1786127082; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=S96pVSc6qSK7JNjBnWVrJfF1KAwOzUVlXD18tkrIn6w=; b=lko9YkiTAslGn6X5mbMSTAL7xnSHkPC7oG6e5OEZQ9Gk2nBce5wfjEJIx5aPsQwaCU Rjy9frMFar0Q4xU26XtTcLzHh6p1jzD1hBrQdqBOknFrbxO2Jdsk0kfop/Yeew8ZzGeK 9N15s/VHiMXOwQWg2DAcDcxXFwB5LtD92rpCcFVSzHIua4t6P7mkYUN0P9wzN3r1mWgD cWY/8BbEdXTla8DX2vSbP8g9hrLLYid890zNT+fn+/NA3iUy/tU7Xyu+Ms0RnA0AzSAK 0q8IkTDFzbxY21TVH9DVjoBp6Mm8Lg0zTfRL2Ecrf7VemiS4WfZV61HI6FvBtKniADes lqhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785522282; x=1786127082; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=S96pVSc6qSK7JNjBnWVrJfF1KAwOzUVlXD18tkrIn6w=; b=YsOI01KtXVRShZ/bIyj7TmgVcykBCZbd971ixHra1uIqNprGjFCtSsVweof0ftWACe ySh6JXZ+7xyWWeG3BNM1JqPvTD+UVOIJ38Q5nxRS2rObCkpzECGP6kBDERx9Nv6lPo5e JQB/L64mhagi4SlM1Xql3F1VulqFqlt4yD7iKj07pKlaHWXvmlEy55N2xVzFCzADUj2h nuFzq+ae/KnY6O5eY8O96Wx+glRw+uU4txYyxjTqGGMYjysCvEg6GtpBnpDKuI0cSPK7 nIlbPeNYOdnjGfDPG+omel8il9ho7NrFurSJYk38Se+KXK5P+N4k7kBOXeYfHVQEOeQW rInw== X-Forwarded-Encrypted: i=1; AHgh+RoWitXs/VD5JWtueLbLAt4VIqI8RRoFhmoBPreQS51ipAmDR71YX2e8t9ZtDTUnXYMHl9zZivVoNcG/LhQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5kdFrl8S1rhbmifv3JtR+8BcwKxQI33ge2ngBfpO01nbp80z+ UJHssGqxqC+nhyiurUBN87QWVXZko9CAUCCsIMjKM1LvVhwM3SkrcT+d X-Gm-Gg: AR+sD10b1i2wfZI2VoyPAjc98R9q/Baa/ok8rG1V1Mh8jXH4lE6JAlUAt3aZYmZHrsB 9Sg5BPJjJWbQ8rz+YikH8CGl5T+MmeOiFXZyaaZybmKN8etkcGnOa0fteFFu6miKU/X/2vGtbbs LLiGcBo5qzI00307vbUeJVHXiBeco4T2OYwuhES7m43dnnU8JEf+zyT/b7qNJBFzHjGeCL3x0oa rVk8eKlmj0KsUamZb9flP94J5QchjOEfusZC+o3H+cl8ctm6DxX8fBog2O59uiy/VYyHTCi152y jAd3dGBQ62hc8nJGj+kv5rTiKiouUe22mRmhRbnEtnhAT/F3TUCtUQHRGBgsLKy8mUkesnX4uzA WeYhL/iIz+woMfPU72KQem5i6pUd/iA0X9AXXzZlx+RvB8XaFkdofiPd+xojqNNzFoAlSmmuT9+ fhQeir+WgDY16MbKedjHR3BEgk6osm+lpZuJu+Sfe8Wkz0LVr8ABOIkjIeDwI= X-Received: by 2002:a17:903:3886:b0:2ca:feb:303b with SMTP id d9443c01a7336-2d052429193mr8562495ad.25.1785522282316; Fri, 31 Jul 2026 11:24:42 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:d69c:7f00:28b4:311c]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c1casm8400785eec.10.2026.07.31.11.24.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 11:24:41 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron , Andy Shevchenko Cc: Joshua Crofts , Broadcom internal kernel list , David Lechner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Mohammad Shahid Subject: [PATCH v3 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() Date: Fri, 31 Jul 2026 23:53:47 +0530 Message-ID: <20260731182347.42888-4-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731182347.42888-1-mdshahid03@gmail.com> References: <20260731182347.42888-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid This simplifies the probe error handling by replacing open-coded dev_err() and return sequences. Also remove the redundant dev_err() after iproc_adc_enable(), as the helper already reports the failure. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 43 +++++++++++++++------------------ 1 file changed, 19 insertions(+), 24 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index 29ea35972a23..5fcd528eb88a 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -523,19 +523,16 @@ static int iproc_adc_probe(struct platform_device *pd= ev) =20 adc_priv->regmap =3D syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "adc-syscon"); - if (IS_ERR(adc_priv->regmap)) { - dev_err(dev, "failed to get handle for tsc syscon\n"); - ret =3D PTR_ERR(adc_priv->regmap); - return ret; - } + if (IS_ERR(adc_priv->regmap)) + return dev_err_probe(dev, + PTR_ERR(adc_priv->regmap), + "failed to get handle for tsc syscon\n"); =20 adc_priv->adc_clk =3D devm_clk_get(dev, "tsc_clk"); - if (IS_ERR(adc_priv->adc_clk)) { - dev_err(dev, - "failed getting clock tsc_clk\n"); - ret =3D PTR_ERR(adc_priv->adc_clk); - return ret; - } + if (IS_ERR(adc_priv->adc_clk)) + return dev_err_probe(dev, + PTR_ERR(adc_priv->adc_clk), + "failed getting clock tsc_clk\n"); =20 adc_priv->irqno =3D platform_get_irq(pdev, 0); if (adc_priv->irqno < 0) @@ -543,10 +540,10 @@ static int iproc_adc_probe(struct platform_device *pd= ev) =20 ret =3D regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2, IPROC_ADC_AUXIN_SCAN_ENA); - if (ret) { - dev_err(dev, "failed to write IPROC_REGCTL2 %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, + ret, + "failed to write IPROC_REGCTL2\n"); =20 ret =3D devm_request_threaded_irq(dev, adc_priv->irqno, iproc_adc_interrupt_handler, @@ -556,17 +553,14 @@ static int iproc_adc_probe(struct platform_device *pd= ev) return ret; =20 ret =3D clk_prepare_enable(adc_priv->adc_clk); - if (ret) { - dev_err(dev, - "clk_prepare_enable failed %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, + ret, + "failed to enable clock\n"); =20 ret =3D iproc_adc_enable(indio_dev); - if (ret) { - dev_err(dev, "failed to enable adc %d\n", ret); + if (ret) goto err_adc_enable; - } =20 indio_dev->name =3D "iproc-static-adc"; indio_dev->info =3D &iproc_adc_iio_info; @@ -576,7 +570,8 @@ static int iproc_adc_probe(struct platform_device *pdev) =20 ret =3D iio_device_register(indio_dev); if (ret) { - dev_err(dev, "iio_device_register failed:err %d\n", ret); + dev_err_probe(dev, ret, + "failed to register IIO device\n"); goto err_clk; } =20 --=20 2.43.0