From nobody Fri Oct 2 12:19:59 2026 Received: from mail-pj1-f97.google.com (mail-pj1-f97.google.com [209.85.216.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABEE844E02A for ; Fri, 31 Jul 2026 16:37:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785515852; cv=none; b=ubUUGRu5syOG4Lg98GlSeZspFiX1zFh4jCDU4zar8cFKBvc4bRaYhJaYzhjdYMRv6AlzN1rZjXd2BpuA9YP8mcepkTblOdth31uunZccSyrrgWTGfov5pp7Yb5oOgeVp9CtcJ1eADzXsrMbWWBMDqi1RvOL/W9VwZyCPGxTUSBI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785515852; c=relaxed/simple; bh=O5fJQ3d6PuDgPKpL8e9OVHaXuQDovYEMEiNrPn9MFLU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lcSWqRxrwK3HmpyjEgKqX5C2fAuMspEGfkSTgRZKQDlTLDtCtFEgyWzuUo43ywWRLEZBw5lrScVuB6aZO8lj5L9XWgJ6tYISNtvZ/ZkvLA8c5aAC5IhWmkDyDMOGmHr5EqiDYjZ7ORAthZm8oDP7w3opFTGiO17d7RgfFzg3rFM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=NMdKNdC8; arc=none smtp.client-ip=209.85.216.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="NMdKNdC8" Received: by mail-pj1-f97.google.com with SMTP id 98e67ed59e1d1-381c51fde6bso1296275a91.2 for ; Fri, 31 Jul 2026 09:37:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785515850; x=1786120650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MmTQj4gHPMMZifdDZe2dPfuW/tp8ej1Qu6RBJZYcOCE=; b=erWbatbxzqZJCsg3wnV4g7Yq+T1A9o+FMyBMjNspWyJa8u+V099nCerHqMyS1dlzjI fMqnEk9JXYZBpFF25UQsLSFaf/oeS619NuU8KsSJQuhUnafEMxNzjH1jebJwz6xaZxEr u83v4ncPmacuwAldwq7WF0Nek0d7Apjj1nn4sQSBTmnz3xzbSBon/EPMEzHqkSK8N7fQ aTmgGJYmg2qguSHuiQqiBXQykbDZrq4B321BQDXyYeT7lRQ3ygeL9CORpGrmHbkm1MEq hU3PzQNACuCiC0e2zJ8Bc1MBfVHv4+MzxRDw3v6LHSl8++Vruzgc2M041WvEyaVcIROT /GpA== X-Forwarded-Encrypted: i=1; AHgh+Rr4X5x5pMMpDhvmrPMMU76QNYAH85iEetcPtlkDB/k30XCdiBVH0ddexzUPnbEZiyWTVXP1Y9hcFKsISOs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8YpM7q0po1xMdQ599HeppJRrAbxIttZEC00K8llgV5TiFTHeZ OOucbgGULZEhqMpebmM8y5MJJ8rwDuBbkvSR9keRcIUwZAd1QJtimGVmNpxFXZB6I/LRO6gItaw UF5XTmzIdUAGDclPXJLh4CwWUCrYg95WPIQLINK3tj0iaL3O7nXKE6MFtFeiI7tY2gG/XOGqkC7 EjcEBHogMvKnb3mRULndq88p5rKwwZ3YoNk1rOHusyBMvDpIIZonmbZ7ltigv+XM5v4XlpM6kPl dcE0DREI7/eajIGxg== X-Gm-Gg: AR+sD10kigakijoQzhVM8hzs7nx/aYDZmrgEFhjC7ZwiIu5pl8hbP3BQheb1Xf7+Qsg Uj9ylFlH4721U9ay5DOfCeqvsNW1Mi3LDCffycHSvjjRK/iTvIdg8GN9LujCucWRrC3E2m4tJFi 8mrmDFN148viNSpUhuNpHMbyvoUs91C4SIIst5q3E0lWjpumwcnatnZqswSJ70i2T8FRWNns2/x Xm8NEdGBXeY3ikDljQMzDCbhKiGHLCKg2iXqFgy+eZRQZPTmdAMzcqDw2m257ifKnCo1bCCSesd CYwdX/1Urkc+TfA1mjJik31XHVZe25X/YyKlOFnbuhdxCFfGfuUNLReOpLllV4jdPZ2D5xr8Noi YmmC9BS1gALxoLwEVcb2y9Vh4hU6EY3JmbBvYm5w2WkSKwoftm2Yhr56BZOqgPdJGQLAfFRtNGz 3vbYQJ4KswKZuscpAll3eI0+5NW4Ae2uHhlg== X-Received: by 2002:a17:90b:4d0f:b0:38e:bfe:81e9 with SMTP id 98e67ed59e1d1-38fbc4009fcmr505321a91.1.1785515849947; Fri, 31 Jul 2026 09:37:29 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-22.dlp.protect.broadcom.com. [144.49.247.22]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-38fb301fbf4sm173290a91.5.2026.07.31.09.37.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Jul 2026 09:37:29 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84a67b16217so2347869b3a.3 for ; Fri, 31 Jul 2026 09:37:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785515848; x=1786120648; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MmTQj4gHPMMZifdDZe2dPfuW/tp8ej1Qu6RBJZYcOCE=; b=NMdKNdC8K5AkAWbo7yab82YHFogSkSByHFCXfHJiiSwZolJ8JL4eaHNwbn60Sr19le zvZ5Fm0GwEJwUFS+yymgrbGwtwrcDVN8eCnyc/zHGz2jAhtEcHe+zllNxFVDEK12WDSL ll5OiqX6Y7Ou4LQwIH1axXVmGNSy71JhPNxI0= X-Forwarded-Encrypted: i=1; AHgh+RrtNp6l1VjrMyb8FKHf7WJBQpZP1/4ho2x9BQPE8n4dsr4aKBRFKKsj3uYg4b+2jWs8F37wzh6zUTZTukk=@vger.kernel.org X-Received: by 2002:a05:6a00:3cd2:b0:847:8b1d:230d with SMTP id d2e1a72fcca58-84ee482bb68mr331596b3a.3.1785515847762; Fri, 31 Jul 2026 09:37:27 -0700 (PDT) X-Received: by 2002:a05:6a00:3cd2:b0:847:8b1d:230d with SMTP id d2e1a72fcca58-84ee482bb68mr331559b3a.3.1785515847125; Fri, 31 Jul 2026 09:37:27 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84edbe57020sm690127b3a.17.2026.07.31.09.37.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 09:37:26 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bhargava.marreddy@broadcom.com, rahul-rg.gupta@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, dharmender.garg@broadcom.com, ajit.khaparde@broadcom.com, Vikas Gupta Subject: [net-next, v2 1/3] bnge: refactor rx mode helpers to accept explicit address lists Date: Fri, 31 Jul 2026 22:07:10 +0530 Message-ID: <20260731163712.3463362-2-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260731163712.3463362-1-vikas.gupta@broadcom.com> References: <20260731163712.3463362-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Rename bnge_cfg_def_vnic() to bnge_cfg_rx_mode() and update bnge_mc_list_updated() and bnge_uc_list_updated() to accept explicit netdev_hw_addr_list pointers rather than deriving them from the netdev. Add a snapshot parameter to bnge_cfg_rx_mode() to skip netif_addr_lock_bh() when the caller provides a pre-snapshotted list. On the open path (snapshot=3Dfalse), the live netdev UC list is passed and the addr lock is taken as before. Signed-off-by: Vikas Gupta Reviewed-by: Dharmender Garg Reviewed-by: Rahul Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 39 +++++++++++-------- 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 6f7ef506d4e1..db0e616fc46c 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2144,16 +2144,16 @@ static int bnge_hwrm_set_vnic_filter(struct bnge_ne= t *bn, u16 vnic_id, u16 idx, return rc; } =20 -static bool bnge_mc_list_updated(struct bnge_net *bn, u32 *rx_mask) +static bool bnge_mc_list_updated(struct bnge_net *bn, u32 *rx_mask, + const struct netdev_hw_addr_list *mc) { struct bnge_vnic_info *vnic =3D &bn->vnic_info[BNGE_VNIC_DEFAULT]; - struct net_device *dev =3D bn->netdev; struct netdev_hw_addr *ha; int mc_count =3D 0, off =3D 0; bool update =3D false; u8 *haddr; =20 - netdev_for_each_mc_addr(ha, dev) { + netdev_hw_addr_list_for_each(ha, mc) { if (mc_count >=3D BNGE_MAX_MC_ADDRS) { *rx_mask |=3D CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST; vnic->mc_list_count =3D 0; @@ -2177,17 +2177,17 @@ static bool bnge_mc_list_updated(struct bnge_net *b= n, u32 *rx_mask) return update; } =20 -static bool bnge_uc_list_updated(struct bnge_net *bn) +static bool bnge_uc_list_updated(struct bnge_net *bn, + const struct netdev_hw_addr_list *uc) { struct bnge_vnic_info *vnic =3D &bn->vnic_info[BNGE_VNIC_DEFAULT]; - struct net_device *dev =3D bn->netdev; struct netdev_hw_addr *ha; int off =3D 0; =20 - if (netdev_uc_count(dev) !=3D (vnic->uc_filter_count - 1)) + if (netdev_hw_addr_list_count(uc) !=3D (vnic->uc_filter_count - 1)) return true; =20 - netdev_for_each_uc_addr(ha, dev) { + netdev_hw_addr_list_for_each(ha, uc) { if (!ether_addr_equal(ha->addr, vnic->uc_list + off)) return true; =20 @@ -2201,7 +2201,8 @@ static bool bnge_promisc_ok(struct bnge_net *bn) return true; } =20 -static int bnge_cfg_def_vnic(struct bnge_net *bn) +static int bnge_cfg_rx_mode(struct bnge_net *bn, struct netdev_hw_addr_lis= t *uc, + bool snapshot) { struct bnge_vnic_info *vnic =3D &bn->vnic_info[BNGE_VNIC_DEFAULT]; struct net_device *dev =3D bn->netdev; @@ -2211,7 +2212,7 @@ static int bnge_cfg_def_vnic(struct bnge_net *bn) bool uc_update; =20 netif_addr_lock_bh(dev); - uc_update =3D bnge_uc_list_updated(bn); + uc_update =3D bnge_uc_list_updated(bn, uc); netif_addr_unlock_bh(dev); =20 if (!uc_update) @@ -2226,22 +2227,28 @@ static int bnge_cfg_def_vnic(struct bnge_net *bn) =20 vnic->uc_filter_count =3D 1; =20 - netif_addr_lock_bh(dev); - if (netdev_uc_count(dev) > (BNGE_MAX_UC_ADDRS - 1)) { + if (!snapshot) + netif_addr_lock_bh(dev); + if (netdev_hw_addr_list_count(uc) > (BNGE_MAX_UC_ADDRS - 1)) { vnic->rx_mask |=3D CFA_L2_SET_RX_MASK_REQ_MASK_PROMISCUOUS; } else { - netdev_for_each_uc_addr(ha, dev) { + netdev_hw_addr_list_for_each(ha, uc) { memcpy(vnic->uc_list + off, ha->addr, ETH_ALEN); off +=3D ETH_ALEN; vnic->uc_filter_count++; } } - netif_addr_unlock_bh(dev); + if (!snapshot) + netif_addr_unlock_bh(dev); =20 for (i =3D 1, off =3D 0; i < vnic->uc_filter_count; i++, off +=3D ETH_ALE= N) { rc =3D bnge_hwrm_set_vnic_filter(bn, 0, i, vnic->uc_list + off); if (rc) { - netdev_err(dev, "HWRM vnic filter failure rc: %d\n", rc); + if (rc =3D=3D -EAGAIN) + netdev_warn(dev, "FW busy while setting vnic filter, will retry\n"); + else + netdev_err(dev, "HWRM vnic filter failure rc: %d\n", + rc); vnic->uc_filter_count =3D i; return rc; } @@ -2695,11 +2702,11 @@ static int bnge_init_chip(struct bnge_net *bn) } else if (bn->netdev->flags & IFF_MULTICAST) { u32 mask =3D 0; =20 - bnge_mc_list_updated(bn, &mask); + bnge_mc_list_updated(bn, &mask, &bn->netdev->mc); vnic->rx_mask |=3D mask; } =20 - rc =3D bnge_cfg_def_vnic(bn); + rc =3D bnge_cfg_rx_mode(bn, &bn->netdev->uc, false); if (rc) goto err_out; return 0; --=20 2.47.1 From nobody Fri Oct 2 12:19:59 2026 Received: from mail-qv1-f97.google.com (mail-qv1-f97.google.com [209.85.219.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4458455178 for ; Fri, 31 Jul 2026 16:37:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785515857; cv=none; b=C0utRhgnPvdNUg3RpDZos1OVi7J5wogjmzfV3xchMd876Al5JICijDe4kuSrYCKtMvM3fQDW7YnODjNFu+xASAMunUQQ0/tShu0nEcprBC1778EzKQKb+hLCTzn3bPSq17Dh9bgcbT29hrMD8f7RDGMmyslk4aMlualpwi1vyiY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785515857; c=relaxed/simple; bh=3C5AABexfvyCLkrRdDNz3236hDARiVl0H4YbD7IuVQM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zc0qv87minoGGMMQbwYxKM//i5gCrrKGWktzuB90Gzfov38NDrQsFSiRwGfmkh6lniFHN9PLqmtE+s8CF+krSN6a9H4XmTDRiKq9JxXgw9HaTNP8drGn8SVmUZfO/jrd4KaQJC6MlaHWM6TP3unikzpHKEcNYGBrTGO36O9VVIA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Xk4z9hld; arc=none smtp.client-ip=209.85.219.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Xk4z9hld" Received: by mail-qv1-f97.google.com with SMTP id 6a1803df08f44-8ef7b7651ecso16108396d6.1 for ; Fri, 31 Jul 2026 09:37:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785515855; x=1786120655; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=O3+7vGCuus9kHQh7NOEwPhcHzmTaHtnsRvlJx5U3nw8=; b=BrdLRebm3q+dHIURtIsopeG5dFBDdAffw9vhlgNJ9fkDJ8uvLYRe+7kwExcy66oFGj Wpj/J0+u06DREfgpKplYDvPGtKZv+obJw3firgtJebcVpxWA2UXGBNygbgeoMiPy2b+C aup8uRlBqm1C0eDgaY4Z8Hd/s6YsY7N0snw7SffFW1YSVcKxEBqh8gTobrLC5syrOQnj OPuSA/eoqQJDavpkCJFWhQTyrdZhi1tDJ+dc7qoxxsGGuQB04laUwBDQc6toJK1YDN1M WGhLIpmP3qbaPINd8WeXPUq4EAq9ull+KMtlAvm3eUx3IG6cTXnfUUt/lDQ2GZ4DYco9 66yQ== X-Forwarded-Encrypted: i=1; AHgh+RpWbXLboBEYo2u2WEP94C2vOYbi8roHx40hig7bder2BtjXGXXenRs4jqtLCPuAJgtTG/qU3pY2SujWUWQ=@vger.kernel.org X-Gm-Message-State: AOJu0YypW0G7hGzBw1gv9CTmzwnnX9A+Fc5VQFC9wb1ou7Pu/Y4Pnou6 ygAMaCCAb3xuZUAASGws35yL4EuVVjOGFd6y/GdYe/56EGwBkHSL8IspSjDt7GAQO81IkWUvPVg XKL594Whz7ClBef3LkCsR42jcUilllZLL7G+zOp78T5tPLxLRLaUYWTVG7ckeFP8afzgiWc2Sab 4oVbddHkV1F++9csF0niOAI04pzw7MRqEMQ3usHcUTK1qxRc+BValOOEFswE3869GfFkPorAbT5 xmot7kFpAj2jo+OAA== X-Gm-Gg: AR+sD12nVUNlOVss4SgzNgGCHIL/sEFk5NGW5FNJPfXi6PqIDBl+B/JLu6ooX9WbOFh r5lAIBShFxuNZGpSnGxuONMV5DmugDKrsunkSMms0rln9B8xojB6UcBwRPzbkZnk+0WG0LBtfKQ 4QBTLHpu5WHawHzAL888wOjTriQMarzd6HRHhkhaz9pwqoDZguYq9dsGMdCsnCFVy3pWYpRH62k O9ZClKGmy8TvkrPwSJFCaEoxeEW8a+UK66g1asj1YndyqQbe0VjWsjF14IW0jLrO1e7Qun1tCaH ccTqt0lTzePiJUQE+sNwce2DvlvTjfUtMXynxrHMAORI2Sqstxb3cYG6e/+kpDdC2UFlDDpkrZF ZDZwz1DpttlAc7dbgo3N1zxSvIfOKxGtdwcOdsqghAEyl6KPV57kdcMjxjAjRHG44GRb4ZJo02p 5kqOcg8PGH6BwwNFnU9AZoqyUw8UWMhj3KrQ== X-Received: by 2002:a05:6214:415:b0:907:6f9c:3b43 with SMTP id 6a1803df08f44-90849710f5cmr8042596d6.2.1785515854397; Fri, 31 Jul 2026 09:37:34 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-27.dlp.protect.broadcom.com. [144.49.247.27]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-908435aa19bsm1243316d6.15.2026.07.31.09.37.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Jul 2026 09:37:34 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-84a251c2e3eso2815471b3a.1 for ; Fri, 31 Jul 2026 09:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785515853; x=1786120653; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=O3+7vGCuus9kHQh7NOEwPhcHzmTaHtnsRvlJx5U3nw8=; b=Xk4z9hldxtqOJL/7outM1IDQfJXZKsUS0Xn5RZPqMe3wms29cw2EzLmI6CxQv21lII IX4YPZHYBOATPAq0LrhlOnAGgMDADGU+FRBcGkrdb6pLj3pxzif29KcZ38Dzx4xUtFmF 5cv+raJKJVdZ5OGvM3MIQc+VTnOWDJbnmevsA= X-Forwarded-Encrypted: i=1; AHgh+RopvvanlIloRVN/X3rz+xjgRWifYZNKSxt5Nbo+PpKE5uSC1Qs3jud9IfJNKy+8lMfShD/mwskckn9smBs=@vger.kernel.org X-Received: by 2002:a05:6a00:2d0c:b0:848:55a6:fbe with SMTP id d2e1a72fcca58-84ee499d324mr244377b3a.35.1785515853061; Fri, 31 Jul 2026 09:37:33 -0700 (PDT) X-Received: by 2002:a05:6a00:2d0c:b0:848:55a6:fbe with SMTP id d2e1a72fcca58-84ee499d324mr244357b3a.35.1785515852598; Fri, 31 Jul 2026 09:37:32 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84edbe57020sm690127b3a.17.2026.07.31.09.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 09:37:32 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bhargava.marreddy@broadcom.com, rahul-rg.gupta@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, dharmender.garg@broadcom.com, ajit.khaparde@broadcom.com, Vikas Gupta Subject: [net-next, v2 2/3] bnge: add ndo_set_rx_mode_async support Date: Fri, 31 Jul 2026 22:07:11 +0530 Message-ID: <20260731163712.3463362-3-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260731163712.3463362-1-vikas.gupta@broadcom.com> References: <20260731163712.3463362-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Register bnge_set_rx_mode() as ndo_set_rx_mode_async to handle unicast, multicast, broadcast, and promiscuous filter updates via CFA_L2_SET_RX_MASK. The async variant receives pre-snapshotted address lists from the kernel, allowing the driver to issue sleepable HWRM firmware commands without holding the addr lock. Move uc_update detection to the caller so the async path can compute it directly from the snapshotted UC list before calling bnge_cfg_rx_mode(). Handle -EAGAIN from bnge_hwrm_set_vnic_filter() and bnge_hwrm_cfa_l2_set_rx_mask() on the open path by scheduling a retry via netif_rx_mode_schedule_retry() rather than failing the open. Signed-off-by: Vikas Gupta Reviewed-by: Dharmender Garg Reviewed-by: Rahul Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 67 ++++++++++++++++--- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 6 ++ 2 files changed, 62 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index db0e616fc46c..d47eb9bc5b8d 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2202,18 +2202,13 @@ static bool bnge_promisc_ok(struct bnge_net *bn) } =20 static int bnge_cfg_rx_mode(struct bnge_net *bn, struct netdev_hw_addr_lis= t *uc, - bool snapshot) + bool uc_update, bool snapshot) { struct bnge_vnic_info *vnic =3D &bn->vnic_info[BNGE_VNIC_DEFAULT]; struct net_device *dev =3D bn->netdev; struct bnge_dev *bd =3D bn->bd; struct netdev_hw_addr *ha; int i, off =3D 0, rc; - bool uc_update; - - netif_addr_lock_bh(dev); - uc_update =3D bnge_uc_list_updated(bn, uc); - netif_addr_unlock_bh(dev); =20 if (!uc_update) goto skip_uc; @@ -2267,13 +2262,58 @@ static int bnge_cfg_rx_mode(struct bnge_net *bn, st= ruct netdev_hw_addr_list *uc, vnic->mc_list_count =3D 0; rc =3D bnge_hwrm_cfa_l2_set_rx_mask(bd, vnic); } - if (rc) - netdev_err(dev, "HWRM cfa l2 rx mask failure rc: %d\n", - rc); + if (rc) { + if (rc =3D=3D -EAGAIN) { + netdev_warn(dev, "FW busy while setting l2 rx mask in CFA, will retry\n= "); + vnic->rx_mask &=3D ~BNGE_RX_MASK_CFG_FLAGS; + } else { + netdev_err(dev, "HWRM CFA L2 rx mask failure rc: %d\n", + rc); + } + } =20 return rc; } =20 +static int bnge_set_rx_mode(struct net_device *dev, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_vnic_info *vnic; + bool mc_update =3D false; + bool uc_update; + u32 mask; + + if (!test_bit(BNGE_STATE_OPEN, &bn->bd->state)) + return 0; + + vnic =3D &bn->vnic_info[BNGE_VNIC_DEFAULT]; + mask =3D vnic->rx_mask; + mask &=3D ~BNGE_RX_MASK_CFG_FLAGS; + + if (dev->flags & IFF_PROMISC) + mask |=3D CFA_L2_SET_RX_MASK_REQ_MASK_PROMISCUOUS; + + uc_update =3D bnge_uc_list_updated(bn, uc); + + if (dev->flags & IFF_BROADCAST) + mask |=3D CFA_L2_SET_RX_MASK_REQ_MASK_BCAST; + if (dev->flags & IFF_ALLMULTI) { + mask |=3D CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST; + vnic->mc_list_count =3D 0; + } else if (dev->flags & IFF_MULTICAST) { + mc_update =3D bnge_mc_list_updated(bn, &mask, mc); + } + + if (mask !=3D vnic->rx_mask || uc_update || mc_update) { + vnic->rx_mask =3D mask; + return bnge_cfg_rx_mode(bn, uc, uc_update, true); + } + + return 0; +} + static void bnge_disable_int(struct bnge_net *bn) { struct bnge_dev *bd =3D bn->bd; @@ -2706,9 +2746,13 @@ static int bnge_init_chip(struct bnge_net *bn) vnic->rx_mask |=3D mask; } =20 - rc =3D bnge_cfg_rx_mode(bn, &bn->netdev->uc, false); - if (rc) + rc =3D bnge_cfg_rx_mode(bn, &bn->netdev->uc, true, false); + if (rc =3D=3D -EAGAIN) { + netif_rx_mode_schedule_retry(bn->netdev); + rc =3D 0; + } else if (rc) { goto err_out; + } return 0; =20 err_out: @@ -3202,6 +3246,7 @@ static const struct net_device_ops bnge_netdev_ops = =3D { .ndo_stop =3D bnge_close, .ndo_start_xmit =3D bnge_start_xmit, .ndo_get_stats64 =3D bnge_get_stats64, + .ndo_set_rx_mode_async =3D bnge_set_rx_mode, .ndo_features_check =3D bnge_features_check, }; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index d177919c2e11..476b5bab96fe 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -561,6 +561,12 @@ struct bnge_napi { #define BNGE_VNIC_DEFAULT 0 #define BNGE_MAX_UC_ADDRS 4 =20 +#define BNGE_RX_MASK_CFG_FLAGS \ + (CFA_L2_SET_RX_MASK_REQ_MASK_PROMISCUOUS | \ + CFA_L2_SET_RX_MASK_REQ_MASK_MCAST | \ + CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST | \ + CFA_L2_SET_RX_MASK_REQ_MASK_BCAST) + struct bnge_vnic_info { u16 fw_vnic_id; #define BNGE_MAX_CTX_PER_VNIC 8 --=20 2.47.1 From nobody Fri Oct 2 12:19:59 2026 Received: from mail-yw1-f227.google.com (mail-yw1-f227.google.com [209.85.128.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 136204562AC for ; Fri, 31 Jul 2026 16:37:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785515862; cv=none; b=uSbUQ2Kd6InGJfie0el6IuSTQjQsO4c7LK7p3BCvVTSwIBLaCMH/aJmik15A+tDzSyG0OAcUESuxBmAj/iR9GkIq5UQtiS8VXskvs6mROaQWV2uLf+NbypmcrOpQF2QCsljfWcBAduF7QAYEY4tuSHEWJKOKmfNQAaBobGc2rHQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785515862; c=relaxed/simple; bh=/AHuTK/EWIh6mSL+YYtp1VcqATQuiVubR8zEMFzuA3o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cnPlJBfviUqdlfuo+Wv26ffAltAw5ZSuDZKkgHjbNlCuHRSKPjddRVKLvlcTxFym2id4G9t27AD829IQWAkEVp2Hl1w3UqNsD3QNUgUgt8HKBi/ldH3XBgjdXruDsnKqmhlrJJEDsjqz8zNsDjtsrs8YwWKelMN0Z9JD1uNIiLs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=hqVRRmbV; arc=none smtp.client-ip=209.85.128.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="hqVRRmbV" Received: by mail-yw1-f227.google.com with SMTP id 00721157ae682-81e9d8f3289so17386547b3.1 for ; Fri, 31 Jul 2026 09:37:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785515860; x=1786120660; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lRdwnNt6x86Uy4JXaTIBlaSrTz+xz9fM5aVZPxECWm0=; b=T4nbQnSeGBR6q+ro5yoKuKQNdbY0ea1gr+9Zp9/fhVpQM8HAVwSOfXju1ASD+9ghBC SPlZmwcMGJWNRgp8AfT3MTOHsrTsUgfKuVi0qSUVrm8ZLCGlRJ5pHGifel+pPdMi8BVe DDspMSZrdWnD3wYZHKrrfFeelnUKeGxezHVnhfe1g++hrpUDQbH1ILle2/7Jxm/fTg17 rqmWsKFzLpa8It3A3HbX8yS4Dlwdw1kGrR1TLgn53oBNnJAaUJCBkhpDE6ab9DBKeZc8 Ghu21WK9XEEj79f/wwQixOVZRdTEy9bQZ2ZD0lNPPZkQCpA+YTfJv3xAmYnqf9nTXX4H Ta4g== X-Forwarded-Encrypted: i=1; AHgh+RqX7iv9RkD6w/vcjChgY9JBYRsJrHmgx3ijBW1Rq68EB2h/R9D6aM7SvmiNQlrThoo2t8sbod17byLBYsY=@vger.kernel.org X-Gm-Message-State: AOJu0YyWARHYs2z97dqInTVEcM8Z9S3PwxSzF10yQhCDcex6WIKnzBpx 5MrF6z+KaRAcKChBL1/K1zpctSQD94F2B8IbgsHxxKDTcr0pS/H3XinuSq/NUHVYI67OUBxhkSp KFbtG4lCOP+PoykkSzDkK7cVax5FHQasgkewrFcaZngcvPvmNJsihs/hDPrhVutKzfLV0EBiPJ2 s65POXFIHpRZaDUlDT/g9i8WU7y+abvQ4NXcyv8GLrGcatofoE9/3j4GlDH+OVRR8ERX+xgkpCV 1c73dHnbF022v2PhQ== X-Gm-Gg: AR+sD12fFHPqEqtWyOd/98mF3aYFF+oHBoYXgWSHMBFTp4pS1rl0QnOxZmZN4lqXzlT 05Cr5mJwWSDkGQ5X/w0GI3bGnmH6PcE/L4CwpfziCCy68werordGR4A1k0pE9gpZtpsLGH4KoUt F5Ger7kT66uTNojIjQBrrt6AE6C5XLJcgvoINrVAUCj4cli9VlBMeG475VZngWNbGm16eRWyRRE oPBjZYxvhVvwp4kR9/MAuKsAfd5t8FrMjsk3IQLa3oQT6n0wGsovCXr3j30+jZk/WrumlkYPaC0 Jb5pjTKVFrlBK8jI8H+YoFfH8XQiAFrqn+iYKZ6rmC3TAcXbZbjOkfN6W2UyTEAP4tD35ZBuRul xS8j3gO/HtfGFUqB6r3aXslc3lWr+FATdOvVX34mmsrgiNvG3GF75/c5crqUFAzIOwcZWimw2fW wL70lVHnr2JJWONCGHHUtpUmyetsDskhCvLQ== X-Received: by 2002:a05:690c:6506:b0:81e:45a6:bd52 with SMTP id 00721157ae682-81fd4c7f0e3mr6403267b3.34.1785515859801; Fri, 31 Jul 2026 09:37:39 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-27.dlp.protect.broadcom.com. [144.49.247.27]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-81fcd0add7asm921607b3.16.2026.07.31.09.37.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Jul 2026 09:37:39 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-8486c3411c8so1595127b3a.2 for ; Fri, 31 Jul 2026 09:37:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785515858; x=1786120658; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lRdwnNt6x86Uy4JXaTIBlaSrTz+xz9fM5aVZPxECWm0=; b=hqVRRmbVi5Y2FiopOcDQiIB5Jucu8w45pd1ytRkWV4AVD8SKDl5MXtj/3S624TdE64 JQRYDN/hk1IWVDDNu3gRkXCGnA/zLWtC4AmHDdlj0HiLMHe1X0SpZoUW25x73vsByBiI CUhMHQUucUhAkLL+VG6xK3dbvohkf6p/D9wGU= X-Forwarded-Encrypted: i=1; AHgh+Rpx0rUzXRRRUitZzj92OG7UlUUVlNjqPikvO2LRY98CxyNEHPrH7K4/0+9FSCrsnC5nO5PfTp4dJ4qFVKo=@vger.kernel.org X-Received: by 2002:a05:6a00:2e85:b0:848:2f7a:2e5f with SMTP id d2e1a72fcca58-84ee49a5970mr282214b3a.78.1785515858448; Fri, 31 Jul 2026 09:37:38 -0700 (PDT) X-Received: by 2002:a05:6a00:2e85:b0:848:2f7a:2e5f with SMTP id d2e1a72fcca58-84ee49a5970mr282178b3a.78.1785515857974; Fri, 31 Jul 2026 09:37:37 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84edbe57020sm690127b3a.17.2026.07.31.09.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 09:37:37 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bhargava.marreddy@broadcom.com, rahul-rg.gupta@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, dharmender.garg@broadcom.com, ajit.khaparde@broadcom.com, Vikas Gupta Subject: [net-next, v2 3/3] bnge: send hwrm for interface down/up transitions Date: Fri, 31 Jul 2026 22:07:12 +0530 Message-ID: <20260731163712.3463362-4-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260731163712.3463362-1-vikas.gupta@broadcom.com> References: <20260731163712.3463362-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Firmware expects HWRM_FUNC_DRV_IF_CHANGE on interface down/up transitions to coordinate resource management. Add bnge_hwrm_if_change() to send this notification. Signed-off-by: Vikas Gupta Reviewed-by: Dharmender Garg Reviewed-by: Rahul Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 32 +++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index d47eb9bc5b8d..c2e865f8d9c4 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -20,6 +20,7 @@ #include =20 #include "bnge.h" +#include "bnge_hwrm.h" #include "bnge_hwrm_lib.h" #include "bnge_ethtool.h" #include "bnge_rmem.h" @@ -2864,6 +2865,24 @@ static void bnge_tx_enable(struct bnge_net *bn) netif_carrier_on(bn->netdev); } =20 +static int bnge_hwrm_if_change(struct bnge_dev *bd, bool up) +{ + struct hwrm_func_drv_if_change_input *req; + int rc; + + if (!(bd->fw_cap & BNGE_FW_CAP_IF_CHANGE)) + return 0; + + rc =3D bnge_hwrm_req_init(bd, req, HWRM_FUNC_DRV_IF_CHANGE); + if (rc) + return rc; + + if (up) + req->flags =3D cpu_to_le32(FUNC_DRV_IF_CHANGE_REQ_FLAGS_UP); + + return bnge_hwrm_req_send(bd, req); +} + static int bnge_open_core(struct bnge_net *bn) { struct bnge_dev *bd =3D bn->bd; @@ -2871,16 +2890,22 @@ static int bnge_open_core(struct bnge_net *bn) =20 netif_carrier_off(bn->netdev); =20 + rc =3D bnge_hwrm_if_change(bd, true); + if (rc) { + netdev_err(bn->netdev, "bnge_hwrm_if_change err: %d\n", rc); + return rc; + } + rc =3D bnge_reserve_rings(bd); if (rc) { netdev_err(bn->netdev, "bnge_reserve_rings err: %d\n", rc); - return rc; + goto err_if_change; } =20 rc =3D bnge_alloc_core(bn); if (rc) { netdev_err(bn->netdev, "bnge_alloc_core err: %d\n", rc); - return rc; + goto err_if_change; } =20 bnge_init_napi(bn); @@ -2927,6 +2952,8 @@ static int bnge_open_core(struct bnge_net *bn) err_del_napi: bnge_del_napi(bn); bnge_free_core(bn); +err_if_change: + bnge_hwrm_if_change(bd, false); return rc; } =20 @@ -3157,6 +3184,7 @@ static int bnge_close(struct net_device *dev) =20 bnge_close_core(bn); bnge_hwrm_shutdown_link(bn->bd); + bnge_hwrm_if_change(bn->bd, false); bn->sp_event =3D 0; =20 return 0; --=20 2.47.1