From nobody Fri Oct 2 12:25:56 2026 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBD1A3DEAE3 for ; Fri, 31 Jul 2026 13:21:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785504089; cv=none; b=S+glR09+OXLLSSLlRxhSnPa6potzKa3T0/i9NyABEMt1mf5KwcAti31rwtMDPBgPsirjRzi0QvahKPBcgc+A7+JihYxi6jMNoPJe16SdF9ovXXuUprLfIlIN3hTrANf4M5/3Jyjp1k9xjnlsCoFWz9oXeuX5g3MqILH1f2MNhxE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785504089; c=relaxed/simple; bh=lPdoWeeyKj9fSYT1nyRXwOHG+zy531mjImV5i72oVKs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=K0Sp5ayQgLrVsufq2atTa00VCxqP8YTIW6TW9lNeB/POsdld/155iCSamqwL0dZ+slmUdQ0Zyoom3WN3i++agK4Q7C7dLnMoVZaJSz37v4rLZA2rJ3XVkqHZxQrOcoPW6FX1L4V5go4si6ygnp9hV04I73TzTy4Tqxfb1lkR96U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eVaZh9E7; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eVaZh9E7" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-69fe1df830fso194369a12.2 for ; Fri, 31 Jul 2026 06:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785504086; x=1786108886; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=FYERtEQAnWQOlIECqIVTadIigrKOp3Tps8nppRp0o/k=; b=eVaZh9E78yYp31SErsSQOMEC8qnIi6AVX1OE5exjq2MYeXyvvP3XA8pjBT2/xpSgpe unTBQwgzsJmyXBBupdlQyOivUF/POVED4BrdMcsFtRkAHu/jRkhsE0I8YboTURzlDNx8 yrDygROHy4wwTAeoTNrG7htXKCS2iox6eHw+p8IRcKWsDo5J5NFYoiEwd9eSkizVPhiO Dg7cwE6wTbHwRPKCrTcrvfSquJjHcu7+1f33D2D8+viSoz06MFr8tbLtLzIRWPMPh081 tcUS3hvkcc/eVQYGV4IZKEwrB3LwwEaYRHFCEmPNYQ6sM0Omx7sDB7Og/AyLvYnzA0+R Hikw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785504086; x=1786108886; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FYERtEQAnWQOlIECqIVTadIigrKOp3Tps8nppRp0o/k=; b=XZk2oDI/eMHTVvDlZEBW4A6ogqymiOWgmpwVfPDtvA9vv+KAFIiQyB5Ihgi/5wl3QW 0rQW60Z4Yl/Op2mdu4RRPuhDh+kRzduzj8/g01/4taBfk978cyZthvdRJKiZiFonulFo M4YtdDzqJCW+zw2fSsbIS4EKoRk3mJgPLeBgB/X5Ir9SHy2fKdCZHUIWIN2cXOUg3AaJ hkFy6BApWSlPPFAD/qhnL7NsOq/Gl8EnHCbxXlRqom+NcMJrUDJYsAEcRGimhAiYNyZZ mlQ2XR/Qkc7nRaRSnbzY5xoH0qnIlu/SCBR4BvPUuMRhBUc7MVNBl/LkEy5/pgzOC2w9 Lhsw== X-Forwarded-Encrypted: i=1; AHgh+Rof0hd1MyPEar4DjLMJrfP7H4ezXZfheV+vUy54dQNh9amBKjulZqRNtF3hcxOR7RL8zTeKDsPiUGfxooM=@vger.kernel.org X-Gm-Message-State: AOJu0YzU7gesCwCoNxnMgkSgFOfQYf+SjrZH3uBjHH5sJi/TI9MpJqWY Ty2n57Tio4DXpNN3xMKtWm2TtvIGlPozZYFQvAP4GgKn0vU5Ot6rdTMa X-Gm-Gg: AR+sD12/38QbAr7JPC2/PV6i+9onv+mV+a6NoPyYTV1aGTTwZbGWXG4zEZhGO/jvR/j WyoBiN2J3sUmg3bZFaqCX00RIRU2BEtfb6h1RJaonp+G0BWjhuYvkJ9uwOGdk0dfix+tvi01LMI smXU5mSVSaRN3tBD3kBdW0AJCeNGcDpb83BMtK6yDjV2UIWRUgv9QsFikMr97kQcOpu0sJCWf0O NpNiPwiuaUxtubDSnPPMcrmbp1FRqHQiMDjE9cSWynjPxWNE4fXcOZS8kgnUNeLTzXJh6dwQqzG Bi9dBFQTuq9meHmSOxrRWFZ6jqiSX86E5AKz6WrFJmlMSq9Wnv2dG61ELBumteaU3+iEHIQetuy j3D2xI2l1ieSgOEIlUFRow1UYwinWtCuH7ujDYLO+7vfWXzCZlo4Nqs1KoM+QuAsoBtmLTWFfTA jV9owbdVHeEd+kgkkjGcIJZBsicjDQB2auFoCX829oglV+4z/TkCPc3EuCIQSJqulBjNs5K7Enn 48idxdNDzTO51J3rVEE1sm8WdXrvSNMQNXtq/nAjW5X638/Fu+wby6+mPP6xDOIC9IwJmSxNTbP 9K1IvLC74RmaFA== X-Received: by 2002:a05:6402:4287:b0:68e:4c0:f59a with SMTP id 4fb4d7f45d1cf-6a098d2b24dmr1467405a12.2.1785504086003; Fri, 31 Jul 2026 06:21:26 -0700 (PDT) Received: from fedora ([149.3.87.76]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a09c664713sm1548846a12.30.2026.07.31.06.21.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 06:21:25 -0700 (PDT) From: Giorgi Tchankvetadze To: Kevin Tsai , Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Giorgi Tchankvetadze Subject: [PATCH] iio: light: cm32181: return zero after writing calibscale Date: Fri, 31 Jul 2026 17:20:48 +0400 Message-ID: <20260731132048.199946-2-giorgitchankvetadze1997@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Giorgi Tchankvetadze The write_raw callback is documented to return 0 on success or a negative error code. However, the IIO_CHAN_INFO_CALIBSCALE case returns 'val' (the user-supplied value) instead of 0. Fix it by returning 0 on success, matching the behavior of other calibscale implementations in the subsystem. Fixes: 971672c0b3cc ("iio: add Capella CM32181 ambient light sensor driver.= ") Signed-off-by: Giorgi Tchankvetadze Reviewed-by: Joshua Crofts --- drivers/iio/light/cm32181.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c index 2590fc8fd154..b32a94028f09 100644 --- a/drivers/iio/light/cm32181.c +++ b/drivers/iio/light/cm32181.c @@ -368,7 +368,7 @@ static int cm32181_write_raw(struct iio_dev *indio_dev, switch (mask) { case IIO_CHAN_INFO_CALIBSCALE: cm32181->calibscale =3D val; - return val; + return 0; case IIO_CHAN_INFO_INT_TIME: ret =3D cm32181_write_als_it(cm32181, val2); return ret; --=20 2.52.0