From nobody Fri Oct 2 12:20:16 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E32D936DA0D for ; Fri, 31 Jul 2026 12:55:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785502554; cv=none; b=N89fpotDpRWYxuDDdEsIn0chtqHa6kufm9LZn184fnMTJd8vDM/eLEITy6b1gpa+4Pn/lCWe+GFRWgxDx7apknjsFxrMigsu5RVZiz1Tudw/OdJQmVp+hGKh721fqEP6T++MxTxyfYD1cquj3xEWVzZLsu758R5/7MGSrukmmr8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785502554; c=relaxed/simple; bh=Vy/xxsu07a+RzvXUAFm5BKVjHO8gES2Oy+eDy1kDoQg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=L4yFncDZ0s1ATRvrbX0M2ZsVRasdrFSz+HPdwzr1hoaD4JREYh6sRjC6MVB11ZlYBSeiikr/vfPGCLXLGSjZDhSI++gIkUBYizlnzz23FR+ihB3rkhnndo78HaT7HddDr4eXvvLWIxNpIMG3dXDJ4CQ4Ytc3LVbfQrLbw9PYb+k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ITfMsx4N; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ITfMsx4N" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2cf50c6f235so10236595ad.0 for ; Fri, 31 Jul 2026 05:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785502552; x=1786107352; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=sj6Ckv5iD9HLK/c7N60xodU3sNZOHZjF0NQQRaKqqos=; b=ITfMsx4Nsdro8HhnleTIALSPViKHIIhRQrPWyHBDznraN3eGf7zIBNoFUy5xlb0STH mn8jnxTnX6yhfqmQaNLfmbxCdbU2dbGyXp0PpBqbmYREKNLVTNO4Tkwrpu8rMm0oobV+ FkU7PEPHda7R+J8Ge2S00yYOZAFhiuy7flWWYTcPLFl4FmOMOfse31ZNUJBKZZp8hCoD m+VGzwoHZfeMBpHTXERkHqfTf5MMj4KbrYX0fq7Rmrfbja6RP2jn/h3t9dFCq4yoXQxz ym/bkNMf1MAmCpU1qbJnaNjKBRc7ELGaBbzExJedXmDQITqV+AvVxolvnOnLQvPfPNvO rbNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785502552; x=1786107352; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sj6Ckv5iD9HLK/c7N60xodU3sNZOHZjF0NQQRaKqqos=; b=nhiFAzYIOqx4YbICsYX38w6OY7Lfu2GnthDouM5DXSyXEWc1lsrqmqU9i6EeeGv35b 1YGLw5ORYCGUzrrOOU3Rvf0fbI+4CQSPn112K2IYD5pR3+HkQd9EJ614CwpmsaloUmjZ TGzv++vFfoCyqB9TyWF2exrfLXNrIKqcdaWvBafg9s0JeNk2Jsp+UMGzMrCOvLyZm5YG lnB81DAz+2xuD+Goq98l33fJNpD7EDzwX9cp4Tzup9q/2id++KxP78i1UgFGZyk7j5ca 9PT3izXtYkqTb6MMGCxj2hnl94bu3SRySohXaRcxN39LiwIXYt+Gh96jhbDcD9xPsApf znbQ== X-Forwarded-Encrypted: i=1; AHgh+RoEefFOII6Mdr55+hLl9jVSQ4Zo8Yc2i09/OrEMtgxS8i1RTBJ5O8TkBhr/4F3jQmFkUrTxSd55L8ZH8ts=@vger.kernel.org X-Gm-Message-State: AOJu0YxqH9kw4MCenJRWIWwMcPzOA+FO6XnmYnBqKT3LvYRYCjsfSTya aJO92VslrYkq3HvivI1ISrxyepY3lLl5//w66bwHIW85ilCY4kotTt+R X-Gm-Gg: AR+sD12rstBXNyGditCum8zuUk3Ud9Qc0bpPtfpXV3H9eL5gzuOZ3MCcU3qbtB4P759 qRUP/Rl8q2aLdCnsIVJ0y0gDQ6US9CxA/r1vvh8/J64NrOQUKNXPruJhATt88cMWY+uVYFmBHm8 XI83aTT4hAc9x9F/DbAqMvkis4fslRAGLMg1rJLNviWxust5reSfKyOoMnhBCVjNncRiwz+8fw5 ZkfKndmX80yoUvCFkEhHgzTDLJON7lihDZjkzLgydsqppAyOevYUmmVXxXbIyYCkP1km3h22TJU SMKgjFMCIIpoWIsqtwzK2M+MDmvNhURW3aacNeM0bBGB9rirLq8sEgxJzRx8aaf6n4Dz2mqxD0C I8rTaLF4Rw7FbuG6d5qobOyEzvFw07LWmDpcGCnqNOBqnMczXk3A+Awo/1bjTIeFeiwrOgW1PsF FjmqoPcDMg/eN5csybm9/yqdh+ZutccJFA58bcoHKJ+IJ2w2Uh+3OZQx0qrJKcBdtw50TKYS0+d /3Y X-Received: by 2002:a17:903:4b4c:b0:2c9:d88e:f996 with SMTP id d9443c01a7336-2d046d6d47fmr19650765ad.9.1785502551976; Fri, 31 Jul 2026 05:55:51 -0700 (PDT) Received: from ahmi-PC.. ([2401:4900:88f4:3366:cce1:8fb:2c26:b414]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd4f0f0sm5720699eec.2.2026.07.31.05.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 05:55:50 -0700 (PDT) From: Narasimharao Vadlamudi To: michael.riesch@collabora.com, sakari.ailus@linux.intel.com, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Narasimharao Vadlamudi Subject: [PATCH] media: i2c: imx415: Fix control error handling Date: Fri, 31 Jul 2026 18:25:42 +0530 Message-ID: <20260731125542.293895-1-ahmisaranrao@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" imx415_set_testpattern() accumulates failures from cci_write(), but drops the value and always returns success. Return the accumulated error so V4L2 reports failures to userspace. The VBLANK path also returned immediately when programming VMAX failed after pm_runtime_get_if_in_use() had taken a runtime PM reference. Break out of the switch instead so the common pm_runtime_put() path is used. Fixes: d5df1c7f3f83 ("media: i2c: imx415: Convert to new CCI register acces= s helpers") Fixes: 3bcae55ab96a ("media: i2c: imx415: Add read/write control of VBLANK") Signed-off-by: Narasimharao Vadlamudi Reviewed-by: Michael Riesch --- drivers/media/i2c/imx415.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c index 0b424c17e880..c3b22b238ea0 100644 --- a/drivers/media/i2c/imx415.c +++ b/drivers/media/i2c/imx415.c @@ -686,7 +686,7 @@ static int imx415_set_testpattern(struct imx415 *sensor= , int val) cci_write(sensor->regmap, IMX415_DIG_CLP_MODE, 0x01, &ret); cci_write(sensor->regmap, IMX415_WRJ_OPEN, 0x01, &ret); } - return 0; + return ret; } =20 static int imx415_s_ctrl(struct v4l2_ctrl *ctrl) @@ -720,7 +720,7 @@ static int imx415_s_ctrl(struct v4l2_ctrl *ctrl) ret =3D cci_write(sensor->regmap, IMX415_VMAX, format->height + ctrl->val, NULL); if (ret) - return ret; + break; /* * Exposure is set based on VMAX which has just changed, so * program exposure register as well --=20 2.43.0