From nobody Fri Oct 2 12:24:37 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 017683264C8 for ; Fri, 31 Jul 2026 12:34:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785501277; cv=none; b=temYBtMFVXZWqJfD5O75UJ56982l4tq/4w9gEnE1JVit262HZPwkkcMjCR1O4bfWvmQgbXt3s1RN3Bkga13zXxhau373/j9ntBLA2OfTnpqfjbFDa0xiwTmh+G7QT7uw+B34Uw9312KkvV58RTgG6c67AgDLAqd5sZ+N0ZaLYck= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785501277; c=relaxed/simple; bh=Nh4PFm11HLdYfdaHE+StxaZNZMR/hpsrLROctxnaWoY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=n5A7VCHAfloBTNqPpH+X9RnnT4Uk2M2pfcahIVS9WTeu+m0bawH652hZKSxkMPm+Fix8spQzcG7Ag16ZurZ1FT7yTuwjjYyNBcHUD9LSIko+VgKnZ+z8MNBxLaQTDkRJ7QcTlHo98X+b/XqsV81jt/NtF91XRVq9C5fKDvIO1CA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sibhL1LE; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sibhL1LE" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-8486672f03cso1126790b3a.0 for ; Fri, 31 Jul 2026 05:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785501275; x=1786106075; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=F8nuVI+qLwkDAX0IRPSjr+eNe4USoFr7whaO483gFLM=; b=sibhL1LEJcsWzdteX16452xdHdOk+NMUHtO9oAayxXRe3JaUUSBs67Eh80WSHNPYbt VoRAzbNe5CnRceo1Xhf/iyfxwp6RJM3R8jsR31rWMJZY0ZtxN2fNt+QK7eu5m41I1E2R yagoB4RutI4ZG6taeF1XY/qXpIpuA7EwW8NaREa6gOkq3VA2KwCvE7lSEDjCv8QD8yWk fng87fxVvoN562Dc5Ggd45qeliS5lJx7BPuV1LyOt/VBJtZjK/iabqHlonS3nouRL81g 7eo2ZLtViM0CJ/TlCKDJI3OEOtRKtKW1XU72hAUZGL3WcuwOhljOrJZUDyJTIiZUg6jr wmBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785501275; x=1786106075; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=F8nuVI+qLwkDAX0IRPSjr+eNe4USoFr7whaO483gFLM=; b=FEFD6HKJUNyg2feTV86aB4YzVizw3zXsLtiHnUoTCKQzczJoOYOo4ehejF8ERQnPX+ qjeChmx7fElOMsHRcTmgetIYqtB+I1lS7giz6EVd2XUWxbKKg3ZiPCGgYRlZZcscHIzH H2BxBvzo8ejMePg/mudN2UuQSo8QuZL35dob0TtkctwsO7Aqd31BW2jWIREV6kQ65JTU kJByZBJkWzEbhOirQGnt1nL+A1ac+M+wev2rFSBmUP8/+tNQG9LylxauGXAvYv1eg6+T qDN0WTqu8dK3VzWaJDyzXg/pgY5hq0xRdQjEGgAt8mcCfKp5xwNvg+cVk4xAFzOcq3Mx hvww== X-Forwarded-Encrypted: i=1; AHgh+RqQztetSVDKZyMSWqneYTcfeLFDGBnCG+GvvDYoqgcCzJY1LJ+NsKojw2JSVvoy2O2Wu04ZQ3HL5fgrLZ0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5hYCSOOOImDT5ZHL6BmJaukrYHKOhApuYex4L3uygb7JtEJvQ BhobL8aTAWj1fXl6mu2JtmmNjnY42h/WAq91zA2t7H+QIfe246rkxPfY X-Gm-Gg: AR+sD1109esPhe0VKtZ+0D3KEcss8F9rr3oJFtQmpmEq5M+Pe9tKsdFSRJcM5FgSFZv GFoYGQho8oTa5UTNI0+MjZQeaCsPFs9lsdfMK3AabgQzFz7KwwYZiblWavR7EgmghUwvejjnFbm UMdIo/oI8QKjAG1YZzNX05zeXaIxqVizdqvRg0bsCWtzWV/1d5y28tuCpYajNXHRTr0VMKsGPUS smNG4374p9xBhnNdwBaGH5cLrzmerrssi5ojixUUEZv5mCXEnL8mh0jQ8j/tk+Mdu/S5UzWXslQ M7EYZzRNOp4YDb6j0+CbYqAD2ZMP5yB500RqGoM4jCy1d1eD61Zxfr/Sp/9SVAjugZ4wOzlsGwT gLfzM6ZsWTxgAIUFvi568c++n7dZsbKlTpUdQmqG6haOsv/WrFByGEFrcLvCrlvNuDV0pNwHbJK dOwc1uJioeHXLrXIYUHY/XICv2eOw54e5EhzTlbXCfuByHJPy8G72To9QAJeDh81NuvUmhP09Cb oXjKw== X-Received: by 2002:a05:6a21:4d8b:b0:3c3:91f5:82cf with SMTP id adf61e73a8af0-3c91b30eda1mr1743755637.46.1785501275101; Fri, 31 Jul 2026 05:34:35 -0700 (PDT) Received: from localhost.localdomain ([188.253.118.67]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbe39ea0a73sm535109a12.23.2026.07.31.05.34.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 31 Jul 2026 05:34:32 -0700 (PDT) From: Eric Wu To: vkoul@kernel.org Cc: pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, ckeepax@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] soundwire: stream: validate slave port properties Date: Fri, 31 Jul 2026 20:34:15 +0800 Message-ID: <20260731123415.34070-1-kunjinkao.jp@gmail.com> X-Mailer: git-send-email 2.48.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" sdw_slave_port_config() validates that a port number is within the generic valid range, but does not verify that the Slave exposes the port for the requested stream direction. As a result, an in-range but unsupported port, or a valid port used in the wrong direction, can be accepted. Use sdw_get_slave_dpn_prop() to perform the direction-specific lookup and reject unsupported ports before storing the runtime configuration. Signed-off-by: Eric Wu Reviewed-by: Charles Keepax Reviewed-by: Bard Liao --- Changes in v2: - Explain why the generic range check is insufficient. - Perform a direction-specific DPN lookup and reject a missing entry. - Drop the fallback that skipped validation when both port bitmaps were zero. Testing: - Locally compile-tested with GCC 9.4 using allmodconfig, W=3D1 and -Werror for x86_64, i386, arm64, arm and riscv64. - SOF CI was temporarily unavailable. Bard Liao manually tested the patch on SoundWire hardware. The same revision was reviewed and merged into the SOF topic/sof-dev branch as commit 54c1da4: https://github.com/thesofproject/linux/pull/5849#issuecomment-5141207403 drivers/soundwire/stream.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c index cbf7bd3d4e7b..e85025a5aea0 100644 --- a/drivers/soundwire/stream.c +++ b/drivers/soundwire/stream.c @@ -1069,14 +1069,23 @@ static int sdw_slave_port_config(struct sdw_slave *= slave, =20 i =3D 0; list_for_each_entry(p_rt, &s_rt->port_list, port_node) { - /* - * TODO: Check valid port range as defined by DisCo/ - * slave - */ if (!is_bpt_stream) { ret =3D sdw_slave_port_is_valid_range(&slave->dev, port_config[i].num); if (ret < 0) return ret; + + /* + * A port in the generic valid range may still be unsupported by + * the Slave or unavailable for the requested stream direction. + */ + if (!sdw_get_slave_dpn_prop(slave, s_rt->direction, + port_config[i].num)) { + dev_err(&slave->dev, + "port %u not supported for %s\n", + port_config[i].num, + s_rt->direction =3D=3D SDW_DATA_DIR_TX ? "TX" : "RX"); + return -EINVAL; + } } else if (port_config[i].num) { return -EINVAL; } --=20 2.48.0