From nobody Mon Sep 28 06:35:55 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3420F3C1D72 for ; Fri, 31 Jul 2026 11:18:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785496728; cv=none; b=CKDrA2U83axtThAMlEZco3bHV186+gXzCujyvjqOkHOYj1Cd8dgknpQFTWtEdFnnP4IhEH3HAUCEXd/7SDNn/SdPbWs1quBDqYhlfwMWCskyQi3hK7oBQkvFpoiRdpRdI9MvqKaNVuKlCOUp8TT6DXbICc8+MCREf43gJTWe4Wg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785496728; c=relaxed/simple; bh=7PTOqVvzsFOLPjp/g0lIUzItIHwrlERamhJyz3IQwyM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=W90xV5CWyGZcZeI+g4uMkQz8ijs2CI7xFF28WYTsc6ZN9lxZFyxJYQbMC5juNM1zvh/N6fmP7yUEYl9xVDCx8jh7tqtSzUOcH4cvl7fZLM4NgGawHtni7Xp/xxrifrGvhLNomnKPYpcCrTolwyO5BglcbHskGbUqo3SVDap8NdE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=Ipc6bAWB; arc=none smtp.client-ip=117.135.210.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="Ipc6bAWB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=Mj rd8bbwxSZ0QnBilVvAQFYg71SC/QaMqNrvLQDFIKk=; b=Ipc6bAWBpVPThOVMvc zuQTU/qc0A40dwNZv0WhstzbaInHCaRn0KPJ4f+DKaPqApgrFqn8TuwXcvfMKbK7 MVBVYygwSb0gqbaT+P3FupoFQFOMLa6hMYJHknKADw18ramN/llPKCueN22BhiYK fU4PETst5arw6VYuZ/Bu43maQ= Received: from localhost.localdomain (unknown []) by gzsmtp2 (Coremail) with SMTP id PSgvCgB39ZZLhGxqEmm3JA--.39364S2; Fri, 31 Jul 2026 19:17:31 +0800 (CST) From: oushixiong1025@163.com To: Thomas Zimmermann Cc: Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Shixiong Ou Subject: [PATCH v2] drm/sysfb: ofdrm: Fix is_avivo() constant comparison bug Date: Fri, 31 Jul 2026 19:17:29 +0800 Message-Id: <20260731111729.703116-1-oushixiong1025@163.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PSgvCgB39ZZLhGxqEmm3JA--.39364S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrZFW3Ary8Gw4UtFy5GFWfXwb_yoWDCwc_WF y0qrsrGrykJF1kuw13uFWa9ryakayY9FZ7G3Wqg393t39rX343Z347ur9Fvry2g3WxZF90 v348KF4YyFn7GjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUbxu45UUUUU== X-CM-SenderInfo: xrxvxxx0lr0wirqskqqrwthudrp/xtbC-Qvo92pshEu-VgAA3J Content-Type: text/plain; charset="utf-8" From: Shixiong Ou The is_avivo() function has a logic error where it compares a constant to another constant instead of checking the device parameter: (PCI_VENDOR_ID_ATI_R600 >=3D 0x9400) Signed-off-by: Shixiong Ou Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/sysfb/ofdrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sysfb/ofdrm.c b/drivers/gpu/drm/sysfb/ofdrm.c index 819aed466727..1d95df522ad5 100644 --- a/drivers/gpu/drm/sysfb/ofdrm.c +++ b/drivers/gpu/drm/sysfb/ofdrm.c @@ -238,7 +238,7 @@ static bool is_avivo(u32 vendor, u32 device) /* This will match most R5xx */ return (vendor =3D=3D PCI_VENDOR_ID_ATI) && ((device >=3D PCI_VENDOR_ID_ATI_R520 && device < 0x7800) || - (PCI_VENDOR_ID_ATI_R600 >=3D 0x9400)); + (device >=3D PCI_VENDOR_ID_ATI_R600)); } =20 static enum ofdrm_model display_get_model_of(struct drm_device *dev, struc= t device_node *of_node) --=20 2.25.1 No virus found Checked by Hillstone Network AntiVirus