From nobody Fri Oct 2 13:10:34 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3EFA3E9C3C for ; Fri, 31 Jul 2026 11:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.2 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785496387; cv=none; b=kLS6ln59dFN8V1BtOEEWSDfL70p7TL18WQWwWdTssV8EfVZeDVSrKeKLIIdFN3sMyxmo6cn6V+vAaVQRkhwRPbXhqPFJD6DKzQ5oDyWZtFZ2PPqUCeUWvPB/ULlYsRNgmfBbMKodLcPEs1yM4dSoHs4wJTa48fLeSOFuhJrx1xs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785496387; c=relaxed/simple; bh=Qc/c4yoXKcp4ee+/wB1jctrJSzgKwXVzm3vCcrwBcSM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=vEUFfQ4YqNW5Bmr8Xz2jlG6mVovORhdNDeZie7u7h8w7cTAKIUQ/36cyV59BOm5a441NR9DzL4Alym7ZqsHc1fPwCRR9xMWUgufhwMA6TdNwRtKiWBt7Af2Tmh7I+h6+5NbwaiyaXgZyqPIEAq3ubn7dxpuQGRXYU+0GuUPtb3I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=Y7ua6z21; arc=none smtp.client-ip=117.135.210.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="Y7ua6z21" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version: Content-Type; bh=INQWhOLIhCHtGcOk61iUZgio4nHSvbrA+EjdpS+Q3u4=; b=Y7ua6z21gHLh+UdDXB385Bz0ojkBPgHYOfDiMWy2WXeQanTvddMy6tXSpM3RLH H+19vGfrgScZm/KDDUF5p3Oyk5Z3r8lSO8ER3HPV/jTMfJkF0qYUv/xOC+IUsWtd djEYZ1hjKEGwyDNrgA3hGlqrFywF6ucIyswos/ZFs1xTk= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-1 (Coremail) with SMTP id _____wDnTwD8gmxqtQ_iMA--.5689S2; Fri, 31 Jul 2026 19:11:57 +0800 (CST) From: oushixiong1025@163.com To: Thomas Zimmermann Cc: Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Shixiong Ou Subject: [PATCH] drm/sysfb: Fix atomic_disable to use dst coordinates instead of src Date: Fri, 31 Jul 2026 19:11:55 +0800 Message-Id: <20260731111155.695390-1-oushixiong1025@163.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Add_By_Label_Mail_Nextpart_001" Content-Transfer-Encoding: 8bit X-CM-TRANSID: _____wDnTwD8gmxqtQ_iMA--.5689S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7WFy8tF15tr47uw1rGr1kGrg_yoW8XFWrpF ZrG34q9rsYyws0gFWDCay8try3Xa95Jw4xKryrCw4S9wnYyFy3GF1rGry7Cr4UJrZ5Kw43 ZwnIyrWDJ3WFka7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j8J5rUUUUU= X-CM-SenderInfo: xrxvxxx0lr0wirqskqqrwthudrp/xtbC4h2VpGpsgv2LXQAA3h --Add_By_Label_Mail_Nextpart_001 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain;; charset="utf-8" From: Shixiong Ou drm_sysfb_plane_helper_atomic_disable() constructs the clear rectangle from plane_state->src_* coordinates. This is inconsistent with drm_sysfb_plane_helper_atomic_update() which uses plane_state->dst \ufffd\ufffd\ufffd the destination rectangle already computed by the DRM co= re with panel orientation applied. Use plane_state->dst directly, matching the approach in atomic_update. Signed-off-by: Shixiong Ou --- drivers/gpu/drm/sysfb/drm_sysfb_modeset.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/sysfb/drm_sysfb_modeset.c b/drivers/gpu/drm/sy= sfb/drm_sysfb_modeset.c index d2de29caf89e..18466de886aa 100644 --- a/drivers/gpu/drm/sysfb/drm_sysfb_modeset.c +++ b/drivers/gpu/drm/sysfb/drm_sysfb_modeset.c @@ -380,14 +380,10 @@ void drm_sysfb_plane_helper_atomic_disable(struct drm= _plane *plane, void __iomem *dst_vmap =3D dst.vaddr_iomem; /* TODO: Use mapping abstract= ion */ unsigned int dst_pitch =3D sysfb->fb_pitch; const struct drm_format_info *dst_format =3D sysfb->fb_format; - struct drm_rect dst_clip; + struct drm_rect dst_clip =3D plane_state->dst; unsigned long lines, linepixels, i; int idx; =20 - drm_rect_init(&dst_clip, - plane_state->src_x >> 16, plane_state->src_y >> 16, - plane_state->src_w >> 16, plane_state->src_h >> 16); - lines =3D drm_rect_height(&dst_clip); linepixels =3D drm_rect_width(&dst_clip); =20 --=20 2.25.1 --Add_By_Label_Mail_Nextpart_001 Content-type: Text/plain No virus found Checked by Hillstone Network AntiVirus --Add_By_Label_Mail_Nextpart_001--