From nobody Fri Oct 2 13:11:24 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 533B434EF07 for ; Fri, 31 Jul 2026 09:41:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785490918; cv=none; b=DyWMhnReVNax3MGYyAQMXrW+9ZYML5nLvO3DWgFCQuxKs6l/5eEEZYvGzDfBdPwH1Pnw7uytiPOcYeEEWe7x0Sb9zutp3opN0pn3zwEDka2eNYDyeTX9ihxbFLhl75UVbI/p/EwVhtt59gkevmoaOg7dOGkarb8fjDb8YcVurUk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785490918; c=relaxed/simple; bh=tFubRax+MZtom/XKrJueDLH6hyxYVkfxIndfMFMlN50=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Srsf6WSSSqpGn/REKM71kIiYZBTE/i9DQVctJpQ776k4hCa/Khhkb/81tO0WjQkW7gNd2tF0OoIgzUJcsrpB/s2JUksVRLcWV4aUCKkYOoOhw5xW5Fvhxm46zMKfOlPKETjzjBmLrkW+tRTi9/hLBU+E1aaWeWu2CprAKpcsdAE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 0d5ed6068cc411f1aa26b74ffac11d73-20260731 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:a5f57544-9df9-4891-87f4-541aad19b3f3,IP:0,U RL:0,TC:0,Content:0,EDM:25,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:25 X-CID-META: VersionHash:e7bac3a,CLOUDID:adc4faf56fb77f26a2ccdb6a84aa5eac,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|850|865|898,TC:nil,Content:0|15|50,E DM:5,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA: 0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 0d5ed6068cc411f1aa26b74ffac11d73-20260731 X-User: gonglinkai@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1035839986; Fri, 31 Jul 2026 17:41:49 +0800 From: Linkai Gong To: linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org, Linkai Gong Subject: [PATCH] macintosh/ans-lcd: check ioremap() return value Date: Fri, 31 Jul 2026 17:41:44 +0800 Message-Id: <20260731094144.1820681-1-gonglinkai@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" anslcd_init() used ioremap() without checking for failure and then called anslcd_write_byte_*() which dereference anslcd_ptr. Return -ENOMEM if the mapping fails. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Linkai Gong --- drivers/macintosh/ans-lcd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/macintosh/ans-lcd.c b/drivers/macintosh/ans-lcd.c index fa904b24a600..6ea7fb8666f7 100644 --- a/drivers/macintosh/ans-lcd.c +++ b/drivers/macintosh/ans-lcd.c @@ -168,9 +168,11 @@ anslcd_init(void) of_node_put(node); =20 anslcd_ptr =3D ioremap(ANSLCD_ADDR, 0x20); -=09 + if (!anslcd_ptr) + return -ENOMEM; + retval =3D misc_register(&anslcd_dev); - if(retval < 0){ + if (retval < 0) { printk(KERN_INFO "LCD: misc_register failed\n"); iounmap(anslcd_ptr); return retval; --=20 2.25.1