From nobody Fri Oct 2 13:04:00 2026 Received: from mail-pj2-f0.google.com (mail-pj2-f0.google.com [74.125.227.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 359C7367F21 for ; Fri, 31 Jul 2026 07:06:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.128 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785481592; cv=none; b=mIIcSqHGwulPPmnFYO3Nj5ZC3YosvfCzIr0to5Qwx0uNDH326sUv52ZGPw5e9WEbh5X9Z/A9DpYBfCCcK7If8sYBXyFDNglAuA+/qZSqUWaAVLo1i7JE5hEBBPWRrTQHw/XRbRXrBQNOWy4rnzsnLS5VOZE04Ks4uMlQN5b2jTo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785481592; c=relaxed/simple; bh=bmbAN0joM0QSQlBsr+1XRr4e0QuytSVMbBJ5jv9uc0Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dnfAqVis++h+31dyieY8hpgMQoWBONuwAQsilKwIqyb+kIhLb5IRb2C9+s2iOe4zQn3u0ziET7i26ajsPPa8xwodD37vlqCjyCVpEw9ZU2trk+sVFIJ/rYQm21xLcldeyqigx1VK4phwvDxF+7q6XyD0kSRpFn13KH3MGoh0txQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bDswUyj1; arc=none smtp.client-ip=74.125.227.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bDswUyj1" Received: by mail-pj2-f0.google.com with SMTP id d9443c01a7336-2cc7a345f51so4592495ad.0 for ; Fri, 31 Jul 2026 00:06:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785481590; x=1786086390; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/2eeMe4bUYVoR8xJiruE/ZmrCkmBvcANozp9bXajUHw=; b=bDswUyj1YBTD7NhL8+nCF3U10WcOIBHgWqypjhbNUydx2mykMCAr4k/Ey8eoTwS/DQ 2YwaZr55t39c1aRwKFOPVXIZvKVUBP9NcYf2RlBmmIeaWCOZ4RdoW7jq7JXPEKAoSW+E HNT6gPrv1u7WQ2LZ+pBhZXZ7C+n0IXPNN4xMBm583YIZLxusgwtFCeYQb6ppfNM1hVQR TYTBy3tgiqSRA4R/cJEB94L+lWmJKc18rLor5oxqDMcxhv0R6VIVO5QXZ2Dn/Tx6PKiy hU1yzzELLfOVHach5LPXDdJd8xLIzdFZyFfXOqdbqNoIFiyj00nRPiJdR/RFHfCkV06l 1kDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785481590; x=1786086390; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/2eeMe4bUYVoR8xJiruE/ZmrCkmBvcANozp9bXajUHw=; b=FqOXAcQlBkENvZMyehZSz/d8GvNxikSKpQChvrZUbqExxt63soKnFFtgTWM/qubsTB 7H6MsG/tCXQbxrWuZtThYpu+Zl2KsHlo7zgYONwL/0c89NBxxFd1jPOSM9IG3lSHuU0v Qmj2mgXO27i7hWMg6DLl1UeHHet4EC/9Gh2+otjx9MBPcz444ADR289ZNB6/BpBfIEBb FBLZmDYL0kVSpd6qmTl957Hblfy4XWoTq2MOKnQRC9oInvzoA/7qTlbuoeqxaWOiA5wN D5TH5yrAVtISm4xpu4mlz205jxzBLTw0WE0QjBp68m6nMKPqhE0t6sD85IcSHciVCiV7 GvKw== X-Forwarded-Encrypted: i=1; AHgh+RoFili8FaKjbP0NOf/zSEuPMBd+b4CHLeFR4I7s9qcJiV7QY891nubbHj2I/QW+IcNbR8cUQm9V9t4cH3U=@vger.kernel.org X-Gm-Message-State: AOJu0YxQVtjR0XB+0qf/w8d2ERqTLIMt+dt3SI8KifOH08KbiuNUHdxd EKIfOIV2E7mjdYrw5iNWJzRndcLauIIR6rFQ9pGtG/KmQKAmLkuhy1HW X-Gm-Gg: AR+sD13DiakNPKlRISyB0sg1f85LzPmg05ipzQhuyovRdW4N99z0PpzFpYQRPh1TPRt CFG+3ukcXpiQsWOopDxxNwlN25mcs1nGgsX4OYMgVmc+EzQV2zBaK4kCuSMhfHsNF4/b3DyPCf3 ZI6BOLfSrNDh2SHJqF2kMarqc3up+dNbf900z0ux2KN+89pjS29jx9rg/Jk9cv0Jb3qrkbQsr/c 3AGXkU+wMS+HE/lldophm+W6QA2ghCqR8Vjhcin7GKBkaNlMIvlES4NgW+gw47Z03a5JusllsSZ mmI3XEP8zD3E8A//qzI0+ZLTykjvdiYvcPZa2eV5cA6be8tPGBL9GAjDs7VtFKnQ7DNzQ9PqRTm 2S604wEeQM2TBIT3m3YnzO4w/JFMitj1pGEsbiGjKzBoojOcHJPuBP5/3XtVKSBIB4AAIEYW+Q0 TrDn9AU3sBmBSFey1gzyki9/rrNrefFF0m2+6jkH9D+mIPwRSc1OR7VZIeEPd4E43GVWtprDDGX 8s20+d56iPdYeCRycC8 X-Received: by 2002:a05:6a21:730b:b0:3c3:a140:938a with SMTP id adf61e73a8af0-3c91b316892mr899765637.45.1785481590453; Fri, 31 Jul 2026 00:06:30 -0700 (PDT) Received: from localhost.localdomain ([76.86.179.124]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm2589587eec.7.2026.07.31.00.06.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 00:06:29 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 1/3] staging: rtl8723bs: convert mgmt xmit coalesce to errno Date: Fri, 31 Jul 2026 07:05:44 +0000 Message-ID: <20260731070546.20959-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731070546.20959-1-dennylin0707@gmail.com> References: <20260731070546.20959-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change rtw_mgmt_xmitframe_coalesce() to use kernel-style return values. Return 0 on success and negative errno on failure, and update the declaration in rtw_xmit.h accordingly Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 ++++---- drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 16e6c9567224..01512f438295 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1187,7 +1187,7 @@ int rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct } =20 /* broadcast or multicast management pkt use BIP, unicast management pkt u= se CCMP encryption */ -s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *= pkt, struct xmit_frame *pxmitframe) +int rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *= pkt, struct xmit_frame *pxmitframe) { u8 *pframe, *mem_start =3D NULL, *tmp_buf =3D NULL; u8 subtype; @@ -1210,7 +1210,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s BIP_AAD =3D kzalloc(ori_len, GFP_ATOMIC); =20 if (!BIP_AAD) - return _FAIL; + return -ENOMEM; =20 tmp_buf =3D BIP_AAD; subtype =3D GetFrameSubType(pframe); /* bit(7)~bit(2) */ @@ -1341,12 +1341,12 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pad= apter, struct sk_buff *pkt, s xmitframe_coalesce_success: spin_unlock_bh(&padapter->security_key_mutex); kfree(BIP_AAD); - return _SUCCESS; + return 0; =20 xmitframe_coalesce_fail: spin_unlock_bh(&padapter->security_key_mutex); kfree(BIP_AAD); - return _FAIL; + return -EINVAL; } =20 /* Logical Link Control(LLC) SubNetwork Attachment Point(SNAP) header diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging= /rtl8723bs/include/rtw_xmit.h index 917e846e9ce2..31decc210e73 100644 --- a/drivers/staging/rtl8723bs/include/rtw_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h @@ -424,7 +424,7 @@ int rtw_xmitframe_enqueue(struct adapter *padapter, str= uct xmit_frame *pxmitfram extern u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pkt_attrib *patt= rib); #define rtw_wlan_pkt_size(f) rtw_calculate_wlan_pkt_size_by_attribue(&f->a= ttrib) extern int rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff= *pkt, struct xmit_frame *pxmitframe); -extern s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk= _buff *pkt, struct xmit_frame *pxmitframe); +extern int rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk= _buff *pkt, struct xmit_frame *pxmitframe); s32 _rtw_init_hw_txqueue(struct hw_txqueue *phw_txqueue, u8 ac_tag); void _rtw_init_sta_xmit_priv(struct sta_xmit_priv *psta_xmitpriv); =20 --=20 2.43.0 From nobody Fri Oct 2 13:04:00 2026 Received: from mail-pj2-f1.google.com (mail-pj2-f1.google.com [74.125.227.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 540D3374187 for ; Fri, 31 Jul 2026 07:06:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.129 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785481594; cv=none; b=Gt/sOl78xblVZVXLBCa0Il6ek3aRRX7Ml0jjMIJuNHuuJKEPyO1iOFauLlJK5qF15iouhB87MXUm6dN5l7Z2FbW0DK2V56rsfb9vAhQ8xcqPJgVnhz/J7DgngSEwCh6bpRe17Nj09DKB4xanw6Y9+vEDzizySmdF6FQ2aj/M7O0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785481594; c=relaxed/simple; bh=OoXYpZ7Q2fli2l1172p+ihOsLv/pUj5fJNQ7I7ror4s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CFYkljDwyCRVjWuEUrZLsSPpw0sXYol2f74+5UBTUqbajHA6Y0+zViGmAZqNqu020sv27XKlAPZnBIM4359JMT4KWiWxSak8vl/if5AfmhXc4s8orBB6nBYlkgLtzO7y+Cpga6iE+S5URNAa2Vb7hwIjQ0WWzkpLvw5dLhZx0pc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rYJN6DCS; arc=none smtp.client-ip=74.125.227.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rYJN6DCS" Received: by mail-pj2-f1.google.com with SMTP id d9443c01a7336-2cac634f921so1999495ad.0 for ; Fri, 31 Jul 2026 00:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785481592; x=1786086392; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uLP70stMRNJMbiaBki2KwUOdJcZtOnKHT3dQZuqY5Dk=; b=rYJN6DCSHLxIiJiZWtFy6kVI2f7N6GdKCMUx7D5tcstpp4ONuy4gHL6un/LPFCe5Lr HgAqqwmhyZ4WeNejE4/jOuIxFpPnSq2LnrO6EzKJmTmhEJDulR85MISe5ys3aY6zs3HR hnJObtCMd13pdpi2ejwT+RQRUvvMcnHXpThJIdf/ZJOCO5T59K5Pu8Ez9KYSBaCvF865 kuDrt7A/RnNq/kLP02oZg/RYpmWXgfh6oFH9kxhId/eqH2pwA/C1a9gzajVvtE+7kgY5 3UVujWEovRO0IHMdjIZCMGwDURrdgwh1ZeUFN1AHQPFU+y+p/NHQmq2FJAY2XQbl8bGa +xLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785481592; x=1786086392; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=uLP70stMRNJMbiaBki2KwUOdJcZtOnKHT3dQZuqY5Dk=; b=ZoYlgiGmLvymUbU4WYiKMm6XGvTuWV8BoFUL0+V7/vy7bVCRlnX3IqlhQ/etU1no7+ MesEr408vfVhfKX8LkuZU7P/GZ7CTGR+PwuLwyP7SJEISyQMgyUIN52iiB6epSFFmqou tk+ExaJwIIzB4saC0FYzEs8WipHZoF+fBPTpxipdMQ0eAB+FFiwhaTYNmBIQ3omgWk1u Hp4lW4l5x6YMyFEEls51eaKnF0l+gQTELKLWzjrM1IEHGoTjZfbtYtCtkaKaJW/0zHm6 uovJ9uftZ+m8NpP/4eaihefebRzNmzrXz+Hep2PeTZz8EVXMvVAiiCaqnSTLVFw4LEjM ohyQ== X-Forwarded-Encrypted: i=1; AHgh+Ro8vr5WoZZt7IXc9RSsq9OHgzy8bod7NOC+tAS7CkKKGJpJJsVmlOVtxhqIVQNIkggUAWnCFm+xh0Hilh0=@vger.kernel.org X-Gm-Message-State: AOJu0YxOia5D8ZqXzGQR1VuyYl8E0iWCxIwybocvsdN46m9mFsJKKzR0 9yLKhQi1TR8U2dW56KVVbNtqZmSAZ6+6bVMG4XHdWRVhSATaVc5EhlqhltA3dgYU X-Gm-Gg: AR+sD133QCna8njO+EqwRtbIi6A0ouihBasFve55LZ/iRCYlGatTOG8Ys82c8I+Jt7Z ACUz1qq+pccplp557RvGfuFnga562Pb82Mbba8agSkJAC2Br87f/zbXeROlZbLXb9X6g0nnUfWW CsUu963AhMt7MSAHkSz+EuZLF36ublubMbHdftZO4eCOUNIZOEPQh+qfq1PCvdPF+yMTN8NUVlj AYtNj9j0L4x2/qFbTwQt50J+oyFLZDQS3UoZ73TukAOOH16/oo4Fc2Q6Rp6Vn3kQ/UIogy0FnSV pVeJyb727EnocjAg4zIRc6Uu/fRHXItkZ89SQUc0i8EGBJHOIDnN3Rihx7Je7zKxg8jM1riSZbv Nc1iuJ2w9kJzSzvH7moJ03H4NUInEeSIbf3KGW4+OPSxGAGa7V3k0tAKRCmT+TO0fMnqWVm/2m1 RWno122XCnl9Oi6NffoaSYunFYMeLgB90U9qBbowWW9vskKoyy7XJ5858oWE2g8EENwQ7QAKGzv rx3JGFFHrc0zNHlrwZ+ X-Received: by 2002:a05:6a21:1b84:b0:3c3:7e9c:e292 with SMTP id adf61e73a8af0-3c91b111233mr815924637.25.1785481591592; Fri, 31 Jul 2026 00:06:31 -0700 (PDT) Received: from localhost.localdomain ([76.86.179.124]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm2589587eec.7.2026.07.31.00.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 00:06:31 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 2/3] staging: rtl8723bs: propagate errno handling for mgmt xmit Date: Fri, 31 Jul 2026 07:05:45 +0000 Message-ID: <20260731070546.20959-3-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731070546.20959-1-dennylin0707@gmail.com> References: <20260731070546.20959-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert rtw_hal_mgnt_xmit() to return errno-style values and update dump_mgntframe_and_wait() to translate the result back to the existing _SUCCESS/_FAIL flow. Update the prototype in hal_intf.h accordingly Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++++ drivers/staging/rtl8723bs/hal/hal_intf.c | 9 +++++++-- drivers/staging/rtl8723bs/include/hal_intf.h | 2 +- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index f5ab94a2d0a0..0027f9333738 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1990,6 +1990,10 @@ s32 dump_mgntframe_and_wait(struct adapter *padapter= , struct xmit_frame *pmgntfr pxmitbuf->sctx =3D &sctx; =20 ret =3D rtw_hal_mgnt_xmit(padapter, pmgntframe); + if (ret) + ret =3D _FAIL; + else + ret =3D _SUCCESS; =20 if (ret =3D=3D _SUCCESS) ret =3D rtw_sctx_wait(&sctx); diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index 2caade1a8bdd..1443875d1369 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -115,8 +115,10 @@ s32 rtw_hal_xmit(struct adapter *padapter, struct xmit= _frame *pxmitframe) /* * [IMPORTANT] This function would be run in interrupt context. */ -s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntfr= ame) +int rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntfr= ame) { + int ret; + update_mgntframe_attrib_addr(padapter, pmgntframe); /* pframe =3D (u8 *)(pmgntframe->buf_addr) + TXDESC_OFFSET; */ /* pwlanhdr =3D (struct rtw_ieee80211_hdr *)pframe; */ @@ -130,7 +132,10 @@ s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct= xmit_frame *pmgntframe) pmgntframe->attrib.encrypt =3D _AES_; pmgntframe->attrib.bswenc =3D true; } - rtw_mgmt_xmitframe_coalesce(padapter, pmgntframe->pkt, pmgntframe); + ret =3D rtw_mgmt_xmitframe_coalesce(padapter, pmgntframe->pkt, pmgntfram= e); + + if (ret) + return ret; } =20 return rtl8723bs_mgnt_xmit(padapter, pmgntframe); diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index 8a85e8419e47..1b6b348435cb 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -197,7 +197,7 @@ u8 rtw_hal_check_ips_status(struct adapter *padapter); =20 int rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame = *pxmitframe); s32 rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe); -s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntfr= ame); +int rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntfr= ame); =20 s32 rtw_hal_init_xmit_priv(struct adapter *padapter); void rtw_hal_free_xmit_priv(struct adapter *padapter); --=20 2.43.0 From nobody Fri Oct 2 13:04:00 2026 Received: from mail-pj2-f11.google.com (mail-pj2-f11.google.com [74.125.227.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F1CE3750D7 for ; Fri, 31 Jul 2026 07:06:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785481595; cv=none; b=D6dTvHDRACzwzoqYn/cdUOkxlOl70QtUU8uAW/L+k4xC7RQ+avGbX+P2JsOwoN5f0o50vW26yatGzPoGJ9IFTUlb2fUMMiWsXNblP7Mf3utzge40GwXb7S/yBisoe0ovtSitmHq7TXHJy7pnTcbduI9IkbGSeWgbZINh+ppv+n4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785481595; c=relaxed/simple; bh=kgH+Unk5jFkTbBsM5Q2SSn1BubqFz43+w/4uwL0fHis=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d/KRwQEhpJeHNk4suWRpUZZlSQYUoyC+zxEho1X4DWaERH4NACW9MNlVjFDGgNOrmR4I+gnPZzSIr+Hu5GAJMzX1qrMIsNHvHli2z7p9G+NYCGpV/fU31lpoeUY896k5HNdpELvxZwBW6LuzLuPq0cgm9X81W/r3lNgS/KRlhxQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CY92gw/w; arc=none smtp.client-ip=74.125.227.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CY92gw/w" Received: by mail-pj2-f11.google.com with SMTP id d9443c01a7336-2cf02ecb572so5592975ad.1 for ; Fri, 31 Jul 2026 00:06:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785481593; x=1786086393; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rfHEkC18UILYbYSRhqGinmN4Aeu2njCcFmZPfPXNvtQ=; b=CY92gw/wJ4wbXjDl6tON3ZDQPISRIRthw+JmtQ5M4zh0nx7xIer4AHZTxKoTF8Mx6Y zFxk2Ua0TYN8BmqOQR1BFbm0LWtJIs1KFvecNZoxcpF9AtvA4DdND0ipvxAYr7ObFP/Z VFQapicUQ1483dXpOHnp9VFjGMVP9els8rHcY98o6hFoQqz7GRtbh9/lxayI1YAn1Qyp l7bOLCRT8vGLl+ebFzvx2xt/rzkw8u/X1gBVo9EoCtA7XHSFIeS10pmmaMP2pqDJghrb MbTPIPLwmlkSsg+S5RuKRgYSv3GPXP0ycNlzN7AatCvGkQs2dY9I/lgReBnqj22xlMVN T8Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785481593; x=1786086393; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=rfHEkC18UILYbYSRhqGinmN4Aeu2njCcFmZPfPXNvtQ=; b=HGyTe6vMGc6gLAOMM7AxYIB9jdG/ASlp8cTZLeyxbRKdpe7D6wgi8itUIFp078cXkF 2tLlWsarEMzHo3Gv4dW672RiJlSmZPz/gLYm+sMeZt6LGt4Ee1oqrues5b+yQ/F3rLwo eWyt8J1FGov0/is4PyBCrCk6R4Kner3Y4vG86FtozEvSvz+QPEOchlnzy3MjpKjitpkA Sc+FiUnt5XzmheiUBXufiBRvPx0XOOhFR298pUt8NssARDhKeDlWW+cOeMq1olOQv2zI KMMR7ioMOkAoC124SvPtd+bEW8Ek1fELD1HqwAJUX3kYVbYSp/a400cMxp59ZjKvxwyu 619A== X-Forwarded-Encrypted: i=1; AHgh+RoH0Z7HeLgGe3RSfz2C+b9WZdhiHjIdif6cHkNKMl4MizSxAU8Z4tSLKY8Yq7Z/XlKqWXiQ+2SaWPVgAss=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9lbRXaeO+4fio3ftdBMViicGqyugpYCmcU2KhCyD2mMrDLl4F NE+GvaCdEbcwoqxCv56byNau5+O5Ya34Ci4Ia0d6DcTkRZvaLrnPl8JR X-Gm-Gg: AR+sD11eI9PMYW2a+PXVaynRB7/fAehJX1xu//TDSLWrh1SYGb642YNYjTzWBC4bdyU zaJrJOnpm5pbpR6znLjUBaXMkhyyHvXM5baZfSeIHes9khwvKiluTLhkDQfF6QIydvlYQBpuq4F 3HValgHUIt55UYWUjdPD44O6b/31qbSEmb4J0Tg+V9MvuuLtIWxW5jZPhats3HZACLcvkGVJfdH 0eXV6qBO5FacT/0kKpMJfvdY1czDQpkbhpciq1L0A8K0YsnlBto3I+GyncjnIJ3F9ObU1lETx5t 3x5HgPrlPlln3VNAD6oe9vGQlD8Yw/Y4J4P7q5dsIs/j4uBxMN9O6gEAs6tsHHvX/7w70wn5BDk 7TSgojRTNVYfWrwFQIJZb/Hf55DY3f7QuCMZDJvwOBR2TEIAXdVLbeF2nIB4koybbrHNHFjEX5B hHRq4jb/Fizq7aMvMOD4XjwTwcBMQE4CJ9nythHabtuLknlgtvfqn5Kpk70PC6jp0FGIlc5wsAw Tv0HqT2xGswv4hPncbB X-Received: by 2002:a17:903:1211:b0:2ca:5970:732d with SMTP id d9443c01a7336-2d046ebb185mr10052965ad.41.1785481592613; Fri, 31 Jul 2026 00:06:32 -0700 (PDT) Received: from localhost.localdomain ([76.86.179.124]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm2589587eec.7.2026.07.31.00.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 00:06:32 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 3/3] staging: rtl8723bs: convert dump mgnt path to errno Date: Fri, 31 Jul 2026 07:05:46 +0000 Message-ID: <20260731070546.20959-4-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731070546.20959-1-dennylin0707@gmail.com> References: <20260731070546.20959-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert dump_mgntframe_and_wait() to return errno-style values and update its declaration in rtw_mlme_ext.h. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 13 ++++--------- drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 0027f9333738..da74184fd07e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1971,9 +1971,9 @@ void dump_mgntframe(struct adapter *padapter, struct = xmit_frame *pmgntframe) rtw_hal_mgnt_xmit(padapter, pmgntframe); } =20 -s32 dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *p= mgntframe, int timeout_ms) +int dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *p= mgntframe, int timeout_ms) { - s32 ret =3D _FAIL; + int ret; unsigned long irqL; struct xmit_priv *pxmitpriv =3D &padapter->xmitpriv; struct xmit_buf *pxmitbuf =3D pmgntframe->pxmitbuf; @@ -1983,19 +1983,14 @@ s32 dump_mgntframe_and_wait(struct adapter *padapte= r, struct xmit_frame *pmgntfr padapter->bDriverStopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); - return ret; + return -ENODEV; } =20 rtw_sctx_init(&sctx, timeout_ms); pxmitbuf->sctx =3D &sctx; =20 ret =3D rtw_hal_mgnt_xmit(padapter, pmgntframe); - if (ret) - ret =3D _FAIL; - else - ret =3D _SUCCESS; - - if (ret =3D=3D _SUCCESS) + if (!ret) ret =3D rtw_sctx_wait(&sctx); =20 spin_lock_irqsave(&pxmitpriv->lock_sctx, irqL); diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/sta= ging/rtl8723bs/include/rtw_mlme_ext.h index 0c2bd51b6bc2..c2993e442d80 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h @@ -533,7 +533,7 @@ void update_mgnt_tx_rate(struct adapter *padapter, u8 r= ate); void update_mgntframe_attrib(struct adapter *padapter, struct pkt_attrib *= pattrib); void update_mgntframe_attrib_addr(struct adapter *padapter, struct xmit_fr= ame *pmgntframe); void dump_mgntframe(struct adapter *padapter, struct xmit_frame *pmgntfram= e); -s32 dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *p= mgntframe, int timeout_ms); +int dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *p= mgntframe, int timeout_ms); s32 dump_mgntframe_and_wait_ack(struct adapter *padapter, struct xmit_fram= e *pmgntframe); =20 void issue_beacon(struct adapter *padapter, int timeout_ms); --=20 2.43.0