From nobody Fri Oct 2 13:04:16 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C539735837E for ; Fri, 31 Jul 2026 05:31:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785475871; cv=none; b=F5JcwGN9tsO0Ju4oavNOWFwO/F4iNrZxCc/3iU5K0Hs5SD2UcAQI/PudXlwHbBx/U/IJRiDbkYMV8IWhBI3fDKl0I+67ErVB7VaDPdR/p6LhSXTxFN9ZjWrYeC4K2axm0awoLklEo86CIzOhAw24wrjyLVwEYdNx4O4wNd9WhZ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785475871; c=relaxed/simple; bh=6vY8NDrgvGnvBWnzXnTiMiRP7yvJ++bDYFqiPWAdZCY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=rEuXVhDNEiallnAwL3p0w5vi0XF47IpfI3tDxc3UfnvgxzK7jFyheoavklkyr7idxtemJsmDL2YbFfIamc7ChaQAVZS01xmFQXuJd4xeltIQPA0BOVq5eBv8ZE5WHgtz+nifaKK6oTi10iUsjjA4SZsKQyTNObif4nKLhFcB7zk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pKBDeRri; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pKBDeRri" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47f64ca1c2dso133360f8f.2 for ; Thu, 30 Jul 2026 22:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785475868; x=1786080668; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WUyp9U7dXdiG+QsLynyvNf4in1b+6GPKTpacp6ZUx0c=; b=pKBDeRrikEnrVsMub5vHpHzodMIHQAQl11Hi1sopXigDv9j0+s5yyrpBHwo2HZ2PSt P7cRuTxJ6y1hLa/2ZMGx4KT0gvMZWVo1K+EQJPmjtrIbdk32fCZREgagfTpmtsvrq7dj mHwXwe9BzaSo3RggXS/46TE/5LYDeimwKkqkIUSMLyTCzvD0icvVIHCUkrYVd5NKhVNZ YzKkjXtu90zCREAG7tnfsy0fGXj2hOT7KdvuzOz34bp3a8q3cyJlo8mVuFNa8PWHhZcM LPLvw8uQTqtvPZvyp0uSbfzuXXiLsU+W8sMtB7bf1rmNAvabetX+cv9oTLBwzzDdRuNW vDAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785475868; x=1786080668; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=WUyp9U7dXdiG+QsLynyvNf4in1b+6GPKTpacp6ZUx0c=; b=LB8h/la5NxSh6g0DB3eezRndfMT2INWh8CqdAo4i2XMwnu8QJt+3TsmcOLjBT2YHG+ oLGMksBQcaPttzr3PAjO96zRpYdleAJxY7Fc28R5gzfcD+vH2CtLU4AT3nkSL8BkC5kr tuTHqzhbNm8UxsH4D7QNQIrzUP3BD3C7+kQN1BMYaYb2dzW0vEntVHO3bW/aSWt5R4Ia 6N/6w9Qc+/BWref472S0zfI8OdvQ95qb15M4MtnfzvbIXQ6AdW/twtH8QKwvm/ma5sjN G7G0uF/PA1Uaamuk6Hwv5OCVgcbFs6WmnRQG5pW3Jupur2hlna5fL22ky4u7U6zpQG2s +jUA== X-Forwarded-Encrypted: i=1; AHgh+RqDvGegVgR67befu7enxP1SVRb90CCnC3UkjmZ/2LGPfGeArvYCwjK61AQ6H/Z3gDNkrOKyKwKFWOp6K88=@vger.kernel.org X-Gm-Message-State: AOJu0YytuLve690XkZ8MXCQJfyiTV56TLs6VWJz0cb6IVDQa6//fk3ih BZggibST1qWAPj+KNQZoWUrhKh55IDUyqJWtr8413SQM12cBAj+oC9QQ X-Gm-Gg: AR+sD10ZTtta3PX+PmN7qbQ7eN7ftRpnMsAwCtANloJ68Wc/QCbV4DpV7eAJYN2u+Lg nmWjgYgfp9Ym/dNEVDsiBlr8FLJlpHxQcp5hT8329Zik5ZXVyWPL55buwtdEgUNDoqrErUB+rXL 9IejhlnEfgeqjrvFg60T7jwNppwjdYKLiZdP98hoodqPzxblm/up9Kf9mCwVV1K/85VgOs9hvEp yyrFzsGlKpofjkWDyPIkdr/RQOJlceMpI2vU6rdBhrRNUwrxTff2ijmNfrs7LJ+YCo8uJMegTBe J16SdCpIrzHO+aSQULVGgIr7k3X/0ICdfiqmXYn4kQLD0XEaw0Z77PeshEngmzSNyLBpQ2TVoPf ZlD0wA6Jtbf/qqPBG7Xa3ZGS6JtHQkRsF4jR6Iq/jrqGEP/UFMmMN6NDQMMweq6xP37m2kU+ZUa xwUNushX4tVh9S+258Pt0c7Sgu4vb6gRUzBayQNfAsYQZ+VmRT763ZR9k3TW4Q2zZ7nyHoUlQV+ vIDHXSqrzl2PiBPzINJoGWl8vD6CbFpz2/8gndJQZ+/OnODWyDil/oG3e9sHEg= X-Received: by 2002:a05:6000:40dc:b0:47f:9d0e:f8f with SMTP id ffacd0b85a97d-47fd2aea087mr1700034f8f.26.1785475867744; Thu, 30 Jul 2026 22:31:07 -0700 (PDT) Received: from torre-GIGABYTE-B550-AORUS-ELITE-V2 (212.pool95-21-2.static.orange.es. [95.21.2.212]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd456a5a4sm345470f8f.20.2026.07.30.22.31.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 22:31:07 -0700 (PDT) From: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= To: Christian Koenig , Huang Rui Cc: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= , Matthew Auld , Matthew Brost , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev Subject: [PATCH] ttm: Add error handling for ttm_pool_mgr_init() Date: Fri, 31 Jul 2026 07:30:36 +0200 Message-ID: <20260731053047.24503-1-megia.oscar@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The ttm_pool_mgr_init() function can fail, but its return value was previously ignored in ttm_global_init(). This could leave the pool manager in an invalid state while the system continues initialization. Fix this by checking the return code and jumping to the error path on failure. Assisted-by: OpenCode:1.17.8-Big Pickle Signed-off-by: =C3=93scar Meg=C3=ADa L=C3=B3pez --- drivers/gpu/drm/ttm/ttm_device.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_dev= ice.c index d3bfb9a696a7..c880a0430363 100644 --- a/drivers/gpu/drm/ttm/ttm_device.c +++ b/drivers/gpu/drm/ttm/ttm_device.c @@ -96,7 +96,10 @@ static int ttm_global_init(void) >> PAGE_SHIFT; num_dma32 =3D min(num_dma32, 2UL << (30 - PAGE_SHIFT)); =20 - ttm_pool_mgr_init(num_pages); + ret =3D ttm_pool_mgr_init(num_pages); + if (ret) + goto out; + ttm_tt_mgr_init(num_pages, num_dma32); =20 glob->dummy_read_page =3D alloc_page(__GFP_ZERO | GFP_DMA32 | --=20 2.55.0