From nobody Fri Oct 2 14:02:22 2026 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF10729D27D for ; Fri, 31 Jul 2026 01:19:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785460798; cv=none; b=EGawqET38/iwg8F5BlmFVhaIsoEqw3vDuZT6KotyTpDevw+ahxIoFagZ7lfBtpSPUfiAqh5+jpPgcm+HQvAnLpqUpFTLmnN4F9mCMaWDIU6R5pfRzXDPJ88nd28Hz7Nk9VEDGSBbmmjdIQgkPxLhzjDx101BdJyzrIKBRX1lp7M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785460798; c=relaxed/simple; bh=47e8b0WdNaEk4DooyC6qfw7+a4EBXQUIyJCmrzaFF5A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LtmuQMvkW0T82nShNHdSzhjH8XBSd56HZtjFUHoxJ8AQZC2I1jpQ9siBtqfdZkrdQtS9fOcKuq/vvRVwFRh8aIv5943nnzSVTsSa+/d7QCSLwqa7gvUsGKpF1u6bGWqR1IKS3KX3z8ZVMNYUpr/Jzy2WU22Rgu+hlwfNDja5m7U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=gTG3Sioe; arc=none smtp.client-ip=91.218.175.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="gTG3Sioe" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1785460793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wXHPrSho6azgZZFSVUejZWoRGeUy3dDCZgU8B46t7FU=; b=gTG3Sioekhliqb9ChSprbt7Dkp14qN/JzvJmI52pEsnJrF8lwEb2aWMxAweZEbuRSXTFCv eMRVTHUC/tqHtnwPwLrCouppJRylm1tpO+eLjDi7BOL0ataYGH1SJyRKyd0+oICp8crjoz 3Lu/QjqxaBJAI3zUhDN6KbliqOhTdoA= From: Yi Cong To: gregkh@linuxfoundation.org, error27@gmail.com Cc: linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Yi Cong Subject: [PATCH v3 1/4] staging: rtl8723bs: free HalData with vfree, not kfree Date: Fri, 31 Jul 2026 09:18:53 +0800 Message-Id: <20260731011856.2006363-2-cong.yi@linux.dev> In-Reply-To: <20260731011856.2006363-1-cong.yi@linux.dev> References: <20260731011856.2006363-1-cong.yi@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Yi Cong In the probe error path of rtw_sdio_if1_init(), HalData is released with kfree(), but it is allocated with vzalloc() in rtw_hal_data_init(). Freeing a vmalloc allocation with kfree() is undefined behaviour and can corrupt the allocator. Use rtw_hal_data_deinit() instead, which calls vfree() and is the matching deallocator used on the normal tear-down path. It also NULLs the pointer and clears hal_data_sz, making it safe to call here. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Assisted-by: GLM:5.2 Signed-off-by: Yi Cong --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index c43a0391a5ca7..f7ec09310ce98 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -286,7 +286,7 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_p= riv *dvobj, const struct =20 free_hal_data: if (status !=3D _SUCCESS && padapter->HalData) - kfree(padapter->HalData); + rtw_hal_data_deinit(padapter); =20 if (status !=3D _SUCCESS) { rtw_wdev_unregister(padapter->rtw_wdev); --=20 2.25.1 From nobody Fri Oct 2 14:02:22 2026 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADFB82D29C8 for ; Fri, 31 Jul 2026 01:19:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785460800; cv=none; b=D851weeyj6znsLmlC9MANemZLu7Ss9DZ8dA6Cj5lWdVgShPbGyfrG3Qb+5o3Enp9cv2Hbxd1vsMq96tumLkBrMnLvsbaQ+Z/BGwuh79GXpGLUySAPebqtxORuze76N/i71yMVxYRcUp13lZQubIrT+Jyv9/3SAoefYJzg1mxPNM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785460800; c=relaxed/simple; bh=lzpp4ZcV7xUZM+OdKpDiqol9PIFFFRauowiqPTQ6PBQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tJzcE47GuOaA0ukyqsRkqgs0p/DDPmmvZCzzUayb0563ms9q1Cec6GN1QAcVXdLXdQt2Gvy6QX4V8yM4SXcZUlZ90I1mJiH/u/2ioAaUMMN+5dQBd0AyD8li5OfmvkmpbMuM2E+JNJMe9SjMJcbwFet/518WjtRLytlFRd+7G7U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=NG4fY7AF; arc=none smtp.client-ip=91.218.175.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="NG4fY7AF" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1785460795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bMElUg5mvhcb74SmfnOIwi6H8mT79uJYk5mlABd+2Nk=; b=NG4fY7AFGJBXXI+wIqj3vEXTAK3PV7MR4lzUrdyHo1u2kIfp1Y1IBEhGR9WbPDG/+uX1SY 28i04SlotD9ZbfCXDkz0H14OJh+2q7ZxH5YHDR9QNYJq2CFOq3iO3/DMvL+qqBtfpC0obs yFdCh76yrgaGHtWxnIyTpC/rIuAFF3I= From: Yi Cong To: gregkh@linuxfoundation.org, error27@gmail.com Cc: linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Yi Cong Subject: [PATCH v3 2/4] staging: rtl8723bs: fix double free when register_netdev() fails Date: Fri, 31 Jul 2026 09:18:54 +0800 Message-Id: <20260731011856.2006363-3-cong.yi@linux.dev> In-Reply-To: <20260731011856.2006363-1-cong.yi@linux.dev> References: <20260731011856.2006363-1-cong.yi@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Yi Cong When register_netdev() fails, the error_register_netdev label in _rtw_drv_register_netdev() frees the adapter and netdev via rtw_free_drv_sw()/rtw_free_netdev() and then returns _FAIL. The caller rtw_drv_init(), however, still holds a non-NULL if1 on this failure path and jumps to free_if1, where rtw_sdio_if1_deinit() invokes rtw_free_drv_sw() and rtw_free_netdev() again on the same already-freed objects, resulting in a double free / use-after-free. Drop the freeing from error_register_netdev and let rtw_sdio_if1_deinit() perform the tear-down, which is the single owner for this path. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Assisted-by: GLM:5.2 Signed-off-by: Yi Cong --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index f31196f54b3e0..84633a51e2db7 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -754,7 +754,6 @@ u8 rtw_free_drv_sw(struct adapter *padapter) =20 static int _rtw_drv_register_netdev(struct adapter *padapter, char *name) { - int ret =3D _SUCCESS; struct net_device *pnetdev =3D padapter->pnetdev; =20 /* alloc netdev name */ @@ -765,19 +764,10 @@ static int _rtw_drv_register_netdev(struct adapter *p= adapter, char *name) =20 /* Tell the network stack we exist */ if (register_netdev(pnetdev) !=3D 0) { - ret =3D _FAIL; - goto error_register_netdev; + return _FAIL; } =20 - return ret; - -error_register_netdev: - - rtw_free_drv_sw(padapter); - - rtw_free_netdev(pnetdev); - - return ret; + return _SUCCESS; } =20 int rtw_drv_register_netdev(struct adapter *if1) --=20 2.25.1 From nobody Fri Oct 2 14:02:22 2026 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5726C2D1907 for ; Fri, 31 Jul 2026 01:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785460802; cv=none; b=TLkElbVB6TqpmI8xNVdLLy/5saiWCRxbe0YBfs9lIG86OsEqQXx3nls6kzsfgLZNhUlTbrU7YimhuhAppilCVlUL8TWRflCt63JIJkJvJurcHcJLuFEdgEW+4EXUmGX0vz7cuh5oKTSiKKvFXsHRWsEp9oN4vANe3TNFhhmMmhE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785460802; c=relaxed/simple; bh=FcgnHvf/nf59EDdmbipZWrJ+c6ayLiiQbkljh42e7Uk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=i0nuUh0J6TfpvXVkwu/HtnGXz+jPwUhS27VrxkfxmOPqxeB3+D51ahDzVRLKXkg1vU24uYeqOds0NENOOSgATuLZy3dAVWgUL/mKdmQ8h4QTpJHnCyd2jmbb/oGCCZYjzmWw8quYQRdP1X/aY2ksvUrefn3gmgguDRJdx8vkuYc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=OTxZn8Lq; arc=none smtp.client-ip=91.218.175.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="OTxZn8Lq" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1785460798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Afs96YJEbYAMJtEzntjOA/OwDoHOu0CZXDKx9MAXo9I=; b=OTxZn8Lq0aziEnqr/IMeKvehXIUKesnM/ZXg1NIFMyL9NLWagGZUpcTjC+SgHZHFwjQh9x nLUTQAc1IgPi4zWG7jJlFihSGKWcOS0yulB+7gQs/v+u/oWlgct6lSNsiCaL5jgk6+UMJp 6giZCcB2SnsuGUNmvS1mR4hrwBJqFp4= From: Yi Cong To: gregkh@linuxfoundation.org, error27@gmail.com Cc: linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Yi Cong Subject: [PATCH v3 3/4] staging: rtl8723bs: fix NULL deref in c2h_wk_callback() on alloc failure Date: Fri, 31 Jul 2026 09:18:55 +0800 Message-Id: <20260731011856.2006363-4-cong.yi@linux.dev> In-Reply-To: <20260731011856.2006363-1-cong.yi@linux.dev> References: <20260731011856.2006363-1-cong.yi@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Yi Cong When the SDIO interrupt handler cannot allocate a c2h event buffer (GFP_ATOMIC under memory pressure) it pushes NULL onto c2h_queue as a "needs re-read" marker and wakes c2h_wk. In c2h_wk_callback(), if the re-allocation also fails, c2h_evt stays NULL and execution falls through to rtw_hal_c2h_valid(adapter, c2h_evt), whose underlying macro dereferences c2h_evt->id, causing a NULL pointer dereference panic. C2H interrupts are produced by firmware/network events at runtime, so this is reachable under memory pressure. Add a `continue` in the re-allocation failure branch to give up this event instead of dereferencing NULL. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Assisted-by: GLM:5.2 Signed-off-by: Yi Cong --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index b932670f5d63a..e9b1136dbf668 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -1716,7 +1716,8 @@ static void c2h_wk_callback(struct work_struct *work) kfree(c2h_evt); continue; } - } + } else + continue; } =20 /* Special pointer to trigger c2h_evt_clear only */ --=20 2.25.1 From nobody Fri Oct 2 14:02:22 2026 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F1F526A1CF for ; Fri, 31 Jul 2026 01:20:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785460808; cv=none; b=rGh5g9UJiIncBhlefQWftMUDDou9xuX6+TsAuYapUAwTWiAfuUEg9nVpmHvsrOo4UxnA3mE9GZMIAuHGc4Xe/YisMDKNCGf7Ezp21E45eRdd0MVvEZLR6rtDN3NnbMfmfF+AP5o3fBZzJgGPK9T3t0JoTNhn3FWTQxkR5PFgq/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785460808; c=relaxed/simple; bh=/1G65/0RGWqgYt6TvQ0u8uwK//Jr7KOjKUmITCD2xpg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GPSx+mY5MB+aNw6v4JDv7S67PBhO2TygKXHg8nsAr9cRMR+wwru7dPZDeugwfNBq1K1lx9kQvxH8+gN9Nd4WSKZ53mXaqgOtDmFjoYtPwCKhbKixW8gAE+fl6v3MRf8q3hxWOUTLnbL/ZymtrLiE6YdHIVtvPXKiR/hNts/IqKk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=V34RUJJq; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="V34RUJJq" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1785460800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1SjDezo3u50GFBkzPXvGQqu6t8Eum3WQXRXk4DRobfs=; b=V34RUJJqI2WzEzM5jycvNGBPqDWtsNDpx/jqdhrY9CaenAV/W59klc1KZywkNImrB8EFZp exRrl6cW67f4CdV6ZGB8PBNY8GtR+UmhHexWVwi0j9Aht34owXtrErKm7/1Q0sgocH4uf8 OvNq5ACRx3gRb5qPXUqOQ/BkzgaXaUM= From: Yi Cong To: gregkh@linuxfoundation.org, error27@gmail.com Cc: linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Yi Cong Subject: [PATCH v3 4/4] staging: rtl8723bs: fix NULL deref on bcmc station lookup in defrag path Date: Fri, 31 Jul 2026 09:18:56 +0800 Message-Id: <20260731011856.2006363-5-cong.yi@linux.dev> In-Reply-To: <20260731011856.2006363-1-cong.yi@linux.dev> References: <20260731011856.2006363-1-cong.yi@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Yi Cong In recvframe_chk_defrag(), when a fragment's transmitter address is unknown (no associated station) and the frame is not a data frame, the code looks up the broadcast/multicast station with rtw_get_bcmc_stainfo() and immediately dereferences the result to obtain defrag_q, without a NULL check. rtw_get_bcmc_stainfo() (a thin wrapper around rtw_get_stainfo()) can return NULL, for example if the bcmc station has not been or is no longer allocated. Every other call site of rtw_get_bcmc_stainfo() in the driver checks the return value; this one was missed. A fragment with an unknown transmitter address received from the network (e.g. an injected/rogue management fragment) could thus trigger a NULL pointer dereference panic. Check the return value and set pdefrag_q =3D NULL when no bcmc station is available, consistent with the adjacent data-frame branch (the later code already handles pdefrag_q =3D=3D NULL). Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Assisted-by: GLM:5.2 Signed-off-by: Yi Cong --- drivers/staging/rtl8723bs/core/rtw_recv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rt= l8723bs/core/rtw_recv.c index 86c5e2c4e7ddd..ffcee431caf55 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -1146,7 +1146,10 @@ static union recv_frame *recvframe_chk_defrag(struct= adapter *padapter, union re =20 if (type !=3D WIFI_DATA_TYPE) { psta =3D rtw_get_bcmc_stainfo(padapter); - pdefrag_q =3D &psta->sta_recvpriv.defrag_q; + if (psta) + pdefrag_q =3D &psta->sta_recvpriv.defrag_q; + else + pdefrag_q =3D NULL; } else { pdefrag_q =3D NULL; } --=20 2.25.1