From nobody Sat Oct 3 14:53:30 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 520DE3A3809 for ; Fri, 31 Jul 2026 07:57:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785484652; cv=none; b=HGnuiUYsA0xbhcwY6knP3cNMp0fYOGsUmqNi2v9OZJuT+Libyjnc35N11jYwdbTkRawN8+uwqxZmwZzF7XvCkl9q4KkjUnAcbUELtxKUiHidgPOHS/+ayZYwer7lvbsnVK4LGuD2BpUn0K5rm4e4o19mkKpWN3IT67j7XSfIB/k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785484652; c=relaxed/simple; bh=BdtF3ST042y2YchbvBs4t9dLvIHevyY2/0fXOWGkF8g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=A6Rp6YmRDrJVRJ6GjoDsxqGLEpNjURyZ9+abQ0Ui7fLgVyc9lAEGiy4z0ypr6XlEV06K0lNknaRfhlu7PhRhOZw5x4KBtbmEWaRNxyrkcKrr9gAIlQO0fTufTz8ENhfLc5KBfRKp8lz1osYrzbomuMoXGoS6J7uiGo681P/NN24= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Fn1XW7BG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Fn1XW7BG" Received: by smtp.kernel.org (Postfix) with ESMTPS id CF52CC2BCB9; Fri, 31 Jul 2026 07:57:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1785484651; bh=BdtF3ST042y2YchbvBs4t9dLvIHevyY2/0fXOWGkF8g=; h=From:Date:Subject:To:Cc:Reply-To:From; b=Fn1XW7BGOHSKcn6kmXu/llZBM6CUDPJoRAzLYCxVLBgr4+iRG7HWOOFLpWOEjGrDH tifeaH/QofgHURtbxwTW6gQjcPgRem3tq1tJrBO+HeKuYqTb5AKPd6MGVMtqKfJNSf GkE4yTZ34Dekns7ZkaS6pJPgprvxpSWhZBHI1InajUIWxZJga1iHooCz+h5VqwxbxE GVeFfGbcYELTAJu1mOl+bW0ZMFZJAAxX/qbTYj/HAnlIm3KWfX8XmfXsEZEGr0SmZP myQsyATFFNa+loVIqBxoA4AnTc+MqWZuolrf2l6KaoG16Cox9PFzDmUxyTlZ7j9pyV h3SpgihToWDzQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9034C55171; Fri, 31 Jul 2026 07:57:31 +0000 (UTC) From: Takahiro Kuwano via B4 Relay Date: Fri, 31 Jul 2026 16:57:19 +0900 Subject: [PATCH v3] mtd: spi-nor: remove unused NO_OP_CHIP_ERASE flag Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260731-no_op_chip_erase-v3-1-41f101d9968b@infineon.com> X-B4-Tracking: v=1; b=H4sIAF9VbGoC/yXMQQ6CMBBG4auQWdukQhD1KsY0bf2BcdE2HSQkh LtTZPkt3ltJkBlCz2qljJmFYyhoLhX50YYBij/FVOv6prvmqkI0MRk/cjLIVqBarb272846PKh kKaPn5b98vU/Lz33hp+ND27YD+1Y/dHQAAAA= X-Change-ID: 20260731-no_op_chip_erase-500cb8a7abe9 To: Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Takahiro Kuwano , Tudor Ambarus X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785484650; l=3127; i=takahiro.kuwano@infineon.com; s=20250227; h=from:subject:message-id; bh=jprftuHIU60xPd5Dstni2VUPc6HizHvPQXOhr2GB5c8=; b=EMtwEyxS9gBoBD2Qg+w33I764ypoFIdvNiYEtgWNG8lvesztgM1LFxjZo/o2GQ5UjTMNXmEgj f/fTHr0j5aXDzxTJ7PqBgNLMUayHjAPKf74R93jS5EdRZCkzqJ8I+Ph X-Developer-Key: i=takahiro.kuwano@infineon.com; a=ed25519; pk=aS8V9WLuMUkl0vmgD0xJU19ZajdJmuyFBnBfVj0dfDs= X-Endpoint-Received: by B4 Relay for takahiro.kuwano@infineon.com/20250227 with auth_id=566 X-Original-From: Takahiro Kuwano Reply-To: takahiro.kuwano@infineon.com From: Takahiro Kuwano NO_OP_CHIP_ERASE flag is no longer used. Remove definition and references of the flag in core and debugfs. Reviewed-by: Tudor Ambarus Signed-off-by: Takahiro Kuwano Reviewed-by: Miquel Raynal Reviewed-by: Michael Walle --- Changes in v3: - Rebase on top of v7.5-rc5 - Collect trailers Changes in v2: - Collect R-b from Tudor - Just drop NO_OP_CHIP_ERASE and leave the rest of bit assignment as is - Copy to --- drivers/mtd/spi-nor/core.c | 3 +-- drivers/mtd/spi-nor/core.h | 6 ++++-- drivers/mtd/spi-nor/debugfs.c | 7 ++----- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index ccf4396cdcd0..4d868afca2c1 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -1852,8 +1852,7 @@ static int spi_nor_erase(struct mtd_info *mtd, struct= erase_info *instr) return ret; =20 /* chip (die) erase? */ - if ((len =3D=3D mtd->size && !(nor->flags & SNOR_F_NO_OP_CHIP_ERASE)) || - multi_die_erase) { + if (len =3D=3D mtd->size || multi_die_erase) { ret =3D spi_nor_erase_dice(nor, addr, len, die_size); if (ret) goto erase_err; diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h index ba2d1a862c9d..765a8542af54 100644 --- a/drivers/mtd/spi-nor/core.h +++ b/drivers/mtd/spi-nor/core.h @@ -121,10 +121,12 @@ SPI_MEM_OP_NO_ADDR, \ SPI_MEM_OP_NO_DATA) =20 -/* Keep these in sync with the list in debugfs.c */ +/* + * This could contain holes, if adding a new flag use the first free spot. + * Keep the flags in sync with the list in debugfs.c + */ enum spi_nor_option_flags { SNOR_F_HAS_SR_TB =3D BIT(0), - SNOR_F_NO_OP_CHIP_ERASE =3D BIT(1), SNOR_F_BROKEN_RESET =3D BIT(2), SNOR_F_4B_OPCODES =3D BIT(3), SNOR_F_HAS_4BAIT =3D BIT(4), diff --git a/drivers/mtd/spi-nor/debugfs.c b/drivers/mtd/spi-nor/debugfs.c index 288e2866daed..2ba8cbca04c9 100644 --- a/drivers/mtd/spi-nor/debugfs.c +++ b/drivers/mtd/spi-nor/debugfs.c @@ -14,7 +14,6 @@ #define SNOR_F_NAME(name) [ilog2(SNOR_F_##name)] =3D #name static const char *const snor_f_names[] =3D { SNOR_F_NAME(HAS_SR_TB), - SNOR_F_NAME(NO_OP_CHIP_ERASE), SNOR_F_NAME(BROKEN_RESET), SNOR_F_NAME(4B_OPCODES), SNOR_F_NAME(HAS_4BAIT), @@ -144,10 +143,8 @@ static int spi_nor_params_show(struct seq_file *s, voi= d *data) } } =20 - if (!(nor->flags & SNOR_F_NO_OP_CHIP_ERASE)) { - string_get_size(params->size, 1, STRING_UNITS_2, buf, sizeof(buf)); - seq_printf(s, " %02x (%s)\n", params->die_erase_opcode, buf); - } + string_get_size(params->size, 1, STRING_UNITS_2, buf, sizeof(buf)); + seq_printf(s, " %02x (%s)\n", params->die_erase_opcode, buf); =20 seq_puts(s, "\nsector map\n"); seq_puts(s, " region (in hex) | erase mask | overlaid\n"); --- base-commit: 598149737c4965eb8e0b160faed32827a2d9eb77 change-id: 20260731-no_op_chip_erase-500cb8a7abe9 Best regards, -- =20 Takahiro Kuwano