From nobody Fri Jul 24 20:48:51 2026 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012009.outbound.protection.outlook.com [52.101.53.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1C4C4156D1; Fri, 24 Jul 2026 17:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.9 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913600; cv=fail; b=KStAkmFDpuCBB9TOim8xEPIE8sQFlYniIzUtagbbftMJ4XUXcSJqetKmPvKxEin48lFmTg68mGHC3suQzjI2YSQhyAMAX+d5+rlPYsEo1Oc7XJQnh2eKnw87S3mFmKMdJHf0aAgvG5t9YbqgpSDOWlprwhri3Z0ZRrZ3NcTNAoQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913600; c=relaxed/simple; bh=QeaF5UdfjOz2SUB9MwgWOCC6VW81rhHr/gC5dgLbVQA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=C0ji1r32gHldYKYYhLrHr3QBToKNTfOnzURDSobjYj5LiE3ePPrVT0Ah0+NdyP0E8z01CqMp3R/YSvIPgFcDPGcdDlVBTG1HHXTkjajRoJk686nD8xI8OCdzvZb2IPAw29K8JCZDUgxmkjEgbm3T9fb7M1+nI+c7U5VMqCdNKAU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=CRachWqA; arc=fail smtp.client-ip=52.101.53.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="CRachWqA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vSxmb3DJK20uyZzxMLgnJOAKAusy7qQQKY9O+euoHGlm+/KUbjxaORG5+PCQvHPOEj84MFP3yv8mo+y8Ip15oKLb3/Y44flnAv4U04DQFPsIAzc0ESkQqsVViS4EsZqcDaPaGJc5QhluM2NgEgNMoty2z/WlTQNyK1gXskt4yjYajkSSX60o5l2LymUjmBMQvK9cf+kFj/Pqg+KP0C4BFh4dLUAsFL5yksKeZrICikugk3y6MoYd0coYGoYjbFht0UI3FYyPHK5Z6lJMxRAOmTFMKqyHYkV2g3Chn1Divjw2fB/zfcaIob7iDH1Mu5tE8w6e7xdXHuKG7kSUbLUR4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0+N69rB0x5bc9v+iS/VlU143uYpvZu1DlRvNLL4AQIY=; b=LqMm6nMMTX/nF2WU/f+pTqG4HfIRRkQED6Lzh1Pw/0M9TGXpWElqTBib0wsLmccMNTWjjmx6SI27aWxk4EJ8L4fA0m9j6PiNC2livsHVATEzS1DYOIg9XQWNEbhJajYUN1uDCrKJgKjqStb4mUWPrkZpUHE7b6LhthzlKGpJcNENIabRfL1BJdCtuVwlct7ouKXRc4LYuJNj1fjgFhPLKHU5xAkxLO8PE71OZ8ozkQulA6L5Ow+vrQ5KLKcF2leW+9pgjjrtdDSI57bIj8Q55L/PfyZro/whjekj9Tl0MFLzS6uj7MFWIlmNsEfPj1K4JaB0wWmSr0Cj1QCShYj4og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0+N69rB0x5bc9v+iS/VlU143uYpvZu1DlRvNLL4AQIY=; b=CRachWqA4hwjtbyS8p8qecuZFv2if+hxRvsb7oe0oikFvTkhkHVeZ0znXM0rxq9W2wjtwKPVkvhs8vK8bUgUv9Pgv2oUncgr3GGlEhQ0IfZK8Csv0IwodV3nMUhlW6kLZ/goPtLP9SZuuKb1D0AaO/I8bJhnU3GwGcy3/powg+E= Received: from CH2PR15CA0006.namprd15.prod.outlook.com (2603:10b6:610:51::16) by BY5PR12MB4275.namprd12.prod.outlook.com (2603:10b6:a03:20a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.12; Fri, 24 Jul 2026 17:19:52 +0000 Received: from CH3PEPF0000000B.namprd04.prod.outlook.com (2603:10b6:610:51:cafe::50) by CH2PR15CA0006.outlook.office365.com (2603:10b6:610:51::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.11 via Frontend Transport; Fri, 24 Jul 2026 17:19:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF0000000B.mail.protection.outlook.com (10.167.244.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Fri, 24 Jul 2026 17:19:51 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 12:19:50 -0500 Received: from xhdshubhraj40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Fri, 24 Jul 2026 12:19:48 -0500 From: Shubhrajyoti Datta To: CC: , , Michal Simek , Borislav Petkov , Tony Luck , Subject: [PATCH 1/9] EDAC/versalnet: Add NULL check for mci in handle_error() Date: Fri, 24 Jul 2026 22:49:37 +0530 Message-ID: <20260724171945.2812749-2-shubhrajyoti.datta@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> References: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000B:EE_|BY5PR12MB4275:EE_ X-MS-Office365-Filtering-Correlation-Id: d147b1ff-4604-4ee6-3be1-08dee9a7c5b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|82310400026|1800799024|36860700016|376014|10067099003|11063799006|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: VsLszP/MUILfWb1FEl9C69Z/ZUUiK9gQYjV440MC38OPNe4AcXvCzgSy+FIL4DFGrQCyRuEa8ewoZKE7YtKvQ3fd06AMSPE94Fu63VS57cycAdnpholraBWKZvjmYhTXZkxhL9h32qe2VzivxA/EdZLfQhXer6/Z5Ebi3aibxJ9H/ZpQFEIMiRc20lbaSrCkVturueMLdGg0u9kAXNIWdDTRVmWNULK1dnqk91/OEPSDEPlxDh+I/8RrFggLX1dbgedHPHxC2kblKTCHjG/1yGfCaf/NXAZsSvAdMdbjMAumGei5mVjkb6HH3v6Jr/PSAws8/Ux4fEkuPRoace3IKgePirSgerMJN3FKIN+UxEBUOIHra9/QqWatn05lzG+VYbyoAtBrNlktepZ5U3wl5nwflg18ElK+hnp8Ki9RPtAtZDl4vzkdYej7R4Qr/I9DZt8XQWkH1pmLKOxZs9wzJfdhyDccSPI0H6+TUjA41LsSnOaZSQF/B9wt9GPn7s/6K/dEmaN8ZM7aaAz1jsbIfQQkvpIRa0wsIXhXnbK7rZgV3iN+m8mWba2Tu6C90Sq850yFDXjn6/+uZHyNMnLIbeJZ8YQNdb0rwMqjHCdky/dQ8ZqsrFCFLdcrR+sXAZ6J5ZmCgLId8lEII8kOEI044TjZhAT6jF3WxilvCyVFz4nE7yh+vNDC8OuFrp4euNdJzSLbomqyYIqrLA4Bty+zeg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(82310400026)(1800799024)(36860700016)(376014)(10067099003)(11063799006)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LnMlzRLurjp3e65O/Rb6j8+js0+6uw7L/32OCwKCjI2j5dvL6LalEewNaPrSHhzJfHWUxqCotmy7QgGUWOIgnyeUwTQTqPPVsAWyHCPFV/kUX4ndFMtQxMeLDHfH5MqUHKvUlDQ/5l+66zVi+2CFO9BhMNxn4hNGPObbbKGvx6CfDyCwisIQTGQZbk9igvzjhdeWDsihtQ2+UjuEoOgXJvwvwUkFvGGdFWf9BSWd2vhDNkCBSLBzIrcQOXrXZXtX5416xy40b15kiu6Lo0GBS+Uz8eST3sz3nFbwi2pRr+cFxh8RO7g8o4/CAbUSJkXbp8QJLPzNAER4V6GAKx4+bXEjFt1Gfn3x8Y4alBQIwNSFTKx813b8GH0y9VF8owjx3aQkZlCRjuJbtWgyWUo2Y1hZc4l7TQNKQ0jwcy9+IQB+eSVwVlx1/36cPRD7IuHN X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 17:19:51.8453 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d147b1ff-4604-4ee6-3be1-08dee9a7c5b5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4275 Content-Type: text/plain; charset="utf-8" Add a NULL pointer check for mci before use in handle_error() to prevent a potential NULL dereference when the memory controller instance is not initialized for a given controller number. This is added as a defensive check. In our current firmware the event will not be generated. Signed-off-by: Shubhrajyoti Datta --- drivers/edac/versalnet_edac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c index d1af5e175f7e..316f8f79c4d8 100644 --- a/drivers/edac/versalnet_edac.c +++ b/drivers/edac/versalnet_edac.c @@ -439,6 +439,8 @@ static void handle_error(struct mc_priv *priv, struct = ecc_status *stat, return; =20 mci =3D priv->mci[ctl_num]; + if (!mci) + return; =20 if (stat->error_type =3D=3D MC5_ERR_TYPE_CE) { pinf =3D stat->ceinfo[stat->channel]; --=20 2.34.1 From nobody Fri Jul 24 20:48:51 2026 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011058.outbound.protection.outlook.com [52.101.62.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA9B544C516; Fri, 24 Jul 2026 17:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913604; cv=fail; b=TYLoIxzQvSwQuqAiS/5TQFnbY5mvhuqI91MssAe/FbqLh5HVdJJMZuhqf4fqcE3pghNzjd2iEzJUl7Rp8yUJDCoDsHjeZYJG79wAgN066J0z//Bf6jOqvU85SrHcjjuHlRw/toH3DeEMJPxyhegqPUA+O9YTV5ynxvwP5KfjmXw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913604; c=relaxed/simple; bh=Yt30JjVNeKdyqghL/z1+6tatKl7tSzobwJL2VmOiaxA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=n7qJ7K1d/F+rvDAEFsWlWkmg0FKjz9p0hT5A01Q4O8+NyM5wWW+97qz5x+ZeXXCrwQ8ym+Cw9VK8FN/X9Nx9H9SQjRiXK56NwapSaEx/m/alSAw5W57eOHCueYXomf95/z7jnxqDq041ANkSse2/uXYX376klWxKuzhzpi8RP9E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ECmGKc/7; arc=fail smtp.client-ip=52.101.62.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ECmGKc/7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ksKSlW8sGMsbGh3uWQhTTySkTPdR++JRK4SgZL85bMaS1F05mdWgaLeQZLPutqvbmI6ezqQxy4F2THvV6shZzHRhNdeiBZFo69iDvkXVSL5YxpP44lbtBuUaBuMKiENad5tehEnsutcvshjMSe8Y8dGpllhkd+fC8R7l6RGU9BWlw2nx1HKlkyWGZQNF/WXYwjRXAme2jeFZ2Z5/pxU/D5PwImgBeQv3/VvnOrCr8U3DENFCnc6OwTASoezbRco3UspBUbfIobeCZWDXuioQ62A5vsDUOPcSDPOJzam920BGakiPL/rtf8l1KEsPe/6+W/2Dx/uI4cuKl3KshFdRRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uTYLLnX0mO0SKb+rWhtbN/WTNZrMpTczh090RaqCIMQ=; b=Het0cLKlptqbBJeVaPr/8WkQ9f/yWkHXVAJqaiaTYh2Yu94mHLURqlRjZM187mBbIfudxQ6H27BDmxrachp2PkDSidOJKLMQFwNjS8ObBTu5r+gj6fPOkKKNX4v87NVesZJSctsvg8DMjrHERqVfePPInN9qMGxK84DmqXpF4cMZH9mwL+aZmuj8s9VYOrFzBqFP33p1D4h/qet/oZyK0eL5taTuSXHGIoX3NHX3JXjImFemwCeYetoGZENEKzEcK+PbFX4W0uokeVEEesk7sWYA0Bv2E6YTEOimYXP2cdLu/8LbNzDSJalk/yulf0za4XGNMDctP0B3AS0sKotMqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uTYLLnX0mO0SKb+rWhtbN/WTNZrMpTczh090RaqCIMQ=; b=ECmGKc/7Nz1PAmUK4t+8KsPSlM4HELg0t9BFEnO3h/TvgfiAnlf+GGCIN6IPJolVNwWlxX1Ffl7wtc9d9sQhzk3oBTPZjUJMGEmZ3crBsOXphTo55PCEHdJxJ7dnlpsJ9/sWLfuMKrWgBTrqlnqTd6eAjusl1BOrbBlW9j5haTc= Received: from SA1P222CA0156.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:3c3::19) by SJ2PR12MB9191.namprd12.prod.outlook.com (2603:10b6:a03:55a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.11; Fri, 24 Jul 2026 17:19:55 +0000 Received: from SA2PEPF00003F64.namprd04.prod.outlook.com (2603:10b6:806:3c3:cafe::66) by SA1P222CA0156.outlook.office365.com (2603:10b6:806:3c3::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.12 via Frontend Transport; Fri, 24 Jul 2026 17:19:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SA2PEPF00003F64.mail.protection.outlook.com (10.167.248.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Fri, 24 Jul 2026 17:19:54 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 12:19:53 -0500 Received: from xhdshubhraj40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Fri, 24 Jul 2026 12:19:51 -0500 From: Shubhrajyoti Datta To: CC: , , Michal Simek , Borislav Petkov , Tony Luck , Subject: [PATCH 2/9] EDAC/versalnet: Add NULL check for mci in remove_one_mc() Date: Fri, 24 Jul 2026 22:49:38 +0530 Message-ID: <20260724171945.2812749-3-shubhrajyoti.datta@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> References: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F64:EE_|SJ2PR12MB9191:EE_ X-MS-Office365-Filtering-Correlation-Id: 76c3f597-e857-4c73-f58b-08dee9a7c73b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|23010399003|36860700016|376014|6133799003|56012099006|11063799006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: Ydi8Gw/TUUkN5MmvK768ZpcAydecTKPwlqWvkEqrr4KKiESIHp+FkFu7+QOD2ALQp7pAgjqI55FRsnDdXVEpufTZZdWqmkP2oqHnD0okpJq1uuJSfpGNz32OLYIVIXeAHsBd7HnYFodM9OrVvwLT35GzBspCQtY0rzM5bK9bS4IDe9nutr9X7RIDJYstfBDPRy5qWdLFuy2MOdCgsV5T7nwaoL+qeSo5Br/o5WuQWP2d0fiozv8rLli5Notqnl7sQJBhZhuozxbfazaC5QbTb+FUrToFfhLdphz4Q1b9lRpGIZtzzxKarihBt+mwVq/IAqXLy6gjJqsG+K5oex7iJ5pzZbVm3tsxOgRp4bp2DeYBK2E1wf/r8OO0tOsyhkVznh7JxdYTekhbNInknv3j52Zh9Lrvu01YDLFKdT8X/A/y/x1mx+XL5076CbBiooMQpDD0MIJ/hhKyzVSMmDM+bmnkhxoKA3FLsY8zvkRR8X8wzR/Aob1lJhrtpA7l5aucgD6xR5PhCSX696yLgZjNcQuqUz7d10CkkyBN9K8P9WBuagXzbql7id9vrGDjyWiXacuCWzXEoBLwaKkf8godgSStcIwrD1wXPuqShhJm5Um2ir4NZT3IGJ3p2r82jq8/k9zk1S47KpaRq+us6ernmszAMOSFaxzzc7IEABjVkyePIa3yzF4GcAZRCqBB9K+mgLv7UneSgZfwnE5kA825Fg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(23010399003)(36860700016)(376014)(6133799003)(56012099006)(11063799006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bSfOPb+xkVnJuQIkEYrxG7oomPtmf8OmA4R310W4UXBG/OxtP4QYj3PHS+aYxoZr3beoCLEi2wvvn+sxVCR04rP+LSwjHDi00c8HALHXjbRF6djFRW9C74gVmis0RcJZrjgbFTzBL0Dakjtj++AiWJNAQDR3Tk4Yy/oxWwqGC8ZobMhmfsbmSBhj0WsWpJCh/MbWRZwA9GpRpPReLh6xkbHgOx/l0TCzE5li6RbETBd35SlRZe9zvC/bu3/fjcgdnnSggZCtcHCgKd6plC6eY2yb/A3WzMoxIw7328uABJn2ihYu1b/DNhUFqNC+8+X5a3uEUevZGDkEqB7aAtJtBFYSF8XyCt9xIieb+tk0GsOYnijaAtrvg49PrzeBJahlgUqGuj5GCwsrUQxRaFNJaZPlZhg6Vil26pIv5RQTDNf+u1EVpEaohFvu5gfhdYnv X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 17:19:54.3951 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 76c3f597-e857-4c73-f58b-08dee9a7c73b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F64.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9191 Content-Type: text/plain; charset="utf-8" If a controller's configuration specifies an unrecognized bus width, init_one_mc() returns 0 but skips allocating priv->mci[ctl_num], leaving it NULL. On module unload or probe failure, remove_one_mc() is called for all controllers and unconditionally dereferences priv->mci[i], causing a kernel panic. Add a NULL pointer check for mci before dereferencing it. Unable to handle kernel NULL pointer dereference at virtual address 000000= 0000000390 Internal error: Oops: 0000000096000004 [#1] SMP Hardware name: Xilinx Versal NET VNX (DT) pc : mc_remove+0x34/0x88 lr : mc_remove+0x4c/0x88 Call trace: mc_remove+0x34/0x88 platform_remove+0x2c/0x70 device_remove+0x48/0x7c device_release_driver_internal+0x1c8/0x224 device_driver_detach+0x18/0x28 unbind_store+0xb4/0xb8 Fixes: 62a9fc50e8d9 ("EDAC/versalnet: Refactor memory controller initializa= tion and cleanup") Cc: stable@vger.kernel.org Signed-off-by: Shubhrajyoti Datta --- drivers/edac/versalnet_edac.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c index 316f8f79c4d8..05dc34504cc2 100644 --- a/drivers/edac/versalnet_edac.c +++ b/drivers/edac/versalnet_edac.c @@ -769,6 +769,9 @@ static void remove_one_mc(struct mc_priv *priv, int i) struct mem_ctl_info *mci; =20 mci =3D priv->mci[i]; + if (!mci) + return; + device_unregister(mci->pdev); edac_mc_del_mc(mci->pdev); edac_mc_free(mci); --=20 2.34.1 From nobody Fri Jul 24 20:48:51 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010047.outbound.protection.outlook.com [52.101.193.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9042E44C514; Fri, 24 Jul 2026 17:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913609; cv=fail; b=M43LTP6ip6CNSorpJJgBJ0pUUgE7ZxMt90JuV66kZlrH0xBbtPUKUCNLlHd5Pk1wtKtBi5RNlDZBbAM/ThvX7h1srL3VADnoOePc+w9zem73FZjclviSvuoRVW9Gj0R4Zua27jjlRrJYPWrfkHyVlyHWLgyvcuHU6SCd6QOasa8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913609; c=relaxed/simple; bh=IBZN4ccik2rynmf6hYsAjarkJ2Pv0/nrqJYOZEW1ZAk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TMGYVezrX9pxh30pJGJ+6ulhdCIz9+MwKC/rYyEOjKMkv4QRJatMWz/Dcfr0LNhxEAqhpiC+2fGXb7SdVgKfEBQ66GT3crudHwf9z/QdEImPXW7CFDL0GKyM1rSFx9NW6/pRhVl8EYNiDnOymE3B4f/OLzgnOi/SH+uhLkBD53M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=FV0e5Q+Z; arc=fail smtp.client-ip=52.101.193.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="FV0e5Q+Z" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EmezmB7jSDXDx5rp/czI1SOYUp9ROm3uAaWYgEPNI0rz5LRriE9Rpf1lPkfMZ7cbOMC2rpwrMltpPIpQ6+0PJ/38hSPz1uL3dzpt/Z0ZXqgKQqdH22zOMNDCElNTUl0ZhSPFIe/PC86lcugpulLIj+3xxwnRIQ3DdYZOLvE3jUGj+fvGRZl7Q2loBmgfbcfUlmnkJc/f+8el65vQXEWJ4AVigfk6O4lQyzWEHoB5khNiwddB9tymMOnsisDEfgTqo2fzkDDzyjDuacPLM56r1H9iTobIik6nLD8UMDOu68m4g1qt83LYaz1QZ7kunGQPiHbA8SjjQSpMJUUWUgXiCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RZ0n7Z8SpRMiDurFw2S6Bt54h0u1blEn2bcU1qbo5no=; b=MXzr86iswyskG+HweCF3FgSKhznzQx5ScZJxS0Hg0OFEIyxnDai5Ul1WwAtsTUL2xLAS3y2k5AaWlryK61X4RcezYbyHlGRDCzANPqJBo0D0j5SW82FM9tvWkIzx4dlNrN8HU7xvOIpN0IeFCs3StZAjhbu9kIPRH+e59kKG6BcdVvuMwgI0mGBS9VcJpvBgyw/NKecRbYtcvXTveoplq7v/OPALXy278AJmfZbp8+B6EyWcWrc0iw5/5V/+/BrToffxCnPpL4nZOz1cykojbtpvMrqt9J/F50hwvxPNxii8Nxd78dgoax/5yfwyShNod7mSF8G+Hxl1aus3yroIuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RZ0n7Z8SpRMiDurFw2S6Bt54h0u1blEn2bcU1qbo5no=; b=FV0e5Q+Z0LDfn7vfuvNtD5cMibn8WMGPS0arINEMFXOB6D0qulLIXMp0JRhl2GiwbG6q2jczGZBgmj8ZegDZwrLMi0B+hI2J+AplMrIHRJbZhXiFiBoAS9qp+4Bmb2NQn/ARW6HCm1ybYyGEAmjHDK9W10flJBCqd1kU+hKedfw= Received: from SA0PR11CA0058.namprd11.prod.outlook.com (2603:10b6:806:d0::33) by MW6PR12MB8951.namprd12.prod.outlook.com (2603:10b6:303:244::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.12; Fri, 24 Jul 2026 17:19:58 +0000 Received: from SA2PEPF00003F61.namprd04.prod.outlook.com (2603:10b6:806:d0:cafe::88) by SA0PR11CA0058.outlook.office365.com (2603:10b6:806:d0::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.12 via Frontend Transport; Fri, 24 Jul 2026 17:19:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SA2PEPF00003F61.mail.protection.outlook.com (10.167.248.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Fri, 24 Jul 2026 17:19:56 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 12:19:55 -0500 Received: from xhdshubhraj40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Fri, 24 Jul 2026 12:19:53 -0500 From: Shubhrajyoti Datta To: CC: , , Michal Simek , Borislav Petkov , Tony Luck , Subject: [PATCH 3/9] EDAC/versalnet: Move platform_set_drvdata() to mc_probe() Date: Fri, 24 Jul 2026 22:49:39 +0530 Message-ID: <20260724171945.2812749-4-shubhrajyoti.datta@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> References: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F61:EE_|MW6PR12MB8951:EE_ X-MS-Office365-Filtering-Correlation-Id: a5ef0580-b5a1-4988-225d-08dee9a7c8c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|36860700016|376014|1800799024|82310400026|11063799006|56012099006|10067099003|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: tZ8rtfMXhFRF9zA0lqUd80cb7hH6OibviWTkII3xt7HwDYxlK6U+frHkfqpat8pCO+EJ8IfFUmO8eYyQWBk9ofIBmKND1eVDONqYaYQdp9a1SLVYz16+6mHC5/NLxz8Maz0Zcu7mpBGQ5mvq1WdzyBAHxbwU4nWVK43/KcCoyHP6ExADEAGoXhTCoTGnNU0hfTfN++bExIE/SzzcJrnweYKxl8M7UTRtKoFzaeTb/XabBExWBQ7R7CkN96T9cEluJdiFwX9Bj9O/yCTdRaYfhULHDAdflK/X+cY9oyC92FgHFiEKW6rJiWR4cveO2k8LcPql1qd7ybwgsjiDLt38VmVmt/uGUijIr4UVN5e74UFQDzOVWwzyghzY+Qte9Ez/N0v9tksh6A5Xg/HFTpq9+g2EvVWPwKZKvXejYDydGHCojRQ/8rz8K52rfcryAMDtdQbl26PFV8jTUUymODG3qWF3T2hG4bUeriNDCp/s+AV2NNmr2+H/OPXEfMC8lvboUL7grkignjBX5VBo2iwWngZBTIX55e2SFqSDfER5GERCNSj0nmMvHfhDWINydH6SxKc814C/hGQpf1tPXZxYeZJexkltCw13lKwQw1TgSZhEUKSblOn9/iEPCg4g32Wm3HzBzslPg3ZYa/YLD1dWi56zMrAA/Zq1dF8yRaaESTn2pa/hoMTaeLw/Xs43ydosYPJNmBhtKZtoooAIBeqOOw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(36860700016)(376014)(1800799024)(82310400026)(11063799006)(56012099006)(10067099003)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TsLAnyslzL59So9P9KLPmi9dGTS/JXtF+P/j6VVUq9/PJhJVEhpMfgS69PHkuvjnM1Yky0irXCVP2+TVJ1F7Gn2NJbG7yvxG6SueKrpdtuTpBUFeUCsWKMueXPX1sVxuNsgdgpjEDMeh5WV7L2NauVutAJiPJUV9ozsAg8lMH/6YjorzLuAUp1KM7M5VYiLNDot924xa0ujy9ulSoVWf8moaWYDgo+QETHiCAGpFtsdDDGVxTEkDF1tIoMkw+ouTZlZW07SJuan+UyzTxRGQ3tiucKSWuSmUzXNnXaoo5O/qjr5skEYI3JuSxA30YiU+uZIvkCejoyU8n9ApfX/YGtaCruRUL6jFNsv4mzpD0l5rJ0Xw/zQr5/diRzw7pPw7oi/D1+ZiMunsSnBQW+jK3APVOF/vodjkOb1IOztAPX07qu8juFMtb3Y5ZY93woTu X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 17:19:56.9501 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a5ef0580-b5a1-4988-225d-08dee9a7c8c2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F61.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8951 Content-Type: text/plain; charset="utf-8" Move platform_set_drvdata() out of init_one_mc() and into mc_probe() so that the driver data is set once during probe rather than being redundantly set on each memory controller initialization. The pdev parameter in init_one_mc() and init_versalnet() is no longer referenced. Remove it from both function signatures. Signed-off-by: Shubhrajyoti Datta --- drivers/edac/versalnet_edac.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c index 05dc34504cc2..03b6e0958f17 100644 --- a/drivers/edac/versalnet_edac.c +++ b/drivers/edac/versalnet_edac.c @@ -777,7 +777,7 @@ static void remove_one_mc(struct mc_priv *priv, int i) edac_mc_free(mci); } =20 -static int init_one_mc(struct mc_priv *priv, struct platform_device *pdev,= int i) +static int init_one_mc(struct mc_priv *priv, int i) { u32 num_chans, rank, dwidth, config; struct edac_mc_layer layers[2]; @@ -849,8 +849,6 @@ static int init_one_mc(struct mc_priv *priv, struct pla= tform_device *pdev, int i priv->mci[i] =3D mci; priv->dwidth =3D dt; =20 - platform_set_drvdata(pdev, priv); - return 0; =20 err_unreg: @@ -863,12 +861,12 @@ static int init_one_mc(struct mc_priv *priv, struct p= latform_device *pdev, int i return rc; } =20 -static int init_versalnet(struct mc_priv *priv, struct platform_device *pd= ev) +static int init_versalnet(struct mc_priv *priv) { int rc, i; =20 for (i =3D 0; i < NUM_CONTROLLERS; i++) { - rc =3D init_one_mc(priv, pdev, i); + rc =3D init_one_mc(priv, i); if (rc) { while (i--) remove_one_mc(priv, i); @@ -914,6 +912,7 @@ static int mc_probe(struct platform_device *pdev) goto err_alloc; } =20 + platform_set_drvdata(pdev, priv); amd_rpmsg_id_table[0].driver_data =3D (kernel_ulong_t)priv; =20 rc =3D register_rpmsg_driver(&amd_rpmsg_driver); @@ -928,7 +927,7 @@ static int mc_probe(struct platform_device *pdev) =20 priv->mcdi->r5_rproc =3D rp; =20 - rc =3D init_versalnet(priv, pdev); + rc =3D init_versalnet(priv); if (rc) goto err_init; =20 --=20 2.34.1 From nobody Fri Jul 24 20:48:51 2026 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012036.outbound.protection.outlook.com [52.101.48.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61DED44C518; Fri, 24 Jul 2026 17:20:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.36 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913618; cv=fail; b=mXinEPrCgLxBlB1+8HBiUWIGS+VmH+LqCbmg+Rnt08kDo2DAFe1O/Ah1JEoKBtVKa5eSZ8vG0i3/QLhIofyhEAalYhuRr3+m3X04/gYPEkvVXhlHc0RX9Dqxw+iKgIvgaswcAYQ0Z6PugRrmGEjKe1Dj2FvPutVMFnSbltFgyUM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913618; c=relaxed/simple; bh=LvDRAQK38VxHDAJoK18ZnYwNeN3TR4k7lwF45OYvqe4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PDZejCevkDFDnxGPPgHxWmNFq9Di8vDsMtMdNs0soc9DjH4mS++GaXOdElzYmsvYhFj/F7Fak0xn/YQVsAFVEujY5Al/DNdYaOX8fOvd/u1gUmsi9p1LZM9xSVRBFQszLpHwtT1XM/GSfzQg4NwYvBJPcLOrtWBx2al9jHY83x8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=wUjZX3UL; arc=fail smtp.client-ip=52.101.48.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="wUjZX3UL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gVxB8lKamLOnp5/hoxzQata4KABhFtGvUy/eyx8j77TDoXdhmTLpC8zGfWhwwHQTw+e/jlPkseGBFih9Vu2/WW/VfUmu7EXy4z+DfVo6sWldAMfUWrp+Y9MfQu7LxBUn7sYSSdpyy1bCfSKqtec/6rDUl4AUqIaSI2qXC6NQ87uM4oiWP2tEW5DJbVLl8xVnzNf0AR8uJq0wqD6/Bs9MWsBxSSxSx8E6Xv0p8NpdF36ZwY9GvrdSLBLmNYvZpGHJKDq7Bo8ln1a+sz1RfArV0dTus0Bq0uvl8vh65e0PUGGRkIeyILFvbC36tORt7encw1ymvvkJj5b/gM0r2SsNLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=htpPrwL1J6/5BoEJOs2oMUm/EuiKduVI5GxTcKjC8Kw=; b=SZm+cX9/97EQqX+8CEoRnEWTSxR2kNuQninbWlOLoqLpptQI4wZSnjaqsaDDf+2WSBKWmdeaAtGhv8yRGqqMJ8fE3uDdtSn8j4n8YsxDZGDvn5k0nKMrMakY7J9gnPPvBaD2sIVyQ5Ny2+oSEGaifyd4s2+U+7Fq35JeCfe9B2S/WGFVYdahgdzuXAs02HiiWrPnnaufSbQU0gbTU7ZN9yRDOGxyN9qjjNeJCyDlgIk56AvslegADWWYvdvioJXn25adG3m+dkoolB6Xt1Rp3+y64pTe6vZj1MGumv4YiQapNVP+pt8B2sVPqJUotkJC1CUjkEzlqD8bZKypeypPJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=htpPrwL1J6/5BoEJOs2oMUm/EuiKduVI5GxTcKjC8Kw=; b=wUjZX3ULeOrukaYaNhRCFnyBjM/eeVng5qDeRCQFdWH6ifk+lHL+UyHX9yny2ONL0E7fKxt2YSGmQxS8TZBn91OwVDEeiuSUlY5OZBzCmUZgw9UDNSFkpvisTvy0+dx7XwHbkqDzf+sSpBUxmmeQ1DPK2C8v8qTW9R0nZ35hLY0= Received: from SA1P222CA0058.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:2c1::9) by PH7PR12MB7116.namprd12.prod.outlook.com (2603:10b6:510:1ef::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Fri, 24 Jul 2026 17:20:00 +0000 Received: from SA2PEPF00003F65.namprd04.prod.outlook.com (2603:10b6:806:2c1:cafe::80) by SA1P222CA0058.outlook.office365.com (2603:10b6:806:2c1::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.12 via Frontend Transport; Fri, 24 Jul 2026 17:19:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SA2PEPF00003F65.mail.protection.outlook.com (10.167.248.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Fri, 24 Jul 2026 17:19:59 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 12:19:58 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 12:19:58 -0500 Received: from xhdshubhraj40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Fri, 24 Jul 2026 12:19:56 -0500 From: Shubhrajyoti Datta To: CC: , , Michal Simek , Borislav Petkov , Tony Luck , Subject: [PATCH 4/9] EDAC/versalnet: Fix device_register() error handling in init_one_mc() Date: Fri, 24 Jul 2026 22:49:40 +0530 Message-ID: <20260724171945.2812749-5-shubhrajyoti.datta@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> References: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F65:EE_|PH7PR12MB7116:EE_ X-MS-Office365-Filtering-Correlation-Id: d041dfbd-f6ea-4881-5f95-08dee9a7ca37 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|23010399003|376014|1800799024|36860700016|18002099003|22082099003|10067099003|11063799006|56012099006|6133799003; X-Microsoft-Antispam-Message-Info: ex41RlLjBsmOtLkmnaE1D1tAhfyoIHjqowOSeed/JFNMC9SvP7tkHpmQ7ju2sAk+hVocrQZqk1N41EX7Ep5ag0Xg0g+ydKdQl2TT5CBfMiqQz3MFRSiHC4pz4mybBvMfHx8mAb5NXL4rMA0k09irYywgZgSkkcgRmDdnD+RPVqqhWbkjGj6JDLxwrT0ZZiottwK2eCeU0CcxS1zZmvoIYRg61S2Ympb46Hy4XFTISCEHZ3JN9r/e3LxPoyWB3uIs0VnbB4Nk/tFRwvzKOVxakQfPF2/9WJCfYtVenzZeZoiiEsiq/LnUEbZSRQiJPDtp+MmaGluMngB87S1R7p5mvoIiD9mneTLvJGrqL1PYatH8ZDHZ+khFMsIFfvyZInFeqKpXYPQHjKbdsPf9Iah3qBZCf5S4FKHHUIywO7qF3+11+IPJsGHesGCqIYHcXpbA6k/ZFbTIbPGlH1k2iR1I18wEI76fSthyYMQ4LKxJ42rBKkvpQbJ87vd8qNbMoU1nTSA1tUhjhpQ/MCTTRgjwPA7N6+BhcDDoP7MVPMJrFa16gExolJgxd8y8xFiYyDz+ZRQDPNl9M7DHKe7EOP/qXiqukTbmPLki/1EHnBvZ/MU3suPyLfMa+R5WXgiED+9gtptcsiByI+XrBi/M+ZE9z5oO8AoQzttSS703NEEQVdUCKmiCn0cQU47UZeukjUIy0RJ7dEQap2glONoTzCg5iw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(23010399003)(376014)(1800799024)(36860700016)(18002099003)(22082099003)(10067099003)(11063799006)(56012099006)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: mZ8TRp3UIgN3LYpYEc6tUUyFXdekTC4nI6drf4M9IJ3Ygp55K0qc0IqSdwCHcNj8LYa/RMYd8DR8cOa1lnHUcaOLs5R97eLT7BOnsyhEwmEjHNTxW1VeVeJh9xfZ0yIkggI/6VTEorTIdCZ2dB+MIE8xZKA4HCV4J8p37xefAssWZUnAp/robH5+ipvqpFW4+yYS6Xy6i5SgpknWIaZjDwRt0YQIt1gAFIcTdu8T8Fw3xdzDHi5mgMjorvchZSYv+AtdZLfNxqcJTERohBrlXEgJ+wYH9zm2PzI4mZ1wAIZRkyweTHwOn5RrZnWRYrPnWmw390R0USsKL+an1vtrBZod+T2mUKhpwCAFgBpIoPUkPdbDZ9ayvfFS9Qqq1iWc6vBNQvYAmuQ5cV5QAGCvd21EuSH6WwTxg2ZAB12AnaEYYNoUX1jEZCG3B4GP/GoO X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 17:19:59.3977 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d041dfbd-f6ea-4881-5f95-08dee9a7ca37 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F65.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7116 Content-Type: text/plain; charset="utf-8" From: Prasanna Kumar T S M When device_register() fails, it must be followed by put_device() rather than kfree(), because device_register() calls device_initialize() which sets up the device refcount. The matching release function versal_edac_release() handles the actual kfree(). To simplify error handling and avoid complex unwinding, split device_register() into device_initialize() and device_add(). Initialize the device early so put_device() can be used in all error paths. Fixes: d5fe2fec6c40 ("EDAC: Add a driver for the AMD Versal NET DDR control= ler") Cc: stable@vger.kernel.org Signed-off-by: Prasanna Kumar T S M Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Shubhrajyoti Datta --- drivers/edac/versalnet_edac.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c index 03b6e0958f17..3c9eaea5a106 100644 --- a/drivers/edac/versalnet_edac.c +++ b/drivers/edac/versalnet_edac.c @@ -785,7 +785,7 @@ static int init_one_mc(struct mc_priv *priv, int i) char name[MC_NAME_LEN]; struct device *dev; enum dev_type dt; - int rc; + int rc =3D -ENOMEM; =20 config =3D priv->adec[CONF + i * ADEC_NUM]; num_chans =3D FIELD_GET(MC5_NUM_CHANS_MASK, config); @@ -817,23 +817,23 @@ static int init_one_mc(struct mc_priv *priv, int i) layers[1].size =3D num_chans; layers[1].is_virt_csrow =3D false; =20 - rc =3D -ENOMEM; dev =3D kzalloc(sizeof(*dev), GFP_KERNEL); if (!dev) return rc; =20 - mci =3D edac_mc_alloc(i, ARRAY_SIZE(layers), layers, sizeof(struct mc_pri= v)); - if (!mci) { - edac_printk(KERN_ERR, EDAC_MC, "Failed memory allocation for MC%d\n", i); - goto err_dev_free; - } - sprintf(name, "versal-net-ddrmc5-edac-%d", i); =20 dev->init_name =3D name; dev->release =3D versal_edac_release; + device_initialize(dev); =20 - rc =3D device_register(dev); + mci =3D edac_mc_alloc(i, ARRAY_SIZE(layers), layers, sizeof(struct mc_pri= v)); + if (!mci) { + edac_printk(KERN_ERR, EDAC_MC, "Failed memory allocation for MC%d\n", i); + goto err_put_dev; + } + + rc =3D device_add(dev); if (rc) goto err_mc_free; =20 @@ -843,7 +843,7 @@ static int init_one_mc(struct mc_priv *priv, int i) rc =3D edac_mc_add_mc(mci); if (rc) { edac_printk(KERN_ERR, EDAC_MC, "Failed to register MC%d with EDAC core\n= ", i); - goto err_unreg; + goto err_dev_del; } =20 priv->mci[i] =3D mci; @@ -851,12 +851,12 @@ static int init_one_mc(struct mc_priv *priv, int i) =20 return 0; =20 -err_unreg: - device_unregister(mci->pdev); +err_dev_del: + device_del(dev); err_mc_free: edac_mc_free(mci); -err_dev_free: - kfree(dev); +err_put_dev: + put_device(dev); =20 return rc; } --=20 2.34.1 From nobody Fri Jul 24 20:48:51 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012019.outbound.protection.outlook.com [52.101.43.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8047B44C51C; Fri, 24 Jul 2026 17:20:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.19 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913618; cv=fail; b=jE+ybUIfqjcgL+fWKXh8JqO53wcXjMb5XVED0Z8vtRBeicKXWbnFM4pIOrts7N/08Nk6/0ad7KqohsRlMKzRNRn010rGvczyREMoa37YT69F0mgDOxcUz2CKLIkIxTAXCeKO1XLhVx4L21CTNcgzUz1kmgfBxzy1ETLDIjY5Agc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913618; c=relaxed/simple; bh=kAlSjO4SWHFfK+G7pinx4jjfOjiC0JHWXIB2FQ8Vcg4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rQbaDI/aiALU4etHdUvkrzAuc/cKQs+xETq14w3nWcokbo2YMwEDbyTOLaaUx0LscvfjVyls/u3ng+55Z8ev5elvv2cj2gEQ+FN+cFuqn8IbUmIRzECT/NvnaVCRoqtDakJkbhjzOgY3KxRM366J4xIkZQHyw9we4ahGmrIcQDM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=d/uwtgLt; arc=fail smtp.client-ip=52.101.43.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="d/uwtgLt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NQ6V5eJq6QujKa1yjanN092xbjQ6ElFm8y94iMM4+OYXRkKJS3IZ4Kq7jmaWj5BLjvHOQ6hvt6oiwtzzGKKafXDReyxm3XpHqCceroqV9u3LdDbhWopjhZTowKTPxBDObd6KX6fzXgoLdZ/FPV1y9rctH6kFZ62j44Tiisy1t3OydgAOii17m0aAVAtfKcJYdIhD8ADamRQ/8Vij3C42MTsl43GiBml+qjZQxUirX3O/vSw2F3C1VOh0V0EYecUKr89hrxyG/Fib9Rcdv5XfpyHE8hiEyt4F1cJMef1N7Kb5PJ/R++IDcalg28H1X4WixVOS9/lVQPNObJtRbKYvJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zoeEwRMHa37OYn1CBiszKCpJI3gADE1Sk9tAMuMOrOc=; b=Dco5zM2IYCgqvq3feXma+DBNABKWu8+DErkloox1YmrdRfoJs9t8Xa7Qa7WDEzMJMbgtgXKj9HK+XLFM5Wt7Q9gMQBDFTz+Eb9FNDaTt1ETEQcXs9qYqvjikTSKEXLFeelf1DKbwoAKfaClKoW0TvaUcX9WQhlaUDTJGDCtXV4aENq9vn2WBex2PCWYOw9isbym7A4msbJXSp1zjCbpnvvzMEHUwgzvTEq25UtOkq8xr8aA2thoMX3Z+Yu4Kpwo4CsY1/h2ylgKsXCiumDYRZwXrVFS8VjUeqJrw/ouD9h2z+iTSNSq0EaDzburyudgloGfDaww1VahKc2PbzqiVeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zoeEwRMHa37OYn1CBiszKCpJI3gADE1Sk9tAMuMOrOc=; b=d/uwtgLtahowvw39afrOvqP7I7IPyyCeFrKxnzZ1UpLjbUBGR6Zu87JzTqmdqjnrcF8aAT//588REBeAUT/hlFuDDKJiEBo8BDiWcomLlFuShTh2QU516t2FaE8edEkcWW0wRND9c8WwOS+yatEYoryWUh+AYZY3tHDgW+/EsrY= Received: from CH2PR15CA0027.namprd15.prod.outlook.com (2603:10b6:610:51::37) by MN2PR12MB4141.namprd12.prod.outlook.com (2603:10b6:208:1d5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.11; Fri, 24 Jul 2026 17:20:08 +0000 Received: from CH3PEPF0000000B.namprd04.prod.outlook.com (2603:10b6:610:51:cafe::9c) by CH2PR15CA0027.outlook.office365.com (2603:10b6:610:51::37) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.11 via Frontend Transport; Fri, 24 Jul 2026 17:20:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF0000000B.mail.protection.outlook.com (10.167.244.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Fri, 24 Jul 2026 17:20:08 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 12:20:01 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 10:20:00 -0700 Received: from xhdshubhraj40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Fri, 24 Jul 2026 12:19:58 -0500 From: Shubhrajyoti Datta To: CC: , , Michal Simek , Borislav Petkov , Tony Luck , Subject: [PATCH 5/9] EDAC/versalnet: Use dev_set_name() instead of sprintf with init_name Date: Fri, 24 Jul 2026 22:49:41 +0530 Message-ID: <20260724171945.2812749-6-shubhrajyoti.datta@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> References: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000B:EE_|MN2PR12MB4141:EE_ X-MS-Office365-Filtering-Correlation-Id: ad8a95f4-6583-4961-0335-08dee9a7cfd7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|36860700016|1800799024|376014|82310400026|10067099003|11063799006|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: bLVw8L6lVZzmv8dKyLm+Xix/DP4gZcjZRcwNugV+rPfLUthONm5Sb1fGEVIxEFY3Xvdn9t/5iCYyJRXbO1UJKGnQEeDfXEgXXwMX9CFUg8BhprYpRcjE9HnPtP+ZW8bJHwWcU4b99kzeg/YBa8DXLGzwOwAleR7CgqTto8hs03Ri2esOMRCXcU0dfzpAIQuawT+q/8HzGOZ3R4t2ElotkalM7XAWJo1MYYKK/0zVuE9U1+QskVdZM9HtQz/66LjmqC7ml000if/bhDLUu04QQbseQod3XQKM7+lLuKC59Sx65+q74nxjzXxuf4vf4qO+in2vWjruBR1TAKcg9fqajVYvsaIj2o8F8C/RYDkOB1bsBkuw6cjLduTOkhuPz2RWBC5fTVJEw3MX/f1Hsq0n4jFATZ33dYrTgmHY7hXGQrAQmbo1BwHMIgeXgPvlLt5uGlrJdZupSsoOGbrBXMP6J81/RtNJR1tIvdbw15MzSEc3oTpVOUS95t5apjthMEp+hCPV3Wk3YCCpTKaVHi3NRlQH5HgZYQENI4lSbD/21wKwIqWwFUi3gzOe8vxzdaVwpsT3SuV40e9LmO9uYxrTRVOiF4/+65JFTjoBEXSfKzUynrmh7ZOV0VDlybKWiX+X45LgzoBFv1r0ShbU3dNbALY3SCfzZ0mnoIH+OiOJEN54vjV8AAxunCQ3n8Jm8nOhMU6Cay/bbIB1tax3kqJsTw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(36860700016)(1800799024)(376014)(82310400026)(10067099003)(11063799006)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: jtdhU6MgKRGsXXQ57BB0OsP8areONMEPbKWdcWYNiM++NRmmjp6crKpi6u2WStmu4ZPJjuBaL04ERgNPwuhF/K6jMFbYcmfQ3a9qZnzrVyyvszfmSBA86/+nLrNtLMR01BM+519uDS6q2uDmFni2/b+RCBEqjmY4dBfKCqiRyT3k99n6+SPbakql0m7YotEt8O3PC1Op3tVjaEk9n9ZgAJRP5r0tjOsh8QyXux82E7EF837zj+8SQvoXJDBr7wbYisHrrTlVxhoUVgFSEF6e4OGfDSEuS1wCSz3lmGaUkduPVjTqx4qS3SS1kRDAGiYhFeDyAHy3tkXqyQXNZ+9eOrMu+lfEdE3ZuBOVjrGX0IY1qHFLvfT2oy9RD8t5o80MGrNBkl8GuFBkSByRTAPF9ZzIXOkk+N0prUkq6l+sRJVLoOgzKoIECVDcaVoZs7KY X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 17:20:08.8701 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad8a95f4-6583-4961-0335-08dee9a7cfd7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4141 Content-Type: text/plain; charset="utf-8" The previous code used sprintf() to format a device name into a local stack buffer and then assigned it to dev->init_name. Since kobject cleanup can be deferred asynchronously (e.g. when CONFIG_DEBUG_KOBJECT_RELEASE is enabled), dev_name(dev) could be accessed after init_one_mc() returns and the stack frame containing the name buffer is gone, resulting in a use-after-free. This is fixed by switching to dev_set_name(), which dynamically allocates and manages the name string internally, but the now-unused local char name[MC_NAME_LEN] buffer and the MC_NAME_LEN macro are not needed so remove them. Signed-off-by: Shubhrajyoti Datta --- drivers/edac/versalnet_edac.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c index 3c9eaea5a106..1caaba653fc0 100644 --- a/drivers/edac/versalnet_edac.c +++ b/drivers/edac/versalnet_edac.c @@ -70,8 +70,6 @@ #define XDDR5_BUS_WIDTH_32 1 #define XDDR5_BUS_WIDTH_16 2 =20 -#define MC_NAME_LEN 32 - /** * struct ecc_error_info - ECC error log information. * @burstpos: Burst position. @@ -782,7 +780,6 @@ static int init_one_mc(struct mc_priv *priv, int i) u32 num_chans, rank, dwidth, config; struct edac_mc_layer layers[2]; struct mem_ctl_info *mci; - char name[MC_NAME_LEN]; struct device *dev; enum dev_type dt; int rc =3D -ENOMEM; @@ -821,9 +818,7 @@ static int init_one_mc(struct mc_priv *priv, int i) if (!dev) return rc; =20 - sprintf(name, "versal-net-ddrmc5-edac-%d", i); =20 - dev->init_name =3D name; dev->release =3D versal_edac_release; device_initialize(dev); =20 @@ -833,6 +828,10 @@ static int init_one_mc(struct mc_priv *priv, int i) goto err_put_dev; } =20 + rc =3D dev_set_name(dev, "versal-net-ddrmc5-edac-%d", i); + if (rc) + goto err_mc_free; + rc =3D device_add(dev); if (rc) goto err_mc_free; --=20 2.34.1 From nobody Fri Jul 24 20:48:51 2026 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012065.outbound.protection.outlook.com [40.93.195.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9517244C65E; Fri, 24 Jul 2026 17:20:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913619; cv=fail; b=RJLffT9OSqwn8YuAlikgCOS2qLG7+Tkb7Ek9l4XPf6e+iNUsBT7xLergXhstA0S5bE6YIE7qU6QEUuBwiY+5usM04h/MAXf+7CKIWr3u0LDDzAZh0MviGKZdDFEdXYad522MvZ7JHxak2V/ooRgXWguLDnQ+oQ/9sjrscrZd/F8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913619; c=relaxed/simple; bh=fNdEjDVjA34eL4hFJlvZjb76M9IF08PS0nOInYe8d9o=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LoooCcM/22am99etAmdcgzFvdhf6kHO5lfCbki7InrUFRFZ0tJ+7twhpCeziEjuYG5KCsakFEgl/pMrO39DrlsoBfVQx9jEbFu01237L9sQ2xhd+/ykARa9CBwx+iVS/jwzdfUahZAnMmo6ICPL47be9xJ8LEI6kSI/26HKzs9k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=pyBe1XrW; arc=fail smtp.client-ip=40.93.195.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="pyBe1XrW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kqe3P01hHBLhqXdweeUquPpyFiIZvxkA2us+OUU60YXSOlFR5R0wuka7FF9+nW9WVrs9QkxBNYY6MUXh207ib+r/95/dQZ03tAqZU8gdA6Iu2trz9sK7n+r+uotPA1OJGAt1sgZ33/7U/t5Lx/Nt64bFhZqBY6uegbz7pNvdjrBDhpMip1bMJFcw5Yo+77YWLE8lGhr/9Ah8EwxR43cS3THiEnentNpswGTjkCM5YQq9v8PW1+23gU1DsmomNmJXt+wuVY1Txsob7mZYCk5ItyeJHKgCOq9spFzw4ysRULlF+QE3cFYDhQkebkbPFNFRB4io++Hn4tur8DrcmcnyPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q3tInHeKqpigzeyDz0g/wvDU+vaKygYEx1sN8kplLlM=; b=xAeaMr9hw79AYtFI3hsxiigZUJbkM14Zb2zuIBPrAO0H+oxtOhw3KT3IztJW8f736rj7K0/kX/DNGz6zigos/es8NmL92BoEa9M7mwdk2ZWU0LuOQ4y4kMxaGHEtjEDGz6d16KgvWeoLZYN3kJ00nltBUOpukFaM9ec+IGuWu+0hoSafm7niOcMvD2r4+HaPV1O1jRWxaA8ILuO6r7tf9k/sHyiIt6a8hyqP2xfyefFS1Yr4wOF1tMs7tECdf/nKbW4R3Za6FYD58eb08Vj106+znW/8DO5UPW5EajIt0E2srEVhmal84Gzg7sc7wuWxBUYYYV/tEB8KHuJ2VsDQnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q3tInHeKqpigzeyDz0g/wvDU+vaKygYEx1sN8kplLlM=; b=pyBe1XrWbDGc2hrLqqkGys7hcOOQbOqFfUW5CBmO11iQX/Ndar7MP3PSIMTMuH3iyagdhsmuZHRzJe/HUPAaCkHhdozVNvGwKnE6M91Ni0WJkLHMNy6ekwJPH+PchRZXNyrieJjD0OQDTqnT14/BsUTbm84uu56GFmc8tag+9oQ= Received: from PH7P221CA0071.NAMP221.PROD.OUTLOOK.COM (2603:10b6:510:328::24) by PH0PR12MB8006.namprd12.prod.outlook.com (2603:10b6:510:28d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.11; Fri, 24 Jul 2026 17:20:08 +0000 Received: from SA2PEPF00003F67.namprd04.prod.outlook.com (2603:10b6:510:328:cafe::71) by PH7P221CA0071.outlook.office365.com (2603:10b6:510:328::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.12 via Frontend Transport; Fri, 24 Jul 2026 17:20:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SA2PEPF00003F67.mail.protection.outlook.com (10.167.248.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Fri, 24 Jul 2026 17:20:07 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 12:20:04 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 12:20:03 -0500 Received: from xhdshubhraj40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Fri, 24 Jul 2026 12:20:01 -0500 From: Shubhrajyoti Datta To: CC: , , Michal Simek , Borislav Petkov , Tony Luck , Subject: [PATCH 6/9] EDAC/versalnet: Initialize MCDI before RPMsg registration Date: Fri, 24 Jul 2026 22:49:42 +0530 Message-ID: <20260724171945.2812749-7-shubhrajyoti.datta@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> References: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F67:EE_|PH0PR12MB8006:EE_ X-MS-Office365-Filtering-Correlation-Id: 98096c65-53ba-4fb7-5377-08dee9a7ceef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|82310400026|36860700016|1800799024|6133799003|22082099003|18002099003|56012099006|11063799006|5023799004|10067099003; X-Microsoft-Antispam-Message-Info: GOv/IAoOLWN1uVyJx78WnziNTUoAMlDGyYY7XmODYWdGADwX5PDxEne2FbIi2PlYcXndx/fGt7Cg17MIvedfGmxNG7EJq90xxTornrsM9JhBHK4QY8JQaWuAAzfvU6d3QnZAsxKwy9cK8c++2ZkPKiPcb3KZgpxScWY7uefjY3NMt344+6ECbl1ICWPO2ecjTTr/5dluWJCD5Yie7bPiKPNukq9EU9nYniMeYE4T0OKW2H2uE5Qg2q0O8Tykdj1A4SlY9/1A8z4bHvdJGBAJqZyoWtjBzdsNJ87oRqgfHqf1leyGa9U3B0Z6dUAZBqwh0q0v8NTUdOf+XD9l0X1CvMilA/KD14zTYc7Swp7RFz8HxlI5eYvRhC4N4IlZ1Wji8Gl1mPAprxXeQM5Qa8/uHkQ1QeNx2ogxZSyXJ3COvI1SkzXWpuKB+ZSjh8ZOPxVWlCe8w1DPNUb5lJWJoDRCSuz+MI+J63nIvZgz5eq2j1qOxDvItmAYdZIG1cz08CBi0zXn8dyPgByeU9nh/Xfhh1nKaGBL/RtMdkw9gSAh5hjZnwElGaylSMBR/ihJD87gtNcCG8Erg4v1FN4HnAVpQfNvDbixBLMTe987ZQztOylgGPFLzbrcM8rtzqz6fPg+KT1td6g78Rhox0VXnczD8JFSrralRtthyr84jAf16zz6Ls4578duhEZd/Wxb4uJHH0Gl/vUkGE2GYpIhpPgcxQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(23010399003)(82310400026)(36860700016)(1800799024)(6133799003)(22082099003)(18002099003)(56012099006)(11063799006)(5023799004)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: FNtUAIOyxkFCbSB/dtu3YGQ/JMCwmfL1+hcRxRN8h9IJ/ECJmZUpyvkKa88bL3qJDyW8FbR/GJ0M+ddCj59AeBoXouGhHIG8/I69TVCiahgXs2kjV84/CA4tiwy/KBIhbXyOPPPTAE8XwodqR2k5nJaxW3JPG4m+48W9SMsY/w2OzJzXp+sO4eKeElczMqrxlysbo8HVPttnU89lw+mk3T+r3cyxk26eURoNR0wDsu3Ysf6t8DQQdNztAPsPz0ttFth8wEjNPa72TH75M/dPb3UQSeTixu+wH4yiLkdiacLY3ASkE+uEaFjuzTDIAE0gGp5VQsbzFIP+rn8+6A4lZjPn+iqKbDqZ8KOXOX1fPQa9dYoLrhlyKGsZJti+qA8IcAQTXW7kDWUkWJK+uArw+dGA66/vGM0h+9LZugK1jgoprVOCEQ6jbl5QchBQrsau X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 17:20:07.3370 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 98096c65-53ba-4fb7-5377-08dee9a7ceef X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F67.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8006 Content-Type: text/plain; charset="utf-8" setup_mcdi() currently allocates the MCDI instance, assigns the RPMsg endpoint, and retrieves DDR configuration data. The DDR configuration path invokes cdx_mcdi_rpc(), which requires a functional RPMsg endpoint. Split setup_mcdi() so that only MCDI allocation and initialization are performed before RPMsg registration. Move endpoint assignment and DDR configuration retrieval until after register_rpmsg_driver() succeeds. Update the error paths to match the new initialization order, ensuring resources are released in reverse order of acquisition. Signed-off-by: Shubhrajyoti Datta --- drivers/edac/versalnet_edac.c | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c index 1caaba653fc0..e9561242f292 100644 --- a/drivers/edac/versalnet_edac.c +++ b/drivers/edac/versalnet_edac.c @@ -559,7 +559,7 @@ static void get_ddr_config(u32 index, u32 *buffer, stru= ct cdx_mcdi *amd_mcdi) static int setup_mcdi(struct mc_priv *mc_priv) { struct cdx_mcdi *amd_mcdi; - int ret, i; + int ret; =20 amd_mcdi =3D kzalloc_obj(*amd_mcdi); if (!amd_mcdi) @@ -572,12 +572,7 @@ static int setup_mcdi(struct mc_priv *mc_priv) return ret; } =20 - amd_mcdi->ept =3D mc_priv->ept; mc_priv->mcdi =3D amd_mcdi; - - for (i =3D 0; i < NUM_CONTROLLERS; i++) - get_ddr_config(i, &mc_priv->adec[ADEC_NUM * i], amd_mcdi); - return 0; } =20 @@ -886,7 +881,7 @@ static int mc_probe(struct platform_device *pdev) { struct mc_priv *priv; struct rproc *rp; - int rc; + int rc, i; =20 struct device_node *r5_core_node __free(device_node) =3D of_parse_phandle(pdev->dev.of_node, "amd,rproc", 0); @@ -914,18 +909,22 @@ static int mc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, priv); amd_rpmsg_id_table[0].driver_data =3D (kernel_ulong_t)priv; =20 + rc =3D setup_mcdi(priv); + if (rc) + goto err_alloc; + rc =3D register_rpmsg_driver(&amd_rpmsg_driver); if (rc) { edac_printk(KERN_ERR, EDAC_MC, "Failed to register RPMsg driver: %d\n", = rc); - goto err_alloc; - } - - rc =3D setup_mcdi(priv); - if (rc) goto err_unreg; + } =20 + priv->mcdi->ept =3D priv->ept; priv->mcdi->r5_rproc =3D rp; =20 + for (i =3D 0; i < NUM_CONTROLLERS; i++) + get_ddr_config(i, &priv->adec[ADEC_NUM * i], priv->mcdi); + rc =3D init_versalnet(priv); if (rc) goto err_init; @@ -933,11 +932,11 @@ static int mc_probe(struct platform_device *pdev) return 0; =20 err_init: - cdx_mcdi_finish(priv->mcdi); - kfree(priv->mcdi); + unregister_rpmsg_driver(&amd_rpmsg_driver); =20 err_unreg: - unregister_rpmsg_driver(&amd_rpmsg_driver); + cdx_mcdi_finish(priv->mcdi); + kfree(priv->mcdi); =20 err_alloc: rproc_shutdown(rp); --=20 2.34.1 From nobody Fri Jul 24 20:48:51 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012027.outbound.protection.outlook.com [52.101.43.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 522C12931DE; Fri, 24 Jul 2026 17:20:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.27 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913620; cv=fail; b=ki1aIgyOi8KnlCTnNI0s3E8TNlTb34XLjqDQmkIxSf2PufWfyCwqb1wRShY1O4YcYpmPhg1RpwW4Fjk5JI51VhiIkXq5i5vyMATgRUx6DgIcSHjbo9aLDAGFZagrHzLW3yG8vJdjfpnKkoOoehQPfv0o5CWMut73h++fLGcTo24= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913620; c=relaxed/simple; bh=KmwzBRd/kgdJfC4SJ2enWYXoLOq6S9CRzPbQrB3hSl4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=obS/0jh4f8n3OefjuAol2DbGksC5vpX8snSjqsk2fi1zyqeVfOnVk88MIms6MegFf7JcSDpaeodDGkg6lTd9xhP7kk1eKAIYPClUnlQD+KjOFSoF9q3ZbCFWzVspY56+346X5H6D5KOpmk5b67Sy0B2dh5SZvqjbiSDSn4rSPVg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=cWb8ul5H; arc=fail smtp.client-ip=52.101.43.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="cWb8ul5H" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=T0W9kSqmb8qZYFuyd1PFPjUkfFUHhuhXS3eRYREC8yPt2cE0LXXjf4390ch5adrVpGOignJrJgDHM+6FEG4OLncTfbdOMAeEAyb5EIEOaeARta5ASMtm9tUTPkl1KzXshr3VSbuLyzoGI52AEPQ2lQTnZae2ts+q/jcLw2z7qSeIrCo4GD/PsHa++rMHDBotQxlXO6egFqAdLhD9S9EUVPiQ+xfDZu4DzpD4F33JVdvzaH6FxJPD2LA6iytT3/SRGdADH+Stypa3ltUJevTNUhK3JMQsQgl0GlKzO9zVLbim6ioJh4P1HS3DQ2h29+Bg8rxP7g5Ks98P/jmgvkenYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Xh7SyUgrH8zS6gxQPPkuamEXaaQr+LH8n4Eu+2gOyA=; b=WEiiUb26i6Q97ncY0xFrj1P08fXAb6r+R3Vxd4oxnO7Sv0J4aOGnSBfEuXBmPBbxcC1AptCL4uTisb7nBJXh6H32GDaRs8CsHMn78VkghPTI3IkQkJpaPefV4F1/IkJQTQP6Q+kB2WmlxQAqvBqIBOSKNJz+uI9R4M+BaFSmSkEGCBfnpUWYfdaE3j33YYuPq+wuP84SoazIbyqlFxp2XyK6alIdXtTc6QTVM4LxwsDZQCqQVm3qydmrc6x5h9MNnUDXPy9tE4WeSMZBClJhtzCwYyIq5I/ie/GdE3NkFf6hAP8gMCQj1u6vNhjsiwDlBSZQQhBQ1aPtwrrQrQlhHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Xh7SyUgrH8zS6gxQPPkuamEXaaQr+LH8n4Eu+2gOyA=; b=cWb8ul5HKofazlz5zl5gdgovD81csWgTk2+deONJcVZYR+k8GN6OFCHkc3w2z+AsG7t2g0CtegC3GhZTDEpTlJTU/V+E7UKGgm+RDQPLqpEjvWG8UHLpiJViufUIDI2TdoT6vUJPsphur6fm0GA58nhJ1GbXU4UjDm1sf0E82YI= Received: from PH7P220CA0045.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:32b::17) by PH8PR12MB7326.namprd12.prod.outlook.com (2603:10b6:510:216::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.11; Fri, 24 Jul 2026 17:20:10 +0000 Received: from SA2PEPF00003F61.namprd04.prod.outlook.com (2603:10b6:510:32b:cafe::50) by PH7P220CA0045.outlook.office365.com (2603:10b6:510:32b::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.12 via Frontend Transport; Fri, 24 Jul 2026 17:20:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SA2PEPF00003F61.mail.protection.outlook.com (10.167.248.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Fri, 24 Jul 2026 17:20:10 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 12:20:06 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 12:20:05 -0500 Received: from xhdshubhraj40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Fri, 24 Jul 2026 12:20:03 -0500 From: Shubhrajyoti Datta To: CC: , , Michal Simek , Borislav Petkov , Tony Luck , Subject: [PATCH 7/9] EDAC/versalnet: Add bounds validation in rpmsg_cb() Date: Fri, 24 Jul 2026 22:49:43 +0530 Message-ID: <20260724171945.2812749-8-shubhrajyoti.datta@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> References: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F61:EE_|PH8PR12MB7326:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a758b98-ac1d-47c9-e9c2-08dee9a7d0dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700016|23010399003|1800799024|18002099003|22082099003|11063799006|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: raExrQxa2wca4ENaAAZnZi1eSC9uvt7nVyIPUcBJ1yeAwQ/OaqJ4uh716Lg5pYxs9sQMhJfS6Z0QSfL10sgNLZdqXhWeFr6Ta0CBCxJBpFN7Ss35sfP6W8QFkCHTnLO/LsABnNaHvjrkZYKZLJGTy+3uLBNMBroyRvAdGDa+3o72YDvXwA8SOpYgBCsWQu1IiM5OnIt+mRfSQ+h2HG2SOZauvACG0T9Qp2hKcMR/WpAlk8MFAXGN4VVbAf0VByMvQDvGlZN3HbnvIcidPSi0RO/CAuUH9jt6WwSHcHJ8VGK4/5S7uh2/blKNk43mZAeNL7zx5vNiE/5j9GPo0s2QpT0rtgdNTFcBHYjnVOfDAn5Z9AWm+iN8NtWhmkHyFWy40sVbniNG2tSvsSUPvPXyDHiiEnENSITrJbUTSt682OpbieVWZ21l47mpHpbHOssDH5o1dzec0wh7rS/JqS18I11FgWMDaWfinba4O36Pwiurhcsn6kngcIDGnXguFU8G1/aUW1L/AeHoIIV5j7osu2uotIwiFEFn+UNJDoMV+MlWGLfu6Hc3oSwq0uHG9+NTTMQBpSUOIi2lKeg/45ABRGHyFzOJcL3maqfwR+2rBGJdkwXcxu6XHKjQuYh/v5kOWlW2dv630/Tm+zIIj4E9ei48Tv7PdwVIvlSOFqK2J+mqt7Jcg4FlGUMDUYeQ4jK5pXAb2+GC3y5MmCym607zgQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700016)(23010399003)(1800799024)(18002099003)(22082099003)(11063799006)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: iseg5xKuDZ9jaGjo6aJwKh8iktkOEb+XIo7oMwqwb0T9xZUu5d8d/pU1DclTS3rSgQ2geyO9ieb9n+4MrxOYL6JzmnRWnTwUwTq8QjNbOBsEuN8N6t8y7i18tICek37kNCMOn0Dw1myzbJAWlRLSGJXsPuUVwNdjZXC398s7Sp5ZHDoL8pleJBFmYrwwqx3rBDGiXzSfcqPK9YJso/bIaVZQRgtppvkdGTvnJSAdIeyOJl2GL+O27YoxvPREdhM8gN1x4VBaQ2RllDrxN94qgMujM+OwckjmXdAxjaEiJimDRUAPXs9FIruUBDndtlvH/VZcW9lsfMrO5zjYDGsbd5u/7yXHylEXBGUlgKU+kPkHDISUY5mDn5IYJueZROBUOTVZsD1XpzKdzZK2uZXdWcw+zo8gVUtSgtjC/VjxbwSmTostRa+jwN0Do2TlrujS X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 17:20:10.5877 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9a758b98-ac1d-47c9-e9c2-08dee9a7d0dd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F61.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7326 Content-Type: text/plain; charset="utf-8" The firmware-supplied offset and length values from the RPMsg payload are used without validation to index into mc_priv->regs[] (REG_MAX=3D152 entries). A malformed or buggy firmware message could write past the end of the array, corrupting adjacent structure members and the kernel heap. Add check for the same. Signed-off-by: Shubhrajyoti Datta --- drivers/edac/versalnet_edac.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c index e9561242f292..baca90f44c58 100644 --- a/drivers/edac/versalnet_edac.c +++ b/drivers/edac/versalnet_edac.c @@ -602,6 +602,9 @@ static int rpmsg_cb(struct rpmsg_device *rpdev, void *d= ata, length =3D result[MSG_ERR_LENGTH]; offset =3D result[MSG_ERR_OFFSET]; =20 + if (offset + length > REG_MAX) + return -EINVAL; + /* * The data can come in two stretches. Construct the regs from two * messages. The offset indicates the offset from which the data is to --=20 2.34.1 From nobody Fri Jul 24 20:48:51 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010037.outbound.protection.outlook.com [52.101.193.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D163345EAA; Fri, 24 Jul 2026 17:20:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.37 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913621; cv=fail; b=Kc2yYOreSw/C6fzEfrVG1mHFByPA9XUlm1nXuypG6Myb9gerLWKv0zKV3l+W20cG1QlN4jygLB7K+XRZR5ZFqTpxpKiw4l2GVw0Rd9tx7avmFt5t5kWs3PtfouimhvINcpxqmoltjBwOQc1nQa0SgCMBIsrQvVCjw12KDRxuhdk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913621; c=relaxed/simple; bh=qiDipzY1wGToggmaXi1R6RCLRlVDQYbTi+jxmaKq8Ag=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KbD7qQcmyTA9WH0Xjjtw3yPR8JAi4I/RCUB3b7WBRdzoGQBuwB4clLs1kkQce7kcqnNN5YMyNaBi0Sr8QWFetBn7fbOv1NnPkpyHQo23xlo3ckVOfl1se4y183qsgqKY/EzMstd5b/fAJ+g4d9pFk0i2/oiaShnogVfS7nCP8ug= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Gh8eKizC; arc=fail smtp.client-ip=52.101.193.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Gh8eKizC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ML/IorKw2cwCmGPT3IJSdPZ5UsdaaZaUR28meFKRPXAwvPVSulpQeIdbsFPP10wKkRGyIc7jAmvJIcfamG7GtpToLiq1VEDWocVby+ds7yVwH1saL46NUJyXte/PgYmwgMqwwpxcP2b7qdBJwx7HTTd4TW5UgVzd6dJSL5ZjFk+7+iqt04tukb9RUoA94fu6mI7/6pr4vSSojWhDAT5/VtZYaH65S/kSKWKhwegBYNPuv+4ZSBTJK2WwGL5reVksNCSPrGr8huibFjRTy7046XXQPd8GZpCanbiC8NFb7cToU9dFDIgCWjYyOXWrU0ZX3sDhfvFNyq7JBhLa2JtIjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e4sPDJEE8z2PAm5CDZe9JognrSs1z7jePZVNRW5+nKM=; b=st+imQu+qb+5xsN0SEXIstXRAqz8wFXLsurcjutJEFG1AaQItaVX6vI5eQZTrQnaxHH5+IfkSZzYFCCKGL3aT9tjR1w0rBQLCDoRSAuXsVB2rpKi5nrFEBltf2UsZh3IoJRkHUmk4s0mpxSHRGJMIQ+xb7iOY8CSWRVScl4PRXH9c3Ob3KRs0/sspY40IJzbpBXXgzXt0up3lZiHoHyC4/nv8ESnn+9Iz0A1q/TyZjIHFDs+RZM1JZ3x8hovEeJmMHlcLq+4pX1diw8NK5ELDk4CQ1FgYZ1Gta+3uEc51I2TiDTPqAHgnoFasxuQXF85EGLHoP23pQAwQ4frhjfTYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e4sPDJEE8z2PAm5CDZe9JognrSs1z7jePZVNRW5+nKM=; b=Gh8eKizCPfJN8rwZXG5ihyRD7JqpOoHsV01tl/x6MBNNFOoTIVw3qVmoRVQQyX/Z/BasKYiImG5LBlcItcEAXfPz4xzDk5k/Y5ZOAkAMn6PAmqHDAFqLv2UZFQCiUSx/93S5iO4SaooOxAovAAUmSUz/BaQms2rx8zCr9kqdMWs= Received: from CH0PR03CA0099.namprd03.prod.outlook.com (2603:10b6:610:cd::14) by MW4PR12MB8612.namprd12.prod.outlook.com (2603:10b6:303:1ec::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.12; Fri, 24 Jul 2026 17:20:14 +0000 Received: from CH3PEPF00000010.namprd04.prod.outlook.com (2603:10b6:610:cd:cafe::26) by CH0PR03CA0099.outlook.office365.com (2603:10b6:610:cd::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.12 via Frontend Transport; Fri, 24 Jul 2026 17:20:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000010.mail.protection.outlook.com (10.167.244.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Fri, 24 Jul 2026 17:20:14 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 12:20:08 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 12:20:08 -0500 Received: from xhdshubhraj40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Fri, 24 Jul 2026 12:20:06 -0500 From: Shubhrajyoti Datta To: CC: , , Michal Simek , Borislav Petkov , Tony Luck , Subject: [PATCH 8/9] EDAC/versalnet: Fix use-after-free in remove_one_mc() Date: Fri, 24 Jul 2026 22:49:44 +0530 Message-ID: <20260724171945.2812749-9-shubhrajyoti.datta@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> References: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000010:EE_|MW4PR12MB8612:EE_ X-MS-Office365-Filtering-Correlation-Id: c6b3721b-9af8-4ecd-0872-08dee9a7d319 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|23010399003|36860700016|376014|6133799003|56012099006|5023799004|11063799006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: QzCZI8N4ambnTddpbOp6ZqfAP45fRNiq1l6t1RP1Bvn8gfcBOnJam3IQuTMCtoXN/bOwpxsQ4BsgHjftTgayKBYbtNJdfpfukwXmTLGe9P+CclWuuLA/DpLSj6mM/4SZd7R56B20heaYUorz39JMJgg+LAUNj2E3JndrDV/jkCnykFWMBSnb0rOrrj8irHwNhSAnBByMngnbxrMLkaTK5OzZpBm4uwLHyem1a1/KsYZEv9MX9vLh33O3vGBadQ9J4+cK10JMf7DyUQvcaO7Nr7o5ckE7R0X+2BPAN7CrLma02gYE+xS0Bui5zapccIw+xsiyY8+0VP1865L3gujt+y6Yf4ZdqBPYyqbBhhb/StQb4RgHUaTxEO/CR41rrMKo66YCQ9FFqNOTwZeJP4CUmeB59A78SgfwLnMWA8XgFF2Jfu4SzXTlXriTeldE2eeupG5q/hHY9FJSoTLrSS8KH0Tvd4YZvRqTNrnlfet7ur0SUbqgAyUL8mefzGhJFuec00r+MFeNEc+56g8ojp9K9aBOwcs+4dxujFl8JuLMwa16JBCCPEczLmrsyX9qiSKPYUd1+dJJGD4QYMwTwMePe/s+8szmtO10ytjoTFZXeUznoNoUssInti/dM9LV4tN/0TkdO3EOoYypFqldJIJiZH0krVj+DQtg8MVfSpPuGhhyiQfGY9sWuMCai3AiTrPh8oLfrTwIE/efVs60x5f8kw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(23010399003)(36860700016)(376014)(6133799003)(56012099006)(5023799004)(11063799006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DMnYiUAM/ibBMHT4Cls4rM1sQQLY2rYecaVrhB8hhHJkC5OAzXNqWN7cZzZIjRNb8dBova7ug/RZEAe2s0Z33ThDCw4TprU8wobTb6hASH6gATrSgDFcjWhPaO8ZAuVxFcu6aq1gcwL4fxzTiDoUJQMF9fupu89JsyRVyYtQ4hoEwvVzh4qyRfKXLJhEKBrVsSUBbLcvDIICb4wYCAlW5XZL06uUXb3VAEWCCW950XdMJvYdgcWqw/J7piFnKaGv5TIf7H+hNYke3y78B81PbV91Ltw3NDL29s+za0BftuhhxAALLE83VDkDaQL2Q4NfP1LvcJuvwQmn5oVo0CHw0yFbKKZK6Sa+5N4FtxqqX8PWG9YPJ1quMW56knhitxER2fz5ltDViaSyK6AEocfr9vBthPKkNE5jMl80IVlJYmm02zpWJSIwGp28WgGPEYq4 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 17:20:14.3325 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c6b3721b-9af8-4ecd-0872-08dee9a7d319 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000010.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB8612 Content-Type: text/plain; charset="utf-8" device_unregister() drops the last reference on the device and invokes versal_edac_release() which calls kfree(dev). The subsequent call to edac_mc_del_mc(mci->pdev) then dereferences the freed pointer. Fix by saving the device pointer, calling edac_mc_del_mc() and edac_mc_free() first, then device_unregister() last so the device is freed only after all users are done with it. Fixes: 62a9fc50e8d9 ("EDAC/versalnet: Refactor memory controller initializa= tion and cleanup") Cc: stable@vger.kernel.org Signed-off-by: Shubhrajyoti Datta --- drivers/edac/versalnet_edac.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c index baca90f44c58..ba295714d972 100644 --- a/drivers/edac/versalnet_edac.c +++ b/drivers/edac/versalnet_edac.c @@ -763,14 +763,16 @@ static void versal_edac_release(struct device *dev) static void remove_one_mc(struct mc_priv *priv, int i) { struct mem_ctl_info *mci; + struct device *dev; =20 mci =3D priv->mci[i]; if (!mci) return; =20 - device_unregister(mci->pdev); - edac_mc_del_mc(mci->pdev); + dev =3D mci->pdev; + edac_mc_del_mc(dev); edac_mc_free(mci); + device_unregister(dev); } =20 static int init_one_mc(struct mc_priv *priv, int i) --=20 2.34.1 From nobody Fri Jul 24 20:48:51 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010069.outbound.protection.outlook.com [52.101.201.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA56244C4E5; Fri, 24 Jul 2026 17:20:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.69 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913632; cv=fail; b=XHS27ytrfqcE9cwNxzEVG6rtU4LYLAV91ldApM3HiXVhk7oSM7lkaJkDUNmJ1GGDp8fXrcGyy1ZDCVk7DZXj9kzS3lHLAOE7tqw3Kg8idSjIzKtDD9QFvTtypaHz11woN35P8Y+90CmGD4491sceszo3YcCVEzn/MkR9YV8GBUQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784913632; c=relaxed/simple; bh=GYsy3r0v4j0BcVvJdjhntaHH+VtiVLDZQo2oZZc3Rrc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JfOjBA+prGPYbkjrMQwwR+giWu4IAY0GZhw7syNUF1FBTYhxcn4Xi/OAdKN4U1QdQpDCREAb42BIAPqyIcLCkaSD3458FxYORvXw7AVk8mxX479FgCafRxyQ+VzcI8nNxv9yUuYzRD9VrufS+MvAVpvtDp9Ip/DUn4jEvGDrETw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ZrmF1o4h; arc=fail smtp.client-ip=52.101.201.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ZrmF1o4h" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DBUXg7DzF3aR/MqsZtvE87X/6fRkkq/6z5D9qWHYVg7Tj1eP3ocET5ut1Y1WWFbm29B9MyIrheLo00CKiYGPp5/mUH9TS/52llRx5P7nxcvU/01g+jOYtA/nH0tzaau5INJtwcaTdCq9MN7huMTsmyuOd4OtftWd3ojoZRh5jRu0ng4qV5s+etmPLQLw1vBJhGNV27jRMwqmw68HBpzbXmCWcTnzwz6y/PBysIr9eLiHeg7Yoe42zu2hfnnJC/Q+wrBC5LEa+c53CzGMHNsDIp67RmjZZSr1xi+dVeoSK/Cklk/C9entlZhFiPsiNPymLLcAfHEqMFJjOkcofCnEjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5UVs9Pb1KTT7wVg6dGfcjxY+pcXzGmCqTbwntJ22JOA=; b=FB8WerDfkLvQedUfPK4X2l09KP4hoorP/GCs3ASd9++RywS39NURZ8C4kt8z0PNdd4IuTk5F6JDHZTk6xHppN5r5d2Kz07VJbt1HPoHm3FrrFRts+xfwLXRsIUy/7IkhnrWm7XFZHBE7w+e42POD8sK8DV+EZp6cvN7i262A2wx8egzDg7qBePMjDXkniIuB0dA0Osx1DpLMpc8/w8vm2Dm5KP6ZzuFBnGRxUGmHI9spTe4wLdjA96GobRYATYuhE09gr2xHujpolXKE5tsDCwc+iLchOFEZsHVdyJ8O4vI1YcC0u/QeaNFwnJzu9ZFxHZnx7QO9JJz/MzYZh2XXrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5UVs9Pb1KTT7wVg6dGfcjxY+pcXzGmCqTbwntJ22JOA=; b=ZrmF1o4hNkrkgisXu8M4N+a2Wd7GNHtR32JEenR8xyqZm6ylI+rMk/kRRfN8m1gT6yl5JxPJoAv3Ck5NfHFMpu4snY9OmLgs/SBx8mctaxpn0HQ0MMtxu0NA6gGKXaOWOddvT1206fpd58bnb+K/PQyfrEcsMX+I94MLnBYD85Y= Received: from BN9PR03CA0227.namprd03.prod.outlook.com (2603:10b6:408:f8::22) by SJ2PR12MB8157.namprd12.prod.outlook.com (2603:10b6:a03:4fa::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.11; Fri, 24 Jul 2026 17:20:18 +0000 Received: from BN3PEPF0000B06C.namprd21.prod.outlook.com (2603:10b6:408:f8:cafe::9a) by BN9PR03CA0227.outlook.office365.com (2603:10b6:408:f8::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.11 via Frontend Transport; Fri, 24 Jul 2026 17:20:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BN3PEPF0000B06C.mail.protection.outlook.com (10.167.243.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.1 via Frontend Transport; Fri, 24 Jul 2026 17:20:17 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 12:20:10 -0500 Received: from xhdshubhraj40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Fri, 24 Jul 2026 12:20:08 -0500 From: Shubhrajyoti Datta To: CC: , , Michal Simek , Borislav Petkov , Tony Luck , Subject: [PATCH 9/9] EDAC/versalnet: Use designated initializer for rpmsg_channel_info Date: Fri, 24 Jul 2026 22:49:45 +0530 Message-ID: <20260724171945.2812749-10-shubhrajyoti.datta@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> References: <20260724171945.2812749-1-shubhrajyoti.datta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B06C:EE_|SJ2PR12MB8157:EE_ X-MS-Office365-Filtering-Correlation-Id: b9ecef04-861d-4958-79a4-08dee9a7d545 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|36860700016|82310400026|376014|56012099006|10067099003|22082099003|18002099003|11063799006; X-Microsoft-Antispam-Message-Info: +UMOmod+mG4REoof/uzNU/mwdrLBbSajg/qgjDo0WwqFWW0iwNsgTcKdFXr48twfnUMT1Ok4ldUCJGKtGbKDHY96j4HZYpWnBc3Dxz4GVKRY7kdatF25CaBA9LNSxk8zFLRoVaEV9YNozZZJlHZlImjzaaqYImZIhtXk4MINkRCo4Gv1yJKAh1g0zWjuPYWJOIuNNjG7omcGMQePvQsXjngZ9rhONIMF6bj0KJzLvPYWPUzhqaRBdtLG9GoiZZauCKNLWukoWN7iyhVQHi0w+aD9t6q+3ULrebBqaGqP/xCt4kFb7j/h+uoOsVgnkWL/hANH1+zWPeOREtD9M9Yd9CNbMPTFhGNpvY0jXsocz1e5466U0mgGHLfN6Y1DEV0SjXEhXQDiF+HV9iZfaHel1gWS3ubBYccZzbRbjMFTHe9EaXOMFzLtsLg5O5HHQDJOo5FwpuLVbkcoq9aUoVsAbXiJM8DHiWcsjOeRDUf8BJdUBb/QB+Ecr8/ArdxOEcjUkVE8ssD/76RHtxLI/uaw02RlmsZiXfPboOIy+Dq6b8bZ9tZB2hmiEp5Y5pkd1cH5j6MExLmD48RlJUjDsdtcknwxwbSXy3O4zNhhQl1D74PtgfRBPiAw3CmESahcZN68v2N6YePXNS8c6httTgm76XhG3fxHvaao+DItaStmZv1H2uNOkQaKqbtRrpBaHr9jPF+pSXJmAryulg4hM9aMBg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(36860700016)(82310400026)(376014)(56012099006)(10067099003)(22082099003)(18002099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 9CpuzvlX/YiHsjZFLF6SauplPdbsu8+6At5RgiGffc9AaJNsvUvY5fD8sjlZasXPEyl1h0MIG9Q/TYJoe/j1cBvSJLQ8Xd6NCPkFBhZFsA8HnWvN8r2d7nIWbGSPDgwOJIY02LNK4ihkUjUSL6q0S004sYyVcH8PMNYDa6Hr5hV6koJCVNZNCIMPEMH/HGAvq/dAB0Zsiu9xLVfAeK/r3S5YF1JN414IrihL6KawNQO1CuZDQ0lgTHJrfnwU5Zba8QAnr1yu+28NdMKB568EdCihEUiwV49cFAPDjtmNvbJSluHbcraryvtZGvM/GGma60BHiX+hytqjND4byN17wQ+zqAIiDNZr1I3CmkpaDHVjkSlmVf+t9p0Y6WlxorMHoDrYvdv55wFH8youxpkqJcW3ynxQrmvCi4pTJCuCupVWj48idsl8a48o3wln9MfK X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 17:20:17.9717 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b9ecef04-861d-4958-79a4-08dee9a7d545 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B06C.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8157 Content-Type: text/plain; charset="utf-8" Replace field-by-field assignment of struct rpmsg_channel_info with a designated initializer. This also fixes the incorrect use of strscpy with strlen which could lead to silent truncation of the channel name. Fixes: d5fe2fec6c40 ("EDAC: Add a driver for the AMD Versal NET DDR control= ler") Signed-off-by: Shubhrajyoti Datta --- drivers/edac/versalnet_edac.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c index ba295714d972..88b24eec4206 100644 --- a/drivers/edac/versalnet_edac.c +++ b/drivers/edac/versalnet_edac.c @@ -720,14 +720,14 @@ MODULE_DEVICE_TABLE(rpmsg, amd_rpmsg_id_table); =20 static int rpmsg_probe(struct rpmsg_device *rpdev) { - struct rpmsg_channel_info chinfo; struct mc_priv *pg; + struct rpmsg_channel_info chinfo =3D { + .src =3D RPMSG_ADDR_ANY, + .dst =3D rpdev->dst, + .name =3D "error_ipc", + }; =20 pg =3D (struct mc_priv *)amd_rpmsg_id_table[0].driver_data; - chinfo.src =3D RPMSG_ADDR_ANY; - chinfo.dst =3D rpdev->dst; - strscpy(chinfo.name, amd_rpmsg_id_table[0].name, - strlen(amd_rpmsg_id_table[0].name)); =20 pg->ept =3D rpmsg_create_ept(rpdev, rpmsg_cb, NULL, chinfo); if (!pg->ept) --=20 2.34.1