From nobody Fri Jul 24 21:29:11 2026 Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A001E346774 for ; Fri, 24 Jul 2026 15:06:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784905604; cv=none; b=FuC/hc2cTrc876yVGQFqUYprd/Z43tDFT2FJWXww+4Oob0R4eBxZA6v1o+TCmzw1GIWHN0znyK81dENB8jgST5OaGW7Bp/OaZXQ5zK0ErUaHer+sVkaAOZQ1uj3BjAsE5AZ88n5EVhCrjalKqbjTLKr6I1ckTcqufeyYOqe4Ozo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784905604; c=relaxed/simple; bh=WCFeK1U/sB8u6+XghEzeDL5uvuawBnLyk20EecCgWSc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SypvY+Tn6Kbt2LQJf2gBy45vSP1/HP328caOe29KFlEtf/XmI4FLMuDHFfBdneRkgJxeRfnO/HjFFjX2tQzIzCvNbegNEJHf7SkuLGYrC2CuqqZok2iuVrCxLIyv34UOGAF4dk2mylv66pZHEQJeErrqS2O7WjJkumvJvzuGVR4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gXq6QU+3; arc=none smtp.client-ip=209.85.217.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gXq6QU+3" Received: by mail-vs1-f45.google.com with SMTP id ada2fe7eead31-74d55dac06dso131870137.1 for ; Fri, 24 Jul 2026 08:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784905597; x=1785510397; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6oyqB7q7QHkqcZKXENbolthguPaX/LV0/csmdxwyvY8=; b=gXq6QU+3Qy1TeVqxyjn0hdRDRTYkqUieAMH2shLXY4sgOR9StX1V6kGtTXSEjVulwT kWbNHiCPx8TR3i0f+4ysV+PLhboKdDKxNN1YXI4TUEtdrViovBVQDTbel2WzOiEBVyWd q73LrMTGCq5ITpAkvhkGPJXiJ28BU6HCJ85zclS9uIp56ksKXQhCAYz2L66ZjTNFPL2F HMlenBYPKQun5QDq4GSqxA3qx8z22rZhgjExfTKcxyE0A+GhDZTg1PgWD8+CxtesjOEk CdUc86NdhGFy9TiUmvt6ApWXOc8JWqH5VQ/dfFt1RxJlf2KCa+wiLYoUWhGIz7+stDgE tnlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784905597; x=1785510397; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6oyqB7q7QHkqcZKXENbolthguPaX/LV0/csmdxwyvY8=; b=MDzfIZxbEA7/r3bHfJnSPjlVJnF7q7EuqkG1O3R/1wQwOPlHZNZH6KSR0CfYVSksCV 3jc141Voujtd1fZwHl3P5y6J9x9oS9+fPrA4fjF/hv00rZxn3kchCapUR3V7qB2PtA3N 9XzVYZTTbYDHeNU4WTYQmRgYBK15l/JXTcjMR2cl3NHhvHz7vY9dEppaes4p004m08jM 1TIiyk2fgevGUraLg1Px9hUxrnDOiehcj8dIuqTEnbPFQY35lCTBQ+RnxVCXw2Y6S23/ L72JXg/sT0XdJkny0A71qMO3DEB0X9lkg2ny5wf9SGPRJS0FVUHWb4C8TNj/Jj4KM+S8 IplA== X-Forwarded-Encrypted: i=1; AHgh+RruJD2r5bKPlfG+73YBQjAFaVaPDgOlqyITRKcFkNT2bGqrr/674cNDdyhvGCO+pk6cLt+ZBKt40rbtRho=@vger.kernel.org X-Gm-Message-State: AOJu0Yxtb0tRuAE5T6LgZtXuljVUE9hN1pXBYZZortd/bNC+nMOXWOXf +4fNTwnOLNry7ZuU57+6pN8nkzTna/LVkV6YAaLQuSDkbaQiIcHcDEyQ X-Gm-Gg: AR+sD139ZX+Sw9g1GnFO2Yy56a0+kE+3cwo9ppJ4Ox4Vf/Ea2T0+LFO+X4cTYssWZs3 D5HXiz4M6VgflVlFnfGp7ms7JNXQXwkbwkbj1i9fR/V0wqqstkEtnQs7l4MpxKCKXskwHw806Ic BwkeL4N4XAl0+8jrKeb2VIYZXRVCHThYDaAPG0RFnhsmNfBhherPUHsSRFGLqW14wQuNX8Vl44W 8MCkrrdBg8U0dc8pvofvut2aKuhCvt5Y1dS84kRMDV4NlRvY+/qRNgk5dTO2VKw5lQJebBDpf37 6X3561nr84Tzbf6YLTUyy/9oGcmMw/byahO9AMYkffdLszUw1T5+aCxRA3HDvWqMrSEgz18Gbxa cDodhZqymIHbQVx/ueXrajbYENV8l1Wzlp6pIx4mWnz5uoTOmUOReqiqP8VwHvEEBxGTFmw== X-Received: by 2002:a05:6102:2b83:b0:74c:7dbd:8c89 with SMTP id ada2fe7eead31-74d60909992mr3314336137.25.1784905597005; Fri, 24 Jul 2026 08:06:37 -0700 (PDT) Received: from houminxi ([72.244.37.221]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-74ad32165f4sm7744810137.6.2026.07.24.08.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 08:06:36 -0700 (PDT) From: Minxi Hou To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, aconole@redhat.com, echaudro@redhat.com, i.maximets@ovn.org, i.maximets@redhat.com, dev@openvswitch.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, horms@kernel.org, linux-kernel@vger.kernel.org, Minxi Hou Subject: [PATCH net-next v6 1/2] selftests/net/openvswitch: add SCTP flow key parsing to ovs-dpctl.py Date: Fri, 24 Jul 2026 11:06:23 -0400 Message-ID: <20260724150624.3457427-2-houminxi@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260724150624.3457427-1-houminxi@gmail.com> References: <20260724150624.3457427-1-houminxi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ovskey flow-string parser has no OVS_KEY_ATTR_SCTP entry, so a flow string containing sctp(src=3D.../dst=3D...) parses without error but silently drops the L4 key. The resulting flow carries only ipv4(proto=3D132), and the kernel rejects it: match_validate() in flow_netlink.c requires OVS_KEY_ATTR_SCTP when the IP protocol is IPPROTO_SCTP and returns -EINVAL for the missing key. Register OVS_KEY_ATTR_SCTP in the parse table and add unit tests (runnable via ovs-dpctl.py --test) covering SCTP and the neighboring TCP/UDP/ICMP/IPv4 key parsers. Signed-off-by: Minxi Hou --- .../selftests/net/openvswitch/ovs-dpctl.py | 129 ++++++++++++++++++ 1 file changed, 129 insertions(+) diff --git a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py b/tools/t= esting/selftests/net/openvswitch/ovs-dpctl.py index f3edd198223f..633af10d7e8a 100644 --- a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py +++ b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py @@ -15,6 +15,7 @@ import struct import sys import time import types +import unittest import uuid =20 try: @@ -1984,6 +1985,11 @@ class ovskey(nla): "udp", ovskey.ovs_key_udp, ), + ( + "OVS_KEY_ATTR_SCTP", + "sctp", + ovskey.ovs_key_sctp, + ), ( "OVS_KEY_ATTR_ICMP", "icmp", @@ -3165,5 +3171,128 @@ def main(argv): return 0 =20 =20 +def _init_ovskey_nlas(): + """Initialize required NLA classes for ovskey parsing.""" + nlmsg_atoms.encap_ovskey =3D encap_ovskey + nlmsg_atoms.ovskey =3D ovskey + nlmsg_atoms.ovsactions =3D ovsactions + + +def _parse_flow(flowstr): + """Parse a flow string and return the key.""" + key =3D ovskey() + key["attrs"] =3D [] + key.parse(flowstr) + return key + + +def _find_attr(key, attr_name): + """Find an attribute in parsed key.""" + for attr in key["attrs"]: + if attr[0] =3D=3D attr_name: + return attr[1] + return None + + +class TestOvsKeyParse(unittest.TestCase): + """Unit tests for ovskey.parse() flow string parsing.""" + + @classmethod + def setUpClass(cls): + _init_ovskey_nlas() + + def test_sctp_dst(self): + """Test SCTP destination port parsing.""" + key =3D _parse_flow("sctp(dst=3D4443)") + attr =3D _find_attr(key, "OVS_KEY_ATTR_SCTP") + self.assertIsNotNone(attr, "SCTP key not found") + self.assertEqual(attr["dst"], 4443) + + def test_sctp_src(self): + """Test SCTP source port parsing.""" + key =3D _parse_flow("sctp(src=3D4443)") + attr =3D _find_attr(key, "OVS_KEY_ATTR_SCTP") + self.assertIsNotNone(attr, "SCTP key not found") + self.assertEqual(attr["src"], 4443) + + def test_sctp_src_and_dst(self): + """Test SCTP source and destination port parsing.""" + key =3D _parse_flow("sctp(src=3D1234,dst=3D5678)") + attr =3D _find_attr(key, "OVS_KEY_ATTR_SCTP") + self.assertIsNotNone(attr, "SCTP key not found") + self.assertEqual(attr["src"], 1234) + self.assertEqual(attr["dst"], 5678) + + def test_tcp_dst(self): + """Test TCP destination port parsing.""" + key =3D _parse_flow("tcp(dst=3D80)") + attr =3D _find_attr(key, "OVS_KEY_ATTR_TCP") + self.assertIsNotNone(attr, "TCP key not found") + self.assertEqual(attr["dst"], 80) + + def test_udp_dst(self): + """Test UDP destination port parsing.""" + key =3D _parse_flow("udp(dst=3D53)") + attr =3D _find_attr(key, "OVS_KEY_ATTR_UDP") + self.assertIsNotNone(attr, "UDP key not found") + self.assertEqual(attr["dst"], 53) + + def test_icmp_type_code(self): + """Test ICMP type and code parsing.""" + key =3D _parse_flow("icmp(type=3D8,code=3D0)") + attr =3D _find_attr(key, "OVS_KEY_ATTR_ICMP") + self.assertIsNotNone(attr, "ICMP key not found") + self.assertEqual(attr["type"], 8) + self.assertEqual(attr["code"], 0) + + def test_ipv4_proto(self): + """Test IPv4 protocol parsing.""" + key =3D _parse_flow("eth_type(0x0800),ipv4(proto=3D132)") + attr =3D _find_attr(key, "OVS_KEY_ATTR_IPV4") + self.assertIsNotNone(attr, "IPv4 key not found") + self.assertEqual(attr["proto"], 132) + + def test_eth_type(self): + """Test Ethernet type parsing.""" + key =3D _parse_flow("eth_type(0x0800)") + attr =3D _find_attr(key, "OVS_KEY_ATTR_ETHERTYPE") + self.assertIsNotNone(attr, "EthType key not found") + self.assertEqual(attr, 0x0800) + + def test_full_sctp_flow(self): + """Test complete SCTP flow string parsing.""" + flowstr =3D ( + "in_port(1),eth(),eth_type(0x0800)," + "ipv4(proto=3D132),sctp(dst=3D4443)" + ) + key =3D _parse_flow(flowstr) + in_port =3D _find_attr(key, "OVS_KEY_ATTR_IN_PORT") + self.assertEqual(in_port, 1) + sctp =3D _find_attr(key, "OVS_KEY_ATTR_SCTP") + self.assertIsNotNone(sctp, "SCTP key not found") + self.assertEqual(sctp["dst"], 4443) + + def test_sctp_roundtrip(self): + """Test parse -> dpstr -> parse keeps the SCTP key.""" + key =3D _parse_flow("sctp(dst=3D4443)") + key2 =3D ovskey() + key2["attrs"] =3D [] + remainder =3D key2.parse(key.dpstr()) + self.assertEqual(remainder, "", "round-trip left unparsed text") + attr =3D _find_attr(key2, "OVS_KEY_ATTR_SCTP") + self.assertIsNotNone(attr, "SCTP key lost in round-trip") + self.assertEqual(attr["dst"], 4443) + + +def test_ovskey_parse(): + """Test ovskey.parse() method for various flow key types.""" + suite =3D unittest.TestLoader().loadTestsFromTestCase(TestOvsKeyParse) + runner =3D unittest.TextTestRunner(verbosity=3D2) + result =3D runner.run(suite) + return 0 if result.wasSuccessful() else 1 + + if __name__ =3D=3D "__main__": + if len(sys.argv) > 1 and sys.argv[1] =3D=3D "--test": + sys.exit(test_ovskey_parse()) sys.exit(main(sys.argv)) --=20 2.55.0 From nobody Fri Jul 24 21:29:11 2026 Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com [209.85.222.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD385448389 for ; Fri, 24 Jul 2026 15:06:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784905610; cv=none; b=IAR33Ub/zEk4LyiDNH6jkrb120HSctR40sKNFZVMxzjdSOOJp6e4qMqRI7qg09Kwfn+vqUxxK5ODLem7Y0uBftVDICzaL/4Uv18+LaO9UvMg+XL9eMzuBAU9CKaqjfqepGSwLh10/z7FW5AvMm3n/7UO6MVw/T5S5Iycjp9ijx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784905610; c=relaxed/simple; bh=aLvrgUhovUotbgq1yV5E5nzK8hKbIYLBa8oT5Q49nik=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CRAy6HTSxz0NfSstuZXtHWu3jCEJiA0/GHzGUqt6ebyX5pH3sSK5zsD2JN5BL4NdH3WDwo2jzX2AB3dGeAigXBmMJPVLtoFjEwn+8Ivgg89QqW1doeUPWX7KC1dDZi9b/WaM8tTO32MUsQWmDeH6YBAuDqxXz98RdW2bz+/1zvM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ATVgZt5R; arc=none smtp.client-ip=209.85.222.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ATVgZt5R" Received: by mail-ua1-f41.google.com with SMTP id a1e0cc1a2514c-97727c2064fso268018241.0 for ; Fri, 24 Jul 2026 08:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784905601; x=1785510401; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5ElNQLPF+IOEJVGx3X6HzWFOmVSfbkgUy77zg9FdrcY=; b=ATVgZt5R23l2x1nh786HIA6mHuK11Zjb1jbVX8J0IaP8348yzH5cs1fMLQeq4dZlSd WtnK11qid36y4lHDi4ambFRy3Iu40g0MwAiMh8lfsIYw1JBu/NZMLgxamEPXil49WoJs oo5JGNY0i/5nkhwz1nY655IFTdJdxSLqCziRdJjMFutKjPfQdF/pFpn95l6/hxFVaAYz 01XpqWmJUGJ57ex7NIeB+ct7vng8PaCi4v9Tihn/0qQQPrO5/C+ueSmc7UpqCk9ar1IS CT3eL+XJhUP4yGhR7Jd/9luCHdocXcDoSimVifcpztLsk1iX1a3KV5QokWwU3QA9Q9o/ I6IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784905601; x=1785510401; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5ElNQLPF+IOEJVGx3X6HzWFOmVSfbkgUy77zg9FdrcY=; b=j7toybBFIJDKKFnOe45PHcyT8NU0SjMush1cjpJTBfhUZeDbX/1n6NIKCklrHX+5tg 17khaqsnJ4aVzA9jQX3eEiKYjWdGNEq0yHVILzj63Bp3SRZ8QA+qHOYrx+4ajkX0/F2Q hWzql02U0pfTXHCdOJ72zoGabbcPw5fwWd7LYukhjRsZNae9g9AEvyo4oWKwZB9c6AGq M2V4tn4Ms12ddQIs8kp2StElg1Qdv4tYyOhjz3P+F6YqT8mWRz4zpFkS6+grZNqrNzv0 TmK/0PxqIhgOeNmEZO9vw9YYgjuyKLe2fEsI01TI5PMA/ZlCkhE+MmF+Rsni6J8IjRfy XB0A== X-Forwarded-Encrypted: i=1; AHgh+Rob5mdj8lhCR0F8Mnq9t1sNd1kBm64wqJgaEA6GFY9lc34MqZ5DMYXQ5+PLaJpjbl3VoKI7Rm4ee2tFnSo=@vger.kernel.org X-Gm-Message-State: AOJu0YzmRIQdfT2fxnJr6M9BSr/EsV++sVLcIWdE0T332lFRnozWduXf h4bMlDuF6R1ksjJdjpOOrsPvecNJvcCy8zgzvTrnd79Q/mk43FJANjH2 X-Gm-Gg: AR+sD13k6doYQ6cRe/Wu72NEAgQ7dtW8XKKUYTlkK79MPI9uyxixDmeCCdVaVgCIseH 85mgLZCXAjDp+6fAySZHd22Ywv6NQ7ifichxGt94MvcdQebnB9MCtNvzE+hR80057oK5rZrHSDa vHBDjkxExpOhOMD/q2EYGqb3BsNH0VEaeQFxc6lg+s0evT+7YswpHINn7Fp1wzYGNHe9Nc+NR8x Uqgbl+dkBED/j2kWf39cHwIamtNWAPncThJcO8MXIYXfwQBISqAa1glU0K+yh0kbweK5VAZ531X Q2BmeTO14DSyaDMLSLNWbDmRVal1ioUXyDjL8uAysqEZC+WeZwb+IVXjYsS09i8P/nOnS6Dm9DE N1wLlGEn/UP+GT4Lk86RpKJ0X/fxzebO+BkGaQgA1gB5S5rGfjcwlneArqXdee1VVSKli2w== X-Received: by 2002:a05:6102:3f87:b0:74a:9ac9:792c with SMTP id ada2fe7eead31-74d5e3cb58dmr4397247137.12.1784905601146; Fri, 24 Jul 2026 08:06:41 -0700 (PDT) Received: from houminxi ([72.244.37.221]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-74ad32165f4sm7744810137.6.2026.07.24.08.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 08:06:40 -0700 (PDT) From: Minxi Hou To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, aconole@redhat.com, echaudro@redhat.com, i.maximets@ovn.org, i.maximets@redhat.com, dev@openvswitch.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, horms@kernel.org, linux-kernel@vger.kernel.org, Minxi Hou Subject: [PATCH net-next v6 2/2] selftests/net/openvswitch: add SCTP flow key test Date: Fri, 24 Jul 2026 11:06:24 -0400 Message-ID: <20260724150624.3457427-3-houminxi@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260724150624.3457427-1-houminxi@gmail.com> References: <20260724150624.3457427-1-houminxi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add test_sctp_connect_v4() to verify OVS can match on SCTP flow keys (sctp src/dst port). The test sets up client and server namespaces connected through an OVS bridge, installs port-keyed flows, and verifies: - sctp(dst=3D4443) matches client-to-server INIT - sctp(src=3D4443) matches server-to-client INIT-ACK - removing flows drops the connection - reinstalling flows restores connectivity The listener readiness probe reads /proc/net/sctp/eps instead of ss: ss requires the sctp_diag interface, which is not enabled on all kernels, while /proc/net/sctp/eps exists whenever SCTP is loaded. Signed-off-by: Minxi Hou --- .../selftests/net/openvswitch/openvswitch.sh | 121 ++++++++++++++++++ 1 file changed, 121 insertions(+) diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh b/tools= /testing/selftests/net/openvswitch/openvswitch.sh index 853dbc1b00d7..b448324527d8 100755 --- a/tools/testing/selftests/net/openvswitch/openvswitch.sh +++ b/tools/testing/selftests/net/openvswitch/openvswitch.sh @@ -34,6 +34,7 @@ tests=3D" action_set set: SET action rewrites fields trunc trunc: output truncation icmpv6 icmpv6: ICMPv6 echo type match + sctp_connect_v4 sctp: SCTP flow key matching psample psample: Sampling packets with psample" =20 info() { @@ -611,6 +612,126 @@ test_icmpv6() { return 0 } =20 +# Check for an SCTP endpoint via /proc, which works without sctp_diag. +sctp_eps_has() { + ip netns exec "$1" awk -v p=3D"$2" '$6=3D=3Dp' /proc/net/sctp/eps | grep = -q . +} + +# sctp_connect_v4 test +# - sctp(dst=3D4443) matches client-to-server INIT +# - sctp(src=3D4443) matches server-to-client INIT-ACK +# - remove flows and verify connection fails, reinstall and recover +test_sctp_connect_v4() { + local t=3D"test_sctp_connect_v4" + local srv_ip=3D172.31.110.20 + + modprobe -q sctp 2>/dev/null || return "$ksft_skip" + socat -V 2>&1 | grep -q "define WITH_SCTP" || return "$ksft_skip" + + sbx_add "$t" || return $? + ovs_add_dp "$t" sctp4 || return 1 + + info "create namespaces" + for ns in client server; do + ovs_add_netns_and_veths "$t" "sctp4" "$ns" \ + "${ns:0:1}0" "${ns:0:1}1" || return 1 + done + + ip netns exec client ip addr add 172.31.110.10/24 dev c1 + ip netns exec client ip link set c1 up + ip netns exec server ip addr add "${srv_ip}/24" dev s1 + ip netns exec server ip link set s1 up + + # Probe: check if kernel supports sctp flow key. + ovs_add_flow "$t" sctp4 \ + 'in_port(1),eth(),eth_type(0x0800),ipv4(proto=3D132),sctp(dst=3D4443)= ' \ + '2' &>/dev/null + if [ $? -ne 0 ]; then + info "no support for sctp key - skipping" + ovs_exit_sig + return $ksft_skip + fi + ovs_del_flows "$t" sctp4 + + # ARP forwarding + ovs_add_flow "$t" sctp4 \ + 'in_port(1),eth(),eth_type(0x0806),arp()' \ + '2' || return 1 + ovs_add_flow "$t" sctp4 \ + 'in_port(2),eth(),eth_type(0x0806),arp()' \ + '1' || return 1 + + # SCTP port matching: dst for request, src for reply + ovs_add_flow "$t" sctp4 \ + 'in_port(1),eth(),eth_type(0x0800),ipv4(proto=3D132),sctp(dst=3D4443)= ' \ + '2' || return 1 + ovs_add_flow "$t" sctp4 \ + 'in_port(2),eth(),eth_type(0x0800),ipv4(proto=3D132),sctp(src=3D4443)= ' \ + '1' || return 1 + + ovs_netns_spawn_daemon "$t" "server" \ + socat -u SCTP4-LISTEN:4443 STDOUT + local server_pid=3D"$pid" + ovs_wait sctp_eps_has server 4443 || return 1 + + info "verify SCTP association with port-keyed flows" + ovs_sbx "$t" ip netns exec client \ + timeout 3 socat -u STDIN "SCTP4-CONNECT:${srv_ip}:4443" /dev/null + local i=3D0 + while kill -0 "$server_pid" 2>/dev/null && [ "$i" -lt 5 ]; do + sleep 0.2 + i=3D$((i + 1)) + done + ovs_netns_spawn_daemon "$t" "server" \ + socat -u SCTP4-LISTEN:4443 STDOUT + server_pid=3D"$pid" + ovs_wait sctp_eps_has server 4443 || return 1 + + ovs_sbx "$t" ip netns exec client \ + timeout 3 socat -u STDIN "SCTP4-CONNECT:${srv_ip}:4443" /dev/null 2>&1 \ + && { info "connection should fail without flows" + return 1; } + + info "reinstall flows and verify recovery" + ovs_add_flow "$t" sctp4 \ + 'in_port(1),eth(),eth_type(0x0800),ipv4(proto=3D132),sctp(dst=3D4443)= ' \ + '2' || return 1 + ovs_add_flow "$t" sctp4 \ + 'in_port(2),eth(),eth_type(0x0800),ipv4(proto=3D132),sctp(src=3D4443)= ' \ + '1' || return 1 + + kill -TERM "$server_pid" 2>/dev/null + i=3D0 + while kill -0 "$server_pid" 2>/dev/null && [ "$i" -lt 5 ]; do + sleep 0.2 + i=3D$((i + 1)) + done + ovs_netns_spawn_daemon "$t" "server" \ + socat -u SCTP4-LISTEN:4443 STDOUT + server_pid=3D"$pid" + ovs_wait sctp_eps_has server 4443 || return 1 + + ovs_sbx "$t" ip netns exec client \ + timeout 3 socat -u STDIN "SCTP4-CONNECT:${srv_ip}:4443"