From nobody Fri Jul 24 21:29:11 2026 Received: from mail-oo1-f98.google.com (mail-oo1-f98.google.com [209.85.161.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4FAF43CE74 for ; Fri, 24 Jul 2026 14:30:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.98 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784903436; cv=none; b=fVOiQXe4E8pXcKla5jXxBXGi/mzlNqghUIAIPTZIHEcCeRqrwSm+3LQHwOFJwsLlWoy788YcniMixkEk4g/DD3llVL/7G11JRzqD+3Ye/yF1ux1bL37li1J/lS1CMR353CrP6iKwm1zocCIhMbl0rHjfnJNDaIRIT55+X5qHC3k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784903436; c=relaxed/simple; bh=4T3TGrPOmCcuyK6wQdLMcII19a6AyfhLY97Res9looE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rLRWliboSTb29tD99cA3sNg14a6Ei2Q4qtrlR6gf0WAzg+H7CMFmrrb7VdY7XPd73bYHc3a02wdOAOX5uZn5fPthRXJJ4ynbY3XcKyhSNvND839szbWWHZxBV65+jSGJ27VwXltZr0ouhsUktB+wyL+IWQSKvRvmOsH/QQ3oE/Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=C03TPZf6; arc=none smtp.client-ip=209.85.161.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="C03TPZf6" Received: by mail-oo1-f98.google.com with SMTP id 006d021491bc7-6aade290804so239048eaf.0 for ; Fri, 24 Jul 2026 07:30:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784903433; x=1785508233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TSV0sSSXYSyAmLjxbnCOORhk+yB6Zbd6HUBS6OIrdiQ=; b=VsveSgtutOSaN15BZPInD68TrfUK8sDPB/d6R7mPJ50v2M1ygbeoZ9cX6apTE182AW zsoHb7mZIyWk5Y+AwdYI0QFmQCtbFP5yqCdtYsd0Tuqv9XJ0ZYQlwKQFavzTe942ncde JwVAcJmR82OI93LCVgk6VT5PFuhTSC5DkIMYxH5HTUQ9FV6/8DFuKHwFek99tX/0J3SL 06vG+/6nkAPjmdMGwNbrmq2nMF4EwIWAtRoB0QHTXKgHA1oLv7X4oZWJ/Gn8qzcI01qR pJjsfMOjO8AXOWtMTpbFbPhdmEt9tB+PE2uZcv3ve41HWIaJLXsV1zZbdcvc9CeVNfwn 2arg== X-Forwarded-Encrypted: i=1; AHgh+RrypRhmeLPkK1ukITaJE0O8KtVxKqCNCnnHJt33hshF2uDjx4Iy/ttj9pR/4n8Cp6L41irqvqQzLchHM90=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2o/rEr3E3mHd1zxWydJ7QjIlIIJbWkvpcCzW9hBhK0UlKMIzG 3kBKgDbEFgQlS7iHGa6KXd4WHXKg5Tcd5jImWOYNp9HS+ihZ/Vky2NhB7PObU+HKwFym4WCIwlW 70+ywSeQb/aEvqX7Baf3UKazU8KxTgs372Ht8NjhszL4th0PQqPr/gj8ttINSZKfOgqjIIHWYuM +nGyPQoRHDjkbxrmYSlONX08GVOHkPqOqpgdDJsuUuixWl9GChN3W5RjVKXoCBwhu4VaXEJotty hkPKs+JioGRm24FyA== X-Gm-Gg: AR+sD10NDBkqFEPmdouGMSwCzvRkPJZ2D9MaRGzPveAPeBtTLAnVXyyeb3QNRjv3EL+ GHK7/ShTEyPmYJtumiRgzwP1GV4bWJPqyfy49h0FcHjD1W/I8FGUPLKRsJMFwxdh3Pr/cuRoTdT 6pMk2yYjmhbPvxGJ0I4UPA6EwzQ2zNzmLa5AsLXdLKIL1wsHJQh79Z1tRuIHTO50vRtOREIghzT dpB1ZEteUCTP7eReVKwqQyKiHnREZ09o6PWa24pD+UCo7bxXQXOoUizZCVc4Vd7m4pFtAqMWvhh kqzn3+JpqYfYoAtHUoWSRsh+MJxKwBPevNsnSJ2E+J+ftIOwsizir+630DBonONRUOfNv9i79s5 mxrALJbEYsMXwR31RHHK6cPsN6PMRSIcFaM49rOO3/Gnn8ie5SVgxnE3LZ3qt+VqDiz1FGQIaS0 ISMSk8hZyNCSCkTqKvfWw+kq5Z8L0fgT/t+Q== X-Received: by 2002:a4a:e849:0:b0:6a4:7afa:aed9 with SMTP id 006d021491bc7-6aad415dc1amr4039377eaf.52.1784903433371; Fri, 24 Jul 2026 07:30:33 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-26.dlp.protect.broadcom.com. [144.49.247.26]) by smtp-relay.gmail.com with ESMTPS id 006d021491bc7-6aae0460d92sm201265eaf.24.2026.07.24.07.30.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jul 2026 07:30:33 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cb5ea36f969so553649a12.2 for ; Fri, 24 Jul 2026 07:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1784903432; x=1785508232; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TSV0sSSXYSyAmLjxbnCOORhk+yB6Zbd6HUBS6OIrdiQ=; b=C03TPZf6cGw7y791sMQSyNWDE/1RhbxZ2lXe9LVi2XtySOCQITMcxtoYsIFyygwuvq JXelc1CgKMPGxIcF4nfsONbtY7U4NedpzPT973r7NHWcDT0qHsGbVN6/wrj1Qg/QVZlY lBbrCm2/9T52N3GZVgcjZo6zcJ9iMWDt6kGcA= X-Forwarded-Encrypted: i=1; AHgh+RqSaDW08isRy9t4AOxoruU59C3GWYNTJKj3wC5qvO3Z0Rzwy1OpaR5bPqO1pzuFGKzle/SvYzFCPOEx++Q=@vger.kernel.org X-Received: by 2002:a05:6a21:7317:b0:3bf:9aa9:b2a4 with SMTP id adf61e73a8af0-3c44afcf8b1mr7850182637.20.1784903431661; Fri, 24 Jul 2026 07:30:31 -0700 (PDT) X-Received: by 2002:a05:6a21:7317:b0:3bf:9aa9:b2a4 with SMTP id adf61e73a8af0-3c44afcf8b1mr7850146637.20.1784903431100; Fri, 24 Jul 2026 07:30:31 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc5cb670sm259643eec.31.2026.07.24.07.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 07:30:30 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bhargava.marreddy@broadcom.com, rahul-rg.gupta@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, dharmender.garg@broadcom.com, ajit.khaparde@broadcom.com, Vikas Gupta Subject: [PATCH net-next 1/4] bnge: add steps in bnge_shutdown() Date: Fri, 24 Jul 2026 19:59:51 +0530 Message-ID: <20260724142954.3101980-2-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260724142954.3101980-1-vikas.gupta@broadcom.com> References: <20260724142954.3101980-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Since the driver now implements ndo_open and ndo_close with full link management, the shutdown callback must mirror the close sequence to ensure the device is brought down cleanly. Signed-off-by: Vikas Gupta Reviewed-by: Dharmender Garg Reviewed-by: Rahul Gupta --- .../net/ethernet/broadcom/bnge/bnge_core.c | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_core.c b/drivers/net/e= thernet/broadcom/bnge/bnge_core.c index 68b74eb2c3a2..9846d29b4fe3 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_core.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_core.c @@ -5,12 +5,14 @@ #include #include #include +#include =20 #include "bnge.h" #include "bnge_devlink.h" #include "bnge_hwrm.h" #include "bnge_hwrm_lib.h" #include "bnge_link.h" +#include "bnge_resc.h" =20 MODULE_LICENSE("GPL"); MODULE_DESCRIPTION(DRV_SUMMARY); @@ -406,12 +408,34 @@ static void bnge_remove_one(struct pci_dev *pdev) =20 static void bnge_shutdown(struct pci_dev *pdev) { + struct bnge_dev *bd =3D pci_get_drvdata(pdev); + struct net_device *dev; + + dev =3D bd ? bd->netdev : NULL; + if (!dev) + return; + + rtnl_lock(); + netdev_lock(dev); + + if (netif_running(dev)) + netif_close(dev); + + if (bnge_hwrm_func_drv_unrgtr(bd)) { + pcie_flr(pdev); + goto shutdown_exit; + } + bnge_free_irqs(bd); pci_disable_device(pdev); =20 if (system_state =3D=3D SYSTEM_POWER_OFF) { pci_wake_from_d3(pdev, 0); pci_set_power_state(pdev, PCI_D3hot); } + +shutdown_exit: + netdev_unlock(dev); + rtnl_unlock(); } =20 static struct pci_driver bnge_driver =3D { --=20 2.47.1 From nobody Fri Jul 24 21:29:11 2026 Received: from mail-vs1-f98.google.com (mail-vs1-f98.google.com [209.85.217.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F1C143CEE1 for ; Fri, 24 Jul 2026 14:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.98 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784903440; cv=none; b=tA3ZOGoGZlgHd8Rfu7nkIoWDSG49BSRzuTFGcE/g7FMPLTHS6610VG/t0gUV1ZrLPZIPgBxdjN0lFWiF1Of5M3rTJ/AGpf09SSJAplSf57xa8l1Qm1DyRYptkkitoPpQGIVUmtcG0eUKgQpK1hGd8gqEOLE+qHdtVERErG9WKF4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784903440; c=relaxed/simple; bh=4ehvwSaEiXVBlRUd5vewS2RGvirgocMw5uBi835Hx9A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZontcLFduHMl/0VjkoB2UeTmwYwrN99wZOvw1xacBVwxXYCNNaZV/NUnJgMzmPxhmkm51soDxMA51N08GEyR3TfH3QA7X+tRE0NmjbrZxZKOkVf9W5bwVXunqFXvR+493lFtNywFdYXxDH+/kERpuAqQ6qmPpxpjDBAlYvDxU+c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=ZYMeRiI0; arc=none smtp.client-ip=209.85.217.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ZYMeRiI0" Received: by mail-vs1-f98.google.com with SMTP id ada2fe7eead31-74d43f06686so135254137.0 for ; Fri, 24 Jul 2026 07:30:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784903438; x=1785508238; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+PfAlfX3vpEZCie4PFwUObkKJIDKS93e86I5c2uPjRs=; b=WSuftFy4ODsmJ7tNmX/v9yLVJJqpc6geT0nUS1WnLFIP2qLQQZ+8F+/ZUA41jvUmBF PY+FPRMbctPuxy4gvJsCE+FdWOJOC1rWZdmQ1NaWt82SnOQI6BZ2o2hdltioFK5bmywe r6d4jgupz7Lx/J+ywUmuIy3PUJ8/8QFCC98p/sy3gCvPlq4TBSwa+int4OQj9eNJ8NUb 9sSWXVDr0LKCopsb+8vHVCTMWX225vZIJgXpfheJNWpkM1VTgiXzrKgZEn3+aWbS2Ayf pC/LXDIP5mcKa+BRZD4nwGZuwBu/UrDdyhAxtLbSzK/fowSYQx5blHomhgWX/aK3t6OC yG7A== X-Forwarded-Encrypted: i=1; AHgh+RpDrnv9nR8S5uuvvhIXtJz4gxDyOs9PmSzSyK0zh9vH0XFoyvDpqGiCzz9jSALGLF3oFupP6fUKVga0cdY=@vger.kernel.org X-Gm-Message-State: AOJu0YwLMUQusvMxGoO/5jR0eqfX2u2WX1u1Q1dd53ZSLEsuk4zSpsVN uYqqM4pjVWhyO8YiRi+iQQgczyeZukX1/exWt1R0HEQ9Xc79c24CtLXhgz0k4ZcRf3J45VtKVwW JHmpxf2tvvcl7avKALSDUVxu7vEEC6+DU2zt3NYqbPq9O2U10lXLkxdg9A1c1I/0kEkzJR+sWX+ NC8kugqoEyh3NhpHAayLTFfGDFJyoyeX6MN03KSKdrq6lH1AO2WWnYH0Bl1SUxuFQnmUd/fZl8L FbqguoD+D2Zxz1zGg== X-Gm-Gg: AR+sD12Ig+vqRh0YJnXKp9tJQ0lxcVEQK+dNN0yneGrPpj9ucKKhq9Pk6nKxKanVnxL QjORkZxt8OM9ye2ESFV3UcNqDu5DL/6/GRpkwxk1gTRlBsHjfsgmKdgVyQRD6HnMSFwyrHPbiEV 8vTzYuou1C09TIYzquRiGQ3T6WSGJVeiYOuGwEjef5ZuI46ESdLnyyFEJJT+pEcHf/GR6H708F+ b2BY6HCTa59WHtiaPC+t9sJ0QKFEXIxPyk4/n7zd1WbKL0p4/1hKMlUqILt4MCQm8AdykfCCZ9K t468q78/fP3m4ytJvvzH9y4bhqPJrYggNqooXeQ8YL6ZXznS3JTBBr+nttXmB1c+90oGkj9bQjf iyyqZcZSjkG70SOSjpR9fcleosC5SNOegCLlI0yuvzbetzj6eh0zrMkTdI8oVyi2g2UjPFGHYNH 2ILzudiiqN0H+JG0gs0nN43UadjJdcpTVkfQ== X-Received: by 2002:a05:6102:2b8b:b0:738:9c79:7506 with SMTP id ada2fe7eead31-74d5e2cc01fmr3575546137.7.1784903437978; Fri, 24 Jul 2026 07:30:37 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-22.dlp.protect.broadcom.com. [144.49.247.22]) by smtp-relay.gmail.com with ESMTPS id ada2fe7eead31-74ad3247902sm775707137.11.2026.07.24.07.30.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jul 2026 07:30:37 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cb5ea36f969so553752a12.2 for ; Fri, 24 Jul 2026 07:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1784903437; x=1785508237; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+PfAlfX3vpEZCie4PFwUObkKJIDKS93e86I5c2uPjRs=; b=ZYMeRiI0cXUaofJxMlKk8pNZSC7Pu2vk3NVOqN/ESj3UTL5WPY+lPisCoGnE30YqSq lrHA0TZhc4la3ztv0mux9diX4Z2ZZpopPQ/Qa62S3SY06Y6seMmJreuldAl8A5P6gIO/ 74rA1stf+k5Gk1Y2mgcorCZfo+5AMzhmNIA2Y= X-Forwarded-Encrypted: i=1; AHgh+RoDk6TUe25+6gf21LtPLqAQC4KvCZY7n/3x+vhysB7IiGiwQNuW3NWLnw05VfCtI+Xib0k7sYMrV69Pgbw=@vger.kernel.org X-Received: by 2002:a05:6a20:9183:b0:3c0:9c19:6591 with SMTP id adf61e73a8af0-3c44b2c3b52mr9461686637.75.1784903436645; Fri, 24 Jul 2026 07:30:36 -0700 (PDT) X-Received: by 2002:a05:6a20:9183:b0:3c0:9c19:6591 with SMTP id adf61e73a8af0-3c44b2c3b52mr9461641637.75.1784903436193; Fri, 24 Jul 2026 07:30:36 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc5cb670sm259643eec.31.2026.07.24.07.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 07:30:35 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bhargava.marreddy@broadcom.com, rahul-rg.gupta@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, dharmender.garg@broadcom.com, ajit.khaparde@broadcom.com, Vikas Gupta Subject: [PATCH net-next 2/4] bnge: refactor rx mode helpers to accept explicit address lists Date: Fri, 24 Jul 2026 19:59:52 +0530 Message-ID: <20260724142954.3101980-3-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260724142954.3101980-1-vikas.gupta@broadcom.com> References: <20260724142954.3101980-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Rename bnge_cfg_def_vnic() to bnge_cfg_rx_mode() and update bnge_mc_list_updated() and bnge_uc_list_updated() to accept explicit netdev_hw_addr_list pointers rather than deriving them from the netdev. Add a snapshot parameter to bnge_cfg_rx_mode() to skip netif_addr_lock_bh() when the caller provides a pre-snapshotted list. On the open path (snapshot=3Dfalse), the live netdev UC list is passed and the addr lock is taken as before. Handle -EAGAIN from bnge_hwrm_set_vnic_filter() on the open path by scheduling a retry via netif_rx_mode_schedule_retry() rather than failing the open. Signed-off-by: Vikas Gupta Reviewed-by: Dharmender Garg Reviewed-by: Rahul Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 47 +++++++++++-------- 1 file changed, 28 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 6f7ef506d4e1..1e3cdaeaa03d 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2144,16 +2144,16 @@ static int bnge_hwrm_set_vnic_filter(struct bnge_ne= t *bn, u16 vnic_id, u16 idx, return rc; } =20 -static bool bnge_mc_list_updated(struct bnge_net *bn, u32 *rx_mask) +static bool bnge_mc_list_updated(struct bnge_net *bn, u32 *rx_mask, + const struct netdev_hw_addr_list *mc) { struct bnge_vnic_info *vnic =3D &bn->vnic_info[BNGE_VNIC_DEFAULT]; - struct net_device *dev =3D bn->netdev; struct netdev_hw_addr *ha; int mc_count =3D 0, off =3D 0; bool update =3D false; u8 *haddr; =20 - netdev_for_each_mc_addr(ha, dev) { + netdev_hw_addr_list_for_each(ha, mc) { if (mc_count >=3D BNGE_MAX_MC_ADDRS) { *rx_mask |=3D CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST; vnic->mc_list_count =3D 0; @@ -2177,17 +2177,17 @@ static bool bnge_mc_list_updated(struct bnge_net *b= n, u32 *rx_mask) return update; } =20 -static bool bnge_uc_list_updated(struct bnge_net *bn) +static bool bnge_uc_list_updated(struct bnge_net *bn, + const struct netdev_hw_addr_list *uc) { struct bnge_vnic_info *vnic =3D &bn->vnic_info[BNGE_VNIC_DEFAULT]; - struct net_device *dev =3D bn->netdev; struct netdev_hw_addr *ha; int off =3D 0; =20 - if (netdev_uc_count(dev) !=3D (vnic->uc_filter_count - 1)) + if (netdev_hw_addr_list_count(uc) !=3D (vnic->uc_filter_count - 1)) return true; =20 - netdev_for_each_uc_addr(ha, dev) { + netdev_hw_addr_list_for_each(ha, uc) { if (!ether_addr_equal(ha->addr, vnic->uc_list + off)) return true; =20 @@ -2201,7 +2201,8 @@ static bool bnge_promisc_ok(struct bnge_net *bn) return true; } =20 -static int bnge_cfg_def_vnic(struct bnge_net *bn) +static int bnge_cfg_rx_mode(struct bnge_net *bn, struct netdev_hw_addr_lis= t *uc, + bool snapshot) { struct bnge_vnic_info *vnic =3D &bn->vnic_info[BNGE_VNIC_DEFAULT]; struct net_device *dev =3D bn->netdev; @@ -2210,9 +2211,7 @@ static int bnge_cfg_def_vnic(struct bnge_net *bn) int i, off =3D 0, rc; bool uc_update; =20 - netif_addr_lock_bh(dev); - uc_update =3D bnge_uc_list_updated(bn); - netif_addr_unlock_bh(dev); + uc_update =3D bnge_uc_list_updated(bn, uc); =20 if (!uc_update) goto skip_uc; @@ -2226,22 +2225,28 @@ static int bnge_cfg_def_vnic(struct bnge_net *bn) =20 vnic->uc_filter_count =3D 1; =20 - netif_addr_lock_bh(dev); - if (netdev_uc_count(dev) > (BNGE_MAX_UC_ADDRS - 1)) { + if (!snapshot) + netif_addr_lock_bh(dev); + if (netdev_hw_addr_list_count(uc) > (BNGE_MAX_UC_ADDRS - 1)) { vnic->rx_mask |=3D CFA_L2_SET_RX_MASK_REQ_MASK_PROMISCUOUS; } else { - netdev_for_each_uc_addr(ha, dev) { + netdev_hw_addr_list_for_each(ha, uc) { memcpy(vnic->uc_list + off, ha->addr, ETH_ALEN); off +=3D ETH_ALEN; vnic->uc_filter_count++; } } - netif_addr_unlock_bh(dev); + if (!snapshot) + netif_addr_unlock_bh(dev); =20 for (i =3D 1, off =3D 0; i < vnic->uc_filter_count; i++, off +=3D ETH_ALE= N) { rc =3D bnge_hwrm_set_vnic_filter(bn, 0, i, vnic->uc_list + off); if (rc) { - netdev_err(dev, "HWRM vnic filter failure rc: %d\n", rc); + if (rc =3D=3D -EAGAIN) + netdev_warn(dev, "FW busy while setting vnic filter, will retry\n"); + else + netdev_err(dev, "HWRM vnic filter failure rc: %d\n", + rc); vnic->uc_filter_count =3D i; return rc; } @@ -2695,13 +2700,17 @@ static int bnge_init_chip(struct bnge_net *bn) } else if (bn->netdev->flags & IFF_MULTICAST) { u32 mask =3D 0; =20 - bnge_mc_list_updated(bn, &mask); + bnge_mc_list_updated(bn, &mask, &bn->netdev->mc); vnic->rx_mask |=3D mask; } =20 - rc =3D bnge_cfg_def_vnic(bn); - if (rc) + rc =3D bnge_cfg_rx_mode(bn, &bn->netdev->uc, false); + if (rc =3D=3D -EAGAIN) { + netif_rx_mode_schedule_retry(bn->netdev); + rc =3D 0; + } else if (rc) { goto err_out; + } return 0; =20 err_out: --=20 2.47.1 From nobody Fri Jul 24 21:29:11 2026 Received: from mail-pl1-f228.google.com (mail-pl1-f228.google.com [209.85.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46DD243E9FB for ; Fri, 24 Jul 2026 14:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784903445; cv=none; b=bjh1XtXXEZfs/hsFub6GX9F12s53rrPLJfimfVZCA7Fh/kG9hmhNFL59jJBVvZ2QHd1uSoquptJ+imwK7UbUaHpSIoCFn5sE6c7ULmHwlrYgNMFlpp8xOP/UCRyjy79fmqeaH6evksPCxqwd3yEIxxLoBwIo3M/jrcq3PtyIvLI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784903445; c=relaxed/simple; bh=T6+4uWno3qiPu42lbh3caCYCt+l5+8vX7oK0bCAiq8Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TcG2mR0T5kTBn8AoTe9bcvODeMM2ABg6uBeeI/dj0LLt32mj4YT3K6SNXmnUUnXZ4EaajYM8RHR/ss/l7pfZUsejLdKOy1DIJk5gmtUWxe4+yX+RngVCEaObiZh+N7G4uQ0neVHdyv12EdmvljdRrZMk0iNANViRjxU/M4jKkE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=hWcQHXpT; arc=none smtp.client-ip=209.85.214.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="hWcQHXpT" Received: by mail-pl1-f228.google.com with SMTP id d9443c01a7336-2cc61541f8cso17490465ad.0 for ; Fri, 24 Jul 2026 07:30:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784903443; x=1785508243; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6yRI+9u7xmeJWs4rtpYpBl5JFmjWKLMn+METPdpZP8k=; b=I0I8yfw7Izi6R04kAT8fEsuLoVb1KXVzPbtabEd6gho2TKOw28FBg3/+weE2sa0eAT Qmsbj5NGK5fr0/WOKs15iPqvDiI7aslVhfOr1u9b9XmCQRJ/aahTMEYkyV6h1y7UI3sQ DcTFjC5zJdz3TfpAYJ5cem+7kJXEbVzUqvemo8tXhxdY2oerqPsch0FFNLU0Ll7C+kLF JFKwQpY2KzlQNrI5HVbYr8/Z/DzqkHebGboW4kOF472qmet4KJhdqFhDOSZ4CUjUE47W p+YUHwF2pw9/LEfGBHu4ujPTpE+4iwXrchNIxgtfkvJrOUGFZjHjWfX30UPWVc6D2fQ4 zQ3Q== X-Forwarded-Encrypted: i=1; AHgh+RpA6Xjuo+bAzbU1vfbxWxEnyXf8BDroE6EPvlUDTFcXfSXBSTzOauYVuWUYsLOqTqt36Ndv7/yxc9dEgog=@vger.kernel.org X-Gm-Message-State: AOJu0Yyy4wkTg1/lPZz3CDQDBMdfN8CUtAi7GeNcAu9/la5cNSbLLIP2 mj1RzPkjEOK3nOZmT5O4EBhwcS/okle7HcPocRyZVnVOMavkPOj7INeB9sVTorRBKzokddZSnlL tXz4P9F3n7W+6ZnGX/+cQ7ghA9Bcsslg78Y1gJ8qVY/wyhYRFBrWpUCtMys61+M8jo32jL2R39t MS+opLOgT6Rub2k5RabNOj6PIyAWSKjATpcGYS6ZkphMMZS1uwg+HUowbvxlAiwiub+iVy3PAeb IYJ4qfKuvkVZBtMXA== X-Gm-Gg: AR+sD106i3OCfN1jV6J1JK5z3sjSDGN1HB1hDqKXdV+WpAf3sxhLCgCZpbZRWwyjd4T gAxSkAH/2lzB0pM8wOd3z/Eq2usz14czWePrjTjsOqAxSLZK6vXbQn2uOHpgwq8AkYim3iwMwJ5 YBWjIvKNO91jFujrgEovw9l4s4rTnhHGYqGOXE28djGrV10YAgQcjNqC4bW8ip0CE3Lx6Er9QQC 2y5rqdtFZmSXHYMjtNZroL5cWYSVvcEkHcD+cAlpxJCp0CCWFnw7hwXga351mDAoa2LYT1qfJkB M0m6j2SU4Tm729GP9PADXmvorPOg/iuxtlAeQPvcTiTRYBXlhGlGWIVO3mIeMqcewAmsg+y1fjt 49nTFcIF+IqRLKk8DKVfgOThpa447IWA1xNboQzmJocCZ9uURhmWMLCPXi7H0ZZ5ldizKyYBylu m5Zx+1de2gNNP+qEfBjPNh8gkVmgyAgl79Rw== X-Received: by 2002:a17:902:e545:b0:2cc:db7a:251 with SMTP id d9443c01a7336-2cfd70bf070mr6963425ad.2.1784903443326; Fri, 24 Jul 2026 07:30:43 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-26.dlp.protect.broadcom.com. [144.49.247.26]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2cf8f2b1947sm8112765ad.33.2026.07.24.07.30.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jul 2026 07:30:43 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cb6ef846b33so396222a12.1 for ; Fri, 24 Jul 2026 07:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1784903442; x=1785508242; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6yRI+9u7xmeJWs4rtpYpBl5JFmjWKLMn+METPdpZP8k=; b=hWcQHXpTT9W5h8PZtbTzbJFuSCf5r4RbbHnfyOmCm9fzyuC7qz77vE4vfIiLbGpvMC 5NRg9o9B0taUcu3UaUdDkcdUKf/RbCFqJerclHZEHpOaFjXQJfuHwsWVhxDpgq1bzYJ0 DTMRYJSjzQvCvY54nMwOIhfRCpIsn4EA9Ffh4= X-Forwarded-Encrypted: i=1; AHgh+RpBWj+vijB3Rj7KQDH5hpHNlmDs2P2CRJb67O7M5gCrzu9oU6C1rtn8LYN1CShxFOVCnYJXg2ziRz27pE8=@vger.kernel.org X-Received: by 2002:a05:6a21:6494:b0:398:76d4:c7e9 with SMTP id adf61e73a8af0-3c6726d21c0mr802989637.35.1784903441771; Fri, 24 Jul 2026 07:30:41 -0700 (PDT) X-Received: by 2002:a05:6a21:6494:b0:398:76d4:c7e9 with SMTP id adf61e73a8af0-3c6726d21c0mr802944637.35.1784903441316; Fri, 24 Jul 2026 07:30:41 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc5cb670sm259643eec.31.2026.07.24.07.30.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 07:30:40 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bhargava.marreddy@broadcom.com, rahul-rg.gupta@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, dharmender.garg@broadcom.com, ajit.khaparde@broadcom.com, Vikas Gupta Subject: [PATCH net-next 3/4] bnge: add ndo_set_rx_mode_async support Date: Fri, 24 Jul 2026 19:59:53 +0530 Message-ID: <20260724142954.3101980-4-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260724142954.3101980-1-vikas.gupta@broadcom.com> References: <20260724142954.3101980-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Register bnge_set_rx_mode() as ndo_set_rx_mode_async to handle unicast, multicast, broadcast, and promiscuous filter updates via CFA_L2_SET_RX_MASK. The async variant receives pre-snapshotted address lists from the kernel, allowing the driver to issue sleepable HWRM firmware commands without holding the addr lock. Move uc_update detection to the caller so the async path can compute it directly from the snapshotted UC list before calling bnge_cfg_rx_mode(). Signed-off-by: Vikas Gupta Reviewed-by: Dharmender Garg Reviewed-by: Rahul Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 50 +++++++++++++++++-- 1 file changed, 45 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 1e3cdaeaa03d..e67536a8c430 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2202,16 +2202,13 @@ static bool bnge_promisc_ok(struct bnge_net *bn) } =20 static int bnge_cfg_rx_mode(struct bnge_net *bn, struct netdev_hw_addr_lis= t *uc, - bool snapshot) + bool uc_update, bool snapshot) { struct bnge_vnic_info *vnic =3D &bn->vnic_info[BNGE_VNIC_DEFAULT]; struct net_device *dev =3D bn->netdev; struct bnge_dev *bd =3D bn->bd; struct netdev_hw_addr *ha; int i, off =3D 0, rc; - bool uc_update; - - uc_update =3D bnge_uc_list_updated(bn, uc); =20 if (!uc_update) goto skip_uc; @@ -2272,6 +2269,48 @@ static int bnge_cfg_rx_mode(struct bnge_net *bn, str= uct netdev_hw_addr_list *uc, return rc; } =20 +static int bnge_set_rx_mode(struct net_device *dev, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_vnic_info *vnic; + bool mc_update =3D false; + bool uc_update; + u32 mask; + + if (!test_bit(BNGE_STATE_OPEN, &bn->bd->state)) + return 0; + + vnic =3D &bn->vnic_info[BNGE_VNIC_DEFAULT]; + mask =3D vnic->rx_mask; + mask &=3D ~(CFA_L2_SET_RX_MASK_REQ_MASK_PROMISCUOUS | + CFA_L2_SET_RX_MASK_REQ_MASK_MCAST | + CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST | + CFA_L2_SET_RX_MASK_REQ_MASK_BCAST); + + if (dev->flags & IFF_PROMISC) + mask |=3D CFA_L2_SET_RX_MASK_REQ_MASK_PROMISCUOUS; + + uc_update =3D bnge_uc_list_updated(bn, uc); + + if (dev->flags & IFF_BROADCAST) + mask |=3D CFA_L2_SET_RX_MASK_REQ_MASK_BCAST; + if (dev->flags & IFF_ALLMULTI) { + mask |=3D CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST; + vnic->mc_list_count =3D 0; + } else if (dev->flags & IFF_MULTICAST) { + mc_update =3D bnge_mc_list_updated(bn, &mask, mc); + } + + if (mask !=3D vnic->rx_mask || uc_update || mc_update) { + vnic->rx_mask =3D mask; + return bnge_cfg_rx_mode(bn, uc, uc_update, true); + } + + return 0; +} + static void bnge_disable_int(struct bnge_net *bn) { struct bnge_dev *bd =3D bn->bd; @@ -2704,7 +2743,7 @@ static int bnge_init_chip(struct bnge_net *bn) vnic->rx_mask |=3D mask; } =20 - rc =3D bnge_cfg_rx_mode(bn, &bn->netdev->uc, false); + rc =3D bnge_cfg_rx_mode(bn, &bn->netdev->uc, true, false); if (rc =3D=3D -EAGAIN) { netif_rx_mode_schedule_retry(bn->netdev); rc =3D 0; @@ -3204,6 +3243,7 @@ static const struct net_device_ops bnge_netdev_ops = =3D { .ndo_stop =3D bnge_close, .ndo_start_xmit =3D bnge_start_xmit, .ndo_get_stats64 =3D bnge_get_stats64, + .ndo_set_rx_mode_async =3D bnge_set_rx_mode, .ndo_features_check =3D bnge_features_check, }; =20 --=20 2.47.1 From nobody Fri Jul 24 21:29:11 2026 Received: from mail-pl1-f225.google.com (mail-pl1-f225.google.com [209.85.214.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0BAA43F0B6 for ; Fri, 24 Jul 2026 14:30:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784903451; cv=none; b=JdDO33mmiGsa00JTdac+hu6E3ZftYv5/A+9vzb4MwUy46r0Cfsx4YcOXMaja+EVj5MqzeRYVXddx/SI/h1kENdknPAnhuFXxdL3efsi5wiLxwNzG8QhRws+iuYeoFeXWHlIZYHS9ixhuLgn8kkpnKyMndn4vzrhvVXAroxIAcRQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784903451; c=relaxed/simple; bh=90EVbGJA84/7M9JAh396s55yku4g+D/H4Cbmu9cjEms=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=keqIGCZLH8uilfbxmNHfcQzSYe27piuBW2+gQRugyFjtthzaZyVQlW7T82xZYEJtSjtObe3bEvZP0oTUmCZODY9AZBuvehRDmKJR3FDnxxYH30Tr1DVsnDX9AI5+0etR7h8uQu/QAfQSBgX9BC5s5RCn4xol/i1P+WVeq31nQEo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=PNW7SGPW; arc=none smtp.client-ip=209.85.214.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="PNW7SGPW" Received: by mail-pl1-f225.google.com with SMTP id d9443c01a7336-2caf228a910so3900025ad.2 for ; Fri, 24 Jul 2026 07:30:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784903449; x=1785508249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fRvfd4XDLRXG+hTzuT9EEdM6zfTC4YymdTujDGLFF/E=; b=jrtiZ0aHkJ1g4UQZ0Q6VFr4OjsiJHR4bNvO8H7u0eBoB82xO1pmJ1yPrISV7cf/vU8 bjigZ818bctNGj14t6xSqDCPR8GHyOsWc0sd2pJqGZhXxKSzB0/X+yzNlPTQCAEX2QRz M350KIPUR0sST4dM5lxfwOoNZFaNgHvnc8bHqbQIq0ODDt7NUIMs+3pT0qMhskYXQDOq 6qWmZCPrzv/47J7uz+JUPuq6UdXzIIReYFQJQDCFU2XxJSy30ekFRHHM5LkcLCav1cOo w1Uw1jjE03z1422BaEc112d5ipeuW+oO9CePRHqSw0Kr+FTTQneI1grS5HgMKtMhVpTy eOjQ== X-Forwarded-Encrypted: i=1; AHgh+RpPwCWTDwRxDtSN2J+/vxRqhNXQnyGJlTjQgYMeRI7hYK/ZWMO9QhYr7+r6N5NPPqgrPDVb/c/wJe23wHE=@vger.kernel.org X-Gm-Message-State: AOJu0YzIheZJMb4/J9EPv+mGnyxuL3E+5mEGrlW4aBaNwPixyQT/jGEx o/OXjh9GmDfcF+iSqgho4NhnHvk6Dg53uWTK8XxE22ooilaqEkHSpjvMTBWhyTwLko6KPM6RNcX 5TtBYuuTGIPrirYtD6Dnq6x/immybCl6t3FRF9qdOiE56eXHE7c4nGKFKmu1971kPwrbyFRRlWc EbqMGI1Q1JopGU/dziEDvHxIPmdRyD9bzug3slslCkTkTeMnza1lVh3Hww2jFhfDMxy2BEHkX8t K+Za1cvvhqbHb34MQ== X-Gm-Gg: AR+sD10UZTwxIneWX3QvJeXJHl4/cPq4oIPocAmMR3f59wZuu/snCcr1/LO4Y1tGgVu Hw5GkPjjI2qKtq6quG2Gp8zN+IYm3agdgXxSiVmVmvGQsWk7ervfHflcgCug3gsVN8wHdB3GfVh ZAWXFukVJ8UeKRdGaSxwHx71RxnIKbG7m10G9xBH03hEPw0Oj7XiYb4KVQbZwk0OzWG6BI/5Skx ixz4EN44tdjIw9y1+PFsqAnjHDrCpcldSPX5ud0W+qKWUlzzADZKj5DQOFxQIJWMH7vversg+SB H2WLu1XGCVrfvsn/raVU2j6IQtUcxCMjv+rdyoNMnvdBvmJcWXou6mH5hUpv48xhbGcgwERz0St FjkgZp2lYPqZwkdi7JERvhsE87t7ykYnmgpn8VN3Mjcg3TXpuVdsF/HjcD/T9US4OF6/uv+VHH9 7EubMN+62lztbLeQiQKgtq3cQYsL5C67bFnQ== X-Received: by 2002:a17:903:1104:b0:2ca:d172:7228 with SMTP id d9443c01a7336-2cfa6b7d4b5mr91575145ad.11.1784903449101; Fri, 24 Jul 2026 07:30:49 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-22.dlp.protect.broadcom.com. [144.49.247.22]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2cf8f2e5f0asm8793975ad.41.2026.07.24.07.30.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jul 2026 07:30:49 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cee894b3d8so8461695ad.2 for ; Fri, 24 Jul 2026 07:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1784903447; x=1785508247; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fRvfd4XDLRXG+hTzuT9EEdM6zfTC4YymdTujDGLFF/E=; b=PNW7SGPWpTRuLBMX9MyuSDLA3cvPatz3mnx0IZ3WqyVOPea0nqF0Hk/mx7xUVgllmV s+tKzmrR5phX0i/PR5jYjlQHd/AbYj00VcMJ3oMn86rV9oezI0vXWPv9sPUiP4SDFvTi LgzMUCGnP4YhwmhKGk90/yPf5QAxGUEVFXFZU= X-Forwarded-Encrypted: i=1; AHgh+RoA/eCZQhRBuMOCFHDvyOnpCZ7Vw4fhSTuEWMX+fsroGQz5cmJIIG2oFvW1E6bwkFDwUsRjUCDVCd1ybvI=@vger.kernel.org X-Received: by 2002:a05:6a21:730a:b0:398:7ed3:a001 with SMTP id adf61e73a8af0-3c44afb1ab6mr8101941637.2.1784903447141; Fri, 24 Jul 2026 07:30:47 -0700 (PDT) X-Received: by 2002:a05:6a21:730a:b0:398:7ed3:a001 with SMTP id adf61e73a8af0-3c44afb1ab6mr8101882637.2.1784903446449; Fri, 24 Jul 2026 07:30:46 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc5cb670sm259643eec.31.2026.07.24.07.30.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 07:30:46 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bhargava.marreddy@broadcom.com, rahul-rg.gupta@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, dharmender.garg@broadcom.com, ajit.khaparde@broadcom.com, Vikas Gupta Subject: [PATCH net-next 4/4] bnge: send hwrm for interface down/up transitions Date: Fri, 24 Jul 2026 19:59:54 +0530 Message-ID: <20260724142954.3101980-5-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260724142954.3101980-1-vikas.gupta@broadcom.com> References: <20260724142954.3101980-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Firmware expects HWRM_FUNC_DRV_IF_CHANGE on interface down/up transitions to coordinate resource management. Add bnge_hwrm_if_change() to send this notification. Signed-off-by: Vikas Gupta Reviewed-by: Dharmender Garg Reviewed-by: Rahul Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 32 +++++++++++++++++-- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 2 ++ 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index e67536a8c430..220bdcced0db 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -20,6 +20,7 @@ #include =20 #include "bnge.h" +#include "bnge_hwrm.h" #include "bnge_hwrm_lib.h" #include "bnge_ethtool.h" #include "bnge_rmem.h" @@ -2861,6 +2862,24 @@ static void bnge_tx_enable(struct bnge_net *bn) netif_carrier_on(bn->netdev); } =20 +static int bnge_hwrm_if_change(struct bnge_dev *bd, bool up) +{ + struct hwrm_func_drv_if_change_input *req; + int rc; + + if (!(bd->fw_cap & BNGE_FW_CAP_IF_CHANGE)) + return 0; + + rc =3D bnge_hwrm_req_init(bd, req, HWRM_FUNC_DRV_IF_CHANGE); + if (rc) + return rc; + + if (up) + req->flags =3D cpu_to_le32(FUNC_DRV_IF_CHANGE_REQ_FLAGS_UP); + + return bnge_hwrm_req_send(bd, req); +} + static int bnge_open_core(struct bnge_net *bn) { struct bnge_dev *bd =3D bn->bd; @@ -2868,16 +2887,22 @@ static int bnge_open_core(struct bnge_net *bn) =20 netif_carrier_off(bn->netdev); =20 + rc =3D bnge_hwrm_if_change(bd, true); + if (rc) { + netdev_err(bn->netdev, "bnge_hwrm_if_change err: %d\n", rc); + return rc; + } + rc =3D bnge_reserve_rings(bd); if (rc) { netdev_err(bn->netdev, "bnge_reserve_rings err: %d\n", rc); - return rc; + goto err_if_change; } =20 rc =3D bnge_alloc_core(bn); if (rc) { netdev_err(bn->netdev, "bnge_alloc_core err: %d\n", rc); - return rc; + goto err_if_change; } =20 bnge_init_napi(bn); @@ -2924,6 +2949,8 @@ static int bnge_open_core(struct bnge_net *bn) err_del_napi: bnge_del_napi(bn); bnge_free_core(bn); +err_if_change: + bnge_hwrm_if_change(bd, false); return rc; } =20 @@ -3154,6 +3181,7 @@ static int bnge_close(struct net_device *dev) =20 bnge_close_core(bn); bnge_hwrm_shutdown_link(bn->bd); + bnge_hwrm_if_change(bn->bd, false); bn->sp_event =3D 0; =20 return 0; diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index d177919c2e11..a1a939496ebd 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -275,6 +275,8 @@ enum bnge_net_flag { BNGE_FLAG_PORT_STATS_EXT =3D BIT(1), }; =20 +#define BNGE_FW_IF_RETRY 10 + enum bnge_sp_event { BNGE_LINK_CHNG_SP_EVENT, BNGE_LINK_SPEED_CHNG_SP_EVENT, --=20 2.47.1