From nobody Fri Jul 24 21:29:03 2026 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E7304322E5 for ; Fri, 24 Jul 2026 13:58:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784901503; cv=none; b=oskKAW83PpeNxTF9RtdDtVuzYAhBYHOcMjXLd9kVxNnOqXDwva62NGg5p/UCYMpMmXsxdbbF/qFx5pXw7ZMXK3iL97QbcH6mo++CEBMdjd6wnfxtmZjqHXhkzdst+mgK1BSyCsSvM25tvXl/akzCb8tasSiPPyOOvpL8cFjBd/8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784901503; c=relaxed/simple; bh=9bVq3PKKCCjYfUKFC8lsteul1thSQleu0PchsXsqgeA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EEt2LVsPll8TnG7PznEoVkpzjkkJWSKabnyfFSU+eOvi7ZMWKsX+7fsYqw4MEIO2rf7iVocRhbm7NetudRPvfuobThfBpTUivzvwsJrfcJbvk1WAGRduUmULefeDV1CkEztsAd6Tsf32Y/Ex44XA1HpnuRHMuWGWP9o+zIya0Vg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XcbDdnX9; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XcbDdnX9" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-81f52945098so4991907b3.0 for ; Fri, 24 Jul 2026 06:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784901499; x=1785506299; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=jOq8PKa6aIygrh3C9B6cO75yjjM9OGV5sf4Vbyk2dT0=; b=XcbDdnX98q2nAjJECWaWSNrGQ+bHXeyehiNy1296XT9XVwb5s4cQiHq7jHAGWsFKFG AeYsQqtSo/BHpyqCnWkNW66MK7asg2x3nGi0qAV+el+Q/dCXOMAmR1EiBQZKLU9OTDaN Lc7qNAp3MjCIZnsm2wZu0Y4MnKKZHe2PAPQZd+NQacEzlzm9y0rxvBFNficHUKxJu4Xx Ge2ygSDtZz89hMIBuDdGH3PJkQB3wiWP2+KPMlA/ONE9gNQs6tgdu7XAKkDu3+j+lpRg NFCguoxD19zLwtngdnpG5NtwBaOCT+b3tKPjOhyf9ah9jrJpf0bAVLnAuYxXv3stNfel ew1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784901499; x=1785506299; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jOq8PKa6aIygrh3C9B6cO75yjjM9OGV5sf4Vbyk2dT0=; b=niMLTvYddA6qtLVoJht5j4v7+zbFl312XK/6wIJ8L1ScaU9SPM/emYnoLXV5/kCGg4 5bZebhsAR4L00PH5rZbe5aJqz1DIs3k2/AZFO9Jc5Ow43Oa135/MznjVgfUaYT3tQdcj 6vKdsef3Qcl+85RTOPw4OQRyXBpx5tcU68ykVIHjC+FR5WaEA2FOWUHFkNzNdN6xej8i nGyFkh/vJeRFsXyGC9XnSIs8D6tzoz/KInFtZ7M+h3FF/DYKr9R2WbBzoviikbqqwyjQ nJBb31iZ8XsWneu8sysrlWSpxXcC0hULrjvv4RFQ5yLL3XpWo56beMHomNXPVdbfZN3Y 2AfQ== X-Forwarded-Encrypted: i=1; AHgh+Rq4NmT3/47rnUP0sesmf6ZQdPEP640WAjaVuF12R6YTb1BN339szYZLFPELx3JmlpDa0o36A5rlNtklhEg=@vger.kernel.org X-Gm-Message-State: AOJu0YzHJYdBCVsCwl0euSWMD97R1L5lKwM0mFBFs62W6HFO4KLQRAuZ fDWRXjpCfF0Kach/lsv8++EAIjEFivG4ArGX24Tpe20QcNR6nnoLfQU= X-Gm-Gg: AR+sD10rUwOm6F4/2rMUzVX51sKTvVXWkBIpowix8fqm/FB2UQVJAF/tBK7SJSy2/JH OuY4+fywyjYdvNbAN+sCAJlJ4T2sZcgp/ClGywnbwW6aY/L/NDrpYv3BYXvmNcG0mRWcFuVsXS9 RKMT1GHr4noBUavGQrGdeftlipMRNB5rlUyokF60sUBYrckMc0i4djhuK95dENKQUxLJeKCYp6f voeCViJLU9Yny0OLnVsd3BRzGNeyQO/LD8qleojPxvqtjAWVbdMiRT1FEZfCEKTrmUTY+lQtOOQ C2QNqPKCI6VZbB0Y+ttM6lyeL8fxa95GKwBZgGRu7N126aMaIgH2l5KSPQvbskQxojVaY+naR+4 5KyVdoUKKYWhgpHrU0JA1+DmT8TL25Nq3noGUatxBCD4T2RR/rseZotRnI/bKVfUjwl/DZqbMGp KKoTO1uOjvCjJjfUWuclHKRc0uYW0= X-Received: by 2002:a05:690c:e3d0:b0:81c:2a00:aa42 with SMTP id 00721157ae682-81f63faecc5mr1632347b3.20.1784901498554; Fri, 24 Jul 2026 06:58:18 -0700 (PDT) Received: from t-rex ([2401:4900:1a5e:93db:310f:3bc6:10c2:6175]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81f658fc799sm191397b3.34.2026.07.24.06.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 06:58:18 -0700 (PDT) From: kr494167@gmail.com To: alexandre.belloni@bootlin.com, dlan@kernel.org, elder@riscstar.com Cc: linux-rtc@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Surendra Singh Chouhan Subject: [PATCH v2] rtc: spacemit: handle regmap_test_bits() error return Date: Fri, 24 Jul 2026 19:28:03 +0530 Message-ID: <20260724135803.81223-1-kr494167@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Surendra Singh Chouhan p1_rtc_read_time() called if (!regmap_test_bits(regmap, RTC_CTRL, RTC_EN)) to check if the RTC was enabled. regmap_test_bits() returns 1 if the bit is set, 0 if not set, and a negative error code (e.g. -EIO) if reading the control register fails. Using !regmap_test_bits(...) evaluates a negative error code as boolean false, causing I2C/regmap read failures to be ignored and incorrectly proceeding to read time registers from a failing device. Fix this by capturing the return value of regmap_test_bits() and returning the error code if negative, or -EINVAL if the RTC is disabled. Fixes: a6de182daa2b ("rtc: spacemit: support the SpacemiT P1 RTC") Reviewed-by: Alex Elder Signed-off-by: Surendra Singh Chouhan --- v2: - Use ternary shorthand (ret ?: -EINVAL) as suggested by Alex Elder. - Collect Reviewed-by tag from Alex Elder. drivers/rtc/rtc-spacemit-p1.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-spacemit-p1.c b/drivers/rtc/rtc-spacemit-p1.c index 43ab62494bb4..1de7bd995d29 100644 --- a/drivers/rtc/rtc-spacemit-p1.c +++ b/drivers/rtc/rtc-spacemit-p1.c @@ -57,8 +57,9 @@ static int p1_rtc_read_time(struct device *dev, struct rt= c_time *t) u8 time[6]; int ret; =20 - if (!regmap_test_bits(regmap, RTC_CTRL, RTC_EN)) - return -EINVAL; /* RTC is disabled */ + ret =3D regmap_test_bits(regmap, RTC_CTRL, RTC_EN); + if (ret <=3D 0) + return ret ?: -EINVAL; /* RTC is disabled or error */ =20 ret =3D regmap_bulk_read(regmap, RTC_TIME, time, sizeof(time)); if (ret) --=20 2.55.0