From nobody Fri Jul 24 21:30:23 2026 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B89941D113 for ; Fri, 24 Jul 2026 13:50:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784901044; cv=none; b=W1X7MKslzeH0gTTA0kgwlgqyfQfX332rHTPvgZt5Ulz+cAc62V12RzJIqkRO4ciYR8vmNEoPApq4oTWB0vpKDhj2NCcAQ6ataQ3V5yzsqAM97fEwNjp9HU0h7UkPfHl2Ae16nqoYbMH+hMcm1MviTZ5fAWbroP2/JiSZbztm0YI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784901044; c=relaxed/simple; bh=4Htcbaa/gM8THJ/Z1/Iayukjsepp5V2bmR2x0uBunqw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rm6qd7ImF3Emt8fmJ7FfeW8+j/QBOvKZZaMKZI+zxRIbD91ZAqbvRnlWpZ3Hw5127C21b/rylIURJzqF73RQf6bUoJoXPjF8djXZpOAp/cw95T06HRuIIXezUDCYWPSsb/pzIQyISJTWQiR+pV5WUCSqja+laMI39i0pfSSR4bs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A1hmmz97; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A1hmmz97" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-c15e03c2763so83462666b.0 for ; Fri, 24 Jul 2026 06:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784901037; x=1785505837; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=5vLc+vG0rGVVOWe4a5Zin60GW5eTEpkkuLWioXbed9o=; b=A1hmmz97rdv68U9KtHIKTlwyqXI65houglpG21/YFBS/8gepXALbssdleT7/BZD+Je wGPSlSisAD27YsGUpK8Yq27PN17eSz6KJgT79pMcMSuUxQ2/7ozeJ6/3yU/XWbB3z1uA hwNzTbFw8ihD15qU06dWeSySkRC+R3eTux9BJ1gUw2g2QepUJiuqTXcjIlEJ9G3gI1vs kCjSpVU2D90SmUoTyT8q5tI1nYfYWNIvbLWtTFpFTuut6O+rujs0R5JJLuR5J/acnTT8 1tbYGMnfUD7cI8TtO8Ct62o5Kd8MjdYQA4zvZJc9aZFeSIvdra8dSWJC6ogtQyeEj9jP u1GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784901037; x=1785505837; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5vLc+vG0rGVVOWe4a5Zin60GW5eTEpkkuLWioXbed9o=; b=LaQ+t2+4T5FWoeNPK4n3Cc1Ko6+XJeYhd+s2dnCfOrZ4OKP57ajP5VXj+Sukul3f4p l7nd8TMWkzg+B9LvBZIbqSZSalKCstMu9RLEOxTeW9ENhjoR9BJ83LXOLJBI9Z43zOty 2NyrkPPdASnz+OVAhjE8jBE1zqxh5kHjHl9CkzTZHu+J+XEYTqlpA+VXOSiBq8lnEfNQ DmI8X1gMRfj2g79d8f1oG+sCMcasjnPX401fd0Jvtk/3LtqYh05t840WcPHWuAlMI/N5 tLOHZvYBhx8pWGvbNIdlQ4TUIUbBPQ2aGNM41QZLzycSIieiB3kz8Y5UX2JeLc/IsDOs 9EuQ== X-Forwarded-Encrypted: i=1; AHgh+Ro+MII24unHNaCLARQuGWbrCGRyvwArkzV4KmLJRbLerlT/bxMMq3uB7R+QjfZJmfqyzKFkG8GegsOXnYQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwVTEJtI33MxyzbP0iHzIl4s9FIN22qYNRdenB2bHbkjsqss1kt mip3Z9RQFM4lmEPO6bV6PoIiJNnxyPsNsJP9RylwiwDNNpD7xm4un4EH X-Gm-Gg: AR+sD13403FlBhO8aNZCoQi0Gjy8rEXQDPP/x2ChCBEOAoa2iZrAgGLquVD3SwpMnbF nDKzhXuyXx3AjOwD02CttOYra9+5xnC7a+HyNSo5PYHAhgRqlnBfZVFS9CYA+YQCmQJ6NBF3ozQ McD/PrzuW4nu/TRZ5yLxP7bzyHrZlykHqzDdXzMrDZCoo4KBXBhBFo9crEjVfviGQa4wdLR9jhr D7Nj6/Pal6qM9s0ULrp5AO4iFm8oP4h/UrbuuMNQGWYuL6nXhcO4T7UeRBJe8IG9PK4+DuF5tCR 5Vm4GoeUbzEk0xeInsk8YSZkVFGh/S+QZX77wVUGxjtey2BX41kgNL1vG7oQPkRdDzheBP8BnHl ixeqdlFge9Mx01jK3UzsL7Z80FXhar6oQPUuSyy1+Yl1sjlP/gQLdS0Uu/vE9jWxhq7Qnc4tQnK VlD86b3H52W1qtgbnVAvoITLgLOp2az/AUo/vysw== X-Received: by 2002:a17:907:c21:b0:c1c:6d29:8a11 with SMTP id a640c23a62f3a-c1f1397b66cmr39700566b.13.1784901036978; Fri, 24 Jul 2026 06:50:36 -0700 (PDT) Received: from qiwenjie-ThinkCentre-M760t.mioffice.cn ([43.224.245.241]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1c32a798a5sm349051266b.9.2026.07.24.06.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 06:50:36 -0700 (PDT) From: Wenjie Qi X-Google-Original-From: Wenjie Qi To: jaegeuk@kernel.org, chao@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, qiwenjie@xiaomi.com, qwjhust@gmail.com, stable@kernel.org Subject: [PATCH] f2fs: avoid stale FI_COMPRESS_RELEASED on release failure Date: Fri, 24 Jul 2026 21:50:26 +0800 Message-ID: <20260724135026.500859-1-qiwenjie@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" F2FS_IOC_RELEASE_COMPRESS_BLOCKS sets FI_COMPRESS_RELEASED before walking data nodes. If release_compress_blocks() fails before freeing any reserved block, the inode keeps the flag while i_compr_blocks is still non-zero. Then F2FS_IOC_RESERVE_COMPRESS_BLOCKS returns success with zero reserved blocks, and regular writes keep failing with -EPERM. Set the flag only after the ioctl succeeds, or after it has actually released some blocks. This preserves the existing partial-release error handling and leaves a failed zero-release attempt unchanged. Fixes: ef8d563f184e ("f2fs: introduce F2FS_IOC_RELEASE_COMPRESS_BLOCKS") Cc: stable@kernel.org Signed-off-by: Wenjie Qi --- QEMU fault-injection test with FAULT_BLKADDR_VALIDITY: - before: release failed with -EFSCORRUPTED, reserve returned 0 blocks, and pwrite kept failing with -EPERM after remount. - after: release still failed, reserve returned -EINVAL, and pwrite succeed= ed. - normal release/reserve still released and reserved 192 blocks. fs/f2fs/file.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index c54897a25981..dca1722f92b3 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -3916,10 +3916,6 @@ static int f2fs_release_compress_blocks(struct file = *filp, unsigned long arg) goto out; } =20 - set_inode_flag(inode, FI_COMPRESS_RELEASED); - inode_set_ctime_current(inode); - f2fs_mark_inode_dirty_sync(inode, true); - f2fs_down_write(&fi->i_gc_rwsem[WRITE]); filemap_invalidate_lock(inode->i_mapping); =20 @@ -3963,6 +3959,12 @@ static int f2fs_release_compress_blocks(struct file = *filp, unsigned long arg) =20 filemap_invalidate_unlock(inode->i_mapping); f2fs_up_write(&fi->i_gc_rwsem[WRITE]); + + if (ret >=3D 0 || released_blocks) { + set_inode_flag(inode, FI_COMPRESS_RELEASED); + inode_set_ctime_current(inode); + f2fs_mark_inode_dirty_sync(inode, true); + } out: if (released_blocks) f2fs_update_time(sbi, REQ_TIME); --=20 2.43.0