From nobody Fri Jul 24 21:29:32 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7988C2DF153 for ; Fri, 24 Jul 2026 13:05:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784898359; cv=none; b=VKD1dn/BBqWsQY2cIEtKZJ3jFaLzGRaIybWkr1Y6f9+Wplcv0ZrRvy1F6dVE0zgfdvh9GFUBE+AuuehlB/OF5THLKlz7HrFH5UpxILRCpsR8aTFLxbVMXEj1GPF9Ou/W4thdxV037Xb8ZQ0KmurBbSnFHrNaPdeLo8ZtNQ7vitw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784898359; c=relaxed/simple; bh=dXHCFcUJQsMwTExHkiATQxrOJr7MIdFpXNwCcJ8R3Oo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=sQ/zLo6hP7R4KwIZAZdv7hcpoUpUsCd0HxRDMYRRuZqBIh/6qEej/gfir2r070rr4X38eJfNzsJQ8mp3rp/0seneYzQZFUAi6hmvOzLHDyp3ELSmlbePho8DsGyZBOy9lE7bQdjyY5FisFuMMUH1fRTsVHWQ8Ksa/sTFcaB6Ffo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XFWPWnwt; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XFWPWnwt" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-47f96c5b722so332166f8f.0 for ; Fri, 24 Jul 2026 06:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784898356; x=1785503156; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=7ffTcP/8EWckqMdUYwoVUNH5rNYwFmBDuzzlwPoFbkE=; b=XFWPWnwtfkiBY5ieb9F578q3DOfnokkrJPRcewUuBxH693T8Mjb2Gm4NdeiOHstyrm cXUjqyj3OBVPYQ//6xsiTHTKh7EJPnDWyj0kYeQYFIa5HcBfvFIaLqGk04cQVk/hc+fc zLn3SKwava84YognxNb+bZullrPSwK6tliDI5s2apQNWlV920ErDdmWwAei7yV6tB90I oumCfKzf6H+imvvyYCY0UFf3o0Z9D85TY3ek0ERaI7JbicpG6wxsPpRf4/LhoRma3S8X CE8G1mQiczVSQWkKY0fe8frwWcgKf7/EIMtsK+PO1f0yaWcVg6m5E4kouNcc/PBwKWVd ZP7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784898356; x=1785503156; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7ffTcP/8EWckqMdUYwoVUNH5rNYwFmBDuzzlwPoFbkE=; b=iWhJjnn7Nnjmo7fO3srv5PEKHvGxFrpJTD1b8pZjbxPbXzRyOpf0RS5JzlgXBq1Df8 Ud8sOKNXJhGiWtrAERQEvn/EgxOfiY2f3sjMUtNgf0s9mDDraDOyI+Nyg5BhBVHVNuWA fK7AYEIJYlRXrCsjDNlLsIQ3JSbCYaLhIzh5vfhspV4tHh4prbc1fc2vdJ+zqyvKHxQr TWkXyoyHFDJAYz7hXhEhLn7w5yGCOjdX3mOBwCjYv3y9K4ZgAZHzxWmylcN16bNtGTd0 YX9Seh4UQtfs/MfZtGcCiyzwedmXWq9kVsRnkFPX63Svq9ST7Wbp6/RYbmwh1gQAlonK Typg== X-Gm-Message-State: AOJu0Yx8jQOZeckmTi8qTZXQC4izZzS6lwtzsKZ4lg0k8RaI7YDOGmL4 Z1/cj0+DcsE6TRG96YkwswXem8IuG8Hmbvq3TFkF+rzvY5nRe7rlU2h+ X-Gm-Gg: AR+sD12GvtcH6W7EmmExF1yX29L5p+jvFw737HVJFywU3KUqiG7JzrBiPGsEIJohkFO eZn940+DXkhjDt9RuRhZSkZEBeSa96Yim/ap48K6KQKgBDZ0svKsud4DEYonnam8sfOSSFmUeq2 nufldEh5HSQ0nGVy7a/J7447J+3vj+y/vLGsmtLPDzBfjvz68KuKPcdEp5I4GkaYdmNNyn2nBGM vg51kmra35bdXdxN62WacFyp+E+YgMrrGaqWjVbBdsbYPIHZGheQn6ZgcFrnYRgvIU1EoQeuhdX PKP27LBfi7BA8gIJg/tUsxhV86FCHzDQH54daZt8fZUSAgdsrBuSr4lKKblO7WSv2Z77XOJTgpf +TjuiWuEdXHNTK6j9ctMzOfKyEibIgZglBGN2nfdIZ5GXPouZokcD556UqLCQKLPNCse9w9BUcG ozJR+jhPqVjln6wXdoMatJo7k+mZHLSb6/4w== X-Received: by 2002:a5d:5f86:0:b0:47f:2dec:fd64 with SMTP id ffacd0b85a97d-47f8dc959a8mr9790406f8f.45.1784898355462; Fri, 24 Jul 2026 06:05:55 -0700 (PDT) Received: from localhost.localdomain ([95.43.220.235]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85b9a64dsm26255464f8f.1.2026.07.24.06.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 06:05:54 -0700 (PDT) From: Ivaylo Dimitrov To: Sebastian Reichel , Konrad Rzeszutek Wilk , Thomas Tai Cc: linux-kernel@vger.kernel.org, Ivaylo Dimitrov , Merlijn Wajer Subject: [PATCH] hsi: omap_ssi_core: fix missing DMA mask setup for SSI controller device Date: Fri, 24 Jul 2026 16:05:22 +0300 Message-Id: <20260724130522.706480-1-ivo.g.dimitrov.75@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The OMAP SSI driver uses a synthetic HSI controller device allocated via hsi_alloc_controller(), which does not go through the normal OF/platform device initialization path. As a result, the embedded struct device does not have a DMA mask initialized by default. After recent DMA API hardening changes, dma_map_sg() and related helpers now require a valid dma_mask to be present, otherwise the driver may crash or trigger warnings when attempting DMA mapping operations. Fix this by explicitly initializing the DMA mask for the SSI controller device and setting a 32-bit DMA mask, which matches the hardware capabilities. Fixes: f959dcd6ddfd ("dma-direct: Fix potential NULL pointer dereference") Reported-by: Merlijn Wajer Closes: https://marc.info/?l=3Dlinux-omap&m=3D163799095101818&w=3D2 Signed-off-by: Ivaylo Dimitrov --- drivers/hsi/controllers/omap_ssi_core.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controll= ers/omap_ssi_core.c index eeacc427fd659..47826315d7d62 100644 --- a/drivers/hsi/controllers/omap_ssi_core.c +++ b/drivers/hsi/controllers/omap_ssi_core.c @@ -502,6 +502,12 @@ static int ssi_probe(struct platform_device *pd) =20 pm_runtime_enable(&pd->dev); =20 + ssi->device.dma_mask =3D &ssi->device.coherent_dma_mask; + + err =3D dma_set_mask_and_coherent(&ssi->device, DMA_BIT_MASK(32)); + if (err) + goto out2; + err =3D ssi_hw_init(ssi); if (err < 0) goto out2; --=20 2.39.5