From nobody Fri Jul 24 21:29:28 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A50A83515C3 for ; Fri, 24 Jul 2026 12:59:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784897947; cv=none; b=f4ct66otiM1JWNp2VDZ6P9lWwpknjYkU4vaNr79uz4erPegeFeJvv/T/Z7iXC0rnUeH89xU1i3ErU2h7i2s2sZFaZ4lsePXABSse/zkjCe5wr6NfudWfVuNhQZf1MEbVL48cAR3NfJoLNgnnCi5Kb9lzg4+XITgUwLvQT9GBAkE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784897947; c=relaxed/simple; bh=8c6fwm7BVy4bOPRHmLys3nr8Vc3lZrSSHSaOl8QUdDA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=k0/XWGypG2queK3cH0QFWKYdpFB8V07U31oI+LPKgPwyyLCmErFiNt+doV/ekvMdXmMCGaXmRBtNkUBl9ThL1Xy7AQ3EN7NwjIFnchCNaDkzFLILzvBlT/bp0hvhOB3gK2HauxdYx1/iJbXu5iJyK4F5LxBTQ/YbmlWkTn3DlOA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nTn1U84q; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nTn1U84q" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-84a2c90e383so1032088b3a.0 for ; Fri, 24 Jul 2026 05:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784897946; x=1785502746; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=+cRfv+ctKl5fOlsjmKm82KfGL4tm5D0Gdv2mvh03kd4=; b=nTn1U84q0HDqCNRNIiWyVrKRZDI0w7atOStPS+KHGGCRhkK3CdFYiiFDyGE52iOUS/ T/g7xEpPCKZn2jDTUCuRUxY47Wq0sM4rRGwIbcPAV7GO0pa3pKSN2HNuCqGwBEsotvqC OFfRHCVqM9YU5KiFUZAKjciNYd0Lx8QM/vLX3SvLAI6xYSYIahQGua1dIUDZNoRnkNn0 jKwXPdHFiLEZQgLXzrHJgK8Vr63FaVHJVluKc9kAVcTw07MZoHonT4CI+FxiQbr5/gGj YY0DDa8XQG5UfW0Rz5ZJD3ZaaieJm4mdO+AcptwSKKjPvNGvv91yYOL+0vzotI7py76Q UiLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784897946; x=1785502746; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+cRfv+ctKl5fOlsjmKm82KfGL4tm5D0Gdv2mvh03kd4=; b=QCX9u+on7jzYwvexkjbshmndKY1uWCEGdeIpNqeMO7y7NkqZlQhA3Yhlq4Mjb0XAdX h84eb6WD6CAB07U0FFzLbQxAfnBB9EERdsu6fVKignrYKmZp20Ks8x2mzumT3yoLUaV3 l7uw0BxTRmtNxUUEZScNWkLCRopIq0AuLG7qDLwnFK1LLGuGITqAa6tC0vKAG7MxK68Z hTX4AcuCQQZjsm+CYkAHKtPghyuPff3lU24mYGdFgZihpFw2LToVKwycht//8QcRTPUU kRgXSpUSTuVT6LP8ZjY4gilHlkkb6Yhy+0zbNakIHsKQk4gGmJkRzq/e90pps3r5Yqab XwFw== X-Forwarded-Encrypted: i=1; AHgh+RooH1SKpx0gvA0gJHFzdPEoCLY7bc3wjiZin9CjQhT9OQ49LgDrVLmQrXmkm79XDm7DQR/bEVbVOAJq0Q4=@vger.kernel.org X-Gm-Message-State: AOJu0YwZSC+BIeQUjfWstxUG3B/s12s3l80cJDg5GnaT+UcS4Vnksc8v F+DLHlsujmmY+sj2/9XwiBNn+NRmTyFcwYYq1u8C+2B1tYijXp72TY4= X-Gm-Gg: AR+sD11hkvotwazjRRqy14iGocHgOcumpy0kByITmMb9RzDAM+oorMUee/jKrWOvFfi uXku3AhmyC40DvDwnDXrme13tCGIQ5uWeUJqdZG+/J9klYcTPzJqpPJ2vxDWdRMz9N63N4R2zEF BkAjL2YoPWC5zJ7fr4w+SeqJSzHul/AKn/Wdb6CshsFaninCHxEuvEoPoEwk8yi+fZlrEJCqkXt 47hwufQlYk2FX7gLdy63msdLJqSbGKUiEkdm8gzhFDHcU8FsFuecgwR+fJfvup6P8oD3bTvxLNA d8mQrALizjyvr8IOB5HkvdH+2XdpqEFqXxwj1BX8W+68CEzb5N9YaO3W62u2oynhw0vzd5OZ1FY kQo3j8mFKMTQlsMggGnzOVplQagDwiQ39Xnz1byTHSA5wOGbPDo1X+y3OQCJR4fjmIu6eip+UbG xI426oy60qBZr1xYT9sVafv10IogI= X-Received: by 2002:a05:6a20:a126:b0:3bf:990d:3fc7 with SMTP id adf61e73a8af0-3c67260e5b6mr493676637.20.1784897945718; Fri, 24 Jul 2026 05:59:05 -0700 (PDT) Received: from t-rex ([2401:4900:1a5e:93db:310f:3bc6:10c2:6175]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc6162csm30400707eec.7.2026.07.24.05.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 05:59:05 -0700 (PDT) From: kr494167@gmail.com To: broonie@kernel.org, lgirdwood@gmail.com Cc: andreas@kemnade.info, linux-kernel@vger.kernel.org, Surendra Singh Chouhan Subject: [PATCH] regulator: tps65185: handle gpiod_get_value_cansleep() error returns Date: Fri, 24 Jul 2026 18:28:57 +0530 Message-ID: <20260724125858.75635-1-kr494167@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Surendra Singh Chouhan tps65185_vposneg_enable() evaluated: if (gpiod_get_value_cansleep(data->pgood_gpio) !=3D 1) return -ETIMEDOUT; gpiod_get_value_cansleep() returns 1 if active, 0 if inactive, and a negative error code (e.g. -EIO or -EINVAL) on failure. Evaluating !=3D 1 treats a negative error code as non-equal, swallowing GPIO read errors and masking them as -ETIMEDOUT. Fix this by capturing the return value of gpiod_get_value_cansleep(). If it returns a negative error code, propagate that error immediately; if it returns 0 (inactive), return -ETIMEDOUT. Fixes: b0fc1e770194 ("regulator: Add TPS65185 driver") Signed-off-by: Surendra Singh Chouhan --- drivers/regulator/tps65185.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/tps65185.c b/drivers/regulator/tps65185.c index 786622d8d598..1f13e4156cab 100644 --- a/drivers/regulator/tps65185.c +++ b/drivers/regulator/tps65185.c @@ -183,7 +183,10 @@ static int tps65185_vposneg_enable(struct regulator_de= v *rdev) wait_for_completion_timeout(&data->pgood_completion, msecs_to_jiffies(PGOOD_TIMEOUT_MSECS)); dev_dbg(data->dev, "turned on"); - if (gpiod_get_value_cansleep(data->pgood_gpio) !=3D 1) + ret =3D gpiod_get_value_cansleep(data->pgood_gpio); + if (ret < 0) + return ret; + if (!ret) return -ETIMEDOUT; =20 return 0; --=20 2.55.0