From nobody Fri Jul 24 21:53:04 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011032.outbound.protection.outlook.com [40.93.194.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BE113D9DAA for ; Fri, 24 Jul 2026 09:53:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784886810; cv=fail; b=sf/YA4apUVrjDzv7Zpiw1w3EV+Lbhto5y6rvHtjKK7zVW7YRpX3Yt86zjUeqlS+T1kwScpMYVQUaUYYqBOzo/AIw2eAZiOVEC5CdrcjletKR/57xfEjvbBST9sFpWsIEwqVwr6+zAv3nD1NVafdH0sy6PxtHQEkDyIEglEABhFs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784886810; c=relaxed/simple; bh=tXiPltHQ6aAyKv8KRr4UOcCUW3JGV+SPTWAJPyvYLTE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QM5q1QqbzmfPgRH+ZLZZ93ZAWiAlIUwyE1P3Q+VzPlaN3r7RoZDj5u7kQopi2FljwX2zHXubcBpbqVgglLhX3ZSBPKPJ8ZkwB6yutDTs2pJBCK/yoFe4nJDLyabiu+1rBJkMvGTSNmoxXfek43+UUwjZ78ykDSMFecg1cMZiB+I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=38wuYJu7; arc=fail smtp.client-ip=40.93.194.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="38wuYJu7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BbZNZ8JCMRLq6xnCIApGKjtz6HLoTrrbsqhSxwkFcCyrQOdRQi6omKSfPoXRRxr/sSd8F7fQLN4KvKoSrApm1ITr9BI4if2hRnWXWRe6o7siGMpPtH22AWExTEkiYYwSTE+cDJ6zjvVXSxo+HHLTHzQaylqeU8UYE0MzsEZDgULUjY6cHSh5AMGNA0pns9OmU0DT7UDtGAdmY3BKczuThYcn35Vrfg2qwun+SI1kKmOChiyr4GbTqOqX4Cx88aYVqGaUG7iTSHe9LQdFSg5ldZxVxCsBHAlFuv45JBFxUkOHe61GtrqDfSwL4VP/mkpMIQMRcKLsLw798CugFm2c6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S3TgU4rRzOrKm4hfmPQeRNfydeIerif+Z8QCIQhT0g0=; b=lHsFONmPT1gSKaNLdit6SnC0enHpg2Nl7S8qotv81btp6FX3Px+GlBIyGpR4GTXWK5F6E/Blg+TbZe/34Eo/n8jY104eHxsarvlYdqxHpl/41aAF6j/bWxLV7pnhWhlrM6DTWECWKcgffXzd1wysW6uSEgdzm/itzBARZO1ISk5sfU53/ith8dvXgwwAn+GUtPkPZLk+UvUK/Nw3x8e7QVxdC2UHiJWILxlNQI4bc+QPNIzjM6HffF6GZeGK7iprMuCT+R3GReL/faWQYgXDf9bY/A3L1ofnB1nLU1+ONY2g0eSQ8+L28gx95mf+7ErnF90BpcyRgKCeSkzCPomyFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S3TgU4rRzOrKm4hfmPQeRNfydeIerif+Z8QCIQhT0g0=; b=38wuYJu7q8B16J7uwGMo5rctYBuUxDWTp5HEsxnrXHiEgx/cqbumXJtLmZCKzPq3G8EZarSrg4RkJsiwSvuQGJZq7CESqJggqfVIaNC9ONkzuY2kM0v2eB2RLCZyIs1vT2lQrM2CrrM8/gBZ1Jie5T67eE0HRj+/FCYCWH7dlWo= Received: from BN0PR07CA0025.namprd07.prod.outlook.com (2603:10b6:408:141::28) by CY1PR12MB9700.namprd12.prod.outlook.com (2603:10b6:930:108::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.12; Fri, 24 Jul 2026 09:53:24 +0000 Received: from BN3PEPF0000B072.namprd04.prod.outlook.com (2603:10b6:408:141:cafe::60) by BN0PR07CA0025.outlook.office365.com (2603:10b6:408:141::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.11 via Frontend Transport; Fri, 24 Jul 2026 09:53:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BN3PEPF0000B072.mail.protection.outlook.com (10.167.243.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Fri, 24 Jul 2026 09:53:24 +0000 Received: from xsjarunbala50.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 04:53:23 -0500 From: Jay Buddhabhatti To: CC: , , , , Jay Buddhabhatti Subject: [PATCH v2 1/4] firmware: xilinx: Add support to clear TF-A PM state Date: Fri, 24 Jul 2026 02:52:59 -0700 Message-ID: <20260724095301.2890001-2-jay.buddhabhatti@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260724095301.2890001-1-jay.buddhabhatti@amd.com> References: <20260723124841.2567827-1-jay.buddhabhatti@amd.com> <20260724095301.2890001-1-jay.buddhabhatti@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B072:EE_|CY1PR12MB9700:EE_ X-MS-Office365-Filtering-Correlation-Id: 50889478-691b-47eb-1384-08dee9696731 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|23010399003|36860700016|376014|6133799003|56012099006|5023799004|4143699003|11063799006|10067099003|18002099003|22082099003|3023799007; X-Microsoft-Antispam-Message-Info: CKHldz6YtVjGaS/FxHW7elOgHCUIm0j/VdOKGXuukuPGxb9WTn0XR2mbkIOIvhLxTPWXIcuCxxnOKnVvOYi0TV6i5JuGP43dG/Uf+x7D3DjJB2WIicWwBeSVRCpSBoeKX5G3sMaRK47JnETu35rkhDZz29gSn02lEn3Rq3c9FiWMxpDWjTu+4qzF0AthoXpoeDhJP+6/UE3u7FbI1w90l2qgC55foSRVs9x9VJ1ICxMURS7RqxoXrdREmRwdn64PjQCdVrDPvXdoF9SglW5ZrSt2C5wnQExskpJeTVWL8KLri4kozXFBrLxAVMU70kBYJCdkYoRxS0VtAvE+u2qzi47BSahpIp9WEZmEfBYjc7MmDMV6R4FZUgBC1Fmze6Ww0eXf5ZtNdzMOxmsymwlrzTGX2zDISM4DAdyRrSxvncd32+bB+X0jBWjLDlJiw0zEYrmr8CrXpaH1frOPJbVJEX9iFsuYYYVW2WlOvF/CxyIjAIchRD7qETDUx5I0fkYfKFvSwCmOtzPtaTQqTziRfmahUYPwW6wU5caIGE+tsmSNnKcULZwunAYeS67znJ/P4zG32+2S/plFcwSxFmLpLxZ/BvC7wVGojP4xL9b0SLZtMdfhLiQeweyGnrD8yZWt8JFVBB4BSI65p9pu3pb2hUki/7UFGTpPHF8p8u0BCPw9/smmiw9TNPlF/lqLxMmnkqdUfpQvKncHHCSQkyvZcw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(23010399003)(36860700016)(376014)(6133799003)(56012099006)(5023799004)(4143699003)(11063799006)(10067099003)(18002099003)(22082099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JT5lIG+BH3bZit8zkA4xKEME5TKpLG8JkzMHXY8KCAOzauWMSBFwuHWt7lWWBig5d0MbdgDNHTbEXvY8Arh0qQGfbjzVMguywSSsW4F7kkQ2359+DMWCenlfcGvjxWfgqsHcLAoXglHo6xZrWzCZawGwBpxTPzFXjb+pEjRLvtxEcfrjsO4rW5uSj18GQAloftsFsaiascyUxqXPcLnzs1ruZftHU9ALdfesiv1lCom+6jjK9hngo9KTVyY12ChYSCVNJ9VvdnRAdwkSVZbku9JXH6l+oN3rNkYFJEgpUPab3oQEzNADudDFL8ptpVJ+t36EXu3E5cXIn5Awx5jL5x1A+LWLLxjjZvYhKvEtociy/fMKmzzx/nE//k4Y8bqeLQ4E1jk9gz6gYI7bLC2SAlOsyWR5DqnbSQnAQbFewnl3s46eV9ppcLUFtnP+pw70 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 09:53:24.4881 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 50889478-691b-47eb-1384-08dee9696731 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B072.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB9700 Content-Type: text/plain; charset="utf-8" Currently, during a kexec restart, only the kernel is reloaded, while the TF-A specific data remain unchanged. This leads to a mismatch between the kernel state and the TF-A firmware state like SGI number and shutdown scope variable. For example, the kernel registers an SGI number with TF-A so that TF-A can notify the kernel of events via that SGI. TF-A stores this SGI number in its internal state. After a kexec, the newly loaded kernel re-registers and may request a different SGI number, but the stale value programmed in TF-A remains, so event notifications are delivered on the old SGI and are missed by the new kernel. The shutdown scope variable has a similar stale state problem. To resolve this, the TF_A_CLEAR_PM_STATE PM API is introduced to clear TF-A-specific state during kexec. On a graceful reboot, this API is triggered by zynqmp_firmware_shutdown(), while in a crash kernel scenario, it is invoked by zynqmp_firmware_probe() in the reloaded kernel. Signed-off-by: Jay Buddhabhatti Reviewed-by: Radhey Shyam Pandey Reviewed-by: Prasanna Kumar T S M --- drivers/firmware/xilinx/zynqmp.c | 51 +++++++++++++++++++++++++++- include/linux/firmware/xlnx-zynqmp.h | 3 +- 2 files changed, 52 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zyn= qmp.c index af838b2dc327..b5e372190b44 100644 --- a/drivers/firmware/xilinx/zynqmp.c +++ b/drivers/firmware/xilinx/zynqmp.c @@ -3,7 +3,7 @@ * Xilinx Zynq MPSoC Firmware layer * * Copyright (C) 2014-2022 Xilinx, Inc. - * Copyright (C) 2022 - 2025 Advanced Micro Devices, Inc. + * Copyright (C) 2022 - 2026 Advanced Micro Devices, Inc. * * Michal Simek * Davorin Mista @@ -13,6 +13,7 @@ =20 #include #include +#include #include #include #include @@ -2065,6 +2066,42 @@ static struct attribute *zynqmp_firmware_attrs[] =3D= { =20 ATTRIBUTE_GROUPS(zynqmp_firmware); =20 +/** + * zynqmp_clear_pm_state() - Clear subsystem state. + * @dev: Device pointer used for logging. + * + * Clears PM specific data in TF-A. + * + * Return: Returns status, either success or error + */ +static int zynqmp_clear_pm_state(struct device *dev) +{ + int ret; + u32 pm_family_code; + + /* Get the Family code of platform */ + ret =3D zynqmp_pm_get_family_info(&pm_family_code); + if (ret < 0) + return ret; + + if (pm_family_code !=3D PM_ZYNQMP_FAMILY_CODE) { + /* Check if the TF-A supports the TF_A_CLEAR_PM_STATE */ + ret =3D do_feature_check_call(TF_A_CLEAR_PM_STATE); + if ((ret & FIRMWARE_VERSION_MASK) >=3D PM_API_VERSION_1) { + /* Clear PM specific data in TF-A */ + ret =3D zynqmp_pm_invoke_fn(TF_A_CLEAR_PM_STATE, NULL, 0); + if (ret) + dev_err(dev, + "Failed to clear TF-A specific subsystem state: %d\n", ret); + } else { + dev_warn(dev, "TF_A_CLEAR_PM_STATE is not supported in TF-A: %d\n", ret= ); + ret =3D 0; + } + } + + return ret; +} + static int zynqmp_firmware_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -2118,6 +2155,12 @@ static int zynqmp_firmware_probe(struct platform_dev= ice *pdev) if (ret < 0) return ret; =20 + if (is_kdump_kernel()) { + ret =3D zynqmp_clear_pm_state(dev); + if (ret) + return ret; + } + /* Check trustzone version number */ ret =3D zynqmp_pm_get_trustzone_version(&pm_tz_version); if (ret) @@ -2151,6 +2194,11 @@ static int zynqmp_firmware_probe(struct platform_dev= ice *pdev) return of_platform_populate(dev->of_node, NULL, NULL, dev); } =20 +static void zynqmp_firmware_shutdown(struct platform_device *pdev) +{ + zynqmp_clear_pm_state(&pdev->dev); +} + static void zynqmp_firmware_remove(struct platform_device *pdev) { struct pm_api_feature_data *feature_data; @@ -2210,5 +2258,6 @@ static struct platform_driver zynqmp_firmware_driver = =3D { }, .probe =3D zynqmp_firmware_probe, .remove =3D zynqmp_firmware_remove, + .shutdown =3D zynqmp_firmware_shutdown, }; module_platform_driver(zynqmp_firmware_driver); diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/= xlnx-zynqmp.h index 7e27b0f7bf7e..baaa88b0b197 100644 --- a/include/linux/firmware/xlnx-zynqmp.h +++ b/include/linux/firmware/xlnx-zynqmp.h @@ -3,7 +3,7 @@ * Xilinx Zynq MPSoC Firmware layer * * Copyright (C) 2014-2021 Xilinx - * Copyright (C) 2022 - 2025 Advanced Micro Devices, Inc. + * Copyright (C) 2022 - 2026 Advanced Micro Devices, Inc. * * Michal Simek * Davorin Mista @@ -66,6 +66,7 @@ #define FIRMWARE_VERSION_MASK 0xFFFFU =20 /* ATF only commands */ +#define TF_A_CLEAR_PM_STATE 0xa05 #define TF_A_PM_REGISTER_SGI 0xa04 #define PM_GET_TRUSTZONE_VERSION 0xa03 #define PM_SET_SUSPEND_MODE 0xa02 --=20 2.34.1 From nobody Fri Jul 24 21:53:04 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010047.outbound.protection.outlook.com [52.101.56.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC0793DAABB for ; Fri, 24 Jul 2026 09:53:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784886810; cv=fail; b=jhDJ2zAZP2JA9BAE5j8x6p8zkWvUUciplcaU3j3hNVl9hYlTLv/+TWJ6AjUNxhc0YGKoDhMlPeXA6Nle91EMbnFfI7fuCYKy9sYgdTuSzdGrs742lxYLjcklVT/TQkUVeA7knDcj3y/C7FKkghWWsWVh11QLIsOOs32l6EXdmnk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784886810; c=relaxed/simple; bh=TSV2gGXKSxV9C+3keRXRHbXscbDrqOpbkACQfUrpctY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=swO7ESvdPu23T18J+C7XRcJK0x9NEruuUI3KxPxb6kBiRxGnAN1QpciP+oXLfWIoozZgkU6UY2TTFgwbS+lK32m/AoqoQcdZYVqEqZ00PlqqVEX8/MrlXbVGF864NRzhc3nJ9o8mvwQDhV1oUdyw7PcxohNRk72DJtbUP0dIbgA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=IbOs+sb7; arc=fail smtp.client-ip=52.101.56.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="IbOs+sb7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IXguPbHoS/JOIUCFdnQotIPuNk/uZ2IJlpS1z0OLGvwoqAkGlgGX7Hcv9cFITHhMh5MusmSfrDvz4xlewZPDnfC3x9sr+n9ZCa86WO7PX8Cyq3kMCZ5MOyZPJeZCfmBBAPv9CkbUPJytlDM1PBqLo46NGo9kjKa8+CZ04EkSYOXD0/YJv1Jt/aifef2vJOnyb77RpWj4zhBj/L06/wUntvwqIRRiqwLBEc/1ShckkuegHKnaEa3nw7M4/HYO6/05k/fLMtCZ5qOJ0iWKvlJhENGs4guAplbGK2J+Svk3SsnUPut1ie41tLgPq/KrCTYi1JKZQMs+YIbf1ydHFdS8JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2M6fYO7DExB5eVkj7u3WmZ1oP8edC4HwGD8A/I2sqbU=; b=vpkW8o28Y4ziHEVEeK48Q94PS1uhER4iNDQGXiuWBGDIa5wV32ZE4aVQ5BjLUd6BRraRq2K9wc7pUrEZCeGimNFqF3+vppJrvp/1iz8TboGKu4z485yp55Aj1QyX0FaneEJ8SyjlYEvrmAcN6rHUoF03dX8KHDU9kxAZ36ruarQ3m37ch0c3Fduwq3IuyeeF7t+x02kX7J39FUcEOj1BRtvBairEhvQfHxzG7UciaLKJOjVIlPYIbjtc0RA9g6MOXcpkE3ANFJ4lv4PK56grq3bgUwqwUz0eY2GCbgl2rTAmgzf60ajDykE84x5AHBxNykwncs+gzxa+bYctw8Xcdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2M6fYO7DExB5eVkj7u3WmZ1oP8edC4HwGD8A/I2sqbU=; b=IbOs+sb75QszCAxJ2Bp+UiMcV5YZEWsSK8Qspl20coH7sGCedXQHe6vGc6YGvGZMRtcsEmQbNc0/QVJX9mNNbfmQH+iwwAV6Gv8F9cj6q0YPC3361xuC83IETDRypI0mqQ+awAwtQ9/TlAeN4EQg9QWpx/C98sTr2CsZHyOP4ig= Received: from BN0PR07CA0021.namprd07.prod.outlook.com (2603:10b6:408:141::16) by LV1PR12MB999282.namprd12.prod.outlook.com (2603:10b6:408:2cf::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.11; Fri, 24 Jul 2026 09:53:25 +0000 Received: from BN3PEPF0000B072.namprd04.prod.outlook.com (2603:10b6:408:141:cafe::6e) by BN0PR07CA0021.outlook.office365.com (2603:10b6:408:141::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.11 via Frontend Transport; Fri, 24 Jul 2026 09:53:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BN3PEPF0000B072.mail.protection.outlook.com (10.167.243.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Fri, 24 Jul 2026 09:53:25 +0000 Received: from xsjarunbala50.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 04:53:24 -0500 From: Jay Buddhabhatti To: CC: , , , , Jay Buddhabhatti Subject: [PATCH v2 2/4] firmware: xilinx: Release all peripheral devices from firmware Date: Fri, 24 Jul 2026 02:53:00 -0700 Message-ID: <20260724095301.2890001-3-jay.buddhabhatti@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260724095301.2890001-1-jay.buddhabhatti@amd.com> References: <20260723124841.2567827-1-jay.buddhabhatti@amd.com> <20260724095301.2890001-1-jay.buddhabhatti@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B072:EE_|LV1PR12MB999282:EE_ X-MS-Office365-Filtering-Correlation-Id: 442ce9e0-a106-487a-be4e-08dee96967a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|82310400026|36860700016|56012099006|11063799006|4143699003|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: U6810JJiU/jHBTVZafnJzqxGigN4MOEKZVI+59xJAtOzyL2Jdo3D3s/D4eoLW/rEfGsGQSPj+XiDcNDV4mWzRjW8QgFLmTVCQDfxzY71ZZF2VfvlA/elcp7LeuD5SiysoYahNhhFefeB+fl/qKUtw2T2DBwZurkzDuabn0gCwlH63CDYiqnRDuTn06xAd7DJEKChk6wyDd/FewyJ/Q+Iskzh05siXIQ1/Hype5eY0M2S9fPcH32vYOqWGbzMjDTkuufA3g9WQrDviBynfrJRfA7S+I0Vz7QTIV6AsZfkh/jc2dquI1Fa7IwfcMLbpL1ndhGAJb1vcSNuvX9S4Zp7l1fVUp9+SjmizHRTMUuKhsHjMDrbN/MGTmq2yjwq4LQ/L5/447g7NQAAiRlLr1O7ra9Ep98LNUe3ih/vpM5aWleOpM+PX8IIow2tIWTK9WWuDUb/38TBoP4guTx7h1tNzHfuMZIziQfPYlIFiM73zr2W1b8/kLvMF0TpYMRHKA5ANWFYKlm1UJ9ZgmQY2nPhc9fSGI0feoXcl9A6ngUz8FDq0yXu01I91iZrIOj3FF50+7/8tE/LlVYeWu7aMFNWaW4xqwX1IFSFoqF9q6jur4OBY/dI3bVo/hEj76IYLgjKz1gSmr+YGHgPASYxcw5N48/6LfRbEJ2UlGq+19NRDaqyyJ9Toh5D1+JUaJQD3GvSDPco7OzzbA3FuT+VzWn5yA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(82310400026)(36860700016)(56012099006)(11063799006)(4143699003)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: aQaZsmViy//axtGrHfZ2r3C9olrse/Z65haT9SuuoKkcPmsp1csEuXP+Vfru+DR78atvns3AN5+hSYiEsI2ByzQas0ENlNHriL7sMRH+AFKgcfgkoVgBMUa83GJgEZMzCQ5R2q29rtxJ8p3C+Cw0hXa2l5Ltiz6WQsLHLaRwYCsmgdtSuTf6zWtyHCWxke3lysgIC5f1gi/cZd5C66kqCyk+gojlmSPYxB0zdOm2eXnXDimUDKkywzQtJejJjVO1mbPwI+SbIeSJRBh9OTjvKPeqWW7VCKu2D8XInoOnj3ERBD0ohW7QusX1u1lEPS5/b3kAA0S3k9HWIIZK8uhqFJsP7LA6BcErvaL1x+rXKbro3dszl7GHDVAM69TZTQ7xwtxIfXRi0D7E/fNtCCLCOiAmBVCW3Uit1YwqW7tbD8rjCm3voLHjCaub7XNoNs34 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 09:53:25.2589 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 442ce9e0-a106-487a-be4e-08dee96967a6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B072.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV1PR12MB999282 Content-Type: text/plain; charset="utf-8" During a kexec restart, only the kernel is reloaded while devices allocated in firmware persist, causing state mismatches between the kernel and firmware. Introduce PM_DEV_ALL_PERIPH node ID (0x18224FFFU) to release all peripheral devices during kexec. On graceful restarts, this happens in zynqmp_firmware_shutdown(). On crash kernel restarts, it happens in zynqmp_firmware_probe() of the reloaded kernel. Releasing all peripherals depends on firmware support for the PM_DEV_ALL_PERIPH node ID. On firmware that does not implement it (the feature check reports a version below PM_API_VERSION_3) the release is skipped and a warning such as "Bulk device release is not supported by firmware" is logged, e.g. on Versal NET firmware that predates this API. Signed-off-by: Jay Buddhabhatti Reviewed-by: Radhey Shyam Pandey Reviewed-by: Prasanna Kumar T S M --- drivers/firmware/xilinx/zynqmp.c | 14 +++++++++++++- include/linux/firmware/xlnx-zynqmp.h | 4 ++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zyn= qmp.c index b5e372190b44..0deb278b2c2d 100644 --- a/drivers/firmware/xilinx/zynqmp.c +++ b/drivers/firmware/xilinx/zynqmp.c @@ -2070,7 +2070,7 @@ ATTRIBUTE_GROUPS(zynqmp_firmware); * zynqmp_clear_pm_state() - Clear subsystem state. * @dev: Device pointer used for logging. * - * Clears PM specific data in TF-A. + * Clears PM specific data in TF-A and firmware. * * Return: Returns status, either success or error */ @@ -2095,6 +2095,18 @@ static int zynqmp_clear_pm_state(struct device *dev) "Failed to clear TF-A specific subsystem state: %d\n", ret); } else { dev_warn(dev, "TF_A_CLEAR_PM_STATE is not supported in TF-A: %d\n", ret= ); + } + + /* Check if the firmware supports the PM_DEV_ALL_PERIPH node ID */ + ret =3D do_feature_check_call(PM_RELEASE_NODE); + if ((ret & FIRMWARE_VERSION_MASK) >=3D PM_API_VERSION_3) { + /* Attempt to release all peripheral devices via firmware */ + ret =3D zynqmp_pm_release_node(PM_DEV_ALL_PERIPH); + if (ret) + dev_err(dev, "Failed to release all peripheral devices: %d\n", ret); + } else { + dev_warn(dev, + "Bulk device release is not supported by firmware: %d\n", ret); ret =3D 0; } } diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/= xlnx-zynqmp.h index baaa88b0b197..ac39e5492961 100644 --- a/include/linux/firmware/xlnx-zynqmp.h +++ b/include/linux/firmware/xlnx-zynqmp.h @@ -50,6 +50,7 @@ /* PM API versions */ #define PM_API_VERSION_1 1 #define PM_API_VERSION_2 2 +#define PM_API_VERSION_3 3 =20 #define PM_PINCTRL_PARAM_SET_VERSION 2 =20 @@ -145,6 +146,9 @@ #define XPM_EVENT_ERROR_MASK_NOC_NCR BIT(13) #define XPM_EVENT_ERROR_MASK_NOC_CR BIT(12) =20 +/* Node ID for all peripheral devices */ +#define PM_DEV_ALL_PERIPH 0x18224FFFU + enum pm_module_id { PM_MODULE_ID =3D 0x0, XPM_MODULE_ID =3D 0x2, --=20 2.34.1 From nobody Fri Jul 24 21:53:04 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012057.outbound.protection.outlook.com [40.107.209.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC81C376A0C for ; Fri, 24 Jul 2026 09:53:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784886811; cv=fail; b=pk7ePCpxftsK+sRyjFzrbSrEVIWxFSYBmcIL5saOEtqb4Svt0vLsYAicwG0QqF+VlK5v2cnFHPEn2sAdpUzgMch1gElhig2ZWlW8n+X2xknJwqgaO+qZHNdf+8Kwb023oUlwG1A/kdItC4mDjprhW1iCudMvxDXG5r5K+ECrG2Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784886811; c=relaxed/simple; bh=d89gSxTFFBc7gfUKHOvZpMGYF7X9/UnTlpw9mj9qLys=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hGI0oyg9AkYWX6P1txqH28aiSvkMzVgs8fslp/jY01ncPsZhAzO72vMBsIMBVdjlcTBFvnUf8B/PxwX8oAm6hGgLTewDWCRZ7sGuhCMXSpwIpIWpJccmb1g+3uyeBgIMB5rRa0MzMHUZvHYvvPxzoEfI+ieGyS1cECPNdziQUZA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=r8aoCObe; arc=fail smtp.client-ip=40.107.209.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="r8aoCObe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WXAzm4k/0V5r4WoRIP5biTgXLG4IL22jUNfpmZH7/RUauUIcLtEZ0DY8NGjLPDhTVP2ExDfILA4WMamnmQfUKcaPHI44UnNfbZunwtCoFtZfoSI9JmyWpYfJLE0l/HV708XxGmYLUY3zAvAEPVfI8Ccn6qHLw+8edHdAcwo1j/qM2BkQZJhMiiAxJisyuzfeX3ujosuH1Jhs0+mP5L/VDaWlPQnvOIM/z5XN+ngNN39AnoZ8wRpAvExDwzreObDhm5Q4ez3HQ6vSqxLbCxTAE/Pgj5Nrrq72zzTVB6puD9GLVSQvVv+SJxtoxynqquk0tyipLFImt2toFmZOYlcdWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JH1/Hr7l5eO8f8631dkBZUk6vL5wKe96/qcNrf/7kmQ=; b=i8/9wzLanWH4DDgUqO/wzIOBBWs+5qBl3yJqlNa6EX5DPBg3MUpKYuLYUZpGXZ8CIMg/jMc1BVcHBRRAcr2BCrl0Gi/aM+NhEKIFpLdG+vpgNOb0XvPSb3T8ryGsCyRU5oUsHrdhva0s/8QclmZF2zwp5gymXLAWp+Spy0ZkmLPKPK6oYvhuexLC7GiIBrGpnXDd+STVZTpqShDLvUUKEQtm75h1Vh2LwQHrXkwbHHxk+iYDiz6oUjwp1JX8sKd5Nr1Sr4FssKrN3VpWIgyp4AX1q/7F70lwINw4Vtl35aHxoS9N73ABoFERJIqxGCvIALKkaztp55QgRZ28b8Z7rQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JH1/Hr7l5eO8f8631dkBZUk6vL5wKe96/qcNrf/7kmQ=; b=r8aoCObebuWDR0cBN/2dNrynYc42HCrUWKpoTx/MzCcF2qI2qU3+wG/HFsEtm7PMK5GQkMLhw1+7Sr2W0tS2+OkksedOsLMGoaHKar+JarxujDnPQcMbtTbnUIzci8nBaUh0M2P7uXyfCOrpmTgU1Q3TgbwrHNriO3U8FGwfJw4= Received: from BN0PR07CA0024.namprd07.prod.outlook.com (2603:10b6:408:141::33) by BN7PPF7C0ACC722.namprd12.prod.outlook.com (2603:10b6:40f:fc02::6d5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Fri, 24 Jul 2026 09:53:25 +0000 Received: from BN3PEPF0000B072.namprd04.prod.outlook.com (2603:10b6:408:141:cafe::a2) by BN0PR07CA0024.outlook.office365.com (2603:10b6:408:141::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.11 via Frontend Transport; Fri, 24 Jul 2026 09:53:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BN3PEPF0000B072.mail.protection.outlook.com (10.167.243.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Fri, 24 Jul 2026 09:53:25 +0000 Received: from xsjarunbala50.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 24 Jul 2026 04:53:24 -0500 From: Jay Buddhabhatti To: CC: , , , , Jay Buddhabhatti Subject: [PATCH v2 3/4] firmware: xilinx: Clear firmware notifiers across kexec transitions Date: Fri, 24 Jul 2026 02:53:01 -0700 Message-ID: <20260724095301.2890001-4-jay.buddhabhatti@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260724095301.2890001-1-jay.buddhabhatti@amd.com> References: <20260723124841.2567827-1-jay.buddhabhatti@amd.com> <20260724095301.2890001-1-jay.buddhabhatti@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B072:EE_|BN7PPF7C0ACC722:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a6cd7b5-f5f5-43f2-968d-08dee96967d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|82310400026|376014|23010399003|22082099003|18002099003|4143699003|10067099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: imB8oLaCzNXDykHt/6KkOfAOM3TQ21O0PcK1hEZz7PLmjo0jQ7XEjTMozTlwqHsk/hb3lSdBsnFSdHeU7onZ6U3V4CPzwJj5CGVkltBZ2DyUsr7KXa64uSVx2Ym77lcOfT8pKV4t0qlfpY1wE4e5jv3U6LdcaAovEbNQLbNZwiiwaKpe94wk30V3rgg5x6IHo2GFQzjVohce5JrN9LIujGWlXzrRUum8mIo5hU6xb4g5pGbR6zKiAFuvVG5kxOpJPSqcCilHGbM1U198assCKkc557GtIZw0V7RRvyL0MoGcThUwd2WajAncjYP5LbYG5wrFaHII0hl4S3bvN8gYxBwy/C9wuBcQwrmRt3CUx2t7e67ESyeCSUiaMJDdbH3kWpS7WiPYjE4D8HmN2/hk+bgkg2LhC5wMchmG8DIowZ/Uvt6dpSbrXe5N29o9VCHg7u5fi2TsEF2ZHZ01TCW6Nmlc1MpXDIp1ib57HY781pmxiXDTqict4cLtEutse8bLOcyIY1gzGNsa7YgnfcmNeIno1gyQEyLzqhdPCq1gpk5x7p0JHVoNpXEAXik3E1oM7d346hk5gqdmDCxmpcERrtsnmt+aHC+Y/CTx+Se9QRg29CeyqBJiAdz09EbD78pYvNlJz/uWCaaILS7EAgXRTacJVLwvU36k7iUui3X5w07fAAUnnBdrJHvN5G2SPoYbZMKCChSfC18DcOau/xpD2g== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(82310400026)(376014)(23010399003)(22082099003)(18002099003)(4143699003)(10067099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uMhZzouZCHfLf9YgJKK6VjYDWbxUQzDnMg/nsXNhCGO157Ll7UFPcObBm02V3vHFgC8j/rV5v6k9OfvnVhmptaNPR7uFcjoDPZJhA1qK0wxD9gwLX8Bc2WiS4i9CeJ7wd/v6ufnJ/DdXpLm8Io0Dwr5EcIL3l3m5TnCiwg9T9uv5HO5fh7yeJcnp3NnfzaY46hvpnz9UjU79TzYqGhbH5g4kUvGshu5sducYDPJglvjzOVZk6gWyQE+B/4kRz4SDVQT/YDmYnErLsHhZ7PrIzMxTR/VfyGwZzo/FZyss6Ku+V5wXXTfzzytVDHQsdwfIxjEtmehAKEGWDCsxFjOjmhODICkiez6rgntNKEjulPoB8cj+JBzEoaLslumoSAQ+V0sJzuu3M7FXc4O8DBU8LiHYwXPzB0HkUlIb6GdrcaD5wzgvoGTXmXsfxNdFjKK7 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 09:53:25.5393 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a6cd7b5-f5f5-43f2-968d-08dee96967d1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B072.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PPF7C0ACC722 Content-Type: text/plain; charset="utf-8" During a kexec restart, only the kernel is reloaded but notifier callbacks in firmware persist, causing state mismatches between kernel and firmware. To address this, introduce PM_ALL_NOTIFIERS node ID to unregister all notifier callbacks during kexec. On a graceful kexec restart, this occurs in zynqmp_firmware_shutdown(). On a crash kernel restart, it happens in zynqmp_firmware_probe() in the reloaded kernel. Unregistering all notifiers depends on firmware support for the PM_ALL_NOTIFIERS node ID. On firmware that does not implement it (the feature check reports a version below PM_API_VERSION_3) the step is skipped and a warning such as "Firmware doesn't support unregister all notifiers at once" is logged, e.g. on Versal NET firmware that predates this API. Signed-off-by: Jay Buddhabhatti Reviewed-by: Radhey Shyam Pandey Reviewed-by: Prasanna Kumar T S M --- drivers/firmware/xilinx/zynqmp.c | 13 +++++++++++++ include/linux/firmware/xlnx-zynqmp.h | 3 +++ 2 files changed, 16 insertions(+) diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zyn= qmp.c index 0deb278b2c2d..4e57c0ab9fe1 100644 --- a/drivers/firmware/xilinx/zynqmp.c +++ b/drivers/firmware/xilinx/zynqmp.c @@ -2107,6 +2107,19 @@ static int zynqmp_clear_pm_state(struct device *dev) } else { dev_warn(dev, "Bulk device release is not supported by firmware: %d\n", ret); + } + + /* Check if the firmware supports the PM_ALL_NOTIFIERS node ID */ + ret =3D do_feature_check_call(PM_REGISTER_NOTIFIER); + if ((ret & FIRMWARE_VERSION_MASK) >=3D PM_API_VERSION_3) { + /* Attempt to unregister all notifier callbacks via firmware */ + ret =3D zynqmp_pm_register_notifier(PM_ALL_NOTIFIERS, 0, 0, 0); + if (ret) + dev_err(dev, "Failed to unregister all notifiers: %d\n", ret); + } else { + dev_warn(dev, + "Firmware doesn't support unregister all notifiers at once: %d\n", + ret); ret =3D 0; } } diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/= xlnx-zynqmp.h index ac39e5492961..69a2f74269f3 100644 --- a/include/linux/firmware/xlnx-zynqmp.h +++ b/include/linux/firmware/xlnx-zynqmp.h @@ -149,6 +149,9 @@ /* Node ID for all peripheral devices */ #define PM_DEV_ALL_PERIPH 0x18224FFFU =20 +/* Node ID for all notifier callbacks */ +#define PM_ALL_NOTIFIERS 0xFFFFFFFFU + enum pm_module_id { PM_MODULE_ID =3D 0x0, XPM_MODULE_ID =3D 0x2, --=20 2.34.1