From nobody Fri Jul 24 21:52:36 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 59D7D392C21 for ; Fri, 24 Jul 2026 09:27:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784885248; cv=none; b=mgeDqksU9wmvaLQS7CQmFMTHnjW12FAOZmUdy1zs/1R/1tKI62JfyqJWXQTAB3Sh4koF3q5w07lr/m+yJ/0FQ56cOvEcdNFcdaTniib5QVvGwv3zZJkQ4F+9p3SvbDiUvDUacW0pO39CKOrL6VUG2blxh46tTHJXKxi5jSWKUhw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784885248; c=relaxed/simple; bh=W2y3OKKybbfme2GlTqFuhl4zoQk6lE1zUl4CB9zdkhk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iSecn0RvFW3hyW+KJVSpj49k6Dub0tOlAODh7XOH5W7EkraiQOHCYk/tZvGIS9ESK6KPDUzE6ZZykmONiB2Zw561P2llx6gReYCE2Cwl8fuokKx/cVgC0v6ktOk6tadr1NyCMJv3vMMGFTyr2rdIeECA5VHTXsGZqLsVvtvYibY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=IYJ424va; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="IYJ424va" Received: from linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net (linux.microsoft.com [13.77.154.182]) by linux.microsoft.com (Postfix) with ESMTPSA id 012AF20B7167; Fri, 24 Jul 2026 02:27:13 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 012AF20B7167 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1784885233; bh=USrhihm1p4CZBiEFsQcPZpSuXluHvD4ukOs2O3ezgIk=; h=From:To:Cc:Subject:Date:From; b=IYJ424vap/mtjWg4et7nrGHQFCasIKA4sQG9yfb6rZGWu0dRYVCTbClx9mNJ5wnZ/ vjFY8pqNBu/Xxfb/r6iXu5gCdssTTj1ILl1siGq1BgohmHRXhn+BtuCCo2l7OZJ1+5 +NgODCHDHhQpT4gZ446QDemQcExbEtIZeSDBEgUA= From: Prasanna Kumar T S M To: nipun.gupta@amd.com, nikhil.agarwal@amd.com, gregkh@linuxfoundation.org, puneet.gupta@amd.com, abhijit.gangurde@amd.com, linux-kernel@vger.kernel.org, ptsm@linux.microsoft.com Cc: ssengar@linux.microsoft.com Subject: [PATCH v2] cdx: Fix double free when sysfs file creation fails Date: Fri, 24 Jul 2026 02:27:12 -0700 Message-ID: <20260724092712.2119149-1-ptsm@linux.microsoft.com> X-Mailer: git-send-email 2.43.7 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In cdx_create_res_attr(), if sysfs_create_bin_file() fails, the code frees res_attr but doesn't set cdx_dev->res_attr[num] to NULL. This leaves a dangling pointer in the array. Then cdx_destroy_res_attr() frees the already-freed memory. Fix the double free by initializing cdx_dev->res_attr[num] after sysfs_create_bin_file() completes. Fixes: aeda33ab8160 ("cdx: create sysfs bin files for cdx resources") Cc: stable@vger.kernel.org Signed-off-by: Prasanna Kumar T S M --- drivers/cdx/cdx.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/cdx/cdx.c b/drivers/cdx/cdx.c index d3d230247262..a118a89a7779 100644 --- a/drivers/cdx/cdx.c +++ b/drivers/cdx/cdx.c @@ -738,7 +738,6 @@ static int cdx_create_res_attr(struct cdx_device *cdx_d= ev, int num) =20 sysfs_bin_attr_init(res_attr); =20 - cdx_dev->res_attr[num] =3D res_attr; sprintf(res_attr_name, "resource%d", num); =20 res_attr->mmap =3D cdx_mmap_resource; @@ -747,8 +746,12 @@ static int cdx_create_res_attr(struct cdx_device *cdx_= dev, int num) res_attr->size =3D cdx_resource_len(cdx_dev, num); res_attr->private =3D (void *)(unsigned long)num; ret =3D sysfs_create_bin_file(&cdx_dev->dev.kobj, res_attr); - if (ret) + if (ret) { kfree(res_attr); + return ret; + } + + cdx_dev->res_attr[num] =3D res_attr; =20 return ret; } --=20 2.49.0