From nobody Fri Jul 24 21:52:57 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3312A390600 for ; Fri, 24 Jul 2026 06:42:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784875348; cv=none; b=XR6laZ2STiOeNYn4tQdQezOun8xqF0tKstD8iOQQpB6cDDUX36FWUJgE/p21HbrX51MjOjjGr1nAT3FrV2JHyt5J3eZrpIVq+VGEqQMfXuIcwzqR1ks5UxSrv7zZNsXXWYHre9Dxmuz5sOhVPrb5XJMuesLnppd7GsGZ/o5+L44= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784875348; c=relaxed/simple; bh=UYfnAVkJYqrCgRSzVomRRD9UqZf21Lsk6dNux6uNhHE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=flYInVPZ7hBLbw7v+AyB254jF4vLWxcFixlQWL6vfsYD7JJ5P+UcvUBuiK44OuE+og43+0jdjb6x1VHYraLJTtiHwJ68+8xHgP5tS3abJfL2ABywtD9ixaW0OWr14UnRAKZfd8Z5O0WOA0uylznWO7vKK2VSTFxeFS441u1EZSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GGESawy5; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GGESawy5" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-cbb662575d3so71409a12.0 for ; Thu, 23 Jul 2026 23:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784875346; x=1785480146; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=3jI/otvSm+1a57vqHZ9bhuvtuCSbIaM8PvVKGIua6t8=; b=GGESawy5hAJ+3Xcl6UzYqF2Z52pmqvAQe6obk7kR9j7TDLwBqT4Q2BzyqfxoBG8nVS uvP5SM5SRzuPlf1RvT8UJC8poJisgbu8qTqYPIxgQGXq0Vjs+rDrw+bVVFIAActZcUcP WB/rS4BhtZmQ+Av21i62/4QZ2ZHLdJ76yV9/HQFVl43BbJ0irRQjkP9/M643Dxcv0Mhc PexzvqjSr7LxBvap91qpNw48z8MMhaER8cbjmOAymS5RVdFXhXwERVekWAVzANQgFR8B LcNUDMqMW98PJKvKXK0s6eOopqmTMGJmm7LFqX57pG8208Ko9tCmTmhJ7180qJRCBIdC sRew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784875346; x=1785480146; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3jI/otvSm+1a57vqHZ9bhuvtuCSbIaM8PvVKGIua6t8=; b=iyB1UoZ0kesd7yx29MBP61S7nbWlTBpJMhHS7eQn+yxBPipqn8SVmBp71eM/DeZJIS 8jVq0+vWXnISGviYROCTKNIH3WKva739OqFww8Zc3qGk88Y0Qtuz43VS/G6zRY9mp50p bubZyYFfjE2dJfc9XojUmYMry14YduFzC5SXYmL8oZpzXQaMQ8g6eU2HSZXyIDwzgIc7 O0eqDSKyR++rx4foSU8HbUmyf1QzySTxmIYpHy1+MegKLGXel+NB80Rc3CZNnNs8rKBJ roIC8XfU17TGArWFJdjJ8/VzH3yfOlMJnwqqQ60x6Wb4z9P/Ti15va7Aum7NWcXtM//z Sa9Q== X-Forwarded-Encrypted: i=1; AHgh+RrkxbkkPMRRhRpGowHrwmwS06oihPmckUGQ8Z3S+fTx+hF0ptpzo28vAP0UXgHI5XvvTL9uNfA93gmpsr0=@vger.kernel.org X-Gm-Message-State: AOJu0YzmJna7crA2xptwhh+MIa1i2nO8IdqJ2OyQ4lM1Wz2lik91trGU gd8117s52YQkQo9s6RdJmEnN6k4Qelgi9NfhT0BUIV3PQpq0WyC5vc2s X-Gm-Gg: AR+sD10Kv25aDjscxSN8+v3kVqnASA5R1I1QuAovUPPT7nQM3ejFO3eqXvFbGiJzzS0 JMDgAJFDzcW3fOQIiI60faV9BvPP6W+dDAALWjgGa7W7bw3F1O34BdO2jJWK6QmHMb/SRRQKECh SV/lao+muCs3+a07ElE9K68mqQ7IlfLxKKHxIIj+B29Zei4xQ4FHEDmOlf0rYYFnVCVBybCy56D +8EC7CI6Gj8r/Zs5pWZA41/VjxwDkGctfG9JZ4BB+e+w6sFmB0Q5ME2Whu4FqfEM0HYA5UckM7S 8jID4Ymfkl3Lre5z8wxVBQBRRYExFH31IB4zRMazeh0YDs9uhZ0Xcn1Nae6clIDLYjAyIldQRPO nw75YHuuZZNw+neiatp4cJBypSPHbKns9BMhGM15efnBL0C9EbrsR0As5R25uvrrloNpn3//AsX IoDt5FKxF+2dI2wg== X-Received: by 2002:a05:6a20:a126:b0:3c2:dcdd:a85a with SMTP id adf61e73a8af0-3c44afcd25emr7057739637.13.1784875346272; Thu, 23 Jul 2026 23:42:26 -0700 (PDT) Received: from lenovo-thinkbook.lan ([1.22.231.74]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147e081985sm27783326eec.23.2026.07.23.23.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 23:42:25 -0700 (PDT) From: Raushan Patel To: Masami Hiramatsu , Steven Rostedt Cc: Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Raushan Patel , stable@vger.kernel.org Subject: [PATCH] tracing/fprobe: Roll back on enable_trace_fprobe() failure Date: Fri, 24 Jul 2026 12:12:08 +0530 Message-ID: <20260724064208.480030-1-raushan.jhon@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" enable_trace_fprobe() sets the file link or the TP_FLAG_PROFILE flag and then registers each trace_fprobe in the probe list. If __register_trace_fprobe() fails partway through, the function returns immediately without unregistering the trace_fprobes it already registered or undoing the file link / flag it set, leaving the event half-enabled and leaking the registered fprobe(s). enable_trace_kprobe() already handles this with a rollback path. Do the same for fprobe: on failure, unregister all probes and clear the file link or profile flag. Fixes: 334e5519c375 ("tracing/probes: Add fprobe events for tracing functio= n entry and exit.") Cc: stable@vger.kernel.org Signed-off-by: Raushan Patel --- kernel/trace/trace_fprobe.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace_fprobe.c b/kernel/trace/trace_fprobe.c index 9f5f08c0e7c2..3120403a5b60 100644 --- a/kernel/trace/trace_fprobe.c +++ b/kernel/trace/trace_fprobe.c @@ -1481,11 +1481,21 @@ static int enable_trace_fprobe(struct trace_event_c= all *call, list_for_each_entry(tf, trace_probe_probe_list(tp), tp.list) { ret =3D __register_trace_fprobe(tf); if (ret < 0) - return ret; + goto err; } } =20 return 0; + +err: + /* Failed to enable one of them. Roll back all */ + list_for_each_entry(tf, trace_probe_probe_list(tp), tp.list) + __unregister_trace_fprobe(tf); + if (file) + trace_probe_remove_file(tp, file); + else + trace_probe_clear_flag(tp, TP_FLAG_PROFILE); + return ret; } =20 /* --=20 2.53.0