From nobody Fri Jul 24 22:17:37 2026 Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0F843515DE for ; Fri, 24 Jul 2026 05:12:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784869966; cv=none; b=OEBP/wX2QPwDFNHUBpznbmYAmT9bj+n275NFIwH2LuOZDmmCOwI3hrpPYbXyofJ1D4k4DaKbZQnl5vUvTJBWxlkLWc8erGcRPPnTygrWDKvByz2UAaQVMFMhQBlJId+Q7y4J39YOw/+2IMxXvwikI6cyzrmvgYf5CBurnmzD8VY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784869966; c=relaxed/simple; bh=BXw66hXGuImIJwHVpe0J6OOzDDbA3l/0X6t5liDFZG4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WB07ugyeN4ClgdVQ0oQ/2yx5yd5qD0j38ZItj6HQkTvUHY6U0TsCivB3Q0uEJUTAQ1U9Pv+7eJPn13M9LOSMedo17AVKP32euoAsyGb9FxK3yx6mWbbAGXkkOG4nBdKqHptrvd3XmphsPZomFmqKU25ZPO28KXb/nJ2FpRt6+N0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=corvaglia.dev; spf=pass smtp.mailfrom=corvaglia.dev; dkim=pass (2048-bit key) header.d=corvaglia.dev header.i=@corvaglia.dev header.b=JBFy6txe; arc=none smtp.client-ip=209.85.161.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=corvaglia.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=corvaglia.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=corvaglia.dev header.i=@corvaglia.dev header.b="JBFy6txe" Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-6aae11ddd13so490544eaf.3 for ; Thu, 23 Jul 2026 22:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corvaglia.dev; s=google; t=1784869964; x=1785474764; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=rN9GaeCC8AYVH1+QdHf7ZR+ma81Q9VJG0dObH93Dktw=; b=JBFy6txeLtva6/4v1Eo92uMKZwYQX+BWD/jqIcDSffJi2hAjp7dsqfKRwB8f5BLeuh li0N0PPbeNt2Thev4Xx2BMXsD1AW0kb2EgtHE7e3SQ+fuBw/xN3DdEYXf8hXkRFt/OKi cbRTAXE+2R/nOaLvM25caHX6wNB0J8THV69dRQKmumUTZlMJXDRfLnThBQ8zUwSXJBxW 4U0y7AlsF3e/o+L0EfHSAzsLZMCafk2ibQ9jtD1UutMdNbZ33LRSztHKQp3NsFphyOT2 Z3p8jDp0PFy2iNGyuzJY1HsZuvFouHDQunDHeFfIQ3/BwGBO1FQ36VlGxY+iT5pe8nG8 ih+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784869964; x=1785474764; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rN9GaeCC8AYVH1+QdHf7ZR+ma81Q9VJG0dObH93Dktw=; b=ZgmbYSNRZ1tgwvyljRnSG02waGM5dkWBaUJuGOXaypLIlM68t5fkEdE3C2zGv+KLdu J0rnXG2pqvJuRIzS00uDPZzRVukBS47G9oBHcdi+hPQEVTPg5nM1jYUofFZVx0PznnQs GJUwx3to6L2T/Mc2CKNsRu0jkkehsYl4a/nvYdWVP0rXtr3+sQuncaQXR2Iueqzd8qR7 /hzHL/vTjw6OhSfMxhWXUFscmPLOrGjcXSh/XUVyiyTZIvglWKMqHRfJAQfJ7ivF8A8u 1OQRIT2/6WcdOHHPac8Fk9XCxDwOcHnc2DQw70yUpnj66TsG1kVWFxEjOisv897fUwLj fnlw== X-Forwarded-Encrypted: i=1; AHgh+RqAAGgTm4u96MwtmUiLevytcu2cWvx7eUKCV8DwXtWuKd84sCa5sNVpXgwN+dZAdHtHIc6zhZgU4VxRHbI=@vger.kernel.org X-Gm-Message-State: AOJu0YzpDMzVRC2c+Qlhgi/3kHCgyq7sXtR9WGIhksc4Rr7gyCJY1c+D hi6LNM82KDCylt0vQ8eFI9DwpA6NaelUv7PdXskt/Z62AJbzh+w8nIxYVnIYcq2YqpXK X-Gm-Gg: AR+sD13kWyW22c5TZM1KwTTYHvA9WguI7F9jVkXiQC6JWkq1winc9OL4yOffrDjwBqG q/YKslW8sOnFNvJsIkEWr6oyRYlF5vSOJQh/J+a1SFqZAh678vvk4H0ICDGifMoGdb0/F0+5JTx k+qJkfqeQPUPg6+aGOZibmKzXAsSA0btD3HkWc3KKMeAaEMBEwbanN9eXg1oKm1QRc/if5w3BXF Y47zcNf69hhnoDbhiIaa1ca25K3XNc9CvqnPMJed+kmMq1ONWNc4dv21LBwGD6dDLeAH+g0E8xt sQNYc69u3B7nBr/fN5KEd7Y1YgkUIZ7iGA4Av1frUMLXFpzy/NW3zyapysyMom2ovJzQfsz0Rd1 1QGEXK4ES6UkpBzcDFL5Jn9SvSbAgMpZ7q8WOPkTYdTtinwhkhr0q65FCn9Rq3Gw5 X-Received: by 2002:a05:6820:2d0c:b0:6a3:7f14:7d05 with SMTP id 006d021491bc7-6aad3fa6f31mr2879504eaf.11.1784869964113; Thu, 23 Jul 2026 22:12:44 -0700 (PDT) Received: from dev ([47.160.132.81]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6aa76c19081sm4924823eaf.6.2026.07.23.22.12.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 22:12:42 -0700 (PDT) From: David Corvaglia To: Nikolay Aleksandrov , Ido Schimmel , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , bridge@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Corvaglia Subject: [PATCH net-next] bridge: mrp: fix MRP_Test option TLV length Date: Fri, 24 Jul 2026 05:12:02 +0000 Message-ID: <20260724051202.61946-1-david@corvaglia.dev> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" oui is a pointer, so sizeof(oui) is the pointer size. The MRA Option TLV thus advertises a wrong length (15 vs 10 on x86_64), causing misparsing of the frame on peers. Fix is to replace with sizeof(*oui). Signed-off-by: David Corvaglia --- net/bridge/br_mrp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_mrp.c b/net/bridge/br_mrp.c index 3f7126a7d720..179d2470b724 100644 --- a/net/bridge/br_mrp.c +++ b/net/bridge/br_mrp.c @@ -215,7 +215,7 @@ static struct sk_buff *br_mrp_alloc_test_skb(struct br_= mrp *mrp, struct br_mrp_oui_hdr *oui =3D NULL; u8 length; =20 - length =3D sizeof(*sub_opt) + sizeof(*sub_tlv) + sizeof(oui) + + length =3D sizeof(*sub_opt) + sizeof(*sub_tlv) + sizeof(*oui) + MRP_OPT_PADDING; br_mrp_skb_tlv(skb, BR_MRP_TLV_HEADER_OPTION, length); =20 --=20 2.55.0