From nobody Fri Jul 24 22:17:35 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03B891EB19B for ; Fri, 24 Jul 2026 04:42:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784868140; cv=none; b=Ij1m97oj8FUxTMNmZTHJ+FRCzEKjcqKVjF506j/CAvOoEAdh1NOeIYeLBLp69bMK96thbaaUQdg9VXHM4jYAxd2p+F5BltWs0otrZ3lMozNOpV00cOj0zhcYMKWGb2N+fcz8A7ZMY8IdQcghzLCEK8/fM8V+1QW0ueS4K9v5zXc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784868140; c=relaxed/simple; bh=Hb44MR4gsD5UFuVSEDySniYWJIp6Vkb5givXLRM2dcc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jukd+PwzKzjf3BUYLuluX+El+MxLutOo1NtSsrD75k5Shav/P3zbUZFlD0Vh8q1aIh312JEnhwOR6hbaNWRpPaUBctd9PHOKoUTSC7SkEW3LP6IPftGVc8q0mFWfjRfMwUjGBp9mFdJWd1UzH1eyO2StLtC8ywNhShoJPrkmJ9k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qeg1GYBI; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qeg1GYBI" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2cae1a3a744so252715ad.3 for ; Thu, 23 Jul 2026 21:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784868138; x=1785472938; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=3lGmAGFwKbmg0sIcc+yz1JrF4MXL+t8WFtTnxStidCE=; b=qeg1GYBItoEIKJKO+OOe1mjiwg+CkgIHvRmI39UPDqibNW4tKoj8Xg/daK5Qq0TDl5 mezrsWSQZ7+ljX7Ce8Dc3ar71WXSSKkGQc2ByUbHWmSdmUbEBe/Dm5R2JPKzAeX7MA12 5yBOiKNDyXG8dg+tPZEZw9S9+Z71Hg/2MhGcxHKG75vw0Z27gpWTwaCD7faDcFMSy2uu LeDScPqdsYFXqyKYD5Aev2vVtcvtr3Sus2XbiiXp/hNd+SGkDCjRQnitH9Zv2w3S0m00 ogDzcg8k1MUNPfby/SFYZ428jqb6UvrfKY6+14AiHoiZzvuSeNXNcbhEBrrsskTr+TL9 Bwkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784868138; x=1785472938; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3lGmAGFwKbmg0sIcc+yz1JrF4MXL+t8WFtTnxStidCE=; b=Ythy2tY1L6MT/T06+0dAPuAfiwAZ3swtDM3C2esQHS8YZcEH63bsfMMt0y0YvfDvj+ vl8w0YUGt3M4WqRpkc0hZMsWBbRRBP5KEBazmfp7sQD+j3MzFZdMxmWyTcQUXZ/Rt6tG Wg1MkqaniWj/Td0vwevQ1PIQBU8Lu8Hk2MGHSITc08gUVbYLOB7jLgqe3LWmCPHHsI8P OB3A9o+YQTvZfLo6S4Nb4p7jMGpx5k+n8yGOEPIE3Qcd+4sT16D0Joed12DBLKAgAVWr MGYoE6v5WCORsx9J/dExdaN8gQUtE2cW9aD0sa0HVQ/3vq8kXI7sed9SqO6ryEPi4Vph h/Jw== X-Forwarded-Encrypted: i=1; AHgh+Roq3qRgD/1ui57B3ALU+6GweSXhJYDK7GncCr1nx428cyIcqm2Itun/idtUx7LLgf9GJ/1GVB4o3na2uPA=@vger.kernel.org X-Gm-Message-State: AOJu0YzmeH74b9EfITG6xk96KAgAx3kUno1c5gxdJmYWGylEQDBFzgzm gEuRycxLrWPzbRjUKMrvGthpf+eWnT3I35hAMFLgX/87K4pR6Zb4tu04tucEA14= X-Gm-Gg: AR+sD12C+guC7i1+CTpXolRO+w6y2WQsFgPzOD+DARTRRkLpcPRdLVCEB1VCfdwj2Uf tRCPkur30LEip+c/+stehXk/bVCIloVYl+ffkohqXa4/aOxj9iwbrH7tOy73KFYPnaew4vUU3uR WDhS7Y28+jrL5I/YHoqZf9OU/VERNuMFKVrqr+4RmluXxTPsEVFGNwG+jUXVtqg5MGlUT19QVci qGF+EKJf3MGfpMevYz5jUzl2wlOTjaXBrGMaAJhKtp9FnCpeDkBqMDDtMMoR6ko4DyD76+P0EOS VTPv8J+Vgfi1wKvXyql3psHm7Ops8IoM5z1oqIkX5sWQyVR9TdaH08InI5R0CPVHhQuYPFVnvgj QG0lj38BhvTasWLq1PAgIpKa4D8BEDjXTgR3KeCyDOJcHIZMfGWXmXK51yUNMlaI16Odu+czEeL u1FhFXe2/JbhHn3QMAh+ZG9NIqOZU= X-Received: by 2002:a05:6a21:138f:b0:3c4:3112:33 with SMTP id adf61e73a8af0-3c44afa2428mr7021478637.6.1784868138090; Thu, 23 Jul 2026 21:42:18 -0700 (PDT) Received: from t-rex ([2401:4900:7b3a:ad08:5f07:2836:b3b8:b712]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3149a62cf50sm11851161eec.5.2026.07.23.21.42.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 21:42:17 -0700 (PDT) From: kr494167@gmail.com To: p.zabel@pengutronix.de Cc: gary.yang@cixtech.com, linux-kernel@vger.kernel.org, Surendra Singh Chouhan Subject: [PATCH] reset: sky1: propagate regmap errors and validate signals Date: Fri, 24 Jul 2026 10:12:10 +0530 Message-ID: <20260724044210.31592-1-kr494167@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Surendra Singh Chouhan sky1_reset_assert(), sky1_reset_deassert(), sky1_reset(), and sky1_reset_status() ignored the return values of sky1_reset_set() and regmap_read(). If regmap operations failed (e.g. due to bus I/O errors), error codes were swallowed and functions returned success (0) or incorrect status (1). In addition, sky1_src_signals is a sparse array containing unmapped entries (offset =3D=3D 0 && bit =3D=3D 0). Out-of-bounds id lookups or references to unmapped entries were not validated before performing regmap operations. Fix these by capturing and propagating regmap read/write errors across all ops, and adding bounds and unmapped signal validation in sky1_reset_set() and sky1_reset_status(). Fixes: 7cd3ca90d921 ("reset: add Sky1 soc reset support") Signed-off-by: Surendra Singh Chouhan --- drivers/reset/reset-sky1.c | 54 +++++++++++++++++++++++++++++++------- 1 file changed, 44 insertions(+), 10 deletions(-) diff --git a/drivers/reset/reset-sky1.c b/drivers/reset/reset-sky1.c index 78e80a533c39..885eb9563ef8 100644 --- a/drivers/reset/reset-sky1.c +++ b/drivers/reset/reset-sky1.c @@ -267,8 +267,17 @@ static int sky1_reset_set(struct reset_controller_dev = *rcdev, unsigned long id, bool assert) { struct sky1_src *sky1src =3D to_sky1_src(rcdev); - const struct sky1_src_signal *signal =3D &sky1src->signals[id]; - unsigned int value =3D assert ? 0 : signal->bit; + const struct sky1_src_signal *signal; + unsigned int value; + + if (id >=3D sky1src->rcdev.nr_resets) + return -EINVAL; + + signal =3D &sky1src->signals[id]; + if (!signal->offset && !signal->bit) + return -EINVAL; + + value =3D assert ? 0 : signal->bit; =20 return regmap_update_bits(sky1src->regmap, signal->offset, signal->bit, value); @@ -277,7 +286,12 @@ static int sky1_reset_set(struct reset_controller_dev = *rcdev, static int sky1_reset_assert(struct reset_controller_dev *rcdev, unsigned long id) { - sky1_reset_set(rcdev, id, true); + int ret; + + ret =3D sky1_reset_set(rcdev, id, true); + if (ret) + return ret; + usleep_range(SKY1_RESET_SLEEP_MIN_US, SKY1_RESET_SLEEP_MAX_US); return 0; @@ -286,7 +300,12 @@ static int sky1_reset_assert(struct reset_controller_d= ev *rcdev, static int sky1_reset_deassert(struct reset_controller_dev *rcdev, unsigned long id) { - sky1_reset_set(rcdev, id, false); + int ret; + + ret =3D sky1_reset_set(rcdev, id, false); + if (ret) + return ret; + usleep_range(SKY1_RESET_SLEEP_MIN_US, SKY1_RESET_SLEEP_MAX_US); return 0; @@ -295,19 +314,34 @@ static int sky1_reset_deassert(struct reset_controlle= r_dev *rcdev, static int sky1_reset(struct reset_controller_dev *rcdev, unsigned long id) { - sky1_reset_assert(rcdev, id); - sky1_reset_deassert(rcdev, id); - return 0; + int ret; + + ret =3D sky1_reset_assert(rcdev, id); + if (ret) + return ret; + + return sky1_reset_deassert(rcdev, id); } =20 static int sky1_reset_status(struct reset_controller_dev *rcdev, unsigned long id) { - unsigned int value =3D 0; struct sky1_src *sky1src =3D to_sky1_src(rcdev); - const struct sky1_src_signal *signal =3D &sky1src->signals[id]; + const struct sky1_src_signal *signal; + unsigned int value =3D 0; + int ret; + + if (id >=3D sky1src->rcdev.nr_resets) + return -EINVAL; + + signal =3D &sky1src->signals[id]; + if (!signal->offset && !signal->bit) + return -EINVAL; + + ret =3D regmap_read(sky1src->regmap, signal->offset, &value); + if (ret) + return ret; =20 - regmap_read(sky1src->regmap, signal->offset, &value); return !(value & signal->bit); } =20 --=20 2.55.0