From nobody Fri Jul 24 04:48:25 2026 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0F334908B6 for ; Fri, 24 Jul 2026 02:46:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784861196; cv=none; b=OQUdU8O8G0vgFPDS5z6rW22MM3SSbroxd6Cm2gBYBL9B0bTM5+FQwfqtbpjfhSw5YmFPYrW6giDn5IKs/hH7C+deKMa2iQXYv2u5Hk3drnIdeaBrGiRlLSV8fYdk5r6Ely1Rc9Cq4WD+7o6fdUe4qBEbL1YF/uCLNXGBdhCdPvw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784861196; c=relaxed/simple; bh=KILsT4dW4cQighKmRhE5lZqxzpweKpGL9LY4pXjFwB4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lx7xErDbCrSZYsiw/XWvJP0ziA8nR5v9jhauGA31m+6Iv9ZiLOZdftuxutPidlYWIvMUWz1o4MxqjDlRTZRXV/P0BL4xu9DDT0nNyLj/eyEiDskv8lwV4NJFOrZI0XLcRFwd4J9uRtoR1B554IhXFPZBY/X0Z7d4LHELyFZDT4o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kw8xZTgn; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kw8xZTgn" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c999f162c9aso1008025a12.3 for ; Thu, 23 Jul 2026 19:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784861194; x=1785465994; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=CJ/78BuNgsIwulpmGGAeh881xKstF26eW27V+S76HzY=; b=Kw8xZTgn9ZJ0iykxHCXejAumU631hLV6veXpoKD4+3IZUftKjy56GDrGHrENpJhMnm 5la1d7LZmGEuHb8+bPBuJHpuaSpTHx29c/y0A8WiBOGKtQ/4UEorYWS0XL4vDHoigFa8 JCZUMdu5BRHA10GNbNjjY8mdEz3VlxLDA6QWIHTquUmxKfmu2E6OnE2f5tCixdKhc0jC oymsdxb0Ohk05Nfmnpv2PZw2fGtwpUsH6jlAygvocfgGUBZbOYI/7IXe+EZmpYrj8r/P rTMNT/cd1XuB0iK8Q3TWEZmLCW30+8GLRxOLa5mAklFD958RwyTT3TisXIiF4lvu1VOU jZUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784861194; x=1785465994; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CJ/78BuNgsIwulpmGGAeh881xKstF26eW27V+S76HzY=; b=lvu1Ds7zPcEuSgt+buL76cYyNGUyTk6fYacza2pM3BzssteRGGdGbcjXKVxBQUv8en ARXtYpjVSuuCD7lRoxfpxZFKZTTbQp7Ja/lvELBvx9fulsugTgDaZ8oIijf26iipu8/m dqHkJZYcwTYtsk+Qfizo81jLVHKXWC1WmISOuf1I3THQxIsbxfkJ1FA5GAWSRaQcU1Rv RuaCgcgEU4NKk+XwwvdWZqp3kPp92FyP+ipdBcwNPi2t9bnfQeecsGAFBoUTrchr4MmJ UBxGfWY4HRn/gjll+iQ3R78uTjxzT0NpxssWQCq0e8InxEAaitmGS1FgrFiHsGxXS2Wm I4Iw== X-Forwarded-Encrypted: i=1; AHgh+RpeEa8NUeaUWVfIEaoOL1hvOLphrKBnBWZHxvOZIphJ2LkciU6KH/lyUU8f0/scnX5Z0aN89Ny4dc5urmc=@vger.kernel.org X-Gm-Message-State: AOJu0YxNhpXfVoVLwXouXfbv5yPCDLur0m68VJIffiY4o1w4Qs2+BFG5 MI+nMHvzsyLs8NDzIvdMJkMiZo9WBB7+dyLepRDHSEOgwDOmBngKWoo= X-Gm-Gg: AR+sD10uz57yraQhQEH9qJWZRLslnD7P76mUzb/QJHzwHfjROHk339D5DJGcbJI59Qm P7EKI3B/aKslBwFyPtQJ6CyWoMRYBGmWYEXVLs+jj5YzVgvlclx3rDvGXN+NbrVd5f0FAeBRs6U Y+hxdqznIUGAchjgWSSGVBJ/Eip8sAkw6z/HYSFa+VLc4bBNFZ1DY0p8CoeEk0HzGeP7lU56R72 TCqCCF5D9zNt5rZZEsJDI/n5UEpO973qFQNnVUHhy6dFD1D5d4bl3exKYCQHDElhd+vhAe9UvEL a1kLJMT8dhHxIIs3/M0wRcDAEVSg6Q8a5owEvgcTjTZFCWZ9UKC3o3BlxtQwqWJvdhZ1iduZrYO SfN0CsU3DhC2acR67EfrQjX+wuCFfPDEt9pzh68ZbBxhHj1TgIejy4e3VlZg5AYB6tAKTB5qIRV IrQ6qN+FcAJf3fWslzr2ZgYDQzLYs= X-Received: by 2002:a05:6a21:504:b0:3a0:bc61:62e6 with SMTP id adf61e73a8af0-3c44afa0fd6mr6739754637.8.1784861194094; Thu, 23 Jul 2026 19:46:34 -0700 (PDT) Received: from t-rex ([2401:4900:7b1c:a30e:8622:dbfc:dd30:d90d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147e081978sm22562515eec.24.2026.07.23.19.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 19:46:33 -0700 (PDT) From: kr494167@gmail.com To: broonie@kernel.org, lgirdwood@gmail.com Cc: neil.armstrong@linaro.org, kancy2333@outlook.com, linux-kernel@vger.kernel.org, Surendra Singh Chouhan Subject: [PATCH] regulator: sgm3804: handle gpiod_get_value_cansleep() error returns Date: Fri, 24 Jul 2026 08:16:25 +0530 Message-ID: <20260724024625.11057-1-kr494167@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Surendra Singh Chouhan sgm3804_sync_regcache_state() evaluated !gpiod_get_value_cansleep(...) to check if the enable GPIOs were down. gpiod_get_value_cansleep() returns 1 if active, 0 if inactive, and a negative error code (e.g. -EIO or -EINVAL) on failure. Evaluating !gpiod_get_value_cansleep(...) treats a negative error code as boolean false, swallowing GPIO read failures and misinterpreting a failed read as an active GPIO. This improperly attempts to sync regcache registers when the IC may be powered down. Fix this by capturing the return values of gpiod_get_value_cansleep() for both positive and negative rails and propagating any error immediately. In addition, replace mutex_init() with devm_mutex_init() in probe(). Fixes: 0c47e1a8cf5d ("regulator: add SGM3804 Dual Output driver") Signed-off-by: Surendra Singh Chouhan --- drivers/regulator/sgm3804-regulator.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/sgm3804-regulator.c b/drivers/regulator/sgm3= 804-regulator.c index c3406cfb73d0..a430c89b4d5d 100644 --- a/drivers/regulator/sgm3804-regulator.c +++ b/drivers/regulator/sgm3804-regulator.c @@ -97,11 +97,20 @@ static const struct regmap_config sgm3804_regmap_config= =3D { =20 static int sgm3804_sync_regcache_state(struct sgm3804_data *ctx) { + int pos, neg; + guard(mutex)(&ctx->lock); =20 + pos =3D gpiod_get_value_cansleep(ctx->gpios[SGM3804_POS_RAIL]); + if (pos < 0) + return pos; + + neg =3D gpiod_get_value_cansleep(ctx->gpios[SGM3804_NEG_RAIL]); + if (neg < 0) + return neg; + /* If both GPIOs are down, IC is powered down and I2C writes will fail */ - if (!gpiod_get_value_cansleep(ctx->gpios[SGM3804_POS_RAIL]) && - !gpiod_get_value_cansleep(ctx->gpios[SGM3804_NEG_RAIL])) { + if (!pos && !neg) { regcache_cache_only(ctx->regmap, true); regcache_mark_dirty(ctx->regmap); } else { @@ -235,7 +244,9 @@ static int sgm3804_probe(struct i2c_client *i2c) if (!ctx) return -ENOMEM; =20 - mutex_init(&ctx->lock); + ret =3D devm_mutex_init(dev, &ctx->lock); + if (ret) + return ret; =20 ctx->regmap =3D devm_regmap_init_i2c(i2c, &sgm3804_regmap_config); if (IS_ERR(ctx->regmap)) --=20 2.55.0