From nobody Fri Jul 24 04:48:25 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26F261DED49 for ; Fri, 24 Jul 2026 02:42:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860952; cv=none; b=MNmreywIZJ2mQW1pCLc9WGmiJ6h5HbKP6ghPmEi4PIldsB4DV275Pgk1tsU7Si/sJ/HF/6SdQ3nHFl1NDZyGnrHsRjLkOYFa/LLgVSID6XUCQA7EdtyJkdczIagV2WUfh+HFqlZiZJFkEXe3Pqt30qeD+xmtugWWG8lchX6id6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860952; c=relaxed/simple; bh=Kcyf6DRHa971EXj2kBZ35LGhRul4erajhh5T/3cAz7E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Z5idSCEswwPQ03YhQY9i6AkD8QQiILf2om3MjsL8Wl38sHne6baWRqHKP05tw2MeKEU8+uEPnfaVo1y4l22JmqO43SKBfMua4oOHZoX3LdEPLM22XFLHPsEi+uoJF4bREp3OYEMC+GPjv5Ta/lormBfXg3n10WD3WCfUWWdkhXk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kW4rnlco; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kW4rnlco" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2cee9b74ee1so10623135ad.3 for ; Thu, 23 Jul 2026 19:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784860950; x=1785465750; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=z4bvXbXayEnCzzJXqVJPK7lahyeIFGKn1fz42KqQtbg=; b=kW4rnlcoCvyHLcKcVSePDjQzwVRSaajovPfh7DjIUy05NodyhWmwQ0OIkULCH5Ff5z 7nw3LhbuEnVP0XuEHiMX6oddSmrd/j6aeHbzWxzBEd8rlB6zTo0KkFEDmAX2YsyVEi5K RLmvy1QY5HZ0esXZmvq50r2BcdmQPtRCKCid9ud2Z+8yHQVDNULN790D5x+3PsInyau3 Jw3/Vp3jhrnVhKDf4kiJmwcqK78lirSXmZ69Z+NgmGSev3/mwNuqUyxYBM0LUVJsIJSv E1UR5CNV0rhoKZySc7VdiAQuet4A9tz3jXisqvQEIKXWGIz3OKtgvjNE3tLH7/emEJcp wOhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784860950; x=1785465750; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=z4bvXbXayEnCzzJXqVJPK7lahyeIFGKn1fz42KqQtbg=; b=Lc5y0XiG+JFbydiV11f1vMmTpz1OFoYZuEY/CCdZsvmd5M8gxYaZkzP8s7MCjWzNZW pjnv1MC1mryw7tPyHEaz0AHqvHE8f2+P1tW07EoD4i8vi32eYJkB6nkRvKG3UD+iNNCQ F4GxJ3dGWoAPQuksKUqSYRrXHN4Q/i7heiboben4BaSnQUKem/zAAhgZFONmxg/5AzVU 6aOET73eqRYiX1Ww3Feb3Zg/AQo7ckT237jA00MI4i23LuMe4GLz7pQTVYNTVnIH2BOJ 4StOEx2CwJrXHNabIDHAsQpRjZsSuMXYLZ2+zG/LuzP7k6F5CtdKTizDDVoShOHsbLkq OfDA== X-Forwarded-Encrypted: i=1; AHgh+RqmOLJLdMbdpeQKBkjcWdq2YPEkUoGqe3fNy/nE8heXBShS+T4IyUfwRBs6ndo2psUBAKOoK3/Epa9Xdp0=@vger.kernel.org X-Gm-Message-State: AOJu0YzQp2iCt7gRy6UhpUh7FVFlw2uqOMSI6Fi7yum6d+Ty308BAX4A kz1nOZyKa213YR+lNN+iwJZzK0gr8i7JAbJFugTW4KKgwLrtPj/mpNg= X-Gm-Gg: AR+sD117kxfAnkqpFsAVxfUsmqQ/5tyi3aMIV++2zHCh6lTS0bIXmii/juZvDda1mlq FmQ0oLwyEBxspLom3iHied9+pWfQk+q3aWyUVxLe6thZtWuBfz9eZwtXBL95wITN76D3Al6O4Ho hTrSQwMmvGyY/lXJbcs9FBKzTQaiAnKfWSxFOCdpdNu7Vh7c3pYJEkwkMkZuAId4T4NUwq7smKK SUQ+AT6q1rL5f2NnhrcbkcnYLWgdePcUOn6BpqtruSyTgQos2OELTNUAd+tDvxNELUYGz45fr6q wu1oaXsTA21hc4gLslpOoX4tbhivMN2M1vcwdGpjmX3/w1mHr21T0EuMieaWrxajVKeOZGxbmqc 9fH+CkUgHxp+5MQGHXTo+JSBsVXUMcwXX3XJA20yNEZZi0YSKJwsYVVSfqDjJvWGd+2Dv57YMPI WhJfs2UC/vg/m+zs69HeMDkGH8NnQ= X-Received: by 2002:a17:903:2b0d:b0:2ca:f8ef:33e4 with SMTP id d9443c01a7336-2cfa71d9468mr61759585ad.17.1784860950411; Thu, 23 Jul 2026 19:42:30 -0700 (PDT) Received: from t-rex ([2401:4900:7b1c:a30e:8622:dbfc:dd30:d90d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147e1b6a45sm24761728eec.28.2026.07.23.19.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 19:42:29 -0700 (PDT) From: kr494167@gmail.com To: alexandre.belloni@bootlin.com, dlan@kernel.org Cc: elder@riscstar.com, linux-rtc@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Surendra Singh Chouhan Subject: [PATCH] rtc: spacemit: handle regmap_test_bits() error return Date: Fri, 24 Jul 2026 08:12:20 +0530 Message-ID: <20260724024220.10113-1-kr494167@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Surendra Singh Chouhan p1_rtc_read_time() called if (!regmap_test_bits(regmap, RTC_CTRL, RTC_EN)) to check if the RTC was enabled. regmap_test_bits() returns 1 if the bit is set, 0 if not set, and a negative error code (e.g. -EIO) if reading the control register fails. Using !regmap_test_bits(...) evaluates a negative error code as boolean false, causing I2C/regmap read failures to be ignored and incorrectly proceeding to read time registers from a failing device. Fix this by capturing the return value of regmap_test_bits() and returning the error code if negative, or -EINVAL if the RTC is disabled. Fixes: a6de182daa2b ("rtc: spacemit: support the SpacemiT P1 RTC") Signed-off-by: Surendra Singh Chouhan --- drivers/rtc/rtc-spacemit-p1.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-spacemit-p1.c b/drivers/rtc/rtc-spacemit-p1.c index 43ab62494bb4..c1820c920ba3 100644 --- a/drivers/rtc/rtc-spacemit-p1.c +++ b/drivers/rtc/rtc-spacemit-p1.c @@ -57,8 +57,9 @@ static int p1_rtc_read_time(struct device *dev, struct rt= c_time *t) u8 time[6]; int ret; =20 - if (!regmap_test_bits(regmap, RTC_CTRL, RTC_EN)) - return -EINVAL; /* RTC is disabled */ + ret =3D regmap_test_bits(regmap, RTC_CTRL, RTC_EN); + if (ret <=3D 0) + return ret ? ret : -EINVAL; /* RTC is disabled or error */ =20 ret =3D regmap_bulk_read(regmap, RTC_TIME, time, sizeof(time)); if (ret) --=20 2.55.0