From nobody Fri Jul 24 04:50:32 2026 Received: from smtpbguseast1.qq.com (smtpbguseast1.qq.com [54.204.34.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 416E52DFA2F; Fri, 24 Jul 2026 02:29:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.204.34.129 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860161; cv=none; b=jC6pesrqTpJtbO2GiwmwZS17FiVonuHEj+Mb7tnEkSSg9WQnLbtgsyH21j38XOaEXJKllQ6TFpIxHJxKQQv1wjIolmsqq2BC3+8TbqavficSSEN0PGvmO6m+gc64IDk77e4D8QIIt4jClPJbORZ50CrFWWyfUIw+52X8uv9OKNc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860161; c=relaxed/simple; bh=m96zxm1tlVq9oW7yYZBLEg7xTdMzMUccwEOKVWUnif8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jdW+1Pb0yzoQB/b22FGbMOl1fkZZxkxCADKefReO4Ybp1VDOvjzHHJVO3jQZxyuEFYX/2OKbdZL7eGxO3YQ4CqTpRqhZtAG9bkNN8vwA5SefTRyLPYOvRHaOwD5SpnHXkRSatig0hPISfFLghqZYbqfHtOWVF5Yi003gtujMrM8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com; spf=pass smtp.mailfrom=uniontech.com; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b=Thpc9fD+; arc=none smtp.client-ip=54.204.34.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uniontech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b="Thpc9fD+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1784860149; bh=XcvnlsC3HhT/It5VuOwr2y7sGHW1GiSiBgnaGk3guqk=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=Thpc9fD+snLZvia4IvIECJR4/9ngZ61H2O5O1Og1QqoADevADqPMz/Bq1/8BXRRWz JCrXR8+gXkama1LSqp+3/GKFYENpvhaX29P6kuiuDXji9ZyCg63LOcE/Yq33QZNkGR BEJyJj84Px6hBhmJtbdXUe181psxM+dEj5Zv63ag= X-QQ-mid: zesmtpip4t1784860141tf7457151 X-QQ-Originating-IP: mFrNixuyb/9G3t9a9hZZYveY0Gmd34ZMyBS60EAtLAY= Received: from localhost.localdomain ( [localhost]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 24 Jul 2026 10:28:58 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 9941543075585726979 EX-QQ-RecipientCnt: 26 From: Gou Hao To: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, bharat@chelsio.com, jgg@ziepe.ca, leon@kernel.org, akpm@linux-foundation.org, gouhao@uniontech.com, namcao@linutronix.de, ynorov@nvidia.com, sshegde@linux.ibm.com, nilay@linux.ibm.com, clg@kaod.org Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, gouhaojake@163.com, kernel@uniontech.com Subject: [PATCH v2 1/6] powerpc/xive: remove dead NULL check after GFP_NOFAIL allocation Date: Fri, 24 Jul 2026 10:28:46 +0800 Message-Id: <20260724022851.466017-2-gouhao@uniontech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20260724022851.466017-1-gouhao@uniontech.com> References: <20260724022851.466017-1-gouhao@uniontech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpip:uniontech.com:qybglogicsvrgz:qybglogicsvrgz5b-2 X-QQ-XMAILINFO: MKbitA53r7aLciQUIs5N5Tp6Sxgcv1w+S7zBqk7n99csOTvy406dgMTT sOkgZ/hApPmf3bKG96PkPQXXAxqBoFy032u3JELorA5el5VbXUFO48WAQSd7HLbFz0WY5au RJOyxbSi/6iIHkn2Xi+6yfQ6XD9GM1BVHqR7LsYps5FZSPhMPpOehOFlDn766uJo8N0N062 7RIKqwXW0GbV3ggW0syika0wVakN5jMKmg1en2o7zQg1J9C7iD2YGR0LQ7gZIwXlcV2/mMi TcfIeb0mIim9VBNK6vV4TEpYESu3cYTqfSddr1VpvFZnbjLz+nnJmflHgl394kpMeb1suYP jdeemvNIcTLVvsUJiIRJLo9kPfOkiYsc6itKN4eG1X6OScjRg+Z7aixxybDe/ACwO7f90fb 8uxBmydEvHaboLANp1H3ozrpT0CcQTWb3S0tbsltGquaE6rgtkfatvM4QK7u/6b4VsOQAaF L0lDweit4ID6Rcu09PWdl36HLVpP/HDgEIrHV9471gZQdU4Br10CoDK4kWV/v6vcixuM9s1 +jjVV+pZZQv7/vBSIExQT6Et2mX0uE0p6JjR9DxNZjf9bwo8s0WJK+81+xpGzqKX2u15Dd1 VWk2DsXsc4p7XJfbRYYuNhyA5lGoZijiCmmKDXx5nykLEzGnnyOA5R9YMiLV8h0GXpLwmJy +gR9SO0qnSTlhPEfyqFT5hdhiS2twGQ2QyQmzEU/dbEd0n+oxp/29w47XgkGTlHonnMnfXv 6cHoGb7wt3HrEOL+2d9IF13hFhh4blxEWutjyW5x4etjB6KM19S1fAMESkq6+cyT2frQd6R 3LvOXcmR5Zaq8kXvi/8wf89atufvJPDTTu48VLXNYJxAsKzQ4SOcv55zfPJHucsEn1dlnr3 7KO+I6yDPj6G1JWZSo1evCa0mq1hdDVyVXrs51k0NKz1NZiT1YXBblk97uhAKp60Igmj5NN fRQxcdy21Z02GDr83vZNnDfSN5n6YO3kjHX5/2f9cooFOCvOxKVXm68I14zwqPUfoaAINh4 abHRQH0HbIhtCijWfcdOJivysz4H/LuQ1/Y5sySLwXzSENUP5y+q7lbOgIexhy6UfoK3OVn Pqu3XwNpby90rSSIuxhVoY= X-QQ-XMRINFO: NS+P29fieYNwqS3WCnRCOn9D1NpZuCnCRA== X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" kzalloc_objs with the __GFP_NOFAIL flag will never return NULL, so the subsequent NULL check is unreachable dead code. Remove it. Signed-off-by: Gou Hao Reviewed-by: Wentao Guan Reviewed-by: jiazhenyuan --- arch/powerpc/sysdev/xive/common.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/c= ommon.c index dadd1f46ec939..f2904a5c2b7bf 100644 --- a/arch/powerpc/sysdev/xive/common.c +++ b/arch/powerpc/sysdev/xive/common.c @@ -1134,9 +1134,6 @@ static int __init xive_init_ipis(void) =20 xive_ipis =3D kzalloc_objs(*xive_ipis, nr_node_ids, GFP_KERNEL | __GFP_NOFAIL); - if (!xive_ipis) - goto out_free_domain; - for_each_node(node) { struct xive_ipi_desc *xid =3D &xive_ipis[node]; struct xive_ipi_alloc_info info =3D { node }; @@ -1158,7 +1155,7 @@ static int __init xive_init_ipis(void) =20 out_free_xive_ipis: kfree(xive_ipis); -out_free_domain: + xive_ipis =3D NULL; irq_domain_remove(ipi_domain); out_free_fwnode: irq_domain_free_fwnode(fwnode); --=20 2.20.1 From nobody Fri Jul 24 04:50:32 2026 Received: from smtpbgau2.qq.com (smtpbgau2.qq.com [54.206.34.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E96D731F991; Fri, 24 Jul 2026 02:29:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.206.34.216 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860166; cv=none; b=UXUI46dxuwp9d2LHZVpg1TGpDYWd0tQm6g1Pjm4an+QgY5FxxyFiQ4ITgfJVHhPqdUP59KvvplZful2411OmuMoWPkYUK+BNKYbuYwJojJZhHbzgMX8OKSC+FkEpr62lAKi6NXxvTNtERJ6+7q9RvWz+7+eVeXmEH4M/Tclt0fQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860166; c=relaxed/simple; bh=q1KitDd+5YTKSMZcayu9YP2JDF1w1PFBb+0293Mc3/Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UbIFdoNnEHep7K63Yq+VqKSweL1/gs7kRXPwIdVWuY+x017BPBmjJ5uSDJwXhw8RmDDJFLMtc2mlCyfuqpCH5tBXNxoMnyKm1lo94dJ0PSW61aXUh1KR+wMz/h/Q5t9ummBGVKtXgkb8w7FxurUwuPZKRxDtx2JxyFk5+PPe8LE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com; spf=pass smtp.mailfrom=uniontech.com; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b=ncs5xM37; arc=none smtp.client-ip=54.206.34.216 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uniontech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b="ncs5xM37" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1784860153; bh=HXOSjewrugfoFYAviBCdTNIHqggVZlJ3YZl/fwlFoCA=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=ncs5xM37vVjd0IjnaCGWOLRekG4+uPEyk4jfTeaoa26iiFpR/v9bXLSofrN2Dj0Yf /Ub2ptb4AR5B4ZSN+Ac5nenqlE612qp/SqTGNwAQUYlx+y2EkzZJGa1LPOh7qEQLHM HpxJ1/Y/SMCIXk+vm5MVtGtCgH4Irzyb9mJDYwNE= X-QQ-mid: zesmtpip4t1784860146t7ae6cf1f X-QQ-Originating-IP: wWBgv0NV/7CKCdcjUMM5igbrbPg1ViC8PwqJvYK5y/c= Received: from localhost.localdomain ( [localhost]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 24 Jul 2026 10:29:03 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 4050712520101716894 EX-QQ-RecipientCnt: 26 From: Gou Hao To: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, bharat@chelsio.com, jgg@ziepe.ca, leon@kernel.org, akpm@linux-foundation.org, gouhao@uniontech.com, namcao@linutronix.de, ynorov@nvidia.com, sshegde@linux.ibm.com, nilay@linux.ibm.com, clg@kaod.org Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, gouhaojake@163.com, kernel@uniontech.com Subject: [PATCH v2 2/6] powerpc/xive: add error return value to xive_smp_probe() Date: Fri, 24 Jul 2026 10:28:47 +0800 Message-Id: <20260724022851.466017-3-gouhao@uniontech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20260724022851.466017-1-gouhao@uniontech.com> References: <20260724022851.466017-1-gouhao@uniontech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpip:uniontech.com:qybglogicsvrgz:qybglogicsvrgz5b-2 X-QQ-XMAILINFO: OAPJltlfxx0LCBmOXUuzp2BiW70r2R33oMIB3v25EpbYXyqbc5Cf2aGi gYhaKA6U4i6g3pzle958lWasdpVMihj1zbI4dqhSruhzv+4sY2ibGuSKkQ+7gxzBsbvAqqt 71PhKDoTLFP7hyP+NSP5haJNwT5Lf/NHq/K4Npy0Vg26osRjnEGKunytmKWJW8PLssaiERr d8jY+0M1QIhmKoOE5W3KIiUVkhAoiVrU+IYawbztDpSOFrjmxdniLE3d11plVpC2cGHbAze FLvPpYHgRflCA2rH6JoDyJXmE1ns47PVtAndyio5BM5SizNqe2VO5Gk6aE4Ihs87oyYQy4F IvOmXSznuAy2H8Dk3G5TxX9vTTN04h2bcJY2G9vZxbmySNLo62QpSBe9tLUsWduGBrv16jD yjWPlYtXXPJhyy5Lya4X+naSi5CtYrpKz7Jeq18jBDOe8vaiR4rQKtHOCNsez3m9zyXp8uH BxBNKbMca5sN3zFZ3FXVBunMKZUORGKWTO5R9L11MgBlRrTaAk7eEZLYDBB5glgcq7Mfv9d bPc5EBEUFe8t9MhHMoNdOFaMleaj0LCzLXj9pM1/VpmIxkMDvr81hn4c9hmXurZq1OaPK2l UJxgbj6ybMQO0gbqqaO6IeJZg6VWI1R4+uIpIZUsfD3JNDqz1A+x2HAtuJQhqmWfv+Q6QVi hcnnAlMNXjR8ohNuJl+R094d3wGSpfPwNSfVXVCuEk2Pzpy22ITpiRIjVvqWhdQ+Z7bzZPd aPdFsrM5O2T/du3+dRKmQiD9VcsOPsH0Redms+EYv1Da1zYuU8ofsUt2OMg3URjG/hgdyt6 +I/PSuDvRskuRNm6JAWBKGLfTY0EiMI9Yb9U6yDEUSeR0bW2B3hJI3oz6084IxAPdZgrBEv 4MV1w6y9xVTu3ZS4ktpiZytA+nZGVE+s7po6PTrQc2bxhYYNh3BmAajfIiJvzPxvJS2jxKK HJFhNPXrHyzK3KI2WJCJUsHYJQKerbfqTcp36oHEPmQchqHDunB780vZYBs7k8iVUHM2XRv oQ0B/ufBFa11UrOc2ge90qBRRlnKXRV5Prwzm9LD43GUf5UKga X-QQ-XMRINFO: OWPUhxQsoeAVwkVaQIEGSKwwgKCxK/fD5g== X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" xive_smp_probe() calls xive_init_ipis() which can fail, but its return value is currently ignored. Change xive_smp_probe() to return int so that errors can be propagated to callers. This is a preparatory patch for the next one. No functional change yet; the return value is always 0 at this point. Signed-off-by: Gou Hao Reviewed-by: Wentao Guan Reviewed-by: jiazhenyuan --- arch/powerpc/include/asm/xive.h | 4 ++-- arch/powerpc/sysdev/xive/common.c | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/include/asm/xive.h b/arch/powerpc/include/asm/xiv= e.h index efb0f5effcc69..4e3e3358993c0 100644 --- a/arch/powerpc/include/asm/xive.h +++ b/arch/powerpc/include/asm/xive.h @@ -91,7 +91,7 @@ static inline bool xive_enabled(void) { return __xive_ena= bled; } =20 bool xive_spapr_init(void); bool xive_native_init(void); -void xive_smp_probe(void); +int xive_smp_probe(void); int xive_smp_prepare_cpu(unsigned int cpu); void xive_smp_setup_cpu(void); void xive_smp_disable_cpu(void); @@ -153,7 +153,7 @@ static inline bool xive_enabled(void) { return false; } =20 static inline bool xive_spapr_init(void) { return false; } static inline bool xive_native_init(void) { return false; } -static inline void xive_smp_probe(void) { } +static inline int xive_smp_probe(void) { return -EINVAL; } static inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL= ; } static inline void xive_smp_setup_cpu(void) { } static inline void xive_smp_disable_cpu(void) { } diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/c= ommon.c index f2904a5c2b7bf..f9a1229cede73 100644 --- a/arch/powerpc/sysdev/xive/common.c +++ b/arch/powerpc/sysdev/xive/common.c @@ -1254,7 +1254,7 @@ noinstr static void xive_cleanup_cpu_ipi(unsigned int= cpu, struct xive_cpu *xc) xive_ops->put_ipi(cpu, xc); } =20 -void __init xive_smp_probe(void) +int __init xive_smp_probe(void) { smp_ops->cause_ipi =3D xive_cause_ipi; =20 @@ -1263,6 +1263,8 @@ void __init xive_smp_probe(void) =20 /* Allocate and setup IPI for the boot CPU */ xive_setup_cpu_ipi(smp_processor_id()); + + return 0; } =20 #endif /* CONFIG_SMP */ --=20 2.20.1 From nobody Fri Jul 24 04:50:32 2026 Received: from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 248E92DFA2F; Fri, 24 Jul 2026 02:29:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.207.22.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860167; cv=none; b=lkvpPa5o6yE9Ju91WRcmqOhCA6r/3hBhjsvvJ5eSdrumFqV6WChEzr4vQH5bPYLTQADwhm379Ze9CPQv6/S2ryD/7750w28ElSSLbkf1+iV8Znas51ofzV+Z70Fqn5rr+7sxaerOcQJgv7djB8RkHlRr3LHQVcMRnAc8lBI/7s8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860167; c=relaxed/simple; bh=qBcgriTpGXSdcveMAzU624WbFDixVzDy04LllnPaDrM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FutYmupQJ3YWFuauc0X0Jz0fgpWk39AHg1fPlZMaITL8P1hBC8TcpefSJHTxGWNZDKBdz7oztihBfHNSI24ou9R6B1lwH9FJklZWh9W3RDPYOp2Vj978iAvFyoFJSV+bmPvnRP/nzm/AQxs3OtV0iBz3misltwC0CR+Y7vdT//s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com; spf=pass smtp.mailfrom=uniontech.com; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b=LGfdFVjE; arc=none smtp.client-ip=54.207.22.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uniontech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b="LGfdFVjE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1784860158; bh=nFjFFaXMkLzxoExHNfOEPPaBXmUVyvwpIJWfb32uFmU=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=LGfdFVjEYvjxVglWZxiq7eRgH6iAbJCqSGnStOyur1w26FW1jBqPB7R5Vqou5CR4Y FMd5CNpZNFjhTPK2ACHL6w4uGM93PnwP44MG4hx0+QkjlnXi1dZJwKdpwjcAOv+ny8 qv2LUvh8UWBYWu8YbbUEuozZRsLChfXnyot4kYlE= X-QQ-mid: zesmtpip4t1784860151te3c12dad X-QQ-Originating-IP: Q0VsYdJjns2x4KkOcgSLM6b/xTyYuD8mV2X7QLUMAvc= Received: from localhost.localdomain ( [localhost]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 24 Jul 2026 10:29:08 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 9743323694755543151 EX-QQ-RecipientCnt: 26 From: Gou Hao To: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, bharat@chelsio.com, jgg@ziepe.ca, leon@kernel.org, akpm@linux-foundation.org, gouhao@uniontech.com, namcao@linutronix.de, ynorov@nvidia.com, sshegde@linux.ibm.com, nilay@linux.ibm.com, clg@kaod.org Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, gouhaojake@163.com, kernel@uniontech.com Subject: [PATCH v2 3/6] powerpc/xive: fix use-after-free of xive_ipis Date: Fri, 24 Jul 2026 10:28:48 +0800 Message-Id: <20260724022851.466017-4-gouhao@uniontech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20260724022851.466017-1-gouhao@uniontech.com> References: <20260724022851.466017-1-gouhao@uniontech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpip:uniontech.com:qybglogicsvrgz:qybglogicsvrgz5b-2 X-QQ-XMAILINFO: N4WhQbLQyIqSPgzBttvoGSM0rHIoDOFdOVlvtNsNl44gq9z78OzWrIQn 6gTUsLCO36PpNFC0aA0PRmQnKvNci4ZQCuiVBpPbpXXISn8zdTFbgp3vKkE6ZTbobi1ogUE jATLyFsKHyR0ky86uD5CPeWt4gVZ3ayOK4w0Nv73iUfhXxwuohHPDR2QOkSXwKafi+gdb0h 1X4BV8pTOicrYDaJjzUgKGlx9or5UZcU1K8SNsa37VetUCDaiU/d0CaIbuy97xGqFr6CB6E AzCoAY4qG7oHl+WKxvsj95cwOvTv9qDVxkL1IkZQlh4KXHmp7spDG/qS6tfu3WZLbS24DEG tBZ0fLHQFzaigA4CKBN/BkwdiKDNV98VH7swM35UHPCb05m6mI/yyjP4yw9ISxU5M5aMw1i LRcTYcQ0Kb+ZQoqRhYWH+ANL/sT0mwXjNj4ct1K1VFbmWCTYtJKNQWU5mKh9BSdaMUXlzm1 gjUQ2XdDE7+xTon2+AW+culXQWK+nKPYFKsZS2gAnwEz3hhqW0eHlpqFezzWzc/n9T+BW1F USfm8IEoAt9mMb3IGT6KEBGnnH/BbAS4m+tUQwNFxKwNwcOSW5cLXvGeVL+V2FszAciqtqv a+67zkvAWR2kxz2PyFSIDwZ0kdKlk+5jxO3QPySjDh3+fGncTY5QZC+UiYStS1SQ4dpxPxS VyCPuwluLgsOqTnob3KzueH755NsrSdey9aMQ9lvEtiv9JKZQp5/lXQhcmlWoA7lVxGNEgL ozyPBRAVhe+T3Sh/Fu5CP5xqCW9BhWPbBZ5qOxwwHpyLTiScNYfgEXrYLFSBbrJDGuJuXpR p1dRHRV+4fDuKy1kQCxQjKypoZA5aVe+ujIKuDbZENUKLEelQ3eCqBx6RxgMulVxp5Q2QhM G2hZkRtPGSrsZoLO0m85p1NxOqKy85Elc0TYzaN71kA87lyWHSzO4PhGwn2psCCPI4lLFTi rtNDeat6HTyZApeULdkEsXOeFnRiftQ7ErQ61jheOn7erktHgbKaShSSlZSvNp3fZgmvkmC bCJ7UCKhsIkqyX9n66pXkL+khsHQYr8jD+XbN2EiDOf9A1pSEOnRcnwcItIRM= X-QQ-XMRINFO: Mp0Kj//9VHAxzExpfF+O8yhSrljjwrznVg== X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" When irq_domain_alloc_irqs() fails in xive_init_ipis(), the error path frees the global xive_ipis array via kfree(). However, xive_smp_probe() ignores the error return and proceeds to call xive_setup_cpu_ipi(), which dereferences the already-freed xive_ipis pointer, resulting in a use-after-free. Propagate the error from xive_init_ipis() through xive_smp_probe() and check it in both pnv_smp_probe() and pSeries_smp_probe() so that IPI setup is aborted cleanly on failure. Fixes: 7dcc37b3eff9 ("powerpc/xive: Map one IPI interrupt per node") Signed-off-by: Gou Hao Reviewed-by: Wentao Guan Reviewed-by: jiazhenyuan --- arch/powerpc/platforms/powernv/smp.c | 8 +++++--- arch/powerpc/platforms/pseries/smp.c | 8 +++++--- arch/powerpc/sysdev/xive/common.c | 6 +++++- 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/platforms/powernv/smp.c b/arch/powerpc/platforms/= powernv/smp.c index 8f41ef364fc6f..b1201dbafcaf6 100644 --- a/arch/powerpc/platforms/powernv/smp.c +++ b/arch/powerpc/platforms/powernv/smp.c @@ -332,10 +332,12 @@ static void pnv_cause_ipi(int cpu) =20 static void __init pnv_smp_probe(void) { - if (xive_enabled()) - xive_smp_probe(); - else + if (xive_enabled()) { + if (xive_smp_probe() < 0) + return; + } else { xics_smp_probe(); + } =20 if (cpu_has_feature(CPU_FTR_DBELL)) { ic_cause_ipi =3D smp_ops->cause_ipi; diff --git a/arch/powerpc/platforms/pseries/smp.c b/arch/powerpc/platforms/= pseries/smp.c index db99725e752bd..14cd0634eeca8 100644 --- a/arch/powerpc/platforms/pseries/smp.c +++ b/arch/powerpc/platforms/pseries/smp.c @@ -194,10 +194,12 @@ static int pseries_cause_nmi_ipi(int cpu) =20 static __init void pSeries_smp_probe(void) { - if (xive_enabled()) - xive_smp_probe(); - else + if (xive_enabled()) { + if (xive_smp_probe() < 0) + return; + } else { xics_smp_probe(); + } =20 /* No doorbell facility, must use the interrupt controller for IPIs */ if (!cpu_has_feature(CPU_FTR_DBELL)) diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/c= ommon.c index f9a1229cede73..bb6ce07c1699e 100644 --- a/arch/powerpc/sysdev/xive/common.c +++ b/arch/powerpc/sysdev/xive/common.c @@ -1256,10 +1256,14 @@ noinstr static void xive_cleanup_cpu_ipi(unsigned i= nt cpu, struct xive_cpu *xc) =20 int __init xive_smp_probe(void) { + int ret; + smp_ops->cause_ipi =3D xive_cause_ipi; =20 /* Register the IPI */ - xive_init_ipis(); + ret =3D xive_init_ipis(); + if (ret < 0) + return ret; =20 /* Allocate and setup IPI for the boot CPU */ xive_setup_cpu_ipi(smp_processor_id()); --=20 2.20.1 From nobody Fri Jul 24 04:50:32 2026 Received: from smtpbgeu2.qq.com (smtpbgeu2.qq.com [18.194.254.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47FC624A05D; Fri, 24 Jul 2026 02:29:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.194.254.142 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860174; cv=none; b=FYaoAQG7Ln8tvljW7nUtbNwP+CG0IG7/tczGqN6NaGoZXP127sedVPhY8jj98GqCLoXzTjMHR3JG/6qTGYraYhdnuytvEyoCCM7EjSjZWLphd+sh8BPMOvmQ4F6CDgJ8RaRTELT5rw979VsL98E9bl+zY1wMbrc/FfNo5k1Dxds= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860174; c=relaxed/simple; bh=JT1pzcfQVM886uEGqMmj+hWRUWDWJTINjKd9EvxpzuY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=u8NVjNke89nqaUwA/a3lXVwFOnSqSytO9K7a03n1hJZawCFhiCrucdpstXyC1FYS6uPpzUdA66spPUkRNagFlb0jDEjcmJYaI50i70OUWI5M2jeT4o0+yjbtjhmfu4KrmoaxaJk6nprwpN3hJ/8h+vmHDCJwTJqD3ZztjoPO+wE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com; spf=pass smtp.mailfrom=uniontech.com; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b=UKkOeSMj; arc=none smtp.client-ip=18.194.254.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uniontech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b="UKkOeSMj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1784860167; bh=+ZvTI/fcAWs1dkQ4W9g4AT4WdA/up4PGQNqGKnn0rhc=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=UKkOeSMjc/734Eg4FD29Vaa0QPupow1mcYAPMdU0RYAmKUYyK2ylcBhHHNUhjlepu mbxexVLc6DivY6nkDL6kc4X7wFL00xjZPf6n3cB+tp/B+WdfoksWWTL+anW4tXF7sd WNkTTSCQWJF6KAo1LyQDU0SYez1fEa0bJoYSRBSw= X-QQ-mid: zesmtpip4t1784860156t81fb8ef9 X-QQ-Originating-IP: uU8Dw1tobLbkmKcfvIpWRxgng5wGRpu3yzVVioqlHrE= Received: from localhost.localdomain ( [localhost]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 24 Jul 2026 10:29:13 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 1489989829865237816 EX-QQ-RecipientCnt: 26 From: Gou Hao To: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, bharat@chelsio.com, jgg@ziepe.ca, leon@kernel.org, akpm@linux-foundation.org, gouhao@uniontech.com, namcao@linutronix.de, ynorov@nvidia.com, sshegde@linux.ibm.com, nilay@linux.ibm.com, clg@kaod.org Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, gouhaojake@163.com, kernel@uniontech.com Subject: [PATCH v2 4/6] drm: remove dead WARN_ON NULL check after GFP_NOFAIL allocation Date: Fri, 24 Jul 2026 10:28:49 +0800 Message-Id: <20260724022851.466017-5-gouhao@uniontech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20260724022851.466017-1-gouhao@uniontech.com> References: <20260724022851.466017-1-gouhao@uniontech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpip:uniontech.com:qybglogicsvrgz:qybglogicsvrgz5b-2 X-QQ-XMAILINFO: N0jQ/i/W/QNTxc/RtOd6E5z5X8iG4Xi7MqQlPDvw0XsBDLmShpd7mycT Xpv6qVp+4ijm3fmIl71zFj+aIYwRCnNJQyyR5AooAftoCKB3PrQqiqrnwEI3b13BwWo8v46 i5VM6TOAep3cS1JT2Q1V11/cn42F8ZHkI4LCGpDObLaDi5pbOPmuFWTXJYDbAXqj1UnRZ9m pQhBOSq5LG3xhpmajaz6Ru4IyWqwNpMMi1KnzmxUBsZqbG8VNuhQAQV9b7M0i5NwGAsMCTB LYbaQrKuF1bVNDm63EaYvf7RN6e/OrJCwU0GfaQB3ROHS1S+uIQRcEv7zHK9hkH/0r0ciAz pm+kxbAmHhbOduLSCV5btEfD6BXlWLQxwrhiVNvGkGpBkzV+Fm0Vmgdhj2BY/5nQDSyU1gn WFcDvPe0tQh0FLZpHnuPtuOyhXDNdAF3lxnsh49+wB+20Ht5Gb+S5pJqqKoBCy5NhIe2u0h uGYJW2JMlvjI6VR4TEYBv6NwiyOzUDkFvasbIbxElR4Yn4T1hZEYt54uC2d58tjhFkJuhdB DftLyvprBOSKpAFqeRVIktYQHqr2vBYyyLm5HIk1d0CnWLTD1tBK/Bnqcfoym5McJeCm96u r/zotQyMwj/qrNDgyBDbGNRchpmOP1/KqJ6hvTnlGZtwHyIvtM6yib4/NRhSl403w71YbES pVjPpHMHiGAznigrLN0CfuIzHYgFs1IMlj3yHNN0HrUfRpgRuGgFug/Hc1tUv+PNNF2Q/6P hw2qkgvXXdkFApwk5wu/kjStmP9YkudYxY11bVpoP4aDckRgvVFohZCohUjLJ1uYyqVgr0U 5Nn7h8EV+merpEbwqCd85yj4lTpl3k8jMgwCS4W6qtAPy0uaZMHPrSS1NyahcNCFs10ECbb TM+TSjQs5njAmxd1D678fdsOQZy3dyBjD/NhrV/AB4zC4xBO5TyeFUdFq+EyRWuMiXdJeg5 jrrvuj7PcUYnIqSidc8Krylg8R5xZyCqb8Cs6fts44nLSQ2cMstY6G2YIQwR8kEgNfrIrzj nQP+j3uMRkDGQ3wdBji7nGcCcINOlYyIihPFePqMOVNMZGWEvX X-QQ-XMRINFO: MPJ6Tf5t3I/ylTmHUqvI8+Wpn+Gzalws3A== X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" kzalloc_obj with the __GFP_NOFAIL flag will never return NULL, so the subsequent WARN_ON(!ctx) is unreachable dead code. Remove it. Signed-off-by: Gou Hao --- drivers/gpu/drm/drm_modeset_lock.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/drm_modeset_lock.c b/drivers/gpu/drm/drm_modes= et_lock.c index 2c806b0146d67..e14814c30d8c0 100644 --- a/drivers/gpu/drm/drm_modeset_lock.c +++ b/drivers/gpu/drm/drm_modeset_lock.c @@ -149,11 +149,7 @@ void drm_modeset_lock_all(struct drm_device *dev) int ret; =20 ctx =3D kzalloc_obj(*ctx, GFP_KERNEL | __GFP_NOFAIL); - if (WARN_ON(!ctx)) - return; - mutex_lock(&config->mutex); - drm_modeset_acquire_init(ctx, 0); =20 retry: --=20 2.20.1 From nobody Fri Jul 24 04:50:32 2026 Received: from smtpbg151.qq.com (smtpbg151.qq.com [18.169.211.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BCE631985D; Fri, 24 Jul 2026 02:29:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.169.211.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860180; cv=none; b=nL96TUolTfo/LznUgfhQavVBJu2iQYXpEGvYcwGIqG2aXWC9MMDnegGXEVOCvTBePGeS1Yrn/+A9KBWV65nJnoGB3MxoxwMkLjRm0mjjJpbSt/xcbReMtBXBwj7fh650UIkEksAp10UCkIQL1P3Fx/YsLcF+mE7A1Umsf7RVzCg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860180; c=relaxed/simple; bh=4PnnGJ6+0v44DOxB1H5wpOo39BV7YOi1rtx2aSUDuWA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bl9e2O2y98yIt3YDWs4FXg0g3KAwF9RW3K+g/g+4lE2XFAedn4Fiw3xqiN1yUOVcmp2dmeAlqMnDOBetzy/beGc3TMzoqOC9DzPnXyc4FJDH1gxocHqMKAe0m9B32dq9WfZ4Ns39Az0EuDKbaurUenCd6xp1N3m5D93CppG8Zfc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com; spf=pass smtp.mailfrom=uniontech.com; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b=ImOl3V+3; arc=none smtp.client-ip=18.169.211.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uniontech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b="ImOl3V+3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1784860168; bh=OyqXJDBODKL4i9r4faSbxqKqbqbjK9rOASLwkWPXzB4=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=ImOl3V+3qmGjRisyVUVd9mh2AZ0NFSJDdEzDIqUpNvqoNTKhOzOi6KGDffGACMmtR Ieie27rcygsxcHg/b5/K/9wRnsRHf46IlOy9eN5HlR7Vl9LPGQaDr1c7Xc6lm8x8IL 1q3YhVXJS2PN8fyIiZ8h9JL89x+DGRIhNn+dO7mU= X-QQ-mid: zesmtpip4t1784860161t8fb1ed23 X-QQ-Originating-IP: aBJCglJ9q/YAKBS1d2e+RK0bytOzmdANKIZ+RTuS4uM= Received: from localhost.localdomain ( [localhost]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 24 Jul 2026 10:29:19 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 645947347967007313 EX-QQ-RecipientCnt: 26 From: Gou Hao To: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, bharat@chelsio.com, jgg@ziepe.ca, leon@kernel.org, akpm@linux-foundation.org, gouhao@uniontech.com, namcao@linutronix.de, ynorov@nvidia.com, sshegde@linux.ibm.com, nilay@linux.ibm.com, clg@kaod.org Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, gouhaojake@163.com, kernel@uniontech.com Subject: [PATCH v2 5/6] lib/test_hmm: remove dead NULL checks after GFP_NOFAIL allocations Date: Fri, 24 Jul 2026 10:28:50 +0800 Message-Id: <20260724022851.466017-6-gouhao@uniontech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20260724022851.466017-1-gouhao@uniontech.com> References: <20260724022851.466017-1-gouhao@uniontech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpip:uniontech.com:qybglogicsvrgz:qybglogicsvrgz5b-2 X-QQ-XMAILINFO: MhQmneo+3OPbeQBuJJY9aHki43hwqRhTZA8RBTTsTVh6xygcqsJ5LM84 51kCX/5nBUggAR5Q2KtqnFtaQFGbZwgpt1Bxp3zhwC2QFRUsB/CQLEVdX1cgGoF5y8hEGc3 nJAWwUMupjREAV6EhTuCagftQRhJz9/eNPhqPlJ2GZBawTKyouKP4OsUKK6hjQqKHGC0nG2 gxjfuD+m+W3xlV1hmpL4Ngfx3vjJH+LljEfOipBekInwM6A15YkTnkOPwjRAk0JO2ZpsrOT cEVbogtyNvUTx/+H/R83YnUk7X791NfttDwrSAyHEUhgm9ZxJn9H2PfrBVZpWmloVIjtpUQ 5dBE2a4UKQy74DQAzoHmi9K0RnRKBTN2E17ofm02O00H+xX92mCUfxOlEXubxUCOmYf3sgl UaGJu8yY7U5JJ5Fk5N3Y9R2x1sQAlryg5M4owSs0uaWu9igsBEuWoIz4FtkfjxQLT3SmUCG gTrsFdYMkkalMUkGZFTdsiQWmz5U1WkJY7+wc4d3SnpsBnA/HSSkDeJgF27WIBFNaaC6Tu1 lJRQtK0OuvBzTzaHgdWaJc+ebtjhK+utAjb8rCaI8DIk1j380k6HhRsSQDUKlEGkMX9ZDhC 7UJWRaNoc0dHa44YFeTuUvJc5n/tjISyHkvw4ispyWGH1t/78f3/Vo/o0/cMWV4+AX1FE1z IqXDayP51VASxpf8VibmnPBTYw7qcaMWymgQfxBDJBd86kDya/c1hc2p4+5B6WYBit55b06 U9pqsMK5hXhe9IjVnHKY4kwEianfI2/c+vWVDwoQlfsMaZlQtLuAFDBjrIc7efsS2LmLNZJ SGSh54oApiRAByxCv57JvkAYMwFMSDWG4MSRizPYr0I/2+XVoUaukzI3kamwuoe4cRu32B3 yTaxrRU3pfikruafSgojo4G9lhqQcJgcDKwoQm9quVD4bCqMkjYnmjWdVBXz2QzYlQHhubS Rzhkw7lMSmTjJlOR5miHUVgmN6RG9K59g2S4C0ERw7Bx59dITwa9JRtz5TLKt2gD7xEFgJl I+CRuAJYlKEXq7ob2KvkJcmq4KGn5ABj/6SdlHwuIwoiYBx9QI0KKUVCVmhWE= X-QQ-XMRINFO: Nq+8W0+stu50tPAe92KXseR0ZZmBTk3gLg== X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" kvcalloc with the __GFP_NOFAIL flag will never return NULL, so the subsequent NULL checks are unreachable dead code. Remove them. Signed-off-by: Gou Hao --- lib/test_hmm.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lib/test_hmm.c b/lib/test_hmm.c index 9c59d1ceb5b57..d615e4e5fc447 100644 --- a/lib/test_hmm.c +++ b/lib/test_hmm.c @@ -1209,16 +1209,10 @@ static int dmirror_migrate_to_device(struct dmirror= *dmirror, if (!mmget_not_zero(mm)) return -EINVAL; =20 - ret =3D -ENOMEM; src_pfns =3D kvcalloc(PTRS_PER_PTE, sizeof(*src_pfns), GFP_KERNEL | __GFP_NOFAIL); - if (!src_pfns) - goto free_mem; - dst_pfns =3D kvcalloc(PTRS_PER_PTE, sizeof(*dst_pfns), GFP_KERNEL | __GFP_NOFAIL); - if (!dst_pfns) - goto free_mem; =20 ret =3D 0; mmap_read_lock(mm); --=20 2.20.1 From nobody Fri Jul 24 04:50:32 2026 Received: from smtpbgbr1.qq.com (smtpbgbr1.qq.com [54.207.19.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E091B31A053; Fri, 24 Jul 2026 02:29:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.207.19.206 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860181; cv=none; b=fIoPClbqDVCuPk4RR/MWuZHLMRfBqyS0ILroQxM0M2CyBykzPdbHElnY9i19w4ye5PfXDIS1w5WohICp9FUgGbApev6C3jdwVU7I/wkkF8Cx16tKGl0RKkbltSF+2uxReBDUtnS/0K84YIzwjlVvDyPts7NAxL/mHZ+HlyqaAW4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860181; c=relaxed/simple; bh=bvRp3NThDExwUVLGiRwJgad3CghL7MLUZfwhVd7fpY8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=te3ua1gN0agyvkO6IF9HQlY5nWmUb7mGoHGQRuX7PlYGJQRu4Jb/YNqKuZRCtRhQzjaZ4Mbp3lT/mMov9dbw6Rc+ZE1zTyZNm4iQ4ibtGWP16lihVFWDndmF+IcoRX2M9f5SlEAblJ29gqv1QSI8mJmOVLXWUK0QCfHSAkE8b+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com; spf=pass smtp.mailfrom=uniontech.com; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b=JfRBL6vG; arc=none smtp.client-ip=54.207.19.206 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uniontech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b="JfRBL6vG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1784860173; bh=Yn0Gyoe5DqjP71R2buJi41mG3iZ0k1ZX3eDGImr8Sq0=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=JfRBL6vGX+km3YMzXlEy7HJjnZqr5bN52rjPOVAQnKRIbluO+xg2UR2JNwgYqwD0z SXyUg4OftBJTjKaq6Dj2Mo8/uGJrhggOebDVx6pkjdosAv8MRFez9vbIMWQeQE8m6Q WIIski7wchHE/k3u849ZwaM0Ku3cvTGxYk+Yhn7A= X-QQ-mid: zesmtpip4t1784860167t2acc5bb8 X-QQ-Originating-IP: qIXv24m5LF8xLoOUC1kXo/DM9tGPxEiRVtvDS4LSMeI= Received: from localhost.localdomain ( [localhost]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 24 Jul 2026 10:29:24 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 530311859156334886 EX-QQ-RecipientCnt: 26 From: Gou Hao To: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, bharat@chelsio.com, jgg@ziepe.ca, leon@kernel.org, akpm@linux-foundation.org, gouhao@uniontech.com, namcao@linutronix.de, ynorov@nvidia.com, sshegde@linux.ibm.com, nilay@linux.ibm.com, clg@kaod.org Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, gouhaojake@163.com, kernel@uniontech.com Subject: [PATCH v2 6/6] RDMA/cxgb4: remove dead NULL checks after GFP_NOFAIL allocations Date: Fri, 24 Jul 2026 10:28:51 +0800 Message-Id: <20260724022851.466017-7-gouhao@uniontech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20260724022851.466017-1-gouhao@uniontech.com> References: <20260724022851.466017-1-gouhao@uniontech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpip:uniontech.com:qybglogicsvrgz:qybglogicsvrgz5b-2 X-QQ-XMAILINFO: OL8jzxGXDQwe5+Vjow/jerrouFsLXYDeJK1O9Ov7DSshBfHWdMk4cvFo qhZgnY5yIrRt0nKFW4MuulZWTEKLA7qGK4rGL6oTYRvRyXfyx5N+de1qAoH+IwYekwkzl83 nkcBjId3AZu89P0s7xWI0BKZbRMsKzk6gtqBfgoBC3J2ov6HpLzowzIZON3zLqbnvPEPXVr Xs2Z0HwdodOWZsPSDCD13kqn5wG/RDo0DYTiLoTlux+WQRQGSRtnioz4AGSXEYAcYekkprr uwZh4D2rV9FBUQNpW7NnbyC4cdB16eFUaKmv1zYed+IgAGvsqF1Rw1ibOT8KmuNhhRt2CMl sYOmBQvS/V5cPS6Am1X2hFicO1fBvvXeaVha7ZRExw9V/Jsz78PqTxyQrNvjwy9EderILKf HiRrhjpaheDbpBhkWaPRLzn9xhsMVYriUkLZhHeP6seMv6uUI3wa+7YIuLKM//u20YkYjrN aL9EgHjwi4ATfe/cY0BB3zpl0tuHtTPgoPMbA1Dr71QO+JOIP2Qr4OqmSUmpmN7YB+Y6a1L Bc5p5aXkMkDh3mTXuL4E7uLVY4Vfz6BBIXSTUxZe4bz1QbYfRVauns/059HnE/gXUybrc9W UJffQ92bNNzb6+XQxiBAmrIUwqG+UgKEUfnfGiimXPD26OIxb9etyu+sY19bSY+ifuz5wQd DaBEv1opdSjABeLBH4G620oVXA15cH5O56esS+xxXi2ufPm/bEQV8PgZkfTPauMkjNABUQi L4zMmvwUV2IB9DQA4fjjBxBAm1o3hwzfocIhBWzIZS+veewUanOUlDzjggCfDv5TJQ+yKQJ HHhsscOe4zGd2w5DtuXRG5LNbufWD+KVATt05WCDuu+4pZ/TQuk9jY3T4kP83DF3NyovMCf 52AtX0Ug+MfO+YK3AVgKFTvTxsXSPEhSfvfbarw+eAGIjgxeg1rbt/JRY9Z4RLMF5OjoAL2 9NdntHcVlZKc6LDQfRut1ybN6zjnjws7A2Gvaaz/kFlUQEqbOYUa2KIKcN4EqdkPVyU6RnX Vlou6gjJacfcVcGfO/VmpzGLFJBem0xRYjdsdAjNtIrVllOZCEetzorxY8DG+ujtzIEN5LH A0v3nKEk98+YnfaFSsjZ8iZkOyJUJgvYVX+Stz8ULjGEYUiVqJYTto= X-QQ-XMRINFO: MPJ6Tf5t3I/ylTmHUqvI8+Wpn+Gzalws3A== X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" alloc_skb() with the __GFP_NOFAIL flag will never return NULL, so the subsequent NULL checks and error handling are unreachable dead code. Remove them. Signed-off-by: Gou Hao --- drivers/infiniband/hw/cxgb4/mem.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb= 4/mem.c index cd1b010141984..08631de17c0a3 100644 --- a/drivers/infiniband/hw/cxgb4/mem.c +++ b/drivers/infiniband/hw/cxgb4/mem.c @@ -74,11 +74,8 @@ static int _c4iw_write_mem_dma_aligned(struct c4iw_rdev = *rdev, u32 addr, c4iw_init_wr_wait(wr_waitp); wr_len =3D roundup(sizeof(*req) + sizeof(*sgl), 16); =20 - if (!skb) { + if (!skb) skb =3D alloc_skb(wr_len, GFP_KERNEL | __GFP_NOFAIL); - if (!skb) - return -ENOMEM; - } set_wr_txq(skb, CPL_PRIORITY_CONTROL, 0); =20 req =3D __skb_put_zero(skb, wr_len); @@ -134,11 +131,8 @@ static int _c4iw_write_mem_inline(struct c4iw_rdev *rd= ev, u32 addr, u32 len, roundup(copy_len, T4_ULPTX_MIN_IO), 16); =20 - if (!skb) { + if (!skb) skb =3D alloc_skb(wr_len, GFP_KERNEL | __GFP_NOFAIL); - if (!skb) - return -ENOMEM; - } set_wr_txq(skb, CPL_PRIORITY_CONTROL, 0); =20 req =3D __skb_put_zero(skb, wr_len); --=20 2.20.1