From nobody Fri Jul 24 04:46:11 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4199239E7E for ; Fri, 24 Jul 2026 01:38:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784857125; cv=none; b=ubj3MszXWBz9VSFPLYPuOHJ3sbQC35Rmv80u07OvJC8lUC7A//U3jg4zrx/PSd8j5BL65040yYclwsJR2IJXWX0/k6S2LHvjtyHXkGTjoXlnHE24rBcLwpj9f9vMQfHpaTkTiiaUqxCNqqvk/InERJK4ze8jv6zI5Hthv3CUJMY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784857125; c=relaxed/simple; bh=jNYQHIUkbqByED6v3tgKaKTS3GoX2TeoMX93HZeSf80=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Pn8Whs9o4F6/YbiqIuJaclRhz/+SoLCaT+FeEEvznB2CHs+RkQy4ZzCiukiOsLSWWbFSwdzGPKKVCH58DIflA0Ilv4g/FaU8KgZs9cFknk+WbRNk2E3H0nj8O9Dl91HDD6enIZEL9gyH9Ytzdq74IoDVCOX5/7nbgUhBS/yabYg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nue/XSCp; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nue/XSCp" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38759bcd877so1146451a91.2 for ; Thu, 23 Jul 2026 18:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784857124; x=1785461924; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=QnFMxdSo3llZpZ5BFe9yETSRjO+wdEOw2lS33Rp4FlY=; b=nue/XSCpJ9zGsDfV3aC+JSVR06gd1jIx3YwhFk7NuYLGP3zGGUAY180G2A6fmd5Jah rGHEyteqxlo2H9/cVzAZwbFWmesV30wACnmIr65KXVMarVHoSdXmQwMOpiDWrN9IJwb3 R015/R1iDnTPOAmldHzZhNW/Y5ER4FA1xf1XrXPQqbdV3IvthtuGoay92pQM2T+GPNpe QK3TC+9EuG+IPGUO2vo4rBIfclOGMVLfr1jvjappfNurtvoRSLN34LcWX4rEB83o3AIn 0ddBcDNpc1Pyfq14JeXvQr9xhNYT0Svo747wofZ69Q3i47BzsilOCrcJwh83NbsvRIDB tSxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784857124; x=1785461924; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QnFMxdSo3llZpZ5BFe9yETSRjO+wdEOw2lS33Rp4FlY=; b=rkrsYGNwjnBAD+eqSdbS7DXicvC7bgZIBjx95EfEeL1/bICGOSKE0mzbew2ePm5Lyc GvxAyA7vyLm32T1t95C6GNyI7Ypkje0tiktHoSpVLpaKdfrC9Nxxhegng+R1a0rF47rs R8YLdi8qnmFd4jr8+28pmLZuCRasOND+Im5MB+yA0L0qv8wXq+hBycPahD5lm2eGTJdz ZZYfe76uE9FzE2Xuz0QyrqDPP0tFNmW4LLHmb4MjIdnS2d85eDxWWeg6/U6m+qJSRi3S DfqrlYWScIacRFjcrt7+YnHgaI0YJkEkc4J9y4LvzNxSr4avI3Vb4vjHdrBW8bufSMdC t1kA== X-Forwarded-Encrypted: i=1; AHgh+RoxQN4IcrPX/FSqnvOjW9zmxb0QmxUaa1YqHD87I/f8o2Zt3AJeDkS5UYUdjujBJYlJzcxhJLQJmp8sq5w=@vger.kernel.org X-Gm-Message-State: AOJu0YxbC2+IzMc3D+8+YKz3vmiM5Wp1FmBRKXiMXIR3AjULplc7sGTs uhZXUVdTMYLu9stWDhZyRX7sO3jw+kQ0iH3surwyEqyHNgZsNgDv4/Qq X-Gm-Gg: AR+sD106toWbKQBOpH789g4HYHxLM4jDxgJeTn3l+zvoGrsqskA1rRNxRd9hRrDnduh aBLLn+ifgOK5zUzgbgbgkiZh6/CRHPgSVdT+H5S8xOct7tYIA3372LKB3zY1BoLTnvJKlgf1tIk GCACEzydLgU/sIDK1vqsa3wt11yPsmikS9CiHynJBy83aj6tjtmAO1nVYvmqU3xRd47X0o55WEQ 8w1riNysd+f5ZVNo4ZHuwbQaHtjn8jYE56jvlMd6jIU44j0abVjnO2kKyzcGJldw/W6dfFB6Qjv vGzYibT46Zz1Nlh76hgX4aby2z1NKwZsZ6UW8WgWW5aSZV2cKBxmFU1E0bBVgIJnKq2aS6stesR JCLI8igXC1Dqt/wgqtXOyB/Pm5oFkWB1VkytjbD07aQU+xTlUu+mUcHms86NAtOiAE9g5hs6E+o /DihZ8qxBqmLY+Vk8mlTK6X5NI6rnIUxfILeGd3pIHe7zCmA2BkkUmA8mER4Ks9s6rnMfEkYErE 5BU5jjHKmYWMAq1rWKTyVq1paj/KViCEOZU6U2EV2dbmRLgWnbyolVsPxd0b9g9IA== X-Received: by 2002:a17:90b:1802:b0:36a:c4b:76cf with SMTP id 98e67ed59e1d1-38ec6a515admr5347860a91.23.1784857123875; Thu, 23 Jul 2026 18:38:43 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f056472f0sm256163a91.0.2026.07.23.18.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 18:38:43 -0700 (PDT) From: Rosen Penev To: linux-cifs@vger.kernel.org Cc: Namjae Jeon , Steve French , Sergey Senozhatsky , Tom Talpey , Ronnie Sahlberg , Hyunchul Lee , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] ksmbd: remove extra byte from ipc_msg_alloc() size calculations Date: Thu, 23 Jul 2026 18:38:41 -0700 Message-ID: <20260724013841.1345481-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Three ipc_msg_alloc() calls in transport_ipc.c allocate sizeof(struct) + payload_len + 1, but the extra byte is unnecessary. The payload data is binary and copied with memcpy() to the exact size; no null terminator is needed. This was present in the original commit that introduced the file, where the structs already used [0] zero-length arrays, so the +1 was never correct. Fixes: 0626e6641f6b ("cifsd: add server handler for central processing and = tranport layers") Assisted-by: Opencode:Big-Pickle Signed-off-by: Rosen Penev --- fs/smb/server/transport_ipc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/smb/server/transport_ipc.c b/fs/smb/server/transport_ipc.c index 0c581b9624d3..41611c013d81 100644 --- a/fs/smb/server/transport_ipc.c +++ b/fs/smb/server/transport_ipc.c @@ -658,7 +658,7 @@ ksmbd_ipc_spnego_authen_request(const char *spnego_blob= , int blob_len) return NULL; =20 msg =3D ipc_msg_alloc(sizeof(struct ksmbd_spnego_authen_request) + - blob_len + 1); + blob_len); if (!msg) return NULL; =20 @@ -839,7 +839,7 @@ struct ksmbd_rpc_command *ksmbd_rpc_write(struct ksmbd_= session *sess, int handle if (payload_sz > KSMBD_IPC_MAX_PAYLOAD) return NULL; =20 - msg =3D ipc_msg_alloc(sizeof(struct ksmbd_rpc_command) + payload_sz + 1); + msg =3D ipc_msg_alloc(sizeof(struct ksmbd_rpc_command) + payload_sz); if (!msg) return NULL; =20 @@ -898,7 +898,7 @@ struct ksmbd_rpc_command *ksmbd_rpc_ioctl(struct ksmbd_= session *sess, int handle if (payload_sz > KSMBD_IPC_MAX_PAYLOAD) return NULL; =20 - msg =3D ipc_msg_alloc(sizeof(struct ksmbd_rpc_command) + payload_sz + 1); + msg =3D ipc_msg_alloc(sizeof(struct ksmbd_rpc_command) + payload_sz); if (!msg) return NULL; =20 --=20 2.55.0