From nobody Fri Jul 24 21:53:04 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D5B03DFC80 for ; Fri, 24 Jul 2026 09:09:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784884171; cv=none; b=emLTB3SJyRkbyOjtXyUNZoNqNniYhW3eaI0alTvXS17go4fN40yt0UtbnrayEvQk0Nbrs/iQZQV077PH4yKH2huFeW+k+d1WBl58h81EhWpe8qG7xNjut09uI1EKk72dVnWbi4+HBE3XmEaSqcXVUaT68d5Z4prkDVgg4GBwNJ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784884171; c=relaxed/simple; bh=mjrVDz4H6RpOYzrPpqqkMT5INmyzNFeOGabjHCl0QJs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XH8YptWz+YV4rgRoR5RHP3zyCGHE4hR74oicIfKPeU3MvWlD8NCEl+IgmKWj9xQv53Huc4um72QXwAifiymuxgvygCdD/cxgi6U5iQOdEPqxcccrn1tQmHrkePOn6+A2DRiHq0Nbc8s2ma27cOMBFvn+LQPHMj9fUvwrgG1//vo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B0IoIC6l; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BBEZYlIn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B0IoIC6l"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BBEZYlIn" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66O4smuM1897512 for ; Fri, 24 Jul 2026 09:09:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C4fjwuViaOd7s23k+7ReVdvQjEcM0iippnZxvUolPq4=; b=B0IoIC6lgEhlhw60 Xnw+SEktqDWDKXlxpBR8PwZ5mhrK1S6/VuS9CDOll1S67Gu4DbvkzAi/o2NFGbvf /ED63SaaRzsFbfa+osJ+S8VfbDvOfBJpVySihohr1tvyBnqMpfU3U1Lt+h5Yusnm Fo3azfJ0TP0VFIMPwGpyjtmmvswSXWkjz4xErEPt86Il585e3mR0AHuPWDJSYrjP LDFh8mSKercQuBE5ODhNvAlFeZKw8uHE2V9PFklJHUEXJH88+uS4in28o9yjyFk5 IkNqtMRzf+DrEPxMXFd5m2cCcjevnPslN00kfTbwbLuyQ7GFtZCSyFpcKjOEIWpr WlJvHw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fm1em8v7n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Jul 2026 09:09:28 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2cc7e86e7c5so4695365ad.3 for ; Fri, 24 Jul 2026 02:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784884168; x=1785488968; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C4fjwuViaOd7s23k+7ReVdvQjEcM0iippnZxvUolPq4=; b=BBEZYlIngEzspFiZdEXLpF+YxtN+YsLjWclKWlGk3KEezQf04icVL/DPgBiYMUZeLB WQWbzfrm/VWMcFLiVB9VArYLUVW9fLUsDQYepaQXN4+G8UfPktMA3w8z8G88rhIrg3ev gzdYhUzGgqJoNg5EiCGCeQDNYmhoY3+I5t8rTGDU7n/VQsw/JWqNM04X44Zx89PPauNp +XekOZQBt98N8DET+ybW3/l8T+4jTD79fx21nBLGxLY5fwj5S6zrPv1QRVX6e+DZQOVv TIchdhKd5blNUleb2W6CQqBJaYDuM3DcQnKBmZ8sBLlZWHiyU7wR2BZ3i7dhZ3HIqFbu n5rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784884168; x=1785488968; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=C4fjwuViaOd7s23k+7ReVdvQjEcM0iippnZxvUolPq4=; b=gVxKIDKvzZCAbualgVx1LY+AFJGG/famgbqHxa+5xb455oUAItiP9W6R5h5TQp9599 lfd2ZS6Q6qafeSyYVRf6YAFulI7er0qutF+2yGYMfdrdZc98uygr1NFr8bSdq33A/hh7 xlJzLT7v7/mmEP3ovFi05l0ZyaIlIJ+hvAEdafVz2INBBKbpQtHzZKqZHrBkH26JoSJo IOges0BS7AxXPt6vEb/0zKqbR+t85/Yff36sGwIb6QFyQg+IUZF7DizF9UGjATNjsMJH u2Ae4oj9woL21bThI3YyroEUnrxX+Ku39+8Q+2ZGSvTWUsth+fn7oSSU33zvqlBVx2bq G8dQ== X-Forwarded-Encrypted: i=1; AHgh+Rppa5YRsxjHbDZ9q4LR9bxmQ1XUSUaSlDUiUyWxSqSFb0jDpuH1bywRwzxik3wEMOI46LJ6Kzf8WfcyNeY=@vger.kernel.org X-Gm-Message-State: AOJu0YyyEdQINdii94tGZK3n57k3TS1KTaE9DD0UGCVFtlDT6WXFoIVG wMeRFdh3/y5rQjBEgaM67ZhE01uD4nMXFD5950NhoQNkN/cuC+XSOgJWqzOSVvwMIfMtZU+UTFl Z0+hNQAAMM8WD/i0yM/q5nYkAOPagvfdPjtW55VSNRdsFz/RuYogDEB69DZ4bwKQaKjrfYVqKxN 4= X-Gm-Gg: AR+sD103z772m9Hk6PifIuh30rHlV/XxC73uPSp2q0/o8MvYSfofN/ySSc2PQj/tFa7 fBq+nmelIXbKe/nc1NMmrxWrXP/mkp4Dxc4ZrxBUap2U8y8KiYmvgHqRJtiKL7XpEzOBKMUxlxR qhrO34F7clPQ+mEviyCnHFVLjutHHhKZYup/rEoBfZBm23dEhWdG4J1LjgGZnqOEs1fjMVFax4t oCbeYukmdZ50WlLbkwjexLOodmB6qIsaq3P8ZaFrcoNfZUeYf1x7IgM8MrX2FJTArrnWbbzq+ar XQonrtssHmVQ1higNBS3jXENrXJChuXkpeBAMfzMFe0FaBZmUduL+dLQPT8kNgff6JLIG4Js8r8 ygu/WNAhgMLPCuM+qAg5GVZsjDIYVreE= X-Received: by 2002:a17:902:ecc4:b0:2cc:9473:97c8 with SMTP id d9443c01a7336-2cfa6b7dbbemr74746625ad.15.1784884168127; Fri, 24 Jul 2026 02:09:28 -0700 (PDT) X-Received: by 2002:a17:902:ecc4:b0:2cc:9473:97c8 with SMTP id d9443c01a7336-2cfa6b7dbbemr74746225ad.15.1784884167706; Fri, 24 Jul 2026 02:09:27 -0700 (PDT) Received: from hu-sachinku-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc1a6adsm27170719eec.6.2026.07.24.02.09.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 02:09:27 -0700 (PDT) From: Sachin Kumar Garg Date: Fri, 24 Jul 2026 14:38:57 +0530 Subject: [PATCH v5 1/3] media: iris: cache work mode after computing it in iris_set_stage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260724-iris_multi_slice-v5-1-4fb593d29b44@oss.qualcomm.com> References: <20260724-iris_multi_slice-v5-0-4fb593d29b44@oss.qualcomm.com> In-Reply-To: <20260724-iris_multi_slice-v5-0-4fb593d29b44@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Vedang Nagar , Stefan Schmidt , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Kumar Garg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784884158; l=1459; i=sachin.garg@oss.qualcomm.com; s=20260211; h=from:subject:message-id; bh=mjrVDz4H6RpOYzrPpqqkMT5INmyzNFeOGabjHCl0QJs=; b=paK2wn9a4zqJTDaD8uutynnzBibpF639fws5USR7tyf4j3CuICrhETPTaAIUgaAzLue2jH2iT 3EbOlJocLp4Ckrj37ucYxxCAL/xHdRyCT0jD87qmlo6i1bzt5Hs1iBM X-Developer-Key: i=sachin.garg@oss.qualcomm.com; a=ed25519; pk=KcRhp4CP9cR1V2tg6xSNRnB2STYaU0vVigdUF4Actu0= X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDA4MyBTYWx0ZWRfX6FDUjZF2L4WA 1ETl7vc/li+PfC2sM2OTjQYC3Zeo6UaacjZSL5gDnZk69zM34IHUpQzJi3QCOObCM77FCc+O5Rc bWeBlLIUc/93DY830s8Eg+3WKYmVhCE= X-Authority-Analysis: v=2.4 cv=BIODalQG c=1 sm=1 tr=0 ts=6a632bc8 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=DQE9uWRhMQBL0dtU3VIA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: 0Aq3muZMEh4OKiJ1pCkMSUBxUDxqr00e X-Proofpoint-GUID: 0Aq3muZMEh4OKiJ1pCkMSUBxUDxqr00e X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDA4MyBTYWx0ZWRfXxhwtDXkYRvI4 PZSzxrxRiSumuAiq1ozGdFMvrfEBaKn5RwoM7mf344MiVOeRrUxoohgISs3RbE7PCjrIvPiQ4Ur ncof062yDgvHs2GoTg3xaiuhzyCZWiCF6Y8dUjUnhiUEcGpVV1NLGPb7LtEVyAgpt9tGlKAZbHR zm7gsNC5228CzWuj05xWrPFuCue6ZSFlSaAJkfBsi7cQFE/79nSMdumtNrlZVVZrI2sn85Uva8T yN03Zt3PnW8e500AnmWkRhRElQ/+NbWFQ8fcpjNRTwIV//wRLBotwQVzwURSFurKftbXO8zMo72 XwX7G9PugSWKCbmv99KYj7cxZyrRsVJG4P64ZXmsCbEGtqgCPjAMHip0+rJc5OFYzuiX7r07cvt gpAVHxUAZf9nfuFqvyTbDbccwx6vJCCv/FDdg2ZsrkIc4xAM/p4QEWqw8OBNNJPVqrXp6ppgl42 imirnsjMVg9Lb0IlpnQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-24_01,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240083 iris_set_stage() computes work_mode and sends it to firmware but never updates inst->fw_caps[STAGE].value, leaving the cached STAGE value stale. iris_vpu_enc_bin_size() and iris_vpu3x_vpu4x_calculate_frequency() read this cached value, so a stale default causes them to miscalculate buffer size and clock frequency for sessions actually running in a different stage than the cached one. Update inst->fw_caps[cap_id].value with the computed work_mode before sending it to firmware, keeping the cache consistent with what is actually configured. Fixes: 3a19d7b9e08b ("media: iris: implement set properties to firmware dur= ing streamon") Reviewed-by: Vikash Garodia Signed-off-by: Sachin Kumar Garg --- drivers/media/platform/qcom/iris/iris_ctrls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/= platform/qcom/iris/iris_ctrls.c index 10e33b8a73f6..58d195d2ab87 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.c +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c @@ -521,6 +521,8 @@ int iris_set_stage(struct iris_inst *inst, enum platfor= m_inst_fw_cap_type cap_id work_mode =3D STAGE_1; } =20 + inst->fw_caps[cap_id].value =3D work_mode; + return hfi_ops->session_set_property(inst, hfi_id, HFI_HOST_FLAGS_NONE, iris_get_port_info(inst, cap_id), --=20 2.34.1 From nobody Fri Jul 24 21:53:04 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97AC23FA5FC for ; Fri, 24 Jul 2026 09:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784884178; cv=none; b=mPQd8FMhhAYTKameyLEP+khwL35zOlwS0iy35ZHvAsGSns8cSyMRMJ2PftbWqhP003Dh7YpUxNTmykbkdkLiYF55L30lTUoos0vTrR3L8geEY/L7461GzIzZ+6Ht2sdyLnsluqBTUZ5kfe9YqcDrRFR0EbI/+/mqU5edpEpNDks= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784884178; c=relaxed/simple; bh=vyhhtZo2WdIR+FGNDgM41Ud6FlKDiGMJM2eDDf1MrJg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YX7DfZprcnxVCq9ljbOR3Wqb5tz0OPqfNa9iYJe+PfFFBR4HvVqlaC5Y5233jY1YJvKHmsdcjXCnrsDF1vATatmXwmVSngFmQg8MgpkUt1gF5AzXwGTDeDhVnczlkEzE/hj+txA2iGyb8lhnB2P6J+pKOyn5qgm5F5gvfC+dJMI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=odxVt0rC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RnBnWmFS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="odxVt0rC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RnBnWmFS" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66O4lD5Q2275940 for ; Fri, 24 Jul 2026 09:09:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jqEI+F/1SIBbj6LdgTjUTc+Y69JPX3b2PxQd4sqwy7I=; b=odxVt0rC9XiA6XLj U0BPseDfJUzEWM5ryKsqnOPDGr91/PBDwpZH5ryJ9b8l5IrZmXwoFiWGJAono3vu 2IGTnuYTIAB1ctE3FZndxMMM+RwSHmGcy86WeDMdPE7H1NLEoLxWrq9rKoHsdKmR S+YzEIUkCLBgxinyXMafreCNYWKu2ioZ41QXgpoOynS4e5ReMCh137yWBLPKxXYd rxHMlwrGhEB8yWBxaO3/FpUvca0W0GaKT9iD4aMRDylFya0B2WHqxzU9VDq/7OkV SmvBYl4l/EyWroNp9QvPAmNu1xcIS/zw2oJe9W8nT5yi7zaxo9dzsDDr0ggyHTko JNCvgg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fkqa0b0c0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Jul 2026 09:09:33 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cf1c86963bso14153015ad.0 for ; Fri, 24 Jul 2026 02:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784884173; x=1785488973; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jqEI+F/1SIBbj6LdgTjUTc+Y69JPX3b2PxQd4sqwy7I=; b=RnBnWmFShwyP4I7wNiJLVmPHru75QBG0/P5O3Ccadp/m4IFijCak0A7iIvMGcEp3LP v/ITL3M2nrsRgB1Y4EUccrVYw8drIfgUQD5fyAxvWAQQrcG9iKmcAVxcqBSV+D9PTS9p /kmnpfkoixlj0jeuposqHvCMWCznlKbAYoK/otvSwKqjINs2r2fN+JztNuNB843PSpIs PZOr3JwJvHFDtwULJWt4ilDmYe0RsJmAyy4MOYtqCwSaUP/6R4CB81fNDOIsCUnJsRoI wahsErcnUuX5ZAVqJQ4aqUYfGKd1B/qpDIN6O88IWSXsK3b+/X8LvKfglDt2vfCphqIR psEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784884173; x=1785488973; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jqEI+F/1SIBbj6LdgTjUTc+Y69JPX3b2PxQd4sqwy7I=; b=aXEhbQNWQVVX1wGuVJvYkwrKQmjVLXBavUKvjQcAl98yNuIlfu7SoNClHrMAi2gjNq /jV8HWnLhJtttFBZTpTlvfOttrd1NZ5zF29mASMaSYHCDSw4aj4/vicAykRv7Q6zMjti IvTT7gWPl/WPRIWkWZFtOh5dDtSA6Bo8KABvHjrLTOPw2STsP3LjFI4X5g7/f1LZW2YA kdA010gpnW72QZQOCWX9+l4hKi83L7jttC7T82d8zdjX+vGHzFDBXwBAkPiAmB11sETT P0h9x2kjuo+XIVsB5pNukZX7UY9SXn71f+KG4fKHlEaRZjlnISVDVslh2TIcmYMQM+KS RyLA== X-Forwarded-Encrypted: i=1; AHgh+RoEQ/VWvZA0M0ACgNTAbciQ+BhEc4DVx/HQB9TyzYNFzspO1ZAHMMxgngcrKtf/xKAEjJxBa5TMlBcBMLQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxBaVRcB/hYP3tsMCN0Ewviz5WMwVTrEvcWE0jVRQI5OpQhaX1t VU21AaiZNLU4ady+O5SH6CZ8XznJRuQCTLSX/SnTc/jDHe+GJG3yaqKCKVnu25dqK6o8BxYtxPD fg6xXecFtrSaorkataYKaWNRE22LbbfvOVSxVNqFoW0rsD8b+7mg9fEbXaN+C+n5oXKbvGBHJcA E= X-Gm-Gg: AR+sD12/tlbMZprHhbaAxguFi32ELx+Cr3tfrvwgCvpa6noRn7eyHpSPMye6Y+HU1TW FHuYWohkE5Fnjfc+3KUJdHaaZPXgdnRg5eOW0RND0cdifgG16rvYdYFGl3NiuAn2Z4UJetoi4UH 4pG9hQr96esrmTP1ythSFUBIoI51b+Re1Fcd5lFOYIj+UNChRFSB2Pd2Al7TDMlAlgeyqTw0FBe K0LPF+1/vG2vTsGTOFR7U3wVC9fUCgCdkkLsv2tiTspX/Pvg3EcmmFfxpqqAq8+mC07WRySdKsi SRaczAwtHsLwyX2ydHLqU7lvBf6cDEcPmJLlWMzXKCgsN6N3gF0g+ADFsuUrc3qbTQz8iKoa7xX 43R2394fKoi83vzETBfIBgukS/FiqOKg= X-Received: by 2002:a17:903:2306:b0:2c9:994c:9a5 with SMTP id d9443c01a7336-2cfa9588d7emr73332745ad.30.1784884173198; Fri, 24 Jul 2026 02:09:33 -0700 (PDT) X-Received: by 2002:a17:903:2306:b0:2c9:994c:9a5 with SMTP id d9443c01a7336-2cfa9588d7emr73332485ad.30.1784884172772; Fri, 24 Jul 2026 02:09:32 -0700 (PDT) Received: from hu-sachinku-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc1a6adsm27170719eec.6.2026.07.24.02.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 02:09:32 -0700 (PDT) From: Sachin Kumar Garg Date: Fri, 24 Jul 2026 14:38:58 +0530 Subject: [PATCH v5 2/3] media: iris: force stage 1 work mode for CBR RC on encoder Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260724-iris_multi_slice-v5-2-4fb593d29b44@oss.qualcomm.com> References: <20260724-iris_multi_slice-v5-0-4fb593d29b44@oss.qualcomm.com> In-Reply-To: <20260724-iris_multi_slice-v5-0-4fb593d29b44@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Vedang Nagar , Stefan Schmidt , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Kumar Garg , Vishnu Reddy X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784884158; l=1399; i=sachin.garg@oss.qualcomm.com; s=20260211; h=from:subject:message-id; bh=vyhhtZo2WdIR+FGNDgM41Ud6FlKDiGMJM2eDDf1MrJg=; b=Lw02srcT7XO5HNtAvaGhOh3qrJRtqG8UHr/PCbWs9/xeH6CaEsu+nx7z+nuQHY/kCbvzw/Q1T 5Kz1ATrrEJADoOTil2HoErvE1RZ6Mt/4M6m8EEDITQpm2yZhUKgqOBy X-Developer-Key: i=sachin.garg@oss.qualcomm.com; a=ed25519; pk=KcRhp4CP9cR1V2tg6xSNRnB2STYaU0vVigdUF4Actu0= X-Proofpoint-ORIG-GUID: 07D_-uatrOeYp4tkV3fKN98L0nfqtSdT X-Proofpoint-GUID: 07D_-uatrOeYp4tkV3fKN98L0nfqtSdT X-Authority-Analysis: v=2.4 cv=e/k2j6p/ c=1 sm=1 tr=0 ts=6a632bcd cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=LMK2Ni0dcLaqO0rVonUA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDA4MyBTYWx0ZWRfX2HEF+5z64nYw DWu3xV4J2Pa2u/dMs0m1nmp8Hqz/4Sd/EZ7cNbFRpJvpb2QulkX2EEbLBSjFXF2PER3f3GAaCvu mkTTewz4/7ia9fYRG22Cr737ykjdQRtxap1eAbuG8ar3sj/NiKcjb7ScsMXySwzWHmgWYbdArmw 0DlEnFacu8q7zO4A2ADg26Y1gTqSn60j7MaaH/E7ZWPnJ5ZEAf6cKXRCq8IUx7ugZ0FGw0M/cZe UM3LKP3cwrO99hDknRMjmm28+Z8fGfSAMj57NdEAW15hdS5uDCEaArNuMqKFUkC2GFqXlmWPnE6 pTFz//IPl5LXb7cQRl587wMm7p/aD3KZ+chosXcdtgQObCBimaMdHdRoKspaIB+LT614Rcsl0Lu /DTQwajOc7m8xp6C0q8mbkZ+3lassE3EuApLafvxhTDpZXFUTZ0oFmEPN1AVBh/SRTSmi1mjsQb ceEHRohEutZfQ6EB5nw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDA4MyBTYWx0ZWRfXyamvX0s05y7D 2ZIdx86dWSp6biEdS9nKSwlASeJa2y1S1o6UDUglQoPd2iDsecWkYVtwPlE8x0xiQ71zUX1V29E I/4WhPUmqCt4GLV8kXVgNl12kMbggbc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-24_01,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 malwarescore=0 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240083 iris_set_stage() currently always picks STAGE_2 for encoder sessions. CBR rate control requires stage 1 operation, so force STAGE_1 when BITRATE_MODE is set to CBR. The BITRATE_MODE fw_cap value is used instead of inst->hfi_rc_type since STAGE precedes BITRATE_MODE in enum platform_inst_fw_cap_type, so iris_set_properties() would still see the previous hfi_rc_type when iris_set_stage() runs during initial config Reviewed-by: Vishnu Reddy Reviewed-by: Vikash Garodia Signed-off-by: Sachin Kumar Garg --- drivers/media/platform/qcom/iris/iris_ctrls.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/= platform/qcom/iris/iris_ctrls.c index 58d195d2ab87..d7cbf6c3614a 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.c +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c @@ -519,6 +519,9 @@ int iris_set_stage(struct iris_inst *inst, enum platfor= m_inst_fw_cap_type cap_id if (inst->domain =3D=3D DECODER) { if (iris_res_is_less_than(width, height, 1280, 720)) work_mode =3D STAGE_1; + } else if (inst->domain =3D=3D ENCODER) { + if (inst->fw_caps[BITRATE_MODE].value =3D=3D V4L2_MPEG_VIDEO_BITRATE_MOD= E_CBR) + work_mode =3D STAGE_1; } =20 inst->fw_caps[cap_id].value =3D work_mode; --=20 2.34.1 From nobody Fri Jul 24 21:53:04 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFE9B3F660B for ; Fri, 24 Jul 2026 09:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784884192; cv=none; b=BZjVUhOg7noMmGwiiNK3QgODDe3ZcRzP/KoagdJAZGs2sQN0qyw2s+wUHYXtZclkEfHL0+l7NpGCsGmwDIVse2b+zqSYS0/QVUzzLv/1j6Vyo+eb9VFKmgtd46BV+TgjIBcGasSIJ8su7lwZpbi7BeDG14XiOV/YkBvLTu25gOM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784884192; c=relaxed/simple; bh=PqwxDucZXdsz/HqCh2Q4NqD9sV0/hZDBckg40ADfDjU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZEhR4FEvddOr+dFWDsz16c7+LVEYY8bX9kMeXRqNYvW3LJyHl47+EtMiepcgclFBzsKzojw+44odQt+v3bDxE5Jgn0gSl8+N+BG06tE3x5xIRgVCYzWU6MfR2j40+C3HHIWqL8vjmYuWu4hZeevuvFruyoq569kmpk3H1ANtEmo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gNLOFRec; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S0LS5w8j; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gNLOFRec"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S0LS5w8j" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66O4l9ee3139465 for ; Fri, 24 Jul 2026 09:09:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= T3R2RrInhdvmVACMUa6IozYiCgqEHfiEvruhwJfozNE=; b=gNLOFRecm/blEsXJ LgswQnP65jM0vJWg62QK2aBh5sin4J/w+PX9u7bSFJ7LFnGKuD83SrpET1YBDnc/ kFm4FNhgOuA7K34qPNRaX/UTJkLsgtxgagZCpC6A2nDfUzrTyhV47Gjm4p3EWhgP X/TEtFJxL8qu18Or6mFGSHmGKiIMKLNA1S5+u1ig0geOqCA9lh3GQqBXUFKev/Mi 7VHQWj3AOnKYF844w+ekW3iH/mDmfzQl2lpbVhBDn/Vek/vgXWvnZvHC7xORekvp p8nDxkhtavcFEy2iyqwvMh7EJX7JGrM5wjW5RcadOaScpZZpCtgrrTrkkY1u2MO5 pSVIUw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fkn9a3qvv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Jul 2026 09:09:43 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cb733fc5024so370597a12.2 for ; Fri, 24 Jul 2026 02:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784884182; x=1785488982; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T3R2RrInhdvmVACMUa6IozYiCgqEHfiEvruhwJfozNE=; b=S0LS5w8jvvR9p7Kdq5+HDOW5TvjwxOiJnsVQ3HKSyrFp45RKo+VYyd/8LtHWw4jOFP DSyVzb5e64DlTFl+xPrlgCSN4K4eEshI6Ba4Zr9aMjUN7XCAsNwU9FfO2QleVpYegCL/ fBNurpf+1wbEqY2YQIoow4hthdUeVURzeVNUkLZh1VZt5hAEJy7CkKNanUsut0rcKz3q HWpxCfx7TUiymNZRhSzhSfA7bhJW6ETLIUtLy7rfLwF6dbAmwDlXpEIx3cQc566iK5Ww YnpS0cqHey/u5naiLr0d9SiRYuWkgXtnUXJh58wgh79TADLl3esDvSk1YiBDzZv3d6Fp 3aEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784884182; x=1785488982; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=T3R2RrInhdvmVACMUa6IozYiCgqEHfiEvruhwJfozNE=; b=YJav9vca7IfLFdb3uN4oEQmQESFRdc/Kthde/TZKCjFMg5B708nvUVUX5aRGs4AmeW WJflHd1qEjw4pDKBQ0ZLxihYZ2XQS7sQ1UHcVqdDvSakkBjxQwGVUeWh2ttftQsoTfgp 9DY9TnALJi6LvtWUjXVCNdhaQ4ErqRsE9GXbjnhISbDvVQlJGqQMY4Czy+3Md+2w7xDX sffkSaotKBS9SQ3G0JvXFb9ldx/I9awx79HMNcAxD/iU87XxE6RmlMBmukjrXC1QoXHW 22PYXKn5qwtN9pfpdUp9zlOYb6KZoY0Wsnr40TrpeZZlI6Jft42Y+MYaQQvVDGxHDKmw X2mA== X-Forwarded-Encrypted: i=1; AHgh+RoReuLl1X1zlMUgbln5bnrHXfM8boZ6TZD6vrPBl+zbByoTI0KAs11SLduiViKgYWpubW3hxo2qgScJvp4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz09q4zhk2hEZx5PRi6bqctx4qHf8mrhaOrYIjZHIoY4iu2IJ04 QlowjwepjHhSlKr8dyrfdESzS8CfTghKXYjZYo0nOmPWtvGc0gdTG4fZQkAdsySwD11mjOZT8x7 wDOzAlLC5pxazsltamzR9TmSSnhfEdOC9eANW1qhpcQzcJDXzKYxwuL6PharWcYVjmHs48O8vyx 4= X-Gm-Gg: AR+sD10dhW7kII9NAK9hffU/5NwB5SPhWiNt1BA4Cl50dGg+G0MBruEaPTzSgt9eFDK GOzApHK5ABFOfD1lJ22Yh6sjASLnsgmmBv9s0u7lg1TEW2Cm4yUFwXj4e/S+89DtTZv3iKa8Ymg 4uVopLjbUK3CZYYl5DwmVSLbfF6tT8rVv2VW8d0dmU91ALSBvKJN5/1pTsausW8oSeVy5sXRFKz kHC4u7nDn6WGsaH+QExFWCmsiYxB8uim1lpB2NC6S9P9V7JxIplraxVtWaqiP+qpvDzz1S16E+h PSM+Eu5RKRJ0FSE6cIhiIyofHtnv35DhpEN4S8JtSG8Ue0cFpNE7VNdrG+quCzxWsv+wb8GgW53 oD8KSurwEz79SbvnLoSGbwZssf0iD9+E= X-Received: by 2002:a05:6a21:683:b0:3c4:397a:69b8 with SMTP id adf61e73a8af0-3c44afe7510mr7548899637.21.1784884182301; Fri, 24 Jul 2026 02:09:42 -0700 (PDT) X-Received: by 2002:a05:6a21:683:b0:3c4:397a:69b8 with SMTP id adf61e73a8af0-3c44afe7510mr7548609637.21.1784884177609; Fri, 24 Jul 2026 02:09:37 -0700 (PDT) Received: from hu-sachinku-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc1a6adsm27170719eec.6.2026.07.24.02.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 02:09:36 -0700 (PDT) From: Sachin Kumar Garg Date: Fri, 24 Jul 2026 14:38:59 +0530 Subject: [PATCH v5 3/3] media: iris: add support for multi_slice in iris encoder Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260724-iris_multi_slice-v5-3-4fb593d29b44@oss.qualcomm.com> References: <20260724-iris_multi_slice-v5-0-4fb593d29b44@oss.qualcomm.com> In-Reply-To: <20260724-iris_multi_slice-v5-0-4fb593d29b44@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Vedang Nagar , Stefan Schmidt , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Kumar Garg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784884158; l=12723; i=sachin.garg@oss.qualcomm.com; s=20260211; h=from:subject:message-id; bh=PqwxDucZXdsz/HqCh2Q4NqD9sV0/hZDBckg40ADfDjU=; b=8BSV8sbjNsBcsVfnJ9g5sMVTcpN/6fGcEU9WgLZFZI8bN3+4587Ob5nRc4knefGUlWdM6MhYU i2rb+WYqBBbB9gEjcrHZkpQQW+j4W1Dchn6xzOHBLxGA5cKGK8a3553 X-Developer-Key: i=sachin.garg@oss.qualcomm.com; a=ed25519; pk=KcRhp4CP9cR1V2tg6xSNRnB2STYaU0vVigdUF4Actu0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDA4MyBTYWx0ZWRfX9Kh5DGIRtyJx 1sKUkLk6ff23XZQXLbNAZqcE1bmMPrJLd+fpUP2V/nv+GpjrEjUlEmm3FIWjPjg5AbLUTQbT9fx oVKAsWPU6QLOUfjTgI/XhqyI4a3X0pXHULeBWN9eCmnBfuVElBinJ9Lhudj6+0dBGTG7TD9fQ4L 9beatvDbxvbxCVhZ0GlLrVGxo3BnqrWsVt81ZMZiLVgJXvxmilOycruPACQvaYaTQ7FqWGgNy3t iHrJYa1FbQlhT2nXW7s0zZ7eGhMXp+Z79k/wPwxYyuj1/N/RbaWFgz5L7nlccPZnFTDVGnLF5Na D8KkHuHOibX4uo3HetgdqOsNp38vk2ZFlEnBCJNICDzZCDcbjLNwkaGaplqEPq6FVaYqzh2T56L othE70p4Uz494dxgY36omlpE0PVbszcmFCodP3rvsIX2BJi6lx7W3Rq9O9StNIsYJKpIOyMQmCg YdIwSsTY9U1rPmL5VLA== X-Proofpoint-ORIG-GUID: fE5yu9wMDe6_e88asbnGYtnijsr6wOxW X-Proofpoint-GUID: fE5yu9wMDe6_e88asbnGYtnijsr6wOxW X-Authority-Analysis: v=2.4 cv=WOdPmHsR c=1 sm=1 tr=0 ts=6a632bd7 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=ZIa84HXPZlRSj4Il7NUA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDA4MyBTYWx0ZWRfX3wGqR3qu+K7R uwmNKpwrsP8NWJqxIeWJ78TCzLbL6zHeIf6grcCCTi4RffuDrQ+bPmQqQZxJRG+JroCGnMz1jOx x6Ppn8cbAJIFNXy76oiBrD1DPP6de7I= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-24_01,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 impostorscore=0 bulkscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240083 Add multi-slice encoding support with MAX_MB and MAX_BYTES modes. Clients can enable slice mode using V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE control and configure slice size via V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_MB or V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BYTES controls. Signed-off-by: Sachin Kumar Garg --- drivers/media/platform/qcom/iris/iris_ctrls.c | 86 ++++++++++++++++++= ++++ drivers/media/platform/qcom/iris/iris_ctrls.h | 1 + drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 33 ++++++++- .../platform/qcom/iris/iris_hfi_gen2_defines.h | 2 + .../platform/qcom/iris/iris_platform_common.h | 16 ++++ .../media/platform/qcom/iris/iris_platform_vpu3x.c | 17 +++++ 6 files changed, 154 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/= platform/qcom/iris/iris_ctrls.c index d7cbf6c3614a..955f0e56dbf9 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.c +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c @@ -154,6 +154,12 @@ static enum platform_inst_fw_cap_type iris_get_cap_id(= u32 id) return LAYER4_BITRATE_HEVC; case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L5_BR: return LAYER5_BITRATE_HEVC; + case V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE: + return SLICE_MODE; + case V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BYTES: + return SLICE_MAX_BYTES; + case V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_MB: + return SLICE_MAX_MB; default: return INST_FW_CAP_MAX; } @@ -297,6 +303,12 @@ static u32 iris_get_v4l2_id(enum platform_inst_fw_cap_= type cap_id) return V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L4_BR; case LAYER5_BITRATE_HEVC: return V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L5_BR; + case SLICE_MODE: + return V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE; + case SLICE_MAX_BYTES: + return V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BYTES; + case SLICE_MAX_MB: + return V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_MB; default: return 0; } @@ -1482,6 +1494,80 @@ int iris_set_layer_bitrate(struct iris_inst *inst, e= num platform_inst_fw_cap_typ &bitrate, sizeof(u32)); } =20 +int iris_set_slice_count(struct iris_inst *inst, enum platform_inst_fw_cap= _type cap_id) +{ + const struct iris_hfi_session_ops *hfi_ops =3D inst->hfi_session_ops; + const struct platform_inst_slice_caps *slice_caps =3D + inst->core->iris_platform_data->slice_caps; + u32 slice_mode =3D inst->fw_caps[cap_id].value; + u32 rc_type =3D inst->hfi_rc_type; + u32 fps =3D inst->frame_rate; + u32 output_width =3D inst->fmt_dst->fmt.pix_mp.width; + u32 output_height =3D inst->fmt_dst->fmt.pix_mp.height; + u32 mbpf =3D NUM_MBS_PER_FRAME(output_height, output_width); + u32 max_width, max_height, min_width, min_height; + u32 max_avg_slicesize, hfi_value, hfi_id; + + if (slice_mode =3D=3D V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_SINGLE) { + dev_dbg(inst->core->dev, "slice mode is single slice, ignore setting to = fw\n"); + return 0; + } + if (fps > slice_caps->max_slice_frame_rate || + (rc_type !=3D HFI_RC_OFF && rc_type !=3D HFI_RC_CBR_CFR && + rc_type !=3D HFI_RC_CBR_VFR && rc_type !=3D HFI_RC_VBR_CFR)) { + dev_err(inst->core->dev, "slice unsupported, fps: %u, rc_type: %#x\n", + fps, rc_type); + return -EINVAL; + } + + max_width =3D (slice_mode =3D=3D V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_MB)= ? + slice_caps->max_mb_slice_width : slice_caps->max_bytes_slice_width; + max_height =3D (slice_mode =3D=3D V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_MB= ) ? + slice_caps->max_mb_slice_height : slice_caps->max_bytes_slice_height; + min_width =3D (inst->codec =3D=3D V4L2_PIX_FMT_HEVC) ? + slice_caps->min_hevc_slice_width : slice_caps->min_avc_slice_width; + min_height =3D slice_caps->min_slice_height; + + if (output_width < min_width || output_height < min_height || + output_width > max_width || output_height > max_height) { + dev_err(inst->core->dev, "slice unsupported, codec: %#x wxh: [%dx%d]\n", + inst->codec, output_width, output_height); + return -EINVAL; + } + + if (slice_mode =3D=3D V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_MB) { + hfi_value =3D inst->fw_caps[SLICE_MAX_MB].value; + hfi_value =3D max(hfi_value, DIV_ROUND_UP(mbpf, slice_caps->max_slices_p= er_frame)); + if (inst->codec =3D=3D V4L2_PIX_FMT_HEVC) + hfi_value =3D (hfi_value + 3) / 4; + hfi_id =3D inst->fw_caps[SLICE_MAX_MB].hfi_id; + } else if (slice_mode =3D=3D V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_BYTES) { + hfi_value =3D inst->fw_caps[SLICE_MAX_BYTES].value; + if (rc_type !=3D HFI_RC_OFF) { + max_avg_slicesize =3D DIV_ROUND_UP((inst->fw_caps[BITRATE].value / fps)= / 8, + slice_caps->max_slices_per_frame); + } else { + /* + * No bitrate target exists under RC_OFF, so approximate a + * worst-case frame size the same way size_bin_bitstream_enc() + * does for buffer allocation, to keep the slice count bounded. + */ + max_avg_slicesize =3D DIV_ROUND_UP(output_width * output_height * 3, + slice_caps->max_slices_per_frame); + } + hfi_value =3D max(hfi_value, max_avg_slicesize); + hfi_id =3D inst->fw_caps[SLICE_MAX_BYTES].hfi_id; + } else { + return -EINVAL; + } + + return hfi_ops->session_set_property(inst, hfi_id, + HFI_HOST_FLAGS_NONE, + iris_get_port_info(inst, cap_id), + HFI_PAYLOAD_U32, + &hfi_value, sizeof(u32)); +} + int iris_set_properties(struct iris_inst *inst, u32 plane) { const struct iris_hfi_session_ops *hfi_ops =3D inst->hfi_session_ops; diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.h b/drivers/media/= platform/qcom/iris/iris_ctrls.h index 3c462ec9190b..5a73c7c49d36 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.h +++ b/drivers/media/platform/qcom/iris/iris_ctrls.h @@ -47,6 +47,7 @@ int iris_set_layer_type(struct iris_inst *inst, enum plat= form_inst_fw_cap_type c int iris_set_layer_count_gen1(struct iris_inst *inst, enum platform_inst_f= w_cap_type cap_id); int iris_set_layer_count_gen2(struct iris_inst *inst, enum platform_inst_f= w_cap_type cap_id); int iris_set_layer_bitrate(struct iris_inst *inst, enum platform_inst_fw_c= ap_type cap_id); +int iris_set_slice_count(struct iris_inst *inst, enum platform_inst_fw_cap= _type cap_id); int iris_set_properties(struct iris_inst *inst, u32 plane); =20 #endif diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2.c b/drivers/med= ia/platform/qcom/iris/iris_hfi_gen2.c index acc0ed8adda1..fcbebced05c3 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2.c @@ -12,6 +12,8 @@ =20 #define VIDEO_ARCH_LX 1 #define BITRATE_MAX 245000000 +#define MAX_SLICE_MB_SIZE \ + (((4096 + 15) >> 4) * ((2160 + 15) >> 4)) =20 static const struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] =3D { { @@ -937,7 +939,36 @@ static const struct platform_inst_fw_cap inst_fw_cap_s= m8550_enc[] =3D { .flags =3D CAP_FLAG_OUTPUT_PORT | CAP_FLAG_INPUT_PORT | CAP_FLAG_DYNAMIC_ALLOWED, .set =3D iris_set_layer_bitrate, - } + }, + { + .cap_id =3D SLICE_MODE, + .min =3D V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_SINGLE, + .max =3D V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_BYTES, + .step_or_mask =3D BIT(V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_SINGLE) | + BIT(V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_MB) | + BIT(V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_BYTES), + .value =3D V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_SINGLE, + .flags =3D CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU, + .set =3D iris_set_slice_count, + }, + { + .cap_id =3D SLICE_MAX_BYTES, + .min =3D 512, + .max =3D BITRATE_MAX >> 3, + .step_or_mask =3D 1, + .value =3D 512, + .hfi_id =3D HFI_PROP_MULTI_SLICE_BYTES_COUNT, + .flags =3D CAP_FLAG_OUTPUT_PORT, + }, + { + .cap_id =3D SLICE_MAX_MB, + .min =3D 1, + .max =3D MAX_SLICE_MB_SIZE, + .step_or_mask =3D 1, + .value =3D 1, + .hfi_id =3D HFI_PROP_MULTI_SLICE_MB_COUNT, + .flags =3D CAP_FLAG_OUTPUT_PORT, + }, }; =20 static const u32 sm8550_vdec_input_config_params_default[] =3D { diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_defines.h index 776b21cd11b2..226894b99dcc 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h @@ -71,6 +71,8 @@ enum hfi_rate_control { #define HFI_PROP_MIN_QP_PACKED 0x0300012f #define HFI_PROP_MAX_QP_PACKED 0x03000130 #define HFI_PROP_IR_RANDOM_PERIOD 0x03000131 +#define HFI_PROP_MULTI_SLICE_MB_COUNT 0x03000132 +#define HFI_PROP_MULTI_SLICE_BYTES_COUNT 0x03000133 #define HFI_PROP_LTR_COUNT 0x03000134 #define HFI_PROP_LTR_MARK 0x03000135 #define HFI_PROP_LTR_USE 0x03000136 diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/driv= ers/media/platform/qcom/iris/iris_platform_common.h index c9256f2323dc..ad9f2b20cd90 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_common.h +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h @@ -88,6 +88,18 @@ struct tz_cp_config { u32 cp_nonpixel_size; }; =20 +struct platform_inst_slice_caps { + u32 max_slices_per_frame; + u32 max_slice_frame_rate; + u32 max_mb_slice_width; + u32 max_mb_slice_height; + u32 max_bytes_slice_width; + u32 max_bytes_slice_height; + u32 min_hevc_slice_width; + u32 min_avc_slice_width; + u32 min_slice_height; +}; + struct platform_inst_caps { u32 min_frame_width; u32 max_frame_width; @@ -183,6 +195,9 @@ enum platform_inst_fw_cap_type { LAYER3_BITRATE_HEVC, LAYER4_BITRATE_HEVC, LAYER5_BITRATE_HEVC, + SLICE_MODE, + SLICE_MAX_BYTES, + SLICE_MAX_MB, INST_FW_CAP_MAX, }; =20 @@ -315,6 +330,7 @@ struct iris_platform_data { const u32 *inst_iris_fmts; u32 inst_iris_fmts_size; struct platform_inst_caps *inst_caps; + const struct platform_inst_slice_caps *slice_caps; const struct tz_cp_config *tz_cp_config_data; u32 tz_cp_config_data_size; u32 num_vpp_pipe; diff --git a/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c b/drive= rs/media/platform/qcom/iris/iris_platform_vpu3x.c index 2c63adbc5579..6e44bed5ebff 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c +++ b/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c @@ -12,6 +12,18 @@ #include "iris_vpu_buffer.h" #include "iris_vpu_common.h" =20 +static const struct platform_inst_slice_caps default_slice_caps_vpu3x =3D { + .max_slices_per_frame =3D 128, + .max_slice_frame_rate =3D 60, + .max_mb_slice_width =3D 4096, + .max_mb_slice_height =3D 2160, + .max_bytes_slice_width =3D 1920, + .max_bytes_slice_height =3D 1088, + .min_hevc_slice_width =3D 384, + .min_avc_slice_width =3D 192, + .min_slice_height =3D 128, +}; + #include "iris_platform_qcs8300.h" #include "iris_platform_sm8550.h" #include "iris_platform_sm8650.h" @@ -110,6 +122,7 @@ const struct iris_platform_data qcs8300_data =3D { .inst_iris_fmts =3D iris_fmts_vpu3x_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(iris_fmts_vpu3x_dec), .inst_caps =3D &platform_inst_cap_qcs8300, + .slice_caps =3D &default_slice_caps_vpu3x, .tz_cp_config_data =3D tz_cp_config_vpu3, .tz_cp_config_data_size =3D ARRAY_SIZE(tz_cp_config_vpu3), .num_vpp_pipe =3D 2, @@ -139,6 +152,7 @@ const struct iris_platform_data sm8550_data =3D { .inst_iris_fmts =3D iris_fmts_vpu3x_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(iris_fmts_vpu3x_dec), .inst_caps =3D &platform_inst_cap_sm8550, + .slice_caps =3D &default_slice_caps_vpu3x, .tz_cp_config_data =3D tz_cp_config_vpu3, .tz_cp_config_data_size =3D ARRAY_SIZE(tz_cp_config_vpu3), .num_vpp_pipe =3D 4, @@ -176,6 +190,7 @@ const struct iris_platform_data sm8650_data =3D { .inst_iris_fmts =3D iris_fmts_vpu3x_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(iris_fmts_vpu3x_dec), .inst_caps =3D &platform_inst_cap_sm8550, + .slice_caps =3D &default_slice_caps_vpu3x, .tz_cp_config_data =3D tz_cp_config_vpu3, .tz_cp_config_data_size =3D ARRAY_SIZE(tz_cp_config_vpu3), .num_vpp_pipe =3D 4, @@ -205,6 +220,7 @@ const struct iris_platform_data sm8750_data =3D { .inst_iris_fmts =3D iris_fmts_vpu3x_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(iris_fmts_vpu3x_dec), .inst_caps =3D &platform_inst_cap_sm8550, + .slice_caps =3D &default_slice_caps_vpu3x, .tz_cp_config_data =3D tz_cp_config_vpu3, .tz_cp_config_data_size =3D ARRAY_SIZE(tz_cp_config_vpu3), .num_vpp_pipe =3D 4, @@ -240,6 +256,7 @@ const struct iris_platform_data x1p42100_data =3D { .inst_iris_fmts =3D iris_fmts_vpu3x_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(iris_fmts_vpu3x_dec), .inst_caps =3D &platform_inst_cap_sm8550, + .slice_caps =3D &default_slice_caps_vpu3x, .tz_cp_config_data =3D tz_cp_config_vpu3, .tz_cp_config_data_size =3D ARRAY_SIZE(tz_cp_config_vpu3), .num_vpp_pipe =3D 1, --=20 2.34.1