From nobody Fri Jul 24 21:29:08 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78DDB3C5DB8; Fri, 24 Jul 2026 11:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784892591; cv=none; b=sM8ctcTCZp5KkRtNLHZCTKCJlrE+1v4gHUI5Lw1Lb+6Stw6/KifpPEnJg1qOCVmNoQZ7qOMsFRiatUsx9MR55XfLpYkNVduJHYQwfHptRgL5CakdsgOZSSLQ58+TVxkwW9kch5IZ73qeLnu8pNJRjELTbFhjKJC5zImOrQ9aQWc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784892591; c=relaxed/simple; bh=QCNui0KdBUBlrUWMOvfLZPo+juF8+67R6ju1Xq6ckwY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f+9VCDVakqx65YWtvm9BFGMrDOQTwnKCV7A1crdelDu4HBsS8nnqmTnQxC5u3Imnnw8OHErWW8qWAY0gLRr2fbX69nPVTQnx4O5JKUdjOnl9vOTKhhBAKnLBuZ2RMQmghvceH+7p3PEdoHdAVY9E+4Jhc0/7NAx0VM5P0RdBmzA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qMHwzkMy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qMHwzkMy" Received: by smtp.kernel.org (Postfix) with ESMTPS id F3CF3C2BCB3; Fri, 24 Jul 2026 11:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1784892591; bh=QCNui0KdBUBlrUWMOvfLZPo+juF8+67R6ju1Xq6ckwY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=qMHwzkMyfHk9GVFuq1m4wW768y12QTwcZ7n6tv2WIJDODi6Vru3WaJbx0DKXFPJj0 NQ07XtAss5OsoaAAV7OwjTpy1U0S3O1OR9U2wLLhPTwTPUxJcQ6iJYLEtHuTaHdS9T UvLNw3YLK+7bSa1ogD+nKoKIAYkrk93FOpXz6DGP4R9N1kWnUsT6/YKawVPGKXpCbE yNJMB7OWA1mIEAFJDfrz6xL3BB2oHPeavHIPnJZ8q4JsuoQwp+oxmdiij1/Iu+Rkpj bpoFCrKSQc+1NVXMqQlrC2sL4kUkFbmUIe/IoRsyEhtQaqgm5cx73+bLX5d6YNQ9/T /HaQLXBg5F85w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD308C531C9; Fri, 24 Jul 2026 11:29:50 +0000 (UTC) From: Roman Vivchar via B4 Relay Date: Fri, 24 Jul 2026 14:07:06 +0300 Subject: [PATCH v2 1/3] dt-bindings: nvmem: mediatek: efuse: add mt6572 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260724-6572-nvmem-v2-1-e58d16a29621@protonmail.com> References: <20260724-6572-nvmem-v2-0-e58d16a29621@protonmail.com> In-Reply-To: <20260724-6572-nvmem-v2-0-e58d16a29621@protonmail.com> To: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Andrew-CT Chen , Lala Lin Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Roman Vivchar X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784892588; l=1007; i=rva333@protonmail.com; s=20260510; h=from:subject:message-id; bh=nuU2fNRtn+r/1kk0ZhaxODdhDU8esK5VbNO0Kcgpgoo=; b=L7tqSgdl8MY1vNgqq/ul9NO03Q0TCsUnTzMob6hp3Yy4Mx4UQUiDE/B3LwCI20vNjI1yVegg1 /KKiTFFTEutBVk43yW+QBtzbo8gwO/LwZCq1UKhQnoRJ0/ze+uL8+R6 X-Developer-Key: i=rva333@protonmail.com; a=ed25519; pk=zww/nWjBGoQ4POXCG0BV6fx2iuXK6jx77rsKPA5YK5Y= X-Endpoint-Received: by B4 Relay for rva333@protonmail.com/20260510 with auth_id=777 X-Original-From: Roman Vivchar Reply-To: rva333@protonmail.com From: Roman Vivchar Add a compatible string for the mt6572 SoC efuse controller. Signed-off-by: Roman Vivchar --- Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/= Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml index f9323b3ecfc8..e10947164941 100644 --- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml @@ -24,13 +24,16 @@ properties: =20 compatible: oneOf: + - enum: + - mediatek,mt6572-efuse + - mediatek,mt8186-efuse + - items: - enum: - mediatek,mt8188-efuse - mediatek,mt8189-efuse - mediatek,mt8196-efuse - const: mediatek,mt8186-efuse - - const: mediatek,mt8186-efuse =20 - items: - enum: --=20 2.54.0 From nobody Fri Jul 24 21:29:08 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78CD83BB669; Fri, 24 Jul 2026 11:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784892591; cv=none; b=KR/VKWvqZTr4kmWBToVeRiRyGDwAyx3HBfjIdaPnf9DssovVLdG0I2i1cnMkoOIFFneXT/OjFmz8V0zghviI+HrGyAwnWz5SLsAorU1MaCReqX9/HWFNCewGlkV39iCprzSqRWm/6YrgmkKPDKN5PclU2EGF2Q2fm3YubPMpgzg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784892591; c=relaxed/simple; bh=C8aXXQaFeWZmsrlMRRyh9TAsW3FMnEEDkAdARgX7WzM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nC/g45AZEm/J6jGZGUojNKqGYk4X/XFL6fBXEx3IDplzEUm8YL82uN2OEzORMXQ4xXk82RSCazWmgfNvATsr/lLGaZcuw9tzYNCRqwLFDdP+luGvWq0TAuhL1HMMiyagJ4DX6n1Z021vYoNAtBVcnY37U4gpHLagB2hgZXQ59Gc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IywIaAWd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IywIaAWd" Received: by smtp.kernel.org (Postfix) with ESMTPS id 0FA91C2BCF7; Fri, 24 Jul 2026 11:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1784892591; bh=C8aXXQaFeWZmsrlMRRyh9TAsW3FMnEEDkAdARgX7WzM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=IywIaAWdoc1GT6Us92RjWj9sQkc8PT7ppzysHqy8dqPiomNqe7PfyX1ZvYBVqbuQ7 SglkxSJqYGMZrpSSakSxg8vMjoDDbc7FMjCC7KegwzecLWxWoczYyqrNlj/3zRo9ai 40xNOBM/Jpcts0jQMLeYrsai0ZG4gI8WIe7eyzv1xGf44+bGS5DX6CxayVbQgoNocm jxfHMdAyDpPJf/UlbkIyM3pq4zWFeAN4/Mc4meFmt4dEnrDSyqXVzbE0FVw/7Wl/It Jfe95a4Ru7DThWtryqdhItSWvd/RBGZcl6ws0Hr68xE6ONxv46XSeBdiNly6NwComR BSA5mJNm1e0Mg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFF25C531FC; Fri, 24 Jul 2026 11:29:50 +0000 (UTC) From: Roman Vivchar via B4 Relay Date: Fri, 24 Jul 2026 14:07:07 +0300 Subject: [PATCH v2 2/3] nvmem: mtk-efuse: add support for 32-bit aligned reads Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260724-6572-nvmem-v2-2-e58d16a29621@protonmail.com> References: <20260724-6572-nvmem-v2-0-e58d16a29621@protonmail.com> In-Reply-To: <20260724-6572-nvmem-v2-0-e58d16a29621@protonmail.com> To: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Andrew-CT Chen , Lala Lin Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Roman Vivchar X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784892588; l=2506; i=rva333@protonmail.com; s=20260510; h=from:subject:message-id; bh=ylH/IgEJCVkseD04fa7EwlxtvDcFp1eXUc9OswjHzzs=; b=/8VB81TrG8SjFb9w55sRRen2VjLM+hfW97QRD/CaBKXKSzGpXGhXDnsueEA8V3wSIRvkPK73X S1jMcqsdLFLAhCz05D9HEVfK5BBKrQv7ApW0EVDtZgNR1mivuqBywOe X-Developer-Key: i=rva333@protonmail.com; a=ed25519; pk=zww/nWjBGoQ4POXCG0BV6fx2iuXK6jx77rsKPA5YK5Y= X-Endpoint-Received: by B4 Relay for rva333@protonmail.com/20260510 with auth_id=777 X-Original-From: Roman Vivchar Reply-To: rva333@protonmail.com From: Roman Vivchar Some MediaTek SoCs, such as mt6572, don't support 8-bit reads, leading to zeroes or garbage data. 32-bit aligned reads must be used instead. Introduce a 'mtk_reg_read_aligned' helper to enforce 32-bit aligned register access. All reads will be performed by reading 4-byte words and masking them. Signed-off-by: Roman Vivchar --- drivers/nvmem/mtk-efuse.c | 35 ++++++++++++++++++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c index af953e1d9230..178b9d85f813 100644 --- a/drivers/nvmem/mtk-efuse.c +++ b/drivers/nvmem/mtk-efuse.c @@ -4,6 +4,7 @@ * Author: Andrew-CT Chen */ =20 +#include #include #include #include @@ -14,12 +15,37 @@ =20 struct mtk_efuse_pdata { bool uses_post_processing; + bool needs_aligned_read; }; =20 struct mtk_efuse_priv { void __iomem *base; }; =20 +static int mtk_reg_read_aligned(void *context, + unsigned int reg, void *_val, size_t bytes) +{ + struct mtk_efuse_priv *priv =3D context; + u8 *val =3D _val; + u32 i, pos, shift, val32; + + for (i =3D 0; i < bytes; i++, val++) { + pos =3D reg + i; + + /* + * Read on 32-bit word boundary or if it's the first + * iteration + */ + if (i =3D=3D 0 || IS_ALIGNED(pos, 4)) + val32 =3D readl(priv->base + (pos & ~3)); + + shift =3D (pos & 3) * 8; + *val =3D (val32 >> shift) & 0xff; + } + + return 0; +} + static int mtk_reg_read(void *context, unsigned int reg, void *_val, size_t bytes) { @@ -82,7 +108,12 @@ static int mtk_efuse_probe(struct platform_device *pdev) econfig.add_legacy_fixed_of_cells =3D true; econfig.stride =3D 1; econfig.word_size =3D 1; - econfig.reg_read =3D mtk_reg_read; + + if (pdata->needs_aligned_read) + econfig.reg_read =3D mtk_reg_read_aligned; + else + econfig.reg_read =3D mtk_reg_read; + econfig.size =3D resource_size(res); econfig.priv =3D priv; econfig.dev =3D dev; @@ -103,10 +134,12 @@ static int mtk_efuse_probe(struct platform_device *pd= ev) =20 static const struct mtk_efuse_pdata mtk_mt8186_efuse_pdata =3D { .uses_post_processing =3D true, + .needs_aligned_read =3D false, }; =20 static const struct mtk_efuse_pdata mtk_efuse_pdata =3D { .uses_post_processing =3D false, + .needs_aligned_read =3D false, }; =20 static const struct of_device_id mtk_efuse_of_match[] =3D { --=20 2.54.0 From nobody Fri Jul 24 21:29:08 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78C043B95FA; Fri, 24 Jul 2026 11:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784892591; cv=none; b=dgg1wut/utdBq4Xxw0kxmkRGISEPnJ+pszNPRpZ5T3UEsFAk1Hse223pVOVl8G1ydIP0gYoafp1/uqhGXUr1ELc4O7z+CdlMvjY4Tuq+JzLlPknCj+738zJXFCuij1ZO4wldvG0U3+UDRbZd5Fi8m9rh9pzkbdM3xYFCXZJT8+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784892591; c=relaxed/simple; bh=sLUm6phXL6/UN6hHVSZAI3vFakeEUucBJVxBRFM0FRs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Duf8lMTHsKZY7rmemMTZl3c7wGuS5yKsYNNBpR+J/5/Fn1qB4Y+8sq7O0snRBidUSd/BlpT63egLl/HQgKqhrMYZUo6CRDa7+PL99HEYNcEDIb2xH9SSzKZ8AGqYRoU438rA5k7+BuhZBdTzgWzpQspmwbYpAFobo4/vL+yY0a8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Kq6cNYrZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Kq6cNYrZ" Received: by smtp.kernel.org (Postfix) with ESMTPS id 1CCA9C2BCFC; Fri, 24 Jul 2026 11:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1784892591; bh=sLUm6phXL6/UN6hHVSZAI3vFakeEUucBJVxBRFM0FRs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Kq6cNYrZXLDdgj4cQVUVVXvSGvKz6s0oupShUkrT+n20G1MWau2aKGgoF08H+VUg6 8wESZ8bKhIfTT7OWxB6WDwg2Jf76vPQPeNupd2NNnnbdvDDlnEAmXdnJ/mqzUH+wn6 hStZkl9Gg8jgcmjXIZ2IpTBBbi6LSnIDSu5XkEZddXwDnrrkCh1cgpbwC4ZUoztIV3 aEj0zxySeSStf7fm1FHWIc4sd0jk9u0e3lc+yeYK2z+DD8hr0/mvJ95ZRSwfGol5It o6STaWaciVB7i0ZgQXDJ7s7tpmFlHANB1snDZ6NViSUM/84eWRNto9bxxKRxv7WIJh zx4uEeYMMtVnA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id F29B9C53209; Fri, 24 Jul 2026 11:29:50 +0000 (UTC) From: Roman Vivchar via B4 Relay Date: Fri, 24 Jul 2026 14:07:08 +0300 Subject: [PATCH v2 3/3] nvmem: mtk-efuse: add mt6572 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260724-6572-nvmem-v2-3-e58d16a29621@protonmail.com> References: <20260724-6572-nvmem-v2-0-e58d16a29621@protonmail.com> In-Reply-To: <20260724-6572-nvmem-v2-0-e58d16a29621@protonmail.com> To: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Andrew-CT Chen , Lala Lin Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Roman Vivchar X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784892588; l=1270; i=rva333@protonmail.com; s=20260510; h=from:subject:message-id; bh=RglpQMmDi1q9EkMmicGwenzoewTZeLQT6m7DchqK7Ko=; b=OG+XBny8CdCiVuq4629ceAWRfePgmdbdoWS9+9n5klQ1t9JF/yCDZvd60HdotyH/DS5WUwYPO wqPLyIAERdUCjZby1u73qvyf+KlLlX03yWanQDmO2yvcQxLMvbJZZRE X-Developer-Key: i=rva333@protonmail.com; a=ed25519; pk=zww/nWjBGoQ4POXCG0BV6fx2iuXK6jx77rsKPA5YK5Y= X-Endpoint-Received: by B4 Relay for rva333@protonmail.com/20260510 with auth_id=777 X-Original-From: Roman Vivchar Reply-To: rva333@protonmail.com From: Roman Vivchar Add a platform data struct for the efuse controller. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Roman Vivchar --- drivers/nvmem/mtk-efuse.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c index 178b9d85f813..99d061eef6e3 100644 --- a/drivers/nvmem/mtk-efuse.c +++ b/drivers/nvmem/mtk-efuse.c @@ -132,6 +132,11 @@ static int mtk_efuse_probe(struct platform_device *pde= v) return 0; } =20 +static const struct mtk_efuse_pdata mtk_mt6572_efuse_pdata =3D { + .uses_post_processing =3D false, + .needs_aligned_read =3D true, +}; + static const struct mtk_efuse_pdata mtk_mt8186_efuse_pdata =3D { .uses_post_processing =3D true, .needs_aligned_read =3D false, @@ -143,6 +148,7 @@ static const struct mtk_efuse_pdata mtk_efuse_pdata =3D= { }; =20 static const struct of_device_id mtk_efuse_of_match[] =3D { + { .compatible =3D "mediatek,mt6572-efuse", .data =3D &mtk_mt6572_efuse_pd= ata }, { .compatible =3D "mediatek,mt8173-efuse", .data =3D &mtk_efuse_pdata }, { .compatible =3D "mediatek,mt8186-efuse", .data =3D &mtk_mt8186_efuse_pd= ata }, { .compatible =3D "mediatek,efuse", .data =3D &mtk_efuse_pdata }, --=20 2.54.0