From nobody Fri Jul 24 21:52:26 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E25643E317C for ; Thu, 23 Jul 2026 21:56:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784843810; cv=none; b=Rh7uuAnlk2mfRcGNx+bY7xuov7xm5w4GVSHSXiLi0bNvBA9PhcERbKNVmmrNql7ElXyBa4V/c71WevrNeKAqlmGs5Nve6sS997Dfuf0C6bGZL4PjHfY0Dfex+Lt/SiD4GKNxq0cmV/iBDo3doqKypLSkKDtH5BQUaTT/nGFt1wg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784843810; c=relaxed/simple; bh=sgd+UDMAR0xiVT2O1rRObZpg48pJIQQItcB4PQGG0bM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oH2z3UmR8IdmQtsNtwey8X9SeSNhheAn0AWWf4agcZCNER6xQuNhZEYX89KzYIr0eQo7idq5+74JveZTZ8xfphzW7MkGAcFmvBr5ebGve+Qo6y4aayB5/EM67rVNupGcmZNVZyBPWBBB9+V8aECHqifEZ8wxeFXgyO8HuA5OgF4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FIL7o6dS; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FIL7o6dS" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-495590dde14so12856305e9.0 for ; Thu, 23 Jul 2026 14:56:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784843807; x=1785448607; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=HAi92VA2SD7K7c9DV5WSLgZJS336Z6mkG21G4rkyq80=; b=FIL7o6dSM+f5mt0O+z1LXFjcKC2GZrxGH4VjXJLEbPJuhQH6rRFZ4taG3daQLFtCDu 93wABox48odlorb6/Ww9qNUt0B4+o98+6Ee+m3Gz0/up3yVwRgQ8oZo0r6oC1dExQaUk Jza/X+smAwwEBHqVMe61iP1lVdzeWuNJtWUpkDDV0RkUQHojvMA/HZ02632oio6mjsp3 XrFrQMIUVpAv+JLYeI+SfBSteTRXUR+myFEGRZcFTv3sb5RdYwYPWupfs3Mf5Iy+4mrV s8IiPqmOjxFUfsv2mRQKn5nr8iDYzxM7oUXpZeKmQxI2ea9gNb93Vo3vPJXcSuuubDIL q64w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784843807; x=1785448607; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HAi92VA2SD7K7c9DV5WSLgZJS336Z6mkG21G4rkyq80=; b=oKddQi6C0xZaSLg5jQ5Xm72oD3dBtsrduqyCED5xGZ5XEG27Bp4KLJldUwOO+8bT6Y mJiejoFgIgrwoSWFPtWAjJ0KmPIrSSf0WTO0yVs4DKNGSfA1IA58yeAPad6Wt77H61Ss sBuXY45eWMysNwm61fzoGJh/BQ/8fL6udX6Oo5K11WUtbUv+qI+x/J8QNqjF6UPUwEqe fnmc38GYZT6iVo8w0JWWXutY2hMOqpy+t/4qpC89iPCcvqCpDrQkhbqVxhIYDN1FBPbM s60IkFQ1ATeyXJkHF4uW7+tULngpIiTNtxngFBVTHo/Ag7hDXMokEKH04DUF/nU+9VxQ CQmw== X-Forwarded-Encrypted: i=1; AHgh+RrKkAqBqrIBBUq6PKY+JGRXkixJ+DSW8nVQfuteyxF02a7xAZQvkUbUWQYidX+4QXzqY3zCc2YWDiQ+8PU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywi0lFw8Zb+rZiT6Y05N2uqRdVdTqBrnQoXQRMYVqf/u6y6CEjU rwZKsGe8fYsQyzbMIJdVUoljkCyD6HXDqPAOIh5xwZgciYb68kkhvajs X-Gm-Gg: AR+sD1366fqNVgckDgcz8q0oSWNCpVPs6erz/Bh1CPU8GRMlZZVKixPFDPmFZgSximm UNxqkJj0wldxfU1ZyKYuSZobGR4hFTAu+2/2V2eD7CRthzxsrcEmjzjNy0CWggl+KmUBGoYWCYl jGnWXDFiq5QDaX8/oO9UbZtL83kGKJLr+PxlLgrYiSoWzLUhYzvMQKLBuF+GKpQYeIU7zVDH52l YV/2b/iizLCuIPbXgzHYe0/c/RkfwOkMq/ZHncoNxRwTnvy0YIpZ3r+6YvO1QH2OyqMRW/SkbuN qULgKmeDeFgSOrPl6g2ajj9g1Vamjmg6FcR6CiNgJWg+iz5DheG+qqaDmIkUY9UzYJvPphnksPu kARHpbPB4A5LNHi5aakuJ6FkEkPjm418KN98YFU1Xt3NRIkLuU2fRJFK9e/DzkSLAEu0J5hyDsR 1aLYTDP40= X-Received: by 2002:a05:600c:548a:b0:495:641a:fffe with SMTP id 5b1f17b1804b1-49573d20b86mr55776255e9.39.1784843806865; Thu, 23 Jul 2026 14:56:46 -0700 (PDT) Received: from 192.168.122.229 ([115.187.36.104]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85c67339sm19856884f8f.31.2026.07.23.14.56.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 14:56:46 -0700 (PDT) From: Joyeta Modak To: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, Joyeta Modak Subject: [PATCH] staging: greybus: audio_manager: add missing newline in sysfs_emit Date: Fri, 24 Jul 2026 03:26:10 +0530 Message-ID: <20260723215610.700701-1-joyetamdk@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" sysfs should return a newline at the end of the output buffer. The missing '\n' is added to all sysfs_emit() calls in audio_manager_module.c to follow the sysfs convention in Documentation/ filesystems/sysfs.rst Found using ./scripts/checkpatch.pl --strict Signed-off-by: Joyeta Modak --- drivers/staging/greybus/audio_manager_module.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/stagi= ng/greybus/audio_manager_module.c index dc90cc2d2308..5737f2a32f5a 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj) static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *m= odule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%s", module->desc.name); + return sysfs_emit(buf, "%s\n", module->desc.name); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_name_attri= bute =3D @@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_= module_name_attribute =3D static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *mo= dule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.vid); + return sysfs_emit(buf, "%d\n", module->desc.vid); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_vid_attrib= ute =3D @@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_= module_vid_attribute =3D static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *mo= dule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.pid); + return sysfs_emit(buf, "%d\n", module->desc.pid); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_pid_attrib= ute =3D @@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_a= udio_manager_module *modu struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.intf_id); + return sysfs_emit(buf, "%d\n", module->desc.intf_id); } =20 static struct gb_audio_manager_module_attribute @@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct g= b_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.ip_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices); } =20 static struct gb_audio_manager_module_attribute @@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct g= b_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.op_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.op_devices); } =20 static struct gb_audio_manager_module_attribute --=20 2.53.0