From nobody Fri Jul 24 21:52:33 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12F553E63A4 for ; Thu, 23 Jul 2026 21:34:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784842455; cv=none; b=EwL7CiPVK5b8hlNQaevThKV9YAkqfxacWXr6FfF/t8gRlbS2vbQykgG5vXvXVghLoBYn7VaGnSrnz8NFEzyapIAfYT1KJIrS5aqFVIs02hCGYDBmBKnrvAOog/cs3WgtpQzrRA9Nyu+kxHb8itaNjlugs4j5pSnrO/evDSPF3Ic= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784842455; c=relaxed/simple; bh=U4lu+M2evacu4iV52HG7sgsXv1EjpJNk/sLV4luwukc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LAi+tG5yNoB/qf5ewc/oampN2rKOKNf4/dQIf+aFRlU119BQVnUhR6CKIttTJOR+FJnj0Z3gKRxulwvM+XJJxsfTGKT8O/9pcjljsp/j9Gw5fYMgbWJziZ7p0l8FzOPBXvf+wmRAKS4gQRinAaVXSsxmLglzDc0g9tLv8NktPSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oDKxorSS; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oDKxorSS" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38dfe7eb825so927760a91.0 for ; Thu, 23 Jul 2026 14:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784842453; x=1785447253; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Uxzls0OuG9o189IXrTra88llMHOit8dFMSaDNzXEdkU=; b=oDKxorSSg76cfKmYYWegq2auAjvzX8ilbniK2jzgQ89pOU1n9vwqXQaLp7vil/Ts0+ fxyldXbNqr/a306A6zzLn6XP3xfctIO+50Y5WC/eCfmsi4fGOjJLn9cXgj95/95e1VzY pCp2acxlLaQAwl4C4nIANDEnYuuOWQGihhvjQsK7Xs0JlfoO+lr6TjCs1CYUfgFPDPL0 8OkdKbwzhyPTl93/iH7/HG+ClwfjsCKp+IzKLlmFNK6qs4SemGFIyIX5PsPTX21sIQ3b yjFE9P5oIJHDNQBMbDyiNtzsWD6VKYy9e4l10PbWVRaCjs6C0/NHPzCgJjesj/aZ6AZb wTzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784842453; x=1785447253; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Uxzls0OuG9o189IXrTra88llMHOit8dFMSaDNzXEdkU=; b=FW02Dv2KQoFsSf/Y8foI2ycSvU3yOp13n+0R3MjOoLSikfPbOr0gVFVvB/spQPVqlp mdJq5wdQ9kwxRFgx4ha3UKPdfo3h/HH00F6Z7A6mGSujTnHQllDXksz20Ljpt1gInxth 8LQR+53bwzaT+4ZfoVNXyvTqV3Tw7edLzccUuUMphcB+puwDKfpK6k6cJyBDhyeY6e6O /eCuemxvzxkiFGKe0EJqeti7Cag5bxUeY7e7wAmXz9zpcxVR+zXqC+XRryi8vXaaaSpG pfoU6drBBL5yk86FG7ebx9eSfEh7mLGEV8oBYJ9Cf1ywTdxl0w5Hyl4qibQtksWbbSrT f/VA== X-Forwarded-Encrypted: i=1; AHgh+RoRaxUqtoK+ZXkjIQzGIxwWIBhIog1oVx1PXIiLBy6lAedRRacJWcfYzo81AQdfucTf1m6jY6Uy7QmlZEQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwT5GX9wteqLAwbclI2bJ/nEVOAJaN7e71RMwVCKXjXcYma8Ye3 a7tanbMUMwddKGxC8xCQCVAoKwzcY2nAPGCbu4w3nuo4RUmoKZqdr5ZEj04zzgQX X-Gm-Gg: AR+sD10zSfTkjU3uuPnECXeQq8x4aCkf+xSefkUmdNo7E/SiXHsVbRFpmxRHtmpaDqs 9M9mkYjSuZT7ohbWJjaw4b1/sm0kUFlV36ir6UWGNcQHvp40dNmYods/QX3v1pJis53h/B23emx 94m5dv/l2jTvuiThc8qmmXh1abT5mQyhrmDp44wsYt+C8w6QNnb1l+GAXQv7lWHX/hBd0MW9rWN QujCTQnHgFMktkgWDCuLIyKrHIqvGe9FLf9pQk8yB++nuxTOYZR/Zd4BHYL23fSmgOhzMo6xAmk vcgeuAWIhiFG96cMAh/hFRuS2nQWxC9qL1Wco2WH8SU9BT+nkS4xQpPv+e0OcshXmqD1GylGovT 7ERC7JQgydiV5/Slq+Eko4gB7+95pNY4jiYYx8f4yxQsOE81jfsXLxWo/zUYVk28HnmZTGlOQOj /lLzgk4vWFF1b/yBQ= X-Received: by 2002:a17:90b:1c01:b0:38e:6ba9:5203 with SMTP id 98e67ed59e1d1-38ec658e6bcmr4830738a91.22.1784842453309; Thu, 23 Jul 2026 14:34:13 -0700 (PDT) Received: from arch-btw.lan ([70.93.178.248]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13d13003f12sm31604353c88.2.2026.07.23.14.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 14:34:12 -0700 (PDT) From: Tony Sanchez To: Greg Kroah-Hartman Cc: Dave Penkler , Dan Carpenter , kernel test robot , stable@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] gpib: ines: fix I/O region leak in ines_isa_attach() error path Date: Thu, 23 Jul 2026 14:25:45 -0700 Message-ID: <20260723212545.2397641-1-tonybanters@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If request_irq() fails after request_region() has succeeded, ines_isa_attach() returns without releasing the I/O region. This leaks the region and prevents a subsequent attach attempt from acquiring it. Release the region on the failure path. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202605271229.d8wGTffx-lkp@intel.com/ Fixes: e6ab504633e4 ("staging: gpib: Destage gpib") Cc: stable Signed-off-by: Tony Sanchez --- v3: Fix From: header to real name (was overridden by git config in v2). v2: Use real name in Signed-off-by (Greg KH). drivers/gpib/ines/ines_gpib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpib/ines/ines_gpib.c b/drivers/gpib/ines/ines_gpib.c index c000f647fbb..cb6ee6882a0 100644 --- a/drivers/gpib/ines/ines_gpib.c +++ b/drivers/gpib/ines/ines_gpib.c @@ -911,6 +911,7 @@ static int ines_isa_attach(struct gpib_board *board, co= nst struct gpib_board_con nec7210_board_reset(nec_priv, board); if (request_irq(config->ibirq, ines_pci_interrupt, isr_flags, DRV_NAME, b= oard)) { dev_err(board->gpib_dev, "failed to allocate IRQ %d\n", config->ibirq); + release_region(config->ibbase, ines_isa_iosize); return -1; } ines_priv->irq =3D config->ibirq; --=20 2.54.0