From nobody Fri Jul 24 21:52:57 2026 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42EEF2931D2 for ; Thu, 23 Jul 2026 21:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784840429; cv=none; b=Euxf59HGE2Tl97aS4/ufu7m0wa4tRYXNl+qm1IY5aYl6+lP3O/vi2Zz+jtD9CgUvXt3NVWweJ55/jyGZj8zeDBz8AmnZ4lN3Njo3/vRLs8B1YPHIV1fBD3MYH4lLzZETd2uEi0dxvq++cohN//njNi92Ro0+HEMjJ2cUWsKKAmw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784840429; c=relaxed/simple; bh=cpkiJ6XPqTQFQCbxQk2CEDR3yIej3gs8P/e4DPaTv0c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bYuMvsAyusSOkPW6MmP+MJiG5I/IWL2NcZgfgPk+f1D2tsv3gzpNAXy89H0vRsBNZpd2BZbU3ZBSQAVsd1tGiiAiRTZ5aJLxDfi0E1LHAennfOgGx45y2DNWL90ZWszay3L+vzp0gnakbZd1ivi1Vhly7SU1/E92fA926kp9zqc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=noZFla2K; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="noZFla2K" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c9eefcf9175so1044352a12.3 for ; Thu, 23 Jul 2026 14:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784840427; x=1785445227; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=YVNbyiH3PI2+SYSNjKe+1+IrASeNNJwVszOZP3uvdpc=; b=noZFla2KKE5tjFU1TqseadtfKhWh7R9z0APCm8FHD6gP1tx2VO6jk74DFKunI4b9GA W8lSH4lUUTQz6n0qKRiPSu02cbg1XVt8q1WEX9cdJJmlXyz9j1TbQWzFvuYu64m9D3oB Z/pnQplXUeGLdui7RH/23DnFEOY9s1NIT/jzYGRxhpnka2Ipje2BUTZOIYfqnKkV18N8 X9INR5aLtMBCDVT/IRelT1t5KbhW/ybDo3kYJYjb34EeQaUOGVefwmZofCmCmczNDTyS BHHbsYF7RKRVvd0H85alRvxP3jSF6Fy72Z1VdSVhBIydigBpzFhAhFEE+8XqmWDu+xBr elVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784840427; x=1785445227; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YVNbyiH3PI2+SYSNjKe+1+IrASeNNJwVszOZP3uvdpc=; b=qlNnvuXGJxm60Ew+nmEypWFNLjUMwHjlRlSCtWJKx86dA3SiL4No9moqOM9WiOnD7f qqm7Auj+ZBNJdrNGKPNLwDTkWGvkMThLYO2yaG1Y9cgOnjdokMHna96hmpo8wNdAJrwM eCN3QxkEcSVM/daerf6cvPCKs2UGwXXwBPpqbhWhXt0TchWy5HbwxJs++g8WPgfTelg6 8LR0llj4qFJuYboi3prql6f1kGDBbUtVkusbRO+LjR5qTpEIrqME7KO1+y+iwlB7mkQt J8xFht/jEDOz89SGH4faWLtQKFbpHD+S3o03dXb0i7mmm+97pi4/0x+pHJpbSoKPGaKk ynCA== X-Forwarded-Encrypted: i=1; AHgh+Rr2UUzS1oGNGu0cgB0AL7vIvEal1ARMfCV7wMUNP4MCJlTBPPVUk16DhoVlyVGB+/ZhUUILV4ulL7cMPmU=@vger.kernel.org X-Gm-Message-State: AOJu0YwHpFFt7IKYj4RcCVd4uD/KFaKP4p0X8Ef+1l57G7AzT+CKecFp nJ75zgAJsrx3NnUtdnDTYy8bvSUgs/wmF8D+IGrxZwmLv/E/kjWg6O9U X-Gm-Gg: AR+sD11R4qqHUeQIIOsK3cAIjM9Po44kxFYYMFc7ZZzcUIawJy+wimeJfiMVJFZHHaZ P4TI6lI8b+MF2fxuVJV2RxNrgRpoxEpUZxm1j8l7i5OfPQtyY6sNQqxye9nvymQydg2S9E4Yc76 GGXh7qNfmjKMrD1CvmI+gmUD8ko0cWobpE5zjmYrZrAFt7xwvFW8xJ5vQR/H90cF0uC7iM/hYSC VAPnPNpe+v6IdARhWgNNBAhzl7rJ9DeozS23MTtk9U0ObxxuiwzYuaMLOlimhNFmu47/QwP/WFP VPAoJH5S+6tt9PJ7+mVsTdK3eTr5avDiktKOCiE0PkFjIHneq0Wi/lZXyhdUwM5izRFNUNW9C9V m8kgOzPCed5O6i6EvFb2Tr5ChWhThxpK+/cyOVF4uYHfiKC3+zdehDeEA0ORByS9T4KiO67qfHv +5LTyqmTDzsuk0Awg= X-Received: by 2002:a05:6a21:1519:b0:3c3:890f:6d7e with SMTP id adf61e73a8af0-3c44b18ac93mr5890998637.47.1784840427321; Thu, 23 Jul 2026 14:00:27 -0700 (PDT) Received: from arch-btw.lan ([70.93.178.248]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc1a6adsm21753031eec.6.2026.07.23.14.00.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 14:00:26 -0700 (PDT) From: tonybanters To: Greg Kroah-Hartman Cc: Dave Penkler , Dan Carpenter , kernel test robot , stable@kernel.org, linux-kernel@vger.kernel.org, Tony Sanchez Subject: [PATCH v2] gpib: ines: fix I/O region leak in ines_isa_attach() error path Date: Thu, 23 Jul 2026 13:56:57 -0700 Message-ID: <20260723205657.2391594-1-tonybanters@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tony Sanchez If request_irq() fails after request_region() has succeeded, ines_isa_attach() returns without releasing the I/O region. This leaks the region and prevents a subsequent attach attempt from acquiring it. Release the region on the failure path. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202605271229.d8wGTffx-lkp@intel.com/ Fixes: e6ab504633e4 ("staging: gpib: Destage gpib") Cc: stable Signed-off-by: Tony Sanchez --- v2: Use real name in From/Signed-off-by (Greg KH). drivers/gpib/ines/ines_gpib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpib/ines/ines_gpib.c b/drivers/gpib/ines/ines_gpib.c index c000f647fbb..cb6ee6882a0 100644 --- a/drivers/gpib/ines/ines_gpib.c +++ b/drivers/gpib/ines/ines_gpib.c @@ -911,6 +911,7 @@ static int ines_isa_attach(struct gpib_board *board, co= nst struct gpib_board_con nec7210_board_reset(nec_priv, board); if (request_irq(config->ibirq, ines_pci_interrupt, isr_flags, DRV_NAME, b= oard)) { dev_err(board->gpib_dev, "failed to allocate IRQ %d\n", config->ibirq); + release_region(config->ibbase, ines_isa_iosize); return -1; } ines_priv->irq =3D config->ibirq; --=20 2.54.0