From nobody Fri Jul 24 21:52:56 2026 Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A59A3F39C2 for ; Thu, 23 Jul 2026 20:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784839337; cv=none; b=GO9IuKrIswGq+dxMLMACqTBZlrVd6TIleqs9EUhZJv2uZT+oF/GP8cJL7UD9taVWCUFec6kSWUqEnusZPkccyTGBvWobOEV7Z+NVT7viIrrX7ljggBvkVQyCIgi3pYwmN9KjIfzDkXgQnLaWVsPZt5XgL1GDlOJn0zGE1GgqPWY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784839337; c=relaxed/simple; bh=+/twtWfTOMAhvQXtQTU0c9mQP7LYwclosx+QVrgBKN4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=r87yifxRRt1qHEMz5S1WFXU+NXMoHPKkdaYKeUFna4Yv9B2Ll5oU/b7+V7MwKoGSMDfnAGAtgrnqHvl4Gxl27KjXXZB9JQFRikSasZTCJa2JmgilWrdu4EMWojaNSNrUserYRnf9GW9a0EkNYVVexYNPY+o52+76IP2grkygE2Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--praan.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ncE6mlBh; arc=none smtp.client-ip=209.85.214.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--praan.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ncE6mlBh" Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cfa55c9430so11230165ad.0 for ; Thu, 23 Jul 2026 13:42:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784839331; x=1785444131; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pIhtxPilZww/6qXFXyt6pCELZXv5C+7yA4sMxjjosZU=; b=ncE6mlBh2ns+yaHARn/oCjKCDqascBBByIQnKaGGHu90Z/ESkHl27iad/WYjD2C6PL F8ricuYxoi2som996RJwqe6ZBRH+sBEnRJ71C2gPSia/hyS2/DGr23V3kOG8ntNL1WXG Wd130xvm6iOS3Dhobxm1vHS7oZYm3NV2wUvS+46UwfuT/UJf92ZVjNiFEeVkAl3755o6 E6X69MhFn2ku+9fkbUGhIXxPScsarQ47Jis9dTgZ8bo4UM+3Y7X3tC2Ca4txA3wMq+cA kPwCHeNZRPuZ5k9vxazO/W3BzJ2eQFNkfNQnOXRpasMNRr+gWoQ3W2rKL9o54xqCOz5O BPfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784839331; x=1785444131; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pIhtxPilZww/6qXFXyt6pCELZXv5C+7yA4sMxjjosZU=; b=YRvU8aCsc6gLjyO2VhqlZeNJTRdDS9EMvtujV3nXANSUwUJIi9p7XQ0kK9WhnPNkoy WNS0jn91UDHGFOTwHrprownWNi6hYZJ89OwGQJE2lNlGle9nntE6QzsW8fTF0RsAVEF/ R2hzOkk498waVr3tkXbU1QWpV+8gjR2jAwOBFNDyH/b0hxZhJdcU0ZIvLxzFMN9osrmg n34UUdJwi1cdMD+3yVITXkqUbrSPz+8CyGVY2V/7TlZNFc0GEYJjO4eH1nMdt7eoBNKB odpZa3wQXhHGiF4qJZQqUAE81m6LvORvUZioGyJXrG1nSrmUHUFBgSe6nWIo7adg/Dr6 3bSQ== X-Forwarded-Encrypted: i=1; AHgh+Ro/JPVEtoGqH4qOQGc9ZaiWLMunsQbWi1h9BSypk1kc4OWhLzFADTicmcwsSUjrMGSBRzutmlJ7cQUTeBI=@vger.kernel.org X-Gm-Message-State: AOJu0YzvG4j1a5wASon+nng1+ZvTCHcOhn4E/EiWqTsCtVBHGjzXBvkW cCtY63HJAUPqO9WVcITLPFBs7Z9pLO9dVI/WKjEvZbj44UeIHcKlTFlEy9o5D1WISNRMvXkhkQL Lsg== X-Received: from plgi16.prod.google.com ([2002:a17:902:cf10:b0:2ca:f1f8:ea00]) (user=praan job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:d2c9:b0:2ca:6514:9201 with SMTP id d9443c01a7336-2cfa6b7a10dmr57623865ad.15.1784839330855; Thu, 23 Jul 2026 13:42:10 -0700 (PDT) Date: Thu, 23 Jul 2026 20:42:01 +0000 In-Reply-To: <20260723204203.2997395-1-praan@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260723204203.2997395-1-praan@google.com> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog Message-ID: <20260723204203.2997395-2-praan@google.com> Subject: [PATCH v3 1/2] kho: Introduce a helper to init high order pages From: Pranjal Shrivastava To: Mike Rapoport , Pasha Tatashin , Pratyush Yadav Cc: Alexander Graf , Samiullah Khawaja , David Matlack , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pranjal Shrivastava Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current KHO restoration logic assumes all multi-page blocks are split into independent 4KB pages. Break out a helper to prepare for supporting high-order non-compound pages. Extract kho_init_high_order_page() to handle the refcount pattern where only the head page is refcounted. Use the helper for folio restoration that requires a similar refcount logic. Reviewed-by: Samiullah Khawaja Signed-off-by: Pranjal Shrivastava --- kernel/liveupdate/kexec_handover.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_h= andover.c index 4834a809985a..e836efd98795 100644 --- a/kernel/liveupdate/kexec_handover.c +++ b/kernel/liveupdate/kexec_handover.c @@ -357,6 +357,24 @@ int kho_radix_walk_tree(struct kho_radix_tree *tree, } EXPORT_SYMBOL_GPL(kho_radix_walk_tree); =20 +/* For physically contiguous pages. */ +static void kho_init_high_order_page(struct page *page, unsigned int order) +{ + unsigned long nr_pages =3D (1UL << order); + + /* Head page gets refcount of 1. */ + set_page_count(page, 1); + /* Clear head page's codetag to avoid accounting mismatch. */ + clear_page_tag_ref(page); + + /* For high-order blocks, tail pages get a page count of zero. */ + for (unsigned long i =3D 1; i < nr_pages; i++) { + set_page_count(page + i, 0); + /* Clear each page's codetag to avoid accounting mismatch. */ + clear_page_tag_ref(page + i); + } +} + /* For physically contiguous 0-order pages. */ static void kho_init_pages(struct page *page, unsigned long nr_pages) { @@ -369,16 +387,7 @@ static void kho_init_pages(struct page *page, unsigned= long nr_pages) =20 static void kho_init_folio(struct page *page, unsigned int order) { - unsigned long nr_pages =3D (1 << order); - - /* Head page gets refcount of 1. */ - set_page_count(page, 1); - /* Clear head page's codetag to avoid accounting mismatch. */ - clear_page_tag_ref(page); - - /* For higher order folios, tail pages get a page count of zero. */ - for (unsigned long i =3D 1; i < nr_pages; i++) - set_page_count(page + i, 0); + kho_init_high_order_page(page, order); =20 if (order > 0) prep_compound_page(page, order); --=20 2.55.0.229.g6434b31f56-goog From nobody Fri Jul 24 21:52:56 2026 Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1BEB3F3268 for ; Thu, 23 Jul 2026 20:42:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.198 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784839339; cv=none; b=i6K5CgunkeQaWg+rVtfG2+65F1cxiey3srfnSTrSRrclquFMFo1yI3J47DsmRbJxGUiglI8d0V+y9m+9X6CKmYvKNVgm7HSnOQKUsP2YiE5jabg3hgSU45BSzvOpcKJCce/jrr3DDpitBnURq9+O6te8xz698rwGmbWLgGkBceQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784839339; c=relaxed/simple; bh=NN+xQUtDI4KNpKsix7cKbTTCoqJZbIAjWTxdmD8w/PE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=JCbzd98+3TUBbVGUEj9+DQ47APHlH0gVYstyEwv1kVgMLB24mpxX0rq4ySEJwXNiRAOlF7sv/pJWu8UZ4qA7aH5QK03ccgZEOgvVLFfnrkCK3xB0u/KOQd6WYBC84LjCi7HQnbfoM0eNDe2vybsYS/hTkqvSGjvA5MhvQXW0UkA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--praan.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=UmR8KUjV; arc=none smtp.client-ip=209.85.214.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--praan.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UmR8KUjV" Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cce14a21faso11831825ad.0 for ; Thu, 23 Jul 2026 13:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784839335; x=1785444135; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/sU7OskJpEHtaekLlZ/5Z4YIkxuA4+y1ea25Y5pF/Mc=; b=UmR8KUjVBR1Zh9ilE/ilUhBw+IbrSFPaNccEIRV5710DuJs7b0Yu4AEn57ydEL5EF5 /nkpTOkUY7nynT2oCjQGKnQK5UKsxL79A2Pmf+0U83GR27qrqRbVcnP/bRYSYiN8mtnj QKivJWfEBTFKr1Y53qlUPbx4/6TeDSAREbKSA+2NnpXmVhurNu3uvcpi2fxJhLyySe7Q Ja0onMAPIVPYfCMAHMQquZmyunOpcitbaiuRuIVuiGl3HeCreEe5VlYLUEsmD/Im6J2u E7btFmYNBTUjK90a50D6FTXjS4ZyJfsa/Rg1LuuyB0BRt+xaDkFkZx33Dfk43rhOgF1F FPoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784839335; x=1785444135; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/sU7OskJpEHtaekLlZ/5Z4YIkxuA4+y1ea25Y5pF/Mc=; b=fFOtGVIoAEmCdOByLUCY82fX03UOgRPztKQ+utqWf8aTJSNjePmQKekCQV+G6aoxzf 9i/YyQ0JPo0vceqwF0KYzrGF/tyr55nCVcAOe7dIvrFLJ+c1R96ZGD2LImyKBbtrIrES 9WLUsobD5R38VRwHdEROl/Riu3dy2QC/Xj9ALdstfyPOA7I3SKIyY2g6C53DDASf7dRr J6EWtZiDD6fS63YmVb/KuGZGlGE69jhfj9uZTtc2P99P/6OSk1UFWyUy7tfTz4VSu3nt pX9BeC6wFVecJCAUbEaMHGaAvhVOsPWOEHvnaz2edG5OXUBIRHILx4/zljmqTUX2lPQt eWIg== X-Forwarded-Encrypted: i=1; AHgh+RpMj8fxEWnr+m37UWXsR2Rf7JnPZvIOC9C11WeqS7iRepmrSAU618jGbK28aoNACIKg+OAINHLi0wCDtG4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+HKAplzjwQ5CHwpkB24YB/SghRuqpbqOYqWv1JztygP92A/z9 QTvTmiAIx84h3jbC1Y9CVnimctehQ2RYsFg+zbAB1YELNDkQ6TLtRc6ikoacUEE06YZa6p2Sasz 75g== X-Received: from plrs15.prod.google.com ([2002:a17:902:b18f:b0:2cc:ae2b:c324]) (user=praan job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:41c3:b0:2c9:fc0d:165b with SMTP id d9443c01a7336-2cfa9552729mr45540675ad.23.1784839334260; Thu, 23 Jul 2026 13:42:14 -0700 (PDT) Date: Thu, 23 Jul 2026 20:42:02 +0000 In-Reply-To: <20260723204203.2997395-1-praan@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260723204203.2997395-1-praan@google.com> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog Message-ID: <20260723204203.2997395-3-praan@google.com> Subject: [PATCH v3 2/2] kho: Introduce preserve/restore APIs for high-order pages From: Pranjal Shrivastava To: Mike Rapoport , Pasha Tatashin , Pratyush Yadav Cc: Alexander Graf , Samiullah Khawaja , David Matlack , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pranjal Shrivastava Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current KHO page preservation APIs (e.g. kho_preserve_pages) assume that multi-page blocks are split into independent 4KB pages during restoration. This is incompatible with high-order non-compound pages, such as DMA buffers, which must be restored with tail pages having a zero reference count. Introduce explicit preserve and restore APIs for high-order pages, which preserve and restore a high-order page block as a single unit, applying a refcount of 1 to the head page while leaving tail pages at 0. Rename the existing internal helper to __kho_restore_page() and consolidate the common restoration code into it. Signed-off-by: Pranjal Shrivastava --- include/linux/kexec_handover.h | 10 +++ kernel/liveupdate/kexec_handover.c | 101 +++++++++++++++++++++++++---- 2 files changed, 98 insertions(+), 13 deletions(-) diff --git a/include/linux/kexec_handover.h b/include/linux/kexec_handover.h index 8968c56d2d73..6e2c75b16209 100644 --- a/include/linux/kexec_handover.h +++ b/include/linux/kexec_handover.h @@ -22,6 +22,8 @@ bool is_kho_boot(void); =20 int kho_preserve_folio(struct folio *folio); void kho_unpreserve_folio(struct folio *folio); +int kho_preserve_page(struct page *page, unsigned int order); +void kho_unpreserve_page(struct page *page, unsigned int order); int kho_preserve_pages(struct page *page, unsigned long nr_pages); void kho_unpreserve_pages(struct page *page, unsigned long nr_pages); int kho_preserve_vmalloc(void *ptr, struct kho_vmalloc *preservation); @@ -30,6 +32,7 @@ void *kho_alloc_preserve(size_t size); void kho_unpreserve_free(void *mem); void kho_restore_free(void *mem); struct folio *kho_restore_folio(phys_addr_t phys); +struct page *kho_restore_page(phys_addr_t phys); struct page *kho_restore_pages(phys_addr_t phys, unsigned long nr_pages); void *kho_restore_vmalloc(const struct kho_vmalloc *preservation); int kho_add_subtree(const char *name, void *blob, size_t size); @@ -65,6 +68,13 @@ static inline int kho_preserve_pages(struct page *page, = unsigned int nr_pages) =20 static inline void kho_unpreserve_pages(struct page *page, unsigned int nr= _pages) { } =20 +static inline int kho_preserve_page(struct page *page, unsigned int order) +{ + return -EOPNOTSUPP; +} + +static inline void kho_unpreserve_page(struct page *page, unsigned int ord= er) { } + static inline int kho_preserve_vmalloc(void *ptr, struct kho_vmalloc *preservation) { diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_h= andover.c index e836efd98795..abe1a800fb27 100644 --- a/kernel/liveupdate/kexec_handover.c +++ b/kernel/liveupdate/kexec_handover.c @@ -393,10 +393,9 @@ static void kho_init_folio(struct page *page, unsigned= int order) prep_compound_page(page, order); } =20 -static struct page *kho_restore_page(phys_addr_t phys, bool is_folio) +static struct page *__kho_restore_page(phys_addr_t phys, unsigned int *ord= er) { struct page *page =3D pfn_to_online_page(PHYS_PFN(phys)); - unsigned long nr_pages; union kho_page_info info; =20 if (!page) @@ -410,17 +409,12 @@ static struct page *kho_restore_page(phys_addr_t phys= , bool is_folio) */ if (WARN_ON_ONCE(info.magic !=3D KHO_PAGE_MAGIC)) return NULL; - nr_pages =3D (1 << info.order); =20 /* Clear private to make sure later restores on this page error out. */ page->private =3D 0; + if (order) + *order =3D info.order; =20 - if (is_folio) - kho_init_folio(page, info.order); - else - kho_init_pages(page, nr_pages); - - adjust_managed_page_count(page, nr_pages); return page; } =20 @@ -432,12 +426,43 @@ static struct page *kho_restore_page(phys_addr_t phys= , bool is_folio) */ struct folio *kho_restore_folio(phys_addr_t phys) { - struct page *page =3D kho_restore_page(phys, true); + unsigned int order; + struct page *page =3D __kho_restore_page(phys, &order); + + if (!page) + return NULL; + + kho_init_folio(page, order); + adjust_managed_page_count(page, 1UL << order); =20 - return page ? page_folio(page) : NULL; + return page_folio(page); } EXPORT_SYMBOL_GPL(kho_restore_folio); =20 +/** + * kho_restore_page - restore a high-order page block. + * @phys: physical address of the first page. + * + * Restore a high-order page block that was preserved with + * kho_preserve_page(). + * + * Return: the head page on success, NULL on failure. + */ +struct page *kho_restore_page(phys_addr_t phys) +{ + unsigned int order; + struct page *page =3D __kho_restore_page(phys, &order); + + if (!page) + return NULL; + + kho_init_high_order_page(page, order); + adjust_managed_page_count(page, 1UL << order); + + return page; +} +EXPORT_SYMBOL_GPL(kho_restore_page); + /** * kho_restore_pages - restore list of contiguous order 0 pages. * @phys: physical address of the first page. @@ -457,10 +482,14 @@ struct page *kho_restore_pages(phys_addr_t phys, unsi= gned long nr_pages) while (pfn < end_pfn) { const unsigned int order =3D min(count_trailing_zeros(pfn), ilog2(end_pfn - pfn)); - struct page *page =3D kho_restore_page(PFN_PHYS(pfn), false); + unsigned int info_order; + struct page *page =3D __kho_restore_page(PFN_PHYS(pfn), &info_order); =20 if (!page) return NULL; + + kho_init_pages(page, 1UL << info_order); + adjust_managed_page_count(page, 1UL << info_order); pfn +=3D 1 << order; } =20 @@ -890,6 +919,51 @@ void kho_unpreserve_folio(struct folio *folio) } EXPORT_SYMBOL_GPL(kho_unpreserve_folio); =20 +/** + * kho_preserve_page - preserve a high-order page block. + * @page: head page of the block. + * @order: order of the allocation. + * + * Instructs KHO to preserve a high-order contiguous allocation (like a DMA + * buffer) as a single unit. It must be restored using kho_restore_page() = to + * ensure the tail pages are correctly initialized with a zero refcount. + * + * If a driver needs to split a block that has been preserved with this + * function, it must first unpreserve the block using kho_unpreserve_page(= ), + * perform the split, and then re-preserve the individual pages using + * kho_preserve_pages(). + * + * Return: 0 on success, error code on failure + */ +int kho_preserve_page(struct page *page, unsigned int order) +{ + struct kho_radix_tree *tree =3D &kho_out.radix_tree; + const unsigned long pfn =3D page_to_pfn(page); + + if (WARN_ON(kho_scratch_overlap(pfn << PAGE_SHIFT, PAGE_SIZE << order))) + return -EINVAL; + + return kho_radix_add_page(tree, pfn, order); +} +EXPORT_SYMBOL_GPL(kho_preserve_page); + +/** + * kho_unpreserve_page - unpreserve a high-order page block. + * @page: head page of the block. + * @order: order of the allocation. + * + * Instructs KHO to unpreserve a high-order block that was preserved by + * kho_preserve_page() before. + */ +void kho_unpreserve_page(struct page *page, unsigned int order) +{ + struct kho_radix_tree *tree =3D &kho_out.radix_tree; + const unsigned long pfn =3D page_to_pfn(page); + + kho_radix_del_page(tree, pfn, order); +} +EXPORT_SYMBOL_GPL(kho_unpreserve_page); + static unsigned int __kho_preserve_pages_order(unsigned long start_pfn, unsigned long end_pfn) { @@ -927,7 +1001,8 @@ static void __kho_unpreserve(struct kho_radix_tree *tr= ee, * @nr_pages: number of pages. * * Preserve a contiguous list of order 0 pages. Must be restored using - * kho_restore_pages() to ensure the pages are restored properly as order = 0. + * kho_restore_pages() to ensure the pages are restored properly as order 0 + * with each page having a reference count of 1 (split). * * Return: 0 on success, error code on failure */ --=20 2.55.0.229.g6434b31f56-goog