From nobody Fri Jul 24 04:45:58 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B2324908C2 for ; Thu, 23 Jul 2026 19:10:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784833831; cv=none; b=YlA+U6YRGwK2/uqv2Yj8smnmSeaPqqikszRWOXUWgTSMTUxL1zcx/KvMNvwyFVdOM82yzmMFK1Zkkhk+pig+nca5268bP1lBhYp9GPXZwgVf+OjUncwsS9N0lZf3+/3DeEDCScVZ26WbepQ6BRCh+tJJcz+O6V3vzkaf8myW/JY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784833831; c=relaxed/simple; bh=CGvBFdrnBTyCmbklutKLWgHULCfNFj0YpxQdGzvdoVY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=r/X5snWg2Ut2ESY+eouU9N+OsENpy70W7dttxvyViRMP+aHtBpg3so2vMI8H3QYYFt65wn/kn4WzOHEEt3aXB25di1XH2cEgNEDI/wArZTUKidOBNMt7LN4HCdqgTiEaNAtkGPIgKsj0fPVZEWCaa3wjU0bCN/ipqVp2hTP82lY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YcaOb3K0; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YcaOb3K0" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2caf228a910so9210655ad.2 for ; Thu, 23 Jul 2026 12:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784833827; x=1785438627; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Kma+H0GidEuVkDhtrT3eR8/peQN+opodaig3EX+nuRs=; b=YcaOb3K0TCrjF1oB2cy5+5I8jaEgu7XB2ugG6IDAndYn6ajUglUt/lbg8P4MD5ZG5e 0HE/G/q4AzjsX2R2jibQJmCkTBqOHYg8XzvbnJsCzV+zA0vfn/c8wRzXUanf56BLlm/f weMBn0UWok2oJ6AcbDWTIW/mFJn66Trk5ZoGvisnUADzmSf3HCmm8egp1gXyamGAq+T8 x8hzDi8cq7/M3REnGkKpsMeP7jOMPYALTAfkZ9y+fcce2z5pJol5O14Q4MRgb+7M2GhD ygAIsYiasrclk06UsSevy3Zipp0yEwdtNP78+ENFXsJnJ0YaCngWFSV1GL7aDDrVxjzf kseA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784833827; x=1785438627; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Kma+H0GidEuVkDhtrT3eR8/peQN+opodaig3EX+nuRs=; b=K9wlGB15ElKqp6j3wvY1VLd57TTGQWnzNadSiOKINmeLgTMX6JvOQgrydDKVrWpcCC 4a3ym9oFL3GR04+UmQ/MLGXVqLCaLEZW7kkAwVbDH/qaMYuPdt5fEwRGzsV5NSXTspBn 4/VKTZVlgW1zbEWV+fj+ygnQv50i0fvn0h744VUSBI4azbvXnShIQE1smlZybe42LYfX pQe421mYysVDmzvYeV9SCb2JVq1w4QcLObD+Z7f+xEkl2BkjVUPWHbjrEnqjwQgIlrXQ vQolO8ejgeJ56We+lsA9TMyjEj/T9yK8sdTpyL/kA33xCo49SenA6W6ABxkhV+lFB0QO z/VQ== X-Forwarded-Encrypted: i=1; AHgh+RpXtO11jV720z5qouZIGr8M5VX8WSCpBH2NexX2qyF/HwdUhAY7IpVK2C5fdDdWDa/hh8YB4xqfOaxwh0I=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1eho1O7FjOr/x2ZB/ns5TbQNEesjW5zTiE7wuPgVmRUjwSlkl XClHyePj3IyPWRIGDgx5tuyhVEmjzfjNt0XESkjaPJQCHeB3OZTnlV+Y X-Gm-Gg: AR+sD10jTxPE43EV6NI+/y3Yf5kHg4b3j7BGLXPAajszej0+fY6GLML5SDbJg/qUSph pHiyi9LIVhStnbVc1Vp1HcgS3kARhWtp9affwNL+eZCV2QnsT7c/vOfbJK7r/5pTmbrJMu7XfGH TA/L4z2wubido5lsueGtR9y1i2KfodgBY5QWZmLOW5o8Lw4aBgzrjvfLCGP4HXHvVojM6Hqjb02 ZqybmvOm5M1TqJIBG6HtBJHNGnTJEj2zYto7GG/e148UZLtD0xLbanSaBlPVDI+FcVLq991kqjO ozi3vU+V7liyE1iqrg6wrOI/USx4uVX6UHXQrC1gVUfmRDy0sKA3gRQxbpdOwyq97wglQRo27W0 YRUlEZddXx+IchL73y8bXoYMdOTAuQcq4UuGmWclWECxqBm2L0uUl987RlrkSMfJppkzy6ToyLh kUBbVHDjqYvqgMJmceMmun8iFPU/EP77ck+Xr4MAfsCyswKstZGM/xsHbGSu+oX3AXHZOD5xlyE sVB+PDxropd77GAfWrS4dTvNLUDqpQujvUEh2PaNz7no5whOByAdYY= X-Received: by 2002:a17:903:3b8f:b0:2cf:7882:a444 with SMTP id d9443c01a7336-2cfa6b7e2ecmr55815815ad.16.1784833826654; Thu, 23 Jul 2026 12:10:26 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f2e65e6sm39324025ad.38.2026.07.23.12.10.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 12:10:25 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Rafal Prylowski , Jeff Garzik , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2] ata: pata_ep93xx: add missing "cc" and "memory" clobbers to inline asm Date: Thu, 23 Jul 2026 12:10:24 -0700 Message-ID: <20260723191024.128984-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The inline assembly in ep93xx_pata_delay() uses a "subs" instruction which modifies the ARM condition code flags. Add a "cc" clobber so the compiler knows the flags are altered. Without it, the compiler may reorder flag-dependent instructions across the asm block when the function is inlined, potentially causing incorrect control flow. Additionally, add a "memory" clobber to prevent the compiler from reordering I/O accesses across this delay loop. On older ARM architectures like ARMv4T used in EP93xx, __iormb()/__iowmb() may evaluate to empty when CONFIG_ARM_DMA_MEM_BUFFERABLE is not set, leaving writel()/readl() without a compiler memory barrier. Without a "memory" clobber here, the compiler optimizer might reorder independent I/O accesses across the delay, violating ATA PIO timing requirements. This also brings the ARM path in line with the non-ARM fallback which uses cpu_relax() (a compiler barrier). Fixes: 2fff27512600 ("PATA host controller driver for ep93xx") Assisted-by: Opencode:Big-Pickle Signed-off-by: Rosen Penev --- v2: add memory barrier drivers/ata/pata_ep93xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c index be8a314654e6..085f1e8e5343 100644 --- a/drivers/ata/pata_ep93xx.c +++ b/drivers/ata/pata_ep93xx.c @@ -211,6 +211,7 @@ static void ep93xx_pata_delay(unsigned long count) "bge 0b\n" : "=3Dr" (count) : "0" (count) + : "cc", "memory" ); #else while (count--) --=20 2.55.0