From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D66144E653 for ; Thu, 23 Jul 2026 18:46:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832369; cv=none; b=qvpZu70Qv7ChoByHk2mIECLhImrfBc2B/dXtdtZNibGC6EAWpKetvdQxL2b6PbzAQQr8ILchZXMq2zsdw0HIyU2gVF3VwNdsNOZ8DWjtpKHhZWtSQ3+DL0EreNLSg//dZXzJM6zoWTlg7GZqMTp/cIx+ao8sKb1Ngj/igrvxHro= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832369; c=relaxed/simple; bh=7CSCLiBzSym1VTRlnZsHYqVM4EjgdFe8A2vqS9D0LTQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bGZ/uUM/NDFQtNai12TJ9rU0ucXIefcahoJvCDfC9s4A0JGm9OPv8fJKmTPe5AtJCr3e63fZBoIqiptgvKSWCZ+zCbNuIrP18ehLb/9QVTX/WpTB5U5cux/oZ5/2d/v8xyt+awruco7KRHR77puAgs14vYlUEy0nZvUPxScPe94= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bF3K+rPU; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bF3K+rPU" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38de840f2f0so798483a91.0 for ; Thu, 23 Jul 2026 11:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832357; x=1785437157; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=awQoiDBDgXhHqvQuYMCoxfsFQDhNz1mjFe+tSKjVwWE=; b=bF3K+rPU0TFK5KhyGc2AzVw632t6LxJbZQFXxC7T73e7srbTx9xXldPP63XS1mxLo+ aFVpk2aiHmUgRSiVpBEaLJII5AgRbQUsFZ8aXUU1Nvn+GSakPXNHNMpVJpY25a93JIsR QeEQV1onhatMCZowK0Ax/iEVsQyG8l3v8CsthXWLkLe7KO0Q/1EedGADGMQX9TyPwKyH 9sWMZwDpl3c1dtnDDcByF3TY7I9b+Ts0OWssiqT4YhKKgAlL/kVE1appoLkyYS53/EBb jxaQQHSdsFtDekBmNpik//PAO88YIEp9VkZgGI5f4AVgrrOFg9CwOW9DIzzSrh44oEAx BsUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832357; x=1785437157; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=awQoiDBDgXhHqvQuYMCoxfsFQDhNz1mjFe+tSKjVwWE=; b=qKwGvDSUd7VW/BXHoHIh6OuL7e2oohbQbe1SRtwGjh+dvs5LG2FR/Goh0e2an9IBQd nEZsoaJkzTBodkdurjz1nac+SUbG708r5d7bHATsGcLC6TVaeQOFxY8RaHjQf0vQssKN wR5zir9rTJvOBgMMd+1FsmQsfkSCSQ+JFcae8Ag1VANipZ2VkEpYBFDf8tffdQy6fVja z6WXYHnEqSjfSMUFAsPpBYft75GefuBeFWuDlTIEqzSvuYeylMQGC24OkaMSdj2ZJpb5 LKJ+X0G2RCB+33BWgrOWr1SBAoFzM8+fhG0hAYYjdbwtGqhVkysBrF2Nzd/bghp+Bcea fNXw== X-Forwarded-Encrypted: i=1; AHgh+RoKLHB/Xo35F0GneIdBaissdnAfATBqLFttXhBORyPCR7oCiA85a0NPzQM1kDj8jyXUbHVsVFdLv8BAsio=@vger.kernel.org X-Gm-Message-State: AOJu0YwNTHKiZWL7arr+5Gz0ICQuudePhMwfxJ/x2JWPamah/hPLfZNO +MG9hvhQzS5kvRnk/bd03fH65UsTLiqIVj2OxV4ZQfjLTXjZdeqfZwYr X-Gm-Gg: AR+sD12W7qaHhXm6f4AQhMBxX0OA0Knt1Ml0GKPzWTYPxVvPPVs8fNJL4z8QaaCSjSS 8lCnvLOCKaCy+TutLLhqIFNZ5ZfbS8k7MRBIm5MjHpsQNTceXs/hFA/C6bPEVUq6VUr22RLPo5S 4Kyc5Y/5tUsz1QnVLbjMZ1t2bT5MrfCTrK/MlP7NYaiBEWhKSHGxt7CcsjubmtqeXDnbuK/YQwz 4ZJg9Vb9C2EhB0PIZEwEV8cqtCCxFOK+6knTEW7atFWHC+ZDqJ0JGFbzV7cN0ho+hbopNnYfqXU AW3J8vulN2+4Mvcr2c8JZuOEIAmNzuy785BfX4WkMkyM6fMuBdTwFRnLSRU5uakREpDedCmYfvt p6es5lMKaLe0cU2iKAEx36QAcsKBuuH4BJ44EJny186kfRSM6x5hlrmuFfgrHolaepvD2JZtn X-Received: by 2002:a17:90b:544f:b0:37f:9cdf:f037 with SMTP id 98e67ed59e1d1-38ec660bb8dmr4570424a91.26.1784832356687; Thu, 23 Jul 2026 11:45:56 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.45.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:45:56 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Nicolas Palix Cc: cocci@inria.fr, linux-kernel@vger.kernel.org Subject: [PATCH 01/36] coccinelle: misc: add cond_return_no_effect.cocci Date: Fri, 24 Jul 2026 03:45:03 +0900 Message-ID: <20260723184538.3888637-2-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a new Coccinelle script which removes a conditional return that has no effect: if (ret) return ret; return ret; Both branches return the same value, so the check can be removed. The condition can also be a negation or a comparison with a constant. Such code is usually a leftover from removing a statement between the two returns. When a local variable is assigned right before the check, the assignment and the two returns turn into a single return of the assigned expression, and the declaration is dropped if nothing else uses the variable. Otherwise only the check is removed. The fold can delete comments between the check and the final return, so the generated patch should be reviewed. Signed-off-by: Sang-Heon Jeon --- .../misc/cond_return_no_effect.cocci | 121 ++++++++++++++++++ 1 file changed, 121 insertions(+) create mode 100644 scripts/coccinelle/misc/cond_return_no_effect.cocci diff --git a/scripts/coccinelle/misc/cond_return_no_effect.cocci b/scripts/= coccinelle/misc/cond_return_no_effect.cocci new file mode 100644 index 000000000000..541aafdc32c6 --- /dev/null +++ b/scripts/coccinelle/misc/cond_return_no_effect.cocci @@ -0,0 +1,121 @@ +// SPDX-License-Identifier: GPL-2.0-only +/// +/// Remove a conditional return that has no effect: +/// +/// if (ret) +/// return ret; +/// return ret; +/// +/// Both branches return the same variable, so the check has no +/// effect. It can also be a negation or a comparison with a +/// constant. +/// +/// When a local variable is assigned right before the check, the +/// assignment and the two returns turn into a single return of the +/// assigned expression, and the declaration is dropped if nothing +/// else uses the variable. Otherwise only the check is removed. +/// +// Such code is usually a leftover from removing a statement between +// the two returns. +// +// Confidence: High +// Copyright: (C) 2026 Sang-Heon Jeon +// Comments: The fold can delete comments between the check and the +// final return, so review the generated patch. +// Options: --no-includes --include-headers + +virtual patch +virtual context +virtual org +virtual report + +//---------------------------------------------------------- +// For patch mode +//---------------------------------------------------------- + +@collect depends on patch@ +identifier ret; +expression E; +binary operator cmp =3D {<, <=3D, >, >=3D, =3D=3D, !=3D}; +constant C; +@@ + ret =3D E; + if (\(ret \| !ret \| ret cmp C\)) + return ret; + return ret; + +@depends on patch@ +local idexpression ret; +expression E; +binary operator cmp =3D {<, <=3D, >, >=3D, =3D=3D, !=3D}; +constant C; +@@ +- ret =3D E; +- if (\(ret \| !ret \| ret cmp C\)) +- return ret; +- return ret; ++ return E; + +@depends on patch@ +idexpression ret; +binary operator cmp =3D {<, <=3D, >, >=3D, =3D=3D, !=3D}; +constant C; +@@ +- if (\(ret \| !ret \| ret cmp C\)) +- return ret; + return ret; + +@depends on patch@ +type T; +identifier collect.ret; +@@ +- T ret; + ... when !=3D ret + when strict + +@depends on patch@ +type T; +identifier collect.ret; +constant C; +@@ +- T ret =3D C; + ... when !=3D ret + when strict + + +//---------------------------------------------------------- +// For context mode +//---------------------------------------------------------- + +@depends on context@ +idexpression ret; +binary operator cmp =3D {<, <=3D, >, >=3D, =3D=3D, !=3D}; +constant C; +@@ +* if (\(ret \| !ret \| ret cmp C\)) +* return ret; + return ret; + +//---------------------------------------------------------- +// For org and report mode +//---------------------------------------------------------- + +@r depends on org || report@ +idexpression ret; +binary operator cmp =3D {<, <=3D, >, >=3D, =3D=3D, !=3D}; +constant C; +position p; +@@ + if@p (\(ret \| !ret \| ret cmp C\)) + return ret; + return ret; + +@script:python depends on org@ +p << r.p; +@@ +cocci.print_main("WARNING: conditional return with no effect (both branche= s return the same value)", p) + +@script:python depends on report@ +p << r.p; +@@ +coccilib.report.print_report(p[0], "WARNING: conditional return with no ef= fect (both branches return the same value)") --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33D67488D86 for ; Thu, 23 Jul 2026 18:46:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832367; cv=none; b=gU7SL1KUJy0yqcH4Rsx6pka8dabQP3KGH3/PHWUDuLaLrQiBjxTarP/40I1Kza1lwbm4EfVYbyBQ70wWLX8gjNqC6vk02IN0B/6isqZ2sj+3iw2ONvNXeTMn8YI3udj9W2tXsVE+1DSuHaHcP4GpO80rs94tSITJ0unDe0NiqGo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832367; c=relaxed/simple; bh=mfEfM/jdC8NNpe+/waB80DCloHDjO+1sOV8dU20CBvo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jQ9hgi0MaMELZe3SLzRI2m+lEglPyPqKr4LSunNxmBYs+s171EeWGfDCoHJ+JtcFFJU9ZGpA3UaPpqB7gqXj2OLH3DKNzx/+PVHk3lILwDqstwQdWkjmNUeYI7fc7In3dHrZ0gRgB3d4e7g52tdU2bXinELQXJee0OlvIuaf/U4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dvDThKeX; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dvDThKeX" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38d489b6b71so931201a91.0 for ; Thu, 23 Jul 2026 11:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832359; x=1785437159; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OFWWMcPCcMgyyaWxMapaPQ6yr5T+tvoKVuXbzZSZnOI=; b=dvDThKeX4FYIWwLox3ESAF5mqnammMnOHKzAGqkuvhAvqm7NfC4Ldn9fyR8wxs/gca tMXCCDMhZmdFYaqk6rDbY3gS1GcZe1fMY6uTkK2s5h1bhbi/xwFyK3eSQW47h6UM/H+C oTzP/hmQdnm7tuG9owhioiU772h71jeWC/oxY5Ng2xrdFPLpamfQGscBwxzJQgAJghHK LhEE1+9CUmNJgWEGzkdCUroJklbcis2lFvKpRvgBgMXNoa7P8gH7f/QzEyoSWCynlEV6 VOy/GKdCIAQwc+FDapJG0Fiw2YLth00VvGzqylPuu1g98HacLzTI7bugnTyOp4RrR3/F QvKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832359; x=1785437159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=OFWWMcPCcMgyyaWxMapaPQ6yr5T+tvoKVuXbzZSZnOI=; b=MpMPjT4mXGj5z98ykFPh/WUzHiFS/Irellsy4g00mIjaMTP9MFPJ68WljAtHe822gh XYoOqhF9Qstcu8uAm/RTg9XjoRVXaiELUg4jXEyTy2KBz41AWXioLsdHN4ZAMwOENOr5 Em7iOoFr1u2LklcqHuca8ZA3PehamKg0YeFxJpt0WxbJWW3J2xSy2PXPNKwdY8VFasQp ZaKb2jWHnlgPl66WMXF8RWCL5PVZoCyRcl40rbpcwlPWjONzyPPE7727FXalHJGOMYQ4 kfnS1MhjImGjDSlczc9JNr51Nr4g+SKF8g+sJejcugZx57R5hByuwZn8MGc5eSoqSq7d R7Hw== X-Forwarded-Encrypted: i=1; AHgh+RriZvtFTb6/gh5OMKa7xDdpRbJsD1hKmd8KsKyK25L1ZrQ8j3/dfxMzfq4zWtkfCqjEv7U3EJmnROn2EGo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6RkAMTiU7Vz2qf5zDISAwbwqzTJLWpXWSEoz6FDDd/f0lJ3aK UXCexYtj00VAF6Veht01K3dLX8mUHt3yh65KURsavemee/R9TGhW1DkV X-Gm-Gg: AR+sD101xIADj2UOEO4AvQapcpPyplMu7EHfVF7zE/NeCTODt7B8D0yded16JdoAyZZ lLsDNghvLLpLlR4S0y3x45A6sG2LWhy7TIkbvd12vccJrHootMEKi7EeMHxyqMIr5720IKA66kz KNclN6tew35PSLOwYEXzr+QIOtpXbvDbRrKYzqH0SVIZPAl1LaEFd1SUUMrR+XJsSZlMDt3s22Q bEa7BZJNPrlmEyjEcyvlxIpIYGvWyzPVZKmK0aAK3e8RHG8SNaHtagtQdAqVnrE2bOL1L5BwL3H QwNJgYOLkLmAJXju6JsmyZp6wVujn8yroul+bV2qzvsU1YN8KhEfjOaKZjUa9qJKVY/lCumg1Au UjYlYmzw90Hh/F/7j093ko8+6c7AP4P9h/bn0GHiJE+bRjjlEdCNHMT3X2gwvS4WS3WRyFsJO X-Received: by 2002:a17:90b:55c3:b0:38d:fda6:4873 with SMTP id 98e67ed59e1d1-38ec64f19b0mr4395595a91.10.1784832359386; Thu, 23 Jul 2026 11:45:59 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.45.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:45:58 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter , Kenneth Feng Cc: cocci@inria.fr, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/36] drm/amd: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:04 +0900 Message-ID: <20260723184538.3888637-3-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 6 +--- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 6 +--- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 6 +--- drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 6 +--- drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 6 +--- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 6 +--- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 6 +--- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 6 +--- drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 6 +--- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 6 +--- drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 6 +--- drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 32 +++++++------------ drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 6 +--- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 6 +--- .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 6 +--- .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 6 +--- .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 19 ++++------- .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 7 ++-- .../gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 7 ++-- .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 6 +--- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 19 ++++------- .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 6 +--- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 10 ++---- .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 6 +--- .../gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c | 19 ++++------- .../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 6 +--- .../gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c | 9 ++---- .../drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c | 16 ++-------- 28 files changed, 60 insertions(+), 192 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/am= dgpu/gfx_v7_0.c index 65b8497ad5f0..c64c79db3016 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c @@ -4482,11 +4482,7 @@ static int gfx_v7_0_hw_init(struct amdgpu_ip_block *= ip_block) if (r) return r; =20 - r =3D gfx_v7_0_cp_resume(adev); - if (r) - return r; - - return r; + return gfx_v7_0_cp_resume(adev); } =20 static int gfx_v7_0_hw_fini(struct amdgpu_ip_block *ip_block) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/am= dgpu/gfx_v9_0.c index 1cad6dc9476e..5baacf86facb 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c @@ -1614,11 +1614,7 @@ static int gfx_v9_0_init_microcode(struct amdgpu_dev= ice *adev) if (r) return r; =20 - r =3D gfx_v9_0_init_cp_compute_microcode(adev, ucode_prefix); - if (r) - return r; - - return r; + return gfx_v9_0_init_cp_compute_microcode(adev, ucode_prefix); } =20 static u32 gfx_v9_0_get_csb_size(struct amdgpu_device *adev) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/drivers/gpu/drm/amd/= amdgpu/gfx_v9_4_3.c index 9512fef81d84..22b48f4232b1 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c @@ -599,11 +599,7 @@ static int gfx_v9_4_3_init_microcode(struct amdgpu_dev= ice *adev) if (r) return r; =20 - r =3D gfx_v9_4_3_init_cp_compute_microcode(adev, ucode_prefix); - if (r) - return r; - - return r; + return gfx_v9_4_3_init_cp_compute_microcode(adev, ucode_prefix); } =20 static void gfx_v9_4_3_mec_fini(struct amdgpu_device *adev) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c b/drivers/gpu/drm/amd= /amdgpu/sdma_v4_4_2.c index 6fe3d3d56c40..4dac16bb330c 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c @@ -1537,11 +1537,7 @@ static int sdma_v4_4_2_sw_init(struct amdgpu_ip_bloc= k *ip_block) else DRM_ERROR("Failed to allocated memory for SDMA IP Dump\n"); =20 - r =3D amdgpu_sdma_sysfs_reset_mask_init(adev); - if (r) - return r; - - return r; + return amdgpu_sdma_sysfs_reset_mask_init(adev); } =20 static int sdma_v4_4_2_sw_fini(struct amdgpu_ip_block *ip_block) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c b/drivers/gpu/drm/amd/a= mdgpu/sdma_v5_0.c index 1ca0e7f65442..5192fe097385 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c @@ -1440,11 +1440,7 @@ static int sdma_v5_0_sw_init(struct amdgpu_ip_block = *ip_block) else DRM_ERROR("Failed to allocated memory for SDMA IP Dump\n"); =20 - r =3D amdgpu_sdma_sysfs_reset_mask_init(adev); - if (r) - return r; - - return r; + return amdgpu_sdma_sysfs_reset_mask_init(adev); } =20 static int sdma_v5_0_sw_fini(struct amdgpu_ip_block *ip_block) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/drm/amd/a= mdgpu/sdma_v5_2.c index 81f1e9882177..4ddb8277c37d 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c @@ -1358,11 +1358,7 @@ static int sdma_v5_2_sw_init(struct amdgpu_ip_block = *ip_block) else DRM_ERROR("Failed to allocated memory for SDMA IP Dump\n"); =20 - r =3D amdgpu_sdma_sysfs_reset_mask_init(adev); - if (r) - return r; - - return r; + return amdgpu_sdma_sysfs_reset_mask_init(adev); } =20 static int sdma_v5_2_sw_fini(struct amdgpu_ip_block *ip_block) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c b/drivers/gpu/drm/amd/a= mdgpu/sdma_v6_0.c index cf3d2997fff8..d41e3720020f 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c @@ -1406,11 +1406,7 @@ static int sdma_v6_0_sw_init(struct amdgpu_ip_block = *ip_block) break; } =20 - r =3D amdgpu_sdma_sysfs_reset_mask_init(adev); - if (r) - return r; - - return r; + return amdgpu_sdma_sysfs_reset_mask_init(adev); } =20 static int sdma_v6_0_sw_fini(struct amdgpu_ip_block *ip_block) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c b/drivers/gpu/drm/amd/am= dgpu/uvd_v4_2.c index 8a9ba2276275..004a8ce8eedc 100644 --- a/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c @@ -128,11 +128,7 @@ static int uvd_v4_2_sw_init(struct amdgpu_ip_block *ip= _block) if (r) return r; =20 - r =3D amdgpu_uvd_resume(adev); - if (r) - return r; - - return r; + return amdgpu_uvd_resume(adev); } =20 static int uvd_v4_2_sw_fini(struct amdgpu_ip_block *ip_block) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c b/drivers/gpu/drm/amd/am= dgpu/uvd_v5_0.c index 454f109cbb2e..52700e9048f7 100644 --- a/drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c @@ -121,11 +121,7 @@ static int uvd_v5_0_sw_init(struct amdgpu_ip_block *ip= _block) if (r) return r; =20 - r =3D amdgpu_uvd_resume(adev); - if (r) - return r; - - return r; + return amdgpu_uvd_resume(adev); } =20 static int uvd_v5_0_sw_fini(struct amdgpu_ip_block *ip_block) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c b/drivers/gpu/drm/amd/am= dgpu/uvd_v7_0.c index 46222fc30be6..3760a06d8ef2 100644 --- a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c @@ -484,11 +484,7 @@ static int uvd_v7_0_sw_init(struct amdgpu_ip_block *ip= _block) if (r) return r; =20 - r =3D amdgpu_virt_alloc_mm_table(adev); - if (r) - return r; - - return r; + return amdgpu_virt_alloc_mm_table(adev); } =20 static int uvd_v7_0_sw_fini(struct amdgpu_ip_block *ip_block) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v4_0.c b/drivers/gpu/drm/amd/am= dgpu/vce_v4_0.c index ee445d8abe47..a2f908f86df3 100644 --- a/drivers/gpu/drm/amd/amdgpu/vce_v4_0.c +++ b/drivers/gpu/drm/amd/amdgpu/vce_v4_0.c @@ -491,11 +491,7 @@ static int vce_v4_0_sw_init(struct amdgpu_ip_block *ip= _block) return r; } =20 - r =3D amdgpu_virt_alloc_mm_table(adev); - if (r) - return r; - - return r; + return amdgpu_virt_alloc_mm_table(adev); } =20 static int vce_v4_0_sw_fini(struct amdgpu_ip_block *ip_block) diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c b/drivers/gpu/drm/a= md/pm/legacy-dpm/kv_dpm.c index b763fdf43c60..0d241002df82 100644 --- a/drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c +++ b/drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c @@ -1075,16 +1075,12 @@ static int kv_populate_samu_table(struct amdgpu_dev= ice *adev) if (ret) return ret; =20 - ret =3D amdgpu_kv_copy_bytes_to_smc(adev, - pi->dpm_table_start + - offsetof(SMU7_Fusion_DpmTable, SamuLevel), - (u8 *)&pi->samu_level, - sizeof(SMU7_Fusion_ExtClkLevel) * SMU7_MAX_LEVELS_SAMU, - pi->sram_end); - if (ret) - return ret; - - return ret; + return amdgpu_kv_copy_bytes_to_smc(adev, + pi->dpm_table_start + + offsetof(SMU7_Fusion_DpmTable, SamuLevel), + (u8 *)&pi->samu_level, + sizeof(SMU7_Fusion_ExtClkLevel) * SMU7_MAX_LEVELS_SAMU, + pi->sram_end); } =20 =20 @@ -1134,16 +1130,12 @@ static int kv_populate_acp_table(struct amdgpu_devi= ce *adev) if (ret) return ret; =20 - ret =3D amdgpu_kv_copy_bytes_to_smc(adev, - pi->dpm_table_start + - offsetof(SMU7_Fusion_DpmTable, AcpLevel), - (u8 *)&pi->acp_level, - sizeof(SMU7_Fusion_ExtClkLevel) * SMU7_MAX_LEVELS_ACP, - pi->sram_end); - if (ret) - return ret; - - return ret; + return amdgpu_kv_copy_bytes_to_smc(adev, + pi->dpm_table_start + + offsetof(SMU7_Fusion_DpmTable, AcpLevel), + (u8 *)&pi->acp_level, + sizeof(SMU7_Fusion_ExtClkLevel) * SMU7_MAX_LEVELS_ACP, + pi->sram_end); } =20 static void kv_calculate_dfs_bypass_settings(struct amdgpu_device *adev) diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c b/drivers/gpu/drm/a= md/pm/legacy-dpm/si_dpm.c index 012227c70600..50973f92ccbf 100644 --- a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c +++ b/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c @@ -6989,11 +6989,7 @@ static int si_set_temperature_range(struct amdgpu_de= vice *adev) ret =3D si_thermal_set_temperature_range(adev, R600_TEMP_RANGE_MIN, R600_= TEMP_RANGE_MAX); if (ret) return ret; - ret =3D si_thermal_enable_alert(adev, true); - if (ret) - return ret; - - return ret; + return si_thermal_enable_alert(adev, true); } =20 static void si_dpm_disable(struct amdgpu_device *adev) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/am= d/pm/swsmu/amdgpu_smu.c index f4e817885e54..9c2eb6431727 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c @@ -1922,11 +1922,7 @@ static int smu_start_smc_engine(struct smu_context *= smu) * Send msg GetDriverIfVersion to check if the return value is equal * with DRIVER_IF_VERSION of smc header. */ - ret =3D smu_check_fw_version(smu); - if (ret) - return ret; - - return ret; + return smu_check_fw_version(smu); } =20 static int smu_hw_init(struct amdgpu_ip_block *ip_block) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c b/drivers/gp= u/drm/amd/pm/swsmu/smu11/arcturus_ppt.c index db5db2c9c8e8..0dd2dbbfb2cd 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c @@ -540,11 +540,7 @@ static int arcturus_setup_pptable(struct smu_context *= smu) if (ret) return ret; =20 - ret =3D arcturus_check_powerplay_table(smu); - if (ret) - return ret; - - return ret; + return arcturus_check_powerplay_table(smu); } =20 static int arcturus_run_btc(struct smu_context *smu) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gpu/= drm/amd/pm/swsmu/smu11/navi10_ppt.c index 8feea44f3ca0..48af342aa549 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c @@ -484,11 +484,7 @@ static int navi10_setup_pptable(struct smu_context *sm= u) if (ret) return ret; =20 - ret =3D navi10_check_powerplay_table(smu); - if (ret) - return ret; - - return ret; + return navi10_check_powerplay_table(smu); } =20 static int navi10_tables_init(struct smu_context *smu) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c b/drivers/gpu/d= rm/amd/pm/swsmu/smu11/smu_v11_0.c index a889d846e9c5..8f35ddaabe88 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c @@ -528,12 +528,10 @@ int smu_v11_0_notify_memory_pool_location(struct smu_= context *smu) address_low, NULL); if (ret) return ret; - ret =3D smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_DramLogSetDramSize, - (uint32_t)memory_pool->size, NULL); - if (ret) - return ret; - - return ret; + return smu_cmn_send_smc_msg_with_param(smu, + SMU_MSG_DramLogSetDramSize, + (uint32_t)memory_pool->size, + NULL); } =20 int smu_v11_0_set_min_deep_sleep_dcefclk(struct smu_context *smu, uint32_t= clk) @@ -1378,13 +1376,8 @@ int smu_v11_0_register_irq_handler(struct smu_contex= t *smu) if (ret) return ret; =20 - ret =3D amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_MP1, - SMU_IH_INTERRUPT_ID_TO_DRIVER, - irq_src); - if (ret) - return ret; - - return ret; + return amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_MP1, + SMU_IH_INTERRUPT_ID_TO_DRIVER, irq_src); } =20 int smu_v11_0_get_max_sustainable_clocks_by_dc(struct smu_context *smu, diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu= /drm/amd/pm/swsmu/smu11/vangogh_ppt.c index 016a5c893fee..3350ea1bea24 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c @@ -1368,11 +1368,8 @@ static int vangogh_set_peak_clock_by_device(struct s= mu_context *smu) if (ret) return ret; =20 - ret =3D vangogh_set_soft_freq_limited_range(smu, SMU_DCLK, dclk_freq, dcl= k_freq, false); - if (ret) - return ret; - - return ret; + return vangogh_set_soft_freq_limited_range(smu, SMU_DCLK, dclk_freq, + dclk_freq, false); } =20 static int vangogh_set_performance_level(struct smu_context *smu, diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c b/drivers/gpu/= drm/amd/pm/swsmu/smu12/renoir_ppt.c index 2b011610e3c7..85f77754a0c0 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c @@ -893,11 +893,8 @@ static int renoir_set_peak_clock_by_device(struct smu_= context *smu) if (ret) return ret; =20 - ret =3D smu_v12_0_set_soft_freq_limited_range(smu, SMU_UCLK, uclk_freq, u= clk_freq, false); - if (ret) - return ret; - - return ret; + return smu_v12_0_set_soft_freq_limited_range(smu, SMU_UCLK, uclk_freq, + uclk_freq, false); } =20 static int renior_set_dpm_profile_freq(struct smu_context *smu, diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers/g= pu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c index cd7bf36673cb..2a74bb8a7b78 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c @@ -533,11 +533,7 @@ static int aldebaran_setup_pptable(struct smu_context = *smu) if (ret) return ret; =20 - ret =3D aldebaran_check_powerplay_table(smu); - if (ret) - return ret; - - return ret; + return aldebaran_check_powerplay_table(smu); } =20 static bool aldebaran_is_primary(struct smu_context *smu) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/drivers/gpu/d= rm/amd/pm/swsmu/smu13/smu_v13_0.c index 4f10bce36756..a2b0a2f23916 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c @@ -583,12 +583,10 @@ int smu_v13_0_notify_memory_pool_location(struct smu_= context *smu) address_low, NULL); if (ret) return ret; - ret =3D smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_DramLogSetDramSize, - (uint32_t)memory_pool->size, NULL); - if (ret) - return ret; - - return ret; + return smu_cmn_send_smc_msg_with_param(smu, + SMU_MSG_DramLogSetDramSize, + (uint32_t)memory_pool->size, + NULL); } =20 int smu_v13_0_set_driver_table_location(struct smu_context *smu) @@ -1281,13 +1279,8 @@ int smu_v13_0_register_irq_handler(struct smu_contex= t *smu) if (ret) return ret; =20 - ret =3D amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_MP1, - SMU_IH_INTERRUPT_ID_TO_DRIVER, - irq_src); - if (ret) - return ret; - - return ret; + return amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_MP1, + SMU_IH_INTERRUPT_ID_TO_DRIVER, irq_src); } =20 int smu_v13_0_get_max_sustainable_clocks_by_dc(struct smu_context *smu, diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c b/drivers= /gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c index 4ce1429cf57b..0ca404ccb4a9 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c @@ -463,11 +463,7 @@ static int smu_v13_0_0_setup_pptable(struct smu_contex= t *smu) return ret; } =20 - ret =3D smu_v13_0_0_check_powerplay_table(smu); - if (ret) - return ret; - - return ret; + return smu_v13_0_0_check_powerplay_table(smu); } =20 static int smu_v13_0_0_tables_init(struct smu_context *smu) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers= /gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c index 64db62a8d642..b55626f61be7 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c @@ -1893,7 +1893,6 @@ static int smu_v13_0_6_register_irq_handler(struct sm= u_context *smu) { struct amdgpu_device *adev =3D smu->adev; struct amdgpu_irq_src *irq_src =3D &smu->irq_source; - int ret =3D 0; =20 if (amdgpu_sriov_vf(adev)) return 0; @@ -1901,13 +1900,8 @@ static int smu_v13_0_6_register_irq_handler(struct s= mu_context *smu) irq_src->num_types =3D 1; irq_src->funcs =3D &smu_v13_0_6_irq_funcs; =20 - ret =3D amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_MP1, - IH_INTERRUPT_ID_TO_DRIVER, - irq_src); - if (ret) - return ret; - - return ret; + return amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_MP1, + IH_INTERRUPT_ID_TO_DRIVER, irq_src); } =20 static int smu_v13_0_6_notify_unload(struct smu_context *smu) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c b/drivers= /gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c index 5f23f2e7f401..0cc3ec648521 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c @@ -499,11 +499,7 @@ static int smu_v13_0_7_setup_pptable(struct smu_contex= t *smu) return ret; } =20 - ret =3D smu_v13_0_7_check_powerplay_table(smu); - if (ret) - return ret; - - return ret; + return smu_v13_0_7_check_powerplay_table(smu); } =20 static int smu_v13_0_7_tables_init(struct smu_context *smu) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c b/drivers/gpu/d= rm/amd/pm/swsmu/smu14/smu_v14_0.c index 2a0c7cde938d..27a3f5d9cba6 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c @@ -549,12 +549,10 @@ int smu_v14_0_notify_memory_pool_location(struct smu_= context *smu) address_low, NULL); if (ret) return ret; - ret =3D smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_DramLogSetDramSize, - (uint32_t)memory_pool->size, NULL); - if (ret) - return ret; - - return ret; + return smu_cmn_send_smc_msg_with_param(smu, + SMU_MSG_DramLogSetDramSize, + (uint32_t)memory_pool->size, + NULL); } =20 int smu_v14_0_set_driver_table_location(struct smu_context *smu) @@ -911,13 +909,8 @@ int smu_v14_0_register_irq_handler(struct smu_context = *smu) if (ret) return ret; =20 - ret =3D amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_MP1, - SMU_IH_INTERRUPT_ID_TO_DRIVER, - irq_src); - if (ret) - return ret; - - return ret; + return amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_MP1, + SMU_IH_INTERRUPT_ID_TO_DRIVER, irq_src); } =20 static int smu_v14_0_wait_for_reset_complete(struct smu_context *smu, diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c b/drivers= /gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c index 0fbcaf884419..0aec08200038 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c @@ -366,11 +366,7 @@ static int smu_v14_0_2_setup_pptable(struct smu_contex= t *smu) if (ret) return ret; =20 - ret =3D smu_v14_0_2_check_powerplay_table(smu); - if (ret) - return ret; - - return ret; + return smu_v14_0_2_check_powerplay_table(smu); } =20 static int smu_v14_0_2_tables_init(struct smu_context *smu) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c b/drivers/gpu/d= rm/amd/pm/swsmu/smu15/smu_v15_0.c index 046069e93854..cb1602cfab98 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c @@ -782,13 +782,8 @@ int smu_v15_0_register_irq_handler(struct smu_context = *smu) if (ret) return ret; =20 - ret =3D amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_MP1, - SMU_IH_INTERRUPT_ID_TO_DRIVER, - irq_src); - if (ret) - return ret; - - return ret; + return amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_MP1, + SMU_IH_INTERRUPT_ID_TO_DRIVER, irq_src); } =20 static int smu_v15_0_wait_for_reset_complete(struct smu_context *smu, diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c b/drivers= /gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c index 227cd86e13e8..b398e1606177 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c @@ -318,11 +318,7 @@ static int smu_v15_0_8_fini_smc_tables(struct smu_cont= ext *smu) if (ret) return ret; =20 - ret =3D smu_v15_0_fini_smc_tables(smu); - if (ret) - return ret; - - return ret; + return smu_v15_0_fini_smc_tables(smu); } =20 static int smu_v15_0_8_init_allowed_features(struct smu_context *smu) @@ -1253,7 +1249,6 @@ static int smu_v15_0_8_register_irq_handler(struct sm= u_context *smu) { struct amdgpu_device *adev =3D smu->adev; struct amdgpu_irq_src *irq_src =3D &smu->irq_source; - int ret =3D 0; =20 if (amdgpu_sriov_vf(adev)) return 0; @@ -1261,13 +1256,8 @@ static int smu_v15_0_8_register_irq_handler(struct s= mu_context *smu) irq_src->num_types =3D 1; irq_src->funcs =3D &smu_v15_0_8_irq_funcs; =20 - ret =3D amdgpu_irq_add_id(adev, SOC_V1_0_IH_CLIENTID_MP1, - IH_INTERRUPT_ID_TO_DRIVER, - irq_src); - if (ret) - return ret; - - return ret; + return amdgpu_irq_add_id(adev, SOC_V1_0_IH_CLIENTID_MP1, + IH_INTERRUPT_ID_TO_DRIVER, irq_src); } =20 static int smu_v15_0_8_notify_unload(struct smu_context *smu) --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EE1C48A8A1 for ; Thu, 23 Jul 2026 18:46:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832375; cv=none; b=Gf+nIuvaeNza9nV4lS5WN9aJCEgqhaj0nEaNKb2aeMsJ5vm1PbvRRxLqKj6zwKDmTHsPH0JOQVrqU1JKaktKVATb2dxTlOqgfA0YgKbWT55dbas6aPHNzp+F5rLObuAJHw6SDoyrXLVtIs4MenpF2SM+roG6DQUlShc/jsgHvUM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832375; c=relaxed/simple; bh=SH9hRpJpnFXaJHhuWqBFaIN7XJlpoNlseJ43jS/sqis=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K3VE9O4wB5q6f61LCTngwRXhS+z2JSkq1XQB02OUy7Kr1vmcfNFVCbLWgRN5zhzXaO6WG4kGWo4aUco4fE7182j+2L7oHyfxsBDoLIXWyI8W1+HtTgwZLFStKIWOEvO9QJRQ1Y006mPMh/VpJBg5kOurJZ1FeZ7XEx8XtBzkIpo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WK6wFCWg; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WK6wFCWg" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-38ec1402b05so774468a91.2 for ; Thu, 23 Jul 2026 11:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832362; x=1785437162; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4ythMD/8HygMBBur9HX2jCV0xO6Blk6zNXYU5eF8R0o=; b=WK6wFCWgWbxEi0a8/GX/xUFVdsSJwFde0OOQwC/ifapBkEtjwEEoCb+jcQFyR/oZRh ifc7Qeuxufs619YlAd/hpAvJYKhSLtfQvhkkf9QMo2q0HHkt4ldWdgi5tQXZhzoi4ecY TaxcPKZ8uWxN0Tq/hBpDybkRQhq4iBXxH3DRfisKulZNXA9kTTiFXs0DfV0AmFa0zbb5 yglJs4qk1kklkpOZW/kjJI/KxC710g2tzJaFvkfMyLCNV/w8AmL8gv68d4mz8SqaeOpM rU1p/ziM9YNjzDQHRN2OqKlIraALB3yumI875R22ChRYj+upCm99UvWarDqoqc9ShxaH 17yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832362; x=1785437162; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4ythMD/8HygMBBur9HX2jCV0xO6Blk6zNXYU5eF8R0o=; b=hLF50e/ewG+IrZqB5F2Ctuvzd0+SAsP390fiN8RGdw/7iJFKTJc91AKl7kUPSpnaWq RF1S3ay/57VdNoy4HfBvy7e/2/HdPZWe7MkiFXLX7eLqQGGbwzH1J8geoKulz3X02DoZ lbfhcGSXLAriXMzCBoLwez3CKHhimgT8gbQJokRqjN8KsUYqKfGBOLSERJxxbVfGfdWI Jqrvsbdzr8O0bL6cGfRp+1G8ijYbzqwHzCJPfNCwvZ5j+ImY8vuvkfFjq2Llj/16fbJ6 DhVXXe+fKStAamIfo5WeFU0DtdSkXLsCuZFxnr+coyXBzTuNQ5FAjza0vnBLLBD5xhyU Q1ng== X-Forwarded-Encrypted: i=1; AHgh+Rqfq+saWHbZk4z0IE1lnQNunNhEDPsc+9oWh6zl1/u4qzgP0ctWwj8BJrpmrg7iiz3FlbqMPxvU3cj3KvA=@vger.kernel.org X-Gm-Message-State: AOJu0YwCGnNT4NGka3mPQSBeLPmH8iC/Fqwq+gz2e+QGtEeTSY77mURT e2s+cD/Ak7Z3w2Q+QMYKSm9sCaUg4B1V+Sy5L6XLZNltMRSZ7LeP19dm X-Gm-Gg: AR+sD13g5qtbX27bpNwLiRr3pPzGXQ2F0wnLZqBYL069CfxSmRJ36s8sXcxpQC747Au oLA4iSUhJCFPI9NkGCvAy3D9WrXFwtZ1a6jEl3RQt/ZDcUczYovc9C8XMc/LTjRDfkhOZwCeXOc NkSoT02GFdnE59f6VXIKDOwn6kow1e3c2CHyQCnZ7WUD8rlZzu3ql29kTGBBSNpNKlDPhgGaX6j W3CSo198N+T1RHn6xEjLJubmVLF+EKbXRSf1QcaFXF2PGhDOXfHvXcGpANV8Dft+t3mzIXUhUfm ewbuNVxyfjj9292Oi3+fn25ExSQX7ORHBkBPghkMk8WIjZDeZw7DI74yTviDXUIQ5hwVTnDjgdX nH12nKps1QyEcezSfUUYAMZi556eVukH8IyhT4Fr9hnPVlF9/nNPrxwc2iEfeNCf4EplmAgyF X-Received: by 2002:a17:90b:524b:b0:38e:250b:122f with SMTP id 98e67ed59e1d1-38ec6461d6dmr4058236a91.16.1784832361816; Thu, 23 Jul 2026 11:46:01 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.45.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:01 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter Cc: cocci@inria.fr, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/36] drm/radeon: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:05 +0900 Message-ID: <20260723184538.3888637-4-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/gpu/drm/radeon/ci_dpm.c | 6 +----- drivers/gpu/drm/radeon/kv_dpm.c | 30 ++++++++++-------------------- drivers/gpu/drm/radeon/si_dpm.c | 14 ++------------ 3 files changed, 13 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dp= m.c index 703848fac189..11707f5aaa6b 100644 --- a/drivers/gpu/drm/radeon/ci_dpm.c +++ b/drivers/gpu/drm/radeon/ci_dpm.c @@ -5244,11 +5244,7 @@ static int ci_set_temperature_range(struct radeon_de= vice *rdev) ret =3D ci_thermal_set_temperature_range(rdev, R600_TEMP_RANGE_MIN, R600_= TEMP_RANGE_MAX); if (ret) return ret; - ret =3D ci_thermal_enable_alert(rdev, true); - if (ret) - return ret; - - return ret; + return ci_thermal_enable_alert(rdev, true); } =20 int ci_dpm_late_enable(struct radeon_device *rdev) diff --git a/drivers/gpu/drm/radeon/kv_dpm.c b/drivers/gpu/drm/radeon/kv_dp= m.c index 1693b36fc52d..fc5252ff2a26 100644 --- a/drivers/gpu/drm/radeon/kv_dpm.c +++ b/drivers/gpu/drm/radeon/kv_dpm.c @@ -843,16 +843,11 @@ static int kv_populate_samu_table(struct radeon_devic= e *rdev) if (ret) return ret; =20 - ret =3D kv_copy_bytes_to_smc(rdev, - pi->dpm_table_start + - offsetof(SMU7_Fusion_DpmTable, SamuLevel), - (u8 *)&pi->samu_level, - sizeof(SMU7_Fusion_ExtClkLevel) * SMU7_MAX_LEVELS_SAMU, - pi->sram_end); - if (ret) - return ret; - - return ret; + return kv_copy_bytes_to_smc(rdev, + pi->dpm_table_start + offsetof(SMU7_Fusion_DpmTable, SamuLevel), + (u8 *)&pi->samu_level, + sizeof(SMU7_Fusion_ExtClkLevel) * SMU7_MAX_LEVELS_SAMU, + pi->sram_end); } =20 =20 @@ -902,16 +897,11 @@ static int kv_populate_acp_table(struct radeon_device= *rdev) if (ret) return ret; =20 - ret =3D kv_copy_bytes_to_smc(rdev, - pi->dpm_table_start + - offsetof(SMU7_Fusion_DpmTable, AcpLevel), - (u8 *)&pi->acp_level, - sizeof(SMU7_Fusion_ExtClkLevel) * SMU7_MAX_LEVELS_ACP, - pi->sram_end); - if (ret) - return ret; - - return ret; + return kv_copy_bytes_to_smc(rdev, + pi->dpm_table_start + offsetof(SMU7_Fusion_DpmTable, AcpLevel), + (u8 *)&pi->acp_level, + sizeof(SMU7_Fusion_ExtClkLevel) * SMU7_MAX_LEVELS_ACP, + pi->sram_end); } =20 static void kv_calculate_dfs_bypass_settings(struct radeon_device *rdev) diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dp= m.c index 4b10715f951c..4323f86000ac 100644 --- a/drivers/gpu/drm/radeon/si_dpm.c +++ b/drivers/gpu/drm/radeon/si_dpm.c @@ -6418,22 +6418,12 @@ static int si_set_temperature_range(struct radeon_d= evice *rdev) ret =3D si_thermal_set_temperature_range(rdev, R600_TEMP_RANGE_MIN, R600_= TEMP_RANGE_MAX); if (ret) return ret; - ret =3D si_thermal_enable_alert(rdev, true); - if (ret) - return ret; - - return ret; + return si_thermal_enable_alert(rdev, true); } =20 int si_dpm_late_enable(struct radeon_device *rdev) { - int ret; - - ret =3D si_set_temperature_range(rdev); - if (ret) - return ret; - - return ret; + return si_set_temperature_range(rdev); } =20 void si_dpm_disable(struct radeon_device *rdev) --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40E46488D93 for ; Thu, 23 Jul 2026 18:46:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832373; cv=none; b=cLPdezrZL0P71eNgnS+xmwiS0ob8KBAL60OGgox9BDUpIkCOBpmIS3ABI+W63kXmqgoqDF1MmX5SwaSXu07N0QzkC9YR7iNxQZyxd0r97SuskTJKOUJljyiaw2ETyD5vuqQ++QSVj14rYmx85TWcp+I46PrkQEjA9WZXQIUfdI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832373; c=relaxed/simple; bh=PPpYtX1bCmCOUQqG3jMTyzpSC2XUlQ7hOUx+Jcf23Lk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M7UXnwEw1W04ey+TNC+zTSN96GVgzV3yUBmMBK1d1i3doAYIg9t7EktEunnuVJ0M2N0HOStElunIrv0v9bxuOeFGPkWe8CvvyMA4xNUMSzrotSKLyFjgBTGlI9+PO/xIZ2zfCeGLhiz7vUVApZTR04KaDhzgz/6HB3CRaKX2fZw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qt5aTg2f; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qt5aTg2f" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38deea72eebso1081318a91.1 for ; Thu, 23 Jul 2026 11:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832364; x=1785437164; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qd/dKHIuRS/CtItZlX4/17nIeCWsz+xndXH+6leeAfQ=; b=Qt5aTg2fZjAiaCo5pfz6Bq8V2sYGUXk4abs7mwh67/UKJYelMhxpOvS4NIL1CEnOZT /kwUVLPP0WSNPKLD0aNjXniTbUA5WHPuSjDaddPUlBfpJDv6oPRb97qhKzoiaccpRnpQ 2v0QsR7CW5TR3xkzQ7HOBq/ZvDHH8r2PUQPvpvm/aft6rYABPfVBIKy6etGzuX+NF/e0 O0639itUhSiv+/1Wyx1UiCIJ7jkVaeBs1kHPS0Tar+wf+bsrW3Tm911VNCAmeZaCsIMl LXZmC6Vcjt7GD8mwDTxowMaYigE0OBWvJMkjCIoYhXNh6KWjddojpWbdCKao5LekgV6I YnxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832364; x=1785437164; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qd/dKHIuRS/CtItZlX4/17nIeCWsz+xndXH+6leeAfQ=; b=riK5X3W7y/KmxmELYdI8JTbfKccDla6bgKYrd7bZxRKZ6P4r1NRF3vNJX5X9qX5zsM +4AUWBUOJhkFnB6FcKsmvlf6uzJshVwzI9kzH3vmhFUda3/ullujsT98KJNj8L8GxdxC KFKkFnb0stF2ret2jr7vWtyFmgDzSAF3av3FnGc36VwJg8RTJoo7a5h1y2YuANB6QFon X9e2NtMTha4Yqs7lcHvzzLaKrjkmTQwH6Tgn+OKPY3mKZPp3Lr2bdAvQUUHoOd/1Q6+R 8fEj7pxcKlPCDI3kg/uZhdhYGBrezDA2EXNE1YBaiq7cI/gsv5KTqOydRSEV1Y+QQn1D FxCw== X-Forwarded-Encrypted: i=1; AHgh+RrPIVMufq+l5a4/8f6hgpNwLI6+WpfYaurl+WyXy8MhFlixcGy9kE9YwixgttqKT4B0iNUx+DN7LqKYMgc=@vger.kernel.org X-Gm-Message-State: AOJu0YzUofx2E1ELIqtBzlk+W/US8QvH6nfS+034sZ2Xh+NAsHKzAOiP f4fBXZ/3ixBErKUsd1QIHfhogZY2gt3dvPKyRb7KmjLlEJVWEroScvZb X-Gm-Gg: AR+sD136kTXJ+D0T0hObMlWTwV82wuFenvXgZobL0A5BsFkJ1f9F0Fx75IFzfEfkUin hQ8AhUMsWbpQgTJJE1P+YBGSg/t7KAQvZaZXhlCDL6vobgXPa1EWxfjaRPqX26wLdXPL1auKdZz 5fBnjxD+qvVyqBbaB9ZCt5qUqnjlPtBcWkskMdIgpMvPfGmCK/7T+m0Co1cBBS55uVmHSyq2OuV 4rk1Z/bt4QB+o7hmOWq9cWC55B5yLA1IJXub8+uinmCeqYyYIJBGlFzi9vRZFKqhvi/ER1YjOeY lGXu/xpO57AcZxj3X/1+kNV3p9+pxe4uKUN4/SIH/AyWA7bBzHHXhaGdTbErleQgHzWQhJJRpbg yUeE4fAq/k+/nc2/CdfS9tMNOneimznWwJyRQWYMXRl8txbL20/JihuVyNEw4KVKuIG/9XjB88M FdHMZyrm4= X-Received: by 2002:a17:90b:57e4:b0:38e:79f:76ad with SMTP id 98e67ed59e1d1-38ec6566203mr4405122a91.23.1784832364154; Thu, 23 Jul 2026 11:46:04 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:03 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Ivan Vecera , Prathosh Satish , Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 04/36] dpll: zl3073x: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:06 +0900 Message-ID: <20260723184538.3888637-5-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/dpll/zl3073x/dpll.c | 6 +----- drivers/dpll/zl3073x/out.c | 8 ++------ 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/dpll/zl3073x/dpll.c b/drivers/dpll/zl3073x/dpll.c index a2a641b8358f..0488ae6ac486 100644 --- a/drivers/dpll/zl3073x/dpll.c +++ b/drivers/dpll/zl3073x/dpll.c @@ -2272,11 +2272,7 @@ zl3073x_dpll_init_fine_phase_adjust(struct zl3073x_d= ev *zldev) if (rc) return rc; =20 - rc =3D zl3073x_write_u8(zldev, ZL_REG_SYNTH_PHASE_SHIFT_CTRL, 0x01); - if (rc) - return rc; - - return rc; + return zl3073x_write_u8(zldev, ZL_REG_SYNTH_PHASE_SHIFT_CTRL, 0x01); } =20 /** diff --git a/drivers/dpll/zl3073x/out.c b/drivers/dpll/zl3073x/out.c index eb5628aebcee..410d15b96d0b 100644 --- a/drivers/dpll/zl3073x/out.c +++ b/drivers/dpll/zl3073x/out.c @@ -85,12 +85,8 @@ int zl3073x_out_state_fetch(struct zl3073x_dev *zldev, u= 8 index) if (rc) return rc; =20 - rc =3D zl3073x_read_u32(zldev, ZL_REG_OUTPUT_PHASE_COMP, - &out->phase_comp); - if (rc) - return rc; - - return rc; + return zl3073x_read_u32(zldev, ZL_REG_OUTPUT_PHASE_COMP, + &out->phase_comp); } =20 /** --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5929353A8B for ; Thu, 23 Jul 2026 18:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832386; cv=none; b=FVtPuqnLRD8H9WE3me+o81jCDsnP1HTzBsJscm9JTEBmykmxlTy5kP/lVeSs+8/kvVw0IX34xg9JzUWFvSCSN9TbwupWUmzVPR/CsOav+Gyz78BS57z376oYOAQIPYbBCSTG+E7834d1eerH1t0qol+wpwh3dGV498hxZsx4wgQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832386; c=relaxed/simple; bh=iCij80qbxvGV+a8hzW5WU4WAS5USF0l8tEZxags5rG8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g0qu+rZHsRm5af1EiPOSvjp8v17ICtIz0G9/AcXAUYlgxw0Vqr7jXZNEGXWioypw+rrKjWKeDAWObuZnOkSwBp4kazLtPuVIYSedETIiDQMW8HoFFVCLEivQqc/aIJP/TfTUNtZUtrLu15RArJw1e/93/JvcUF6SeXaRfw8Lx+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JuChBKgT; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JuChBKgT" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3810c5d691bso818706a91.1 for ; Thu, 23 Jul 2026 11:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832367; x=1785437167; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6s5SzAkwTqv2cG0ZEuCiRJMYbGatFZIR2B9nCnRkYh8=; b=JuChBKgTldeds6XdmD/NHBFGzv0LXJ1smq7SWxpyJA2yimTK899kXO4C4gU3/sd6gK RXBJEUHrqvIWN3/3BtIxBzIWQjCUa/wSJEvI4rFAj7B6uQjR/5K1w7c6Oha9YaEvSamD UQ/Y/iRL/mQTvgKGUtTu2mQBc48wQiW5v4XKhSl+X7Wik50vaNeUesDKZafhrSkAoEpP fEV/4NYh9aJJCLUMETUisdg3t+ExOf67nBi9dChIMTV7HMZx4FheQlqnZjKtqPjSKccH ahkDWWLpXjbBea9DLwrV+gO+fKzzIAKZ0sx5M1d1wj3tl8Grqi1l/CoVDvuNsP/dz9dz ApVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832367; x=1785437167; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6s5SzAkwTqv2cG0ZEuCiRJMYbGatFZIR2B9nCnRkYh8=; b=DSFfZIFcr1Xq3Ml6B1vj1p49YK5iJgTY3YzA/QXegvPN0DSckA9sBeYB3UwiWmtiue W7tDYaw4RUxQPulptQyRsS8ipztLImOgEYSZbbWqFssh7jCVqrtHxGAAQc9fQBSvtJYU ummgIEFwJBbswGpocVdir1BcehFyOGj/Xo8N1HWhk9/Tt+O2X5Nr7gJx3i1pcZNO5J7A shgLjjWh9B6QhyipUAoBKvVvfiejstjiKkU4rlbv0I4saMZchZiXig+NEA72c4tDSrBp PC8PFmJtqllsuhV51JbWsLPNww37v2XCmRFzd1PIXwYXFT31M+iSMtQqcKumki03Q2CF LsXQ== X-Forwarded-Encrypted: i=1; AHgh+RphJ4w/y7cGYmpHWIjmHWabo/P04hH9impceDfarQFeCZjJMoPAtG/9F9DxsuZv7ZPbSA8bPHhHXTZam+s=@vger.kernel.org X-Gm-Message-State: AOJu0YyOL3eLVeWqu4/6P9I4c4AkFmn7doY42WwdZs7m2hrrXIPv4ir1 euishsiV8RbCpU4ZpAG/xbgvk2j/MCmD5gs9WZix6Rfsv1z7Ot1tqr38 X-Gm-Gg: AR+sD12Bj8axguvIWPMZK66vTLdx5iAU2ltqWP7SpUSiTwO/m2sBbV0bejgvJeFKg+W D4L7okG6gMcL3IR+x2hPDhiz+6VoAHLA3HRN5enN7eSig7pzLlLkD1cmIpkZxL/JsmenJuqPqdH /h06nhMUKPtuQZjbAuG88AjVd1C3dKtkkm0x/vIIRKM4beATTQNpPO8mQy7/bH/e/+6U/nvO5LO tRds1rmZvElo+N6elsa99SNZSUeK8a41/tkhOK4XfYdRJdQ0c6y/KlVZW0HmI7VZuNOh9S3cORP 09DKxUHhKrh8ItoJZUSHqEJ2pjGYh49QIg63FojB4eaF0nGYte4OwE3M4wrtSbc/LUqo7rx+/b6 WgPqFnXOTzBr8NPDLqeNvTevLmJaHFtATaLNoLnJUHOemjhmxPNHbWwG9UXHhgVN9QjuWiAzb X-Received: by 2002:a17:90b:4b92:b0:37c:18e0:90dc with SMTP id 98e67ed59e1d1-38ec697d294mr3808455a91.16.1784832367424; Thu, 23 Jul 2026 11:46:07 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:06 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter Cc: cocci@inria.fr, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org, Zhenyu Wang , Zhi Wang Subject: [PATCH 05/36] drm/i915: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:07 +0900 Message-ID: <20260723184538.3888637-6-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/gpu/drm/i915/display/intel_hdmi.c | 7 +------ drivers/gpu/drm/i915/gvt/gtt.c | 8 ++------ 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i9= 15/display/intel_hdmi.c index 8a019d3574df..90880be63a1e 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -2658,13 +2658,8 @@ static int intel_hdmi_connector_register(struct drm_connector *_connector) { struct intel_connector *connector =3D to_intel_connector(_connector); - int ret; =20 - ret =3D intel_connector_register(&connector->base); - if (ret) - return ret; - - return ret; + return intel_connector_register(&connector->base); } =20 static void intel_hdmi_connector_unregister(struct drm_connector *_connect= or) diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c index 5056a5887b31..6bca40128d99 100644 --- a/drivers/gpu/drm/i915/gvt/gtt.c +++ b/drivers/gpu/drm/i915/gvt/gtt.c @@ -725,15 +725,11 @@ static int ppgtt_write_protection_handler( { struct intel_vgpu_ppgtt_spt *spt =3D page_track->priv_data; =20 - int ret; - if (bytes !=3D 4 && bytes !=3D 8) return -EINVAL; =20 - ret =3D ppgtt_handle_guest_write_page_table_bytes(spt, gpa, data, bytes); - if (ret) - return ret; - return ret; + return ppgtt_handle_guest_write_page_table_bytes(spt, gpa, data, + bytes); } =20 /* Find a spt by guest gfn. */ --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D2894D98EF for ; Thu, 23 Jul 2026 18:46:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832386; cv=none; b=vBkva6Km/xej0U/3/1GLTL/CAfGE6uX8P6d8IGdN/9KF10X0We/pH+xR6/UUQNOp41q9hLxbl+xOJAgvfNXbcR/bd+ii5zHqpwwun2L3BLrem/xDdKZkp96UMiCMPRcMgR7KloxEU/aNqsAGmNapvXj3Ix0k2boIw2tnOkLI034= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832386; c=relaxed/simple; bh=/V8mneptUPJ/q4aURKAyvm+FJuT8YJEma4JCKxUZvG8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eOHCxF0hXN6YZT9U4WLnvm+FGz6dWgx0OYpv9duDauwdI0LW5ZEun4rnSQf/6w6ytzVL687/VQB033mzvxHoTfURCWQBmbeY5dR6fLIQ9G/kB03N43kaKXTEsmd8JeQBZgpqkPE7fSS8XdqmsjxUtB9ltAml2NFOLz0fYfWVbmo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ccQdTDEO; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ccQdTDEO" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-385ea3ce80dso961345a91.2 for ; Thu, 23 Jul 2026 11:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832372; x=1785437172; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lNzFXtDRL36sjfeetYaoRGkJ3BZXJkrvXWbUMZXEOzM=; b=ccQdTDEOdSllfqpdERsORnIZf3clgJc+zXrfBvAEpT8h5Qvih3+SRAwRmncZ5rFcqy zFErylOHtpYudSvl7XFEMLfuf1HsfQOqswC6bPvrcAqPrB0MGYQo9AqVscm0GW0MEf5u ZCC9uKhcFGTh4cH65BdlsAVJ4P3HQ3bXz83Lb/cicG282cdIAa/CUO98vC51MFYKk/PX BkNY/4DlXcbD4LQSfTIrgh9+xDNwo8fmkT8gtbIoOCjplKLX0p48iTA7Pst7ZuaxwMLV fa1FPmRv3iNsIiOBPo7hjcO1s8sifgEGtoubbUCQqntIW/AXf0jVQD/F8Qdt0O2/boQe +wWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832372; x=1785437172; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=lNzFXtDRL36sjfeetYaoRGkJ3BZXJkrvXWbUMZXEOzM=; b=aSSBuOXGu7vO+BnzsdiJerXygyRuWvHFdNOJYtHsz5VP5W7aQ3gKiWuYTe8vFJ6LM5 TDSgKJWJd4leqQQVzfS4TvN2H8K2IDCorsvuikd3gJgGn7/ffR8Y1D4yZjcbD8khIaSv 3g08rKex3XZ22W1YFhNidolU4wK48nTGORDT15EW+bA4OERqerNPybMqkIKzV9cQ6tZd JCJq78BkiPEC8KA6CWf+sjPgIVzwbmMmwWOv7O1S4wshao71zsqCmmI+uuhF5UmSW2hJ 5QR2tS6TtOn4I3Ga3cPrf8sgKW/my4IN4mvZCpMQdBaa4xMt9v7QS5Qni9RuzOBCMbza AV7g== X-Forwarded-Encrypted: i=1; AHgh+Rp5+mab+DTxs3j6t7SgxQlRy6jM42HUAG/LtohbMksVsWhP4KTz5LvLZruAribgMTbdMg/Iban0QSn3MGk=@vger.kernel.org X-Gm-Message-State: AOJu0YzDKSGGk4chxZN5GRrP5pJIWSPwWAOK2NP3MYnGhUKhfRxauiNv y3rbvR2Dko1bgF0FSY7u+UV3o9ohUh6K74UigIY4CVkTuqJK9ak0TLto X-Gm-Gg: AR+sD11lyEHXwHsqaFyGhK3fdfot+Huh0MqThWhUqPKF2yixfeARVEZQfmLTq/sUms5 PV4KSKDL05jUv0uHC8hCVDSP9tMIzskeHTyKAYMMsEtwm4op+Ui2HJj3/NpvUxa2Fzo0IjBzHF4 2wCltTRohgaGO0nusm31BEtVRvWHN82rQmkNPgfEWzN2a0uOaK9sl5gPn7QOCeaCgunaGVv+AUw 0honOjAOcjH3nfWXInYkzEvEec8QwY5jquxGQNzbSAoCWNM8Vrqwu+kFQW53bHK8OTK24bT3HGW ZNYaVzBqOLkv+UmvXtCyUPQM7tZAKbFQD7ZP7iwRIqzUbThliKX9nRQh3TBr0hPb3OE9kw0u3uC c2Ng5WV2QXVTQaxLcoTCnYPKHXgzpVyeEOG90YRKqUR/poRC1Ucaw+PCgwMfjbIy7YanHK2gp X-Received: by 2002:a17:90b:1d02:b0:38d:dfd1:7c1 with SMTP id 98e67ed59e1d1-38ec6499300mr4568453a91.2.1784832371666; Thu, 23 Jul 2026 11:46:11 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:11 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Lyude Paul , Danilo Krummrich , Neil Armstrong , Jyri Sarha , Tomi Valkeinen Cc: cocci@inria.fr, dri-devel@lists.freedesktop.org, Fabio Estevam , imx@lists.linux.dev, Jessica Zhang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, Pengutronix Kernel Team Subject: [PATCH 06/36] drm: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:08 +0900 Message-ID: <20260723184538.3888637-7-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 6 +----- drivers/gpu/drm/nouveau/dispnv50/disp.c | 14 +++++--------- drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c | 7 +------ drivers/gpu/drm/tilcdc/tilcdc_drv.c | 6 +----- 4 files changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c b/drivers/gpu/drm/imx= /ipuv3/imx-drm-core.c index 51a0ec043248..52a2334be799 100644 --- a/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c +++ b/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c @@ -55,11 +55,7 @@ static int imx_drm_atomic_check(struct drm_device *dev, return ret; =20 /* Assign PRG/PRE channels and check if all constrains are satisfied. */ - ret =3D ipu_planes_assign_pre(dev, state); - if (ret) - return ret; - - return ret; + return ipu_planes_assign_pre(dev, state); } =20 static const struct drm_mode_config_funcs imx_drm_mode_config_funcs =3D { diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouv= eau/dispnv50/disp.c index 364227f5456f..e8fde399acae 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c @@ -301,19 +301,15 @@ nv50_dmac_create(struct nouveau_drm *drm, if (ret) return ret; =20 - ret =3D nvif_object_ctor(&dmac->base.user, "kmsVramCtxDma", NV50_DISP_HAN= DLE_VRAM, - NV_DMA_IN_MEMORY, - &(struct nv_dma_v0) { + return nvif_object_ctor(&dmac->base.user, "kmsVramCtxDma", NV50_DISP_HAND= LE_VRAM, + NV_DMA_IN_MEMORY, + &(struct nv_dma_v0) { .target =3D NV_DMA_V0_TARGET_VRAM, .access =3D NV_DMA_V0_ACCESS_RDWR, .start =3D 0, .limit =3D device->info.ram_user - 1, - }, sizeof(struct nv_dma_v0), - &dmac->vram); - if (ret) - return ret; - - return ret; + }, sizeof(struct nv_dma_v0), + &dmac->vram); } =20 /*************************************************************************= ***** diff --git a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c b/drivers/g= pu/drm/panel/panel-osd-osd101t2587-53ts.c index 2334b77f348c..16a02527285e 100644 --- a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c +++ b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c @@ -58,13 +58,8 @@ static int osd101t2587_panel_prepare(struct drm_panel *p= anel) static int osd101t2587_panel_enable(struct drm_panel *panel) { struct osd101t2587_panel *osd101t2587 =3D ti_osd_panel(panel); - int ret; =20 - ret =3D mipi_dsi_turn_on_peripheral(osd101t2587->dsi); - if (ret) - return ret; - - return ret; + return mipi_dsi_turn_on_peripheral(osd101t2587->dsi); } =20 static const struct drm_display_mode default_mode_osd101t2587 =3D { diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/t= ilcdc_drv.c index 1d6c9a423a41..990805f1fea6 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -64,11 +64,7 @@ static int tilcdc_atomic_check(struct drm_device *dev, * tilcdc ->atomic_check can update ->mode_changed if pixel format * changes, hence will we check modeset changes again. */ - ret =3D drm_atomic_helper_check_modeset(dev, state); - if (ret) - return ret; - - return ret; + return drm_atomic_helper_check_modeset(dev, state); } =20 static const struct drm_mode_config_funcs mode_config_funcs =3D { --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7033A48A8A2 for ; Thu, 23 Jul 2026 18:46:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832386; cv=none; b=VXW12Z5L/cbrWeHqocQXtfslBVItEI/KUUDNOh22p5T6vvtZ9iYwzMrp2k52/fPyrQJifMHophRx4wSJl8R45wk/2zmD3BkbyrqD84yFNaDxi6CRTZoMTy0VEB+s8WlAS0jxLSoso53ip5yaVo7vX03a5WkMR1qIWzUe/QG+w5k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832386; c=relaxed/simple; bh=4nPOOxQQdsH8s+vHIqe3mHFKEUuR7Q7OhqCIYNGa1DY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FoKFwPy5EjgZWZ5Mi8ZlqoVwpRwXI+E77oxkkVK9uppiObW6UowLy8ZsS2gOruL6PR95X1wjJav2UGSCMV59GrdX/XPDf0ZAKemP+3tyeNYAXRx4OLrbs1K5JfoZeNovBwS77t6EiNwNfG68Ir7uEY5myqnmflj1dwK9Ai0lFpg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NKMrNrjE; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NKMrNrjE" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38101f85591so777463a91.1 for ; Thu, 23 Jul 2026 11:46:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832376; x=1785437176; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QiNsXajlQRLTmIS3RzF6Ciae3Ovg515LecRLWPQA57w=; b=NKMrNrjEwXAFWbuy2PddaHTBcfdK/dVgCS7gJHlI68vW0sNh+mEwvX+PLrt50C/56+ XTPZmnY87ObbFBOXdGf6f13lLHVyoIuFljuzgzvJD2+fdRsCmUJ29Z4ZQ1mQbNnWGWW0 3xeYTp0ZeEWJ4py6WKaDOnwmcD3S5u5WghPQGRzUuJH5jEZajbagajXfJ7EGnvRj4Ypv aN4kYZ54UYglFHhKtFzA+t0JAM7t6e84Ja/T+sC4M2TjQ8lIw2JFUS0H4cx5/jVZSghQ J5QvL3RSZpdL91GoXPk+6RJeVUuZSvGiMZooW1WKKl3OUK0j9/7Co1WE/aoCD4ZZO1VR Y+Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832376; x=1785437176; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=QiNsXajlQRLTmIS3RzF6Ciae3Ovg515LecRLWPQA57w=; b=FuervaquPd9/tN3n4s8rQghlKQJf4ccye2WBphI+KdZbOtUc/aaaXkwt0dcWyRuZKv 9KrIRFcLMBmRPX5HPEY/z6BdwSkZ2JH1ZR7M3+VukoAATETlslHa6ELGqokVKv6zsS4p YN+eP49y7xvYmcWzxdiZSUwQ4Y1CwDdnsenAo2YO8+fQhYxwkgzrml8bX4g8nVqBXvbA 4a8NAdS8L2CDyi9g4PQd5pr9NSnOeKKhAwkK/BUEqjpULccpGhyKpOCwLdaHhKo7c9y9 TtpONmyyi+6RWBZkKTIh+tqbeJoRLzI3Sjmr41HL7buOpjA05sBa86Kcl5gHaeROUdZC piVw== X-Forwarded-Encrypted: i=1; AHgh+RoXwdp5EubNhpAcC2Pb0shPcobHk1SGBdLCKr+bHG+plj/mJgaSzR2bg0LrDqyG4kKogFJiPnUftfrWqyY=@vger.kernel.org X-Gm-Message-State: AOJu0YyPcHFQCETRTUcIJioTx29Trg+nvzchc7jJPoHCAJu3It+EJhDN JU6gOxKy3WfJRkcPz9/JJ4QDMpRGryDqkKG2uTqZU6qyBzjsSjIN4wf9 X-Gm-Gg: AR+sD114BlPCrzXkCegmrR10O4dzc0WefAoLLGLZv6SQHIcCyROFakEv+et3Yc+qUEw c+vMkSgra0Ml3mhDW+Rf1m66a8HolSr2W1+w5RS/iI7WvODWAekWWLIAXifvmQG987JEJ7pjfNh wFymxCKVW2JfbIzFg8z92vsEn3xawe5JC/ynJ+G+Pt5PKkxOBh376Rm6BoV9urP3tCTLNz+L6cP XQo2zNpc7LnNMmGT85KOE0M1aoXcRItXp7UUStkIGzpfEc0wFMs8JoVcMpvusFrO1K26wTjimBc 5048hiLFCeID3US3XfCP0EyZbTT1syhYcBFSJCCUay/pQyIZ9KjS6wJcQiGx6eic954Ho5A4ZM1 /kr6mvQZSgHFFL8jNOXOx9DQKvfiF5SIpA1ozchYXZU6vJTm8vbgtbbPdFmyJxYjWOT5kWFpd X-Received: by 2002:a17:90b:4d83:b0:38e:4f42:d0d6 with SMTP id 98e67ed59e1d1-38ec8461966mr2882664a91.12.1784832375589; Thu, 23 Jul 2026 11:46:15 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:15 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Arthur Kiyanovski , David Arinzon , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sukhdeep Singh , Ioana Ciornei , Claudiu Manoil , Manish Chopra , Rahul Verma , Shahed Shaikh , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Sabrina Dubroca Cc: cocci@inria.fr, GR-Linux-NIC-Dev@marvell.com, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 07/36] net: ethernet: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:09 +0900 Message-ID: <20260723184538.3888637-8-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon Reviewed-by: Arthur Kiyanovski Reviewed-by: Niklas S=C3=B6derlund --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 6 +----- drivers/net/ethernet/aquantia/atlantic/aq_macsec.c | 6 +----- drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c | 6 +----- drivers/net/ethernet/freescale/gianfar.c | 6 +----- drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c | 7 +------ drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 6 +----- drivers/net/ethernet/renesas/rtsn.c | 7 +------ 7 files changed, 7 insertions(+), 37 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/eth= ernet/amazon/ena/ena_netdev.c index 5d05020a6d05..ea89619039d8 100644 --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c @@ -2303,11 +2303,7 @@ static int ena_open(struct net_device *netdev) return rc; } =20 - rc =3D ena_up(adapter); - if (rc) - return rc; - - return rc; + return ena_up(adapter); } =20 /* ena_close - Disables a network interface diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_macsec.c b/drivers/n= et/ethernet/aquantia/atlantic/aq_macsec.c index 3ca072360ec7..fd4ee6212234 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_macsec.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_macsec.c @@ -735,11 +735,7 @@ static int aq_set_rxsc(struct aq_nic_s *nic, const u32= rxsc_idx) sc_record.valid =3D 1; sc_record.fresh =3D 1; =20 - ret =3D aq_mss_set_ingress_sc_record(hw, &sc_record, hw_sc_idx); - if (ret) - return ret; - - return ret; + return aq_mss_set_ingress_sc_record(hw, &sc_record, hw_sc_idx); } =20 static int aq_mdo_add_rxsc(struct macsec_context *ctx) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c b/drivers/= net/ethernet/freescale/dpaa2/dpaa2-switch.c index 33e7a99d3e49..79d4a77f72bd 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c @@ -3935,11 +3935,7 @@ static int dpaa2_switch_port_init(struct ethsw_port_= priv *port_priv, u16 port) if (err) return err; =20 - err =3D dpaa2_switch_port_trap_mac_addr(port_priv, ll_mac, ll_mask); - if (err) - return err; - - return err; + return dpaa2_switch_port_trap_mac_addr(port_priv, ll_mac, ll_mask); } =20 static void dpaa2_switch_ctrl_if_teardown(struct ethsw_core *ethsw) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/etherne= t/freescale/gianfar.c index 89215e1ddc2d..cf636fc5aafa 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -2877,11 +2877,7 @@ static int gfar_enet_open(struct net_device *dev) if (err) return err; =20 - err =3D startup_gfar(dev); - if (err) - return err; - - return err; + return startup_gfar(dev); } =20 /* Stops the kernel queue, and halts the controller */ diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c b/drivers/n= et/ethernet/qlogic/netxen/netxen_nic_hw.c index fff8dc84212d..e96a268067f2 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c @@ -2478,7 +2478,6 @@ static int netxen_parse_md_template(struct netxen_ada= pter *adapter) static int netxen_collect_minidump(struct netxen_adapter *adapter) { - int ret =3D 0; struct netxen_minidump_template_hdr *hdr; hdr =3D (struct netxen_minidump_template_hdr *) adapter->mdump.md_template; @@ -2486,11 +2485,7 @@ netxen_collect_minidump(struct netxen_adapter *adapt= er) hdr->driver_timestamp =3D ktime_get_seconds(); hdr->driver_info_word2 =3D adapter->fw_version; hdr->driver_info_word3 =3D NXRD32(adapter, CRB_DRIVER_VERSION); - ret =3D netxen_parse_md_template(adapter); - if (ret) - return ret; - - return ret; + return netxen_parse_md_template(adapter); } =20 =20 diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c b/driver= s/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c index 45ed8705c7ca..47cd9ec665ee 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c @@ -1618,11 +1618,7 @@ static int qlcnic_83xx_check_hw_status(struct qlcnic= _adapter *p_dev) if (err) return err; =20 - err =3D qlcnic_83xx_check_heartbeat(p_dev); - if (err) - return err; - - return err; + return qlcnic_83xx_check_heartbeat(p_dev); } =20 static int qlcnic_83xx_poll_reg(struct qlcnic_adapter *p_dev, u32 addr, diff --git a/drivers/net/ethernet/renesas/rtsn.c b/drivers/net/ethernet/ren= esas/rtsn.c index ee8381b60b8d..f7beeb73eb16 100644 --- a/drivers/net/ethernet/renesas/rtsn.c +++ b/drivers/net/ethernet/renesas/rtsn.c @@ -685,7 +685,6 @@ static void rtsn_set_rate(struct rtsn_private *priv) static int rtsn_rmac_init(struct rtsn_private *priv) { const u8 *mac_addr =3D priv->ndev->dev_addr; - int ret; =20 /* Set MAC address */ rtsn_write(priv, MRMAC0, (mac_addr[0] << 8) | mac_addr[1]); @@ -702,11 +701,7 @@ static int rtsn_rmac_init(struct rtsn_private *priv) =20 /* Link verification */ rtsn_modify(priv, MLVC, MLVC_PLV, MLVC_PLV); - ret =3D rtsn_reg_wait(priv, MLVC, MLVC_PLV, 0); - if (ret) - return ret; - - return ret; + return rtsn_reg_wait(priv, MLVC, MLVC_PLV, 0); } =20 static int rtsn_hw_init(struct rtsn_private *priv) --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D916148A8B7 for ; Thu, 23 Jul 2026 18:46:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832397; cv=none; b=tXSuA4MUkrB5TaAwqpOLo4XyUC7MJCuMPQZXCXSvJOmZ79P20VdvZYYTRlAtPcFUb1+j64KS2FxPc/vdBR2r8dlwAbChsJXlZZSVq2az4D8xB2vOSTzOckv5MQeLTAfhGtpLPbFc6gISKbyP+Wj+mpIJ0krspLgVb/QYLK6OWNk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832397; c=relaxed/simple; bh=pXLTAUkjCgRFuHbdlrm9wPCFAoCGzZnJNnZvsbZon1Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B4o9NWEuUvGgivzF2fXcvpDYRDEcAKDhoNRAIzOs7tXe+igCllkJIxPW0rRhghsYJNJSKwwe6BrZHV3taHIH3yPFw6SbBoG/3AzEjZgdOPIKecpxQXPdiPNIU8FY5LI7tX5Rg6mZQyW4nlPuzja458BhnB4PtgzauABddcKfDW0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I2SybAu/; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I2SybAu/" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38dcbade417so1041261a91.1 for ; Thu, 23 Jul 2026 11:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832379; x=1785437179; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mTuJvAzG5mLe5AUB4aEimify+WXcEx2MLUBwrRB2paE=; b=I2SybAu/NbDXH3Ob+ZOTehOR3mWbaldDLvt3AnuUFR0g+clbZiHDKZ6XWlIb1aEfup g9YEjPIQProUmTUm86KaLeJjNIdrB/v17gdBA7wRsqu+nx7dM/gL3W97BAqtkZg9Caka HfOdyq8Bl7JXhGbNolima/104MJD8VXX+8Hu1bT8r6DQmzyNNf74VZSs5oplTgXUoUec /tjZG4cFyY6AhbnT2l55Drdw8f6L2xfmuI/1HmTpdF1v/6VUISBmGokBAiddviP9n/n4 ozG5mxSJc6w16FvPgpg5qw0Ql8jq5J2nJb7G0wu9BRr2EWyY2mvWDRNTpdetldk2obNX nGqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832379; x=1785437179; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mTuJvAzG5mLe5AUB4aEimify+WXcEx2MLUBwrRB2paE=; b=AI/SRQ+/suRItIjMipFB90Ztd8BtA8BSdh8G+fyWBXR/AxWLmFJE20qfc5Pdo4xYmu yl3RzSWENmc6UP7oAbS8likbMHw3r7XeeAbepVHRo4KhrORE2D/9F5TmApNSYEJf6I// 6tMO6nBrTpHFy8SfEWxtXS6ZHYIrNjSvoiU/hwva9YcbuyAbGLem7ETI0IXAahfi/HNq tA/oDcDRlh6K57as2zQDgewMei9hJrn8C2/twh7nUCr0v4Pjv5sVCu4HDKxkJWywVGJK tAM8NAHbSqCZxmsrdDDG4EBL0nYApKl6eVgATaL/1tfIDKUXsj635NqJatg7bis7qMG5 IIPQ== X-Forwarded-Encrypted: i=1; AHgh+RqyV6mO9eXZ4L4uPAxQlknCYD5OrHftbJ0wi2M3rVsTMN5g7t1Vg0c8N9oiXla6okot6IEkiws2JIWwLnA=@vger.kernel.org X-Gm-Message-State: AOJu0YzoTmrptDpbYuiMgWZA94eBMXxRN7zA1cqAjCANIzQjn6v8z42v zvPY2wpTsgwf2o3D2pBqU2+hvYy/gjDMSVHNcAZH2V77WBuNB8Jyi5Kv5l8fPCGlZik= X-Gm-Gg: AR+sD13XDEPFPvT+RuMNGzywIxvxjHgAcvvBOyTUuC5WLC/WV3CBJiIOdopncVPMHEf vLXwY+2WynLjqHzjjQiCaV5M4XFlvkRfVZeqjT4N4VV4ZuF/g1HD1KX0OsdSSVDN2aBNzLlxMpa JghFC3BproZrf6yrr78+SYruYwWAgmr0cOm650fYaQBN07kG84XxIAWlpJ0ZiHlOLSiL1LUybbq ovNMxTJs8hwSl0FWaxzc0ohg00PsIobTKEsLSbasfnVbSDd/vOr+iy+jKF+V2hK0/TaHzOpImGL VJVqzIByLCcaawRHrjooYv4lnfeZl+YaaOIb5saOeboJOMu4omhU8ESRnWDT41GHQobQyFi304Y i8ElJsMsHLaU2uERvVH4PDvq2G/FrgO5L+tsAyqUVdGF71/zilbAh5ryy7ZvSChxVz8135bZg X-Received: by 2002:a17:90b:50:b0:37e:a09:2640 with SMTP id 98e67ed59e1d1-38ec64958fcmr4523372a91.7.1784832379247; Thu, 23 Jul 2026 11:46:19 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:18 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Arun Ramadoss , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Oleksij Rempel , Kory Maincent Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Russell King , UNGLinuxDriver@microchip.com Subject: [PATCH 08/36] net: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:10 +0900 Message-ID: <20260723184538.3888637-9-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon Reviewed-by: Andrew Lunn --- drivers/net/phy/microchip_t1.c | 6 +----- drivers/net/pse-pd/tps23881.c | 6 +----- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c index 62b36a318100..3292b2235c8f 100644 --- a/drivers/net/phy/microchip_t1.c +++ b/drivers/net/phy/microchip_t1.c @@ -1028,11 +1028,7 @@ static int lan87xx_read_status(struct phy_device *ph= ydev) if (rc < 0) return rc; =20 - rc =3D genphy_read_status_fixed(phydev); - if (rc < 0) - return rc; - - return rc; + return genphy_read_status_fixed(phydev); } =20 static int lan87xx_config_aneg(struct phy_device *phydev) diff --git a/drivers/net/pse-pd/tps23881.c b/drivers/net/pse-pd/tps23881.c index 49d6389da067..8a3bbd623412 100644 --- a/drivers/net/pse-pd/tps23881.c +++ b/drivers/net/pse-pd/tps23881.c @@ -1520,11 +1520,7 @@ static int tps23881_i2c_probe(struct i2c_client *cli= ent) "failed to register PSE controller\n"); } =20 - ret =3D tps23881_setup_irq(priv, client->irq); - if (ret) - return ret; - - return ret; + return tps23881_setup_irq(priv, client->irq); } =20 static const struct i2c_device_id tps23881_id[] =3D { --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B44F041D226 for ; Thu, 23 Jul 2026 18:46:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832392; cv=none; b=IxbLMSONhXJJ8AYaMsnk/vbwCyhEoyjrDVcSJcs8ybK2+re+wapgCaqZvFbi5F5qJBfXje3B94Kf/Ej+AjJB+PR03zmAUiPsjDy80D7Z3OUA2ETUNQBGACBULfsFKQ8fVPDfULfrvaT12wPbPZsbCuVn+ltZ5BR8WJiZnmm3yMk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832392; c=relaxed/simple; bh=urFPXC2bDGFRb3YEWf5ToWXnZVSrmuUPwVRzUD+dqlY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kdpXryqxa9KUeQ1TvOxU6wmGdqMrgVDI0/DpJC+o0n81dCpq1yyoJ1kkerloI1bvJ+xCt5xJf17iPkzcoY40XbK3/0xCDLWgTxu9zz/4LxbwcuKYIQAHONyQeKn5Pxsq5KEb/5AMCJ0LHVJOqDoNL78guHvnqHUdzTuXdWyWhFY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZysxmINY; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZysxmINY" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-38511175ad3so736235a91.2 for ; Thu, 23 Jul 2026 11:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832382; x=1785437182; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kxRvmx1wxGvV8pBQOXsif8sDMDGk8D/ZvwH0veNhWow=; b=ZysxmINYypslLelTrq15Hxa7Cplwyi0Q2Wp5PFsML9nEo67/mprZWkssYVXYRM5uE8 b1Ygrr6BoX15S5asvEd1dKqykBZ9feWjescyheGSz8+UyYB6FMmlNtqK7IFI6gsENX9J JE8ZOojtcEw9fsMFse7RB++GAIISb4Mm8w1Kf1x+GkVZ3xCqQiKBIAy3VddECBQRaujD F1DrXRzMVu9lIZXaq/f20C7VUeLtB0w6bX42RKee0dDqZ4hHH5HOt8NBFbKbZwY0uwcd eiaztjbBZfBJsYpWy85CSXF8dQ6ooancGhX0m0Vg4BbY2U1ypZ3Ap4JPbaT1bI5gF1n8 5qXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832382; x=1785437182; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kxRvmx1wxGvV8pBQOXsif8sDMDGk8D/ZvwH0veNhWow=; b=Qz/1IcHOyXRZuxkbW0PseVL9iibgUO0+KVC2ah3xcJoNHqGwmcv/yQ/jQNoAepS8wV vKclQP34KTethgk4HQq6ZfEfORfdjIHpppmZPkO2Qt5SPz9iV3Fi+6WwjKlFLBTAYvVh HurYizyoBBahVSfCS9OgqeANkrc81p+2V0D8HiCxU+IUa8j9rza5jJ27g5tFv9HLKSEw UtuSbl8pMF64uaOflY/2IuhHnkqXFy0H5l/5PT57yE5UtCuqsHWqBnYzG5kCis21gMaW nWeJNHCXuUrk+2MUCoNojl+uYN1IbtD12CxZ+NEFwp0M+1wi7SNyodrMv81fabK2vg1i 3zbA== X-Forwarded-Encrypted: i=1; AHgh+Ro4siyPOWZNiu8sN5tMXxMOb2+dwulCGAZRXjjJncHUuf5PluW1da1x6jw4fbNVzCOsHuG1jnu3biqwvqU=@vger.kernel.org X-Gm-Message-State: AOJu0YzM4J73aHjsY6UMtRhonpzKJRk31+WjwU40pe35X0D1mgae2ImA Jax5tJcuG+zX0uYugangrxkYpbCvt4rbIZBirWnCfVwkWx9Ix124MZxb X-Gm-Gg: AR+sD117foRNFRyQmaE65rwc3v+8952ldrTw9DmS6IuoHmDBdUMsC41nn3GH+JEv0pL /m/6GRGxdnI1ZrseEzlHw/YHy/QOwnkQ58IJsg5rrq+jtlima7r+lJh/QMgGfiooKVz/pyuZB56 jSiRYVZAvW81YkLH+TJLutpYjOoEAmoU65k9e/E6v9Gj1pEM22ZHaEZRhI9IfPwOkM0EGa9BXo4 5aE4w6crHkys7rYpXiJGEorJ3APTJ5J6jY9cw7Jik5d6StrjvDgA/NHKnWhsbQiw6F4MR9qTjjM 2h9v3zyeSqtxFh1sqQKbBK8ffoXJgv2/oD9xBvy3joGegsKWmJJgieoMzQpQQ7Z+RJBCg91cNpc se3SK3Ej83+u+NEvhyu3qiiynQvOxKB10h2KVLBwbJ9ebhg+tFW9DOm5Hbj5geVy5vnvUezLPgL 7S45GbjUE= X-Received: by 2002:a17:90b:53c4:b0:37f:ed7e:7e42 with SMTP id 98e67ed59e1d1-38ec64f3415mr4603537a91.14.1784832381937; Thu, 23 Jul 2026 11:46:21 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:21 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: cocci@inria.fr, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 09/36] net: intel: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:11 +0900 Message-ID: <20260723184538.3888637-10-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/net/ethernet/intel/i40e/i40e_main.c | 8 +------- drivers/net/ethernet/intel/igb/e1000_i210.c | 6 +----- drivers/net/ethernet/intel/igc/igc_phy.c | 6 +----- 3 files changed, 3 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethe= rnet/intel/i40e/i40e_main.c index a04683004a56..0cd0e5597c90 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -4864,16 +4864,10 @@ static void i40e_control_rx_q(struct i40e_pf *pf, i= nt pf_q, bool enable) **/ int i40e_control_wait_rx_q(struct i40e_pf *pf, int pf_q, bool enable) { - int ret =3D 0; - i40e_control_rx_q(pf, pf_q, enable); =20 /* wait for the change to finish */ - ret =3D i40e_pf_rxq_wait(pf, pf_q, enable); - if (ret) - return ret; - - return ret; + return i40e_pf_rxq_wait(pf, pf_q, enable); } =20 /** diff --git a/drivers/net/ethernet/intel/igb/e1000_i210.c b/drivers/net/ethe= rnet/intel/igb/e1000_i210.c index 9db29b231d6a..784f9a7bcbed 100644 --- a/drivers/net/ethernet/intel/igb/e1000_i210.c +++ b/drivers/net/ethernet/intel/igb/e1000_i210.c @@ -756,11 +756,7 @@ static s32 __igb_access_xmdio_reg(struct e1000_hw *hw,= u16 address, return ret_val; =20 /* Recalibrate the device back to 0 */ - ret_val =3D hw->phy.ops.write_reg(hw, E1000_MMDAC, 0); - if (ret_val) - return ret_val; - - return ret_val; + return hw->phy.ops.write_reg(hw, E1000_MMDAC, 0); } =20 /** diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/etherne= t/intel/igc/igc_phy.c index 4cf737fb3b21..b758a7e0f013 100644 --- a/drivers/net/ethernet/intel/igc/igc_phy.c +++ b/drivers/net/ethernet/intel/igc/igc_phy.c @@ -675,11 +675,7 @@ static s32 __igc_access_xmdio_reg(struct igc_hw *hw, u= 16 address, return ret_val; =20 /* Recalibrate the device back to 0 */ - ret_val =3D hw->phy.ops.write_reg(hw, IGC_MMDAC, 0); - if (ret_val) - return ret_val; - - return ret_val; + return hw->phy.ops.write_reg(hw, IGC_MMDAC, 0); } =20 /** --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37FFA47FAE5 for ; Thu, 23 Jul 2026 18:46:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832393; cv=none; b=XJg9/e7tv0HX9wpvmyUkHGUTEjPqT21e3oO8uRnD04iJvaXGHS1wt9zOCvGdUkmAcJ4D91zY7hCUp/aFwG/eabqM3vENWlX+6G8fHdon3+lweJp5XB13c243hWKw56z//FnNuGHAVueqJIt+KCO6+QVe2ZLT0zS5lnCsisTkZTo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832393; c=relaxed/simple; bh=l5cYumQSVda6TM4im2zMBBHJR+B+/MjRxhrS0PQEpUU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pw6dlYeZlP2MNlxwwXRXLfe6W7KEoRU6EW19gb9Ht82sMFMs0maFSgq3b5L5V79hwf6QCwKcinDBgwnaNrJcIMcqcQyWLx82Nk2gxqYQldM57VGAmWAHLQUoZOJSQOj5gmJFtfwonhRtHkD2FzuViUuHwCIjEB71PXr/mjWuN4I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lyXgxQGh; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lyXgxQGh" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38e07ebd263so689989a91.1 for ; Thu, 23 Jul 2026 11:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832384; x=1785437184; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=POBnk8e7cjMk5Mm303buRI06BRywbPO3M0j5oTpXzt4=; b=lyXgxQGh9f+VamZrV+xgiT6KkvluQa2NES/CmEJfyGCuZAf3R3FD7VJp9UTpEViBTR Zmy7k9dMebw5e1gmYup45nFbL0n17qewT7bssTZEGGUm6nmmF+zArf54uBIBuXn9WW69 wgeY9ZpRjEolfMK5RCKhLKb3oMljv4sb1nvBtpjia8/54xCmFvopu3AKQi9s/OWLC5ZP jLh1pdf95PR+xEbtKgMLwVTOXrgomcK228DFkSwriRRCxCL8RjpHJkKQ7Ac7reksyG9r KKd6kPw6jpZjoCcIyoL0/SxyEj6iQ+NPjIlpj8kxo3lI0L8eLRKF2QJiG9K1rliHb7zq b3MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832384; x=1785437184; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=POBnk8e7cjMk5Mm303buRI06BRywbPO3M0j5oTpXzt4=; b=VfdN9vkKsrVLbou94yCgu1W/AhDZQEAhga4DvE+HktcZPYS7aQyFQ4p+osoFLLdzwx pd9VXUnbH52ygMuJad/oxw0U0BUI2Hl+hk+VSBK+vX3EhpOZ45eoRCJgDKM6r2cwnWq2 VpoWyth1bSf01ATdYmKgVBMXW8km66PqkCcHUjcDPCGlvoSXjL5Zk4WT7K/RrW4VcGw2 XWdD9GWBpZvjqTaiBBv8d+eFxJrFQi4G7ToxAZR+j7AntTVzwrNjOa7Gn0hh27EpE5F0 iMUnnRZZw7J077dQrp/dADcP7dVo293i6yIcF+EcqEMb7vPj9sH095U2u7iTtpIzWmR5 Jd9g== X-Forwarded-Encrypted: i=1; AHgh+RrQ9DNjTJbQ2eCEIRaiGaxQmVmLYDt09CCPKJVkIRYC3FBnGUXocXk4vPV2RugOyQkf5MytBFcz6kbE08Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzM93G4sWEFLi2Qkabsc/zjb9PNO2w1lQvctIplaoB/60UYZAxI VgL+IGrh35QPedNQNZrgrI/R9yhwLt0BPfRtXAPRnUbi3wsgWVu3UaAg X-Gm-Gg: AR+sD10cDtIFI9IXPCD/fGWfcMJNP+WLk/EVNwg8bc2MQY0E8vGecs/NNsgxoS8FqNa jvoRWh+BkcsmdWxQXcK+qea3HubCc2WQqTsvynzHvFsqPOlCfBodEvqekV3owR0rDo9b5y8vHbZ zPHPDtRXUwsZ9u22pnKXkJFZRq2PPvGHcPl68bhTpIA792Gkcaat/Zx6GJ0SBsbl1r3klfBlxBz cFYor3SIFiZ6mKRe2BZvpo8Ye0/2jw6HTZhV3hqvuT+d300L2lX4Z9vTUa1VQfNSSQ8kX/B/s4h YcYbLR01d1iqYzny8kVnUfZLhZHMqJOj7NVziN9v3vdeYBZRGKJdQ6y8J/a4U11VtLVXkWHURHk XYL6w4+W2HzI4+E1pN9ZkwCBvaNKwt6A7JfKBf5zn5cbjSAsLX5rN2ZzTQKUMPq9DneiYbSIL4w wZObdUF0U= X-Received: by 2002:a17:90b:314e:b0:381:5a08:6291 with SMTP id 98e67ed59e1d1-38ec658fc68mr3549005a91.20.1784832383927; Thu, 23 Jul 2026 11:46:23 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:23 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Miri Korenblit , Ping-Ke Shih Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: [PATCH 10/36] wifi: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:12 +0900 Message-ID: <20260723184538.3888637-11-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/net/wireless/ath/ath6kl/init.c | 6 +----- drivers/net/wireless/intel/iwlwifi/mvm/link.c | 6 +----- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 7 +------ drivers/net/wireless/realtek/rtw89/mac.c | 6 +----- drivers/net/wireless/realtek/rtw89/mac_be.c | 6 +----- 5 files changed, 5 insertions(+), 26 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/= ath/ath6kl/init.c index 782209dcb782..61fa10d88714 100644 --- a/drivers/net/wireless/ath/ath6kl/init.c +++ b/drivers/net/wireless/ath/ath6kl/init.c @@ -1566,11 +1566,7 @@ static int ath6kl_init_upload(struct ath6kl *ar) =20 address =3D MBOX_BASE_ADDRESS + LOCAL_SCRATCH_ADDRESS; param =3D options | 0x20; - status =3D ath6kl_bmi_reg_write(ar, address, param); - if (status) - return status; - - return status; + return ath6kl_bmi_reg_write(ar, address, param); } =20 int ath6kl_init_hw_params(struct ath6kl *ar) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/link.c b/drivers/net/wi= reless/intel/iwlwifi/mvm/link.c index b5d252ece2d9..76a548f9aea2 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/link.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/link.c @@ -278,11 +278,7 @@ int iwl_mvm_disable_link(struct iwl_mvm *mvm, struct i= eee80211_vif *vif, if (ret) return ret; =20 - ret =3D iwl_mvm_remove_link(mvm, vif, link_conf); - if (ret) - return ret; - - return ret; + return iwl_mvm_remove_link(mvm, vif, link_conf); } =20 void iwl_mvm_init_link(struct iwl_mvm_vif_link_info *link) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/= net/wireless/realtek/rtlwifi/rtl8821ae/hw.c index 9b119a51bc30..1ba53e671207 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c @@ -1462,12 +1462,7 @@ static bool _rtl8821ae_init_llt_table(struct ieee802= 11_hw *hw, u32 boundary) return status; } =20 - status =3D _rtl8821ae_llt_write(hw, last_entry_of_txpktbuf, - txpktbuf_bndy); - if (!status) - return status; - - return status; + return _rtl8821ae_llt_write(hw, last_entry_of_txpktbuf, txpktbuf_bndy); } =20 static bool _rtl8821ae_dynamic_rqpn(struct ieee80211_hw *hw, u32 boundary, diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireles= s/realtek/rtw89/mac.c index 8c395517bd2f..967b42f2b6fb 100644 --- a/drivers/net/wireless/realtek/rtw89/mac.c +++ b/drivers/net/wireless/realtek/rtw89/mac.c @@ -1706,11 +1706,7 @@ static int sys_init_ax(struct rtw89_dev *rtwdev) if (ret) return ret; =20 - ret =3D chip_func_en_ax(rtwdev); - if (ret) - return ret; - - return ret; + return chip_func_en_ax(rtwdev); } =20 const struct rtw89_mac_size_set rtw89_mac_size =3D { diff --git a/drivers/net/wireless/realtek/rtw89/mac_be.c b/drivers/net/wire= less/realtek/rtw89/mac_be.c index f24c119b99f1..b7ba8de9cc78 100644 --- a/drivers/net/wireless/realtek/rtw89/mac_be.c +++ b/drivers/net/wireless/realtek/rtw89/mac_be.c @@ -924,11 +924,7 @@ static int sys_init_be(struct rtw89_dev *rtwdev) if (ret) return ret; =20 - ret =3D chip_func_en_be(rtwdev); - if (ret) - return ret; - - return ret; + return chip_func_en_be(rtwdev); } =20 static int mac_func_en_be(struct rtw89_dev *rtwdev) --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80CE547FB12 for ; Thu, 23 Jul 2026 18:46:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832394; cv=none; b=Qeo0ABVqFL8HthyNBSv/EVZWxrHXn6czO11Nevx9fnfqw1UmbtakZTGk6LVKE3GRW4191XA0FVIjZhA35+f7JgVbP3295qA9ijm2b/w9CS5i/0kC/8DKo+KsmAVFSBu92iUULQ5fG14u2BoKJvvrfIBJDYMJY8Ox5pSK5zX5lKk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832394; c=relaxed/simple; bh=zNsz4g/9jlKYeSwyAkgTCr/mWLvx1XT3kgMf7ziCe00=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ntnu7MxMZhPMIpliRWAFACp9XVHO2xYYTStJvM0SyqJJdCZ79d+7iqVuWwyqBWKjN3ZwR9nhENwOcLi66kx0aicb4wCK2HuyyJiHUbwspYy0DHQ/mxMaM9o4fZ7/RZRkHcSyVzFvv+6+XhH/ytAyXGs55T93Rv8nfgy0kho9a3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K0l4Ru16; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K0l4Ru16" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-38e69bdb0fcso809025a91.1 for ; Thu, 23 Jul 2026 11:46:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832387; x=1785437187; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gvjX2o7DFFzayFyUFs0i0LzhZ1PMgAv+++MqFVj9d/o=; b=K0l4Ru163rF4tHzGTfr2Y6xJ94fETN8xR+E/v70yXifc5TWJyT/ns7xFE3HlW7IyTD rqFWUZNU2xbwXbJJ1kiA1M1KqTloup2DbD3GBhCY0oOULOs0I4n/Vdg4mIcymMlkPNom 05jLtTGTKRJ0Pzk8hjXMOONkFpkz+VY4UwFIjGT84rQtiBIBCB+9x/pivh1eGHGZRW44 +GdoCQnS9tVrL/aSqdMx4D8wp0LB2bkofN2fZ2xbC+men9lMu3Hcn45yk9f+i+mhD2zK NgGr698RE1H7S/wYh3nCthw1DAH2T2tBGG1mmirAZJ+Omth19hkwtQUlOjVlojge2ypQ 56+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832387; x=1785437187; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=gvjX2o7DFFzayFyUFs0i0LzhZ1PMgAv+++MqFVj9d/o=; b=hOmJnpZRufBRz+LP3NjpjbPCcvkHm9bGUQl3rXB8EFEh2V4oOILMo8PqrXuf2nDL4e VKLTxwjfduIJ0L6kjhcAtrAG/UHlrezHtJP2S2C35zESor87jKDisNR5GVSFQL503WHA Mh7kICJDu59jB5dSynWFx7o0Gd+eTv/1btaFZvNKVsRo0rEi3cqFyCjcIMus5HrQC2P1 YDP5yC0kxVdp2W69w6IRUVI9ooOBEDnaB1VlbEthCXnpakbUu30cDyzTDw8My3mX2vjn tnhuQS4tAaFV1Z+x7Aq4FQryLyMTgOblvoCa52D4PJOp7NPkERJCBZq8QNWIr2ZjJdsz keoQ== X-Forwarded-Encrypted: i=1; AHgh+Ro8wyY7XKmFuDjpvWXWjXXwl1EblBQUj9fFNuGsBmQpbz+jbS9bAuAgfLh/nmPe+iJyHn49EPgsCNvk3Hw=@vger.kernel.org X-Gm-Message-State: AOJu0YwPPH48pMFLW3E0nKQjNjfk1h7J0jFt1tj2sdQA9rrBwOS26QJ/ AOspFKOQpPwiylKh87t6eyW9/DisWgQjxAR6w3EXlNau4yPjxENLttzA X-Gm-Gg: AR+sD11R5tDLM8OEmoes5z6McSy+QtAsDhQmqiYHGiSfkVEqByq9SoriQS4oi4TxVCx hshbzk65EUNj/+lumC6IccHry+27mV5oB+1SA9HHoT3HJBuhfhuzaSgPJoi5D3ewv96fFb5OYpT PfwlyS59U6HhG4e/guo04KLqP5/1PjckMNKUZAF5Q1XCttb0M2Yy/UVVJC4Ds/hhUgl6hPn5K4K APYJKIj2J86YxiGRn5nGbW5/Vp9jMc25eCDKf3EzEaoVAvIcpsr1UlFBnKnK3VA1AbtBMjl6EPV bfBwJl/Ne/77H1iik2FyqH1l+fZrNeGN67zbPNRvyL75XKqTVTFYmJPwvP7aTUfLDjbFw9anZvQ e8qGblRzWb5q2nXjeCjb/Yk9S6NLG5BV9RVEVJbC/giVBG6d+eJ+wHLlVLKSjBVsIqV23b1F34l +xkP3mfJI= X-Received: by 2002:a17:90b:3ccf:b0:37f:fda5:8d9a with SMTP id 98e67ed59e1d1-38ec6a5115dmr4284232a91.25.1784832387385; Thu, 23 Jul 2026 11:46:27 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:26 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Simon Horman , Julian Anastasov , Pablo Neira Ayuso , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: cocci@inria.fr, coreteam@netfilter.org, linux-kernel@vger.kernel.org, lvs-devel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Phil Sutter , Simon Horman Subject: [PATCH 11/36] ipvs: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:13 +0900 Message-ID: <20260723184538.3888637-12-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- net/netfilter/ipvs/ip_vs_sync.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_syn= c.c index 93038abbf5e0..bd4f7e906cf7 100644 --- a/net/netfilter/ipvs/ip_vs_sync.c +++ b/net/netfilter/ipvs/ip_vs_sync.c @@ -1603,15 +1603,10 @@ ip_vs_receive(struct socket *sock, char *buffer, co= nst size_t buflen) { struct msghdr msg =3D {NULL,}; struct kvec iov =3D {buffer, buflen}; - int len; =20 /* Receive a packet */ iov_iter_kvec(&msg.msg_iter, ITER_DEST, &iov, 1, buflen); - len =3D sock_recvmsg(sock, &msg, MSG_DONTWAIT); - if (len < 0) - return len; - - return len; + return sock_recvmsg(sock, &msg, MSG_DONTWAIT); } =20 /* Wakeup the master thread for sending */ --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EA954F7991 for ; Thu, 23 Jul 2026 18:46:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832402; cv=none; b=tx/bRpEsXQvIZdm08UQSTlqZqdoNhet8KAwAsRBW2ecsBzHPgzJswheiDEm7szGoIZRAhnbRRi7vGYml3HVXcuT04PPglLVF6coay/ti4dLfH22ekIR1qZ7+X6T/OhZQNgnrmbbEGk8raWNHFpCPfu5Rrv6c2AUTwihcs42W4aI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832402; c=relaxed/simple; bh=DQFKVraIj3hS/K9rhtkP6NnYFqE9X4Ceep45IBu9BFk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UbW25fzhb6+YsAGRbm3pjS6xODlF8KcMopAVMJUDQvK13O6jRIqFbzxfHRa29oTs7lkaTrBljB9gF5P/9XZmgX/NfE3sU0QIN80mNLNXUyJDApwL3kwtx1fWY74d+vuDZSNBpvVmgnJpGFLW1gFmGrjj5QQjv7H785BdvxZ6b+U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S4d/hxw0; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S4d/hxw0" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38dfe910e9dso853339a91.3 for ; Thu, 23 Jul 2026 11:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832391; x=1785437191; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8aDNX5oWZPCLlEUZqO7qQYiyJOs0NAqqQhS2frdoUAY=; b=S4d/hxw05hTzm0cZgrTJhDMi/tEYkkLv8thfW5xvM8+ellLJtka8xcwyR+RfpFIR0B F2LEXTmR4wcfgwL+5lshVIAoswu25IJERzRiEbcXwYJErCV2wnh5Ch4pe+yF/p/uMQ87 Lb/MxCyE5bjBIrQ3J59Bv8SLkLj3QCR95dArQXg/HWHSeD9zMb9CiysXsQPuwOaJpll8 HIPh9jp+8/KkPx78J2bGPwUrlwfWk6WYLJqHghyzcXUiUS/Ztz+V+IisvgUwoV83IoqV b2mCVsm6MmwWxBIg3khUb+MmEu666Q1fyy5O+qJktvPDTZYWd3FEbd5gYeEexCo0lMb7 73Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832391; x=1785437191; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=8aDNX5oWZPCLlEUZqO7qQYiyJOs0NAqqQhS2frdoUAY=; b=pu7a1Fs2pCWPgwCwdspB2ayUu7uODtYx4AovG8jVbUyasUCpTqglO+dkoXLaocf9lr oFSJ5DpRVG+klRTQtQDjK3NYRenrODRUeH6XDDdrEhMmm69uwEDqUNBsr2xAUfTr/Uor 9JeFwHVHIJunTQc289S0UtW0O1hpPSoeanBZ1/c1jG6FGtVQ82ihKFyk0ApAnr0ag9wl Pgl7scm/tRjxJ1mx2z1uttGFNpSj6jLeF//HLMxZ1N3Dl5mjCM8DDwB3GrL18RTAkNFt 3frK1jtvp0kMARkqUXyi9JOjBa9iD0b4lonI6ROeMazlPOu41UdH0GdsvfSPbmcfOJBp XXuw== X-Forwarded-Encrypted: i=1; AHgh+RpdQyom9/rxZsXSGvS66l4ykFVs2kOhCB7ot8xm1SJWc4b2EJoOboy1sg5mL3InG5dZANV2vTaf0wGSC8Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzegXi/2Mzmh+niGo0P8zehh9WjuEPcrtcXRflcv9kjW6oUVk6I mxcjj5yxEJifZ+jwrjVXROOGxcHGM1sblRLugaMT+xTLXmUrTGYm0XQq X-Gm-Gg: AR+sD13IPSNJVeyC5KTAXaMr83YKWKuhwXByc6nEwKbSUv1fvn2VZHER78+HrxKw8US W5B3CAgjM7kwMXqUFSW+vG+zmk7sB3eEW+RujRwtUUizwxsKs02Z1kebfkw0H8isOY0EElLosia ysKV3mDKopcDWCquCsq0Hi1NSB4pXYdjdes1VCH4kpaepuGG9PcC7EiPClI/IFZEMuUySJku+yi Nm/OaAUHecCrm6JYIhUwbzZH/3wo/QXk/7RrEyI8QK+mEEyfQvL4yOqn5SCCKQ4LuNggPvgYbJn cpnEXMocx+8tCiCOuI3L7P7cvXCUjs/1BujqdZKuTiZl6O18cY19FFnSqPKmD8lKgEIl+FpYRBh C1y46/eaOb29mYTFOjgn0YST+ewrpakAzYrBOGzCXaFFtFTfIjENJFlM5kH4Nv4/WkMv4qMsz X-Received: by 2002:a17:90b:52cd:b0:387:e0cb:7ee with SMTP id 98e67ed59e1d1-38ec6661b73mr4668847a91.34.1784832391486; Thu, 23 Jul 2026 11:46:31 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:31 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , Eugen Hristev , Vikash Garodia , Dikshita Agarwal , "Bryan O'Donoghue" , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Geert Uytterhoeven , Magnus Damm , Sylwester Nawrocki , Michael Krufky , Hans Verkuil Cc: cocci@inria.fr, Abhinav Kumar , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH 12/36] media: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:14 +0900 Message-ID: <20260723184538.3888637-13-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon Reviewed-by: Niklas S=C3=B6derlund --- drivers/media/i2c/mt9p031.c | 6 +----- .../media/platform/microchip/microchip-sama7g5-isc.c | 7 +------ drivers/media/platform/qcom/iris/iris_resources.c | 6 +----- drivers/media/platform/qcom/venus/pm_helpers.c | 7 +------ drivers/media/platform/renesas/rcar-csi2.c | 6 +----- .../media/platform/samsung/s3c-camif/camif-core.c | 7 +------ drivers/media/usb/dvb-usb-v2/mxl111sf.c | 12 ++---------- drivers/media/usb/gspca/jl2005bcd.c | 7 +------ 8 files changed, 9 insertions(+), 49 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index d21510caf45a..2b09e8315c8e 100644 --- a/drivers/media/i2c/mt9p031.c +++ b/drivers/media/i2c/mt9p031.c @@ -452,11 +452,7 @@ static int mt9p031_set_params(struct mt9p031 *mt9p031) ret =3D mt9p031_write(client, MT9P031_HORIZONTAL_BLANK, hblank - 1); if (ret < 0) return ret; - ret =3D mt9p031_write(client, MT9P031_VERTICAL_BLANK, vblank - 1); - if (ret < 0) - return ret; - - return ret; + return mt9p031_write(client, MT9P031_VERTICAL_BLANK, vblank - 1); } =20 static int mt9p031_s_stream(struct v4l2_subdev *subdev, int enable) diff --git a/drivers/media/platform/microchip/microchip-sama7g5-isc.c b/dri= vers/media/platform/microchip/microchip-sama7g5-isc.c index b0302dfc3278..7383341ec51d 100644 --- a/drivers/media/platform/microchip/microchip-sama7g5-isc.c +++ b/drivers/media/platform/microchip/microchip-sama7g5-isc.c @@ -598,13 +598,8 @@ static int __maybe_unused xisc_runtime_suspend(struct = device *dev) static int __maybe_unused xisc_runtime_resume(struct device *dev) { struct isc_device *isc =3D dev_get_drvdata(dev); - int ret; - - ret =3D clk_prepare_enable(isc->hclock); - if (ret) - return ret; =20 - return ret; + return clk_prepare_enable(isc->hclock); } =20 static const struct dev_pm_ops microchip_xisc_dev_pm_ops =3D { diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/me= dia/platform/qcom/iris/iris_resources.c index 773f6548370a..872bd09656b1 100644 --- a/drivers/media/platform/qcom/iris/iris_resources.c +++ b/drivers/media/platform/qcom/iris/iris_resources.c @@ -78,11 +78,7 @@ int iris_enable_power_domains(struct iris_core *core, st= ruct device *pd_dev) if (ret) return ret; =20 - ret =3D pm_runtime_get_sync(pd_dev); - if (ret < 0) - return ret; - - return ret; + return pm_runtime_get_sync(pd_dev); } =20 int iris_disable_power_domains(struct iris_core *core, struct device *pd_d= ev) diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media= /platform/qcom/venus/pm_helpers.c index be1cbd5cfe84..e88e66be4f6d 100644 --- a/drivers/media/platform/qcom/venus/pm_helpers.c +++ b/drivers/media/platform/qcom/venus/pm_helpers.c @@ -781,7 +781,6 @@ static int decide_core(struct venus_inst *inst) unsigned long max_freq =3D ULONG_MAX; struct device *dev =3D core->dev; struct dev_pm_opp *opp; - int ret =3D 0; =20 if (legacy_binding) { if (inst->session_type =3D=3D VIDC_SESSION_TYPE_DEC) @@ -829,11 +828,7 @@ static int decide_core(struct venus_inst *inst) } =20 done: - ret =3D hfi_session_set_property(inst, ptype, &cu); - if (ret) - return ret; - - return ret; + return hfi_session_set_property(inst, ptype, &cu); } =20 static int acquire_core(struct venus_inst *inst) diff --git a/drivers/media/platform/renesas/rcar-csi2.c b/drivers/media/pla= tform/renesas/rcar-csi2.c index 7305cc4a04cb..6635f5782175 100644 --- a/drivers/media/platform/renesas/rcar-csi2.c +++ b/drivers/media/platform/renesas/rcar-csi2.c @@ -2273,11 +2273,7 @@ static int rcsi2_init_phtw_v3u(struct rcar_csi2 *pri= v, return ret; } =20 - ret =3D rcsi2_phtw_write_array(priv, step4, ARRAY_SIZE(step4)); - if (ret) - return ret; - - return ret; + return rcsi2_phtw_write_array(priv, step4, ARRAY_SIZE(step4)); } =20 /* -----------------------------------------------------------------------= ------ diff --git a/drivers/media/platform/samsung/s3c-camif/camif-core.c b/driver= s/media/platform/samsung/s3c-camif/camif-core.c index 14eedd1ceb27..bb06847f3a63 100644 --- a/drivers/media/platform/samsung/s3c-camif/camif-core.c +++ b/drivers/media/platform/samsung/s3c-camif/camif-core.c @@ -301,7 +301,6 @@ static int camif_media_dev_init(struct camif_dev *camif) struct media_device *md =3D &camif->media_dev; struct v4l2_device *v4l2_dev =3D &camif->v4l2_dev; unsigned int ip_rev =3D camif->variant->ip_revision; - int ret; =20 memset(md, 0, sizeof(*md)); snprintf(md->model, sizeof(md->model), "Samsung S3C%s CAMIF", @@ -316,11 +315,7 @@ static int camif_media_dev_init(struct camif_dev *cami= f) =20 media_device_init(md); =20 - ret =3D v4l2_device_register(camif->dev, v4l2_dev); - if (ret < 0) - return ret; - - return ret; + return v4l2_device_register(camif->dev, v4l2_dev); } =20 static void camif_clk_put(struct camif_dev *camif) diff --git a/drivers/media/usb/dvb-usb-v2/mxl111sf.c b/drivers/media/usb/dv= b-usb-v2/mxl111sf.c index 870ac3c8b085..6404eb74db32 100644 --- a/drivers/media/usb/dvb-usb-v2/mxl111sf.c +++ b/drivers/media/usb/dvb-usb-v2/mxl111sf.c @@ -987,11 +987,7 @@ static int mxl111sf_frontend_attach_atsc_mh(struct dvb= _usb_adapter *adap) if (ret < 0) return ret; =20 - ret =3D mxl111sf_lg2160_frontend_attach(adap, 2); - if (ret < 0) - return ret; - - return ret; + return mxl111sf_lg2160_frontend_attach(adap, 2); } =20 static int mxl111sf_frontend_attach_mercury(struct dvb_usb_adapter *adap) @@ -1007,11 +1003,7 @@ static int mxl111sf_frontend_attach_mercury(struct d= vb_usb_adapter *adap) if (ret < 0) return ret; =20 - ret =3D mxl111sf_lg2161_ep6_frontend_attach(adap, 2); - if (ret < 0) - return ret; - - return ret; + return mxl111sf_lg2161_ep6_frontend_attach(adap, 2); } =20 static int mxl111sf_frontend_attach_mercury_mh(struct dvb_usb_adapter *ada= p) diff --git a/drivers/media/usb/gspca/jl2005bcd.c b/drivers/media/usb/gspca/= jl2005bcd.c index a408fcc3a060..4988fbf5005e 100644 --- a/drivers/media/usb/gspca/jl2005bcd.c +++ b/drivers/media/usb/gspca/jl2005bcd.c @@ -148,17 +148,12 @@ static int jl2005c_start_new_frame(struct gspca_dev *= gspca_dev) static int jl2005c_write_reg(struct gspca_dev *gspca_dev, unsigned char re= g, unsigned char value) { - int retval; u8 instruction[2]; =20 instruction[0] =3D reg; instruction[1] =3D value; =20 - retval =3D jl2005c_write2(gspca_dev, instruction); - if (retval < 0) - return retval; - - return retval; + return jl2005c_write2(gspca_dev, instruction); } =20 static int jl2005c_get_firmware_id(struct gspca_dev *gspca_dev) --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D25DF44C4E3 for ; Thu, 23 Jul 2026 18:46:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832401; cv=none; b=bRRqw2gTALjpZljB9985E1nNvq21NbYUF1CfDW7KwPVU/2Lgs8RZJRs0QTAn0owU/JJNQN9I7UYsj6fvWHq7sqDqt2G9jbY/edmbWxPzd5183g/0h0aDBcCH7KTTTVbfZ4ICamB34h7PERRDu/4fwE+NKU54DEpEzzJDM1T+mS4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832401; c=relaxed/simple; bh=pC3jMvPYeSyszM8A/kaY0D7/tPIf7nyRWa6KlRbsfEk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E7YeshJPFTTV6Wj0C6wU11K4hfTgqs4W6Whz8f2QrBVhPTSpLawj6wGtorSqN/kX0tV325aWQqKE6k96Y4KF9ZwIK73ey2koGOl/+FBlBWsGWnNwxlGLaJBpK2779HoNcI8fmUJyz8i2D97o7LD2jdE5D1HodO1bUWir71sm4K0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sXXt00zT; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sXXt00zT" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38e3617ba36so977275a91.3 for ; Thu, 23 Jul 2026 11:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832394; x=1785437194; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bRDMoftjJ5LuSOG2BSFEOMESTYAdiLdW60GLICnyHDg=; b=sXXt00zT31L7vRa+Soa6xZPX0g2hjFDNeh0iULYKOf2acqU8NeJN/CTEoPHjCq89oG L0p3NrkiDkMy/m74uo3NUCWjX6MafmcMw+Ezljhc++i+MNuqx3MOkJ3eVA3q7q/bt8Z+ 1+zUMvwsebIeTVwL/ynelnc4pIpvGJs4EEKRsdw4WZjnTFrjVhi/6VSnQC9f/VKSsMnL Qq82EjxV7lLmG7+Sbtf1UxAZek6TPIJ8F9EwslrO0tOORtLcG3LRqIVPSjnbfePHC0nH VsWpTP7DcxvV6YtBrsY7rFPiji5zR9GYsepQPfm0PpL/Up9aYFUpL7hQubEt7DBd8IWw RzMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832394; x=1785437194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=bRDMoftjJ5LuSOG2BSFEOMESTYAdiLdW60GLICnyHDg=; b=e8DpHMCDOAgxUWvqtI8/hxS9ceDmb7eqyACUChJDOWadOvqijDLx995keqLaRE8iD1 WmrpVCslBREhcLbTLjmiWLdlzfN8nPb3hgqVBCIWo8AS0O4RO0MpQ0mvJ1G3c5VD1I6S NeXH7W/bY/29Kqs9brTSyyO5mi2pzjJiHLMQNIqJQTB5IPYlHVzUHWWaPELuVi8+jBzo KAUlpk6v/HP1MCfE2DwUfWigXdConR81hRICwKPsQ4z9Goa/Ke0OgKfAv7nKepH1Vozb hsA93Qc65MDoQUz3675JWuFy94m9bfwquckUYE6VAxeGRlbprQg3vH5ACs0BG2AdqpHP pY3g== X-Forwarded-Encrypted: i=1; AHgh+RorGnvPXw7ujrCD+DO4k+Zzh1xG9TYTfsa9IcTyPqtZImWSspUxmH1lzyADzBluk/i0Q0njWFltgsx/h78=@vger.kernel.org X-Gm-Message-State: AOJu0YzvYawv9r7G5l71UcdURyUocHIfuBxV4HjmSFXeQJH5wivrCjBV P1GxTpwXhcqxV8tJrKCyySe/ISLmvkEtIs9MrDPlQu2wJ+SLi0gvegW6 X-Gm-Gg: AR+sD11QJgi3t4WRauZ93FocFhBuhFLK0vWedjteAxnqRmvXZe0obwpB7hf4J16fOuK cB4z/3AB/aS5DaJOAyTXR4epV+lkjbtT5Dkwr0rfl9L6p5rw4DfwNurUfxBgRkkURVOBJKuQoq2 U9LFsouXelDOU8Y+ryA1VnOMfrTGV0y+zQ5VsHA0cJhHX8MzOKZ8kV3+4yZncPltbzRljeoOmmh yK3dNCViHhN1C129hizWu5ZTqIp1OguLZhaC7Pu7v25Cmt+v0CtH8vKM23cmEmWalvoYyEf6J2n 6vSBCXiOc28Oln3Ye0u+Ol7outWY8AriRGZMMjtBJ4zYz5rxrD9jbvdDEGS9oLY4CmnUR1n2tRB VU3uvmoie5T7RGz0sQPuo0f0SYCRoxBoJCA9KvWf9xRkKQ6ZW/OLPUIWr8z9FUMZW5/T+NR+y X-Received: by 2002:a17:90b:5905:b0:37f:9ce1:736b with SMTP id 98e67ed59e1d1-38ec6a7a521mr3865959a91.33.1784832393651; Thu, 23 Jul 2026 11:46:33 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:32 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Jaroslav Kysela , Takashi Iwai Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org Subject: [PATCH 13/36] ALSA: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:15 +0900 Message-ID: <20260723184538.3888637-14-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- sound/pci/echoaudio/echoaudio_dsp.c | 6 +----- sound/pci/echoaudio/layla24_dsp.c | 6 +----- sound/pci/riptide/riptide.c | 5 +---- sound/usb/mixer_scarlett.c | 26 ++++++++++---------------- 4 files changed, 13 insertions(+), 30 deletions(-) diff --git a/sound/pci/echoaudio/echoaudio_dsp.c b/sound/pci/echoaudio/echo= audio_dsp.c index 4dd494508c9b..90d7f364d2b3 100644 --- a/sound/pci/echoaudio/echoaudio_dsp.c +++ b/sound/pci/echoaudio/echoaudio_dsp.c @@ -496,11 +496,7 @@ static int load_firmware(struct echoaudio *chip) if (err < 0) return err; =20 - box_type =3D load_asic(chip); - if (box_type < 0) - return box_type; /* error */ - - return box_type; + return load_asic(chip); } =20 =20 diff --git a/sound/pci/echoaudio/layla24_dsp.c b/sound/pci/echoaudio/layla2= 4_dsp.c index e7b8f5fe7753..6ed485acd618 100644 --- a/sound/pci/echoaudio/layla24_dsp.c +++ b/sound/pci/echoaudio/layla24_dsp.c @@ -54,11 +54,7 @@ static int init_hw(struct echoaudio *chip, u16 device_id= , u16 subdevice_id) return err; chip->bad_board =3D false; =20 - err =3D init_line_levels(chip); - if (err < 0) - return err; - - return err; + return init_line_levels(chip); } =20 =20 diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c index 99c00e46ce23..fa9cbeb43f15 100644 --- a/sound/pci/riptide/riptide.c +++ b/sound/pci/riptide/riptide.c @@ -1957,10 +1957,7 @@ static int snd_riptide_mixer(struct snd_riptide *chi= p) =20 chip->ac97_bus =3D pbus; ac97.pci =3D chip->pci; - err =3D snd_ac97_mixer(pbus, &ac97, &chip->ac97); - if (err < 0) - return err; - return err; + return snd_ac97_mixer(pbus, &ac97, &chip->ac97); } =20 #ifdef SUPPORT_JOYSTICK diff --git a/sound/usb/mixer_scarlett.c b/sound/usb/mixer_scarlett.c index 673eb8d8724d..b500d6d45e66 100644 --- a/sound/usb/mixer_scarlett.c +++ b/sound/usb/mixer_scarlett.c @@ -1383,15 +1383,13 @@ int snd_scarlett_controls_create(struct usb_mixer_i= nterface *mixer) return err; =20 /* initialize sampling rate to 48000 */ - err =3D snd_usb_ctl_msg(mixer->chip->dev, - usb_sndctrlpipe(mixer->chip->dev, 0), UAC2_CS_CUR, - USB_RECIP_INTERFACE | USB_TYPE_CLASS | - USB_DIR_OUT, 0x0100, snd_usb_ctrl_intf(mixer->hostif) | - (0x29 << 8), sample_rate_buffer, 4); - if (err < 0) - return err; - - return err; + return snd_usb_ctl_msg(mixer->chip->dev, + usb_sndctrlpipe(mixer->chip->dev, 0), + UAC2_CS_CUR, + USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_OUT, + 0x0100, + snd_usb_ctrl_intf(mixer->hostif) | (0x29 << 8), + sample_rate_buffer, 4); } =20 /* @@ -1446,11 +1444,7 @@ int snd_forte_controls_create(struct usb_mixer_inter= face *mixer) } =20 /* val_len =3D=3D 1 and UAC2_CS_MEM */ - err =3D add_new_ctl(mixer, &usb_scarlett_ctl_sync, NULL, 0x3c, 0x00, 2, - USB_MIXER_U8, 1, "Sample Clock Sync Status", - &opt_sync, &elem); - if (err < 0) - return err; - - return err; + return add_new_ctl(mixer, &usb_scarlett_ctl_sync, NULL, 0x3c, 0x00, 2, + USB_MIXER_U8, 1, "Sample Clock Sync Status", + &opt_sync, &elem); } --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD5E247FAF3 for ; Thu, 23 Jul 2026 18:46:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832408; cv=none; b=uWdBkY2DAiSC6LyMKwTG6MhiyNVsholtiqx+EWoFzL5pXr0Q6fKlTo8iWCACeeYP4pT986AoByeu4NaqBH1bR6t99b70TdmelWta/u6KH2/mDW1s3B68jHWwiG16c1K5ThlG+4lKTOGlzYBPhhzux5sM8460GaDCm+eqs6Ekzwo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832408; c=relaxed/simple; bh=LdEcFe8ztfNdGkUJ/0XyjwO4PqFfQkW74j+BaEbSceA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=olgiskfxJgRhdSfYB0SANezMoKrwxahkt2iQU1eYyp8NRB0f7+xUxuFwoFZ5owHO6I23RRJs/N5mcEMuJ8NMLWSzZ1xaDllfJp3qIwDehuNAfAJj3fJPu7UKTWs+pZWVEXYEfos20kiJLenv9TXM/jJEHUht8RLGerMCD6lmJWY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sEg41UHc; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sEg41UHc" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38e3617ba36so977353a91.3 for ; Thu, 23 Jul 2026 11:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832397; x=1785437197; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=a2nXppCiGAGzj7x2K7RacxH7dn9WK6P2XEuUv+uCRKY=; b=sEg41UHc+QvrQx+7X7sh2+Txwrtx9RspBGL0ZfUrA0GcUMafGPO3nMBd+AtFONAgxd mnZN+k4JGLus0qQwGCDpYyUDcM81Tm5KZaD5c4vWhB2UNKqcayehioeNrNiprsId2q3B 6URoPqxtNQ8mhkhdpiAfvetCYIQxw6xmjnwBY6X85X/MyVq1dWCMCwLo77JKiskyz9Ys hqZBcEYu2MOPWRExnYDrR7WIZ8zl+2d4fG7SZ8l8ePw1W0u8P3Sk88oALPZ+gbQu2+Eh wQeOFa2QMihCFhhADwyms9x/+Vs+7CBi7CihoZlhDy+zEiBw4Jl2PElaaNFoojdcH90V Hhfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832397; x=1785437197; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=a2nXppCiGAGzj7x2K7RacxH7dn9WK6P2XEuUv+uCRKY=; b=qxNp3Pb87Xo95bubGmuCYlzcybgvweULnlvEeqPld33KAOAoI3ugrDsDezB83wAYWc iOJmLKgyFjKVCo0UN7Lzif1kW4Pgo59DI4pSmPswZjuuzAYTxivoV2Cmw9E0cT+pzEJR qLghOxtmihCOOTsSLQEuPOtAG1lvfccJ1p35MZSnH3eSVVXaA+EJrMMn+qgoVB7SVUIN W8GxsREBahVOS/GUX5wg4DxrE3geG9nUMmKN5tNNKs0NY6SAqVuMtUGqub6Mdca1jv66 gBZJhpSomQsgbAfDq+og8n68Bp0xyKQgFQX8G1tiw95rMwO3yWdUiEDZ2u6aiwWPsSzO +gzQ== X-Forwarded-Encrypted: i=1; AHgh+Rp83R0Il+/PIczqPldMwDVctoXC8D/V/rLiO6FFWRNK4FIUn5PfpIWnL9Vxj2ykzlM5jcg09YEoVFfbbwE=@vger.kernel.org X-Gm-Message-State: AOJu0Yzvf8gcGSGNZY6PCqe2H+2HzG4Go/bok8tZQd25PHpvs+/mipbc GJ1Mxt6paoug5w/kRt0/sHLnNvQ+fg6+zv+uW4yUQwXpnFI+w2jG8YR2 X-Gm-Gg: AR+sD11BJ8fkVYOSuEe9Nr0E9pvNm/Qla0e063UtgXmNN5KXWUojoLwdMQR7a63jtQM GoK7oyKYvbZ4SaIkxqNMu2KMYwv7eN+5+UTU5ry2O8l98yG7M7ga1b46oL8/IQ+2vv50xC2+EN5 zV8qsQzPYDySvMFu4nGTgJA9pSBKLgB2aElKCdquV1RXhpaRGoyaUFpGvNX/Z1rZzoh0qZ6kbmk SZ09a41q7vsWPT204Q9IYqZVm6mMSaFmbVzesMTe/9o+aGofKwZvOR1ug2oXbojrWTNVvrWk17E YyNi7oBDTAwPk/fnrc3u+BQHa2eLlDrHeAqEyK0yJzZmVmd1meFaY51CXDrSDJ80TmKd3Lh0diG agI+Vz3MbUJEErt8K036OMFDTQZDXNjeKUjiDETrOgog/aguM+7T3+zKzIP1+0kHSyCNKxJpp X-Received: by 2002:a17:90b:2e84:b0:387:e0bb:57f4 with SMTP id 98e67ed59e1d1-38ec6a965a9mr4789308a91.37.1784832397395; Thu, 23 Jul 2026 11:46:37 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:36 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Vijendar Mukunda , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Sylwester Nawrocki , Daniel Baluta Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, Pierre-Louis Bossart , sound-open-firmware@alsa-project.org, Venkata Prasad Potturu Subject: [PATCH 14/36] ASoC: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:16 +0900 Message-ID: <20260723184538.3888637-15-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- sound/soc/amd/acp/acp-mach-common.c | 11 +++-------- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 7 +------ sound/soc/samsung/smdk_spdif.c | 8 ++------ sound/soc/sof/intel/hda-dsp.c | 6 +----- 4 files changed, 7 insertions(+), 25 deletions(-) diff --git a/sound/soc/amd/acp/acp-mach-common.c b/sound/soc/amd/acp/acp-ma= ch-common.c index ef784cca13f2..01a0aaa60246 100644 --- a/sound/soc/amd/acp/acp-mach-common.c +++ b/sound/soc/amd/acp/acp-mach-common.c @@ -938,15 +938,10 @@ static int acp_max98388_hw_params(struct snd_pcm_subs= tream *substream, struct snd_soc_dai *codec_dai =3D snd_soc_card_get_codec_dai(card, MAX98388_CODEC_DAI); - int ret; =20 - ret =3D snd_soc_dai_set_fmt(codec_dai, - SND_SOC_DAIFMT_CBC_CFC | SND_SOC_DAIFMT_I2S | - SND_SOC_DAIFMT_NB_NF); - if (ret < 0) - return ret; - - return ret; + return snd_soc_dai_set_fmt(codec_dai, + SND_SOC_DAIFMT_CBC_CFC | SND_SOC_DAIFMT_I2S | + SND_SOC_DAIFMT_NB_NF); } =20 static const struct snd_soc_ops acp_max98388_ops =3D { diff --git a/sound/soc/intel/atom/sst-mfld-platform-pcm.c b/sound/soc/intel= /atom/sst-mfld-platform-pcm.c index 9ee4d9926e06..a4c8cbfba096 100644 --- a/sound/soc/intel/atom/sst-mfld-platform-pcm.c +++ b/sound/soc/intel/atom/sst-mfld-platform-pcm.c @@ -236,12 +236,7 @@ static int sst_platform_alloc_stream(struct snd_pcm_su= bstream *substream, =20 stream->stream_info.str_id =3D str_params.stream_id; =20 - ret_val =3D stream->ops->open(sst->dev, &str_params); - if (ret_val <=3D 0) - return ret_val; - - - return ret_val; + return stream->ops->open(sst->dev, &str_params); } =20 static void sst_period_elapsed(void *arg) diff --git a/sound/soc/samsung/smdk_spdif.c b/sound/soc/samsung/smdk_spdif.c index 2474eb619882..515e4dfc1432 100644 --- a/sound/soc/samsung/smdk_spdif.c +++ b/sound/soc/samsung/smdk_spdif.c @@ -130,12 +130,8 @@ static int smdk_hw_params(struct snd_pcm_substream *su= bstream, return ret; =20 /* Set S/PDIF uses internal source clock */ - ret =3D snd_soc_dai_set_sysclk(cpu_dai, SND_SOC_SPDIF_INT_MCLK, - rclk_rate, SND_SOC_CLOCK_IN); - if (ret < 0) - return ret; - - return ret; + return snd_soc_dai_set_sysclk(cpu_dai, SND_SOC_SPDIF_INT_MCLK, + rclk_rate, SND_SOC_CLOCK_IN); } =20 static const struct snd_soc_ops smdk_spdif_ops =3D { diff --git a/sound/soc/sof/intel/hda-dsp.c b/sound/soc/sof/intel/hda-dsp.c index e9f092f082a1..b9b2bdff4ccb 100644 --- a/sound/soc/sof/intel/hda-dsp.c +++ b/sound/soc/sof/intel/hda-dsp.c @@ -1114,11 +1114,7 @@ static int hda_dsp_s5_quirk(struct snd_sof_dev *sdev) usleep_range(500, 1000); =20 /* Restore state for shutdown, back to reset */ - ret =3D hda_dsp_ctrl_link_reset(sdev, true); - if (ret < 0) - return ret; - - return ret; + return hda_dsp_ctrl_link_reset(sdev, true); } =20 int hda_dsp_shutdown_dma_flush(struct snd_sof_dev *sdev) --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F42E483809 for ; Thu, 23 Jul 2026 18:46:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832410; cv=none; b=gJRbtF6DKztMPp2srdHRMq2hLklTeBiBst+w3a0bBEmu5Hh1Y7Emw97vWYOThQPr5EpISIQmVHIJysmUxJ4ae77kPnU4EMthJr+1F2IDpW3ShTVQb0w4De+r/BivuD4lK0rPXfM39FsqU+dQ7rV9yJfi0fOBUOvBVeuqdooLwcI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832410; c=relaxed/simple; bh=koLwl54hduwliaDn6Li/AbrO7iJtrRjAGHnmTifrPGc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OUeOIX3DcvsUad8P7NdkUz77zRN+TjEvfIK17GgUMoIVSF/fyKDMlGKvjVmbgXKpLZUa1ZLNvTxAuMq9+fduzkstMZ+D2HTMFqaD9oCEnVsmUenYAUpVeqBLLSafIuD3zpjs3sVRFS9bWypnLPVapvNexVpLXsZOfgFC6yeIjQY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TxpoLRqT; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TxpoLRqT" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38e07ebd263so690120a91.1 for ; Thu, 23 Jul 2026 11:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832400; x=1785437200; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ECPS5j1qCPcwB0YlL4FTJ27ue7WhDH56E/Wn/MeLYUc=; b=TxpoLRqTRQvl5KhCiowrngOKWXJfZ8rgv8ETnvXluAX8cUE0oIJ9Mn8LPX2O1mUKzR vyjyPS9TLBgDo+Do45clztxYhuKe4YIZ7gj9cdI82jXSc3/sYOLyscfe9z+XyVJdYDtv 8txziwMlbm1shHg37eGw3uk21JrO+8w5bdDyy/7A3p5SR2PzIkQaleFVIcP/pdzrIpP7 Sle9SLoXxu1rnq7Wf5zEO/+P5de5/kg/nhNDfeUEY7FCqTTQDC7N9KAyCMXRwVeUvm8y QJ1KZS6ujBFgF/wTWUWKEAdO9djPTuetHtQH00FR0qc14css9jrqjIBxF4mcYwu6WWsr BRNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832400; x=1785437200; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ECPS5j1qCPcwB0YlL4FTJ27ue7WhDH56E/Wn/MeLYUc=; b=bHw5ECkmpEhFdRzitOOjxKMGNYX+feKErOGXG5VoAdiEydCWYCOdetg7RdSvxqebVQ bcylTDar+91Hu0oxn0C7QAbfShWTgHn1NFJBptF0EhDzIkcKaWdes0ob+zrT3KV5/MrZ I6T/73LvJGsxRrmxgfxl4quEjrEnDSYdxnxRb1U/FS2U4/sPebJPw9rqebslxUpSkKgG NNJXY+KQbPUs5A2NSwXrkhNxpVc5BGSGuC69+i69v1mEcdu/CtC5QlYLzOcGzYSTwxa4 jEpFwW60HpTmyxH/iAZOLIRvUhrSknvKIRo6mnIgsxBiCO94tKMbTrISNNRFVSzgdfwk aINA== X-Forwarded-Encrypted: i=1; AHgh+Rq0JnfXtj13fnxi5jq6vIIGVUzTvOj6ol7NJ0SuClf9qMMUlK2J+560USrra/1o3/FoFKZXsormv2kpFoI=@vger.kernel.org X-Gm-Message-State: AOJu0YzuNkHVXRdlDFCN3S0XwoOE/pItQHcr1fEDZQNGgNg3YQZ9OPRv elkmMLWiHbRE7q5FFK+HsHBEbzWKeEf+FG309DnqZBbglu0GWg0maFtxFJ+hzEKYhPs= X-Gm-Gg: AR+sD10fwKLu0/izNs9ByewRtHZ8l9OEL7DaDYkzK6HAXoilfGV4OBorokrySRwfuoa LUqUbl7h+8N90DICOGYJCTOo53+m7vO0imvAcsvbnvDfMWDn+fPqWr1d69VoZJajFKd6ci8OW3L ltT+tG8ezPCca070dunQurlCSNg2pcv5HbnO55jG8FpGg1BszwENVfNxJezI7cge/lB5fWc0m8W COMH29ZHwA42PxR6on93kunjKvxnJhIiZeU/VOpd2WHsW6RqOEJW41vcMWUl+zmjjw1OpncGDVI uU5ifj7sNcn+NyZpbdoLLWmfybR9s7E+GZLkyO+fdORpmCR53VI5WhQykiBDrx0YxZrhQBJ9PFM AObH8M5t0fQuY/OqFlpR5mHQ49EKhQeUiMMZv6Ibj+UAL8pW5TB0GKdxa+mSvRJDUE1GVd8+y X-Received: by 2002:a17:90b:5588:b0:38e:6a44:671b with SMTP id 98e67ed59e1d1-38ec6281ddemr4252308a91.0.1784832399932; Thu, 23 Jul 2026 11:46:39 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:39 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Jonathan Cameron , Linus Walleij Cc: cocci@inria.fr, Andy Shevchenko , David Lechner , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Nuno=20S=C3=A1?= Subject: [PATCH 15/36] iio: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:17 +0900 Message-ID: <20260723184538.3888637-16-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon Reviewed-by: Joshua Crofts --- drivers/iio/light/isl29028.c | 6 +----- drivers/iio/light/tsl2583.c | 14 +++----------- drivers/iio/magnetometer/ak8974.c | 6 +----- 3 files changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/iio/light/isl29028.c b/drivers/iio/light/isl29028.c index b88e7c4eae3e..ea38d797082b 100644 --- a/drivers/iio/light/isl29028.c +++ b/drivers/iio/light/isl29028.c @@ -405,11 +405,7 @@ static int isl29028_write_raw(struct iio_dev *indio_de= v, if (ret < 0) return ret; =20 - ret =3D isl29028_set_pm_runtime_busy(chip, false); - if (ret < 0) - return ret; - - return ret; + return isl29028_set_pm_runtime_busy(chip, false); } =20 static int isl29028_read_raw(struct iio_dev *indio_dev, diff --git a/drivers/iio/light/tsl2583.c b/drivers/iio/light/tsl2583.c index a0dd122af2cf..a38a0130d854 100644 --- a/drivers/iio/light/tsl2583.c +++ b/drivers/iio/light/tsl2583.c @@ -456,12 +456,8 @@ static int tsl2583_chip_init_and_power_on(struct iio_d= ev *indio_dev) =20 usleep_range(3000, 3500); =20 - ret =3D tsl2583_set_power_state(chip, TSL2583_CNTL_PWR_ON | - TSL2583_CNTL_ADC_ENBL); - if (ret < 0) - return ret; - - return ret; + return tsl2583_set_power_state(chip, + TSL2583_CNTL_PWR_ON | TSL2583_CNTL_ADC_ENBL); } =20 /* Sysfs Interface Functions */ @@ -790,11 +786,7 @@ static int tsl2583_write_raw(struct iio_dev *indio_dev, return ret; } =20 - ret =3D tsl2583_set_pm_runtime_busy(chip, false); - if (ret < 0) - return ret; - - return ret; + return tsl2583_set_pm_runtime_busy(chip, false); } =20 static const struct iio_info tsl2583_info =3D { diff --git a/drivers/iio/magnetometer/ak8974.c b/drivers/iio/magnetometer/a= k8974.c index c7fdb7c2f543..c988d0e40cea 100644 --- a/drivers/iio/magnetometer/ak8974.c +++ b/drivers/iio/magnetometer/ak8974.c @@ -379,11 +379,7 @@ static int ak8974_getresult(struct ak8974 *ak8974, __l= e16 *result) return -ERANGE; } =20 - ret =3D regmap_bulk_read(ak8974->map, AK8974_DATA_X, result, 6); - if (ret) - return ret; - - return ret; + return regmap_bulk_read(ak8974->map, AK8974_DATA_X, result, 6); } =20 static irqreturn_t ak8974_drdy_irq(int irq, void *d) --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12824483820 for ; Thu, 23 Jul 2026 18:46:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832412; cv=none; b=qZp//qkl6GD+gPXBc6o+D0DEmnq2bTAKjuSEdh5BHI42mX/gmqg7kKHbUr7qMi/bm950O1l7yCEEIei5EurlFwOfyFjAVyAjEUiWB8wejTi/g8bWeQdg7liB2EhRWfJzyP8BlfkDGx84rC20P7eatK1MF0ETzZrnZjix716MbpQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832412; c=relaxed/simple; bh=OjuU5sZNyEfe3NY/W693mYnbMjjdy0/PtxQZI/XdJ4s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HhGsB2BRY/RR2h5r6nCo8vkTf1SB++E5SYbTcbF437dv+L/AYu9ZqmFTRI8j2QDV614l0KyeMnPu782APQvvgBkCuQQcx2nUjDizBp/MOyGFhoV2y+oXxG0tl4pyhRGwMxpATeMLInOH9LKMLD0Jf8kMCzLyS3hp19vel8oc+ls= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bfn2gqhm; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bfn2gqhm" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-381c51fde6bso1080063a91.2 for ; Thu, 23 Jul 2026 11:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832402; x=1785437202; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/ZyPlyAUxTK8Vz/tunABGXVD0bibLKDl8Em93+X7p/Y=; b=bfn2gqhm/GGnWxwuwqByRgdWQ0oGWL0dfEhGLe402t2Jkrd9xl72xo+UF8IscgxRYt 6oWbdXnUXmPJ2/wFW/wY9A4BBfMoBjLM41qpesvBg/6mWmSYRjmNVfopYWGk24biU+Mw Udu+DYkgMSye513XyNhElHr80sydkVL2DSGlQoU4/L74CKZE66Sej7Sx02+sqIwqnWLM EPCe8YuDgW3A/JKWk57YFHWsRnl01mVcHYlrZUnOTLZScDacRf2WTqH81fgeQj5b2L/V uadHYEu0zmDXmMatqWWSKjwjTWsjpQsMk7LSFTQm273w6bY2C3qfrE4c54kb/5CjRwSm kyiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832402; x=1785437202; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/ZyPlyAUxTK8Vz/tunABGXVD0bibLKDl8Em93+X7p/Y=; b=m7yjLAlfBhD8ybYs4Tv7DMQMSfjpTJfwYqs0juNeG5AMOCcbYTtODM4JwvSugmX4gd qOFAvptVgdTMkflF9v+hGWmsngxTXG674Y33DOOV3AWAA9Cm00xyjdcXnJvZlQd9jZ0X edguWXoT88vmubnqQQH5/YNQ1lx/hEIrNYsWLgnXS3bk4BnAGI2g8w5wxGUhKWbl9+wP SnqvqFFytIJZlKqjv9ZpMbdSo8k8pI2Qo3knCYemnYFUmH0omeTIlE1zha6C2xG2OiKB x1PAVBbyZntRk+rO5sdTumw5s8PW8KWiVtQeyjQUdLj6hnEsWHBvMUzfx8ZssRvwIwmI bGpw== X-Forwarded-Encrypted: i=1; AHgh+Rqq9erRHUro5oRmSsDb32sYqtSczupuvHT4Reqz8DrVtzD6AotRMeaGAcBCtmPd6DkXPzD0Y9KjsctJCBY=@vger.kernel.org X-Gm-Message-State: AOJu0YzO4ajpieknQWbJoUqP9xKVBZGHQkKCbYcElFbxCPzB7WLIYtfv 8dse+/H/kRRK5Bmx+wEVz8cNvC2Z0cYbVH7uUG5Eonlh5S8RZQpgMteDeckUac+GZIc= X-Gm-Gg: AR+sD10dh7QJvfvhmtc8pKzbpNAW946cEvMc+gGkmh5DRgrSGMOrOOnJJMqk3VDRmfX JlJ0sYJiKKq3x9huift/NFdRG1taS/PVXOaFHvssudN5qeIIMJEhcvTgsYSG2x3XzhD7CPfqbC/ fYGxM2nOs1ytIuciD1NHUzYqBc99yPjNhFmHUKlDNuC5edojH5501FteyVl/nRHJzP/gMsIa1v1 DBQgaVe6lqBKUVVvl4VXtxozFYTfrOFt8OriOvD71g0Wz3pe5+tBzU9WtY8Jk9xKR8R7B9eMHfW YJoZBrfosRBO7JpYyl+xQaEvrgCDIohsvjelDwA37iBIMwg6VhphGR2ZSAAF5I8ICMDpQlcCnIV 7QcO0giC0LzojT1mOUpjAmaBeLNsICmF8JzRsKaMAp1NYaxrZ2zcf/6QO3xPS9vcpLTDT7pd2 X-Received: by 2002:a17:90b:1847:b0:381:a766:efcc with SMTP id 98e67ed59e1d1-38ec642bd8dmr4696955a91.14.1784832401698; Thu, 23 Jul 2026 11:46:41 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:41 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Dmitry Torokhov Cc: cocci@inria.fr, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 16/36] Input: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:18 +0900 Message-ID: <20260723184538.3888637-17-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/input/keyboard/pmic8xxx-keypad.c | 8 +------- drivers/input/mouse/synaptics_i2c.c | 6 +----- drivers/input/rmi4/rmi_smbus.c | 7 +------ 3 files changed, 3 insertions(+), 18 deletions(-) diff --git a/drivers/input/keyboard/pmic8xxx-keypad.c b/drivers/input/keybo= ard/pmic8xxx-keypad.c index 35d1aa2a22a5..c916e80e2f58 100644 --- a/drivers/input/keyboard/pmic8xxx-keypad.c +++ b/drivers/input/keyboard/pmic8xxx-keypad.c @@ -462,15 +462,9 @@ static int pmic8xxx_kp_enable(struct pmic8xxx_kp *kp) =20 static int pmic8xxx_kp_disable(struct pmic8xxx_kp *kp) { - int rc; - kp->ctrl_reg &=3D ~KEYP_CTRL_KEYP_EN; =20 - rc =3D regmap_write(kp->regmap, KEYP_CTRL, kp->ctrl_reg); - if (rc < 0) - return rc; - - return rc; + return regmap_write(kp->regmap, KEYP_CTRL, kp->ctrl_reg); } =20 static int pmic8xxx_kp_open(struct input_dev *dev) diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/syna= ptics_i2c.c index d4cf982f1263..85e37e2ce45b 100644 --- a/drivers/input/mouse/synaptics_i2c.c +++ b/drivers/input/mouse/synaptics_i2c.c @@ -257,11 +257,7 @@ static s32 synaptics_i2c_reg_set(struct i2c_client *cl= ient, u16 reg, u8 val) if (error) return error; =20 - error =3D i2c_smbus_write_byte_data(client, reg & 0xff, val); - if (error) - return error; - - return error; + return i2c_smbus_write_byte_data(client, reg & 0xff, val); } =20 static s32 synaptics_i2c_word_get(struct i2c_client *client, u16 reg) diff --git a/drivers/input/rmi4/rmi_smbus.c b/drivers/input/rmi4/rmi_smbus.c index 6de68c602558..3160714a514a 100644 --- a/drivers/input/rmi4/rmi_smbus.c +++ b/drivers/input/rmi4/rmi_smbus.c @@ -177,13 +177,8 @@ static int smb_block_read(struct rmi_transport_dev *xp= ort, struct rmi_smb_xport *rmi_smb =3D container_of(xport, struct rmi_smb_xport, xport); struct i2c_client *client =3D rmi_smb->client; - int retval; =20 - retval =3D i2c_smbus_read_block_data(client, commandcode, buf); - if (retval < 0) - return retval; - - return retval; + return i2c_smbus_read_block_data(client, commandcode, buf); } =20 static int rmi_smb_read_block(struct rmi_transport_dev *xport, u16 rmiaddr, --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF67644C517 for ; Thu, 23 Jul 2026 18:46:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832415; cv=none; b=WM0V7/HChsnJVo6iZSKZznVjtq3QgO47GnHTa/NfwDg7RvMdNHFiH5JLjgq/wGuQ8ZiblYTZR09RxYXwZUPZdr/KZdJWBDXvD9Iur2EHOI+qjS3r5gHQueBbEGn6Xv8h0sjlxNjUkL7bvU93LOO7C4wS/egNC6t9bWHxrN9QDYE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832415; c=relaxed/simple; bh=Cw+Iw1oGtwEx51kVwGrw3fev8VnbppEtNmYYejqZ4k8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=brBS1ZXRxkwojdNAgvJ9h/96laMDBq7pHBM3XIm4lGQyM/Dn9NX0DIam5xHJOfCWVBn6MhMiBR/ECxCnzrbwpVI0jKMVCjD0GpuPYtayhMMPBpXSSaM2WpKrcYSS0yRXGMcaBFeFWOBrLDNiVmHVJd9Vw936PAbF12UkXaSkH78= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rrayn80G; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rrayn80G" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-3856d6fbcb3so905944a91.2 for ; Thu, 23 Jul 2026 11:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832404; x=1785437204; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+53O0vXfEk/QFHYiZ5anDwDOO58yxuSoKuAHDn4vUGA=; b=Rrayn80GyoPbn47Awu8p0FeVSUqRihf4syZGb0mp7OMFHoSLIufvs/gTViqDgiy2+r m50WNTDbGGRdLwOiPPtChc/hcD/JWsMoOek13o40xvXQ0ocDCpBdr4SYU6dwcfwHorb1 ErswQHiUI7H+aJW2IkMWIefLGH7H2SNbZdKNiRnQnJBTUSQh/6MD5STi6hG+d5YPUPsX 3pEnW6fZ2g262BLmUNGxRDHBbFQrGBtcVgzQTw0dZfLbDGUye5ucWvWI66+P+y934mN2 Cs/X6eDVdiGbvpwqc5fT7nJR20kGy5hz6+rTDlVXBA+rZSF7nEI2OmCGt7Ezpg7PLE9z 5cIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832404; x=1785437204; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+53O0vXfEk/QFHYiZ5anDwDOO58yxuSoKuAHDn4vUGA=; b=K9kiQt0KekWdWlOabEzRfofSppaDwppZisDco7YfsAeLm+LuRusW1E+ktecXAAwoX5 KjWREY1wko/9cZUB+zM5lFd3pO8IIjf6iL9gMEU1jJ0kAgfO5N33dQdYeShzdk+ik4C4 rDwfXthrIBUIEOKJPAFHuLvC10bglyYU8s1exb1YQeA00VMY73JzIryOMj49+Oz7p0n6 c+7gh8bi7z55fp/ei1CwB5oNUfHvfq1Y9AvbmKcSmjxg1fQ3fo69nQVGw/HdU+2Cfe3q gJ59hOLRTB6r/Y++IXfYDX/GcJvT11i75VszYUKzLolET45yz4eAWk8AvXAplmuo3PNU mv4w== X-Forwarded-Encrypted: i=1; AHgh+RoO+KRPm/rUBHk98SJpCdiajICIdqNg3Kmsw3i1U0OWMFZrBDnclNiNWsks63vuEh9GJDCGHEGjOxZC6d4=@vger.kernel.org X-Gm-Message-State: AOJu0YzrKasb85sW4sSNJo1fIN0cNB0bWvFIPPQExTGrBgNHQCWI0Fms zE7fpviTMRKW+wDIRKMHnTQIthfrv/+j1F1sJaOgerxFbga4u9+L2ZrC X-Gm-Gg: AR+sD10Q0aQ9bwFCYIZifyiRFixmKU9gH8hwlviTWNfbJFeOg1G4IktddOQ8tVOgt4c oFRlx0gga4w2gBlo33y9VNKG24STdZWDZbXD8Se25N6H7+E2IvQymQOPx9rS90qrus7XHUnDD33 Ywp9WpUhMWl5+QY0xY45LjxkkVw2GNp6R9wgYVGCKISRON/Ejdo2d4Sbk/1PZO8d71qw3OFhsLF uRaQWQLzcmIOG/wGUfSx7Xjl5oOoSltLqs9caZFLhKYSpQeQwPm31bA7PrtIkearp15+67mk1/z qp6K3cu8LZXRHP+meSUdKozz6G0FeCgv/uuLWbxFpm++GPo8lknCRluOFDz+jcHDVrFzE9uXvTy fzm5/FVMtMoxbpXFQYX3SY8uWr4EJBlnMbeg8uBhQZzCYXMQItfPJOCZQGpzcPcQ0Yk9YEWbR X-Received: by 2002:a17:90b:2d10:b0:37f:9cdf:f03e with SMTP id 98e67ed59e1d1-38ec6632b70mr4099341a91.33.1784832403772; Thu, 23 Jul 2026 11:46:43 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:43 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Michael Turquette , Stephen Boyd Cc: cocci@inria.fr, Brian Masney , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 17/36] clk: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:19 +0900 Message-ID: <20260723184538.3888637-18-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. In the lmk04832 driver, the hardware sequence comments are moved above the final return by hand. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/clk/clk-cs2000-cp.c | 6 +----- drivers/clk/clk-lmk04832.c | 12 ++++-------- 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/clk/clk-cs2000-cp.c b/drivers/clk/clk-cs2000-cp.c index 8800472ba63f..4de581771d7d 100644 --- a/drivers/clk/clk-cs2000-cp.c +++ b/drivers/clk/clk-cs2000-cp.c @@ -404,11 +404,7 @@ static int cs2000_enable(struct clk_hw *hw) if (ret < 0) return ret; =20 - ret =3D cs2000_wait_pll_lock(priv); - if (ret < 0) - return ret; - - return ret; + return cs2000_wait_pll_lock(priv); } =20 static void cs2000_disable(struct clk_hw *hw) diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c index 9bf86caad829..f006401c1586 100644 --- a/drivers/clk/clk-lmk04832.c +++ b/drivers/clk/clk-lmk04832.c @@ -822,13 +822,6 @@ static int lmk04832_sclk_sync_sequence(struct lmk04832= *lmk) if (ret) return ret; =20 - ret =3D regmap_update_bits(lmk->regmap, LMK04832_REG_SYNC, - LMK04832_BIT_SYNC_MODE, - FIELD_PREP(LMK04832_BIT_SYNC_MODE, - lmk->sync_mode)); - if (ret) - return ret; - /* * 9. (optional) if SCLKx_y_DIS_MODE was used to mute SYSREF outputs * during the SYNC event, restore SCLKx_y_DIS_MODE=3D0 for active stat= e, @@ -843,7 +836,10 @@ static int lmk04832_sclk_sync_sequence(struct lmk04832= *lmk) * SYNC pulse to delay the output by some number of VCO counts). */ =20 - return ret; + return regmap_update_bits(lmk->regmap, LMK04832_REG_SYNC, + LMK04832_BIT_SYNC_MODE, + FIELD_PREP(LMK04832_BIT_SYNC_MODE, + lmk->sync_mode)); } =20 static int lmk04832_sclk_is_enabled(struct clk_hw *hw) --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDA734CA292 for ; Thu, 23 Jul 2026 18:46:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832418; cv=none; b=jFqrV8ZwWuUP3LGh1tFiyJpGYabGR54zeKYhgEL+Z8YDUs9fpDIF6BvgwbUhPsPRr8RLyCg9W6cnmxcGoW4VvG3FFpvO9sgeOMCqExgsQxHVezH4ll71F2YXI8ipuUGyJLXo2WLaxMxqRyUIZTTYNg6hR1ymvN7GuF3+Y37DBLw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832418; c=relaxed/simple; bh=2XerIORtjYT6lU/QCxj94nR/+mthwLJM8r1lYonXQgY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q2HHyNI6yuz0xEFreqEI3pPLI2EPg6lplnMdgyU5J6atFCRej4uM20pjnVeuYhYGDjHS6VEeGV/nvjYJbu3iPo1K4nG5h0LF1ZoB4BtA2TAfooSOV4ytsB0aHVpmoKSob08+Iw9qjIXGgrN1LsqCi+jQQKHphXxd5FivqKse5yk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CQvez56A; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CQvez56A" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-38759bcd877so917832a91.2 for ; Thu, 23 Jul 2026 11:46:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832406; x=1785437206; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MvMxjqNvpASivPiDAcPmI8PwBsKAarLbQdQ8wRHMWv0=; b=CQvez56A9PDOxPPkjW5dr+x5rcO2ncfLNjk2XekL77va8AYlax4uwKC+xoCZJFyldM 9vXsoTXkWPSFVSM4MdfBePJi6fZvBAL5HmB5g1wE+uOXC9uE84R+lgGI5ZetHTHgdw/X r0iFOg1smVEQIxmlVQEjPpJabbo0FLkky0ntrUSTvgZzAN9dl/1EiOig0CvQ4nbcEwJs aun1+YDL2wPVMTrkRGSiprOEqbJMNZaq+vpIaGhrMMmUjKtqBLBd2uiRZO8OZxg5CnQ8 6MRIol28m6RCnLrt0OwdUdIq1I4EEuqXcAVd3aYayTm5u8GSqCk+SkqQD2mUiU86TWTj gSKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832406; x=1785437206; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MvMxjqNvpASivPiDAcPmI8PwBsKAarLbQdQ8wRHMWv0=; b=dif9paEyvU2f3t+h4PEdzpTgHENg4rRCvYV9F3NpxRkeDQPMw7stUApe2DjbEaYkLQ 3HGjjAZNCxWwki5aYXIKrSx6RQJcB4c+yS//QmJVMHtOPEDmgjtpqDROb1WG9hisPf6U lvokUmFku2HzN0/EvzXu2FVJu3z2vX/OBWnlyDSaOhhwagR1SWhB4qfT8NPE400/TZnW U7WZX/K2lp/hSW6fy5bIiwe8bt/HFyVOOX4S+pR8wdPiSYd7ai4qi6UsswaZqPkw7yAY r3JXs5QCt28hkaKUHhGcuLptzClp9HzJ/4WELe3I2Z7jk7sOtljWaAs5mAvYz929bFKu Q7IA== X-Forwarded-Encrypted: i=1; AHgh+RpA7YENkGEN9Svw15EWTRwxgQGfSw1s9vtZBEJxvw8ZqN6osAJl0MW3HNf2FhDdz9TQkOqYOJnoXD/Ttgo=@vger.kernel.org X-Gm-Message-State: AOJu0YxaQX/CiEbvz5afVFj9H/cqt7Sb5CJ+ClyH6nWN2i15GP/J2+mX mVupzx4LRCinbO2SmWxRWuGvfC2rrxIYhyWt2+rxCn3W1d6WZkpdgh0o X-Gm-Gg: AR+sD13cvw2xqM1F9F+hJOXAd4qFVUKArwMN4KryjM76ZD+HxFJbJxLVk8t0BK8mmup clxX9t7aeHA+MxhR+8Mgh45OP53vUcWgUNr9niWhS3LKZ6TNupWwQA982VCl3Ymz4qj2PKCABZz NiUc59XTkq21IP8VxjCffAjz7Qd0TKoB4S2Hor5Pq9O3JxeZQDcvARxGIlhb4X7vgYPDU+6pYIj jO3++n8fM46/KOKAuA8dW979Mtrp5zAcVX4QH79KH6JkKcJGJiTSoeQryu4eV8MYQz/P+4Rzpwy hO2q/TX+wC+rnfEagYRZkRbZ8pD6N3RJ5zFmdRJ7Rwk7WTZhmFZCWizS9dVA5kIt4A80zkKchh0 8KnklE7YF3kChlJECG5PPvCLXzBBx6/tsTLUs/oIY0JjPmI6xC8oonTBhEEvydFAgHH0bpqvA X-Received: by 2002:a17:90b:3904:b0:38e:584f:2515 with SMTP id 98e67ed59e1d1-38ec6aae88emr4263344a91.37.1784832406282; Thu, 23 Jul 2026 11:46:46 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:45 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Giovanni Cabiddu , Herbert Xu , "David S. Miller" , Srujana Challa , Bharat Bhushan Cc: cocci@inria.fr, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, qat-linux@intel.com Subject: [PATCH 18/36] crypto: drivers - remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:20 +0900 Message-ID: <20260723184538.3888637-19-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/crypto/intel/qat/qat_common/adf_gen2_config.c | 8 ++------ drivers/crypto/marvell/octeontx2/otx2_cpt_mbox_common.c | 7 +------ 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen2_config.c b/driver= s/crypto/intel/qat/qat_common/adf_gen2_config.c index c27ff6d18e11..57025bffee73 100644 --- a/drivers/crypto/intel/qat/qat_common/adf_gen2_config.c +++ b/drivers/crypto/intel/qat/qat_common/adf_gen2_config.c @@ -155,12 +155,8 @@ static int adf_gen2_comp_dev_config(struct adf_accel_d= ev *accel_dev) } =20 val =3D i; - ret =3D adf_cfg_add_key_value_param(accel_dev, ADF_KERNEL_SEC, ADF_NUM_DC, - &val, ADF_DEC); - if (ret) - return ret; - - return ret; + return adf_cfg_add_key_value_param(accel_dev, ADF_KERNEL_SEC, + ADF_NUM_DC, &val, ADF_DEC); =20 err: dev_err(&GET_DEV(accel_dev), "Failed to add configuration for compression= \n"); diff --git a/drivers/crypto/marvell/octeontx2/otx2_cpt_mbox_common.c b/driv= ers/crypto/marvell/octeontx2/otx2_cpt_mbox_common.c index 95f3de3a34eb..1542a110ba37 100644 --- a/drivers/crypto/marvell/octeontx2/otx2_cpt_mbox_common.c +++ b/drivers/crypto/marvell/octeontx2/otx2_cpt_mbox_common.c @@ -235,7 +235,6 @@ int otx2_cpt_lf_reset_msg(struct otx2_cptlfs_info *lfs,= int slot) struct otx2_mbox *mbox =3D lfs->mbox; struct pci_dev *pdev =3D lfs->pdev; struct cpt_lf_rst_req *req; - int ret; =20 req =3D (struct cpt_lf_rst_req *)otx2_mbox_alloc_msg_rsp(mbox, 0, sizeof(= *req), sizeof(struct msg_rsp)); @@ -248,11 +247,7 @@ int otx2_cpt_lf_reset_msg(struct otx2_cptlfs_info *lfs= , int slot) req->hdr.sig =3D OTX2_MBOX_REQ_SIG; req->hdr.pcifunc =3D 0; req->slot =3D slot; - ret =3D otx2_cpt_send_mbox_msg(mbox, pdev); - if (ret) - return ret; - - return ret; + return otx2_cpt_send_mbox_msg(mbox, pdev); } EXPORT_SYMBOL_NS_GPL(otx2_cpt_lf_reset_msg, "CRYPTO_DEV_OCTEONTX2_CPT"); =20 --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C3314D8DAB for ; Thu, 23 Jul 2026 18:46:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832422; cv=none; b=MzgTuWTkhh/JWldV6wGgp5KZDbjdL3Mxx8MtF0IrzfgBfVW3GglT3qIJBAS3Ra/ddUy20vtFivRTWjspFUqk4+Je5tZOp3rJtCkdVTpzrBsOwCUgPtjBXp6Qzp+cuEFpsEE0dC9ywVEK7Gph0wThyIaoNIOqEUKj1Ps8WkquiNM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832422; c=relaxed/simple; bh=JlumXXFYa4YT2z0t/Rv8VpE7rH6ygFShwNbbT7uFZdU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ej7UP3wjrB3uF6lT7Ow6NQ3uUltfojmbjOUkqzzimEF+bJVPjeK5N/B7RqFLXAPcwAQimymwFY7IUkuTKyjAlANR1ulN2uczCSclEJUOqr335/PkWhc/+xLiDF+2nnl2lF/qnvMZbcMF4V15Rxgv/VsaXRqXIJmD5CTnOvaQlI0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fHyUgATG; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fHyUgATG" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-382ef647e20so1066338a91.1 for ; Thu, 23 Jul 2026 11:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832409; x=1785437209; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=inEAHAT4FZx62nofTUdSreIh00cPh6gTjTfAeZvFyf4=; b=fHyUgATGzbfJZ2vlpUBJVp3yHBjyEQS5sswCIU+IiRFhFsId1U5H605OqFcKZ5vrdu n4Cm1lK5dxN/St6pRWMW9qoaFjT0vkRxROtV2ajqGZGDaVBjTRokb5lSb9El9sbOfMaf ckjXvJV0YrCmTO/Kg2SAk6vEsWEJEoQBAjRCQ9EDZmanz1WtOypXp6Ln894rMLA9zX9c lRg8M+rtEEyvB7FfT0+qxhdVCsWOhjV+GU+DtQqK2c1AqK60aiSansBLnNSceQUDhFsq nVf3cTWkjwvXExj1CDdEuPlibtyPDDypRehic92vK9OkV7n1Qz26JA+DSv/QERXOhquX Sy9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832409; x=1785437209; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=inEAHAT4FZx62nofTUdSreIh00cPh6gTjTfAeZvFyf4=; b=pHC7W1ZqGNZwM82Wr5iiYVXp5XLpJVcq9tLy6tnR1PprzW38Br2eik0bcu/Ze5ffbY nQxezH4mND4knvMIJBGZDTJp/sJsEihVb+30sqtHyDhhYdVANYkEkUXAxh1HH2qeGney 34Mjwu5E1V/ClFINSFipceg49m8vbzI1j8uRnTkRjaj1n0wgh4oIGshnli4/WBOya7nU RT1S64X6yTnRE1qe2Hh3Kp7iJm6Da+LxwCMb4/PLXyaG0CtXfrBHrYQDK8hFd4QSZRF+ 3F6CpeQ2P0hBXCzHtKB7EHKi12zALGH6EB2ZOzN9QEsL3PiuwED60TPRd+OXbWqxUUQV EkYg== X-Forwarded-Encrypted: i=1; AHgh+RrOl5Y1lOX7z0J5WT5nptN8jkghFFdP62LEs7ztiKkyzMKObJAjGSicnEFBwzDRYfZmjjhuSBJW3yYA51Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwRIl8mg+fflpM678VN1dODNCeez4x14QANZ9H7yI4bf6adSBjV 8O+zSWrvH1rZwQ3Wb6h2lFw/7EfCPwzDXA3j9vAENoKir7jkV5rTeHIW X-Gm-Gg: AR+sD10mFL4ZFbqBy5gxHUIgZSLK735Hj8xkieoAR1pXjWOr0Dz3nEiohxnSAqfAQ0L 3yd0ttwSiIrnr6ZOmQ8pGlL8DC/P72+j1kINA3ERbSCkbJ2TxkGszNsekUd7s9N63Y1lBALKpA3 FwwRivaUw5yFINvYB/AlxOAkoxUFiyFqTDy4TWTCbw6QEFc8KQMBchvuQXrXJwKpwwKf1no82Rr T4/WHqM8DnGRVUIBd6zXe5eWBvyU3lM9cg6n1/zlUTl+XwEirU6uRZvLVQa+NJhqF3jwEK1hYF9 ij6/UzhPT8+bj9cVz+XoKqfVn25Ek/v1/TDahGTNhqfN2kAUVXC2IwBJSX/cOKTdkRYOdwJDDv9 TJncCXWu0ksYL8IqPsVO7rI6tXdh9h9Q2uf74Z17zAqEAl+pYxddK3U20VzPfbOZRHSubIGDs X-Received: by 2002:a17:90b:5603:b0:38e:7eb:d07b with SMTP id 98e67ed59e1d1-38ec6622023mr4815354a91.34.1784832408660; Thu, 23 Jul 2026 11:46:48 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:48 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Sinan Kaya , Vinod Koul Cc: cocci@inria.fr, dmaengine@vger.kernel.org, Frank Li , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 19/36] dmaengine: qcom_hidma: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:21 +0900 Message-ID: <20260723184538.3888637-20-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/dma/qcom/hidma_ll.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/dma/qcom/hidma_ll.c b/drivers/dma/qcom/hidma_ll.c index 53244e0e34a3..f081aa787f0c 100644 --- a/drivers/dma/qcom/hidma_ll.c +++ b/drivers/dma/qcom/hidma_ll.c @@ -677,11 +677,7 @@ int hidma_ll_setup(struct hidma_lldev *lldev) /* configure interrupts */ hidma_ll_setup_irq(lldev, lldev->msi_support); =20 - rc =3D hidma_ll_enable(lldev); - if (rc) - return rc; - - return rc; + return hidma_ll_enable(lldev); } =20 void hidma_ll_setup_irq(struct hidma_lldev *lldev, bool msi) --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DC5A483825 for ; Thu, 23 Jul 2026 18:46:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832420; cv=none; b=QaQoW+mu9EV1n4m7mV43KjqHQxWSxcWWaoEnlhy/FZ/EiKHIPLBvpzfDyLXKOR1qepyxuFwOBVxslFwlSL040gYKmrX+Rer/Y2W/Ay5gl7+LFcAhEJldQ541rDx20C8AKiqTJoJREHd1RLorM2uWntPhVliJMbK6chFsZXYKGIQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832420; c=relaxed/simple; bh=nW6MrRHHWnzwdABJGwvCPzIc7iuIrbsXtzd8lLHRzF0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g5Cm+thIcLx55uKRtiyTRQmAZcifL/gRFkquUgSE6gfUPqcw7eIopmIv6fRy/TZHYCu+662QZoPp5SyUPe7mOHrrEgL8VrmQP9gG1rL/R6jOgixgm7nWazHpzjZNyMIu2ePmPySoNNsqC8RWRQZIo8Zbhyu8A3grbI5QZXPhZ2Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FmYczvoy; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FmYczvoy" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38dcbade417so1041738a91.1 for ; Thu, 23 Jul 2026 11:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832411; x=1785437211; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wDObpA7RQnlY6KsOhvuFRPLttcc0bMB5PHs3ILqM3SU=; b=FmYczvoyHn21U0Gbb5wLNp4iN9lk+/+wJecEllmw6ZrNRNaMIZnoB8uQUx3Rx9E8VQ 8RH2C89/vPSYNjYFDa6NYr1o0PRzEiljit/3+M9ZaW/3oT3dctU54coZ7aWbtfpDXFPd 9hW3sbnahCHKckF1Xg6UjD/uQ2KPWLWyyAzFVwWIuHhYhpqlAvRNeETmUVgOv2YL9XoG 5qXiZwfkx+tCV+VIVqpR2bDLjTOiWpS9sI8hK6lXwSs+yH287lPVkAwOkJCg9jTidIc+ E6CxBXJ3VHxQAmLtIOz6ykbDCV84lM8X1xYNqwTebYxlaJGay18P7bdn5KuFPWIYHc+8 3dmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832411; x=1785437211; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=wDObpA7RQnlY6KsOhvuFRPLttcc0bMB5PHs3ILqM3SU=; b=sstm5f2+4t6A4NYfNKM1bqWxdq4VQfEaLZrN5hRPvznu/Vlm09xl80Za57GycDlvxt whgK3bWtOmoJ5CKaKOWV5TYhOF0/Y8z1x50q5J6LOumqQTkl45eCc2oHy8Phocr8vxnF 5bms5D8IM8dy9OnXIk6HtbqPgBEmUwOvLoUpu4ey3m9ZqvZM7BUow3AwHSIav4QLXQo3 n4GPyQ09ZnojRVRIi1rrGxb52cguyZmlhROAW2zpPiUow4A1NH3TvAP9ELclX/WyVNmW MgGPLQhDjItDInyP/pEsSzCGenVv0qUPifdHhR/9+FVxRBVgmr9DcrHoD7greR+TIQTx uApQ== X-Forwarded-Encrypted: i=1; AHgh+RoqCnDubIpWG9tDKnypf7dqD31DIg8Erl6Z9BtNhXgUddZWJ/MikPD7Cvq9heZlv4cfl9QvxNk0qoXwiw8=@vger.kernel.org X-Gm-Message-State: AOJu0YzwjpmMbqGER8qQWFrNcqLAFS65xAJDbpw8F9QUNh+u7iNATvUW XAMzMYoSbnNBF1CMu2GlsQK/92JHkfHqbDa9KBOOFAJmmU9gYDQaHkUp X-Gm-Gg: AR+sD12VelMygxzsNWCUR6CY3LpJOfRpbusR5FnnTsheyLlrMBuwHG493/hF6jk9V3A 51FnAWxdWpgptnpzA2lP6fYl88wcM5OxufuwrXUYmWrPTcIEsTe0emaZq3ME3mCtjTLt0ulzmDX B8R9SWw/omUsutHxehezUDMalRjryxm/6LG4GLjNS89ehu788RKAVOzZ4Aljf+Ojpb9pNgIHsrj haahPmQhQmMVQq/l2cFzBv9jFb33b7vQyc6Ux2V13DE5K7n0z711UMmlHTzYdapFJAaL5LWzomj JPnXbh/OThYsK75vdWrjt3rptmk8vsbx821TglKLfFx2JNwndzzQBRp/fHJf+tVPpieF+2bpRGB 2a0UABCBgnxpDaonLYmhGLscPJSK3yKJX9IiPD6NdwJo3WnINGKPbQZTohM7NK9B+LKMgaWFUsn 3ojyC5fD8= X-Received: by 2002:a17:90b:1cc7:b0:381:f7a:2e0d with SMTP id 98e67ed59e1d1-38ec66379c9mr3820244a91.33.1784832410845; Thu, 23 Jul 2026 11:46:50 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:50 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Alexander Shishkin , Maxime Coquelin , Alexandre Torgue Cc: cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH 20/36] stm class: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:22 +0900 Message-ID: <20260723184538.3888637-21-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/hwtracing/stm/core.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c index f48c6a8a0654..edf3d69a84a9 100644 --- a/drivers/hwtracing/stm/core.c +++ b/drivers/hwtracing/stm/core.c @@ -602,17 +602,11 @@ static ssize_t notrace stm_write(struct stm_device *stm, struct stm_output *output, unsigned int chan, const char *buf, size_t count, struct stm_source_dat= a *source) { - int err; - /* stm->pdrv is serialized against policy_mutex */ if (!stm->pdrv) return -ENODEV; =20 - err =3D stm->pdrv->write(stm->data, output, chan, buf, count, source); - if (err < 0) - return err; - - return err; + return stm->pdrv->write(stm->data, output, chan, buf, count, source); } =20 static ssize_t stm_char_write(struct file *file, const char __user *buf, --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B23A3486655 for ; Thu, 23 Jul 2026 18:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832422; cv=none; b=Nzm530rnGyrB6yOcCn03uT5+AwLc4dXbNVVUMBE6Nw9Z7cxDaGWC7Wr68BWIVAuNtIFVL9OQEHf8lcrgxQylQg/KGoKdemXoKPacO+yl1AL/nD7y7kwkuaPFsZglJYcFq+xPTMwDuv8sAFZuyASx2TnaSit3L071rpHdEP+8Rkw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832422; c=relaxed/simple; bh=MtaJxvWtcMxwy7KysGC7Xw5ElTrFk+fHV4mJQzPjRfM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bZA0SA73l5hMl2MycG2b9lx/J3uVs0VtTbKjaEx79Y/uS2UPVVKgAHBkcA4WBIsWTmsUfwk3pkooR3kA8VBfoVmw5f5ALsUDyPNIW5N1pPL2HHxhQBdJSOdIaPe29xlmsPoVz2sJdh9OaNb7RCShMWx7Qookkg9AfNzhv4vLVac= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K48vG5E4; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K48vG5E4" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-38e3617ba36so977627a91.3 for ; Thu, 23 Jul 2026 11:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832413; x=1785437213; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vcxLMkMQkwFPgPh32AUwe5n1PBUGwnayfW8DiD3NhNU=; b=K48vG5E4cJ1J2x93yJxYL3G0T60/XocQlB+Qo6stdYGkRu1E+4OR38wENw6xhLGsno 8rIpbVfXzJziWjmyxLz0gg6T/yOEeFcOwAjNnRMykKTQgPj2HpnO73yKA2Uw4X6hWzcV KNO1z3JQpxG+woaEP6enBtG475G1fhAEs92OkAYCjvNs51PBGqLZV2leHWXD4DpmEyOF UV5cELD/8mzBS5HhzTnD2jJh7USJiOiq2axVsAe5ycOfjyhG70NFb9bmhTVEWdkDSblE HC+2CWN5bFUEhjmRvkmAZVhyLUSoJ777mdmHExy0A8MQWu390MdOfyH5iswJm4Lu6pq/ YBnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832413; x=1785437213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vcxLMkMQkwFPgPh32AUwe5n1PBUGwnayfW8DiD3NhNU=; b=iiE6qb/pMja0p8UFi0IhF/095lxLsEXSUCps7awmSHrEtMWUpGGPbjun3cj6wtLz6R Rl4LIMRhUoYLH4NbuyDIX0ufYNG01EP5/Dzywf7YX0lZKLFTGr5sR4PBpDorfiLJmTPd xIUewjjRpSXukzwQ+rT9dCzTSKYT9/2yvOS37X5ThiMLRBEBdf0Wjac83aaL5fmv0f4i DLu1IVsQl8uQqJptUdZrp9mRkpkfKMaRqWbRhdnluJcxInukGtaNF+npReuifU1snAoM wXd9JTQvfqE176cCTLZR9iL1txXpEnDX7siMxeB+3ySR4gXaGZ9hz9Yd4cOhVRDWzc6Q 7/1Q== X-Forwarded-Encrypted: i=1; AHgh+RqWT0gyE2HOZF8MjewEN9hxXGKbKuutQv96da7hkljYcZLgAtTYbrEnZcRAg1ybF3sv0leq/mp/4NPVfRI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0a8aNvgYQZQjtBs6Fn/0gTTDQVse7KsxP/AxMwLBcXoPVg7P4 hbU0DSjN4189pgZgLo/qVxX+DL4k6dUxUqS8DW4WGf7RlN8h19HA0Dsw X-Gm-Gg: AR+sD11t6BPTCpNssNYDmax1VjAGbiDLiUUoAM/o5WOMXcPEXlH4vN3Fryw0bOsZq0v bULUoupIozdwXqnnj8RKqZHehTrLIFeWP9uDtkPWd/hjQsLLzIdl9fhD4RsG5z9Fld/KDWpwb+m KUjRjnCtmHLRElwQHXhtMVvnWdN7CZ70QaymMfkHK+S3lvpqXLtGTvM+teS07uaw5EwfKR+saxP LJ1cjAg1Vcfe+5BWbCpQ7PDvg/Xt2ZNPyD/zQD+7E0dMrssF1je+Ccp4a6W/n9A0ICgzNy6cSAY 7VGG6ajLRey3ADWv1yLwrt5ihCGcGglG516RSGvDE7OVLm24COzd8MiKV8y4djOmuCOEx5bOztW tT9qqTLNnA9NWRRGdDKoIh24MWLtCrdHOm9b21cUbBDVtNEGJ0mPSrrVPQCjsC2JoOqEfKeCt X-Received: by 2002:a17:90a:e7c5:b0:38e:895f:25fc with SMTP id 98e67ed59e1d1-38ec6a9b239mr3870068a91.38.1784832412757; Thu, 23 Jul 2026 11:46:52 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:52 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Selvin Xavier , Jason Gunthorpe , Leon Romanovsky Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: [PATCH 21/36] RDMA/ocrdma: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:23 +0900 Message-ID: <20260723184538.3888637-22-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniba= nd/hw/ocrdma/ocrdma_verbs.c index cfe3d19b73b3..017b3660173e 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c @@ -1749,11 +1749,8 @@ static int ocrdma_copy_srq_uresp(struct ocrdma_dev *= dev, struct ocrdma_srq *srq, status =3D ib_respond_udata(udata, uresp); if (status) return status; - status =3D ocrdma_add_mmap(srq->pd->uctx, uresp.rq_page_addr[0], - uresp.rq_page_size); - if (status) - return status; - return status; + return ocrdma_add_mmap(srq->pd->uctx, uresp.rq_page_addr[0], + uresp.rq_page_size); } =20 int ocrdma_create_srq(struct ib_srq *ibsrq, struct ib_srq_init_attr *init_= attr, --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10CED4D2ED5 for ; Thu, 23 Jul 2026 18:47:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832424; cv=none; b=KVsRTfm66KMAPLqG5ct6kxFD4MuHBoOgBT7qCsxqS1GTyIcZuDx4syAXSAe18cbjF45W5oDzRrN+YjF9E83uPiH988Pz2KJuey/o/nhgSO8QkLV5FsEYe9xjrlMfvGrkogzenjjNMqBV5I3V837jVVzm1m851al0wQnB5WG7nuI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832424; c=relaxed/simple; bh=d0EWrVZ42EPe2bhaOHHufbmj44DuHjUEdUtjBw/ex20=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aT03vTxeEvYg16MHBCF2zHTyU1miWItOkDwK1ubDYxwVUE3FxAPSZ++2PTXgq4RfEc1pu4d7sOV6oio+DimAikzua4ypcQENChXs+Pu/bWt+bLtUEIc3pElsGn8nzcHIyygOtreOKy113jny/PSfxm5mRC2AeDWC0yeE5r7x+LM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LeV/R+zV; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LeV/R+zV" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38dfe7eb825so820199a91.0 for ; Thu, 23 Jul 2026 11:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832416; x=1785437216; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Pa9RhyBV4RDq7tkQpwKRVUOOI8N+P6srYqSVADpe3nI=; b=LeV/R+zV/Qq6oWzzZqslYq4xBY9AOSEsjRVc5DucFqVnQ1m6J/xob2OdY69MCjOQcX grCrFfHzQYBTQdZWkW5t2j3QgFd+axn0rvTv2sYfQQpsiIgz2bRWUxrdwCdomPOg7WsV LLv4ZKm/dYHRkMjGaof1OywC2zvuoMQjgAX2xATzA3Vi/sbytm/ekeU2eVqFPjDxwU6E x28QvIPt25U1D1LcelvFqFrXkhIMvm/ztniRkMU5QSOLOro+sqpbl0jBit5YWALRgkoX UpsCJp7NLQWNHbQKTZSCO2LXEdO6aTT+Oenm3b/Pdiv9jby0+hm6SMiREbjXeEwdjh3v DtKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832416; x=1785437216; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Pa9RhyBV4RDq7tkQpwKRVUOOI8N+P6srYqSVADpe3nI=; b=as4J9c0nFxoh6orPsOasVa8Y6HHNhiwEr3j8rXDD3h+q6jx+AfX/LOD+EdQFc9pZce grG2ejEBGv4WY68FyE5WOay+CmH2/5iU6QQ7AAh2Yg2pfrueJq1i5+Ya5ta9UTnchLmc EqHjtMY0MojCoT/J2aC2dOXukKEtpQKUglDPOylgdkbXRQVQ0wYU7DNbNWkGcJk1cTcf AOMW3X/Gr0o0AdS3X1olZkmr3bb2nM0wzUnVhqxQ/XOE+Zd2nQdd8QPKaPpV5ImX6+Xg AT5UkRPi0tjZ6beQsyUNzIF+JbMAhwtyU7WCql+1rf9hFxRFNnLUv2pW2DisxaWj6INF 2tjA== X-Forwarded-Encrypted: i=1; AHgh+RoPJbo63lP95fXbYn8OLNhXPOVxVAK1RwrKzKGuik8nOx3aD+Dt0MMBeZoW6sDYjbGs1ylAVcfl0dTZxlg=@vger.kernel.org X-Gm-Message-State: AOJu0YyL70awK0/JXGOm/V/rvreSzOrrq2rer+gm6PC5VZU6GHFkkfnj 4b9K1QvzGyvj0jc21nfKSp2FY+3LKa6VSCrB9//BSXWk6LSXnKONjk73 X-Gm-Gg: AR+sD10RGmeFM682eeckxfZIKxqA8Wv3RPrcejdf8n9szeW0L2/+CJkXbWh0AEEE9DA jxCP4naknAWiDlAu0OGZS5v8SnAx9BqE5BorrvoZpAd6JtaWwA/Pj3uOFCg4M1fNftI1FEw8RPz 0r4FSAAGldL74LpJPic06+6+8udTpjZVnDxlhBIoQW3RUIf4jaf645f4SxWEUspiuiuI8FB5ZXP FnGd7OEpfjQa9J/njJ0OY6bC/2pQ4ggxd6Nhdn6vFyjK7Q3cIjmPDvf0IKgnNen8gUgsk3QWAa4 jf5ORadkQaaqg+E2atjCQPi2amcpK/SP1BZT9zqhE0JODinXC21xOSyKQXkx2DBf6cFRz6pxNrn Vhy4OA3KwpclvrVnItlclJRvwdBsT84wvau35/kiUbTDZ3nY5RF7r2vghcD7W1+iNfSiQ/xOC X-Received: by 2002:a17:90b:2b47:b0:383:f52b:d616 with SMTP id 98e67ed59e1d1-38ec6454e6dmr4309241a91.10.1784832415649; Thu, 23 Jul 2026 11:46:55 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:55 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Niklas Schnelle , Matthew Rosato , "Joerg Roedel (AMD)" , Will Deacon Cc: cocci@inria.fr, Gerald Schaefer , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Robin Murphy Subject: [PATCH 22/36] iommu/s390: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:24 +0900 Message-ID: <20260723184538.3888637-23-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/iommu/s390-iommu.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/iommu/s390-iommu.c b/drivers/iommu/s390-iommu.c index f148f559ac56..d008b1d14a9e 100644 --- a/drivers/iommu/s390-iommu.c +++ b/drivers/iommu/s390-iommu.c @@ -1115,8 +1115,6 @@ __setup("s390_iommu_aperture=3D", s390_iommu_aperture= _setup); =20 static int __init s390_iommu_init(void) { - int rc; - iommu_dma_forcedac =3D true; s390_iommu_aperture =3D (u64)virt_to_phys(high_memory); if (!s390_iommu_aperture_factor) @@ -1124,11 +1122,7 @@ static int __init s390_iommu_init(void) else s390_iommu_aperture *=3D s390_iommu_aperture_factor; =20 - rc =3D dma_alloc_cpu_table_caches(); - if (rc) - return rc; - - return rc; + return dma_alloc_cpu_table_caches(); } subsys_initcall(s390_iommu_init); =20 --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10BDC4D2ED0 for ; Thu, 23 Jul 2026 18:47:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832427; cv=none; b=Is1LLGMKO1Jrd+pNmwfN1YrCJD/r2lWKdGJf/QoUQm9iv1vUNl1pE3hgr0JDeqlubqCHiYiqkYaq9xGrT+SJZghQSYVtoQnKjSc7Eg7SWB/FLQOW+0flcIOyFR21zngSqiMPe0nX+3RohDG5mzIuGXdAC62H94zzitSYQ5jsfy0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832427; c=relaxed/simple; bh=WVruzY/Eibfw1kvwy8CJSFL+wCY9qOBSRkZxC3F+RJE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t43k5uGomRKEn2L4dq7xugCsjREDd/DAp57NwicvqnUfsexHobRQEtWdu17wolmuZTsJf2GbIM8Xta6m0zav52getPcrJ7PRYuc0AkYuLSt9SQ3A2NPMrgBX49poKIp5oUMQGs87rLb9afVUbOKgmFnL50zamuH71cpJBSW8o1Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jyQuyCOg; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jyQuyCOg" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-38e7109321dso720673a91.3 for ; Thu, 23 Jul 2026 11:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832417; x=1785437217; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AjI3AsRUClNng1k/UijCjBlEPjB/wot6PGQU56kuWcU=; b=jyQuyCOgszB8+EJljZM+9i5HTDeZiJaAiQeCfZ9FhmbmrbDxL12OIcv3ndGG8YShyP r0ZtNixp1mnoCzmJTQD3nlonpcXL6bOkWg7rDXRCF65MoceRhHnGWtasWVy1dwtVvhDI gWrW+xswEaHudZ+DPDlBfTxvrAnu5AJHs/epnVetSUpFm0fOaUs/CUaKGLpxv4Lxowgg 9bexmsE2++DsOCje8EdjWu5iIdgVKtfdhv6jkRYywKwPxz8fST7QYaOBNQzkVYW4e3YY NCSXdBUGBvUiHw3bx3vm2sHcBENsjiaDV7Zuxw6OQHyGwMDI/ZxSuUNAbpJoXhfLM387 x6RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832417; x=1785437217; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=AjI3AsRUClNng1k/UijCjBlEPjB/wot6PGQU56kuWcU=; b=Zw/eVfUMlTVoaVZzEl97F8k0cUm/1GyVyAxGmfIkZV/5GgNUldMyO1/5kK9WZD47/Z h/Ij1Ew1Tp0zvkH+qhvsNCSyahiRXc2JjmERLx7BH3v4w6LzOnZ1gb6SzGFznx+NCH7W JFQZHoSghW7fYbP+2HtamFOPzg8sXRw1o6/WRpfN+40Zjr91o/n/HarVyFN9tFneO3Do Jl22oP/JHvPnKNy8Dddx6zx6Le1+gIVg4CJM9g1V/4yu/bbks3aZryZMe5JNaE47rOH1 QBib9ghTmhzgQNA5prJToITXHUwVBsR3zog151Blz6W/N87Q29T1jWua5UTVK52zAqXO G3Fw== X-Forwarded-Encrypted: i=1; AHgh+RqzVOLVO0wSruWwSm5ox6y8aRxqZmn8b9OiYuaAvcGEpk1aXD06Wi3irnaSkPjNc5EuFOXXEH5y1KKaxsE=@vger.kernel.org X-Gm-Message-State: AOJu0YzOa45gsTNG8l6KAY0VYFdD8BdeNxYNJ6tKt0EJ9k/9Or8zQL7a xGKTfpjJoWVJ5IjefusQPxCIVcaTEuWc3OmXu3plaNGb28GaPQCdRSuH X-Gm-Gg: AR+sD11FYBpZW/Pa1Wy1B+L/DcdlNx8mmY8i0g3km4FYBYfuKpDBtIy+J3tSUXj+dhs 1Lw5eTMon4/2yK7vKR7a58V8smspxusS0aC05OSzWRUGTHqNbjSJtcZ9rYxx0ZjiaBIWsy6XRjN vEb8nVqUwCEPlvoMH1AAoap1f+mE2vX9I8KTQRRdCdw1DjwfrbaoJJJk+HxbjS+AluISIM58Xki VytDvFNVsOd9+Zf2h023H/FXa7D8Qy8ZZmZeuba4nj5VWNhXV808iGapgqy2f9hNgaYrW/CJY0h 2VEItuzEzIgQC0+VbWMhBjWNv4Uyp9WpjXmb5M0loDcUfki+jGchYfPCyVaiIM0CJstSCnD+C9r 65MYcc/M88OAa1VAWR+9EXrXCYYyrJvo3SsleCfVhQOqYUwOEa3G/+lCSEOgp7Y35rc6YP6FE X-Received: by 2002:a17:90b:1d4f:b0:381:1f51:1ff0 with SMTP id 98e67ed59e1d1-38ec648e273mr4470428a91.2.1784832417345; Thu, 23 Jul 2026 11:46:57 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:56 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Matthew Sakai Cc: cocci@inria.fr, dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 23/36] dm vdo: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:25 +0900 Message-ID: <20260723184538.3888637-24-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/md/dm-vdo/encodings.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/md/dm-vdo/encodings.c b/drivers/md/dm-vdo/encodings.c index d75e023df637..b09373b0cfe8 100644 --- a/drivers/md/dm-vdo/encodings.c +++ b/drivers/md/dm-vdo/encodings.c @@ -1333,12 +1333,8 @@ int vdo_validate_config(const struct vdo_config *con= fig, if (result !=3D VDO_SUCCESS) return result; =20 - result =3D VDO_ASSERT(is_power_of_2(config->recovery_journal_size), - "recovery journal size must be a power of two"); - if (result !=3D VDO_SUCCESS) - return result; - - return result; + return VDO_ASSERT(is_power_of_2(config->recovery_journal_size), + "recovery journal size must be a power of two"); } =20 /** --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2DCB483BCD for ; Thu, 23 Jul 2026 18:47:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832426; cv=none; b=VXmwwik/yCRM7S6NHDD6wshrh+UOOUZqJpr157vdJuwITRCuT2CGi+a0C28fChtYYDZ6wI6eO3AdNeP/4Wcl2TZY90+9fNe4oxmTcTG2OCE5REUZTVSEoxCqQlg3KT1dz2rEL6i3ow25JioPtgMJ78Bh+stlZChAKhh1JHad6+I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832426; c=relaxed/simple; bh=NmlRNc2Hv7I15iZ5R7bh4z3eyVqCDkhiotE+Q1mYe8E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ISAPD6xmJxyeHFk5FcEPR+3GkSoeefEP+n6EfnIwpjRvdb3GcMHYgZkn6n4kXKhYak2K0Gk6WJVfyXvq02dJCSImjTcQ37xgi+fro/aTXL8/qHKOmOVbJT19iA26MFjTiS+LTWHHCU040kWYu/9Ia6eFR3oSd4cEOagM+60cAsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C0om41LZ; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C0om41LZ" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38125cebfdaso1333267a91.1 for ; Thu, 23 Jul 2026 11:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832420; x=1785437220; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BNEry2bLNg81OguQ9I1ru3wEUBWoj/YG1funVUmQkdk=; b=C0om41LZTGOUFcPARp0QOJajKF7NWFnQ/6v5amT65HU6GZxIgDOIwGYZB9c9pKThEk Qz/OFisxMaH1xY6LTUAQVAXAbayd7KXxlCsbM8MsWujOpvSxOb3pm5a91bHubMZ20xsn 2/XUwTqNRFZTYGL8yKoRGePhXca+7l2vvM6qd+7K1hp5H0yfKdPXfk995RBD0/YDAY53 MDPpzHZt0X3IdHjrgoKQ2azZRVgdPGO4JzEYADBJEOhvIV/mEXGw5ksXU4i4T88fuoji 8ei0NKRPi5nTxQa7KmQ454jttRr+y/BGuiu7SDdxin7YXLTh2t+wGupaPt2umuZDqUsq CCLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832420; x=1785437220; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BNEry2bLNg81OguQ9I1ru3wEUBWoj/YG1funVUmQkdk=; b=beipmtxFHQHciefx9v3U02xpHCw4ZvOGDKWRsZSq+HT0a6PjSyKxAtl4TKAtpkmNs8 nmJDMx4R7ykfBtC1yr2lQdUlTSq3yBhmbgvmyzxRm+Aa6GpsbpaZEWR9fNkp0sX3x7/v frBkTkatyNvtcQc/PmH/074iekdi4+PduGIdDlX77ANgnLA8TWVQ/HXejy67vSU7n4Fx 9sM2p/DwH6U997B8xUD/oheA38fU8UiN+TzJTd8wckqg9XEpnfwJUQSMFxYTR75W0Chx DhOUkxN8gcYNboSoc1Zc9Ve2DVdQBC3PIftl7e/CdGxN2IbcVDcmfVcSVkioNMpCxYgp 7dSQ== X-Forwarded-Encrypted: i=1; AHgh+Rr6hqEY3i1caojffrZUtsQUm4MyCzC363ZOhZrapYLUtP3KHx4gQ11VxETSDMdqTD9xERKjFQBokahL1Vs=@vger.kernel.org X-Gm-Message-State: AOJu0YxbTczl3WIxThSjy50z5PBeejxaKowKoY59rrevnAlkdfXO64DU XCeZV63neo99g2PDM4FrPd5U2MTTg7kQsikfaDnSFg5TGkghjOpge9FL X-Gm-Gg: AR+sD126kRBHxt+vzTqh5TG6Wghckxd07yUQqlt6hxwWcwsZoLrAQHanH0Sog3TJKfj sKlOj5aZdZwW4aodUk5vo78OKGG5ftQ2MzHUOmZmIuff6ol7bDeFp1NzvJa8QwBF1u54FeaILj4 2c0Z8VRM1L8nXMga8XB/sPJC1POMTaX90LhVuPG/Easm7Zeyjy7n17aOjTRC/kALqu0Qmpq0+Cx orsiDQcxTDzcYalisyFUXix0hL+NTuYNqTJuVaZBf40qNjIEA4Hv6yMasiP4c6Yp8NYebEwg3f7 8m+4+BSFuI87v4X2/cNJ6sTGpnen8XJZaFleaCbb6p+ktNI42IAIKl/T7a5zOq8/Pb48vZGtaTH CpxYpyoyi19uKDdoNtvVag2FY8/0LWBheYw1zRNNbCgcgbi3fppMQFC/qsH+WxdVfIz0ZrXxX X-Received: by 2002:a17:90b:53c4:b0:38d:ef48:b04 with SMTP id 98e67ed59e1d1-38ec657558amr4646237a91.10.1784832420077; Thu, 23 Jul 2026 11:47:00 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.46.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:46:59 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno Cc: cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH 24/36] pinctrl: mediatek: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:26 +0900 Message-ID: <20260723184538.3888637-25-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pin= ctrl/mediatek/pinctrl-mtk-common-v2.c index 4918d38abfc2..a8ab982d8f21 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c @@ -1242,11 +1242,7 @@ int mtk_pinconf_adv_drive_set(struct mtk_pinctrl *hw, if (err) return err; =20 - err =3D mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DRV_E1, e1); - if (err) - return err; - - return err; + return mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DRV_E1, e1); } EXPORT_SYMBOL_GPL(mtk_pinconf_adv_drive_set); =20 --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73FC7483BE2 for ; Thu, 23 Jul 2026 18:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832433; cv=none; b=oq/vdTrMeNkSXmI/I6+hj1nXvohOo6IsA9bbcOGgQxNMmHjWXzjt5UGDyLmmf2o7C5+zy8MOqVMjT34+fgFxGwtEooN/tBGfKGNQfM9CtDm7iJrr1A+RwSOUpOJGbTDAQIlOoM2GHFynkp8ET6VihFtE7KvazH0J/GiKu4SZwhc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832433; c=relaxed/simple; bh=fqeRCaJ05QJbdHKiFDfxqyKSnyoUuDOaEx4VGjGig0w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GEzShkZWvWyIBCleX1JNfjZPCZCBa8LrWp3WdjXoc68AFqAUBrrJ1qxGr0QuqxtaoYJopnim8ZIALfsyz7I7FF/vZ6LN2YqB7YsbBm0uYl0mylznVeH+Ke3JjyX/CFwiPFxDu5rAwD6wBnbcLQ107W3fvwvqzFEw8DNs1SBa86w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pGbpTHPC; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pGbpTHPC" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-384930ca5e2so1050785a91.3 for ; Thu, 23 Jul 2026 11:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832422; x=1785437222; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=O0IXVWZk1Ru5X2yu0BgI0Dx4RhQRg+VvgM7kUVgisNw=; b=pGbpTHPC6buNyKLICHhTVHnS/5hfh7akl2eR+RjWQZTovLjNPLengDWiWeajubNxnK N6oJx2+lwbVNMf/QWFV9+4z5tCX8tUeMSH/fbYZIF6GofwtfwhQjGg2IHXYINYl/cCFY aL3JcFIb1HXzN5MqTW4Fp7baqpEEEvF0FifIU3qxfMoeFanKtzrQk7ZQijwc6T70IsvZ 1cCZLMKC+NdlGu7wHD3EE7WNCmul8VB1NhW0cGI/aEuiBFyCeFwje6qhx4mvnzOfFqLX 6p/rnC1ZYQ2sjXTutmD370Vtk9vBn5WqUDtXadmmT9LXsprd/IBx59B+QBKehpmrAFwY rp/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832422; x=1785437222; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=O0IXVWZk1Ru5X2yu0BgI0Dx4RhQRg+VvgM7kUVgisNw=; b=Rvjc47PqeKaW6OhCGwb05lbxmkY3O3TGpwu6F18ucIvuKUaru9f65NMLaI0Hh/ngC8 w4qU1WH/AwuK0O6/xyCc+WPwJlAvxZ/rEyQqybPzxA/lq+FkMwA8WM5N9LooJFZwQsOm Kgihti5O24CUdoZREBVtKIc4DJi77/n6IGSwzU/yUPyOVv7cH+92ij+KooAN4imSEDeP NKFKoO2Z0viJE90MTJph0YMSvth/AI8aBRxFuuZ3F3RrA3YoPTlnqEuW2sWzs5rfpm1w pDsB0h0SDAleOdO7n7vTwRRtSCjzOtpUNYuMzFk0QEJq8hDtxIvMnV4nS7j+i9HS0R7L QBQA== X-Forwarded-Encrypted: i=1; AHgh+RqwqGhgLf8Al6d4Z7b628gs7GzYiOTE1AkJh5C2f6Paq0q/fKPkgoCoODJ+YUdZUQDNnSGQ7Zm9vrLXQCc=@vger.kernel.org X-Gm-Message-State: AOJu0YxjQALcqTmHDSYsc09+xWGL2skU/b8Azxur/JXIrEBbFv0DgMrw WwFvobbUkU9x3auK+DEQKiCwAK5kviT47JdeiedDae7cVNeZWunPXJCU X-Gm-Gg: AR+sD11xQamew1EA56OS6Erj6d5OwAszlnB18FwJIbWtkHqxI1Xj5ySU8EE82vaBOL0 IlYXBHLngPgQtQe6RBIkSkno7WEK1WJfVrBR2urwq9a9QfNmCnq84v8CDCmrYEEwE82IgZUNe6b fxg0AnX5wkAwOC+FGQSFHs6lId4l6XxNAHU+OhllRMmppNJWiEXQk08nlQHuDwSacIoKImiYCZH 6LQalSbJR5/CWSA45bg39gWYT9biSAtVduYO0bYvS5FOYumNY3YCgCIZRJ23vsiW0rJRYMI/FOV 1ZOcmyJpjasm+kTKk8Llg4o+MLrfxCzvW5Va88V+TSDURkW465WnYB/PVy7iitBRlaijoHs2wYz /5IW1/A+zPib6K6RrzsZtSlW4P7ziimF3eizp2w4ieDaiHGjLaPqHkXFdsDAl359CN6V69jF8 X-Received: by 2002:a17:90b:1350:b0:37f:c69d:ce69 with SMTP id 98e67ed59e1d1-38ec64a7b7emr4626593a91.10.1784832422117; Thu, 23 Jul 2026 11:47:02 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:01 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Azael Avalos , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH 25/36] platform/x86: toshiba_haps: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:27 +0900 Message-ID: <20260723184538.3888637-26-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/platform/x86/toshiba_haps.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/platform/x86/toshiba_haps.c b/drivers/platform/x86/tos= hiba_haps.c index c6633b74029f..4f62476b8dd1 100644 --- a/drivers/platform/x86/toshiba_haps.c +++ b/drivers/platform/x86/toshiba_haps.c @@ -251,11 +251,7 @@ static int toshiba_haps_resume(struct device *device) haps->protection_level); =20 /* Reset the protection on resume */ - ret =3D toshiba_haps_reset_protection(haps->acpi_dev->handle); - if (ret !=3D 0) - return ret; - - return ret; + return toshiba_haps_reset_protection(haps->acpi_dev->handle); } #endif =20 --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97DE53ACA5A for ; Thu, 23 Jul 2026 18:47:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832440; cv=none; b=r66wDHU4JiNkPO4BnoCdd7QdVRjVsuUepW41ObyyF2Ga8GFPX5cd14C30H9i1QkWNtrfRzORkaGEoHW8Wqm7UDDNysAkX9rrezzBwxouRzanjO6py8gd3OUAi8zrjx92yzlj2i26R1BJp5bC/1+XCocYjV6SHN6QXmN8oAITyJo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832440; c=relaxed/simple; bh=P5lvSNDbtf2etm9/JqPrRb1MwvkxiJTjegfr4c/TBtE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qygNAfzIKWwZN+Ox15Oa3DFqcNWx7YFgPv2xMY4Zz/rZtAueqJ9u8uiYJaso4FYa8RrGvsRs9MR/guLU1HtVCPfvxptROT3zKU7VJb39eq3sjdvrVhkBSCv6Mlr6bonDSZupViIRmMg6vb2J2oB5D9guYmyTepxhcuh+Wyh0om8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JEh+NUY6; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JEh+NUY6" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38511175ad3so736616a91.2 for ; Thu, 23 Jul 2026 11:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832424; x=1785437224; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=E1YwuB1DfTsRKNQyJAGjUXFVGQNAiKL6OzT+JgKENuM=; b=JEh+NUY6oJ56eZCZRyV07+8tCUduhpmG/dSaXVsLm3dWCp4fFrRDH1SnzZLDVFKk/U YWYIUnJiQWJYQPYBcsZTl8FGzV20a7QHeGRmCN0OBXRGknIsrwuGtVUSg02+I1ELJVyg pJIx+A532R1y7nOI+/EU0jDnnzi7/kEUdvuCaTrSBGvll1j8dfDmkf+mx3xol1qTieQ3 ieXFVyZ0moWcZq1n7top+rXKQ5x3+EwL1GBTcn73IiErh71op2Qe/nqa3T2SqX1kbR9v YH0A4uXVXOWIPRz2GFRnrGFxjMkrk2Ks98RGsE7ltvoZw5OEURCHh0jzZQwxeQVhd+8v 8s3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832424; x=1785437224; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=E1YwuB1DfTsRKNQyJAGjUXFVGQNAiKL6OzT+JgKENuM=; b=R/vR5SQzMhtFnVAYZQ4Ta1/5nl8QpmSu/64kfib9DxgP36VDd1qUHCbRLFFU6T/Vpp 9FWLygQYxV9Vt186HmlvAoycB4WwhOINzL8rvp2enwfzi3ENt2WylQKa/q2n0hvQc5Iq eTaP/5F6SZejGqKpZWJn8t3tFzPlHiAGQ2juPTC1IuUXcUcTa3zGT37jIM5TVUIpD5Kb GVjbIDleEMNiH4BKx2NhR24UWKqGazbhr8E241QZVPUirrncBtr5EVApEyWPwY3DagxK XJeVGqQd/60weaKaLa7yu5ALV/aww+HduB/DuNNb1ntCtochr3E90905LgbIxFiPSkQe YcCQ== X-Forwarded-Encrypted: i=1; AHgh+Rqn2mEZAPdEU+yHGAKqUVzRg+axDekJcuKEKaZhXoi9gAoMNbBELbANFktZxEchfTqafoK92L6nLpn5Wls=@vger.kernel.org X-Gm-Message-State: AOJu0Yz99y+ZlZOJWmfH+WlYuKwspQVd3KXVIPYFm0o672gMCuLKGNWA Y1QMfMZir3xSiNpHsXc1Rx+tAvYXl0vC+18hPEBf3JuCWjKTTf3BZafQ X-Gm-Gg: AR+sD10hw1PO7GxzTXnK37Y39QYF8WooLZqWpuXuULclfmHYNOn9i0VamUIQqiMq5AI 7OOfD6s5NYOiGUd5hVEhU4nk0XjSUNCK8V9GYSYywgSPRjyYt7qDX/mv8hpyUElGg4KPzI6DNQp X2PXD3Cruuezryx5Pxf38kZ78KYYvAThDId0UyiyPI0F0w98pZ1/3x4VWd7GmOqosNRcnFsixWy ypI/u/b6PraYGIBe5mig/rBXmbSL26DxVhcP51D+fDKdEVE3ItkfQPOVsWHZEvi6MF9CTeLm/Kr ET90+d9XAD8fEPfHEECgfvH1RjW7RPtwQ2GtZI9PBoXNZZGvZyp5ze2yruTnNm1ZaQwteCfHdK0 74sGIe1jUenIECBse1qbQmwRey7TXxnQGprHoPATXgkyeUsLSO7GaBS0Exv67/uRF/OwREXN8up yWJA792KY= X-Received: by 2002:a17:90b:580e:b0:381:152b:d596 with SMTP id 98e67ed59e1d1-38ec64dd084mr4855965a91.11.1784832423882; Thu, 23 Jul 2026 11:47:03 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:03 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Sebastian Reichel Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH 26/36] power: supply: pm8916_lbc: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:28 +0900 Message-ID: <20260723184538.3888637-27-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/power/supply/pm8916_lbc.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/power/supply/pm8916_lbc.c b/drivers/power/supply/pm891= 6_lbc.c index cdc4d78c4219..569f3f4b16fe 100644 --- a/drivers/power/supply/pm8916_lbc.c +++ b/drivers/power/supply/pm8916_lbc.c @@ -231,11 +231,9 @@ static int pm8916_lbc_charger_probe_dt(struct pm8916_l= bc_charger *chg) return ret; =20 /* Disable charger timeout. */ - ret =3D regmap_write(chg->regmap, chg->reg[LBC_CHGR] + PM8916_LBC_CHGR_TC= HG_MAX_EN, 0x00); - if (ret) - return ret; - - return ret; + return regmap_write(chg->regmap, + chg->reg[LBC_CHGR] + PM8916_LBC_CHGR_TCHG_MAX_EN, + 0x00); } =20 static const struct power_supply_desc pm8916_lbc_charger_psy_desc =3D { --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66B3C488751 for ; Thu, 23 Jul 2026 18:47:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832437; cv=none; b=Kq+FiFZPQCVGxTpZGVWT6FwYWrJhZUc1tCOvzeqJ6gkw7OfOw5FrSrFd8fUtO9+zap29FBHVP6GX6r+j8Te2JAGw3fhiFyNm5ZDLOR7ZW+9fzMbn59V6zSi3xdKF4Lw4QXtQJ4Np4+5EBcQQyRQMN/QPwsZjWYGrq3tMFy42Xsk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832437; c=relaxed/simple; bh=sSmtUuUJ70y44iGSZGE2SXfyBODS1MzhYzpUmvVlbgs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ACXiwvi7Id1m82r5y7nJzuCFXoRzfq+vZmJrTpc6plMIjVgYVKCwI/0rurIsOBAjYQlApKbO+1WkzkHM67T6hweEpifcXY8TsizU2C+SEcNp5n5HQd2M5ZS9UBQRB8/QTxMkXGQRmxrsKSEPKX1xCHqkHNYQOLM2Pw1qD9e9A/I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lNrdHJcH; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lNrdHJcH" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-38e08baf860so1122196a91.2 for ; Thu, 23 Jul 2026 11:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832426; x=1785437226; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ULIJ1Xv9cw+GY9oh3jjJe8v9mZ8WuSVlbfwPasElOsE=; b=lNrdHJcHyRpAkAO0rKsBZyBVjoqW09EPwyNzDp25CzD3hs8g+dgYUnqgE/bWuzQCse gtRuD2Fnas5os73bsGO14WZxjnu4KfvIeP4Zuow/GldKftTQnvR1K2n9pHI+1+uYAmVa 9+4BdhSF2xyBwzQQfsC//o+XMjpDaCw8D+ZvkILYVyIaYK2BZYsYhew1IZAV7As7OO3M lIGK0wGeEx8Jaf8mvRfE0yMKaxBkOU1KVc72R7oSXvMx3DEpmmEUj+Aq8930RQSnOupe 9SwzPu6sfq9LmjgRl3o3Ecn6FeS9XhBgqIWoA4mztDCJJAmYCwn7rQU4WVKGcF5xzhIy YNeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832426; x=1785437226; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ULIJ1Xv9cw+GY9oh3jjJe8v9mZ8WuSVlbfwPasElOsE=; b=P69dhxp02XWp/iWtNwXdwyulIU6xJhT/+mVBOPl4ET8LfV3mblPlw6+itzxtc/6418 f3DF42vqyG+nY0u3nVbVjwRXOkxQ7aEJDnzgtOih6OqhxZHC+6Q9ljwcr8G/XLmMpRFY sp9GTQ8HHdY9X+0a9V9LV/ZLmOdcStsT6fvRx4d957M9J+TM11o/YdhAFjcJC2fMbgPt xBXfg8junE2s9NNGMQQDylHd8dq1PG+go1SSE2fiFMrrvvl0N+MY//mrK6djDGjVQs6d gEWnD9HVXgGH0EsNCiq+jpjh1aJWe1npISTPUWaM7dRPw+7/EhTlw/0mZhElpZfehxQP xFeg== X-Forwarded-Encrypted: i=1; AHgh+RpgErl7UdQmuAKDSy/oVik3DSQMVhUynKL3s9S0tXgzKSOvL7UJPlRQFB9TL+YNkMBcqxKZqgY0MWrAsoQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwYvV2SnJ86lx3hBGMHyN7NkoKSoyCCKfOOmQpH6ROmj2bKJ03v F81wyH2wOjxB3e67g6SBrwnNynVFZgHv9gnxXVBCmCzQFKdu1WU8OHbY X-Gm-Gg: AR+sD10NeN6koeZRSyHx3kRdqqqHqBKsRDZBX0id+5srguzCEzRy5qbMnyln44zg9rV mjYnIESowIX6zdUlSL6NkWopK8afwuKzO9UOfIuSM9GEygZet75DmFzN2K5VhofErjh33FygD6S AFWUrYIqLdEgvAODxARbNWC5tNisXERQKrt2JwEli82uVh3J1IGsi943wxaV9mA9Z+0zc0rp3m5 THaV+Eak1uaJhiW2ywqJSiQxYViQ4TxJIbmdY9EPKs9Ns5ZXQqzrpRWfMdee0fMbDmPhMuyeVwl BFgsCtIpx0eCqa2nsvMBObfcalV4xrj+4b6nDNkY+/sN1nY3S5tRk1mPbPEwKZTewRuyQz8blMN wAHF903/ZyMErcue3b+xOxCgPOmwoaydZGW2jdov66PhdIQj23mUcWCqbWsH8YfzjU9dBToojDU +w8nVfU7U= X-Received: by 2002:a17:90b:518c:b0:38e:b3fd:d582 with SMTP id 98e67ed59e1d1-38ec6657a87mr4132955a91.39.1784832425783; Thu, 23 Jul 2026 11:47:05 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:05 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Yazen Ghannam , Tony Luck , Borislav Petkov Cc: cocci@inria.fr, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 27/36] RAS/AMD/ATL: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:29 +0900 Message-ID: <20260723184538.3888637-28-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/ras/amd/atl/map.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/ras/amd/atl/map.c b/drivers/ras/amd/atl/map.c index 24a05af747d5..4ec9333ef745 100644 --- a/drivers/ras/amd/atl/map.c +++ b/drivers/ras/amd/atl/map.c @@ -771,9 +771,5 @@ int get_address_map(struct addr_ctx *ctx) =20 dump_address_map(&ctx->map); =20 - ret =3D validate_address_map(ctx); - if (ret) - return ret; - - return ret; + return validate_address_map(ctx); } --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56D3F4D2EFC for ; Thu, 23 Jul 2026 18:47:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832441; cv=none; b=ppOJcJvXbrlSWMEcQQyz8JR+543a4gtuqSsp/0dONVRcP1ofo9abTt48KOUZunrnl1epZoxE2+clo1FBdgngDDsQtkAr2QOz33ioMrfleorOe2WCdC0dzUF5UHRzt/eU4KIQ1TpWcBJQWdCbEUUJxXj48Fd8+ApWKJV+0YjgXXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832441; c=relaxed/simple; bh=GO3HXrwvfG6IudXoKBCuvVESTCczNdLq2mlP9R/wk2Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g0WrisiBbe77QiSPN6CN7lmAJSpffC6zm/BTOjysB4nRH/hEFBB5qA0ZyVeDMTAE5NP4nxYal41aHg8rJcDsIBEHbdAp9hDliR46a4sY4dCGagbvErSzeN8ZV9abZgirOTdxtS3dSJOTcjzuKepDOduv2UU8Iqr2I3AARck3Cp4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZQNlvzY0; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZQNlvzY0" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38e69bdb0fcso809466a91.1 for ; Thu, 23 Jul 2026 11:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832428; x=1785437228; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uC6QoEcftILT8FAj1uSkH8G4vFtlGaDcPImQjtMJshQ=; b=ZQNlvzY0Pi0GmYE2mPvsdGQyU8iS7GEPhKiOQfdBg+Hx6EpODl/OhqFxjIwpxMX7Pr 0J/HDm5perc2W+l/T7D8sFYEe3nPxJjUc49+Lb/BwsWuqIQpR4NxZ1MIXZ7N0BJI+ms/ AsL3YGajkac28gq/2z5dvIIbzUBDTCAISplFoe2OoXwv6zz5YFbMPwsgJRYczzgtiTGz Exw7qdt58IG7TezKKOUQIlSx6AUtKnCXzWOTpXR9V/9W9PHXz3v5VqYlrDx+o6GnqldQ p3gwcciJY+XIbWaUv65MAA+bT1tVDwfd/BhhT2N5eDCQ0bZLkw7RiCpsAErNVRd2iF+Z M+Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832428; x=1785437228; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=uC6QoEcftILT8FAj1uSkH8G4vFtlGaDcPImQjtMJshQ=; b=rNhJ8C699IaEbuK+H0GS/aZZLDINc9MF4wWIeSioSYKKNQS8f1i8bsN/TgFMcWQpwj y9SaQahLo5KvYzQ4fMcX8qqL8ZeMZ+bg9Vifb6ePOCAZBqiiwNM2YGGMyyXBzo0Up/fd rkiAx8FjNJcAG9hHNp6BthlVXnl5nbQQJ7cdbanX0407/ILEpCLwi9HJhdB6eEQjI9D+ LOKlJjet2u6XH5I9X0LclmvCSuXj1RS6WEP4XypVpwlvxorIMkhUzOu2+1tsQodp63CU WlSnU9ADs0u7WsnM4ZOxPYi+ej8/OK2w9y7oJLEUaPCVzhbM5Z9qa2uWe+OkOQRhY0Zs Ax/w== X-Forwarded-Encrypted: i=1; AHgh+Rqcj4tJdATEkhgb3SIC9eoOvdjqwkbFTz9agShf4T/gZfpkORW117AlFEJI1idFZxRTyni8QudqQ1uUOr4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3eK8C30ntsOeo5QJkn4fWfWSash1kKn3P8k5B/+nF6//bjUJI ZVhhcJv9YqwktiivOvFgZPxHW02AsG0Prd8okS44aQqGb31gpE7BdM95SFvFXbKHluk= X-Gm-Gg: AR+sD12QEZ8AL9rNKUHtOLlsfKEFsWyykCvRm7fcxnKIFwRITxAB53SDeV4IATaHXpx kCJHQR+nFAMP9aQuG6gbxoA3RbHInKQGoHj0a+DTDBlVzQf37CHVvvC6rNAW63pkMfF5fI2YCHz AdxXPpJUsKBoosKlNeQpQS55nkMgt+5h14SsHg7XBpF9PZUyXu26Ag0wSvvtVT9kVxYDFOIFqDp VPFPYo04OviJKAJxC9NmilDZu5jaUObwBbzy4kycvuOthBT3aSe58P/CQ03WjAjuSY4IX0zPpPS 3ycflvnV0jZyZYmratJQYWUxqd/gxc8m41Y6s3iKfb9CHvjk66FCLrLL6pQyGNB3Ra3YYt5E3L0 3ZZHlbKt3icL4q6kb+72BGj899Xh6mj819FIhaZycen+lptzqBP07yVblwpTGNjzwFyw7i1i7 X-Received: by 2002:a17:90b:54c8:b0:38e:b400:a86c with SMTP id 98e67ed59e1d1-38ec698f5a0mr4314176a91.16.1784832427550; Thu, 23 Jul 2026 11:47:07 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:07 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Liam Girdwood , Mark Brown Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 28/36] regulator: wm831x-isink: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:30 +0900 Message-ID: <20260723184538.3888637-29-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/regulator/wm831x-isink.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/regulator/wm831x-isink.c b/drivers/regulator/wm831x-is= ink.c index 43f220cea21c..b46e2cde5e9d 100644 --- a/drivers/regulator/wm831x-isink.c +++ b/drivers/regulator/wm831x-isink.c @@ -62,11 +62,7 @@ static int wm831x_isink_disable(struct regulator_dev *rd= ev) if (ret < 0) return ret; =20 - ret =3D wm831x_set_bits(wm831x, isink->reg, WM831X_CS1_ENA, 0); - if (ret < 0) - return ret; - - return ret; + return wm831x_set_bits(wm831x, isink->reg, WM831X_CS1_ENA, 0); =20 } =20 --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE69C3515E4 for ; Thu, 23 Jul 2026 18:47:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832443; cv=none; b=iX2u7FfXzHVwmQ1dSDc3el9cVgS9l7S0EIj6T0JF9ARyB0XCqDflLTlIt91KRnuTib7r1mhlHUKnKrbedEb/5NGJleqVr+RG3usdLoq5OEneqlDXaG5oIrpUrbjld6VSqK4anrql47zcTW3Wvvo1rFukyEuAdUuTuzEs6AbOTVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832443; c=relaxed/simple; bh=34ZFRB+t5TBTN8y4CUuvqqvfbV1iOyh2tVj2zJDSmAs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KXuAfPvlxjON4W66+X9Pabguvamq7sNDEtFoSBVPn0UDwNxR6eZAqgCT1KA83gycxk9ruL2Bx6pKRSmuXJWlftIJHpPD8u6AYCtO1CRRa8cbAro4Wq9f6K9RXZbLZDYCztOUbdlkNIgLtLY1SsS1Os1nigfqZOLiIBez/lXYhGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TD/1Pkc1; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TD/1Pkc1" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38e3617ba36so977971a91.3 for ; Thu, 23 Jul 2026 11:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832430; x=1785437230; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SS85S9k55fKh3CHy42qY+ZLh5U3vliQxWiJO6SqlhjU=; b=TD/1Pkc1wq8iwAQ6o1mNDtpMuoZuvSkiuGwfhUneJRw1HzYJ5qGaenT5rbJhCPlkMk R/8P0GeILLaYJBuBLIkNvrunADMq40IVULA3BKz9G2K/rmUPWQzPoOAbjNYYXTlixg/4 QOw2LsB0nNGeEId9vQ/SPB9KLPBhRJp+ejGxLsb0Jpi11z4RB4xfIBiULLYoMcsGwjZo zQBzcZN/GB3uSFV0WmiUyaW3mK06FdQOm7FVDt6aMoLbQjF2OWSg8FF9aWJBMV9pIejL 2ixwjIBGwGPQX80PfBWJxl/dfv/8Bu7jzSBfrbthCE8L5rjPA2T6Lf15a3dXmbwi/n8a v/xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832430; x=1785437230; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=SS85S9k55fKh3CHy42qY+ZLh5U3vliQxWiJO6SqlhjU=; b=NT9Fo5HYRZ+jfXzEOniIQQz44Zp/RfztlHuPxGTtZFav0yE20lgnZFasjZoxYeYalY QCYLBzs03KbNRgRSGdMsPOnYt2avmH5O9fzrtS7r6+yTO+vm0FqMpRclUW8nn7uL9oTW 5se9AEg4ZTi4Ar+4B50jzVyfjwDXCki/JtxsV2n9tmDqiA0eY/Y7Z75rhCKPCmejGpAO ATYN5CmgZquTZSHPXu+lGTCGqbmSvCrsyW8pJy+65ONGrdG9nFAdFkYLCmBsgh2DkDnL 9hMNFRD/NPg8yKk7l2ws8Q/M7VOxnfloNAE3stKNkzmeKUOcuWVIooQKA1YECRaM/WN9 wL5Q== X-Forwarded-Encrypted: i=1; AHgh+RoRe6ZWXwrVLwd9OUHyek0VzWTooVskLqawQ8iXbReZmJ3xsp5dnPxci6cQYEtrcUoFkYNeI2DSEV+mGzY=@vger.kernel.org X-Gm-Message-State: AOJu0YznUU6J4d+pjDLB3NuKB01ZbsSy+QHcP29Zwmqt+EikqVDiESkK tqDGsCnsu10dJyUYsQoJSUiMxrVL3VY4ul2ilS5iJcIjjxlpSio/GqBo X-Gm-Gg: AR+sD11HnmX2tcr5lT0LAOpZH50f8e1ZCHl/ezpPIVcyHeKFZ22M2yxFrsv5C0CkkRT SNXysxYTbWuZ9FoGDzHleQS0O8IrJ8hsnejms46i+Vcy1h54r2ZhPSHCe/5Hh5DHLwF6dc/hMst Mt0jdRNlOcanlXjNt8+foOGiZ2iC8U2uvG0XqacuOoLzEIzjLVWbklwEdIuQ3UUiACUW0SwsvTP baVZoOnKcnEp/24c6lD0f0fiJzaHVLitQLOVMHvgcPwWQlVk+tU0WunTbTPWSjda+WdFsboYpyb UZqV3KdnW5k/NOgMiKDHJ7loM8lkOR3I6yOa3Bdw3CnHgE8oH9oTu1fwwlpxwGN5D6MZQPH4I6C 5x7OLGpkw4PsIW7CN4BJ4HO8yqPKXvduDu7ubNkLT4HdibXPKEyUpur5qZWzlsi/Pfql/Jydd X-Received: by 2002:a17:90b:3b4f:b0:387:e0bb:57f1 with SMTP id 98e67ed59e1d1-38ec6a7a591mr4120286a91.34.1784832429331; Thu, 23 Jul 2026 11:47:09 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:08 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Alexandre Belloni Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH 29/36] rtc: pcf2127: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:31 +0900 Message-ID: <20260723184538.3888637-30-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/rtc/rtc-pcf2127.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c index 1995e9f2756d..ff2023908f5a 100644 --- a/drivers/rtc/rtc-pcf2127.c +++ b/drivers/rtc/rtc-pcf2127.c @@ -1184,12 +1184,7 @@ static int pcf2127_configure_interrupt_pins(struct d= evice *dev) if (ret) return ret; =20 - ret =3D regmap_write(pcf2127->regmap, - PCF2131_REG_INT_A_MASK2, 0); - if (ret) - return ret; - - return ret; + return regmap_write(pcf2127->regmap, PCF2131_REG_INT_A_MASK2, 0); } =20 static int pcf2127_probe(struct device *dev, struct regmap *regmap, --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3E0848CD4B for ; Thu, 23 Jul 2026 18:47:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832439; cv=none; b=C4wlCNfwaUh/6h0kp1Ll2dweaF+nScrihzC73Knq6vxnZB2nn5o3gnfuHzM1tbBitzBFs4EQ8umnderYy4rAtYidt0RIsA0fmO46mc92aaKLAASV09grjrsMslveCNHE75Bh/b9aAOeTpE56pRg5ILAJcCEmnmxjNJsBTUaDXAU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832439; c=relaxed/simple; bh=M9H1p6QdSNOybgbowtw6brrEl/02Mw1iKn1qBSJlFkY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sqtfmw/+X5QP08mPFXA336L/lZTPEyZpRHn4TZChAtMw1Se7IQpe0a7ti0mAZ3vyGjmMC5b8GlBJ6kpM1zVFCwqv4h5IOgWmQaSIJDeLmFnN/QMuMudtM42p8bElO9b4FVj1Ae0bn/312Qwm+YJbPszjKrGUZ8nAFbRc6RSFtmU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FlepFESJ; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FlepFESJ" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-382ef647e20so1066611a91.1 for ; Thu, 23 Jul 2026 11:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832432; x=1785437232; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OMO2KRomBUijve5D7xBOqgHhJt3kPIgvFbAoFSgbWN8=; b=FlepFESJsWWL3mgLFlHMbrQvrwkligVKZxXTI6pQfH2p1U238kH8qVhIOlai3pHolK zBIgGNbT80Yq4lx5AmtWOr/bYISNNBbMHzGUSOmTd2K1iUhaYpjn7owAdjpgsGv3hZ7w M9Imt4zVIq0CKdMQTx1U9gUice8EUT9ZyWCIFegSCqNS2ik7Q0zx++/8tDmDCoptqOFi CjvPs8MYj50hwBCmt95agiIzsVGOoltf6UyePgNCBnkM+cePZh2/wF4aoD4AolHXtlqR 3Q9KYHLnsrUuthqKXna8shfkq7TUOlPhjrJjVlmkwtoUuUH8QjvxFAqqMYQJyYfZY5WQ 8wpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832432; x=1785437232; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=OMO2KRomBUijve5D7xBOqgHhJt3kPIgvFbAoFSgbWN8=; b=cBnITHvu0OzXplH1CwT6+H+crurOVA5/QV/dd0wbZgYom1s0y8UbHgBAWR2McJQzJY Wax6Ojl5h7sHH0aVo/9HCm6kwZkimRzqt69qvL+mfeBrJxKNtEmti/4FGe5fshQNi8QJ nxlAW2PsSXfHap3bsVI6u+ait9f4CdlNGyA5Nklkq3eEy5rFlUdPeOAChcNTe2N3aeqx s1SljLFG7TstvQk5bcLZkzWwN/CW1C2Yusm/toRXHJX7y0rnO3w6LGNYhM+PZ7swUtz4 FWMI/Tg+xnGGzhpLJkSXNz8ee1SgoWQfXOH3bRyDlg5KoTR/BmZ0drDtMPhIw1rGNQnh fryw== X-Forwarded-Encrypted: i=1; AHgh+RrZiEYPUI8bgmJlE3sOAF4Wrol/2xzbvYeYi5xCdJlawPjhBWsoB8oVqhzsxpcumz0aw6x2MSOHq2Y8pZc=@vger.kernel.org X-Gm-Message-State: AOJu0YyqfGzraLeUmRLi4uhbUHhgU2grzmwVF9820w2UCdTQ9i8SOKyt b0EFn6lHHNkTQo9tRFODZi236+vcpQOWpXznYYzOmKFQhkUOAZ1OUA9h X-Gm-Gg: AR+sD121z0S3c1gC+wC0DF4XRXrJL9zQV2SO9GCK2MF3EPd3njCHPMY86EctQHpSlzP GD4SR4DjbQ4KpVrzWKuRp2LYUbGyAPV6Ubbez5ATqm52xAn7G33ibdQcQJNfcQNMo58HUcVTNom CTsWTwlU3KDy/Yv9trrw/SQyCXUaA+AyCWmULUPOj8O+taoA9aABOiXRuIl3rfyijBOI34dr8PG 7PN0XhDYLECfsxd/Yi3EgrLz3LzpAao5ujgYSckO5WbFAhe/7CCMEeWeXgMcMenf5OmbZgmq7G/ z/ayJ5IoF0oldfwscTjyebUOKw7DKL3qoX19ljq34NX3jjlpbWwPFiuavmfSza5CuC2QBq3ty/D yRmk2WtdlrfQcplPM+gTsAEvhWmWTFYfBtKpGYGIvSXgoba+0NUytOmziNFn0Ac7VLNAcN5ys X-Received: by 2002:a17:90b:2ecd:b0:381:9028:5945 with SMTP id 98e67ed59e1d1-38ec64dc738mr4624841a91.14.1784832431870; Thu, 23 Jul 2026 11:47:11 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:11 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , Ranjan Kumar , "James E.J. Bottomley" , "Martin K. Petersen" Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com Subject: [PATCH 30/36] scsi: mpt3sas: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:32 +0900 Message-ID: <20260723184538.3888637-31-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/scsi/mpt3sas/mpt3sas_base.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt= 3sas_base.c index 79052f2accbd..791a3c5fbf44 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -8369,11 +8369,7 @@ _base_make_ioc_operational(struct MPT3SAS_ADAPTER *i= oc) return r; /* scan_start and scan_finished support */ } =20 - r =3D _base_send_port_enable(ioc); - if (r) - return r; - - return r; + return _base_send_port_enable(ioc); } =20 /** --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBB6548CD76 for ; Thu, 23 Jul 2026 18:47:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832446; cv=none; b=Xn/uq58en+6qiQC6bPYO65wFfZvwZ04kywmJ9TGPqSeHMpFYkwJllRJlSb8yORCviX0OvuPn61GO9l6kzotSVaxhF4LDHjAWhufjV3T/n2cOuo7PPuEw+mTusvRG5H0WP0187PwJ7K6b2pPS6qj0Yw2QJlPWw2+hkO6FcN1Xxp4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832446; c=relaxed/simple; bh=Zi8vbQtaaCryc4HCpr0GtJV6f2jQf9Xj8C6Qirl+108=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aLkM7Jr7G1yg/6i8vKNxIiVTlTV3LCXtwJ0bd853KlpfxGZzZJOOIgjsz+biRAHtBID7dWZDa+k1XYTXAKtK2q3x7NACFOKXa72CjGFWlt08FiXGudA6B2j9NFX8xGgIv7mySYkpXbnEL0zOl7Kio6zqQ0Nb82orE4NU38HKxG8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PY0VIxvb; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PY0VIxvb" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-38e69bdb0fcso809522a91.1 for ; Thu, 23 Jul 2026 11:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832434; x=1785437234; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=F+UjJ2nGjxXWT2RhAQzqOjO+SrT+lpfkp3b16ZbPdls=; b=PY0VIxvbzzV5xo3uPJxOlV3TR/vBEIMBSX5Y/igDCCX24oj4IkLlnrwDeC0iDhKxxr QaW9sQ/Wmnp+hfsP4fqwYajs5DqHMgr9pZqqswikHgAURMsgk+Vn0ic7O8UPXH7UVcZs 9cuRRVmRtqWsO+4h7wSECcpsV//AK87eTXPYDGT7GOe4Cwi0HaeMzynH2isEb5uwz24P d7HA3xQEdPTZ1MM4ulD4YqyiioQTgdyyYOX7/SG72MrGiJeXEkB6FNi45Yt6bhUj11J3 97eBYRRtG9lLWYk7rWwZYvC7BTo7mGY7DwcMF+dxaluj/69q1lLTHjSCPSm8wQ4HNeQg hpGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832434; x=1785437234; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=F+UjJ2nGjxXWT2RhAQzqOjO+SrT+lpfkp3b16ZbPdls=; b=Qr1uOLEhKfItO7sWU1PGWO0nHkLkayqtlRf6qeUBVtLdw8B4PhXTvun+YjMOlG35Lj ZryqY+KoTuRkPCMoTquu5366TZC7YAxWxQYLrI6ULypN0IRdYo4RGiQAw0JyCpw9bOPn WvgiEFjusUCaKj1LUJPJJZonwB9Ivoh6o6LDXs47pLVp/xh8Z3a8FSES+qEr1nhbs6fl P1Lx/hTAUKZJ4QFTthDW8mxqgxau8TLx8P8CGo1n9ESft+/+rejvPdIbe0q9gIv5QLOt k2b9smA/gbmz+XAbwRiOGntbF0Kr1MlRSOPcJ1GS5nkJgX0kYTbtM/hNNn8DycMsDKNT x6Gw== X-Forwarded-Encrypted: i=1; AHgh+Rp//mHVjzzfW8SpfLFqYpg6KM+9+U3hwwvXE7pxfmZV6iPWIFAQN//Ix+ngzJDZBWekp+q10nncZVcyJWM=@vger.kernel.org X-Gm-Message-State: AOJu0YxY4tcPaJWG/BdtKZTahEOvGopY+ErEwft7Fs5SsxGq8DS3qv45 tNbL5HG2tHzHOd4ZEk50urKYYKYibsZOfIiihjSgS985uCV06/JV11/0 X-Gm-Gg: AR+sD1388KttBWMwnKgRO+xzxZxDreF7VbfqpMffdVx3CSEY6ItFFMgdUpPfBXD979C SRWSEaeWssc5w23li+2vbF03jcTxzrpQP/uR0PGc/t17oWkQBcGSFM1K66ye8XMZxdgSiOY8mzl bR9YGAMHJ9Jmef46+WkMhWs65Co5c8Syw1TyH+4QIla+FWXt4Z0wNS6EpHHGNAVDgm855B31tBA fpE/qD32D/P19o0QNzb4Tyeta1eiZ7VGvgQ5bXAild1OKpHdfor/bJkOM6d1L/y2y14KlEKAaAn qEQ40jS/whbnHh3OXePw1Biov9Rqo+cNindh2Qj41cWhFlOVgFOi/oTCcgncb3rnqWZzI7UgE58 HW01GLEd0JSskPkzsOsKC3Nhp7DqDzzV9x8wLEShN1nP+77w5XHm05cn0v5ADdNsA7AWnYp4g X-Received: by 2002:a17:90b:3ccf:b0:37f:fda5:8d9a with SMTP id 98e67ed59e1d1-38ec6a5115dmr4286424a91.25.1784832434078; Thu, 23 Jul 2026 11:47:14 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:13 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, "Rafael J. Wysocki" , Daniel Lezcano Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lukasz Luba , Zhang Rui Subject: [PATCH 31/36] thermal/drivers/k3_bandgap: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:33 +0900 Message-ID: <20260723184538.3888637-32-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/thermal/k3_bandgap.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/thermal/k3_bandgap.c b/drivers/thermal/k3_bandgap.c index 678d6ed711b5..766fab7bcf1b 100644 --- a/drivers/thermal/k3_bandgap.c +++ b/drivers/thermal/k3_bandgap.c @@ -141,13 +141,8 @@ static int k3_bgp_read_temp(struct k3_thermal_data *de= vdata, static int k3_thermal_get_temp(struct thermal_zone_device *tz, int *temp) { struct k3_thermal_data *data =3D thermal_zone_device_priv(tz); - int ret =3D 0; =20 - ret =3D k3_bgp_read_temp(data, temp); - if (ret) - return ret; - - return ret; + return k3_bgp_read_temp(data, temp); } =20 static const struct thermal_zone_device_ops k3_of_thermal_ops =3D { --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A43048CD5D for ; Thu, 23 Jul 2026 18:47:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832448; cv=none; b=hSNNQxLYMUBaMLitHDBYZ+wJeNpB9060KqrqPe9bH3woLO1br2Z2IOnKEnhmi1pJ0nnCEOLnEC8W2IEPtt0ousE2ieKTHEmlrWYAA8Lm2e3M5ieeFCVi13LYkYLfbOz4p9mfbXlkJJQL2BykBLp5PRXkmh44VJrpFnd3t9t/SB4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832448; c=relaxed/simple; bh=uYqyINOSIs4ZwGOEvHHuixscb0ZcxiQRCToDw0B3yuw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nMmYvQw7d0rHnUuOSZM/0Tmx/zlx1pYcPmxi5V59to7TQiNxPLvL4inB6IxVXpxi/oClgobXFkCp46DRht93pBO8Y2clSU8vAYhNuvl77c14F/6mKriGk1kCcz8k9cvmttcsGnOWRG3Rra9Gv7p8n7OMYygsRlVRTliKzZyxLvE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NqweemoK; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NqweemoK" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-38dc4553f62so1054797a91.0 for ; Thu, 23 Jul 2026 11:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832436; x=1785437236; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SiSOFKr0Kvems3WldMsj2qAd8XWvGaX93cSHCBNiZh0=; b=NqweemoKyNtknpypcRWlK+uEZxc/8ExfNlT7yP3H/rpladxpXMbLRiJtX7sfGQnhsA WRH8gE/fUz4Qrx8i9HcpYfrVTVpeV1ohdkdiRZP77SGHizEtV0sT3TEyp9DuW1DTAM+Y m4w78p+LGkofLqk4RKSzznPGhwO589Pkw06aF1uObvtorirP6g3KnNNOpx0w2/rnGmZK DRc1Z6l2bifjxR84cr6gywQ0N1q3jJ/IpFvWci2EvJQ+9Jm8ujlDmYZbQVE1LK5ryXSG CynqIV9f1BN4PgXkymN6XyU4JU45HjkF+HSQk7b1kdhVsfmTs6tJuNktWBNenzJwi6or t1BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832436; x=1785437236; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=SiSOFKr0Kvems3WldMsj2qAd8XWvGaX93cSHCBNiZh0=; b=q4zIPmn8y24eGyZXQ2+cubYt2+Uai1xXDWR36j6aQlXGGO4JbytBpB42iMlMgG7GOX z2TZm7lWO5ESuQHT3gaS5RhVigpRVt0gah4XkXyEtgicQ9yNk3T6QaPMpre3jnJ7nnyB qkEKrx8uQqZ2qzt23VN+xQxU4Q08F+MJYFqpM971y7ZZZxKtT8nqXPPM7xNUS16wpFCZ dbN/YhUmuZjeGh/iYkdOPDb/qZC0fixPEFpKz6yNmoXmgUj/L5D8caGch6n+wCg2X/3A zGyAl9FX0C09UDzFH/WoAbuoj0aEci060yVXfkKVyJ/hzc5BJhTCdGmVfoS0Kk0sitxn B3zA== X-Forwarded-Encrypted: i=1; AHgh+RrdDzDjNSMRmPnpudpsDoGMgvqp2JkiY/lRzsMSK5khqJ3CQBzFfu29d1MzjT5ptZ5oCFyU8cN1ga0c5sg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywj4a7+oiavn0ZvLoZTWjvVfZ5sdqQPYfI3pmECmYvMIm8CfvZo 8Zvt98nKzayazfNekGBljDtbrd4k24s10RSJvoS3Td0Yrx9FWlNLWGoM X-Gm-Gg: AR+sD10G1p8UOMpMBTuitbTQJP7rGgqks3ISr9ADJLnr52x6zfSRHmWkHXp0DycKWDs Xxtyk2Fa4yjHoKEcTVMZpQqewYotpSK3Rv5MjOuDknuuFLeH0KXJdqJ8IwLUH5pP1xeKUVNegkk z5RQQCQzpNWrZdbxI8DuI7WxjiNLFJ3OGBmJxvW5tIMLEsXo6F/UFcxi6SNlVlSkC4A6N37YrGb xOTlgwGDhwoMgZ2nZxK2jt14v8dUGP40Ug8W5KVSaGMvRO16XJCWhuVizmx1S0S8D9CNQVucEDa ILFDz+39NEQSkaoJkh/fbgiS3gAQWk96KRhYE000tszdRVMnsjDdEUTvWqnbPmJsE6HXKOyJhLG vfrFwJ3xSaXCjvT13WXMexOfzXZCfvmn2dmIIEyrSUFdjnAPb6CwExHly7ZkPwaQE7ndHUv95 X-Received: by 2002:a17:90b:5885:b0:38e:921a:5512 with SMTP id 98e67ed59e1d1-38ec64dd01emr5012020a91.10.1784832436164; Thu, 23 Jul 2026 11:47:16 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:15 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Johan Hovold , Greg Kroah-Hartman Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 32/36] USB: serial: ch341: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:34 +0900 Message-ID: <20260723184538.3888637-33-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/usb/serial/ch341.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c index 569f4aede215..3de317bde07b 100644 --- a/drivers/usb/serial/ch341.c +++ b/drivers/usb/serial/ch341.c @@ -279,12 +279,8 @@ static int ch341_set_baudrate_lcr(struct usb_device *d= ev, if (priv->version < 0x30) return 0; =20 - r =3D ch341_control_out(dev, CH341_REQ_WRITE_REG, - CH341_REG_LCR2 << 8 | CH341_REG_LCR, lcr); - if (r) - return r; - - return r; + return ch341_control_out(dev, CH341_REQ_WRITE_REG, + CH341_REG_LCR2 << 8 | CH341_REG_LCR, lcr); } =20 static int ch341_set_handshake(struct usb_device *dev, u8 control) --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ECD848D878 for ; Thu, 23 Jul 2026 18:47:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832447; cv=none; b=CkYqwv3b3C6R9gEV0+T1WPRaf6ROKJYNcj1yrs2DTplJk+oUet+TPHCSiN1SuHDg1GFBaFCNAH90zWeg+aU2e5KMsrWK6lqxyOUFnuZfoyiOTuHwJGwu33jxS1FsOMMDoPxmsw3dHJ2V5CHqQxX/qkG0WqEoj8tQc2CXZTZP8Ek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832447; c=relaxed/simple; bh=dCC2It8t5ngYjhp2LUzJWM0HuvqaBLSMX1+wrSZKJ+s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LgIYRkWXMo4W8+QoULwubUr6krECD4wi2PsXXCr4H1LgE3IFpTO1PiQbDdp8uNcnSIu8mG5j7LnJcer+CyLbAdKmFTY+jto9v3Pd/fmv7Uv47rGvJj0fMEJIC9N9rbrcuw5VWh80UZel8hB39xb4oflkdb0om/9fJ2CU3GHwPV0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wpq9hLLH; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wpq9hLLH" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-38dc69c74b8so945151a91.0 for ; Thu, 23 Jul 2026 11:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832438; x=1785437238; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bbSTvhrvJVaWNbYcerAizGhExjCM7xuViLJbvyJxqsY=; b=Wpq9hLLH1vYJks3QmCuyFJkccrysLBesM+BZ+yNcWOqaY6PItW8BtoiHZh/QoegryT mYDQdP1QW8hqLnDno49eHJG1S/nJKQGZFT7p3SPVrur1IGXGypO15xNQOLXn91mLRKHk AoPXbJByrIhMbM6YetSupYoQLMJ2YQQrZruB8drHLVwBR3o7BBEN2SAmElBPyLNqABb2 rMCOBAflr4j5WCL+/HESN16zduHsxZKEwR1m3zxg+U46LbGtRfgF2PytN9euP3vk0Ra0 +r6AqKzPMB85CLrd22x6SBHqOkg7RRW/TsdLfAPN2Jy72i7ek2xpKv2uoI56QxNXZCYi 0z3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832438; x=1785437238; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=bbSTvhrvJVaWNbYcerAizGhExjCM7xuViLJbvyJxqsY=; b=DYti6bsGNLyhpu2FnTf0iwsOErqcmxOMEXQ76FrIjYGvDNSElDZ6e64OXEcZ7y/0sy 3IZfFE1iT0hWAfnm0q21f3GsxJILE0KaCA51iN5PD+Hdanz7LZaAFl/6YJTGyS8h+zoA hJRdnU/iqIkI1UFQ7279nVMP7k5W6fr2wuBhYpWwMLajUKBhoTYK4AugpSAd6ZLdzi/m wduY2WL4E4QLQV387NwkNjD0AWwEtuVdAOUhPEDdQMfBF+E2UunvAs2JOHShbC/fJPzh Ai+F6qFmCdh2aMPaYDBI8yNiWvTKRwmdDvpb/oJv69WJI5zNCINTQ2Jh4S+30nPAgMx6 y3uw== X-Forwarded-Encrypted: i=1; AHgh+Rpw398jch88x4v3e7b6lJTtxb5KUB6jLqKn709NKBt7ujCPEb93QDfcv36EPb1HRiaIgC2fdjA5wLwbC0E=@vger.kernel.org X-Gm-Message-State: AOJu0YyM149OjPclUJNdWDzDDVO1bl6IwKnvcVxI1xwcfCGZEddHaR8w F/xyFjZhytQAXgfT9h7VpovI6ewGTw2GYFaQfkQoO1HoiB040umUz1oM X-Gm-Gg: AR+sD11KXo7DVkGIIf46pZMSkmq/Ba8K7LjLCvrECWECP5U0uGRYq6LHdM0IMlRT6bM mTmZoiLmHPGtGdWBSzh2CXprC9Xk6iKehG13RdCJLjsmfG2+RzwcSgNOuhcZwk6LzJc5gJ6qz+U AikG5djpm+S/RpoFpcVflL6qsgNBYbhofxeZi5ZQaJzlrOpLF5/b8EXB/VVjyTTtVLwHGQqAbae bPVNwFIS02b788eH7hL7Vd6r/Wji64HdUwbKXgsr6iRpoNpkuN1RMThU5e2vhF/EJYR+pMMa79b 83cdARxHPnAzKV4qqv0r8m3vsBMaAcnmtdrySUUpLKuN0bD+uHLOzsE2qktN1KNZ+3l20/W5tL4 tiTdoB5eRk36/RXUsGniyLrLO50vN9tCyHzIVu461YVifnqynLthrWX3lB8Iq4xD9wdDw5Clus4 kAGERv6IU= X-Received: by 2002:a17:90b:1642:b0:37f:f4ae:5f25 with SMTP id 98e67ed59e1d1-38ec6a51c61mr3940118a91.20.1784832438557; Thu, 23 Jul 2026 11:47:18 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:17 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Heikki Krogerus , Greg Kroah-Hartman Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 33/36] usb: typec: fusb302: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:35 +0900 Message-ID: <20260723184538.3888637-34-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/usb/typec/tcpm/fusb302.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb= 302.c index 3319f6a2b0c9..d0ab247b24bf 100644 --- a/drivers/usb/typec/tcpm/fusb302.c +++ b/drivers/usb/typec/tcpm/fusb302.c @@ -314,11 +314,7 @@ static int fusb302_i2c_mask_write(struct fusb302_chip = *chip, u8 address, return ret; data &=3D ~mask; data |=3D value; - ret =3D fusb302_i2c_write(chip, address, data); - if (ret < 0) - return ret; - - return ret; + return fusb302_i2c_write(chip, address, data); } =20 static int fusb302_i2c_set_bits(struct fusb302_chip *chip, u8 address, @@ -375,12 +371,8 @@ static int fusb302_init_interrupt(struct fusb302_chip = *chip) ret =3D fusb302_i2c_write(chip, FUSB_REG_MASKB, 0xFF); if (ret < 0) return ret; - ret =3D fusb302_i2c_clear_bits(chip, FUSB_REG_CONTROL0, - FUSB_REG_CONTROL0_INT_MASK); - if (ret < 0) - return ret; - - return ret; + return fusb302_i2c_clear_bits(chip, FUSB_REG_CONTROL0, + FUSB_REG_CONTROL0_INT_MASK); } =20 static int fusb302_set_power_mode(struct fusb302_chip *chip, u8 power_mode) --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF08448CD59 for ; Thu, 23 Jul 2026 18:47:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832454; cv=none; b=N8/KYomYt6tDjKEd+2LrpyIFaOGeSkyCtNsHH6CECb+PuQ1jcqrF7N0XZsRSrqVHMfrVU/vrEZEDiZNg0ALygKmF9aoisd65nHjfvu/bap5slXrOc5XcdJLrE0oyfYMrO5Z9fcYQUTph+4JzG8ty7fcxP70jNVheo0IGwjY6WzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832454; c=relaxed/simple; bh=0THJsAe0GGadOigqS9gjiJwezmjYYlE4GhLoiWCj6bw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FOp8+2ocbGQ6AoeE6yiR5iZ2rmph/7AxLYUoMd9j+R2+kats8LGvH0qxoq/jK7ElkIxl6CdeeNyEMrl/ODZFZiMB8Jtt2BaEXj2sx9JYqoE4LLogdpULYShf3TbdzFcS6KFylbreh3oh+v/WFDqiaCed4rN7h67TijtlyiKgA4M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EQEIVisM; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EQEIVisM" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38e3efab7e0so723446a91.0 for ; Thu, 23 Jul 2026 11:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832441; x=1785437241; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iwiokRL+A5T31Uey5wDHfoo+mp6zGabrAoF65o28YUE=; b=EQEIVisMEVzEoxHf1rSoc70u3qlYJGbqv8TJewbswYbYTmccAoY3xOHDZZ32ILBD+r Da6RO4tS/8NqOobZZK4Yca4Ux66fFR/z6M6WA5tKHr/+iv7Pi2XN2SHaci3hDCdD2Njj m6cJVRLf2SfKZq8xyER6GKP4nKXQXk9UueWLylXDQkIPfLHfzvByGC1WoRNSwV0RiHA9 ARDlw1wijdnkIH03UiZK+MDgZ4CC1FRaI0qT/Bwu65BPQgsq0WxM8Y5Xx0PO4cvkBbjL LFWHluf0Hqr9x2vNKlFZa9RBOnEfvZEiIs5eH1iZtiZrVGDvM2m394FnPDahT+cmGiCf s2BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832441; x=1785437241; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=iwiokRL+A5T31Uey5wDHfoo+mp6zGabrAoF65o28YUE=; b=lYdgobrXs1fMMahIXccfh3QB0ND3kPg+aK8dW6Zg1Kr2EpHJhESxKhxjJbEwzB4aOv 46fm9OfHN4qIEinlgMx173EbXTzZKOvDpKLfRwMI5d4lEA5IwWWLSlbXI+a6wBbwUIpO 5ZsTiZnQb4tuW5CyJmqtIrmIINT0GsIb/x3Eknr1FPUTX+se1rKErT7vKe/Oe+Nk/R5K tXZMb42GceaLk7laaVVAvZE8bUtO3G1OAhvrwQHvFSoee5J6yS4XYSOE5C57x+2U75WJ pKolBZtCMmOKo82WFtzpZ9u4NWKcTplP/spa38Nh4UXR/W8BtU6Ok/1OO9HqB2cv8h6Z HXJw== X-Forwarded-Encrypted: i=1; AHgh+Ro//f3hfQn40pJxRwzY/XewK4idyi+6xv/zIKYrYEzx9b3Vd1rMCBq0sb9Qj7tssgt4wo+wiu5VLwal8iA=@vger.kernel.org X-Gm-Message-State: AOJu0YwMG/unL7HX303Zp3Cz9D6tubzdw+ISfGU1oXC0+j7ML5sQ73Kg VFcooaYUCFd1SdMIpfuRdx7Qyvnj96qZPYpI/iACLibRYmmf1oeKOD3B X-Gm-Gg: AR+sD13vvTqyTFXPERXc4ai7FInQvhr4SqH9QME/4flLoYULV53EcT3m9XPlT32sv1T z618mxc6IYml/oChaPAdWdtAer6sxqnoXRIaj2Cr73TR9Myq75wZGMYKA1XNGyKNwXJlNAVBjMa DdGAo646TXpnI3bUOqMKzu4aCwQaGRaDsIxZ78PRC+5QKOEbjgMuVUmyUPyPQyhEe/hHs3IUyE9 HtbCZp6U66+HjoDYkiZVtweWRxx9RVno0CK7IleIPtWaWhPqubtds+Vfw/paqFPe6K8GE1muMmk ofzZBa6tfNX1mg4fzSfjCh3fODKL1dTcuQujZOv3HWNSA8hxoSZ+xR/+Q4ssJv3qRhqwAzxCrjE GbXG8JZm/ITmhPkREpqcz1Tm74A8tArDL4vgrMW0coWJdb8m2TkAA//ewqF0WA9ruozkA+ug2 X-Received: by 2002:a17:90b:52cd:b0:38e:5ce1:ae30 with SMTP id 98e67ed59e1d1-38ec8468567mr3576355a91.14.1784832441260; Thu, 23 Jul 2026 11:47:21 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:20 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Steve French Cc: cocci@inria.fr, Bharath SM , linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Paulo Alcantara , Ronnie Sahlberg , samba-technical@lists.samba.org, Shyam Prasad N , Tom Talpey Subject: [PATCH 34/36] smb: client: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:36 +0900 Message-ID: <20260723184538.3888637-35-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- fs/smb/client/smb1maperror.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/smb/client/smb1maperror.c b/fs/smb/client/smb1maperror.c index ab3d09613c91..395299f9121b 100644 --- a/fs/smb/client/smb1maperror.c +++ b/fs/smb/client/smb1maperror.c @@ -234,11 +234,7 @@ int __init smb1_init_maperror(void) if (rc) return rc; =20 - rc =3D mapping_table_ERRSRV_is_sorted(); - if (rc) - return rc; - - return rc; + return mapping_table_ERRSRV_is_sorted(); } =20 #if IS_ENABLED(CONFIG_SMB1_KUNIT_TESTS) --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FAA548EBCA for ; Thu, 23 Jul 2026 18:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832455; cv=none; b=QlwyxfRkPjYrI2YDUnzWchhbgwwNrPVKZgUSzRpTjeEgXsfkj2zdy8v6ikb99sLJpkNqIu+4nyi9Xe98vy14mYA/iNKvYB8sv4dl56XNypCAt8wRWaGvw27tMngK2G3JesaNI3XMgTFYLlLC5s2ZZeC6GlJ8t/lE7KX0218u8Bk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832455; c=relaxed/simple; bh=8A2S62PZzrC8JPpHbdE/IFoS+mlqyAjg7X22tpKj+Os=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H7JNSuLKqI7C/O1qHzkgmvjSP3qb0XjEyrB8/A1OPMuiVWBKu0LSgBNs1HAjv91lFAbGsl7r3aW9+foqFTdSWsxij/oA6X9ieb04+P9JSkFlUVcxaCXqAF38Hf3ekQ6TGPPYlbep68/SXvriTlZGZwPvB9GCjLwLkczZFJbAkRg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZLv7KMdK; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZLv7KMdK" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38e071ed6aeso808585a91.0 for ; Thu, 23 Jul 2026 11:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832443; x=1785437243; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=y+eSaDxt3Oy3svRwCwnnMubzPU6lsf5Q8Wmnj1h35P0=; b=ZLv7KMdKbwdFR79zu/nnXxy3rl4fzgknndDl24jFVOROdLtJnGHusGmd0mbUGV14Vi X2hY8EoYIRI1RUVVima9X0/V/lzNEC0E6NfVTjcFt9wfN9j5A6cC56Hfnd3STA2XvTFl NS8h8Emkbj++rYbSu3CuhjymZQ1t50zCi3bJdyaqcgmTVvNMLhLQX4sxAnwAQXMobU6A ET4sDccUJ32njKrzcgEtIvKOjwDhd1xzwTDe0HBVJiI3yc0CJGrkvdJFYTQ8Mtikofc0 W/UXneWCd0oNpmlUALy8TLacJohYWozfpTHD+CaQIEgf0xjLDLvns69PqFFW+Pf+hi70 bdMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832443; x=1785437243; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=y+eSaDxt3Oy3svRwCwnnMubzPU6lsf5Q8Wmnj1h35P0=; b=djTvvC9Oc/8gsAYdhA93hOFKYknFsggHeb8AvoZ6+s4pO4KMTa0gdhJK6LyBcG7oTE 4HCtGPjjn1BQK8wcsGtL3Y5EnQeLa8h+dWTJ9yANdbnvDpzvI+tgqUcVvX1QSTl+NXyz jJcP5s1w7vYNdPGizTAc1R18CdsZXKBl0lpYnPGLJLk2+Bp5yeGDrSpXXrRWn/H5pHDX TKA48e4ZqBLxv8Mjk7TT706NqhgLfiRgJe4bSZLDBrhrTZYyRffnlYHtYVcW1l3AdX+f uiP7LoyyvxPdd5rHPdP2Plt7KgmL33HBM3khB91ZPwLfey7631pZK6lZPQZ1ZOR5Fk+r ocbg== X-Forwarded-Encrypted: i=1; AHgh+RpCKP34+z0JrX7CkLyhSeXmmR2WkWg06OvsLv9ODt2gmFNnXSXBi1fZRyxFg0tiqqNUwhQNOSO90e85IDA=@vger.kernel.org X-Gm-Message-State: AOJu0YzbljuYXTZ1CUQx/MaWgSHUHO3Rfjg4bek5ClS09LLvxTaALyVA lUTFoM8RleLWmlfb+/BB6CAwgCvK9EO8kQFeypNFCxZ7YLSz4DuOgW9Y X-Gm-Gg: AR+sD10HAYGP5AzylEcwyDveLHEZo82dvG+iFzhET80fHZAN7dDeooEQi5lzGO6SvPz bVaUwiFl5yMPmPxTOcOdPkPgZvtjZmYjKS9oxdA8huQttBeWPqdM8TQ5Mh/VWwGmHnPeX2z7GE5 ZNMNKjG5gZS9SlqtDBOqf/7POJeiAv44MaCfa1hW20JFfvqlA8bILOikxWIcV7Z4dwg32l2xqu5 vXwP4PYqEOBhav7t4z0U+Np5hxTxaJnAvLOAA3FR4yc2Hu7YEmct8KBPeIgmIokClQhbX6Lc4qK Ol7O0Vh4pNehNNNK64GaU+OYmArFYnlb92VsLeJthHDCZFIWbQ13Va3d+O/55SDMlM2mjTQrUY8 /QBy7M9Vu48S8gCet1Fa9CkQt5p+CT05zrfEFqjxd4MN8JITROxd7Ve6mXDTRMb+dFThIGF+T X-Received: by 2002:a17:90b:3d43:b0:38d:dc13:6f94 with SMTP id 98e67ed59e1d1-38ec6649d4fmr4940781a91.37.1784832443347; Thu, 23 Jul 2026 11:47:23 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:22 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Thomas Renninger , Shuah Khan , "John B. Wyatt IV" , John Kacur Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH 35/36] cpupower: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:37 +0900 Message-ID: <20260723184538.3888637-36-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- tools/power/cpupower/utils/powercap-info.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/power/cpupower/utils/powercap-info.c b/tools/power/cpupo= wer/utils/powercap-info.c index e53033488218..88a5edb76315 100644 --- a/tools/power/cpupower/utils/powercap-info.c +++ b/tools/power/cpupower/utils/powercap-info.c @@ -47,8 +47,6 @@ static int powercap_print_one_zone(struct powercap_zone *= zone) =20 printf("\n"); =20 - if (ret !=3D 0) - return ret; return ret; } =20 --=20 2.43.0 From nobody Fri Jul 24 04:48:38 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B09348EBF7 for ; Thu, 23 Jul 2026 18:47:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832455; cv=none; b=tFusZ7w1KenFFt1W4Ejp/jF4fzQfo+qjMYlrHXYLPQEVzyAYKwKK1R192EcgvzaPOYXIN1YXKQOKFqgQ3N7OGBzM1v32oCqL/wMwWh5B0f19BZrfGPICe+xiiL0pMDpJ9CcrM1Q3wUZR3+wgWRwNuXYrdywMGjfMzEJyhubROWo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832455; c=relaxed/simple; bh=p2Vi1WxGdqsuYQW9VNZ+i90fxxCqZYkuNu/KnilY5Gc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H3vyYvSZFnViotCJcF98F/8ad5LFWqL52aqDQF1LzU1mrrHD1dXyi71lU/R9zNUi0QmwSskacF9NwXBKGt4ylW3M8NiO+gGTZVv5LPWFa/BGVn3UxrhaV2EcERoRq6ECOarIU2FP8zY0+59fGD06y4j8mkdvpx5Hxy4RfH/DxVg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V2Kgf5jd; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V2Kgf5jd" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38511175ad3so736754a91.2 for ; Thu, 23 Jul 2026 11:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832445; x=1785437245; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/nXlwcFamigkva6bDWgvzoIWdAmElQTTWvr7VWxupS0=; b=V2Kgf5jdlUoN13r9xXUrpIBQDaaCUiXQLRgNjMhOI0wrZ4WviFG+4MwICCTrMpX4B8 2qbzvcQWx9AdLsHeK0zq6zMeG9kyjl79qGgMmiAKHKfV2/BNzRVFR5Frt7jQpAlMercm 610AV9Rbhqkbu1hTI+M3DnntzcU0tR9j5ELObw9f9b9ZNlne5/vCCq73IhGBboXqxv0T vjmyfFabkBJFqkhGoS3w2cBpeV080HPcFxjmilveu4h9QEDf2PVESOCa4r2VaJurBvCO F+usiXEzI587nqQBagQNOG8MWovCuFDqnSuD/ktfY7RwATIqP2j89voN3d/CsrWxef0K ZpDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832445; x=1785437245; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/nXlwcFamigkva6bDWgvzoIWdAmElQTTWvr7VWxupS0=; b=F276wn1nqVWMAvKih65phU9stpwDVpnhf8ULWwfV4kVe5LJoBElVqfWktnF58NreGw oN9MSjOmaLEgisecqK6iCTKp3rDtpiTxTLaZmMqoB2JfCYAO+H89ldLxXdX1YGE/NRFN 8oKR53Uz4k2fnX3nErvgTebY9uxp7S4P5fKzrFL0vFqYOYJt3GI3XRMrW5OEnnEaovAc ppqmCayCAUoXteW7Jwq8j/H5BjC3Awxr7xA0/zVscn0vEaLXxhmGBRANGDDofit0AJj4 ftpvMa+7Nn78lJ/O8uvQBpgojScvW9WtxaoIgExtvIVHb6HCNmezadozz7IbwDUljAFh 57tg== X-Forwarded-Encrypted: i=1; AHgh+RrJYVreTMN8mjQYLYQKnp8HqA5rgWsTnpiXzxzKIK9/hKG0YXoGfQN0gmmsdRDepyRwbaSgsloy4Ns5W4g=@vger.kernel.org X-Gm-Message-State: AOJu0Ywd/fv6FnudmZKILp0pB9uRvzn6ukjn2foMgM/LSJBzIjQWTufC /tQmKtqt2PsO6HUPqCl2Dst1dURUodLRQ697xf/mLX99fqXxwoCDtPj6 X-Gm-Gg: AR+sD10ptyTh9WTiR/k5zjx93v8bR+ht4qvlbu5q/nAlUnK5jodFPWTzEPBkpMLFrYg Udp3BA8jyZn0lhibwAyzhfNrXXIpB+jbRn+I43pjJ5sMvvTznAEA++L2havE2GcccajpWpRuKbQ ISKkeC+HROqAIOSoh0hGi/kPNLn5IB8qib3XVH+g03YI9/Sk2rt0zPj2fg/humcPqxwqA1V3YlL 3xJy8eB33hcKJ0w39dfcRBvTBkjmawqHLBrOtZjFoV2DkC8TZpXyVH9M/ZaRe138zTd4oCSme2m Gym4tfhSr6dqoHAhNJFfCSEbGOACqS5JQ5H7GLaDxb48nnbKxNlCMo3r4TUu8AYwrnyE6vrgKPn HWXg/Yi/J5hMNtkXs/SZYoPl/Cfgm8HvNxTz2kkHubVAH/bTirjc1SCTl6zoNm8oCVtJKs8UF X-Received: by 2002:a17:90b:1649:b0:38e:2e16:859b with SMTP id 98e67ed59e1d1-38ec65f37c0mr3966608a91.20.1784832445197; Thu, 23 Jul 2026 11:47:25 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:47:24 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Mike Rapoport , Andrew Morton Cc: cocci@inria.fr, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 36/36] memblock: remove conditional return with no effect Date: Fri, 24 Jul 2026 03:45:38 +0900 Message-ID: <20260723184538.3888637-37-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- mm/memblock.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/mm/memblock.c b/mm/memblock.c index 036316e9138b..6941fdaa3473 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -2614,15 +2614,10 @@ static int __init prepare_kho_fdt(void) =20 static int __init reserve_mem_init(void) { - int err; - if (!kho_is_enabled() || !reserved_mem_count) return 0; =20 - err =3D prepare_kho_fdt(); - if (err) - return err; - return err; + return prepare_kho_fdt(); } late_initcall(reserve_mem_init); =20 --=20 2.43.0