From nobody Fri Jul 24 04:44:43 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D55D837F32D for ; Thu, 23 Jul 2026 17:23:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784827412; cv=none; b=JI1z4gufDWdmzBVAO0o9NCQOB3dZDUNySBbHtI64pRXI1pNaUmwVCn37DwlxAMLc/qUfZZ98tczGdkyxCp4/bI74rKbYZZ2fUuSS70kEq9nzP8iAd3iRd1o8CYAP82ylAv5KJHoHN2I9y3bZnmnsyI9tsGkn13JnFjDjhkMB3X4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784827412; c=relaxed/simple; bh=Z2Eq6tPQ8IU+EbAZvLPYmcLwjEeENPPS88GFAlG6sKo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pJ4VnCNWqiitxKEFzo0Zz8ouYW8WgiEYXmpqiGRoBFy37HAUwf3aDC1fq8eWrl7IrVfK1RDdt2bpx536rKKfALhPqqaZIqoLMRt+dLR0EzlHho6gn/R7bP07xru7Iw/ptTTRew89e29SWFFI+NwL4VsY5OFmoRzuQ4drIAK+CjY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hmOCzdqS; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hmOCzdqS" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-ca957432c7fso704788a12.1 for ; Thu, 23 Jul 2026 10:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784827410; x=1785432210; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=eBG5HEmpJKSGr0OHWB4+9YhE4TrW0R0G3idJnIf77oM=; b=hmOCzdqS63l7Ezcz/FGCSHTx5XKohoUpyIhdCr8SCkREmQ1ITJWdMdnZ6Pgc9DNvH0 99zl9f8pIgLrwI1Id/acFjCLUCU5gHs/b13tRae7RRbeWDA+yOC/+ZsBWEmxH8eEa93t Mcw3AzdAk0cC9r4omKlrCiQ4ogweXAW9xtsD1tjERVQYP3xRy1BD/ziBsip4ifWokpRi MdvOF4YsNzjvjjnQOJxPSPhzeOYHxQbfJJClX6a/XMnK9387b/4Zz/l562TjVwd6HiLW lmAuscj0L9vxxtppzCnhVYqw/WebkH0nmgr0q2kgZX7SMbu90Ge2eQM2fsQhCdMDy8xT gBAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784827410; x=1785432210; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eBG5HEmpJKSGr0OHWB4+9YhE4TrW0R0G3idJnIf77oM=; b=aokfOpXEndbPmOIP1VYRZKIU/UkPx3MmvzAmzhkTDAWwTTfwNe1X7QgcHeF7eRRNtl WLNeUhjEQKVvrcJ28JBf2VuOdI7aNMLZmDjE6Nh40XRNAoK4oASSr+1D8TVP0QCROUrm 27MH1nZYfL+MAKxO8ol45L0N2v5+TUW4xR1P1Dmnx2/qjTPNcEiKAJR3w3Av2eKtVr3z yyF5U321r9WoD8E8Nle96eZJtAK31yiXlzKI3UOWX/CD69MIBBwsPWGNj9nd+jWOos/H BVWyG9lTtwDt9VzuRdlz8uLGQqHAovlqRb1Ic4VtNkDVDDAD41+vTxT/KnBiJvEyq86I H86g== X-Gm-Message-State: AOJu0YxfurgL4cYWgP8lGhXs/VVkbDZWt84mZtX1xUD+zkYulQmsSDTH xN6VvtojdvuYgdLPkLzzH0BOVQLvKTkxOzUiHTLpEl69Z3oFB/rTIFXq X-Gm-Gg: AR+sD11ImimGLxLbHtgxYbj9f2FOAEFq86goU5/4DsBu9eMWo5sYBtb96677R2BJgeC H9WvHacDY7Y/L4R/pbWNPL6x9Pt6JTQftf+Vi+0fvQIFvBJ3ng2Yvh/zpxDJ0YOduHfr30NMRkF Nmu9rLJJZ2el1vJaFTTypH8+nj9k5GWu/z1uqjImp8BRnzk2RTyWX8BLmfhzAY29PM587+bQBJ3 BS3RrKvNfPj7FpS06O8sidD5PHzpRWCF1/ZspK7TdsDoyJoyh3Kgu9P6N6H/xoqkLCi2L1Y/b8j 4BQ9SgdE7F6I2U71RipVTZw0wWzsjpn42vIHINvD/WvnXAovrdtrxL92xd3xWgZIzbtPkRF1sj1 KUkqPA/U0Itw5Xv3GUQ2S48vwGZFIuq3rIvDVZUyuHzVpjG9t7d2Dj3WImPkSbCoB0p3T15SZJU xz X-Received: by 2002:a05:6a21:1398:b0:3c3:8bab:804 with SMTP id adf61e73a8af0-3c44b18f692mr4493645637.49.1784827409946; Thu, 23 Jul 2026 10:23:29 -0700 (PDT) Received: from gmail.com ([58.84.62.107]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc6162csm21287676eec.7.2026.07.23.10.23.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 10:23:29 -0700 (PDT) From: Sumeet Pawnikar To: rafael@kernel.org, rui.zhang@intel.com, linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, sumeet4linux@gmail.com Subject: [PATCH v3] powercap: intel_rapl_tpmi: Handle PMU registration failure during probe Date: Thu, 23 Jul 2026 22:53:20 +0530 Message-ID: <20260723172321.5960-1-sumeet4linux@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" intel_rapl_tpmi_probe() invokes rapl_package_add_pmu() but ignores its return value, so a PMU registration failure would leave the driver reporting probe success despite the PMU being absent, with no log trace. Since PMU registration is an optional auxiliary feature for perf energy counters, its failure should not break the primary powercap functionality. Check the return value and log a warning to ensure graceful degradation. Fixes: 963a9ad3c589 ("powercap: intel_rapl_tpmi: Enable PMU support") Signed-off-by: Sumeet Pawnikar --- v2->v3: * Fix the format string as per the Sashiko comment: https://sashiko.dev/#/patchset/20260719085100.145555-1-sumeet4linux%40g= mail.com) v1->v2: * Since PMU registration is an optional auxiliary feature here, treat it's failure as a non fatal error and log a warning and continue, similar to other RAPL drivers like intel_rapl_msr, to ensure graceful degradation (Based on Sashiko feedback: https://sashiko.dev/#/patchset/20260515184250.228062-1-sumeet4linux%40g= mail.com) * Add Fixes tag in changelog. --- drivers/powercap/intel_rapl_tpmi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/powercap/intel_rapl_tpmi.c b/drivers/powercap/intel_ra= pl_tpmi.c index 7f41491d9cd1..a870199a9272 100644 --- a/drivers/powercap/intel_rapl_tpmi.c +++ b/drivers/powercap/intel_rapl_tpmi.c @@ -414,7 +414,10 @@ static int intel_rapl_tpmi_probe(struct auxiliary_devi= ce *auxdev, goto err; } =20 - rapl_package_add_pmu(trp->rp); + ret =3D rapl_package_add_pmu(trp->rp); + if (ret) + dev_warn(&auxdev->dev, "Failed to add RAPL PMU for Package%d, %d\n", + info->package_id, ret); =20 auxiliary_set_drvdata(auxdev, trp); =20 --=20 2.43.0