From nobody Fri Jul 24 05:21:56 2026 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 565AE41D138 for ; Thu, 23 Jul 2026 16:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784824884; cv=none; b=Xt0Vt+c17bvQcYGKuvysWEZScKr3rJ33eOTqMoY5JjvH88trsBUwl09two2bkF/5Nt0PGvnP8z9SVwQh9wxSByT4iPa1DEHb4jga5gn3SFAYXNOzgx2kyC/e24aBv+NUVY3yfVAUWS3qihyQCdEzFejGgD/borehMWzjx75nf3s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784824884; c=relaxed/simple; bh=066KBkce5J+J4omAWQK9ZOGdzxIDXDCCF98U/lxSBAo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jjdqm1Ey69zVQZpJrtmsNDsAmThpsA79OudEI4XaqXD2UcdvW3I6BRJV60sLgWdVCmZIDY8znckoExVifPYA4R8lG0WuPBmZN/J2AkqrDXq76TP0hZzsE8yzzC62kLIv4waMkUGmUCNzi1+O4lxA/mL3NsXH1jZ0M/8RCqCepyU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=hPdptkFe; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hPdptkFe" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=EiMZrXcC3ePUXFsWg2fIgvuQgtinbS5agsWWpN4XL6M=; b=hPdptkFem1mfUKOtLUQZqoGFMk oOZOfjMofGMrQ1A0BaEhewKWTIwmTaqist9KucSlzDukE+ul5N7dC1YjEvmgOE990psY20PbiD3L8 dUGoO/S+W/fxPbqtopYutfDTZqlR4bf61c1z2J5QRTrdGHCmioQlkjCq8Q5bajv7U7yrpnE2j2RhU DkNJQrt5q3GQa3R3sWoMQ1UdrKLU4pB5ANFQA88zc8J89+zpYj1hIv4i+oTq/TFRqSI/1LOIWmaZM g+RQzS4wsVIU/loh6pdnOtUqlRW8ckYE+9bUql9BRN8cP6XUaUzOkK7AH7sXGXaBDtCugKAl0MCXB 2nkJb4gQ==; Received: from [50.53.43.113] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wmwU4-0000000EjtT-08WS; Thu, 23 Jul 2026 16:41:20 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Kees Cook , Tony Luck , "Guilherme G. Piccoli" Subject: [PATCH] pstore: fixup struct member comments Date: Thu, 23 Jul 2026 09:41:19 -0700 Message-ID: <20260723164119.199138-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Documenting the callback function parameters is great, but kernel-doc doesn't support that. Drop the leading '@' sign from these comments to avoid kernel-doc warnings: Warning: ../include/linux/pstore.h:201 Excess struct member 'psi' descripti= on in 'pstore_info' Warning: ../include/linux/pstore.h:201 Excess struct member 'record' descri= ption in 'pstore_info' Signed-off-by: Randy Dunlap --- Cc: Kees Cook Cc: Tony Luck Cc: Guilherme G. Piccoli include/linux/pstore.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) --- linux-next-20260722.orig/include/linux/pstore.h +++ linux-next-20260722/include/linux/pstore.h @@ -114,7 +114,7 @@ struct pstore_record { * Notify backend that pstore is starting a full read of backend * records. Followed by one or more @read calls, and a final @close. * - * @psi: in: pointer to the struct pstore_info for the backend + * psi: in: pointer to the struct pstore_info for the backend * * Returns 0 on success, and non-zero on error. * @@ -123,7 +123,7 @@ struct pstore_record { * records. Always preceded by an @open call and one or more @read * calls. * - * @psi: in: pointer to the struct pstore_info for the backend + * psi: in: pointer to the struct pstore_info for the backend * * Returns 0 on success, and non-zero on error. (Though pstore will * ignore the error.) @@ -132,7 +132,7 @@ struct pstore_record { * Read next available backend record. Called after a successful * @open. * - * @record: + * record: * pointer to record to populate. @buf should be allocated * by the backend and filled. At least @type and @id should * be populated, since these are used when creating pstorefs @@ -144,7 +144,7 @@ struct pstore_record { * @write: * A newly generated record needs to be written to backend storage. * - * @record: + * record: * pointer to record metadata. When @type is PSTORE_TYPE_DMESG, * @buf will be pointing to the preallocated @psi.buf, since * memory allocation may be broken during an Oops. Regardless, @@ -162,8 +162,8 @@ struct pstore_record { * buffer that is coming directly from userspace, instead of the * @record @buf. * - * @record: pointer to record metadata. - * @buf: pointer to userspace contents to write to backend + * record: pointer to record metadata. + * buf: pointer to userspace contents to write to backend * * Returns 0 on success, and non-zero on error. * @@ -173,7 +173,7 @@ struct pstore_record { * passed back to assist in identification of what the backend * should remove from storage. * - * @record: pointer to record metadata. + * record: pointer to record metadata. * * Returns 0 on success, and non-zero on error. *