From nobody Fri Jul 24 05:21:28 2026 Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FE1F45D1B9 for ; Thu, 23 Jul 2026 15:22:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784820145; cv=none; b=SSP4FpL8DHZ4oN0JJRuJrwrHC5lhmoilMLmlopqOpTqG5ybVcBFcYPoy198GrTo93RUuchwdhS7qQIzHai1v6kQGF2dV1snikPnX560A/C2V0HIRyaDBDTWPLEPwTtbnW4ax5m5NINRTMSq7WA7e7a6XQHM1rg7Az06HoZJPiq0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784820145; c=relaxed/simple; bh=bulsuqfT4elwA0ChnmuElrRF7eFdJcIJCtLvAjuNCcw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=gnuS4U4X6RkZEDK+iXVG2QBijbF5nZ8pVks3NjfrMxmGMPo8adfO4jvn1yea4CbC0ja/OEB6JbqHg5YXHmVO6U62HrDjjiI3QAbXhU71Xn9CrCP6XvwTv7AdJJZ0XMzlKGIZDqwH8YI0TG16MGw/qhEuNMbTZYcOcO6nV7Wvapw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NiDDdfNG; arc=none smtp.client-ip=209.85.221.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NiDDdfNG" Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-59b074ec7ceso247603e0c.1 for ; Thu, 23 Jul 2026 08:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784820135; x=1785424935; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=bhoCJazApu7PhpZQh7Bx1EblplBzJkAncb/FnM2OHyE=; b=NiDDdfNGz57SEE6agrAqZqmiVJL0zrCFifnn+vmXH6+WOPwNybJ7tAD4/o6IeWZWpt QXxGLTIVFfsUw8kljn643MP6FzBc8RiPYUc3mHnqVynOMiRoMhRn3JSOd0UKs2TmCD2C PQ7Z/kqqpJYc6nHGrPno3L61e/HfLqltwb0zIrUQCZ5H7cZfm1QS3Qg14VooYTpQWiZy aRly3Mu5fI4FyKb+KMu75pKiAdhMnkur+z831B8WLr+AzmdVzEZ1RyUAx0nmqRrP5EFv 0WVDhnpQ+edsKIPL+VnU4Jsz8U4a1V63whCpWvK3W6hWAsSspLgaK0g3KgtjcNaWZWA2 KisQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784820135; x=1785424935; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bhoCJazApu7PhpZQh7Bx1EblplBzJkAncb/FnM2OHyE=; b=FIirok/BqI8c2bz0UfT/FjNL/9MbADx0iDJAgtHmeoF7dAS1bqcEbtJfck3cwPPWAy n4FN2yZwS8XTmh708RINqEs4ibkFPtyAhEHAjChv5a6kVDl/18VumCikKusYfkRXL4Oa vyvH/KeKRlL0pqEv8fi/GIClgm3W/Rox6xFoBeNuhlmpNKI/1vvrYQJ/82TmbKfMQEqB LY4UcCD7KUx3wFNS7yT/yBDsWg340a7wHoU59KKM8XMrjMqdh5PE/K2Ht+3bYxV9bWhp mKStlZNaPkxje4jxy1tNaaZ/Wag6A4P7Hsq28xQzI6xMEslrdYfqsjUEkl0yuQQipUi/ X+qQ== X-Forwarded-Encrypted: i=1; AHgh+Rri1s2HkaWOG/8r3p8vUvz7aJIGeFb6GxqGHDmQWzIOJZPItrM8mrT8yjObcBGsd/XmwUkJsbDrS8t+JLY=@vger.kernel.org X-Gm-Message-State: AOJu0YzittpR7RETm4qjuglmpOORq/1PTZjRUrMC5tyHUGSXkUy6iHuN d0dUPKw3DXc/ToKHBfP/wNqif4A2TfDvrdqI/+kRayllX6dgjGlYighR X-Gm-Gg: AR+sD12qVgyHZw2lH/rXmrrhVaGfUTq3GOhPOZnBWiFrUPtEzLfrA+kulT2hz+mK0ZB 0/xZziAz/6aDkOCAWp02CFYR4HJcESlFG+sRl4kfL1z5GH72Trzl5ML8mkwkk6GXe0o7we2HyuM NXOprBvS2cfIf1ekqWidZ1uiJemsN5Tdid7YkTFwKYvF2ieD4kvZfYMUWxXT8lLVQ+7gry2QR1K EfQ6lmyOP82lmownH7rUwFt73GquYorMj8VICIYiQV5fj+IHzmPflmDoG7PNy50RFfwIzzpp272 el0cXWxEwOM9+0PyK2rgBu+5jkCBB1wRKcHQ2v9Z2YLFubROWyttriyJHIiYL04m1mid8bvhTpP r07yCqk95pxMBtKMTXO8QeMKX95i+f/vVfBnQrIzFiYUXGw45HBsf7PI9g+074fv5qxTGDyPtBQ KE9AWK03nsY5ihlGQ+W2MO5TEVs2AiheHWLvfAhMj29Xo1nWMlx29x2unWVdT1oh8zdYShoAvpS Xz0TrcL+XEBTVCzuCVl X-Received: by 2002:a05:6123:a1:b0:5bf:d2c7:c481 with SMTP id 71dfb90a1353d-5c2da0e126bmr1430338e0c.7.1784820135565; Thu, 23 Jul 2026 08:22:15 -0700 (PDT) Received: from user.intranet.unl (fweduroam249.unl.edu.ar. [190.122.249.184]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5c2c648704dsm6118065e0c.12.2026.07.23.08.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 08:22:14 -0700 (PDT) From: Tomas Chimenti To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, hansg@kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, andy@kernel.org, gregkh@linuxfoundation.org Cc: ~lkcamp/patches@lists.sr.ht, koike@igalia.com, Tomas Chimenti Subject: [PATCH] media: atomisp: Remove useless return statement Date: Thu, 23 Jul 2026 12:21:46 -0300 Message-Id: <20260723152146.86978-1-tach.365@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch error=20 "WARNING: void function return statements are not generally useful" Signed-off-by: Tomas Chimenti --- Hello This is my first patch, any feedback would be very welcome. Thanks --- .../pci/runtime/inputfifo/src/inputfifo.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputf= ifo.c b/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c index 8e1efeb6372c..f0dcd839e33b 100644 --- a/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c +++ b/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c @@ -88,7 +88,6 @@ _sh_css_fifo_snd(unsigned int token) while (!can_event_send_token(STR2MIPI_EVENT_ID)) udelay(1); event_send_token(STR2MIPI_EVENT_ID, token); - return; } =20 static void inputfifo_send_data_a( @@ -98,7 +97,6 @@ static void inputfifo_send_data_a( unsigned int token =3D (1 << HIVE_STR_TO_MIPI_VALID_A_BIT) | (data << HIVE_STR_TO_MIPI_DATA_A_LSB); _sh_css_fifo_snd(token); - return; } =20 static void inputfifo_send_data_b( @@ -108,7 +106,6 @@ static void inputfifo_send_data_b( unsigned int token =3D (1 << HIVE_STR_TO_MIPI_VALID_B_BIT) | (data << _HIVE_STR_TO_MIPI_DATA_B_LSB); _sh_css_fifo_snd(token); - return; } =20 static void inputfifo_send_data( @@ -121,7 +118,6 @@ static void inputfifo_send_data( (a << HIVE_STR_TO_MIPI_DATA_A_LSB) | (b << _HIVE_STR_TO_MIPI_DATA_B_LSB)); _sh_css_fifo_snd(token); - return; } =20 static void inputfifo_send_sol(void) @@ -131,7 +127,6 @@ static void inputfifo_send_sol(void) 1 << HIVE_STR_TO_MIPI_SOL_BIT); =20 _sh_css_fifo_snd(token); - return; } =20 static void inputfifo_send_eol(void) @@ -140,7 +135,6 @@ static void inputfifo_send_eol(void) hrt_data token =3D inputfifo_wrap_marker( 1 << HIVE_STR_TO_MIPI_EOL_BIT); _sh_css_fifo_snd(token); - return; } =20 static void inputfifo_send_sof(void) @@ -150,7 +144,6 @@ static void inputfifo_send_sof(void) 1 << HIVE_STR_TO_MIPI_SOF_BIT); =20 _sh_css_fifo_snd(token); - return; } =20 static void inputfifo_send_eof(void) @@ -159,7 +152,6 @@ static void inputfifo_send_eof(void) hrt_data token =3D inputfifo_wrap_marker( 1 << HIVE_STR_TO_MIPI_EOF_BIT); _sh_css_fifo_snd(token); - return; } =20 static void inputfifo_send_ch_id_and_fmt_type( @@ -177,7 +169,6 @@ static void inputfifo_send_ch_id_and_fmt_type( */ token =3D inputfifo_wrap_marker(0); _sh_css_fifo_snd(token); - return; } =20 static void inputfifo_send_empty_token(void) @@ -186,7 +177,6 @@ static void inputfifo_send_empty_token(void) hrt_data token =3D inputfifo_wrap_marker(0); =20 _sh_css_fifo_snd(token); - return; } =20 static void inputfifo_start_frame( @@ -196,7 +186,6 @@ static void inputfifo_start_frame( { inputfifo_send_ch_id_and_fmt_type(ch_id, fmt_type); inputfifo_send_sof(); - return; } =20 static void inputfifo_end_frame( @@ -207,7 +196,6 @@ static void inputfifo_end_frame( for (i =3D 0; i < marker_cycles; i++) inputfifo_send_empty_token(); inputfifo_send_eof(); - return; } =20 static void inputfifo_send_line2( @@ -297,7 +285,6 @@ static void inputfifo_send_line2( for (i =3D 0; i < hblank_cycles; i++) inputfifo_send_empty_token(); inputfifo_send_eol(); - return; } =20 static void @@ -377,7 +364,6 @@ static void inputfifo_send_frame( } } inputfifo_end_frame(marker_cycles); - return; } =20 static enum inputfifo_mipi_data_type inputfifo_determine_type( @@ -453,7 +439,6 @@ void ia_css_inputfifo_start_frame( s2mi->streaming =3D true; =20 inputfifo_start_frame(ch_id, s2mi->fmt_type); - return; } =20 void ia_css_inputfifo_send_line( @@ -516,5 +501,4 @@ void ia_css_inputfifo_end_frame( inputfifo_end_frame(s2mi->marker_cycles); =20 s2mi->streaming =3D false; - return; } --=20 2.39.5