From nobody Fri Jul 24 21:29:09 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA35F42EEAA for ; Thu, 23 Jul 2026 12:28:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784809705; cv=none; b=ifdtFKSV1xp419iwvuFxJgAurOURXN1OHyZoDiuVRYrrZrSYtwf7R99xekA2qju3eTisNhwAqdp3YsUdiQ+qEWRgwXiIHRgWLOG47EfNqtFaXk5665S1WjNQgbv9Gc7AFokNIYZYXLQUqCVWvGBpFYEUZGgMIGSd4OumLLnmiHM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784809705; c=relaxed/simple; bh=qJeWLqqHGhywHLzf/EYgOC1kFld80TPrXuXaJUKz/v0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PRzpfZHjEfsTcAuzIOoXj+Xope+OL8uAytk4aGHFNjBxiBxSm03O1HFd20Nm6hm3dDd/IZgtmnTfV2OY2DvsiBgmJsm1bho817aei7gHUtq8O9SFEeuniX280Br9oLF0H+X9H1YVTohbPfYCYKGshpi5S75IIO41SbkYApfZiYY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PhIv7P2h; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PhIv7P2h" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-472326ca506so425324f8f.2 for ; Thu, 23 Jul 2026 05:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784809702; x=1785414502; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kHSxDwM0Y6FUMCJyC98ds2ox0gHcqUAID04qqyOi0zE=; b=PhIv7P2hbQza2paTo+jnAX9VUHTpoWyg/QmI4r/scIuMu5g9GtcTOxjpm6kMy0511h CxHI2uwrHLy/sHY9d14X7ESSbuuRcN1gqfGvOLiaxzm0JYBqbrIohhM0CYWNDPH1ZxZT IFKLSTMH0rRqPy+TrxFOq4xr1/6uE3fvGcWwsHoOlRMUxHQL0rpqVJCPzMfJOzU6Xy7o ZnhCYK4wpllKk0/4cIltdGChwGYPZxxNtJUNRDYoRcCKT3WMqt6hdFXGveAI1jNyBLyW qEinVfhpGsbxz8F5tqhmbU/ACIY50gc9SZzvp8c8/QX6G62C9uG1wgbZDCWFnoISJbDw w/1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784809702; x=1785414502; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kHSxDwM0Y6FUMCJyC98ds2ox0gHcqUAID04qqyOi0zE=; b=GVrS/fyFWeRWi6BOvsMUoyk9nn8k8fOmzXDfLhaddL+bl5VCeI4Kts97f5cOvuHvqj R0DDSUTUd071UonBQrRAbN/e484XTTNgRzkCBfXgN9/Niop0AXzfsv4eeHd9NFdAjOQB +AP5xaVbLIx8lXa9m7ARA0mmYCbgkIW960STYYWoHxZ/ErOPnqErNLRj/gv0H84Zk+sc 2k//9vI3X769kM1QGeT10OweV1PKUW++ITqZJRPV/4S/9mmLWoJPb84CSqMW482P3Pog Blrr4MGIfIbbobci6Wx1OlYHFHXFGpjsNxbDJAj7z9HwpFuSpFlnqUWf2TlbWFHia9p/ QWUw== X-Forwarded-Encrypted: i=1; AHgh+RoBjEr9w2diqJM9pij+ap5fcgij7fdTsVkjdgZk7FSYNjkdEplL/YLdopCoolMdEqVowB/JWrlE/oYsd2o=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0zWapDr6zm1gdikebQ9aIcdq7QtUjI7yXhfZfdQg6Z9F6IoOX UfS81Np0BAH0QTfBkEYHuoDC3RUidFzT2Zoo6IpyTpe9KSO7an5EtlIg X-Gm-Gg: AR+sD13gd0LQ/Y9T/TLtLX77UtD/+skWXMjoZsr86m+UdjX6p4sbXPPZuzN1PgoouC5 lTMqguPccWKIvEb4Bt6TN7Ih3RNmM8kMXXtohBHvUz2UUSfcKCIAufEs/HvxWKfRmqajdHL/iBe +DvfOqOcKsmH1hNP84dp9a1HNNcA2OPjRVthSVC0zgs+gIFqHJeGxzQ4jtRMaFg0e/auvjlp5NX vssRNMVNbLDkblbq9apqTNdCiWT9t7WSAWwHZHas2fJ6DpJhHs7XeU6oQitBMHrvhLffuzlgPTA Mi1/2/eAK+vDnxFJNjxiQY7Wd9dGszSNJLPBxLIbnxo9oANzkeUSMTmDS6oli+7vqG140Iwqszd CoEBrkINEG+SFNhbQeB1yc/55basXBFibc9hsuPX/UGXNRUIhOSqeKtEPEAMp1mplDg2YSRj6o1 vxRgmYtt7hCoPnSZ7t4YH8p17wu4iER39RV0vX9idjTpO6ym3/1A/5QSpGBxOTiyG9HhWpVhU2O WYh X-Received: by 2002:a05:600c:a218:b0:495:6788:c229 with SMTP id 5b1f17b1804b1-49573cb99bamr18898445e9.4.1784809701703; Thu, 23 Jul 2026 05:28:21 -0700 (PDT) Received: from nixos-office (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956a509901sm255799575e9.8.2026.07.23.05.28.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 05:28:21 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: deller@gmx.de Cc: tzimmermann@suse.de, wei.liu@kernel.org, ptsm@linux.microsoft.com, arnd@arndb.de, u.kleine-koenig@baylibre.com, hsukrut3@gmail.com, rob.github@jumpstation.co.uk, enelsonmoore@gmail.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Julian Braha Subject: [PATCH v2] fbdev: replace dead select with dependency Date: Thu, 23 Jul 2026 13:28:18 +0100 Message-ID: <20260723122818.437802-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 'select' does not work on config options in a 'choice', so currently it is possible to enable FB_MB862XX_LIME without FB_LITTLE_ENDIAN. We cannot replace the 'select FB_LITTLE_ENDIAN' without also changing FB_FOREIGN_ENDIAN from 'select' to 'depends on', otherwise we will get a recursive dependency. Since the default choice is FB_BOTH_ENDIAN, let's use: 'depends on FB_LITTLE_ENDIAN || FB_BOTH_ENDIAN' to avoid breaking defconfig. This dead select was found by kconfirm, a static analysis tool for Kconfig. Suggested-by: Arnd Bergmann Signed-off-by: Julian Braha --- Changes since v1: support the default FB_BOTH_ENDIAN Link: https://lore.kernel.org/all/20260722220023.196029-1-julianbraha@gmail.com/ --- drivers/video/fbdev/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 085d3a202148..e8cd8cb76874 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -1717,8 +1717,7 @@ config FB_MB862XX_PCI_GDC config FB_MB862XX_LIME bool "Lime GDC" depends on OF && PPC - select FB_FOREIGN_ENDIAN - select FB_LITTLE_ENDIAN + depends on FB_LITTLE_ENDIAN || FB_BOTH_ENDIAN help Framebuffer support for Fujitsu Lime GDC on host CPU bus. =20 --=20 2.54.0