From nobody Fri Jul 24 21:30:26 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A17E447D952 for ; Thu, 23 Jul 2026 12:01:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784808094; cv=none; b=M3yujMfSyVLFFT8O7lvyIwyMiNprh7z6h9HbtqrJpVGnqmU58/m1wLbTuR2J/O1x1eJ7g7QNmfngvzRMozneGf4CJm8/Ahr5CvN6KC6xYog9ufZjDwL82ivxkSU/PHx9bsR5Zk1Q4O4m+O6iY3HE3nJFSZv7DDZT/RMNRXxjq/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784808094; c=relaxed/simple; bh=JMgzKQ8MAgEi6SWX+W+QcB/WyDSK3011AnCL9gzD17M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GrgZnB86oUvfW0g1ySMYC83L0miXh773vEan0ReQne9KMH41WTVbYJ/HQ/U9KYXJD2YpNcVl6U/6wBMdydKPaKxKSzknLjq07R0D+Vpxs5vw9LU7Q9rJ2y2AferMiGuv59nRgS0/ex6MNSUDnue5VG+DZ4Vij2+8+abVSeBb9JI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=Q/PW0kTb; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="Q/PW0kTb" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38e071ed6aeso434770a91.0 for ; Thu, 23 Jul 2026 05:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1784808088; x=1785412888; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=vjRa0DTFc4Jmbe+bh5TZiQEHTGpASDC3/yAm/lBjtiM=; b=Q/PW0kTbyT9wpVdDmH4xKEwY/wfV/w04XJSsB/WAQz4XgxN3g9tCrfCw5jzlZ2CQW1 m4pUHlB03rYR0QEqWwad/qbYhCcjDW+t4ovmQDO7sok453u9ty56YpE7yODUUmEO6dLy lv5cY+CY7rP1OMoh2BjazyfP1iq4h/vV0l669kAu6Pk7TbcQEmGxYdM1IDBj2SJ4QOyV qEcev4LQLDUDmYT4BwzS2VWGqHBUc8Vl++UuAB4OVdjJlkrIrT2Vfz4J4wJPTgrId4tK CWiPQp7lt+L/6gj9UVKfhY/GHo4WAamKNZIUXz/0cFx4YRmilEoOSVIfmAWR9oKOdUIQ Sv7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784808088; x=1785412888; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vjRa0DTFc4Jmbe+bh5TZiQEHTGpASDC3/yAm/lBjtiM=; b=T+yLJYZBEjiiszsdVWW4LTcv0p52R6qriPE8uAkTPKc4pfcyevrvDmsCWahr7P2+gf ILLCtkzLtaxts7ImLZyJjqavweSQChldAr3Ah5r8ORNW2q+6q6PnhbM9oPXwDeoyerHA 2TyPm4jpTbhA4WjnVOnK+CaI6u9kHLT54UIvCKVTaifDJYUZPeiYAcoweOYU+50yxnLh 8OTj9UULT/gNRGqfRxuqW8oSsramSGfi8JpSiA0OHFrF5yzulou6/SPGxYKF5muYQ9wg 68HcgnxykcKOK1GLs8XILMCQZkyumaeEATunWYB4FtSJxppZstq6YFCpbst6Hr107/tV DSdA== X-Forwarded-Encrypted: i=1; AHgh+RrdMuStth3/9LVLEkggZcHLvOnu1d2c2yqngy7aClrjAdXKFZ1GAPBPOho6quCUVzTP7W3pn9RAb8GH6zY=@vger.kernel.org X-Gm-Message-State: AOJu0YyvGuqL5B2x6D6Nx248Zz68kSGVdxdiKnPZ4sspACgQ3EHc5N+N 2nU6Fbz0FmXmMaP7GMlN+RJsYpUCeT0tFBB4fHwXp7o0JhOPlEYai41EAOabK1sLO8U= X-Gm-Gg: AR+sD113MOweukEiPfRWw1PZJb+6+TXVKRnT2C7KwJ/Ei3b/BOCYsrb8X4TVVGCPzaw yw8p4XB9wBikZrifKMTo3+LQOqwOlorV3UtNh09m1eWx3YO5yRg4khKU5YV53Y3Ik7scjMEdbVj RQErr/S9UJ9tqNNrgAGwMmyP1B1CkoQ19q5XHWLoU6IImjwvi63eVQfbGMhPzV2MwajSpAuz38s z3eyxi+0kj4seea6pC8MHSFzN4bQlYV14KUj7dkcLtTEhZxWLOVXsBMD288zPJ/otMwNOhp9vFM c3wftvicNG2sMksTeOHVC0QepXn+RzuixjzjCHmDbo96ktnzIWtlGd5z52au2XaWDJ0x9jMsCtL /kO7ijujenoy+/PAXYzzE15d7OckL7hCUVViwqNuYhgC8jNtOnWDNGiFYCgnMdf69cJDuSO159p RM5qiSeY+ACq8nqzji5eoQVbZaxi2FxXjYiULjmvmcczTAdzblXi1dvsYBKwh9UifTOA35OtgcT 3Su4gXSgBKNWrq/ZUhmVykDwlRaGU6Y X-Received: by 2002:a17:90b:518c:b0:387:e0db:3d8d with SMTP id 98e67ed59e1d1-38ec66586edmr2599784a91.40.1784808087825; Thu, 23 Jul 2026 05:01:27 -0700 (PDT) Received: from Metius.iitm.ac.in ([103.158.43.43]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-13d130a7738sm16180640c88.9.2026.07.23.05.01.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 05:01:27 -0700 (PDT) From: Abdun Nihaal To: pkshih@realtek.com Cc: Abdun Nihaal , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] wifi: rtlwifi: pci: fix error path in rtl_pci_probe() Date: Thu, 23 Jul 2026 17:31:15 +0530 Message-ID: <20260723120118.145383-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the last error path in rtl_pci_probe(), the cleanup functions are skipped due to a wrong goto label. Moreover, the successful call to rtl_init_rfkill(), ieee80211_register_hw(), rtl_debug_add_one() have to be reverted. Fix this issue by updating the labels and adding the relevant cleanup functions to the last error path. Fixes: 0c8173385e54 ("rtl8192ce: Add new driver") Signed-off-by: Abdun Nihaal Acked-by: Ping-Ke Shih --- Compile tested only. Issue found using static analysis. v1->v2: - Added a call to rtl_debug_remove_one() in the error path, as suggested by Ping-Ke Shih, to free the debugfs resources which were successfully allocated in that path. - Updated commit message to mention rtl_debug_add_one() v1 link: https://patchwork.kernel.org/project/linux-wireless/patch/20260722= 115217.131458-1-nihaal@cse.iitm.ac.in/ drivers/net/wireless/realtek/rtlwifi/pci.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c b/drivers/net/wirel= ess/realtek/rtlwifi/pci.c index 73018a0498b4..de74ff8f6eee 100644 --- a/drivers/net/wireless/realtek/rtlwifi/pci.c +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c @@ -2227,13 +2227,17 @@ int rtl_pci_probe(struct pci_dev *pdev, rtl_dbg(rtlpriv, COMP_INIT, DBG_DMESG, "%s: failed to register IRQ handler\n", wiphy_name(hw->wiphy)); - goto fail3; + goto fail6; } rtlpci->irq_alloc =3D 1; =20 set_bit(RTL_STATUS_INTERFACE_START, &rtlpriv->status); return 0; =20 +fail6: + rtl_deinit_rfkill(hw); + rtl_debug_remove_one(hw); + ieee80211_unregister_hw(hw); fail5: rtl_pci_deinit(hw); fail4: --=20 2.43.0